From nobody Sat Jun 20 01:53:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58385C433F5 for ; Thu, 24 Mar 2022 08:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348846AbiCXIJV (ORCPT ); Thu, 24 Mar 2022 04:09:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348808AbiCXIJI (ORCPT ); Thu, 24 Mar 2022 04:09:08 -0400 Received: from m12-16.163.com (m12-16.163.com [220.181.12.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DAC524D257 for ; Thu, 24 Mar 2022 01:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=X2PkbZuSv9BM7e1K9t z2R+SePk62dCZezpam7namyVY=; b=RtMkhZh21Q/LFBYdsgq3eTqWEKIu73tDrS u9hQiWZyU4fA3zf3inWnhUrh8H0HmfraMpgu0W3LIAaSHCOR5QkVM3HujlHlKzmB 5oD2rdvKPqmKtjsrl8peyXYLJHV9DpMGUYsb92E3+wd8kVxDzuzMYde8ZVyPzWBE vLr7M+/9Y= Received: from localhost (unknown [159.226.95.33]) by smtp12 (Coremail) with SMTP id EMCowAAn5B1iJjxiNR7tAg--.21428S2; Thu, 24 Mar 2022 16:05:54 +0800 (CST) From: QintaoShen To: dinguyen@kernel.org Cc: linux-kernel@vger.kernel.org, QintaoShen Subject: [PATCH v1] clk: socfpga: Fix a potential memory leak for kzalloc() Date: Thu, 24 Mar 2022 16:05:53 +0800 Message-Id: <1648109153-32756-1-git-send-email-unSimple1993@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EMCowAAn5B1iJjxiNR7tAg--.21428S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtry3JrykWw1fZryrWF1kuFg_yoW3Xwc_Wa 4jgr97Wwn8CrWUCr1qy3Wavry0kFs5urn5XFnaqw43Ja4ruF1UAFW2vrs5Wr1xKrW09ry3 Zw1UAr17Z39rCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7VUUzBTUUUUUU== X-Originating-IP: [159.226.95.33] X-CM-SenderInfo: 5xqvxz5sohimizt6il2tof0z/1tbiNALNH1aD-KonPgAAs+ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" kfree() is missing on an error path to free the memory allocated by kzalloc= (). Signed-off-by: QintaoShen --- drivers/clk/socfpga/clk-gate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/socfpga/clk-gate.c b/drivers/clk/socfpga/clk-gate.c index 53d6e3e..0ca5e00 100644 --- a/drivers/clk/socfpga/clk-gate.c +++ b/drivers/clk/socfpga/clk-gate.c @@ -188,8 +188,10 @@ void __init socfpga_gate_init(struct device_node *node) return; =20 ops =3D kmemdup(&gateclk_ops, sizeof(gateclk_ops), GFP_KERNEL); - if (WARN_ON(!ops)) + if (WARN_ON(!ops)) { + kfree(socfpga_clk); return; + } =20 rc =3D of_property_read_u32_array(node, "clk-gate", clk_gate, 2); if (rc) --=20 2.7.4