From nobody Mon Jun 22 20:13:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E78C433FE for ; Thu, 17 Mar 2022 15:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235908AbiCQPfX (ORCPT ); Thu, 17 Mar 2022 11:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234996AbiCQPfR (ORCPT ); Thu, 17 Mar 2022 11:35:17 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C03B91788F2 for ; Thu, 17 Mar 2022 08:34:00 -0700 (PDT) Date: Thu, 17 Mar 2022 15:33:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1647531239; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmfvRc9g5bLRQcU5mUbsyU2skozRH90l+W7VUJrSNkY=; b=3KDAXI9s6uOMQ6ymG0XbP6WqrAVXuBfzEiFQ8WfJA/aSa90JJkcRifFrErBEkPEfOjprKJ SlE9xgzOLLkixm8CVimEqOdoRJUm27y1RdjBNHQBpNfA6X505aFgiCi8yM57Z63BFHVsRk rnyNbLCgts1EJTLsgnlw2RG3RJF6jajoZzBT/TmEajct1dlVzL44jS35f2XmhLuqT12/Uk FFKgInTIm9sS4JtIJGIeozufm8LxbQx0g+35Yn8fQWt1aJ51pgg5+Yt/1eInJnAkQZ2sjO TB13+z+DQXAZDYUR3pqjbNDRmCMW79QAYKizVenZiS2cvGcr+uYm6mDzcB5IKA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1647531239; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmfvRc9g5bLRQcU5mUbsyU2skozRH90l+W7VUJrSNkY=; b=lbYtxVNniht6eJQCMRQpXwotBUYvhGLi/MBcXGmn9mQjEQk2aySGIk8F2rZloqj4N7da7K wrHqypG7ETG6N8DQ== From: "irqchip-bot for Yang Yingliang" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/irq-qcom-mpm: fix return value check in qcom_mpm_init() Cc: Hulk Robot , Yang Yingliang , Shawn Guo , Marc Zyngier , tglx@linutronix.de In-Reply-To: <20220316025100.1758413-1-yangyingliang@huawei.com> References: <20220316025100.1758413-1-yangyingliang@huawei.com> MIME-Version: 1.0 Message-ID: <164753123809.389.16541550679620677780.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-next branch of ir= qchip: Commit-ID: 294aee8ab6cb5d44cde4defcda43324a25c64118 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/294aee8ab6cb5d44cde4defcda43324a25c64118 Author: Yang Yingliang AuthorDate: Wed, 16 Mar 2022 10:51:00 +08:00 Committer: Marc Zyngier CommitterDate: Thu, 17 Mar 2022 15:30:35=20 irqchip/irq-qcom-mpm: fix return value check in qcom_mpm_init() If devm_platform_ioremap_resource() fails, it never returns NULL, replace NULL check with IS_ERR(). Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Acked-by: Shawn Guo Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220316025100.1758413-1-yangyingliang@huaw= ei.com --- drivers/irqchip/irq-qcom-mpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c index eea5a75..d306146 100644 --- a/drivers/irqchip/irq-qcom-mpm.c +++ b/drivers/irqchip/irq-qcom-mpm.c @@ -375,7 +375,7 @@ static int qcom_mpm_init(struct device_node *np, struct= device_node *parent) raw_spin_lock_init(&priv->lock); =20 priv->base =3D devm_platform_ioremap_resource(pdev, 0); - if (!priv->base) + if (IS_ERR(priv->base)) return PTR_ERR(priv->base); =20 for (i =3D 0; i < priv->reg_stride; i++) {