From nobody Mon Jun 22 20:33:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 451B5C433EF for ; Thu, 17 Mar 2022 09:24:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231836AbiCQJ0M (ORCPT ); Thu, 17 Mar 2022 05:26:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbiCQJ0K (ORCPT ); Thu, 17 Mar 2022 05:26:10 -0400 Received: from mail.meizu.com (edge05.meizu.com [157.122.146.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78C35143C5B for ; Thu, 17 Mar 2022 02:24:52 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 17 Mar 2022 17:24:51 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 17 Mar 2022 17:24:50 +0800 From: Haowen Bai To: , , CC: , , "Haowen Bai" Subject: [PATCH] macintosh: macio-adb: Fix warning comparing pointer to 0 Date: Thu, 17 Mar 2022 17:24:49 +0800 Message-ID: <1647509089-4280-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai --- drivers/macintosh/macio-adb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/macintosh/macio-adb.c b/drivers/macintosh/macio-adb.c index dc634c2..b7d287a 100644 --- a/drivers/macintosh/macio-adb.c +++ b/drivers/macintosh/macio-adb.c @@ -97,7 +97,7 @@ int macio_init(void) unsigned int irq; =20 adbs =3D of_find_compatible_node(NULL, "adb", "chrp,adb0"); - if (adbs =3D=3D 0) + if (!adbs) return -ENXIO; =20 if (of_address_to_resource(adbs, 0, &r)) { @@ -180,7 +180,7 @@ static int macio_send_request(struct adb_request *req, = int sync) req->reply_len =3D 0; =20 spin_lock_irqsave(&macio_lock, flags); - if (current_req !=3D 0) { + if (current_req) { last_req->next =3D req; last_req =3D req; } else { @@ -210,7 +210,8 @@ static irqreturn_t macio_adb_interrupt(int irq, void *a= rg) spin_lock(&macio_lock); if (in_8(&adb->intr.r) & TAG) { handled =3D 1; - if ((req =3D current_req) !=3D 0) { + req =3D current_req; + if (req) { /* put the current request in */ for (i =3D 0; i < req->nbytes; ++i) out_8(&adb->data[i].r, req->data[i]); --=20 2.7.4