From nobody Mon Jun 22 20:34:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9506DC433EF for ; Thu, 17 Mar 2022 02:40:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358516AbiCQCmK (ORCPT ); Wed, 16 Mar 2022 22:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358517AbiCQCmE (ORCPT ); Wed, 16 Mar 2022 22:42:04 -0400 Received: from mail.meizu.com (unknown [14.29.68.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F318320F5A for ; Wed, 16 Mar 2022 19:40:40 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail04.meizu.com (172.16.1.16) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 17 Mar 2022 10:40:40 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 17 Mar 2022 10:40:38 +0800 From: Haowen Bai To: , , CC: , , "Haowen Bai" Subject: [PATCH] macintosh: via-cuda: Fix warning comparing pointer to 0 Date: Thu, 17 Mar 2022 10:40:37 +0800 Message-ID: <1647484837-14352-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai --- drivers/macintosh/via-cuda.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/macintosh/via-cuda.c b/drivers/macintosh/via-cuda.c index cd267392..05a3cd9 100644 --- a/drivers/macintosh/via-cuda.c +++ b/drivers/macintosh/via-cuda.c @@ -236,10 +236,10 @@ int __init find_via_cuda(void) const u32 *reg; int err; =20 - if (vias !=3D 0) + if (vias) return 1; vias =3D of_find_node_by_name(NULL, "via-cuda"); - if (vias =3D=3D 0) + if (!vias) return 0; =20 reg =3D of_get_property(vias, "reg", NULL); @@ -517,7 +517,7 @@ cuda_write(struct adb_request *req) req->reply_len =3D 0; =20 spin_lock_irqsave(&cuda_lock, flags); - if (current_req !=3D 0) { + if (current_req) { last_req->next =3D req; last_req =3D req; } else { --=20 2.7.4