From nobody Mon Jun 22 20:27:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBA5C433F5 for ; Thu, 17 Mar 2022 02:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358455AbiCQCeD (ORCPT ); Wed, 16 Mar 2022 22:34:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358444AbiCQCeA (ORCPT ); Wed, 16 Mar 2022 22:34:00 -0400 Received: from mail.meizu.com (edge01.meizu.com [14.29.68.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 436C720190 for ; Wed, 16 Mar 2022 19:32:43 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail04.meizu.com (172.16.1.16) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 17 Mar 2022 10:32:42 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 17 Mar 2022 10:32:40 +0800 From: Haowen Bai To: , , CC: , , "Haowen Bai" Subject: [PATCH] macintosh: windfarm_pm81: Fix warning comparing pointer to 0 Date: Thu, 17 Mar 2022 10:32:39 +0800 Message-ID: <1647484359-12402-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai --- drivers/macintosh/windfarm_pm81.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/windfarm_pm81.c b/drivers/macintosh/windfarm= _pm81.c index 82c67a4..1dfced5 100644 --- a/drivers/macintosh/windfarm_pm81.c +++ b/drivers/macintosh/windfarm_pm81.c @@ -400,7 +400,7 @@ static void wf_smu_create_cpu_fans(void) =20 /* First, locate the PID params in SMU SBD */ hdr =3D smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL); - if (hdr =3D=3D 0) { + if (!hdr) { printk(KERN_WARNING "windfarm: CPU PID fan config not found " "max fan speed\n"); goto fail; @@ -704,7 +704,7 @@ static int wf_init_pm(void) const struct smu_sdbp_header *hdr; =20 hdr =3D smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL); - if (hdr !=3D 0) { + if (hdr) { struct smu_sdbp_sensortree *st =3D (struct smu_sdbp_sensortree *)&hdr[1]; wf_smu_mach_model =3D st->model_id; --=20 2.7.4