From nobody Mon Jun 22 23:58:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D2FC433F5 for ; Tue, 15 Mar 2022 10:44:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347289AbiCOKp3 (ORCPT ); Tue, 15 Mar 2022 06:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347224AbiCOKo5 (ORCPT ); Tue, 15 Mar 2022 06:44:57 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D678C2F028; Tue, 15 Mar 2022 03:43:45 -0700 (PDT) Date: Tue, 15 Mar 2022 10:43:43 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1647341024; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=syG+zqh4Q+3vlw+qKBz98+af1fOexGGxDC8UCaFHYcQ=; b=lAeH6VWQyN6PLvVfZVc89hm/mb3ZGQYHrJ1HfOB6R7OeS2az93Bs+eIQQHoXME7EF0FhRI HSY8t051FPLmEiLkk8l9TuuzOyaZ5a3hpSSE7zY+T4MWu4ocTeSrXiVtcJOjx5pUKeGjVq 0052mr9/82FyjLwtDUa1xrCkYEEdYaBjGXE6pAe3Mf0LGG9THaYQyFDVnmD+5ITSgm/48m dXRXrv54Oe/NZKxXyOSkvs5RTU4nyrpRbtsnmzjLcTG+2g3j++QZHJvWlgO5hlyPnlUJg6 hBnxmGwT5VMREOMyg2ua/X1GTNBt04XNqL1pdlUjGEIzFiBG2jFcQTKvox9JgQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1647341024; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=syG+zqh4Q+3vlw+qKBz98+af1fOexGGxDC8UCaFHYcQ=; b=275fFMT8+OFPgj54EOXLaHV+AyRzUOAcIzeg/wGKvk4v8jaQnVj+xDXtaXn/C2SSoAdxWl aNM5SHlMIq3nywCw== From: "tip-bot2 for Peter Zijlstra" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/core] x86: Annotate idtentry_df() Cc: "Peter Zijlstra (Intel)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: MIME-Version: 1.0 Message-ID: <164734102342.16921.2650710011277528758.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/core branch of tip: Commit-ID: 3515899bef545fc5b5f6b865e080bfe4c9a92a41 Gitweb: https://git.kernel.org/tip/3515899bef545fc5b5f6b865e080bfe4c= 9a92a41 Author: Peter Zijlstra AuthorDate: Mon, 14 Mar 2022 18:07:30 +01:00 Committer: Peter Zijlstra CommitterDate: Tue, 15 Mar 2022 10:32:45 +01:00 x86: Annotate idtentry_df() Without CONFIG_X86_ESPFIX64 exc_double_fault() is noreturn and objtool is clever enough to figure that out. vmlinux.o: warning: objtool: asm_exc_double_fault()+0x22: unreachable instr= uction 0000000000001260 : 1260: f3 0f 1e fa endbr64 1264: 90 nop 1265: 90 nop 1266: 90 nop 1267: e8 84 03 00 00 call 15f0 126c: 48 89 e7 mov %rsp,%rdi 126f: 48 8b 74 24 78 mov 0x78(%rsp),%rsi 1274: 48 c7 44 24 78 ff ff ff ff movq $0xffffffffffffffff,0x78= (%rsp) 127d: e8 00 00 00 00 call 1282 = 127e: R_X86_64_PLT32 exc_double_fault-0x4 1282: e9 09 04 00 00 jmp 1690 Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/Yi9gOW9f1GGwwUD6@hirez.programming.kicks-as= s.net --- arch/x86/entry/entry_64.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 6e53991..4faac48 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -551,6 +551,9 @@ SYM_CODE_START(\asmsym) movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ call \cfunc =20 + /* For some configurations \cfunc ends up being a noreturn. */ + REACHABLE + jmp paranoid_exit =20 _ASM_NOKPROBE(\asmsym)