From nobody Tue Jun 23 03:14:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E303C433EF for ; Fri, 11 Mar 2022 09:23:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347459AbiCKJY3 (ORCPT ); Fri, 11 Mar 2022 04:24:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230400AbiCKJY2 (ORCPT ); Fri, 11 Mar 2022 04:24:28 -0500 Received: from mail.meizu.com (edge07.meizu.com [112.91.151.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B034850066 for ; Fri, 11 Mar 2022 01:23:22 -0800 (PST) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail11.meizu.com (172.16.1.15) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 11 Mar 2022 17:23:11 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Fri, 11 Mar 2022 17:23:08 +0800 From: Haowen Bai To: , , CC: , , "Haowen Bai" Subject: [PATCH] staging: r8188eu: Directly return 0 instead of using local ret variable Date: Fri, 11 Mar 2022 17:23:06 +0800 Message-ID: <1646990586-14794-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fixes coccinelle warning: drivers/staging/r8188eu/hal/rtl8188eu_xmit.c:152:5-9: Unneeded variable: "p= ull". Return "0" on line 302 Signed-off-by: Haowen Bai --- drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging= /r8188eu/hal/rtl8188eu_xmit.c index 293541d..6ab89f8 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -149,7 +149,6 @@ static void fill_txdesc_phy(struct pkt_attrib *pattrib,= __le32 *pdw) =20 static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, = u8 bagg_pkt) { - int pull =3D 0; uint qsel; u8 data_rate, pwr_status, offset; struct adapter *adapt =3D pxmitframe->padapter; @@ -299,7 +298,8 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe,= u8 *pmem, s32 sz, u8 bag ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id); =20 rtl8188eu_cal_txdesc_chksum(ptxdesc); - return pull; + + return 0; } =20 /* for non-agg data frame or management frame */ --=20 2.7.4