From nobody Tue Jun 23 05:10:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB0E3C433FE for ; Thu, 10 Mar 2022 10:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240005AbiCJKb7 (ORCPT ); Thu, 10 Mar 2022 05:31:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233183AbiCJKb5 (ORCPT ); Thu, 10 Mar 2022 05:31:57 -0500 X-Greylist: delayed 64 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 10 Mar 2022 02:30:53 PST Received: from mail.meizu.com (edge07.meizu.com [112.91.151.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DA28139109 for ; Thu, 10 Mar 2022 02:30:53 -0800 (PST) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail11.meizu.com (172.16.1.15) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 10 Mar 2022 18:29:37 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 10 Mar 2022 18:29:35 +0800 From: Haowen Bai To: CC: , Haowen Bai Subject: [PATCH] w1: w1_therm: Use max() instead of doing it manually Date: Thu, 10 Mar 2022 18:29:29 +0800 Message-ID: <1646908169-8050-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix following coccicheck warning: drivers/w1/slaves/w1_therm.c:1452:18-19: WARNING opportunity for max() Signed-off-by: Haowen Bai --- drivers/w1/slaves/w1_therm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c index 5655780..e430d85 100644 --- a/drivers/w1/slaves/w1_therm.c +++ b/drivers/w1/slaves/w1_therm.c @@ -1449,7 +1449,7 @@ static int trigger_bulk_read(struct w1_master *dev_ma= ster) if (bulk_read_support(sl)) { int t_cur =3D conversion_time(sl); =20 - t_conv =3D t_cur > t_conv ? t_cur : t_conv; + t_conv =3D max(t_cur, t_conv); strong_pullup =3D strong_pullup || (w1_strong_pullup =3D=3D 2 || (!SLAVE_POWERMODE(sl) && --=20 2.7.4