From nobody Tue Jun 23 07:18:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7664C433EF for ; Wed, 9 Mar 2022 11:38:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232314AbiCILj0 (ORCPT ); Wed, 9 Mar 2022 06:39:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbiCILjX (ORCPT ); Wed, 9 Mar 2022 06:39:23 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 790411D0E5 for ; Wed, 9 Mar 2022 03:38:22 -0800 (PST) Date: Wed, 09 Mar 2022 11:38:19 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1646825900; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AcqsyaUAYvmbqtP7P9b+TRzWTjt75kKMkxbPSvHkyrM=; b=YEdWK7as0XnlR2ZcQ6rfWVzv9VLYC5wMQ4Le6AwcmK4A0JsUGGCLGPpyxOas1bJu0fxSsU PWa289UJ+fBzXg8RwJ6jbhFgjVNg1tPM8AidOFRUe1CZ6oH6dM0lC995ODfPLLAsa0+ZDw QFO8SmyXu6iXe3R/8v/6CXtpo2gnQnq4WSsrbHX9A6kpnwojUNGFxtIjTFSpUIXrjbjWsM dCMovbqhDe/30253ZMle96ycIqzEbg/leW9SaNNpr5LtrddRTGx2v3zCBmy+DcDLka9yUs qYPemRqEU+O/Wm1D52eNwxuILCvxul1xs7LLX4fIE3LgnkiVXwEQ9aFya7GC1A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1646825900; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AcqsyaUAYvmbqtP7P9b+TRzWTjt75kKMkxbPSvHkyrM=; b=SOmTn9O9QZsmLyb4ByfOPu7O1DngeeO8s9gW66o3PrZZtElh6Zu8Z0GqpDL5JbR5QYbAET DY6r1DOqSIR6LOAw== From: "irqchip-bot for Qianggui Song" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/meson-gpio: Add support for meson s4 SoCs Cc: Qianggui Song , Marc Zyngier , tglx@linutronix.de In-Reply-To: <20220225055207.1048-5-qianggui.song@amlogic.com> References: <20220225055207.1048-5-qianggui.song@amlogic.com> MIME-Version: 1.0 Message-ID: <164682589927.16921.10086882193156342940.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-next branch of ir= qchip: Commit-ID: d6c47d21a0ef9a76c537f8c5258b49d61f2e160f Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/d6c47d21a0ef9a76c537f8c5258b49d61f2e160f Author: Qianggui Song AuthorDate: Fri, 25 Feb 2022 13:52:06 +08:00 Committer: Marc Zyngier CommitterDate: Wed, 09 Mar 2022 11:19:56=20 irqchip/meson-gpio: Add support for meson s4 SoCs The meson s4 SoCs support 12 gpio irq lines compared with previous serial chips and have something different, details are as below. IRQ Number: - 80:68 13 pins on bank Z - 67:48 20 pins on bank X - 47:36 12 pins on bank H - 35:24 12 pins on bank D - 23:22 2 pins on bank E - 21:14 8 pins on bank C - 13:0 13 pins on bank B Signed-off-by: Qianggui Song [maz: fixed some W=3D1 build warnings] Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220225055207.1048-5-qianggui.song@amlogic= .com --- drivers/irqchip/irq-meson-gpio.c | 65 +++++++++++++++++++++++++++++++- 1 file changed, 65 insertions(+) diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-g= pio.c index 7b5863e..2aaa9aa 100644 --- a/drivers/irqchip/irq-meson-gpio.c +++ b/drivers/irqchip/irq-meson-gpio.c @@ -26,6 +26,8 @@ =20 /* use for A1 like chips */ #define REG_PIN_A1_SEL 0x04 +/* Used for s4 chips */ +#define REG_EDGE_POL_S4 0x1c =20 /* * Note: The S905X3 datasheet reports that BOTH_EDGE is controlled by @@ -53,6 +55,8 @@ static void meson_a1_gpio_irq_sel_pin(struct meson_gpio_i= rq_controller *ctl, static void meson_a1_gpio_irq_init(struct meson_gpio_irq_controller *ctl); static int meson8_gpio_irq_set_type(struct meson_gpio_irq_controller *ctl, unsigned int type, u32 *channel_hwirq); +static int meson_s4_gpio_irq_set_type(struct meson_gpio_irq_controller *ct= l, + unsigned int type, u32 *channel_hwirq); =20 struct irq_ctl_ops { void (*gpio_irq_sel_pin)(struct meson_gpio_irq_controller *ctl, @@ -101,6 +105,17 @@ struct meson_gpio_irq_params { .pin_sel_mask =3D 0x7f, \ .nr_channels =3D 8, \ =20 +#define INIT_MESON_S4_COMMON_DATA(irqs) \ + INIT_MESON_COMMON(irqs, meson_a1_gpio_irq_init, \ + meson_a1_gpio_irq_sel_pin, \ + meson_s4_gpio_irq_set_type) \ + .support_edge_both =3D true, \ + .edge_both_offset =3D 0, \ + .edge_single_offset =3D 12, \ + .pol_low_offset =3D 0, \ + .pin_sel_mask =3D 0xff, \ + .nr_channels =3D 12, \ + static const struct meson_gpio_irq_params meson8_params =3D { INIT_MESON8_COMMON_DATA(134) }; @@ -131,6 +146,10 @@ static const struct meson_gpio_irq_params a1_params = =3D { INIT_MESON_A1_COMMON_DATA(62) }; =20 +static const struct meson_gpio_irq_params s4_params =3D { + INIT_MESON_S4_COMMON_DATA(82) +}; + static const struct of_device_id meson_irq_gpio_matches[] =3D { { .compatible =3D "amlogic,meson8-gpio-intc", .data =3D &meson8_params }, { .compatible =3D "amlogic,meson8b-gpio-intc", .data =3D &meson8b_params = }, @@ -140,6 +159,7 @@ static const struct of_device_id meson_irq_gpio_matches= [] =3D { { .compatible =3D "amlogic,meson-g12a-gpio-intc", .data =3D &axg_params }, { .compatible =3D "amlogic,meson-sm1-gpio-intc", .data =3D &sm1_params }, { .compatible =3D "amlogic,meson-a1-gpio-intc", .data =3D &a1_params }, + { .compatible =3D "amlogic,meson-s4-gpio-intc", .data =3D &s4_params }, { } }; =20 @@ -308,6 +328,51 @@ static int meson8_gpio_irq_set_type(struct meson_gpio_= irq_controller *ctl, return 0; } =20 +/* + * gpio irq relative registers for s4 + * -PADCTRL_GPIO_IRQ_CTRL0 + * bit[31]: enable/disable all the irq lines + * bit[12-23]: single edge trigger + * bit[0-11]: polarity trigger + * + * -PADCTRL_GPIO_IRQ_CTRL[X] + * bit[0-16]: 7 bits to choose gpio source for irq line 2*[X] - 2 + * bit[16-22]:7 bits to choose gpio source for irq line 2*[X] - 1 + * where X =3D 1-6 + * + * -PADCTRL_GPIO_IRQ_CTRL[7] + * bit[0-11]: both edge trigger + */ +static int meson_s4_gpio_irq_set_type(struct meson_gpio_irq_controller *ct= l, + unsigned int type, u32 *channel_hwirq) +{ + u32 val =3D 0; + unsigned int idx; + + idx =3D meson_gpio_irq_get_channel_idx(ctl, channel_hwirq); + + type &=3D IRQ_TYPE_SENSE_MASK; + + meson_gpio_irq_update_bits(ctl, REG_EDGE_POL_S4, BIT(idx), 0); + + if (type =3D=3D IRQ_TYPE_EDGE_BOTH) { + val |=3D BIT(ctl->params->edge_both_offset + idx); + meson_gpio_irq_update_bits(ctl, REG_EDGE_POL_S4, + BIT(ctl->params->edge_both_offset + idx), val); + return 0; + } + + if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_EDGE_FALLING)) + val |=3D BIT(ctl->params->pol_low_offset + idx); + + if (type & (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING)) + val |=3D BIT(ctl->params->edge_single_offset + idx); + + meson_gpio_irq_update_bits(ctl, REG_EDGE_POL, + BIT(idx) | BIT(12 + idx), val); + return 0; +}; + static unsigned int meson_gpio_irq_type_output(unsigned int type) { unsigned int sense =3D type & IRQ_TYPE_SENSE_MASK;