From nobody Tue Jun 23 17:22:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2DEC433FE for ; Tue, 1 Mar 2022 18:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236985AbiCAS2x (ORCPT ); Tue, 1 Mar 2022 13:28:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236977AbiCAS2m (ORCPT ); Tue, 1 Mar 2022 13:28:42 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0D841C139 for ; Tue, 1 Mar 2022 10:27:58 -0800 (PST) Date: Tue, 01 Mar 2022 18:27:54 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1646159276; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q2D2STxz7T8Xq/nR5uyA+P9QjoqQeHUiQIWsDf9UHP8=; b=jTQ3a8WfwtmI35js/Lmz5/eegMbGOVEZovwyJGRl2xV0EV8BDrWUpl7gT12o7rHPOZvX9j S1lfglsoij+5FwGqPZp52IxI2IUBPbtRcwBoh+7z5RJvGdVcydAnS6CKzJnZgCkG9X3pVM Avz93LJAkLkTtgEwhVKAfhR9Xzpd3d5h2MMonXGTRTnMbIuysafpto+XBQ2DrGzJhuJrOl bYrEicBd6Onv5RBkqQvT0Bd082Yli4+U7mPK1gxh802TBs8CogXfo0xU+tKlf0vO774wA9 NfMdHutelgeBIy6LqX5haEU/JyVHrJK/AAw1vcOcdfd9teWc8+DaOiUvVOo/Fw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1646159276; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q2D2STxz7T8Xq/nR5uyA+P9QjoqQeHUiQIWsDf9UHP8=; b=YVMgD5KM8ZD8PLFRD3WzrSob8hBAcluKDYB24XFJHnQh3XAh5vjhn/ItrmEI9UBuz1Mi67 M389HHhUwrYIkfCQ== From: "irqchip-bot for Souptick Joarder (HPE)" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/nvic: Release nvic_base upon failure Cc: kernel test robot , Dan Carpenter , "Souptick Joarder (HPE)" , Marc Zyngier , tglx@linutronix.de In-Reply-To: <20220218163303.33344-1-jrdr.linux@gmail.com> References: <20220218163303.33344-1-jrdr.linux@gmail.com> MIME-Version: 1.0 Message-ID: <164615927490.16921.9273664965460113512.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-next branch of ir= qchip: Commit-ID: e414c25e3399b2b3d7337dc47abccab5c71b7c8f Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/e414c25e3399b2b3d7337dc47abccab5c71b7c8f Author: Souptick Joarder (HPE) AuthorDate: Fri, 18 Feb 2022 22:03:03 +05:30 Committer: Marc Zyngier CommitterDate: Tue, 01 Mar 2022 10:19:51=20 irqchip/nvic: Release nvic_base upon failure smatch warning was reported as below -> smatch warnings: drivers/irqchip/irq-nvic.c:131 nvic_of_init() warn: 'nvic_base' not released on lines: 97. Release nvic_base upon failure. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Souptick Joarder (HPE) Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220218163303.33344-1-jrdr.linux@gmail.com --- drivers/irqchip/irq-nvic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c index ba4759b..9423030 100644 --- a/drivers/irqchip/irq-nvic.c +++ b/drivers/irqchip/irq-nvic.c @@ -107,6 +107,7 @@ static int __init nvic_of_init(struct device_node *node, =20 if (!nvic_irq_domain) { pr_warn("Failed to allocate irq domain\n"); + iounmap(nvic_base); return -ENOMEM; } =20 @@ -116,6 +117,7 @@ static int __init nvic_of_init(struct device_node *node, if (ret) { pr_warn("Failed to allocate irq chips\n"); irq_domain_remove(nvic_irq_domain); + iounmap(nvic_base); return ret; }