From nobody Tue Jun 23 17:23:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFF5C433EF for ; Tue, 1 Mar 2022 10:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234126AbiCAKMZ (ORCPT ); Tue, 1 Mar 2022 05:12:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232948AbiCAKMS (ORCPT ); Tue, 1 Mar 2022 05:12:18 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23BF48C7FD for ; Tue, 1 Mar 2022 02:11:38 -0800 (PST) Date: Tue, 01 Mar 2022 10:11:35 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1646129496; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bBW85SkoKW8LZQ3Vt6Qb3JNy5V2ECTgSRgGhhsQSvYY=; b=h7FoI1cxUuw7kB5OvX0nQ3t4clx2LpISlmJdaBAS9MfsxKjLyDuyCZL0404ZxumspueBbs dTOmlm6RPkFvV/jOqib5oeqYDdkRJMTpFZ1rR8KujkOvur1turl9Hi45abDKRbtCOogaXL Tw9jwZ7BH3QgH/EVyJNjQefwOUrtRZLOUlBn1Ag2TTfFmz/uPjqjmThATuCXIRBhedHcNw kEG26TknHKEECxe9UejIy8Ib/h+i1Mli3x0kzUIr6XHSQyocriw1EimTzqrHw7KwAG4K4m UlRX9xm90INTbHbwwV7zNzbnjSAOmBwsall9f9tk1DTRj8QP8p3FRYSK7gLn4w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1646129496; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bBW85SkoKW8LZQ3Vt6Qb3JNy5V2ECTgSRgGhhsQSvYY=; b=hTe4ovJyjsVVy71IXzxy+ndqnd1GFEUGs+YAmPPtL9n/LwIt3aTK33jUSAMjq7fCpYefFF Ml46aTjvdShSAWBw== From: "irqchip-bot for Marc Zyngier" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/qcom-pdc: Kill qcom_pdc_translate helper Cc: Marc Zyngier , Maulik Shah , tglx@linutronix.de In-Reply-To: <20220224101226.88373-4-maz@kernel.org> References: <20220224101226.88373-4-maz@kernel.org> MIME-Version: 1.0 Message-ID: <164612949579.16921.6842959382902482473.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-next branch of ir= qchip: Commit-ID: d494d088ac44b9cf561362a7856fa20b656be64f Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/d494d088ac44b9cf561362a7856fa20b656be64f Author: Marc Zyngier AuthorDate: Thu, 24 Feb 2022 10:12:24=20 Committer: Marc Zyngier CommitterDate: Tue, 01 Mar 2022 10:06:24=20 irqchip/qcom-pdc: Kill qcom_pdc_translate helper qcom_pdc_translate() really is nothing but an open coded version of irq_domain_translate_twocell(). Get rid of it and use the common version instead. Signed-off-by: Marc Zyngier Reviewed-by: Maulik Shah Link: https://lore.kernel.org/r/20220224101226.88373-4-maz@kernel.org --- drivers/irqchip/qcom-pdc.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index 5be5314..837ca69 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -198,21 +198,6 @@ static struct pdc_pin_region *get_pin_region(int pin) return NULL; } =20 -static int qcom_pdc_translate(struct irq_domain *d, struct irq_fwspec *fws= pec, - unsigned long *hwirq, unsigned int *type) -{ - if (is_of_node(fwspec->fwnode)) { - if (fwspec->param_count !=3D 2) - return -EINVAL; - - *hwirq =3D fwspec->param[0]; - *type =3D fwspec->param[1] & IRQ_TYPE_SENSE_MASK; - return 0; - } - - return -EINVAL; -} - static int qcom_pdc_alloc(struct irq_domain *domain, unsigned int virq, unsigned int nr_irqs, void *data) { @@ -223,7 +208,7 @@ static int qcom_pdc_alloc(struct irq_domain *domain, un= signed int virq, unsigned int type; int ret; =20 - ret =3D qcom_pdc_translate(domain, fwspec, &hwirq, &type); + ret =3D irq_domain_translate_twocell(domain, fwspec, &hwirq, &type); if (ret) return ret; =20 @@ -256,7 +241,7 @@ static int qcom_pdc_alloc(struct irq_domain *domain, un= signed int virq, } =20 static const struct irq_domain_ops qcom_pdc_ops =3D { - .translate =3D qcom_pdc_translate, + .translate =3D irq_domain_translate_twocell, .alloc =3D qcom_pdc_alloc, .free =3D irq_domain_free_irqs_common, };