From nobody Tue Jun 23 18:19:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 944ACC433F5 for ; Mon, 28 Feb 2022 17:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239377AbiB1R4k (ORCPT ); Mon, 28 Feb 2022 12:56:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239662AbiB1RxR (ORCPT ); Mon, 28 Feb 2022 12:53:17 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36F61AA2C8 for ; Mon, 28 Feb 2022 09:40:45 -0800 (PST) Date: Mon, 28 Feb 2022 17:40:40 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1646070041; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kaqm2eWHBXcJPmdxh+r33qa7kCgMGlNm6QHSXbUMdi4=; b=ECPVP2fqMGrU3d0J/rccnwOdQrANuJx/NySspOZtXLK7CiQms0HxNP2zAWvNC/Z3HE4IZM cxO47gPRupXAeO1T0apSsgeX4CB2ALFYqcm8AXlEGffTlYiLRCVFwSWiMrHeWh07j6OxUi LtWn+2VbTXFRq7+I1c5NOHufBc7h/zYxm3L0ccRJy6bSos/kql7p7tXLVC6IPIjhb7Sx5T WDhfSZXWYM9ecjwg4xnA1GMvVrG9rI/q+Y59H8JAhR8A/2MyNK+lbYJnUpetRA9lxajz4k uEdSeUpyz9i/9CwEBmtsNrCDr/ElR0iR1p/fYfb+Uqv/5kYp/NoiB/c1PRTkig== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1646070041; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kaqm2eWHBXcJPmdxh+r33qa7kCgMGlNm6QHSXbUMdi4=; b=yW3ZadbZGVK2XvwIHmodriTAagc6bujzLd6jbgmR5xm9LtC6fTXJW3peJDiGOheppmrnSz T7x2slkPQ0Alr1Bg== From: "irqchip-bot for Marc Zyngier" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/qcom-pdc: Kill qcom_pdc_translate helper Cc: Marc Zyngier , tglx@linutronix.de In-Reply-To: <20220224101226.88373-4-maz@kernel.org> References: <20220224101226.88373-4-maz@kernel.org> MIME-Version: 1.0 Message-ID: <164607004064.16921.9532685853753758205.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-next branch of ir= qchip: Commit-ID: af5d5d1d9f2a4a81ae26cdf3eba30248a95f3c89 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/af5d5d1d9f2a4a81ae26cdf3eba30248a95f3c89 Author: Marc Zyngier AuthorDate: Thu, 24 Feb 2022 10:12:24=20 Committer: Marc Zyngier CommitterDate: Mon, 28 Feb 2022 17:32:26=20 irqchip/qcom-pdc: Kill qcom_pdc_translate helper qcom_pdc_translate() really is nothing but an open coded version of irq_domain_translate_twocell(). Get rid of it and use the common version instead. Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220224101226.88373-4-maz@kernel.org --- drivers/irqchip/qcom-pdc.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index 5be5314..837ca69 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -198,21 +198,6 @@ static struct pdc_pin_region *get_pin_region(int pin) return NULL; } =20 -static int qcom_pdc_translate(struct irq_domain *d, struct irq_fwspec *fws= pec, - unsigned long *hwirq, unsigned int *type) -{ - if (is_of_node(fwspec->fwnode)) { - if (fwspec->param_count !=3D 2) - return -EINVAL; - - *hwirq =3D fwspec->param[0]; - *type =3D fwspec->param[1] & IRQ_TYPE_SENSE_MASK; - return 0; - } - - return -EINVAL; -} - static int qcom_pdc_alloc(struct irq_domain *domain, unsigned int virq, unsigned int nr_irqs, void *data) { @@ -223,7 +208,7 @@ static int qcom_pdc_alloc(struct irq_domain *domain, un= signed int virq, unsigned int type; int ret; =20 - ret =3D qcom_pdc_translate(domain, fwspec, &hwirq, &type); + ret =3D irq_domain_translate_twocell(domain, fwspec, &hwirq, &type); if (ret) return ret; =20 @@ -256,7 +241,7 @@ static int qcom_pdc_alloc(struct irq_domain *domain, un= signed int virq, } =20 static const struct irq_domain_ops qcom_pdc_ops =3D { - .translate =3D qcom_pdc_translate, + .translate =3D irq_domain_translate_twocell, .alloc =3D qcom_pdc_alloc, .free =3D irq_domain_free_irqs_common, };