From nobody Wed Jul 1 08:52:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688F9C433EF for ; Fri, 24 Dec 2021 06:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343497AbhLXGq5 (ORCPT ); Fri, 24 Dec 2021 01:46:57 -0500 Received: from foss.arm.com ([217.140.110.172]:54572 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbhLXGqx (ORCPT ); Fri, 24 Dec 2021 01:46:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 473421FB; Thu, 23 Dec 2021 22:46:53 -0800 (PST) Received: from p8cg001049571a15.arm.com (unknown [10.163.70.117]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 946433F718; Thu, 23 Dec 2021 22:46:50 -0800 (PST) From: Anshuman Khandual To: linux-mm@kvack.org Cc: Anshuman Khandual , Steven Rostedt , Ingo Molnar , Andrew Morton , Zi Yan , Naoya Horiguchi , John Hubbard , linux-kernel@vger.kernel.org Subject: [RFC] mm/migration: Add trace events for THP migrations Date: Fri, 24 Dec 2021 12:16:38 +0530 Message-Id: <1640328398-20698-1-git-send-email-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This adds two trace events for PMD based THP migration without split. These events closely follow the implementation details like setting and removing of PMD migration entries, which are essential operations for THP migration. Cc: Steven Rostedt Cc: Ingo Molnar Cc: Andrew Morton Cc: Zi Yan Cc: Naoya Horiguchi Cc: John Hubbard Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual --- This applies on v5.16-rc6 include/trace/events/thp.h | 61 ++++++++++++++++++++++++++++++++++++++ mm/huge_memory.c | 5 ++++ 2 files changed, 66 insertions(+) diff --git a/include/trace/events/thp.h b/include/trace/events/thp.h index d7fbbe551841..be5aeb783af1 100644 --- a/include/trace/events/thp.h +++ b/include/trace/events/thp.h @@ -83,6 +83,67 @@ TRACE_EVENT(hugepage_splitting, __entry->addr, __entry->pte) ); =20 +TRACE_EVENT(set_migration_pmd, + + TP_PROTO(struct mm_struct *mm, unsigned long address, + pmd_t *pmdp, struct page *page, unsigned long pmdval), + + TP_ARGS(mm, address, pmdp, page, pmdval), + + TP_STRUCT__entry( + __field(struct mm_struct *, mm) + __field(unsigned long, address) + __field(pmd_t *, pmdp) + __field(struct page *, page) + __field(unsigned long, pmdval) + ), + + TP_fast_assign( + __entry->mm =3D mm; + __entry->address =3D address; + __entry->pmdp =3D pmdp; + __entry->page =3D page; + __entry->pmdval =3D pmdval; + ), + + TP_printk("mm=3D%p, address=3D%lx, pmdp=3D%p, page=3D%p pmdval=3D%lx", + __entry->mm, + __entry->address, + __entry->pmdp, + __entry->page, + __entry->pmdval) +); + +TRACE_EVENT(remove_migration_pmd, + + TP_PROTO(struct mm_struct *mm, unsigned long address, + pmd_t *pmdp, struct page *page, unsigned long pmdval), + + TP_ARGS(mm, address, pmdp, page, pmdval), + + TP_STRUCT__entry( + __field(struct mm_struct *, mm) + __field(unsigned long, address) + __field(pmd_t *, pmdp) + __field(struct page *, page) + __field(unsigned long, pmdval) + ), + + TP_fast_assign( + __entry->mm =3D mm; + __entry->address =3D address; + __entry->pmdp =3D pmdp; + __entry->page =3D page; + __entry->pmdval =3D pmdval; + ), + + TP_printk("mm=3D%p, address=3D%lx, pmdp=3D%p, page=3D%p pmdval=3D%lx", + __entry->mm, + __entry->address, + __entry->pmdp, + __entry->page, + __entry->pmdval) +); #endif /* _TRACE_THP_H */ =20 /* This part must be outside protection */ diff --git a/mm/huge_memory.c b/mm/huge_memory.c index e5483347291c..611de486e095 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -39,6 +39,9 @@ #include #include "internal.h" =20 +#define CREATE_TRACE_POINTS +#include + /* * By default, transparent hugepage support is disabled in order to avoid * risking an increased memory footprint for applications that are not @@ -3173,6 +3176,7 @@ void set_pmd_migration_entry(struct page_vma_mapped_w= alk *pvmw, set_pmd_at(mm, address, pvmw->pmd, pmdswp); page_remove_rmap(page, true); put_page(page); + trace_set_migration_pmd(mm, address, pvmw->pmd, page, pmd_val(pmdswp)); } =20 void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *= new) @@ -3206,5 +3210,6 @@ void remove_migration_pmd(struct page_vma_mapped_walk= *pvmw, struct page *new) if ((vma->vm_flags & VM_LOCKED) && !PageDoubleMap(new)) mlock_vma_page(new); update_mmu_cache_pmd(vma, address, pvmw->pmd); + trace_remove_migration_pmd(mm, address, pvmw->pmd, new, pmd_val(pmde)); } #endif --=20 2.20.1