From nobody Sat Apr 4 04:54:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EF33DEAE7 for ; Fri, 20 Mar 2026 18:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030062; cv=none; b=srkGGZjgM33qAHZBWjDUxZ3fdPGr0CnvSR8VMXLK8NSjmQeOmywupxrlj9wpeozkOiBSFnnc36QOS8kXKAr79ZVuCOI0mNjbXH7D28yAmJUPTcCwdytn2qwcB9WFIboP7sqPQ70OY9KFtRp0JdQw+EprH0776hNQ+ghvos8IsJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030062; c=relaxed/simple; bh=amPSkQMTzSQojPGe7/NnBN/jpbTA7AJ3qnkGmEg1DZw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iiNut+N5yKWHQ7l4EHL7zm9O149qjtT8bjAlnMMmghXYGbTqzUybytAURllCEwcvi69B4jMT9oIPXT25fOgUzo4liTdh2smslgSkHzHUWxwh+qUMrxK3OPEWs2Ak4vJBb8OMVVpEJdxovb2JI0/9OZES5IRHfo2IbbnROVNCa+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G9T35OO2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G9T35OO2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 648EBC2BC87; Fri, 20 Mar 2026 18:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774030062; bh=amPSkQMTzSQojPGe7/NnBN/jpbTA7AJ3qnkGmEg1DZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G9T35OO2fy9XN0A+O0UjchlBJ4cTGUO0KfKGNpyrYzh8Y4kncNgv0tzdzpIN0BhNc RvyEFjm5KVMdkfaUv0p5DgB3VFIbND1GGr3hOKcXwMu/X4nEyqbmk/XAJGAH3Fz9RT l2eDjHpESSpFmx5ps9dDI2INm9Md+bSRWTzaOC0z6wWcLV4C2a70mOM/bbq10sRTjw nvZl9TKFO/fAJLrMfNrBMOkgIy4wOWZQb1PmfQMF43gsTbkmxawHrihVGv6za557d4 eJWb/c7GZuAuZLg5eYJcOwS0HvLLlbntVNU9o/6lKrBHORDPTtaeKlvaQq8++SoO2g xLF/SYzXxGKiQ== From: "Lorenzo Stoakes (Oracle)" To: Andrew Morton Cc: David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kiryl Shutsemau , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 03/13] mm/huge_memory: have zap_huge_pmd return a boolean, add kdoc Date: Fri, 20 Mar 2026 18:07:20 +0000 Message-ID: <132274566cd49d2960a2294c36dd2450593dfc55.1774029655.git.ljs@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There's no need to use the ancient approach of returning an integer here, just return a boolean. Also update flush_needed to be a boolean, similarly. Also add a kdoc comment describing the function. No functional change intended. Reviewed-by: Baolin Wang Acked-by: Qi Zheng Signed-off-by: Lorenzo Stoakes (Oracle) Reviewed-by: Suren Baghdasaryan --- include/linux/huge_mm.h | 4 ++-- mm/huge_memory.c | 23 ++++++++++++++++------- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index af726f0aa30d..1258fa37e85b 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -27,8 +27,8 @@ static inline void huge_pud_set_accessed(struct vm_fault = *vmf, pud_t orig_pud) vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf); bool madvise_free_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *= vma, pmd_t *pmd, unsigned long addr, unsigned long next); -int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_t= *pmd, - unsigned long addr); +bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_= t *pmd, + unsigned long addr); int zap_huge_pud(struct mmu_gather *tlb, struct vm_area_struct *vma, pud_t= *pud, unsigned long addr); bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 4e8df3a35cab..3c9e2ebaacfa 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2325,11 +2325,20 @@ static inline void zap_deposited_table(struct mm_st= ruct *mm, pmd_t *pmd) mm_dec_nr_ptes(mm); } =20 -int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, +/** + * zap_huge_pmd - Zap a huge THP which is of PMD size. + * @tlb: The MMU gather TLB state associated with the operation. + * @vma: The VMA containing the range to zap. + * @pmd: A pointer to the leaf PMD entry. + * @addr: The virtual address for the range to zap. + * + * Returns: %true on success, %false otherwise. + */ +bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_t *pmd, unsigned long addr) { struct folio *folio =3D NULL; - int flush_needed =3D 1; + bool flush_needed =3D true; spinlock_t *ptl; pmd_t orig_pmd; =20 @@ -2337,7 +2346,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_ar= ea_struct *vma, =20 ptl =3D __pmd_trans_huge_lock(pmd, vma); if (!ptl) - return 0; + return false; /* * For architectures like ppc64 we look at deposited pgtable * when calling pmdp_huge_get_and_clear. So do the @@ -2352,13 +2361,13 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_= area_struct *vma, if (arch_needs_pgtable_deposit()) zap_deposited_table(tlb->mm, pmd); spin_unlock(ptl); - return 1; + return true; } if (is_huge_zero_pmd(orig_pmd)) { if (!vma_is_dax(vma) || arch_needs_pgtable_deposit()) zap_deposited_table(tlb->mm, pmd); spin_unlock(ptl); - return 1; + return true; } =20 if (pmd_present(orig_pmd)) { @@ -2372,7 +2381,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_ar= ea_struct *vma, const softleaf_t entry =3D softleaf_from_pmd(orig_pmd); =20 folio =3D softleaf_to_folio(entry); - flush_needed =3D 0; + flush_needed =3D false; =20 if (!thp_migration_supported()) WARN_ONCE(1, "Non present huge pmd without pmd migration enabled!"); @@ -2406,7 +2415,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_ar= ea_struct *vma, if (flush_needed) tlb_remove_page_size(tlb, &folio->page, HPAGE_PMD_SIZE); =20 - return 1; + return true; } =20 #ifndef pmd_move_must_withdraw --=20 2.53.0