From nobody Wed Apr 29 02:00:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5266DC433F5 for ; Wed, 25 May 2022 09:12:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240052AbiEYJMk (ORCPT ); Wed, 25 May 2022 05:12:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238263AbiEYJMW (ORCPT ); Wed, 25 May 2022 05:12:22 -0400 Received: from jari.cn (unknown [218.92.28.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7513FB36C7; Wed, 25 May 2022 02:08:16 -0700 (PDT) Received: by ajax-webmail-localhost.localdomain (Coremail) ; Wed, 25 May 2022 17:03:03 +0800 (GMT+08:00) X-Originating-IP: [182.148.13.40] Date: Wed, 25 May 2022 17:03:03 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: "XueBing Chen" To: vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dmaengine: dmatest: use strscpy to replace strlcpy X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT6.0.1 build 20210329(c53f3fee) Copyright (c) 2002-2022 www.mailtech.cn mispb-4e503810-ca60-4ec8-a188-7102c18937cf-zhkzyfz.cn Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Message-ID: <12e4cf06.a35.180fa748c29.Coremail.chenxuebing@jari.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: AQAAfwAHEW_H8I1ibgY4AA--.645W X-CM-SenderInfo: hfkh05pxhex0nj6mt2flof0/1tbiAQARCmFEYxsloAAHsF X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The strlcpy should not be used because it doesn't limit the source length. Preferred is strscpy. Signed-off-by: XueBing Chen --- drivers/dma/dmatest.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index f696246f57fd..91bf65e0674c 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -1095,8 +1095,8 @@ static void add_threaded_test(struct dmatest_info *in= fo) =20 /* Copy test parameters */ params->buf_size =3D test_buf_size; - strlcpy(params->channel, strim(test_channel), sizeof(params->channel)); - strlcpy(params->device, strim(test_device), sizeof(params->device)); + strscpy(params->channel, strim(test_channel), sizeof(params->channel)); + strscpy(params->device, strim(test_device), sizeof(params->device)); params->threads_per_chan =3D threads_per_chan; params->max_channels =3D max_channels; params->iterations =3D iterations; @@ -1240,7 +1240,7 @@ static int dmatest_chan_set(const char *val, const st= ruct kernel_param *kp) dtc =3D list_last_entry(&info->channels, struct dmatest_chan, node); - strlcpy(chan_reset_val, + strscpy(chan_reset_val, dma_chan_name(dtc->chan), sizeof(chan_reset_val)); ret =3D -EBUSY; @@ -1263,14 +1263,14 @@ static int dmatest_chan_set(const char *val, const = struct kernel_param *kp) if ((strcmp(dma_chan_name(dtc->chan), strim(test_channel)) !=3D 0) && (strcmp("", strim(test_channel)) !=3D 0)) { ret =3D -EINVAL; - strlcpy(chan_reset_val, dma_chan_name(dtc->chan), + strscpy(chan_reset_val, dma_chan_name(dtc->chan), sizeof(chan_reset_val)); goto add_chan_err; } =20 } else { /* Clear test_channel if no channels were added successfully */ - strlcpy(chan_reset_val, "", sizeof(chan_reset_val)); + strscpy(chan_reset_val, "", sizeof(chan_reset_val)); ret =3D -EBUSY; goto add_chan_err; } @@ -1295,7 +1295,7 @@ static int dmatest_chan_get(char *val, const struct k= ernel_param *kp) mutex_lock(&info->lock); if (!is_threaded_test_run(info) && !is_threaded_test_pending(info)) { stop_threaded_test(info); - strlcpy(test_channel, "", sizeof(test_channel)); + strscpy(test_channel, "", sizeof(test_channel)); } mutex_unlock(&info->lock); =20 --=20 2.36.1