From nobody Sat Feb 7 15:11:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 778EBC001B0 for ; Fri, 14 Jul 2023 04:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234688AbjGNE4i (ORCPT ); Fri, 14 Jul 2023 00:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232340AbjGNE4f (ORCPT ); Fri, 14 Jul 2023 00:56:35 -0400 Received: from mail.208.org (unknown [183.242.55.162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 259FE2D5F for ; Thu, 13 Jul 2023 21:56:33 -0700 (PDT) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4R2K255mDwzBJk54 for ; Fri, 14 Jul 2023 12:56:29 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1689310589; x=1691902590; bh=kH8GnE+sm/V63Y/8cHTnasFldhq gzlUbCDGfR2vkAeM=; b=ZeEWpyRWgvhCJoyEQGJITA3WVMyvKmE64MnvzWjMhDZ 2h4d7zuK2vcpNN5Q08sqsg+suzY9YCIWPSonDwZDjYrCDC5ZOWuaae6DAOfjP0aj A22E2WJ59bAQXrYwdrFyucO5E83OEfdkwd2a4YKCWnnKUi3xAtl+S9GG1kqxWt5n Yygc137bnX9GyQgEM05T8KqPSB2PGDS1rE3BM84hXoCL+7TqehzSAyjEz/aoYruZ vq2UQ2Wa+HzvosRDO24ey+Z6IJFrzP4zGqwZVvfauhVj0BiwHueGcyu6HzM94QF5 XrdFm8WN2S9rcamYEQt739Okb4VOeZRbeXY3zRxD+nA== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yZ3x4ra0qtKh for ; Fri, 14 Jul 2023 12:56:29 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4R2K253rp3zBHXhN; Fri, 14 Jul 2023 12:56:29 +0800 (CST) MIME-Version: 1.0 Date: Fri, 14 Jul 2023 12:56:29 +0800 From: liubin001@208suo.com To: davem@davemloft.net Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] floppy:ERROR: missing put_device; call of_find_device_by_node on line 589, but without a corresponding object release within this function. Add the put_device function before return to release memory In-Reply-To: References: User-Agent: Roundcube Webmail Message-ID: <0f4dc280605c4700556d88d6f59cd1c4@208suo.com> X-Sender: liubin001@208suo.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8"; format="flowed" Signed-off-by: LiuBin --- arch/sparc/include/asm/floppy_64.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sparc/include/asm/floppy_64.h=20 b/arch/sparc/include/asm/floppy_64.h index 070c8c1f5c8f..c4c51f494f25 100644 --- a/arch/sparc/include/asm/floppy_64.h +++ b/arch/sparc/include/asm/floppy_64.h @@ -588,6 +588,7 @@ static unsigned long __init sun_floppy_init(void) op =3D of_find_device_by_node(dp); if (!op) + put_device(op); return 0; state_prop =3D of_get_property(op->dev.of_node, "status", NULL);