From nobody Sun Jun 14 11:27:46 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013007.outbound.protection.outlook.com [40.107.159.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F3AD390C80; Thu, 16 Apr 2026 11:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776339270; cv=fail; b=D7vohPDaxp0FCHW6fZFUzuBOC+gHQNZZbq4pQ5j/PXiTqNcnhYtGABzUiG97EMluo/KW1c8zSBWs2UaC3XmCNF3c2qRcgMDDJJXyYKhLD4TPfCH1K0auCM+RTsuztwq729nQS1B8HJMCIdouR72UU+YUSpUHVEEdZXsTc9EoIQ8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776339270; c=relaxed/simple; bh=rtZ5/KyxX0uZvzTygoeTMlo+/SDtfMCUOOdFYVXz2Oc=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=FS4FB/wY+eeUJwlyNmtKGBnaLyHXRtSvJcYbbOfyx+8fEsDoXnmf/eG/EBlBsPUQJfyV6RmlbMsvkMuQ2mzAjFMmnTks0tCBMn+6+AoSqQ9aB/Jc/eLe4lHa3hqHV1UaqYH7igYT4vxv0z3n7ADcMbAGC9a4WfxItr9OO1obuL4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia.com; spf=fail smtp.mailfrom=nokia.com; dkim=pass (2048-bit key) header.d=nokia.com header.i=@nokia.com header.b=I3/WQkQe; arc=fail smtp.client-ip=40.107.159.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nokia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nokia.com header.i=@nokia.com header.b="I3/WQkQe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aDDWKevqYoexayToFm0ck7ByNbkTno7hI6dy1pIMIjr8gXg3z0cOTAbNreWVMeA13G6jex9WnDVPVupD2I3LullxZ7gwzEd5hdWpAkS7bn3SGeKMLsonP+S0VJ7VIO/XrIyv1uNyZXclnfsj0qlLTRHV9EuNXHu+G8UD4ae1uVnpwWu15G86JNhdw338qs7Hp2AnVqcHn8ePgs+RpyJbNFK0KbeCzX8xaczFn49QXqOTQNOvrmX8eFZaOs9xkYk5mgbDH4u/72wnhsgGdXUnTZN7TRCVRM3ROC1hWtc6LiTD+SUDkcPPuHduCIZy4078bv5pcW0kyusMpcm+ucgFsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rtZ5/KyxX0uZvzTygoeTMlo+/SDtfMCUOOdFYVXz2Oc=; b=mBCX35EewgGX34U3ioL/FpL/kNpv+Nph3VMkqUIQOyaQsgflfG3NSonovHR3C3FGK9yIXLyExHEWfx3AMdNey61xE/hM9Y9RsZHzgMvfbMPx+enK9pPmJHuZ41au+SGeuOC52g3KmFuo5fbZCeM6gU/9AyIZaCyWkBXB3soptxKBSasA/rpmXd4R66g2qF0eu2sT3r95S8QKcl3/v5kqla4HEic+VZZ/ERYEPy2PQDH2s94nYI1PboyEbQT30tCCQyV3XAwkj7jAhuahEyjll2+aIonTwofqEUlxU9H7Om/vSEQs4F3dFsWmoyaHsXpxb96NUHtM5RbxMvklzyAE1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rtZ5/KyxX0uZvzTygoeTMlo+/SDtfMCUOOdFYVXz2Oc=; b=I3/WQkQeepaP6dvhNpWjxd3jmz3PWhWfky9nUIFdNBpAtp35CSQ7wPW08e/P5LIqCpIrxQRHxhqYLJpbB5ia1JrOtJbcVMzfqU4+7wmA+BWH/ODdMH7HKpHavNF3orx6iCKA97lKQ+4lBiTzHnUSDsJsVZXfaZ+neJPOPGzeyeVpH9eHEmOtfJYOS+ZO/SZzrwnchOEAZeDSlW59e8QiEkOd+REtRfcdHhS+KRF2SqiUzmAxkRQe7o5UrAxux8uyDhBiqGiQYO8M7RpmLOMDQIdir6rrKkfDXJtaOzsw3I9r897h51cpLBrSfTwHd99N69Lg2z3CxbMTZbAfJza43A== Received: from AM9PR07MB7204.eurprd07.prod.outlook.com (2603:10a6:20b:2cb::15) by PR3PR07MB6794.eurprd07.prod.outlook.com (2603:10a6:102:5d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Thu, 16 Apr 2026 11:34:26 +0000 Received: from AM9PR07MB7204.eurprd07.prod.outlook.com ([fe80::1f2e:eb0c:2b1a:9cef]) by AM9PR07MB7204.eurprd07.prod.outlook.com ([fe80::1f2e:eb0c:2b1a:9cef%7]) with mapi id 15.20.9818.023; Thu, 16 Apr 2026 11:34:26 +0000 From: "Igor Klochko (Nokia)" To: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: "Philippe Belet (Nokia)" Subject: [PATCH v5] uio: fix unregister_device Thread-Topic: [PATCH v5] uio: fix unregister_device Thread-Index: AQHczZT7IfHclcurcUKzNIat5r4L9g== Date: Thu, 16 Apr 2026 11:34:26 +0000 Message-ID: <0e82fc96-d6c6-4383-ae96-1accfb40d5c6@nokia.com> Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9PR07MB7204:EE_|PR3PR07MB6794:EE_ x-ms-office365-filtering-correlation-id: 5840a7c5-3dcb-4802-607b-08de9bac1d8e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|38070700021|18002099003|56012099003; x-microsoft-antispam-message-info: 8GRlcAHKxPuv+oJWpRodoL8KrTGWOZZ42scvJsuKhAHw6SZd0r9r6wyd0NleBPyBljUB9exDYfX0/wKkUV+yQGnmAdy1FWwAzoYsWk4C/U4tDanLusWervraz+g2TFvss0+eTpc3TIUIrjOHHa37cccmFZNmiyLQ24rbazzkxTIcsCgngZNhUYUV1tyofg5JJ/hWiCZ9On39uJSBa/6g2d/UbnqSSxnIIGMyN0EFjKCtla7Cln7jweRnEFtBToWJkbAEBaSUnGpghnaBIIIoL11JOXfSQUMO9fO6sVCU+eJQKAEfQcUegJ6lU51pigriHrC+F/8/VEM+y+G8xhSSzojiY77QM+ijAMNppnVxAZqtnepqdn2bKlSZVu7U4VKjg8E2rdzSriwMTjVDW84uViqX/bJXUtyq7HcZgDTVXMlBm6WP1Jbd7uxAH4ATGLYa5iNxE88MTdaBEHX/otR5sTl1PLdOnjODOo5zor6y8U1g+835V5wniIjLL4M6a/oeJ+lTBFU3U58cVkQgwm1GomUGZiTMnonxmcLMhhpxlWh1UHgHwfo7jA6ru0mCkj2TK8ib1UIhvgKjbEbtfb/RYyMrB2Ws2X8vQUIGzeU782MP5LmDyHXX/TtBAEBks0+XGSwZwGYicdu9HEewIZUrcVn4RThEnFBXDig2LJSmsznPflEp0zF72tryEtFzSe5Nt5k/vHIhulC5aNgd7P49h7LU4a05u1FKPvy2Q0MkpU6LC7Z5C6FFBej+G79X3OdmdFuoLOsG+qMRK9Bj17E8L14ZoNBNvs0+fRwrb4UfLbc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR07MB7204.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(38070700021)(18002099003)(56012099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cExuQlQwUlVQMXZmaFlQb0Z0T1lzRTdqTHNIOUFGVFR1QkdmM1BKeXdYeWVo?= =?utf-8?B?NHd1U1dhdGJjNy9jbjRRdC9kbEgyMlNQOWtjWUJLemZ1UE81OE5PNXlFVklw?= =?utf-8?B?NVJTcllLVGVid0ZzV2UrdXhyamkzRFdDM0JxNHpRKzNGSFRxK1N5Y1FyK0g3?= =?utf-8?B?azU4dW9MT29kNVpEeDJSQnM3MThaa0Rkci84YjJ0c3ozQXoxb3B3L281cmVV?= =?utf-8?B?aG1jaStFOXRZNlBOSEZacUZjS2xULzh1emVoTEhsVFlSdFdFZ0VPMjZVcFIy?= =?utf-8?B?ZjR3OXRJNmd3RSs4SWZyeUJDbFhnbFI3OHh3N2dpenQwNjdsS2tGbWhTOFlX?= =?utf-8?B?bCsyc3Vqbzh5eFIwMGV6Z3EvaFhNdVRKNVh3cXZ1YnViMG9wTURXQUF2WWI4?= =?utf-8?B?VFZTc2l3eUFuUFpUMWxUeHBIU0tWa25Eek8xVFRpZXFlODFVVVUwaWxRSGc5?= =?utf-8?B?UHl4SXlXN0cydktYL0x2TnZNclBVNGYzT3VlckxacGs4L0laVFJLeGlpQ3pN?= =?utf-8?B?a1JUSUhnQUg4bXhiUUtyaGVxaURkbHpsYS9NTFBSR25wMSsySmZJeVl4RHZ5?= =?utf-8?B?cDhHZ2lUUXVnNVMvWndKYkFVMVdydWt3MjIzWGx1OE43L0ZXZGlhdjBYVitt?= =?utf-8?B?ZzFHbnhGbENBVzdkdHJEcmpMcGVFbnJvSjRPOWpRUFRveXF1N2YzMlZsbDAz?= =?utf-8?B?TnpCaHRZWmFjTmt4OGFpZXRqWVF4NG1zU05BbVNEcEpSR2xkaVJlZWpuQWpm?= =?utf-8?B?dld3QjM0TktWblJ3SnYyY3dMdXVhNnVwdjNCQ0ZtQjJXL3lIUjZ5NEdxazYw?= =?utf-8?B?cGhrRGFuOC9VSGQrdFJXQnhpQ2FGZzJzek84RWNnS1BsTENrZjUvLy9jSHZM?= =?utf-8?B?MjhxcExYd2lEOEJVMk9BOXNwOXhPMVdlblE5TmlFRk55RHNPVzREamFVa1pJ?= =?utf-8?B?bUFMZ0lYcW9lcFhybndmMmpBcmhPeE82YVFOdHVsOXZDYjZxWElpVDEzMkZq?= =?utf-8?B?dzFqMnZKK3JxbW40MFRjdHF3OGMybEd2Y3V2M3ZrckQ1WmZTZGgwaHpTTHNC?= =?utf-8?B?WUJqMzdVMWVqWVBvdG42SUtLS0lPU0Q0SUtNaEtrYXVyZTJWRTNsUzVCQlZJ?= =?utf-8?B?ZzN4dWpWbWxXQVhjWkxuWWVEWVk3WTFDWjdiVDVCNFRvZVZodGFJd25XWjl3?= =?utf-8?B?N3UwVUF0bjVnNzJ3VlRKTlJ5UTh1Y0duRS91VDg5Sm10SWJCUmppOHBjS3BU?= =?utf-8?B?N1hIVThySUkvMnhwSUZYcm1Tak9jOEJXSGF0ck1VY25pYTlRWmpzOXRKMmtp?= =?utf-8?B?cnQwVXlXdzNPbmEvNVJQK3VhV21tMVZLVU9PVUNlMVZUbThUS01lYStzK3V4?= =?utf-8?B?Y25BSmljT3hQQnUxeG4yR2lGTG1xRGY1M2t4VE5IOHdHbVI1dGJFNklPZU1I?= =?utf-8?B?QmV0eWJQdE9IRUs1WkxYQTNHR1Z1SGU1bTdRUGxLU2xoSmxTZjVsaHNBNlZl?= =?utf-8?B?S3lBZ2orK1VnZnN0SzJhek9ybjFUcUNEeFBqMDQvVnh1aVBhei9PZENhWTNs?= =?utf-8?B?dklueFBCRU5SRjdrUlgzbzgzRTI4YVFVbUVtTHpMMjhFZ0pXY1VMb2hSRVh4?= =?utf-8?B?Smd5anJ0QmZjSzVvalptc0dHL3FNelRSdWVYWHl4WUp1cHVVNk56MXBCd2tk?= =?utf-8?B?ODdWRnBhU0hXZjFzeU1lVWJIZGF6b1BtdHN0REMvRjZHQnVuWGh1dGZnVlJx?= =?utf-8?B?SVFiTmJSQVYwOC9uUEpxWXJ4T0F3N2htNnJ3VEw2aDgrOVZQcCtIZzFLd3RY?= =?utf-8?B?UlNaT2JSZmlVQXZ3RzFBcG1VVzR0blRkbTdFOWYzWi9WVTlJdjVOMmFzWVRj?= =?utf-8?B?Vk1ZeEJDRENMWDdjOFRHc0xJZG1qUGZNSWdZaURtZEF6a2JaL2xuN3Z3K2Yy?= =?utf-8?B?TE9Nc00vakI4T1NyR3RTeUViRTU2QlJrUjhBeWJmdElhWXRHQmhXcXFXRTg2?= =?utf-8?B?bmxtQ1VQYUxkemlsN1l4RzFJMzVVTjJvcXhseDJPVkJLK0d6MEJZZFNIdVFM?= =?utf-8?B?THlDTGVJWC83VVRwVVMyc0FEeFc1VjZ2YldiRFJDUXBxQlVjUVNPZWIrNEpR?= =?utf-8?B?YVhXM213UFBIQllFVkt1RHBiMzFjamUxdGcrd0VubThkZjNVN1lXRnE2Rkta?= =?utf-8?B?dWUzUUhId013R0ZJK0hxdDdSQ3Y0TG94UCs5OFJvNGxQS0FnQS9XWWsyYmhU?= =?utf-8?B?bEFjWWdXazAzeTJ0TEFMNnlJbHdlbjc1Vk5lVk91MldycUx3SG1SaTBsTW1S?= =?utf-8?B?Yk13OXVDWld3SGZVOERhVm1ZcUk4aVhQZzdIbjNwZ051bm5UOUdmQUpUUnFN?= =?utf-8?Q?PpUPKmTGBgDYP6Rg=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <870BDCB8F729CD4A82A680C4F7578CCB@eurprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR07MB7204.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5840a7c5-3dcb-4802-607b-08de9bac1d8e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2026 11:34:26.5709 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mc7Fw7EeSXiUiz1912yE/AI1s6znVHMRowaGZNuBGyNNwYliUj6Wa1ZoMDVrgvgttN/QKxdNYnFHWpWXsSgIhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR07MB6794 uio: mirrored uio_register/unregister_device When uio devices are created end removed in parallel, then we sometimes encounter kernel traces along the following lines: sysfs: cannot create duplicate filename '/class/uio/uio899' which stem from: sysfs_create_link+0x24/0x50 device_add+0x2f0/0x780 __uio_register_device+0x18c/0x550 The sysfs directory creation is performed synchronously as part of the device_add call. The high level sequence for uio registration is: 1. uio_get_minor (idr call, in critical section) 2. device_add (leads to sysfs directory) 3. manage attributes (popuplates part of the sysfs directory) For unregistration we have by default the following flow: 1. clean-up attributes 2. uio_free_minor (idr call, in critical section) 3. device_unregister (cleans up sysfs directory) This creates a racing problem when we are in parallel creating and removing uio devices. The uio-minor that is freed when calling uio_free_minor can be claimed by a subsequent uio_get_minor call. The problem is that the device_add flow can end up triggered, leading to a sysfs directory creation; while the device_unregister flow has not yet cleaned up the sysfs directory. This patch cleans up this problem by mirroring the registration and Unregistration flow correctly. After this patch, the unregistration flow becomes: 1. clean-up attributes 2. device_unregister 3. uio_free_minor Fixes: 0c9ae0b86050 ("uio: Fix use-after-free in uio_open") Cc: stable@vger.kernel.org Signed-off-by: Philippe Belet Reviewed-by: Igor Klochko --- v5: - fixed broken link v4: - reformat the patch v3: - Updated email subject v2: - Fixed commit message wrapping - Placed 12 char sha1 in "fixes" - cc'd stable v1: https://lore.kernel.org/all/AM9PR07MB720434A2B0CC99BC0BDCD74E8D61A@AM9= PR07MB7204.eurprd07.prod.outlook.com/ --- drivers/uio/uio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 5a4998e2caf8..10e265c49035 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -1125,8 +1125,8 @@ void uio_unregister_device(struct uio_info *info) wake_up_interruptible(&idev->wait); kill_fasync(&idev->async_queue, SIGIO, POLL_HUP); - uio_free_minor(minor); device_unregister(&idev->dev); + uio_free_minor(minor); return; } -- 2.43.7