From nobody Mon Feb 9 17:37:48 2026 Received: from IND01-MAX-obe.outbound.protection.outlook.com (mail-maxind01olkn2029.outbound.protection.outlook.com [40.92.102.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 406DC4A33; Thu, 8 Aug 2024 11:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.92.102.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723118074; cv=fail; b=SKHh9jsy7PqSKXNQonNsJAX8JYpLztg3tKV3623fNgQ8DK4MsW3yUNnzK1YUQLOb2NHDFJzfIA5+bPlYZmpGTcul6UcDt8k2nIn7zYmj0beQVcHvEshcU3FfPTh+Nq0zyzKe+S5MbW03RTJCPzSGlByGUnZ5o68sOknHyfcR0bA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723118074; c=relaxed/simple; bh=Akx0MrXpd+JVj1ZDV4IdDdBaVXlyzdtgQ3clE80/1X4=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=uxYebRS24NfSvX/pFW+Bi+mWZZCFubgXiKBbGyL3moABizUzL9ufMzShdRLSadUnsL6ybZ9rJLdtaCQACFJ2RV8wg5QplsaVK5njYiNYI6x/GobaxcSoC5N38pIZQw6T2kshAib8nAnNL8iFQWgRA1Shteddmt5iTFj+mRI8/so= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=sPv6ilxc; arc=fail smtp.client-ip=40.92.102.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="sPv6ilxc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DUZupMM6GHkZlsHtl8hk7nv5IJu/D+7DwcoVYxJlUereL+a7FLtjHvDndAVkkteVwvkJpjr1b0DW7ONmR6lDQ/muV2cTcNBYSMf6tDaAwiCGOVW0oSVFKmcjoM1M0BK3ojRlug4bRQvEYha5qc8zI49a11nyspwzeQjuvxOsl82EyqV4iuhe2/w9img1wNhngcDBvb7zo3Mbs39EMCc547z3lUS9nOu/zq6WUFMc51yKxJl4OV3zIu0aXvNvA1vnhpJgrmu1kPuuTpsO9sqSqZrerDvKjKtU21M2DPBoVB5bRrBGCZurP6hJE1fG8X4dGZSIa3e419AuPjFoaR4GQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Akx0MrXpd+JVj1ZDV4IdDdBaVXlyzdtgQ3clE80/1X4=; b=uBvP5ZyiZ9HfsyOaxaUcKuw6duEyeUAV41yP+f3U0NPUgIBCOdEXsYWpd/dbovjOx+EjW3gyg9BkOjNZk8x8VQJPTiBiyMw+LDwwJtpebnD0Da7/SIYm1WCeIQTeTuc9MDDx759mGMTOUPJMQCN9Qk9/xRicPPtnFfruKFPHSpZw9mqK982d66ErjwIj6rN9AUlpqSMuy7Uypxm6Pp334UF+cSqluBEqRkSg9ny0WvlVtt8b+4AxDn9J+slnY/N5Twoeonm3s+6HHkT+PAmL93GXafPPAKPaypXmdeo9PX53S9WkZeiiMVQiKUSQSthaYwh0KxdtDyHDE1Inu5F7mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Akx0MrXpd+JVj1ZDV4IdDdBaVXlyzdtgQ3clE80/1X4=; b=sPv6ilxca09IIDetTPzuk7wibd1Q+IYlDNY5iSm33rtI/oPIG6wkpLvoYLslAQNCkP1gnCoHCWEfM2/KfcAy2qPkbEWzYfmz8EkgmQTfg65b/29S46LPytoJR04WcSd238xb3bBXg4RYZKLqHV6+gvknVs5MLmAV/MdXvCcnHEK46D3qIVGvts5BegpRUuVyCDQ37yKax3KML0xS01bb8ce2InywcM8nwzmu17aWBTfg0QetL7ym7OS+o8v8ZWfoKcNScIocz6cZjHwu5FyVvnSC+ov6s5ajzXVVURtGYwK+99V/a2vXG0NkxbCYfqDhTxD7o81nW8NUM9aAdAYJyQ== Received: from MA0P287MB0217.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:b3::9) by MA0P287MB0680.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:11b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.14; Thu, 8 Aug 2024 11:54:25 +0000 Received: from MA0P287MB0217.INDP287.PROD.OUTLOOK.COM ([fe80::98d2:3610:b33c:435a]) by MA0P287MB0217.INDP287.PROD.OUTLOOK.COM ([fe80::98d2:3610:b33c:435a%5]) with mapi id 15.20.7849.013; Thu, 8 Aug 2024 11:54:25 +0000 From: Aditya Garg To: "tzimmermann@suse.de" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "daniel@ffwll.ch" , Jiri Kosina , "bentiss@kernel.org" CC: Kerem Karabay , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linux-input@vger.kernel.org" , Orlando Chamberlain Subject: [PATCH v2 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars Thread-Topic: [PATCH v2 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars Thread-Index: AQHa6Ym3gmD6gtRo4kOUi8viR/zBrg== Date: Thu, 8 Aug 2024 11:54:25 +0000 Message-ID: <0E5065B4-8E9E-4E4B-A504-54E20EDDACED@live.com> References: <9550ADFD-0534-471D-94B4-EF370943CF80@live.com> In-Reply-To: <9550ADFD-0534-471D-94B4-EF370943CF80@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [1wpSoEXkGnEJ0bP5ZmGrBaTVPEdm6vrcsqMxVRrxdpwpEAdQRNGTxOLj+V1bahP3b6dBYUHSUCo=] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MA0P287MB0217:EE_|MA0P287MB0680:EE_ x-ms-office365-filtering-correlation-id: 12ff68ce-f43d-4176-586b-08dcb7a0d9d4 x-microsoft-antispam: BCL:0;ARA:14566002|15080799003|19110799003|8060799006|461199028|440099028|3412199025|102099032; x-microsoft-antispam-message-info: 4U9Evb3llAGzTRc1bryvR7BM77FC55NHCKf1LhgPQtA6euvMak2IpJPY4yHdWi3YlyX27F2W6aGWjDWoymnJyZLTq6Lw2FTh+6L5NEdlPA9GdsgyYFNw6Tl/k2xqBSF/1HDiZGR6nNwzVT0/0dz/kf4Tpc49olF03HkScbkva9830VgqhotAmrQMHG2Ir3NkNa7rB9A2hyoRn9BSi2nJLjyaVJ7eKcZa+71yUu8QD0Nw2W3hoOJ9va4cIyPneEo3w0ILzMMeJ2em+B3wYqg/xqS0KxzhB8/8yaaNBF4pRTm4qiKNsr9Z67fFqf08QqnmZszkkAYFnv9QFa4LLRzRlSjSAZcJu+WGEzKj9QVNwHDJV+xRDyHk9PmMY+6/D8MNeudqqS/LCAuyLSLiU/QDnctm0ZyMjR+hGmXYSg7wPPzwD78+djAexUQdgXh48UMEGwukMTgdPT+DRQhJrlZUH39v2kqA6OBEIVQMjG6bznss3oQ4lFIww8azJwdOxKmgmImRJ2Djnbx2Uj1DhmDxqBRRulfskN5LDA1KaL5r+WkSDJ78QuXNtHvGCJtjOBZ91QO156wmKgAi4VEju6tjqSf4/vjxCp7/zd8WfVzLvAS8Xhun+sKjHTA0u8/NMBUd3Hy+x9zdkuyVNOFSdMdJ45AMd0d4oFINJ5WR6NXAKX9A7kpx7XF2MvEuJWMPY/Xq x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RC8xczRwbGdwQ0RVbm02ekNkZksybEp1TDZyY2lZL3VTRXRvS2hibkZGcU1C?= =?utf-8?B?elFvb2p6U2k1VkM5M01tTmdmYTdBQU9zUElYcGtnaFJETVBOYTd4RVdDSjY3?= =?utf-8?B?OFlxQzBRencrdkRBa09NclZZNEczbGFtajZyLzVWc3JvRTVMZ3lQYlNad3JW?= =?utf-8?B?S1FQNGgrS2xmVXp0bTMzNkFZZDF2eWljbmhjVlQxaVgzSjdWM0puckN2L0V1?= =?utf-8?B?ZjlRVkx4RnltaVBrT1hrdmNjTUMyRXZmd25CRjZwalZpbDhhM2g5dzNEVTRR?= =?utf-8?B?bVBOb0VmZVd6STZ3NEVaWUZuSDU2M3QrMWpPMVpoZThWYjJ2U0swNHlUWTV0?= =?utf-8?B?aFRRVmp0NUZOTGt2OG00ditZY3ZBNkQyeVRwVHFDNitEbEk4eXB2N0pTQmUz?= =?utf-8?B?OE95cU9RNEhFc0FJTGJoS1lCbUZqNFd1RGRSbVVzejJBaEoraVpJRzZiaUpQ?= =?utf-8?B?MGhBVkt0UHdILzRaK3h1RUkxZkVPK2RZUEg0Qll3NFRMd0c0aUxKcmZmZFZu?= =?utf-8?B?SExLYmJvdHZtNDdqeUYyUXhMWGdKM09CbWJFTXBrNW16bkhPenIwNTduNEhm?= =?utf-8?B?ZVpEWk9XZWFtaW5SZnRFc0gvckM1emNUR3UvYm1wQjA5em5kbHlldHg2KzBB?= =?utf-8?B?YklRQXZ6dnF1TUhwUlFyN0pDSmVJSzhZbkNvR25TeWRLdlk1QkxiQkdwLzcv?= =?utf-8?B?QVhPSFhHRnl4YnEyVHYwM1hJdU1pRGVZekpOZEdzb0pQQVduSk9aNHp0cE9J?= =?utf-8?B?cmdRQnhZWmV1N1p6NGJZbThXcWVONFVCRmtYRXlYd1J6MGJxWVVrK1ZEU2dN?= =?utf-8?B?ZW9EcW1wNmEwRDVubmIra08xVnUrbXpaTmZqWFI5VWNjdHlzNjR6dEhHTEFh?= =?utf-8?B?SHNyeFNGeUdyMklDdDd2Mk10NWk4NGI5NElCMkx2V2FpTzlZd3dEaVBGU2t3?= =?utf-8?B?MktmelFOSkgzbUxhUXg3NFJUUEVydFZ2bDBxQVFLR1RBb0hJekk3aUpoTlhB?= =?utf-8?B?K0xRaVlBNmVtL2xEbDJaeGI1b041ZFlJd2NhWFFUcmwySVFoWDhSbWxYNGdH?= =?utf-8?B?WTBDTGcvSmlsRGNja2FHdGR3blJVdzlEZkMvNlN0RXFNcWZtYUxlSmpBYTRw?= =?utf-8?B?aTQ4OVB4NjdubEE4K1hjZ1RWbXdsTGkxOHZneGJVVDZURHRKK00rZ2RiMzFT?= =?utf-8?B?a2FUdFhrcUtlTzkzR2FxUXZlRHRMQnlFMU9xemNURTd3cmZXcGZ2a2ZTanlD?= =?utf-8?B?TGFJZU1XRUZLUy9aZmMxNHVWVEJ4YldDSVpVMW5rYnpscEQ0MWozSFNoWGlu?= =?utf-8?B?SEJIODRCR1g1UmcvYzVSbVlEdkRKWFkxelFIMkRKRlNQblpoN1JiUThtRjk2?= =?utf-8?B?Mzd3WnZXUkhHQVA3WFQ2OWFoRFpQUW4rN0hIUm9NM2ZRaDBrQjlhNWxPdHNO?= =?utf-8?B?YUs4bXJyTXBVNVM5L0pIaDY5SlppdjFVWFRZRmp0RlV2aWtFZmMzWUFBbXV0?= =?utf-8?B?citjcjhMV1A3WjJtL0lBRUxWRUJSLyt4TzFQR3dPMWl1eE84aEpnNG1haVFM?= =?utf-8?B?WE9qWHJUQ1ZsV3N4T0x3TVhuRWc3Yitvd01uOTJ0cWt0SDkwMFIrN2pVV0JY?= =?utf-8?B?VFJ1SCtwaDVjbU5zdUxFQUlCNFVtT2k5UDFWNzlqcFlrTzFCWUhEZ1FkaWs0?= =?utf-8?B?aUFJZi9wWTJvVEl1S1NqTm5xcXdvMHpHckNCS2ZOMGRjUG10cVBpSk15YzJu?= =?utf-8?Q?8YwAC1j/KB+7H3CrrVPFs7cViyitbtq7O+G75cz?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-24072.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB0217.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 12ff68ce-f43d-4176-586b-08dcb7a0d9d4 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2024 11:54:25.6539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0P287MB0680 From: Kerem Karabay This commit adds a driver for the backlight of Apple Touch Bars on x86 Macs. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschal=C3=A4r . Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- MAINTAINERS | 6 + drivers/hid/Kconfig | 10 ++ drivers/hid/Makefile | 1 + drivers/hid/hid-appletb-bl.c | 206 +++++++++++++++++++++++++++++++++++ drivers/hid/hid-quirks.c | 4 +- 5 files changed, 226 insertions(+), 1 deletion(-) create mode 100644 drivers/hid/hid-appletb-bl.c diff --git a/MAINTAINERS b/MAINTAINERS index 8766f3e5e..ac27f41d4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9931,6 +9931,12 @@ F: include/linux/pm.h F: include/linux/suspend.h F: kernel/power/ =20 +HID APPLE TOUCH BAR DRIVERS +M: Kerem Karabay +L: linux-input@vger.kernel.org +S: Maintained +F: drivers/hid/hid-appletb-* + HID CORE LAYER M: Jiri Kosina M: Benjamin Tissoires diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 08446c89e..4988c1fb2 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -148,6 +148,16 @@ config HID_APPLEIR =20 Say Y here if you want support for Apple infrared remote control. =20 +config HID_APPLETB_BL + tristate "Apple Touch Bar Backlight" + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want support for the backlight of Touch Bars on x86 + MacBook Pros. + + To compile this driver as a module, choose M here: the + module will be called hid-appletb-bl. + config HID_ASUS tristate "Asus" depends on USB_HID diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile index e40f1ddeb..1d825a474 100644 --- a/drivers/hid/Makefile +++ b/drivers/hid/Makefile @@ -29,6 +29,7 @@ obj-$(CONFIG_HID_ALPS) +=3D hid-alps.o obj-$(CONFIG_HID_ACRUX) +=3D hid-axff.o obj-$(CONFIG_HID_APPLE) +=3D hid-apple.o obj-$(CONFIG_HID_APPLEIR) +=3D hid-appleir.o +obj-$(CONFIG_HID_APPLETB_BL) +=3D hid-appletb-bl.o obj-$(CONFIG_HID_CREATIVE_SB0540) +=3D hid-creative-sb0540.o obj-$(CONFIG_HID_ASUS) +=3D hid-asus.o obj-$(CONFIG_HID_AUREAL) +=3D hid-aureal.o diff --git a/drivers/hid/hid-appletb-bl.c b/drivers/hid/hid-appletb-bl.c new file mode 100644 index 000000000..00bbe45df --- /dev/null +++ b/drivers/hid/hid-appletb-bl.c @@ -0,0 +1,206 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Apple Touch Bar Backlight Driver + * + * Copyright (c) 2017-2018 Ronald Tschal=C3=A4r + * Copyright (c) 2022-2023 Kerem Karabay + */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include + +#include "hid-ids.h" + +#define APPLETB_BL_ON 1 +#define APPLETB_BL_DIM 3 +#define APPLETB_BL_OFF 4 + +#define HID_UP_APPLEVENDOR_TB_BL 0xff120000 + +#define HID_VD_APPLE_TB_BRIGHTNESS 0xff120001 +#define HID_USAGE_AUX1 0xff120020 +#define HID_USAGE_BRIGHTNESS 0xff120021 + +static int appletb_bl_def_brightness =3D 2; +module_param_named(brightness, appletb_bl_def_brightness, int, 0444); +MODULE_PARM_DESC(brightness, "Default brightness:\n" + " 0 - Touchbar is off\n" + " 1 - Dim brightness\n" + " [2] - Full brightness"); + +struct appletb_bl { + struct hid_field *aux1_field, *brightness_field; + struct backlight_device *bdev; + + bool full_on; +}; + +const u8 appletb_bl_brightness_map[] =3D { + APPLETB_BL_OFF, + APPLETB_BL_DIM, + APPLETB_BL_ON +}; + +static int appletb_bl_set_brightness(struct appletb_bl *bl, u8 brightness) +{ + struct hid_report *report =3D bl->brightness_field->report; + struct hid_device *hdev =3D report->device; + int ret; + + ret =3D hid_set_field(bl->aux1_field, 0, 1); + if (ret) { + hid_err(hdev, "Failed to set auxiliary field (%pe)\n", ERR_PTR(ret)); + return ret; + } + + ret =3D hid_set_field(bl->brightness_field, 0, brightness); + if (ret) { + hid_err(hdev, "Failed to set brightness field (%pe)\n", ERR_PTR(ret)); + return ret; + } + + if (!bl->full_on) { + ret =3D hid_hw_power(hdev, PM_HINT_FULLON); + if (ret < 0) { + hid_err(hdev, "Device didn't power on (%pe)\n", ERR_PTR(ret)); + return ret; + } + + bl->full_on =3D true; + } + + hid_hw_request(hdev, report, HID_REQ_SET_REPORT); + + if (brightness =3D=3D APPLETB_BL_OFF) { + hid_hw_power(hdev, PM_HINT_NORMAL); + bl->full_on =3D false; + } + + return 0; +} + +static int appletb_bl_update_status(struct backlight_device *bdev) +{ + struct appletb_bl *bl =3D bl_get_data(bdev); + u16 brightness; + + if (bdev->props.state & BL_CORE_SUSPENDED) + brightness =3D 0; + else + brightness =3D backlight_get_brightness(bdev); + + return appletb_bl_set_brightness(bl, appletb_bl_brightness_map[brightness= ]); +} + +static const struct backlight_ops appletb_bl_backlight_ops =3D { + .options =3D BL_CORE_SUSPENDRESUME, + .update_status =3D appletb_bl_update_status, +}; + +static int appletb_bl_probe(struct hid_device *hdev, const struct hid_devi= ce_id *id) +{ + struct hid_field *aux1_field, *brightness_field; + struct backlight_properties bl_props =3D { 0 }; + struct device *dev =3D &hdev->dev; + struct appletb_bl *bl; + int ret; + + ret =3D hid_parse(hdev); + if (ret) + return dev_err_probe(dev, ret, "HID parse failed\n"); + + aux1_field =3D hid_find_field(hdev, HID_FEATURE_REPORT, + HID_VD_APPLE_TB_BRIGHTNESS, HID_USAGE_AUX1); + + brightness_field =3D hid_find_field(hdev, HID_FEATURE_REPORT, + HID_VD_APPLE_TB_BRIGHTNESS, HID_USAGE_BRIGHTNESS); + + if (!aux1_field || !brightness_field) + return -ENODEV; + + if (aux1_field->report !=3D brightness_field->report) + return dev_err_probe(dev, -ENODEV, "Encountered unexpected report struct= ure\n"); + + bl =3D devm_kzalloc(dev, sizeof(*bl), GFP_KERNEL); + if (!bl) + return -ENOMEM; + + ret =3D hid_hw_start(hdev, HID_CONNECT_DRIVER); + if (ret) + return dev_err_probe(dev, ret, "HID hardware start failed\n"); + + ret =3D hid_hw_open(hdev); + if (ret) { + dev_err_probe(dev, ret, "HID hardware open failed\n"); + goto stop_hw; + } + + bl->aux1_field =3D aux1_field; + bl->brightness_field =3D brightness_field; + + if (appletb_bl_def_brightness =3D=3D 0) + ret =3D appletb_bl_set_brightness(bl, APPLETB_BL_OFF); + else if (appletb_bl_def_brightness =3D=3D 1) + ret =3D appletb_bl_set_brightness(bl, APPLETB_BL_DIM); + else + ret =3D appletb_bl_set_brightness(bl, APPLETB_BL_ON); + + if (ret) { + dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n"); + goto close_hw; + } + + bl_props.type =3D BACKLIGHT_RAW; + bl_props.max_brightness =3D ARRAY_SIZE(appletb_bl_brightness_map) - 1; + + bl->bdev =3D devm_backlight_device_register(dev, "appletb_backlight", dev= , bl, + &appletb_bl_backlight_ops, &bl_props); + if (IS_ERR(bl->bdev)) { + ret =3D PTR_ERR(bl->bdev); + dev_err_probe(dev, ret, "Failed to register backlight device\n"); + goto close_hw; + } + + hid_set_drvdata(hdev, bl); + + return 0; + +close_hw: + hid_hw_close(hdev); +stop_hw: + hid_hw_stop(hdev); + + return ret; +} + +static void appletb_bl_remove(struct hid_device *hdev) +{ + struct appletb_bl *bl =3D hid_get_drvdata(hdev); + + appletb_bl_set_brightness(bl, APPLETB_BL_OFF); + + hid_hw_close(hdev); + hid_hw_stop(hdev); +} + +static const struct hid_device_id appletb_bl_hid_ids[] =3D { + /* MacBook Pro's 2018, 2019, with T2 chip: iBridge DFR Brightness */ + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_TOUCHBAR_BACKLI= GHT) }, + { } +}; +MODULE_DEVICE_TABLE(hid, appletb_bl_hid_ids); + +static struct hid_driver appletb_bl_hid_driver =3D { + .name =3D "hid-appletb-bl", + .id_table =3D appletb_bl_hid_ids, + .probe =3D appletb_bl_probe, + .remove =3D appletb_bl_remove, +}; +module_hid_driver(appletb_bl_hid_driver); + +MODULE_AUTHOR("Ronald Tschal=C3=A4r"); +MODULE_AUTHOR("Kerem Karabay "); +MODULE_DESCRIPTION("MacBookPro Touch Bar Backlight Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index e0bbf0c63..818d41a35 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -328,7 +328,6 @@ static const struct hid_device_id hid_have_special_driv= er[] =3D { { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY= ) }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_= 2021) }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_= FINGERPRINT_2021) }, - { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_TOUCHBAR_BACKLI= GHT) }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_TOUCHBAR_DISPLA= Y) }, #endif #if IS_ENABLED(CONFIG_HID_APPLEIR) @@ -338,6 +337,9 @@ static const struct hid_device_id hid_have_special_driv= er[] =3D { { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_IRCONTROL4) }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_IRCONTROL5) }, #endif +#if IS_ENABLED(CONFIG_HID_APPLETB_BL) + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_TOUCHBAR_BACKLI= GHT) }, +#endif #if IS_ENABLED(CONFIG_HID_ASUS) { HID_I2C_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_I2C_KEYBOAR= D) }, { HID_I2C_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_I2C_TOUCHPA= D) }, --=20 2.39.3 (Apple Git-146)