From nobody Mon Dec 1 23:03:58 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBAE930FF2F for ; Sat, 29 Nov 2025 14:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427878; cv=none; b=UaMZRbly+qdpp8DnMXUrFH6nMdmFtOtUlt6LduL9ZVcztxUyW0faCKIghHKtCez5lVluYAcXqZNVNKVb92VeVItttKLtBlhBaTHP9ePtoPnPGkaIomXIlIL0N9fIlA6PEsaiLmVFcirt/GOfhWdaAoFP+s2NLutihNfoKrdZnPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427878; c=relaxed/simple; bh=k0aIXU/reI+53H81Ixsu15XtjHUspATirIgbwnqrpAg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tuLgeysy8+ZFKpMFOiZCuLwJdLd6XvsMvHpoJM6OvHlGg19gid9N+aP9B77a4DKtJIaoTNZso6k0OkwNoJmJTJMIbUcucpBig2CyQVRpN802lRUs2SZA9GrQ/IhygLa28TOdGXlmVMXnmP2tbCTSzfMJaT8h0zoyPE1PjuEzUJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e6QWul9e; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e6QWul9e" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b3b0d76fcso1686507f8f.3 for ; Sat, 29 Nov 2025 06:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427874; x=1765032674; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OKiAwlo9LZ0Y6EQWk7tLBh+YOq0wAbCqmwXrVpwlBTk=; b=e6QWul9eVkXu3AldsfdZpnEwyPb4cCSw2rh1580xlqie+o9vGgPGCc0I5vv7GD/9fQ 8l9D+fkMPTSZyBWQbrkpOOgHNIDevAhPplyFMUdwlZDrV7X3uzLEWGeUwK6uIykF3c+D VETW/vlda54+UFPfP1otbmf0VPW5bRimmi1zPMHJK20YwE+HlLRVmj8ocU++4LyIgdq3 ieEYIcto4zyTjqYdMMpNZ/+pguK5M0ByvAbSW1ZkVF007/U4mv0xvXjaGd37I9pGNktf LJDkYywSW89izgkZtrHr4PVrsR3QTptLRviMTJvYGlx1uV+zfgWqSL5SomRuTpgIYggA ScvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427874; x=1765032674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OKiAwlo9LZ0Y6EQWk7tLBh+YOq0wAbCqmwXrVpwlBTk=; b=IYf/PhYIpyEa/zF8DXs2221rWIzpIDwivwbBiROwFGd1jRRaqcPWnMJfqXcik6i1DI foG99g1ay+qv+3iFNzS06M4e7rAmFEJZ48yJSLU2ibF8wrt71KAwz/O7qcDgaH7jB+1s x9AZYcclZFdi06Xp9pHea+gCAcsxwTfKLnQ3t/RmYK4MIqgpIC+KUlJtkdwmnhPB2qJJ Rnlo4bSs304zTgYsRKl/72Rddsm+UjITO17ha/CzB7w1IIugEpigl+DKnC9TkggKnBI8 0j37YSKL/GOqyk6jz6fSne6jvRduuIaZVZjXhW6Uh+PjGJMRZEK+rfi5iZEQbdOS2IhW 4/gQ== X-Forwarded-Encrypted: i=1; AJvYcCUNk5qiGzJA3Zb1yNi9QZixodphZ2PtMP/8/cd6YmL2iG97iMlCaEwH9LP/Ub0YIv14+gQgGORPFhS1jIA=@vger.kernel.org X-Gm-Message-State: AOJu0YyAHxa0c6H1N0QKMF8vCeUV2MRS4zcKPt6FqiGV4GLEd0hFe5DI GQCoJ6Z9KZ1x8MLaWzY45GSUC1Jp0afpeQCPtdoAqmW7DBqvy+e2677KbEojDhPPgHs= X-Gm-Gg: ASbGncvDoZ+v+AijRJTEoygDFsxnfEoAtoujHY+FgHkNtGRTosP/2LszpBNIppT3qmv frz89OjvTpmvycIWB66GaNfzF5DIwVyEQ5AsW5slOojDSnq3BqkZYuaR9+YY/1km3iiTY3rdX8T HdgV5qnpAM+6nZnGBGRWdpspONCMnSxdH3+ILEs/uuYUUv5MMwyrsRDgLFL9yEhiTnXnw0WIpys 2naTkmHFUeV+QrSrm79aWMdyw9yMHrsgDccqMtm919DKFx/9O3s9EuaY5OwzYb/Egy8sYsDh42k jNZzVSPhPefx526K1nhzQHCGfRMq6qCnGKhdgpcWW/LtCqjbhgfZ4t9BZ5p9qxd/ZCBy7Ofiur0 MupOqgMmt8BbGUkSHF4WtVIYEDp/qFkqxsE/zuEi5Xo6ylG+k+ZKXklAvSAqPyiKRHQBqGoxY/v EOcYsoDe2ipeJqf/j6vBkNf+XgX5E= X-Google-Smtp-Source: AGHT+IGI6zgN1d5AOjsGAZRHPGRNf4EQ0mzqlTC7dJh5tDbKD0iL7abVcYqrVgB4mGVfZwt9HhaLKw== X-Received: by 2002:a05:6000:2387:b0:429:dc9a:ed35 with SMTP id ffacd0b85a97d-42cc1d3479cmr34440564f8f.43.1764427873971; Sat, 29 Nov 2025 06:51:13 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1ca1a303sm16609079f8f.27.2025.11.29.06.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:51:13 -0800 (PST) Date: Sat, 29 Nov 2025 17:51:10 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] remoteproc: qcom_wcnss: Fix NULL vs IS_ERR() bug in wcnss_alloc_memory_region() Message-ID: <09a43da41ee277a80a3265348831e747f7b62620.1764427595.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functi= ons for "memory-region"") Signed-off-by: Dan Carpenter --- drivers/remoteproc/qcom_wcnss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcns= s.c index 14005fb049a2..ee18bf2e8054 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -538,9 +538,9 @@ static int wcnss_alloc_memory_region(struct qcom_wcnss = *wcnss) wcnss->mem_phys =3D wcnss->mem_reloc =3D res.start; wcnss->mem_size =3D resource_size(&res); wcnss->mem_region =3D devm_ioremap_resource_wc(wcnss->dev, &res); - if (!wcnss->mem_region) { + if (IS_ERR(wcnss->mem_region)) { dev_err(wcnss->dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(wcnss->mem_region); } =20 return 0; --=20 2.51.0