From nobody Thu Dec 18 18:51:32 2025 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1402030B521; Mon, 3 Nov 2025 12:19:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762172360; cv=none; b=fkdHHTlHQEkqSu/fA/ONEbr2clU0M86ZM3WukGYs0DQ52VwengK1amkeyoQDblFO3hrDRRDSGDgThLJxySzUJK8WGPSIHtok6bSh0gwOQ+bM2itzRmyuSYqAMJnQggfyfJ22181iUDhoqrfOVuDE1rylb/eSxg4CBgATkBKcv/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762172360; c=relaxed/simple; bh=bFbT36IhSM2DLBDdtzHyTKyDgEpDz3AOrzen7/3kBjc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pZop9dfN6dfVw2BhHbxYHC/Dgu6qNkIuJIk0/4v2VvxlFXA2KNFCGlcCQDFfyfN3BsjH2cOQvzjvbEz+pM9mj/udrtQbbOYD2Yuf0jq17fGjs7+oyGLBYuKLczfH15+wmu3xlvdqaPweRrbXBxTa4y3BRPV799rqXfqB+imKMVg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1vFtWj-000000000on-3ySR; Mon, 03 Nov 2025 12:19:14 +0000 Date: Mon, 3 Nov 2025 12:19:10 +0000 From: Daniel Golle To: Hauke Mehrtens , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andreas Schirm , Lukas Stockmann , Alexander Sverdlin , Peter Christen , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: [PATCH net-next v7 04/12] net: dsa: lantiq_gswip: set link parameters also for CPU port Message-ID: <07c6b8d3a12296123be5e5938b454fc620f819e6.1762170107.git.daniel@makrotopia.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On standalone switch ICs the link parameters of the CPU port need to be setup just like user ports. The destinction in the driver to not carry out link parameter setup for the CPU port does make sense for in-SoC switches on which the CPU port is internally connected to the SoC's Ethernet MAC. Set link parameters also for the CPU port unless it is an internal interface. Note that the internal TP PHYs anyway cannot be used as CPU ports, hence it doesn't matter that they are now also covered by that condition. Signed-off-by: Daniel Golle Reviewed-by: Alexander Sverdlin Tested-by: Alexander Sverdlin Reviewed-by: Vladimir Oltean --- v7: no changes v6: no changes v5: no changes v4: improve commit message v3: no changes v2: no changes since RFC: no changes drivers/net/dsa/lantiq/lantiq_gswip_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/lantiq/lantiq_gswip_common.c b/drivers/net/dsa= /lantiq/lantiq_gswip_common.c index 092187603dea..0ac87eb23bb5 100644 --- a/drivers/net/dsa/lantiq/lantiq_gswip_common.c +++ b/drivers/net/dsa/lantiq/lantiq_gswip_common.c @@ -1459,7 +1459,7 @@ static void gswip_phylink_mac_link_up(struct phylink_= config *config, struct gswip_priv *priv =3D dp->ds->priv; int port =3D dp->index; =20 - if (!dsa_port_is_cpu(dp)) { + if (!dsa_port_is_cpu(dp) || interface !=3D PHY_INTERFACE_MODE_INTERNAL) { gswip_port_set_link(priv, port, true); gswip_port_set_speed(priv, port, speed, interface); gswip_port_set_duplex(priv, port, duplex); --=20 2.51.2