From nobody Wed Feb 11 05:13:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AA34C7EE24 for ; Sat, 13 May 2023 18:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236355AbjEMSJH (ORCPT ); Sat, 13 May 2023 14:09:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbjEMSI4 (ORCPT ); Sat, 13 May 2023 14:08:56 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10FEA1726 for ; Sat, 13 May 2023 11:08:54 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-94ea38c90ccso303351466b.1 for ; Sat, 13 May 2023 11:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684001332; x=1686593332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5/2jtntFcCEy2HLu74Pr7lsSBwQYzCqz7UQ3TltHgMM=; b=I7um9lN73aB3KVdmHhTH3v+3GZKH1TEyOVqVzE3qOHH1iCW447Qp2KTVwX++rS88dh 8kB+qG05V6xfO6mofnRgzfD8x9LW8ZGdQvrz+AVgCIzjznM4KidIqjNYIN8DnNVDvB1A /fnhWzH7EWRmjaeeUiIDx+l+X7UVyweDQo5kNMHY6/jopeAnaSNvkln2G1oNzs4OCb9T PrOuwuCra4E8/+Eg/WM8eAn4y8atBc7oNst+cSDZQ7Dg9CWpAjE+go6Z0PEODWW8qyEN d+re04MdYJCWWOanvrlQx8k9iOgRVqWvhHSjs4wEPljA89npi6no5rF5riWHFnwLCDj1 a0xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684001332; x=1686593332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5/2jtntFcCEy2HLu74Pr7lsSBwQYzCqz7UQ3TltHgMM=; b=TAVvn52IrywSigfKfSavtFjQGFUp+Fm2iZumd45MQzC57oktCE70MSDnr1RphbiZk/ drDLAoMksMj/c21vP9U7V6lytn3ui1cNNDfb16r6Q95Ob2wReKYYmlohpJN8p2wMCOEO Yt6aOPdxvDcr1bW2RpKMWdSlz1OpXJE9pteGlplgLrTXQ5XiOzkEooH/NbUCzY93ng1e Ix+04N9Kdylp7KG2Q7tErR7LC7+ZIxVjudGDs93XaG7sD72IqiAX+vYtX1jTKf6dFlEL mVA15L80cNMTNbepd5g1Kl/gwoD+QophgaFfkN56v8FCOqiFBT4rWQXd57GWkZ54CW26 JXTg== X-Gm-Message-State: AC+VfDxhQD3md9Uz7q32bBIcJjlvy5CGwgJSY0q22L3omhCsySdLlXTN oeecGIpZRUTY0acwA0JzIHo= X-Google-Smtp-Source: ACHHUZ4AcNbu25m6sJyt27XScjARpWHHXNOJ2uu2aSdEI+Rp+jk1TOoMGgmjiEM442HnQEuiN/Bkog== X-Received: by 2002:a17:906:14e:b0:965:9602:3ee1 with SMTP id 14-20020a170906014e00b0096596023ee1mr22936127ejh.2.1684001332326; Sat, 13 May 2023 11:08:52 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935e01.dip0.t-ipconnect.de. [87.147.94.1]) by smtp.gmail.com with ESMTPSA id va8-20020a17090711c800b0094f282fc29asm6887951ejb.207.2023.05.13.11.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 May 2023 11:08:51 -0700 (PDT) Date: Sat, 13 May 2023 20:08:50 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/9] staging: rtl8192e: Remove undefined function data_hard_resume Message-ID: <07048d775759fffe1d1c63d0416214da8311129a.1683960684.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function data_hard_resume as it is not defined. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib.h | 3 --- drivers/staging/rtl8192e/rtllib_softmac.c | 18 +----------------- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 10 +--------- 3 files changed, 2 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b356cde80f84..9b49a15de889 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1682,9 +1682,6 @@ struct rtllib_device { void (*softmac_data_hard_start_xmit)(struct sk_buff *skb, struct net_device *dev, int rate); =20 - /* OK this is complementing to data_poll_hard_stop */ - void (*data_hard_resume)(struct net_device *dev); - /* ask to the driver to retune the radio. * This function can sleep. the driver should ensure * the radio has been switched before return. diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rt= l8192e/rtllib_softmac.c index 65eecbc94b93..fe36a52b4c91 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1546,10 +1546,6 @@ static void rtllib_associate_complete_wq(void *data) netdev_info(ieee->dev, "silent reset associate\n"); ieee->is_silent_reset =3D false; } - - if (ieee->data_hard_resume) - ieee->data_hard_resume(ieee->dev); - } =20 static void rtllib_sta_send_associnfo(struct rtllib_device *ieee) @@ -2534,22 +2530,14 @@ static void rtllib_start_master_bss(struct rtllib_d= evice *ieee) ieee->state =3D RTLLIB_LINKED; ieee->link_change(ieee->dev); notify_wx_assoc_event(ieee); - - if (ieee->data_hard_resume) - ieee->data_hard_resume(ieee->dev); - netif_carrier_on(ieee->dev); } =20 static void rtllib_start_monitor_mode(struct rtllib_device *ieee) { /* reset hardware status */ - if (ieee->raw_tx) { - if (ieee->data_hard_resume) - ieee->data_hard_resume(ieee->dev); - + if (ieee->raw_tx) netif_carrier_on(ieee->dev); - } } =20 static void rtllib_start_ibss_wq(void *data) @@ -2674,10 +2662,6 @@ static void rtllib_start_ibss_wq(void *data) rtllib_start_send_beacons(ieee); =20 notify_wx_assoc_event(ieee); - - if (ieee->data_hard_resume) - ieee->data_hard_resume(ieee->dev); - netif_carrier_on(ieee->dev); =20 mutex_unlock(&ieee->wx_mutex); diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging= /rtl8192e/rtllib_softmac_wx.c index d7166d6772df..371864f0087f 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -389,10 +389,6 @@ void rtllib_wx_sync_scan_wq(void *data) ieee->link_detect_info.NumRecvBcnInPeriod =3D 1; ieee->link_detect_info.NumRecvDataInPeriod =3D 1; } - - if (ieee->data_hard_resume) - ieee->data_hard_resume(ieee->dev); - if (ieee->iw_mode =3D=3D IW_MODE_ADHOC || ieee->iw_mode =3D=3D IW_MODE_MA= STER) rtllib_start_send_beacons(ieee); =20 @@ -505,12 +501,8 @@ int rtllib_wx_set_rawtx(struct rtllib_device *ieee, ieee->raw_tx ? "enabled" : "disabled"); =20 if (ieee->iw_mode =3D=3D IW_MODE_MONITOR) { - if (prev =3D=3D 0 && ieee->raw_tx) { - if (ieee->data_hard_resume) - ieee->data_hard_resume(ieee->dev); - + if (prev =3D=3D 0 && ieee->raw_tx) netif_carrier_on(ieee->dev); - } =20 if (prev && ieee->raw_tx =3D=3D 1) netif_carrier_off(ieee->dev); --=20 2.40.1