From nobody Fri Dec 26 15:30:19 2025 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.197]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89B811A58B for ; Wed, 3 Jan 2024 14:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Jw9L9SfN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Now9Y nDkaSsHEHrDFSFBcDE8yy3D0lUh+jYhNHjxB6g=; b=Jw9L9SfNrJBd4s6kWTjbX G/ntiwm+fC8VvvhmuPERdxVtxQK8bkSWqPrNVs5hF20pSDgh3d/uAbyBuKQjvJ34 OekV8+HhsDiGuef0nqAG7WqQtNxod2BR87QxgShcCfOaUssL6//mu6HPnn4OBcGn Qg2L+oOycNOqJSZRvVMHCw= Received: from ubuntu22.localdomain (unknown [117.176.219.50]) by zwqz-smtp-mta-g4-1 (Coremail) with SMTP id _____wDnL+uEbJVlwe6uAA--.29037S2; Wed, 03 Jan 2024 22:17:42 +0800 (CST) From: chenguanxi11234@163.com To: neil.armstrong@linaro.org Cc: cgel.zte@gmail.com, yang.guang5@zte.com.cn, quic_jesszhan@quicinc.com, sam@ravnborg.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chen Haonan Subject: [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe() Date: Wed, 3 Jan 2024 22:17:38 +0800 Message-Id: <061ed94a003362bb7d7e9d3e4d38358c5b91c8a3.1704186827.git.chen.haonan2@zte.com.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnL+uEbJVlwe6uAA--.29037S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF1DJF47Xw4fXw18AF43ZFb_yoWkAFX_C3 45u3WfuwsrGF4Igr17Aa17ArWIka9Y9F4kuwnYk3W7tw1DG3W3JFykJFyDJw17WF47uF90 y3WfXFWFvF4fGjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8AWrJUUUUU== X-CM-SenderInfo: xfkh0wxxdq5xirrsjki6rwjhhfrp/1tbiQAlY+mVOAw9xcAABsM Content-Type: text/plain; charset="utf-8" From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER=20 and can return the error code, replacing dev_err() with it=20 simplifies the code. Signed-off-by: Chen Haonan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/dr= m/panel/panel-samsung-s6d16d0.c index 79f611963c61..f4103e762b53 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c @@ -194,10 +194,8 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi) s6->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(s6->reset_gpio)) { - ret =3D PTR_ERR(s6->reset_gpio); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to request GPIO (%d)\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(s6->reset_gpio), + "failed to request GPIO\n"); } =20 drm_panel_init(&s6->panel, dev, &s6d16d0_drm_funcs, --=20 2.25.1