From nobody Mon Dec 1 23:03:58 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A9A730FC33 for ; Sat, 29 Nov 2025 14:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427869; cv=none; b=KLgkmFu2PaFGBJLOqQ/oOP1o9oXNSDAiqSUeV7j3oNxJubFw2CvDk2sMpcxOW7ZcvqyRdbG/QzViOxbJEZ1sjeytEXXTkTCAnFlevvZ0jKx9OApOrwnoi4c4xxbjXWiaTBZIlBok+okJ4JbP3Q1UI32SpyW00vEeFFWWbqRtQVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427869; c=relaxed/simple; bh=X/RTVwC1oGN6z5Dka28hemcDQEwsfiKSfg6YdtWaW+k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XSRaw5Y4vVyA6EMNbjiIgNN7R6FNAZXEk665tNDzIPy1HgPrO7tJqocyk5NgvVRaRznPWdPP3IRX6NnTnhjqoG8A2y7OXAf8f0b74oLivw2JDDACO67eZi1lROirgNe3w33nj4bK8RWTxtu5smSk8lHWKo+BFW5R0/OToUaPQ64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Edb7YlTM; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Edb7YlTM" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b387483bbso2239976f8f.1 for ; Sat, 29 Nov 2025 06:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427864; x=1765032664; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f3+pjSj3t+U3wmCCuCdgSBWbp2oqy9bpefHhTr0B/p4=; b=Edb7YlTMKW3UOrRT81YS5BSR99iJ91d/nQS/bgTAUfcE05sG/LVymlvwCFxWNpIuA3 zGXTsdAZDAobQ0D0//VpI5OINXNMGFjLqr+C+xle/Sw6zUd+vpFTYtnPNmw53KJxMTEA 54vIEUB5Obth+i95O9p8DGH+2hmqwwQoiIqTILAR8GQ1Pn5nNRN46PH/mR2A9E07u5pt ieh2/qft8jTaczN2bbM9pgtn25azuQVtybOGwdzGotO6U6pwcNCawY0XElWB7gh/TqDu NPwfXWrQ3s5XdWIBxGO+nkwEQgPYVIaQVLUxlR9kdQPZSonkAjEXtN57rSwWf7Dyy+gB TWhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427864; x=1765032664; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f3+pjSj3t+U3wmCCuCdgSBWbp2oqy9bpefHhTr0B/p4=; b=us3pkY8FNTT+nl6X9ujuwvaFs0qAQxDzpwjPil9pBA3KgP/vB+tcA8KeG5xbjxwRIE BGoVhB/0CDElXfULHpWmrpuZwl18U3cCFGsFxiS+ol6YAW33sLp4DvHYfrvQdgYSSEtA tEOKrwLwYkEYvdoPsqs5z6TFi11O1u5gRujkxUt3Q8NViRd/+YkUS3gSBoYNkdwCQqnO Y9Xu2y0TDdHTbcVcHK/0HSxQL6OlXykDAvhyB4RWC3Lo7fXrlCavQnyfktoJ8ar7PwUq Bz1TxvvIaWcvIb0i0dKpH54gNX9VA+GZaObRyXTL8v0svI68/R5kfoy/o8U3jqhHvS0M zYNQ== X-Forwarded-Encrypted: i=1; AJvYcCWYxwM/yOxiiUNTjt/BTCOhVM9hFzctGJt2638NPJAUGmOscwVzNmjY8wJuoglMMZ3nVSMcG8fbsgRwcIU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyp4/DVPmKsZ6LSzhj1IjhGzptBncElXPwt2GLBwTbzIS91tXQo EZBLocyQWOuvZxmGc9s3CMjEJEB7vFwWTmmZw0s/g5qf7sV0/NvtzhaugM9wr9+Zjio= X-Gm-Gg: ASbGncsQNm8mm7gW5Ch3jFhjQA72piu9faB0NDt1C1UGNHO9a8O4fxXSwOWAfctS2Cg qdOIRbzFvf0m5QwWtF56bZgjCv+oP3bs/0okMtgbk0Hi57fAFwyn/KSvSonCvj284++x3+PMon2 SJbvKLmN9dEjgUg3biAKxhAfN679LLNvTp7gaLLM+J/IrNXVErDsWVs155goo58JLX5gwttoQP6 6i4o6w55Sbzc8G/peEYHv8u7mcvwl5gTt75yCEORQtGxbvAoN5OXElvQQB+nb3BNwF+I9UawrKJ Nkvny8AumvZkW7CWbwFfqjhJjJPd2japPm05W8mY03zrQOdYjw/HgSyjct1IQNc6cd+uwNHQiCi QA8IYeBLUDdBCXllIA+DofLB+6J+VKyuElSzvxQMpIw1bCpiWxyUihtFYvRT3xql43n+b2/NBuP pH1Zk4M06uoyNYxRkVFVY98dnHf0Y= X-Google-Smtp-Source: AGHT+IFXZI+MiyMb88/2TV0PWTJHmmEbApjR91PzKlDmX//1XB5OJjcUROKOaS3odKI4ruxOcHnq3w== X-Received: by 2002:a05:6000:2681:b0:429:c8e4:b691 with SMTP id ffacd0b85a97d-42cc1d5239amr32341226f8f.55.1764427864191; Sat, 29 Nov 2025 06:51:04 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1c5c3022sm16478970f8f.4.2025.11.29.06.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:51:03 -0800 (PST) Date: Sat, 29 Nov 2025 17:51:00 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] remoteproc: qcom: pas: Fix a couple NULL vs IS_ERR() bugs Message-ID: <0599691acc394d9390da8fa0b5de3399b132b187.1764427595.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functi= ons for "memory-region"") Signed-off-by: Dan Carpenter --- drivers/remoteproc/qcom_q6v5_pas.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q= 6v5_pas.c index 609df141ecb1..52680ac99589 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -559,9 +559,9 @@ static int qcom_pas_alloc_memory_region(struct qcom_pas= *pas) pas->mem_phys =3D pas->mem_reloc =3D res.start; pas->mem_size =3D resource_size(&res); pas->mem_region =3D devm_ioremap_resource_wc(pas->dev, &res); - if (!pas->mem_region) { + if (IS_ERR(pas->mem_region)) { dev_err(pas->dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(pas->mem_region); } =20 if (!pas->dtb_pas_id) @@ -576,9 +576,9 @@ static int qcom_pas_alloc_memory_region(struct qcom_pas= *pas) pas->dtb_mem_phys =3D pas->dtb_mem_reloc =3D res.start; pas->dtb_mem_size =3D resource_size(&res); pas->dtb_mem_region =3D devm_ioremap_resource_wc(pas->dev, &res); - if (!pas->dtb_mem_region) { + if (IS_ERR(pas->dtb_mem_region)) { dev_err(pas->dev, "unable to map dtb memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(pas->dtb_mem_region); } =20 return 0; --=20 2.51.0