From nobody Mon Sep 28 23:14:21 2026 Received: from e234-51.smtp-out.ap-northeast-1.amazonses.com (e234-51.smtp-out.ap-northeast-1.amazonses.com [23.251.234.51]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CB1B2367CF for ; Sat, 15 Aug 2026 18:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.251.234.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786817093; cv=none; b=Wc7Fo9A5r8NYqlUYp9pry748zuJmXiv9khAXr4ttUdQEmspIEpLqSqkKXMtQV9wHQVoFl12HsOS4ANydwcWgOEte3Xsn9hUID2RQpHRzYXyFEhUQs0bTyXia/ieqDHUTv8nfgavL0z0RgjH6gLYp07T+ZKA4Jf+nSAW5A31CQ6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786817093; c=relaxed/simple; bh=QjmNvelzMOr9+2S47rgY6JXOIrdM+gMspO+rX7Y+WBE=; h=In-Reply-To:References:From:To:Cc:Subject:Message-ID:Date: MIME-Version:Content-Type; b=SIUTkK89rQ+y81BZpcO+hWxjMvvgUEqicoDEzVNZcg3NgwtaStxevCyGs7r2Ym6JIhK7YcPq4rUZXRYH6eHMYsF/JxX3rIHUn5S4x+ZfOjX7LaHXHalaeOpQqOzfnLZVLDSpjF3ofB0SQAe6LfIOYOPHbJc8j0mHlAxHL6KYIzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ariels.xyz; spf=pass smtp.mailfrom=send.ariels.xyz; dkim=pass (1024-bit key) header.d=ariels.xyz header.i=@ariels.xyz header.b=unx5kXzO; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b=gloJgkzv; arc=none smtp.client-ip=23.251.234.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ariels.xyz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=send.ariels.xyz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ariels.xyz header.i=@ariels.xyz header.b="unx5kXzO"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="gloJgkzv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=resend; d=ariels.xyz; t=1786817090; h=In-Reply-To:References:From:To:Cc:Subject:Message-ID:Content-Transfer-Encoding:Date:MIME-Version:Content-Type; bh=QjmNvelzMOr9+2S47rgY6JXOIrdM+gMspO+rX7Y+WBE=; b=unx5kXzOfbzteXXqUwEQaFRChTFffuAWQUttS3QqZPHNnicNwS3lggdkTHSKTHQ1 JzPexQEPL7HAEGnDx1KUiooqW5KTxaJtcCh8wo5IePz4Zmpk6kQBnvNPH07i0YaWWbO /xlLLVwpkF9W8ipqNVQLLdY4ktOwCuQWRt/9ZcgY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zh4gjftm6etwoq6afzugpky45synznly; d=amazonses.com; t=1786817090; h=In-Reply-To:References:From:To:Cc:Subject:Message-ID:Content-Transfer-Encoding:Date:MIME-Version:Content-Type:Feedback-ID; bh=QjmNvelzMOr9+2S47rgY6JXOIrdM+gMspO+rX7Y+WBE=; b=gloJgkzvvVja+zsj0qrf4mi0j+9Tj/R7R6SHHyeu8XeR2Ft7n7Q6rVDidhykWIwi EGLgWDI0Rk92SaTuuLGrU/EI6eEgHEUIVGs5kqvcEUoSHQgdHGZQTFt0Oqo2UwF6sDs t4dMOo6jFNOSWbJUDYx1ZTYm602CZ9L/1C+4+0Gk= X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yWOzQ6CMBCEX8X07JptkSKefA/jYcCt1ARq2kr8C e8u4N6+5JuZ/aok0UtSx81XRRl98mGYwWw3qu0w3IT8dWZl2Fg+aEtt6HufzUi2KIqq2TsHAzX rjyjOv9aq8+XP6dncpc1LfjE6n3KI73Vr1IunWLNlDWZ2B6CsyYGl1k4IbGvaA44awFBVV0V1N aUpNYjXO+FBQ4i5E6RMeocenzAkSbv5R3WZpukHYQW6Zt4AAAA= X-Change-ID: 20260816-commit2v-63337b4ffa2a In-Reply-To: <010601a000f8aa59-fa0e91fe-a069-4aaf-baa2-79737d25251a-000000@ap-northeast-1.amazonses.com> References: <010601a000f8aa59-fa0e91fe-a069-4aaf-baa2-79737d25251a-000000@ap-northeast-1.amazonses.com> X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2400; i=ariel@ariels.xyz; h=from:subject:message-id; bh=rcITMzquYGdxg3Ng83WcZzZXdW6o61iLtosP5gJo3AQ=; b=owGbwMvMwCX2lfHt4U0KtzwZT6slMWQ1rLJrWHNy8x2xJ5Jt5XtKGNm8g8wSL88v22Nlmn/Fp zGYU8igo5SFQYyLQVZMkSXWmifz9tcIpyqXvvkwc1iZQIYwcHEKwESMdzP8DzsrdVeg/+/dyxcl PktIeQid8zabsG212Gd5O9/46RorDzL89+w+fnjxwf8Zj2eyREatT5i5Xfx9wKfiIIXmQ9N/SB5 O4AUA X-Developer-Key: i=ariel@ariels.xyz; a=openpgp; fpr=F3AB96E458C8098D8330A9FB52B66523B085EE81 From: Ariel Yu To: apw@canonical.com, joe@perches.com Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com Subject: [PATCH v2] checkpatch: recognize standard SI unit prefixes and symbols Message-ID: <010601a006991191-5959d04d-7d19-4128-b488-e51f6f97330e-000000@ap-northeast-1.amazonses.com> Content-Transfer-Encoding: quoted-printable Date: Sat, 15 Aug 2026 18:04:49 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Feedback-ID: :1.ap-northeast-1.mgmjTAb4xwNtpzB/mREvrmDZQ4OxUf0ABiHIN5l04830jQzqdlwGmixgGm7LBQvh3Kz2oC2td3ZcQFseAE2QdPZUOnVGoZ81dVKuFLncFOGtXIfvcMFT66YD6nPHHrfma6+bOqIeKVzUggBbRHUM6fVKU56vtKjTf78DNHTqfrMGdoXymh+08qzIIiH+aJBD:1.ap-northeast-1.DTXDV/V9GPBWozcllKo8innbNB2qs2O/3F8XZSzd9ZM=:AmazonSES X-SES-Outgoing: 2026.08.15-23.251.234.51 Content-Type: text/plain; charset="utf-8" checkpatch flags identifiers containing valid SI units as CamelCase. Expand the SI unit ignore patterns to recognize standard Syst=C3=A8me International d'unit=C3=A9s prefixes (u, m, k, M, G) and unit symbols (V, A, Hz, Ohm, C, K, s, W, etc.): - Allow mixed-case suffixes after the [a-z][A-Z] SI unit core, so derived units like _uV_per_C or _mV_per_K are no longer flagged. - Allow mixed-case prefixes in both the two-char and three-char SI patterns, so identifiers like clock_FREQ_kHz are recognized. - Add Ohm (with all standard prefixes: uOhm, mOhm, kOhm, MOhm, GOhm) to the three-char SI unit list. - Allow mixed-case suffixes after three-char SI units as well. Suggested-by: Andy Shevchenko Closes: https://lore.kernel.org/linux-iio/F9A182CC-62C0-445C-BAF0-9CDB7FFB3= 868@gmail.com/ Assisted-by: opencode:deepseek-v4-pro Signed-off-by: Ariel Yu Acked-by: Andy Shevchenko --- Fixed false positives in check reports with SI units, like , , , . Now these naming conventions will now be considered PASS. --- Changes in v2: - Rewrite all regex. - Link to v1: https://patch.msgid.link/010601a000f8aa59-fa0e91fe-a069-4aaf-= baa2-79737d25251a-000000@ap-northeast-1.amazonses.com --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2b7a42bbdd..a55d7085c5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5937,9 +5937,9 @@ sub process { $var !~ /^ETHTOOL_LINK_MODE_/ && #Ignore SI style variants like nS, mV and dB #(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE) - $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-= Z0-9_]+)?$/ && + $var !~ /^(?:[a-zA-Z0-9_]*)?_?[a-z][A-Z](?:_[a-zA-Z0-9_]+)?$/ && #Ignore some three character SI units explicitly, like MiB and KHz - $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) { + $var !~ /^(?:[a-zA-Z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz|[umkMG]?Ohm)(?:_[a= -zA-Z_]+)?$/) { while ($var =3D~ m{\b($Ident)}g) { my $word =3D $1; next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/); --- base-commit: d58772d8520c7ef247c4b95c9bd76d3a25da9ff5 change-id: 20260816-commit2v-63337b4ffa2a Best regards, -- =20 Ariel Yu