From nobody Sun Feb 8 21:17:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751413550; cv=none; d=zohomail.com; s=zohoarc; b=Lgcf16EM15iC2wANBGRl99evx8LZe+IKDQBFuoHUxDb4jlt2b8VNZtPlqwOMojlQaxlsqkHmJNQydgP9PZnXmSTIprXMsbB9qT+eLpZf9dF9CV7PMYEz2E+S0G9+627X78aZ1Cm8Z9pWJDuaICpPofmO2uNE6JUO17n2/3MIiXk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751413550; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=92xZ3mXFNRETY3/2tgdNdqUaxKhMM421vmXhjEX/B/U=; b=A0/TfDNtpSiRTGIO/Rm3HgMakeIEd8s6NOni8pgzSbMu2/Sd6XLyvj7zA3ahFiHUfk64Tw6psAhIQB8yppfaBDA557UHprkh7pTpkeEB1V8ZRlExKlvD4XKqKKZuWdm1xUxEfJQszJkxVjLfAS46Ccm1fcRaDgJpyyUObNz81qc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1751413550937693.1948632940566; Tue, 1 Jul 2025 16:45:50 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1030119.1403788 (Exim 4.92) (envelope-from ) id 1uWkfM-0000ND-4x; Tue, 01 Jul 2025 23:45:32 +0000 Received: by outflank-mailman (output) from mailman id 1030119.1403788; Tue, 01 Jul 2025 23:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uWkfM-0000N4-1C; Tue, 01 Jul 2025 23:45:32 +0000 Received: by outflank-mailman (input) for mailman id 1030119; Tue, 01 Jul 2025 23:45:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uWkfK-00085D-Sv for xen-devel@lists.xenproject.org; Tue, 01 Jul 2025 23:45:30 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 73e3a3ac-56d5-11f0-a313-13f23c93f187; Wed, 02 Jul 2025 01:45:22 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3a524caf77eso917477f8f.3 for ; Tue, 01 Jul 2025 16:45:22 -0700 (PDT) Received: from lab.home (dynamic-2a00-1028-83a4-4bca-c0bb-96ff-feed-9d50.ipv6.o2.cz. [2a00:1028:83a4:4bca:c0bb:96ff:feed:9d50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a87e947431sm14509037f8f.0.2025.07.01.16.45.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 16:45:20 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73e3a3ac-56d5-11f0-a313-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751413521; x=1752018321; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=92xZ3mXFNRETY3/2tgdNdqUaxKhMM421vmXhjEX/B/U=; b=DKliCH74jV/m80lT4ZLGL0mtI3BoYKFK8wvEb146fboxrLOdPeFq5I8yP8hZSyOJcl jXIUPJ4ujyC4QH9fU96sYLkPFT+heJLvJkL6/qtA5R37s2sQ1JFE5YhjXjtfwbiRbO0z 6PfptOQdRCjSnMsvyS2dHWfHTXs4PsuCDe9jRk7yJ8Q4G5p97thqfHiBSoqy3PgQk3Qs udJzRgssC8il8uHE1iMiJ8VwafEstxi2UhKb5MDZJHtxdJ7ChT/YlqDXuqlKEKjO01bM 0TiZECiDstvkw8QWpf/uzaGjiQbuAXD0NzUlwDcs/zuRE+FHeShy3Jh0FqAFbCmDYsIy 1a3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751413521; x=1752018321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=92xZ3mXFNRETY3/2tgdNdqUaxKhMM421vmXhjEX/B/U=; b=IF8wei2alwC2+XDLp2u6hf9E8t5HuHpGOfQA0O00QT2RaATlqTWHNjlKdGmNc4OXqS X6HoYzCvpdL0X5/4Lv28slXilKecYsIvPkM7rfihP7AV3IbMNCJ3ZmSe6r8adA4XQmQ0 NiroibVUU3PZSI1206LpyfKLLfUtEcwTBJHaDXWupeNGN84hOB84jlMWtTOe4ZZe+WQP v01AAgnCgpeyy/sQzkR30qkNTzpRdzzUcN0zr6DbZBGv3mZ6AssKqCjUgBZqzQdFYOO1 3289LfAG1ZyQVWVHXFdiKKFf2G6/V8j3nd6r2gv2WD461Y+7M9jrv/IfTP1Ssd7TfC3m ySoQ== X-Gm-Message-State: AOJu0YxwVCJwt/6QBIf0nPOKHxbrqn0dVJXPvKm8HEuE8omMPaXhhTR9 +iQY08YmVgiugtJzQJOvZ8Trlu8rEVnjqA4AZRJdpmChXelXYxmOzKbIK7E5Sw== X-Gm-Gg: ASbGnctMUsx2ELEGFYlZmEV/i9zpWnAEHBf5pdeY4ZUkUEdjRMCCEt2cvobb1mQePOE Bm4KDjz4pueHShkZiwBhFPhdVxhiQV5k6AyxM9vCyVJ6YJnWDSuDRy0VXwSjSPBoI2qwaqDOcNz UROyPyDt148fvjY3gcC7IGRXHs/xbm9lVqxOBSZCe3hOmfuwTK6u0tpE6QiEXvhQaq6+GQIJuYf BrpPHhpGp5516vS2MIhEMaXPBcBY5urRqYAMzz8ATku70aLjMCc3mQlZjJs//zJmW9S5qHHhR0/ nB4c/aKeQFQmG1n/RFYQErMtY9UkMNQsJssENuiPL/csHGmgiVaBdyiqMkDqpFKshgJge1dRMGx 5UbPjiskagwto1kjFKDaM/njbyto6YFJTFeAgwqVhcj7Zpz/+O5VYdAjx9H6v6g== X-Google-Smtp-Source: AGHT+IG+5cade+22b5bcAnDmgHCu1cUKB3rMPWWhzP6eHMo5Zjn0QhHw5BpN95JqD/SrFg5lGGBS/Q== X-Received: by 2002:a05:600c:3ba7:b0:453:59b5:25cc with SMTP id 5b1f17b1804b1-454a37207a8mr2489015e9.7.1751413521270; Tue, 01 Jul 2025 16:45:21 -0700 (PDT) From: "=?UTF-8?q?Petr=20Bene=C5=A1?=" X-Google-Original-From: =?UTF-8?q?Petr=20Bene=C5=A1?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Petr=20Bene=C5=A1?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Anthony PERARD Subject: [PATCH 1/3] hvmloader: fix code style violations Date: Tue, 1 Jul 2025 23:45:10 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751413553366116600 From: Petr Bene=C5=A1 Preparatory commit. No functional change. Signed-off-by: Petr Bene=C5=A1 --- tools/firmware/hvmloader/smbios.c | 56 +++++++++++++++---------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/tools/firmware/hvmloader/smbios.c b/tools/firmware/hvmloader/s= mbios.c index 97a054e9e3..fc3cdc9a25 100644 --- a/tools/firmware/hvmloader/smbios.c +++ b/tools/firmware/hvmloader/smbios.c @@ -378,18 +378,18 @@ static void * smbios_type_0_init(void *start, const char *xen_version, uint32_t xen_major_version, uint32_t xen_minor_version) { - struct smbios_type_0 *p =3D (struct smbios_type_0 *)start; + struct smbios_type_0 *p =3D start; static const char *smbios_release_date =3D __SMBIOS_DATE__; const char *s; void *pts; uint32_t length; =20 pts =3D get_smbios_pt_struct(0, &length); - if ( (pts !=3D NULL)&&(length > 0) ) + if ( pts !=3D NULL && length > 0 ) { memcpy(start, pts, length); p->header.handle =3D SMBIOS_HANDLE_TYPE0; - return (start + length); + return start + length; } =20 memset(p, 0, sizeof(*p)); @@ -438,17 +438,17 @@ smbios_type_1_init(void *start, const char *xen_versi= on, uint8_t uuid[16]) { char uuid_str[37]; - struct smbios_type_1 *p =3D (struct smbios_type_1 *)start; + struct smbios_type_1 *p =3D start; const char *s; void *pts; uint32_t length; =20 pts =3D get_smbios_pt_struct(1, &length); - if ( (pts !=3D NULL)&&(length > 0) ) + if ( pts !=3D NULL && length > 0 ) { memcpy(start, pts, length); p->header.handle =3D SMBIOS_HANDLE_TYPE1; - return (start + length); + return start + length; } =20 memset(p, 0, sizeof(*p)); @@ -496,7 +496,7 @@ smbios_type_1_init(void *start, const char *xen_version, static void * smbios_type_2_init(void *start) { - struct smbios_type_2 *p =3D (struct smbios_type_2 *)start; + struct smbios_type_2 *p =3D start; const char *s; uint8_t *ptr; void *pts; @@ -504,7 +504,7 @@ smbios_type_2_init(void *start) unsigned int counter =3D 0; =20 pts =3D get_smbios_pt_struct(2, &length); - if ( (pts !=3D NULL)&&(length > 0) ) + if ( pts !=3D NULL && length > 0 ) { memcpy(start, pts, length); p->header.handle =3D SMBIOS_HANDLE_TYPE2; @@ -517,7 +517,7 @@ smbios_type_2_init(void *start) *((uint16_t*)ptr) =3D SMBIOS_HANDLE_TYPE3; } =20 - return (start + length); + return start + length; } =20 memset(p, 0, sizeof(*p)); @@ -591,18 +591,18 @@ smbios_type_2_init(void *start) static void * smbios_type_3_init(void *start) { - struct smbios_type_3 *p =3D (struct smbios_type_3 *)start; + struct smbios_type_3 *p =3D start; const char *s; void *pts; uint32_t length; uint32_t counter =3D 0; =20 pts =3D get_smbios_pt_struct(3, &length); - if ( (pts !=3D NULL)&&(length > 0) ) + if ( pts !=3D NULL && length > 0 ) { memcpy(start, pts, length); p->header.handle =3D SMBIOS_HANDLE_TYPE3; - return (start + length); + return start + length; } =20 memset(p, 0, sizeof(*p)); @@ -653,7 +653,7 @@ smbios_type_4_init( void *start, unsigned int cpu_number, char *cpu_manufacturer) { char buf[80];=20 - struct smbios_type_4 *p =3D (struct smbios_type_4 *)start; + struct smbios_type_4 *p =3D start; uint32_t eax, ebx, ecx, edx; =20 memset(p, 0, sizeof(*p)); @@ -704,7 +704,7 @@ smbios_type_4_init( static void * smbios_type_11_init(void *start)=20 { - struct smbios_type_11 *p =3D (struct smbios_type_11 *)start; + struct smbios_type_11 *p =3D start; char path[20]; const char *s; int i; @@ -712,11 +712,11 @@ smbios_type_11_init(void *start) uint32_t length; =20 pts =3D get_smbios_pt_struct(11, &length); - if ( (pts !=3D NULL)&&(length > 0) ) + if ( pts !=3D NULL && length > 0 ) { memcpy(start, pts, length); p->header.handle =3D SMBIOS_HANDLE_TYPE11; - return (start + length); + return start + length; } =20 p->header.type =3D 11; @@ -754,7 +754,7 @@ smbios_type_11_init(void *start) static void * smbios_type_16_init(void *start, uint32_t memsize, int nr_mem_devs) { - struct smbios_type_16 *p =3D (struct smbios_type_16*)start; + struct smbios_type_16 *p =3D start; =20 memset(p, 0, sizeof(*p)); =20 @@ -779,7 +779,7 @@ static void * smbios_type_17_init(void *start, uint32_t memory_size_mb, int instance) { char buf[16]; - struct smbios_type_17 *p =3D (struct smbios_type_17 *)start; + struct smbios_type_17 *p =3D start; =20 memset(p, 0, sizeof(*p)); =20 @@ -814,7 +814,7 @@ smbios_type_17_init(void *start, uint32_t memory_size_m= b, int instance) static void * smbios_type_19_init(void *start, uint32_t memory_size_mb, int instance) { - struct smbios_type_19 *p =3D (struct smbios_type_19 *)start; + struct smbios_type_19 *p =3D start; =20 memset(p, 0, sizeof(*p)); =20 @@ -836,7 +836,7 @@ smbios_type_19_init(void *start, uint32_t memory_size_m= b, int instance) static void * smbios_type_20_init(void *start, uint32_t memory_size_mb, int instance) { - struct smbios_type_20 *p =3D (struct smbios_type_20 *)start; + struct smbios_type_20 *p =3D start; =20 memset(p, 0, sizeof(*p)); =20 @@ -862,18 +862,18 @@ smbios_type_20_init(void *start, uint32_t memory_size= _mb, int instance) static void * smbios_type_22_init(void *start) { - struct smbios_type_22 *p =3D (struct smbios_type_22 *)start; + struct smbios_type_22 *p =3D start; static const char *smbios_release_date =3D __SMBIOS_DATE__; const char *s; void *pts; uint32_t length; =20 pts =3D get_smbios_pt_struct(22, &length); - if ( (pts !=3D NULL)&&(length > 0) ) + if ( pts !=3D NULL && length > 0 ) { memcpy(start, pts, length); p->header.handle =3D SMBIOS_HANDLE_TYPE22; - return (start + length); + return start + length; } =20 s =3D xenstore_read(HVM_XS_SMBIOS_DEFAULT_BATTERY, "0"); @@ -927,7 +927,7 @@ smbios_type_22_init(void *start) static void * smbios_type_32_init(void *start) { - struct smbios_type_32 *p =3D (struct smbios_type_32 *)start; + struct smbios_type_32 *p =3D start; =20 memset(p, 0, sizeof(*p)); =20 @@ -946,16 +946,16 @@ smbios_type_32_init(void *start) static void * smbios_type_39_init(void *start) { - struct smbios_type_39 *p =3D (struct smbios_type_39 *)start; + struct smbios_type_39 *p =3D start; void *pts; uint32_t length; =20 pts =3D get_smbios_pt_struct(39, &length); - if ( (pts !=3D NULL)&&(length > 0) ) + if ( pts !=3D NULL && length > 0 ) { memcpy(start, pts, length); p->header.handle =3D SMBIOS_HANDLE_TYPE39; - return (start + length); + return start + length; } =20 /* Only present when passed in */ @@ -998,7 +998,7 @@ smbios_type_vendor_oem_init(void *start) static void * smbios_type_127_init(void *start) { - struct smbios_type_127 *p =3D (struct smbios_type_127 *)start; + struct smbios_type_127 *p =3D start; =20 memset(p, 0, sizeof(*p)); =20 --=20 2.34.1