From nobody Sat Jul 4 21:01:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1782826213; cv=none; d=zohomail.com; s=zohoarc; b=dpw6WkR9hwq8ZGohO52MHJ1EPm0xSnbAg/7xCii5evbQia06rnnaI0eedEoW/oIdammQ6tFV4ZNolULxHDLV3IZbTTt30gCKa1NwOXOzXVed1QVMqjKpk4AZPGg9lrqPVDmEtORK6TjFyCZxaF764FrUQLIv/R2m9hZI/jxdEf4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782826213; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=M9tmno+znSv/d2+fMnlwE81nLCVI/vorM28WqdREbFs=; b=CxWaIjkz1mVk/TxobEus7Gc86ZxK6Eu06LqjZi/NG3SC3BxIuUx75mTZhi8n+nqN3Nhp6ktAnieb87aL/p6DhEN0w6l6bb8k0VZkj5JUdAgm/Mil0tE+GKHHOpfimiGu2loQ8riV+OZKa3TGZKEevteXL8kuZqGNUhFB0M4fBlw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1782826213575543.9622083512685; Tue, 30 Jun 2026 06:30:13 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1348879.1606668 (Exim 4.92) (envelope-from ) id 1weYX6-0000uM-Sy; Tue, 30 Jun 2026 13:29:48 +0000 Received: by outflank-mailman (output) from mailman id 1348879.1606668; Tue, 30 Jun 2026 13:29:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weYX6-0000uF-Q9; Tue, 30 Jun 2026 13:29:48 +0000 Received: by outflank-mailman (input) for mailman id 1348879; Tue, 30 Jun 2026 13:29:47 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weYX5-0000u8-9L for xen-devel@lists.xenproject.org; Tue, 30 Jun 2026 13:29:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1weYX3-004aGV-Mn for xen-devel@lists.xenproject.org; Tue, 30 Jun 2026 15:29:45 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a43c4c5-e002-0a2a0a5209dd-0a2a450a9396-16 for ; Tue, 30 Jun 2026 15:29:45 +0200 Received: from [209.85.221.41] (helo=mail-wr1-f41.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a43c4c9-e40e-0a2a450a0019-d155dd29e82d-3 for ; Tue, 30 Jun 2026 15:29:45 +0200 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4629051c9d1so2604087f8f.2 for ; Tue, 30 Jun 2026 06:29:45 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475641e4618sm7681986f8f.9.2026.06.30.06.29.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 06:29:43 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Subject:From:Cc:To:Content-Language:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782826185; x=1783430985; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=M9tmno+znSv/d2+fMnlwE81nLCVI/vorM28WqdREbFs=; b=EI/xPCWwHgWkZQx1r3SgPm7QuzzsNUorBOUK556vgB2dDiPWb5b3/d4v0nY2AQ7Gnj tIffHkg+/czgO4653NJro4ls7kTxypyPQM8ySj02jXmZEp9AYXHorASUaThictduHxaH SiCL7frTXCAc/Rl8FfKn3fS+vkY+dolAzRnhEtEYMEZ7zBksVL3YVUBzpKeX4liMsRMA 5VxDB0rVJVNflcAmeV9Z4kZcXzVYR0k/4ioizLitrjPRIpR4jkaXsLhzDoMfCxH7CLJ7 F0fePqDS+fvSyHjwUhSspbVfpXwbC2BTtsoLjY/nK0GkcMdqFO/wHjMTdrMX6qtUWtUS Xy2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782826185; x=1783430985; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M9tmno+znSv/d2+fMnlwE81nLCVI/vorM28WqdREbFs=; b=l1qxZgEC4ajTUKmT3JgoacmQSZnopFbgFUzNPbVT0bLOTbw/8CVMHxu007JhxQ8Tla 6r+Ns5M3aTXZ7aESkH8cYZXDpkfK5NF5pIopJJUBMEeVzckY1KOQR+9pCb5rWpfZEWVx wL63Ti+jKuZqCVxv5YSGgl9OIhSsuiNO8WuFfM3vHP3c0TpD6Ay88qv77M00rMsf2ICY aY6cJu6RafZ6SgbfFYaC3swU0JEtswRgb8tACO03OCetgNMf5Gj2K61oaasaC2PU9T5T Trxupnk+sm1D50J1mSmnPN9YI6kYNo/eooo9CXzEBCnXkyj0QAq+xRToubpPlfuk4T8k Lh4g== X-Gm-Message-State: AOJu0YzSedT+S6hVCqz9tArJlMe3Wd+zRe4+JG61Zcu0EbUfcrOOrDid wglJGUYc4gO6oROnw9qi2lKOE9Z5J+lrunrok2SoqU41TBlg3xm5rwQzWwhMB0+hRPOq0dhJj5/ gwjyGMw== X-Gm-Gg: AfdE7cmH8aKavrPmwXYghwvHhbpFiwczV68AxjXwcPdiX7DTDzIiR/F2ul/Me6fH0t/ jKP88ymHnDt4D0n2Z6s6KnexGpRGV/Aswa9zw1TS9lOYlkHyVpTqhIeMAW61kHfXiyP6h49dOXf JSTC2LqISrm1FGT+mlf6bDmM7Lsioayt0LbHTKps3QuAQhB9kZCwPpqW9OsFceEhjQ0a1RdKvSZ C1dqYWfmXtp/V2mHVrk8pu9vr+KvwaTw0STjX8jILtoB9Jh4iiYO4ury2H9dqESMEEo8aXYzoFD ov8ytwfnvi5gg5xLi7kPCz32GCvF/krtvEcdSME/w58/1jbFHzXw9U7p6rQMGD3bU1Ub4Ig4kCN BREJ1fi7eRNKUUftv2m404A9zqATIg4TOTSSQpgB+HbPPtdV78knYqxNGyMwd9sqQIbkk4UDZ2T W4emXRnMXrjLo/0ZrIH9VEeHvTv+aGZ0EkkB0GQctCTeF+d23yv6NF62zJYtH9/IxRvDmo1tu85 /51 X-Received: by 2002:a05:6000:2408:b0:475:f0f0:9ec7 with SMTP id ffacd0b85a97d-475f0f0a01bmr2639945f8f.50.1782826184622; Tue, 30 Jun 2026 06:29:44 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 15:29:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie From: Jan Beulich Subject: [PATCH] x86emul: drop dead conditional from decode Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-4011c0/1782826185-D7D33DDE-534AAD68/0/0 X-purgate-type: clean X-purgate-size: 757 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1782826216096158500 Content-Type: text/plain; charset="utf-8" We know that opcode_table[0x0f] is 0, there's no need to check that. Up until ab082ffa87d5 ("x86emul: generate and make use of a canonical opcode representation") or maybe already c4e7a67e3a10 ("x86emul: drop SrcInvalid") this may have been justified, but it no longer is. This eliminates a Misra C:2012 rule 2.2 ("There shall be no dead code") violation. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -1082,7 +1082,7 @@ int x86emul_decode(struct x86_emulate_st =20 /* Opcode byte(s). */ d =3D opcode_table[b]; - if ( d =3D=3D 0 && b =3D=3D 0x0f ) + if ( b =3D=3D 0x0f ) { /* Two-byte opcode. */ b =3D insn_fetch_type(uint8_t);