From nobody Mon Feb 9 03:29:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1617884495; cv=none; d=zohomail.com; s=zohoarc; b=ELdheiKWMmE31fON9Z2HrBpQctLavHWXx59h92T8rGCN66u4b7oCacXaKSEoAuKaJ59KWj7vISzqNvUq1XREdsw+7dHGytJPuOxM29z4RCBX0JhpdFno/dg7so5QVRpi06/NRYSiiTJT1eqglKqicaasu8aXhrJ//QQjadMhtMU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617884495; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=95K+5XUUtlkYqbXmQ6a5fXeN2FQDprpFs5vXWIcZVZg=; b=FGKIl8hl7dBnbwCOlJORHvDvsrIan8b20wjMhoDepnppcZ3ezGT4eRJpz7kPgC95oh7K0YFhscuyH9SfffMeYnCwKJlD/yMqvnhaRxzAmKVIUW2L7Gr5VipfZw49xZo2EfOen8z/WR/MsX9y4MscX8BtRSp00vzHx51TKmzHDO0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1617884495977363.9038727781393; Thu, 8 Apr 2021 05:21:35 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.107266.205061 (Exim 4.92) (envelope-from ) id 1lUTet-0004zy-HC; Thu, 08 Apr 2021 12:21:15 +0000 Received: by outflank-mailman (output) from mailman id 107266.205061; Thu, 08 Apr 2021 12:21:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUTet-0004zr-DT; Thu, 08 Apr 2021 12:21:15 +0000 Received: by outflank-mailman (input) for mailman id 107266; Thu, 08 Apr 2021 12:21:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUTes-0004zj-Vc for xen-devel@lists.xenproject.org; Thu, 08 Apr 2021 12:21:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 76f69303-e529-4e9f-be2a-5819f072873d; Thu, 08 Apr 2021 12:21:14 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 783CCB005; Thu, 8 Apr 2021 12:21:13 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76f69303-e529-4e9f-be2a-5819f072873d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617884473; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=95K+5XUUtlkYqbXmQ6a5fXeN2FQDprpFs5vXWIcZVZg=; b=S9waDlL3HqvdRuOGtWJksVXo0t/AWmRdrboRuIw4xSAqDnTOnG4ob4TDErr4RliklvWgG6 Yh8WAQ13IqaSkqp3oq9jBS/nvNHXRAkAnud4v2DXIrkCfaZibMILpLSFjF/k/Xbyk8q+wF o03tS4X5ymR8WENgliRv5EGkTKWLmho= Subject: [PATCH 08/11] hypfs: avoid effectively open-coding xzalloc_array() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross References: Message-ID: Date: Thu, 8 Apr 2021 14:21:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" There is a difference in generated code: xzalloc_bytes() forces SMP_CACHE_BYTES alignment. I think we not only don't need this here, but actually don't want it. To avoid the need to add a cast, do away with the only forward-declared struct hypfs_dyndata. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/xen/common/hypfs.c +++ b/xen/common/hypfs.c @@ -72,7 +72,7 @@ enum hypfs_lock_state { hypfs_write_locked }; static DEFINE_PER_CPU(enum hypfs_lock_state, hypfs_locked); -static DEFINE_PER_CPU(struct hypfs_dyndata *, hypfs_dyndata); +static DEFINE_PER_CPU(void *, hypfs_dyndata); =20 static DEFINE_PER_CPU(const struct hypfs_entry *, hypfs_last_node_entered); =20 @@ -160,19 +160,19 @@ static void node_exit_all(void) void *hypfs_alloc_dyndata(unsigned long size) { unsigned int cpu =3D smp_processor_id(); - struct hypfs_dyndata **dyndata =3D &per_cpu(hypfs_dyndata, cpu); + void **dyndata =3D &per_cpu(hypfs_dyndata, cpu); =20 ASSERT(per_cpu(hypfs_locked, cpu) !=3D hypfs_unlocked); ASSERT(*dyndata =3D=3D NULL); =20 - *dyndata =3D xzalloc_bytes(size); + *dyndata =3D xzalloc_array(unsigned char, size); =20 return *dyndata; } =20 void *hypfs_get_dyndata(void) { - struct hypfs_dyndata *dyndata =3D this_cpu(hypfs_dyndata); + void *dyndata =3D this_cpu(hypfs_dyndata); =20 ASSERT(dyndata); =20 @@ -181,7 +181,7 @@ void *hypfs_get_dyndata(void) =20 void hypfs_free_dyndata(void) { - struct hypfs_dyndata **dyndata =3D &this_cpu(hypfs_dyndata); + void **dyndata =3D &this_cpu(hypfs_dyndata); =20 XFREE(*dyndata); }