From nobody Mon May 6 02:22:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1630933211; cv=pass; d=zohomail.com; s=zohoarc; b=dbOdb0ayWAsDE8Z8lxW08mFEPf/5tioKb6CiZDCFNPBjsc8DqYAULu9vHCiUqx3vT6ptmAj90jALDV7sJSIsDlRsNZUJbPtKTUqK69mQVNME3f8zxnTCxo2WSevr+EP9rvkks+fW5dHKvW8zDc/qtaDC/C46MIA+Mv1mt147VnQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630933211; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lYxRIiU55Up939f84d4QmJrnjJ7T0dm9h+/746Rq8MI=; b=O5s/J5CGBqcHoEixhg/6tyrlq7ovdNeOqj/R9GVapTqyCRfCtiDJjWbzlqTmvupHx8Ul5Qe7sPD4i5vj+5OHY/ZOys8HJgU6WuFwNdX1rsDRlNc7gPAcjDaf1k6Piu1F+ZD+4hgFZcuL7/edyg5S/A8ROOeky2xuVPLBNvvifbk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 163093321165871.47237180275965; Mon, 6 Sep 2021 06:00:11 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.179816.326217 (Exim 4.92) (envelope-from ) id 1mNEE5-0004rA-TO; Mon, 06 Sep 2021 12:59:53 +0000 Received: by outflank-mailman (output) from mailman id 179816.326217; Mon, 06 Sep 2021 12:59:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE5-0004r3-PV; Mon, 06 Sep 2021 12:59:53 +0000 Received: by outflank-mailman (input) for mailman id 179816; Mon, 06 Sep 2021 12:59:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE4-0004qY-Gq for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:59:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 52036839-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 12:59:51 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-9-xAUjZGraMhuknGFuXbTleA-1; Mon, 06 Sep 2021 14:59:49 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Mon, 6 Sep 2021 12:59:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 12:59:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0288.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 12:59:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52036839-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lYxRIiU55Up939f84d4QmJrnjJ7T0dm9h+/746Rq8MI=; b=TAsfWiHE7FZWYTewzBgpb+QG9gVW3kWFnzbDI6TYQZ4q61WIEVh0JLmWYfqCz7kJjy6nvA 1qLtePpTs+Wnj9fILoNt7kw9GlELIxxNVHIGvBKGLTJsNhYP47HtI9sp3/JMwOheLQWum8 /uC25cCoklG6xZH6UXkaBi6w6stIP9I= X-MC-Unique: xAUjZGraMhuknGFuXbTleA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLjHtcBlvctdvTt75iYoXLbCptmC1uoUlrqNiQmQOWmN5NMRBe+ubNquiHZn7Wq5b/C/z67M+RdwyNcjKJKh02ATQmXYOrLkVubin4yYYHIRfRSzSvkoVYatGqs0as1BQP0L+Y97lHeLfoZHK94JsMRT8IrlWfP3wQ2jgihURSI0tk14jvyx/GZ9p78FXtC4g63uV4MhEyoDHahdiEqGvXATD+T+FhreW3qXYUw3+ZaajRM/IfMyzUTDycSGZXgW88Gb2CFkJbNWnzUs08XmUmhZVZitKoQ55psDDzosUvTaLRNcIc80BeFRWQroEalriCgOHyeLqx2fVWiCJZc//Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lYxRIiU55Up939f84d4QmJrnjJ7T0dm9h+/746Rq8MI=; b=PF+1ThupuWkV23rBEb/AVG9YKXiiGvWzWk8N0RVdNnbRiY8A9Y1xfd0Ys2B6n9B8bIi5+yrhKDP5LlyHid8BZcSECQY5ToTb05h/ieblw7n0uV7xrluquc6TLnGeefGIMyWcvJLD4YPtwWKMfERKsEhykRZ0NCb1HRs3UY+d0sH4dsrTgiBMt7bSutsb4uqPk4cbmG9rhfWQ7CvulLnIJqeo1EOA1JeVxKl+J+t8wUXxcf0yL4fJPYZV6zu2vnAfKaEYcXMbeglndhz4/v5FSKxibFcor1TaHlfRrY1cAtnjJQHwHkvQUhi+InvBm1GMzwe/wH+JNRYImUUulv2h9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 1/5] x86/mwait-idle: mention assumption that WBINVD is not needed From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <0ebb0de3-2500-a9a2-8128-64b9d4a27cb7@suse.com> Date: Mon, 6 Sep 2021 14:59:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR0P264CA0288.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::36) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7171f000-7582-4922-d127-08d97136349e X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wklRinhSRVpDYvJdmegP10VvhuZJ/azd6SK3EM0JRoO+jeONCwEo0dDrPHZIuQDrxm31/i3doby2IO5X3Wz68ierdfXcSEQM2b1PfiWoOmdmpUqO+6Oi03hx01V0Eo6076ekcEruFFs4nxaAbfG5zttp/Y/N4OJSmiY7ON7Z8UlRomzcDiWYsd4cO02iRWeIb0oJEQiAKz3YSsgpkDBoABzVH2N6/OzjzKNjFLnhVPvddGwkOn/Dd8tij4ivx3BaLAmWM+UVlCVgSONrteD0Xertv70pBHzmFKTjmKlyilsJvsnbL1hswMy4m/7yzCahsRflgR0HKzcUii8TplJ501Nwe4EIDsQfYy2tsPWfJZDjEYQKQvvEZBstvNfexOmA1z6O8oqTOPZegnxl2mIkOQNz4B/LU6Q5CvnMfanNE8MmrDOmbejoWYX/dA9YCrjxaKZKjeuUDhkZPS+PTlOs6jRKke0xOy4FkA+c74HRnfIOVYl9RZkoe9SeMhT8ftCWHnYgMcTBbhV8pMtYhtXg8GMdw/5oNRmk1yUFURpWsPN6wL6YyPf9JQ6lqjaS45Skf4pCWP6emhg5ORp4CcytYlwwIF0wfU3w4cmADcR5BKnI8oLy4p0uuLLtKAtK4YIIAzzRzFjdHiGwTYy2ukJpPTBFn9qjiBMS1lyB4S4YK9JRh8pSndGvuwK6PL+fHSpVLmUh/g4RWA5QTvEAJqlS6Bt8ORLpgHHUMVQDcWzSPwc/sudAHLc8DanABn8qZWic X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(346002)(396003)(39860400002)(376002)(16576012)(54906003)(478600001)(316002)(6916009)(2906002)(31696002)(66476007)(8676002)(186003)(8936002)(26005)(5660300002)(4326008)(6486002)(956004)(31686004)(66946007)(38100700002)(36756003)(86362001)(2616005)(83380400001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjdKRVdDUHVmT1dlNmlJcW9TekoyUk14eXJOeU1iY1YrK3ZPd3FRUU5KeFRF?= =?utf-8?B?YlpubWpLMWtuaDM3dm1ndVJpVXFQSnRUUzArYUJKVHpiaGRrZkJuM2FyRWhB?= =?utf-8?B?amI3bm16QkYxRmRIY2liVkJHRE5hRkVGNWpuQ3U2SWpLajBQWEJaTG5QRW5M?= =?utf-8?B?TVZZSUxFSU8zcXgzZmJnZU56SWtWaWhiU0hQd0wxZjIycGYvZUZ4ei9zK0FE?= =?utf-8?B?aGRmVVdjSjZQMzY3VGIydFhqTFJmUzc4UDFMVDlIQXN1aEhpRTkrVU00MTUx?= =?utf-8?B?SkxvZ3RtR2Y3Y2FtTTNYYm1FbjFmTklhQnhETC9TdkxIV2xBMSsxenRkWUtz?= =?utf-8?B?ZVlzdVdEQlE4Q2t4clhDYmVsemRLYzZjSFhhYm1VeWx2S0x6TnB0RGg2eUtH?= =?utf-8?B?S1RVRVVPSVA0bVE5NTExTzJ5bWpYUVpzNHhIMHZNVnBCU0ZNS2ppUDZySnkx?= =?utf-8?B?N0dZUFVpSGlNYlMwSEI4QWVzek9lU3Z4OUl1UTd1ckJvRTJNR09PUmtheVdW?= =?utf-8?B?OExReC9nVHliVVArNVNQUVI5dDVRamYzbGd3NXhTRFBNZU1qdy9rZzVTUlFq?= =?utf-8?B?VG9BUGFPeG9BQitHWUtMV3ZjbkF6NHF3K3MydnVOVngzTkZNVVZoNG1jQkxC?= =?utf-8?B?aEFyUUJuY3lEV2oyb1hxTWNxUU95V0YyN2dVRHRTZWh3WE1OOHl0R1dNbkxX?= =?utf-8?B?R29qNWhSTjBBZDQxQWhjSW5kYkhpZXlPY1kyM1FmR2NEeW9SMHpQMi9VSllx?= =?utf-8?B?QXRSWUlBTk52c0JKVDB2S3YxT0VwMkNYOVIzTllZWGtPZmI3VThpMEtabkcr?= =?utf-8?B?ekhjMUJhT1N3OENRRmttcDJFRlZYL0o4bVA1ZVlQVUtyZFhPdGNBcTZZNjFK?= =?utf-8?B?RTN4d29NbDNob1ZqZXBoaE1HR1ZyOUhrMHM0QUNERHhTZ2VidmVqVkt0RUY5?= =?utf-8?B?Y1pCNEsvUUR1RW1mVGFscm5ockNYZVZFQU5QNzB1dCtFWnlXeWR3VDVUWTBB?= =?utf-8?B?SlZjVjRlUEU3bDNnRllnOFRCL0VUUEFnV3N6M1pVNGREa2IyYmF6UzdBeGRv?= =?utf-8?B?Wk5OWGh3QXUyV3Jzb0pIdDhlUDdQaXVSb2Zra1NMbVh1LzNheVZrNnIvaitm?= =?utf-8?B?ajZqcmZOYmNLVzhPb3h0d2M4UkpiOEpxL1VzTTMzRVMzNGVydFBwUEJmam5V?= =?utf-8?B?bGQyWlpGb0VVVTJPd2xLUENPVFcrYStIbUQyN2V0bnVxbXZUbXk5Yko5SXNP?= =?utf-8?B?NXhFejNackpNRUtYQW5HSzNjS2NNRUN0WlRpRERwVXlUUTU5VDdGQ1plYXB0?= =?utf-8?B?U3NVTW9CWGp2b2s0ajdMeTJmRjQ0b3lBZDhzc0Jxc0dzYU12VGhNbCtoOXBT?= =?utf-8?B?dE1GK2Rhb0FiQUJEVHh5TEM1NzJCMUxZWjJSTDl2MDgxdW5ZaU5mMTJiYSty?= =?utf-8?B?ak1Wc2lSU21qSEdDYjZ1bkkxUlM1eHphVHRtbU92RkFtSHFlcHp6ZnV0SVJB?= =?utf-8?B?c2xBQlNQM042aDkrNHU5UzBIdEdtZzljcWFUeDFNVnZaSWFCbG9MeTdhOTU3?= =?utf-8?B?TUszZkFWdmZVQ1RBMmhDcDFETVhvV3RYWUZUT3pHZWtWVTJ3U1dmNHE0dVl4?= =?utf-8?B?Y1hkaTRmNFVNNDhyMm9VSHpUNUJqRWxPTFZYczR2WHpkenRXdk5XRjhmOUtM?= =?utf-8?B?U1p6QWkxL0ErSXZyNkUraFlJUmFQTnY4anczMkVjVUxkUU9MZVQ5TUU1Kzkv?= =?utf-8?Q?PI9XIL1uEwWqncUrWy/aSwU36jrDd1X1UsZNY4Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7171f000-7582-4922-d127-08d97136349e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 12:59:47.5361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HqSobVfJ3c2p3fXDjWInCq+5ruoGY8x9/vU4bs9CSCmzW2E0UsiD53GkKIhd4o6HQl1fd2aqdwkm16KZmow+PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1630933218919100001 Content-Type: text/plain; charset="utf-8" From: Alexander Monakov Intel SDM does not explicitly say that entering a C-state via MWAIT will implicitly flush CPU caches as appropriate for that C-state. However, documentation for individual Intel CPU generations does mention this behavior. Since intel_idle binds to any Intel CPU with MWAIT, list this assumption of MWAIT behavior. In passing, reword opening comment to make it clear that the driver can load on any old and future Intel CPU with MWAIT. Signed-off-by: Alexander Monakov Signed-off-by: Rafael J. Wysocki [Linux commit: 8bb2e2a887afdf8a39e68fa0dccf82a168aae655] Dropped "reword opending comment" part - this doesn't apply to our code: First thing mwait_idle_probe() does is call x86_match_cpu(); we do not have a 2nd such call looking for just MWAIT (in order to the use _CST data directly, which we can't get our hands at _CST at this point yet). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -31,6 +31,10 @@ * * Chipset BM_STS (bus master status) bit is a NOP * for preventing entry into deep C-states + * + * CPU will flush caches as needed when entering a C-state via MWAIT + * (in contrast to entering ACPI C3, in which case the WBINVD + * instruction needs to be executed to flush the caches) */ =20 /* From nobody Mon May 6 02:22:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1630933270; cv=pass; d=zohomail.com; s=zohoarc; b=gN8iVL99mIGhTtNYzMWNGaKAo2WrDQ1qUW/zYEWSFMPNuFY98ENHijpmprwtavJN+VgTKxtonfgkNhzdb+S5P/BXplbSH4CE17pdSyYu5KboirB5ItzYIgV58QvxhDPf/5hwvitUNsONpJegME/aHCkHiTisG00X4s/l/GGQz9E= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630933270; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dbwG033IYOy80/NWLE0KFiBS2xDM7Ke8HGRpzdh07P8=; b=SC2P9HFKeRQXVcQbUp1Uv7WjABhCQVY+3SClwMkQ+kceXMLAVR+cuGXRJ+/Vu8lODnGnBcR1ixcdJ7Sa+8rf4fWiUtGOTincP01kg19Wz4fx/VhShHXKrAd4dRcwI4BgKppHusp5VEjFKA753npdnD1OzAz0Nt5AY7+3tcSTHvc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1630933270932324.7756313225791; Mon, 6 Sep 2021 06:01:10 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.179827.326228 (Exim 4.92) (envelope-from ) id 1mNEF3-0006Tj-7k; Mon, 06 Sep 2021 13:00:53 +0000 Received: by outflank-mailman (output) from mailman id 179827.326228; Mon, 06 Sep 2021 13:00:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEF3-0006Tc-4R; Mon, 06 Sep 2021 13:00:53 +0000 Received: by outflank-mailman (input) for mailman id 179827; Mon, 06 Sep 2021 13:00:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEF2-0006TU-AQ for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:00:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d7f79551-92a2-43cf-8f1d-71134edeb319; Mon, 06 Sep 2021 13:00:51 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2058.outbound.protection.outlook.com [104.47.5.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-6-9Bx13LP0PrKwqSeciJeBJQ-2; Mon, 06 Sep 2021 15:00:49 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:00:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:00:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0185.eurprd02.prod.outlook.com (2603:10a6:20b:28e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:00:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7f79551-92a2-43cf-8f1d-71134edeb319 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dbwG033IYOy80/NWLE0KFiBS2xDM7Ke8HGRpzdh07P8=; b=XgWq3RIqJvoN4psFBGnchKCfQbvC/8Vta8PECiyF1/8RoOfHmaZxWexuxyco2G0CRhjoNd VBmbaz8UpiaZjE8WQIL/NX8NwjqiNsHv2aB/sHDnPoABDalEWCh83pXp5wjVfNE4lyv8aO sOOhlD0Jmf8bXIJNvUdk1iCztpU4CWU= X-MC-Unique: 9Bx13LP0PrKwqSeciJeBJQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iFaY0g6K971tMrHClPEJn3tNCVWy2LI8T2tjRGy6BHgpPB4FB4MKe7Wy6mZI4qifrcH3+S/CnUsN7DuggklVQ+yJCElaEH/lPkKFMxBdIz0Chnu+NtHRVuxhZAGQY2o3JMOvzQc5tdQ9dmJ5RVAgICtYP1UF7nJ1qeNmpJ2PNSXAkJnagNIQkGu8ZyMc8EGwoYIzunBVlJN5cz5lilnI9x8c3pOc9xJLUp9lFJNJ7QAMEo9IWOGgB603EMwqsIFw7DQhgzbcaq7aID9DntCXxF3+bSFWHGMnbK+t0EgMDGl/pIARbRsJVzfo+SwiQClGwjxnZFqwWhHzbKNFmVvm1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dbwG033IYOy80/NWLE0KFiBS2xDM7Ke8HGRpzdh07P8=; b=QVkNP6lP5NN+6SQIXjVDOKxQpBEn9ySo6Qa4+Gj49AEMyj8RQolBr+S/Oz5m5eLffTMqpjkIPtzOePT/YiJVNltyKwh76oZbFPHrkkQ3Bl2oTVnt4g1+vrCNGleu6ibRZvSJnypAbtL+hOSqYFAMcKBsb5Xd67ukHETiDC8VfyLmwc/GAR/zbKjYHuZHiwOFQufO0w45g8vVI0HWFdoPOyhGaeKaBAsJqpx4ThuoYeiYiLVlMQJsub2qB9+H2Obk0fxFOb7HFAdWg+LC9oD9AUGbK3vtoqVCFnhYfAAPCMlN0aRNJofdosJ5kIhKC9fsLxPEUAJK8fRxcOUp4tco+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 2/5] x86/mwait-idle: add SnowRidge C-state table From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Mon, 6 Sep 2021 15:00:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0185.eurprd02.prod.outlook.com (2603:10a6:20b:28e::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a5413c7-79c1-4ce5-2931-08d97136587e X-MS-TrafficTypeDiagnostic: VI1PR04MB4608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UvanncNRt3CVO5T4rfui0iaRvjPOLgPVLYFajDhaE8raOtDWDiFid9eL5OCMnTAPwJPTFEkJ/fVkSd01EZGhsIKu39kgI42aIeeVe6m0Mau29B8Puqd6/JI5TXi3RaLs4T/R2Qw6sGXbWGM5F7qAyBTwh8kO7dgJ0610WFWpo2R+xBtdbY5luhgrAlSsF5dNxOTXJel+XR4vG0K2sKSDvZkOQd/7AroTBsLbCs9VMI1oRBfRWvoFNPST4Q/BnxuUnrPpAip7c/u4CpChdzKSqm3WDkw4G8z7SL+vtRF5bGBP1kIKmiED1/QLuKkEDtCsa0SvdkpzdqHdHTzf/AbqrWlJZjg4XTHp4x/9wU4sUEwLc9UOxYaBhG+1ltjPmoFpA9dOa6lbePFtpx92XFnRf3OHeCMxVFFFuaLMiyhklj7CC/AAhkr6k4FNLAywSSsI0EYz79kscZMb9BgJJ0PksmYTb7EqPk3S0kQyE/brt5HTWFON1YPbOFG9a5NiuHKYZCrqwrsGeKF50r5OLlLxIakCUQcT9+2RgqLmeeb2YCqJ1qHLz9l8Cv+bnmf/ZxOnN7DJwSCCx92GRYOb6rj/KYOcE+8jlsOLCHWLQcIkzBy3XdBx8tXK4dSVMX6Lwg4sxDajZzPK5sysUYN2U52XKwrysxejAkablqoVE8eMc3QPXLt3frMEmvjdkI8LcXxVJrt/aegDYidFiC9A2GPfoP4AYn33NolW8hMXKIrN9lk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(366004)(396003)(136003)(39860400002)(66476007)(66946007)(54906003)(478600001)(5660300002)(2616005)(6486002)(16576012)(8936002)(2906002)(31686004)(8676002)(316002)(956004)(4326008)(26005)(6916009)(86362001)(186003)(31696002)(38100700002)(36756003)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGdQazlYVVRFQ2FvcnVYYVRPQndnMUVUelRUSWNFaFdmRWxrcW8vSzJSWGNt?= =?utf-8?B?akdHTXp6bzU5c2lQTjdqelZkcDZrSW4wY1NsRXpwcEpxZlBnTGlTZTVTNWZK?= =?utf-8?B?KzJjb1k5aHY4QWFnOWJGWWhPSXM3THN6b0k5YmRRa0xJUUpqc1R0dWg1VVNl?= =?utf-8?B?cjJpTXZ6cTkzNFhBdlA0NHUyM1FraHJSZ2VabjMvZFZ6azZRK0tybnh1NUVp?= =?utf-8?B?ZU9saE44WkJHclJOQVAwbFNWRjBKb24xK3puMTVHWGJya2xqaVkvQWVDMWJy?= =?utf-8?B?U0k5VXZNNllVUEdmQWJqYWxTUEtmTEVuWlNtSHBIZFVyTCtINEQ2bWJEVFYx?= =?utf-8?B?Q1IwYWF4bkZsbVUxSW13TlpFNEs4NzJKT3Q3OERhaktueU9VM0psYWZLQksx?= =?utf-8?B?VDZiUVo5b0l1TG9UWXhTTmZjYzM0UzhUV0dlNXA3cStJZjlXa21WTHhZUkls?= =?utf-8?B?aFBwU1ZJejRaa05HM014VVMxd3NQbGhpUVd3VHZjS0FnZ2dSVnJCOXVpYXNJ?= =?utf-8?B?aVBKMVNCL055NzRlSVhuQU1zZFpYVFBORDlUUkNWMW03VE9XNFFQdGRURU5C?= =?utf-8?B?SmV4V3VjdWVDM2o1MUg4MVpiVjRNbEYzTmN3UnJScTVTYTQvSDl1aHIvN3Q5?= =?utf-8?B?Vng3d241UDlUU0U2enFLRGlITFdET3hVblNERU9OaVpNSFd1NnlWUEViVzFL?= =?utf-8?B?RGo4ZEdlbndWeVBKbm9jZ1UwaTBnd1U0R2FIM3ljYktOYXNaN3FPR0ZPd0h4?= =?utf-8?B?ZnVJdmVROEFNMzd1TWl3OFV1dGFYaityRDFVcDZnMzByRm9ZeE1UTUVvVDV3?= =?utf-8?B?VENHRjFFaCt0SFpSR3RJQU5JSkxlUlJRblNnVm93dlJWd0lCbTFWdWdhMXhF?= =?utf-8?B?U1VVVTh2eE1mL2ZqTXNBYzlyY1Q0VFBCUS83a0pEdVJzWVhQZDVVeXlxcCtF?= =?utf-8?B?cWl2aUFha0FDcEZET2x0ZzBFYXFXbnhsc0p4dk8rRTlJcDU2ZEJMNSs5K1Zx?= =?utf-8?B?TFY2UERwVGpJNlBrZnMrWmhrVXlQSzEzVzM4NlhKbm9lVUtTNGFsVmE3dGx3?= =?utf-8?B?VkcrL2FLcGZDcjBmMUtkc2dscmpRTUh0NDlSQ3pwY1hZeHh3R2l1Sk4reGNk?= =?utf-8?B?TVhscXk0RHc2VVdBbnMyNnJ6UXVGTXJxSWFvTGlyblBrUnBrYTZOYnF3T0tB?= =?utf-8?B?dWhUU2JIZW5YakV0c29STmpDRmhMNU1KMnh1Rnh4Mk8rZ1kvQkRqU2YzMlFa?= =?utf-8?B?S1J1cVgwczkzc0VXSDZJRHZ3bS94ME5Weks0b00vcEE2dFdMTDBzekRxeVNL?= =?utf-8?B?UFNYaUJObmx2eGFvcEVwSDBkS25CWWZHTUtKTmw0SkR1Tm12QVQ0MGh6Tjlv?= =?utf-8?B?Y21TQ2NIemU5SE0vK1IyenlsOXQyenhVOWFGTVRkTTJ1YWloRWJoTWVucVJC?= =?utf-8?B?U0VOVGdKTXRJZjZWb2VJbW5HQXlHbU84VlB0TE5FOFkrTzRubkdYOGZyQkJT?= =?utf-8?B?bjRKMWU0K1pwc3I2UTc2N1hlMi85WXFpMlg4MWY1VlhOSzJOQ0hnQTVGczl1?= =?utf-8?B?THp3UU9GRWtsVVFPSHI5Sm1pK0dRdmtjbVFpdEMrVzUvcUpSRmJ2QUJTeTZX?= =?utf-8?B?RFNGTVY1VmUrWHZLZTlBVEpWQ3U5aTBaSUVubzRsaE5sNW02UDZTS05GYUFQ?= =?utf-8?B?MHRFeExQcDB4OThkVUwvMGE2MUV5NzVnRmFDRjlLN3hHczYwQjBQUXQ2RlE4?= =?utf-8?Q?WYU2dVH9UHMJXzxfqcdUVpFYl3z8QEef2XWjqF9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5413c7-79c1-4ce5-2931-08d97136587e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:00:47.7291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LM5RyPaoQrPL30amNzacVtuxbHakgb9YTZUAkyIQJQG2u9hpUvBixHNvhy39UxNHDy8hP0FOPy+s09sEBdP+2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1630933279972100001 Content-Type: text/plain; charset="utf-8" From: Artem Bityutskiy Add C-state table for the SnowRidge SoC which is found on Intel Jacobsville platforms. The following has been changed. 1. C1E latency changed from 10us to 15us. It was measured using the open source "wult" tool (the "nic" method, 15us is the 99.99th percentile). 2. C1E power break even changed from 20us to 25us, which may result in less C1E residency in some workloads. 3. C6 latency changed from 50us to 130us. Measured the same way as C1E. The C6 C-state is supported only by some SnowRidge revisions, so add a C-st= ate table commentary about this. On SnowRidge, C6 support is enumerated via the usual mechanism: "mwait" lea= f of the "cpuid" instruction. The 'intel_idle' driver does check this leaf, so e= ven though C6 is present in the table, the driver will only use it if the CPU d= oes support it. Signed-off-by: Artem Bityutskiy Signed-off-by: Rafael J. Wysocki [Linux commit: 9cf93f056f783f986c19f40d5304d1bcffa0fc0d] Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -742,6 +742,32 @@ static const struct cpuidle_state dnv_cs {} }; =20 +/* + * Note, depending on HW and FW revision, SnowRidge SoC may or may not sup= port + * C6, and this is indicated in the CPUID mwait leaf. + */ +static const struct cpuidle_state snr_cstates[] =3D { + { + .name =3D "C1", + .flags =3D MWAIT2flg(0x00), + .exit_latency =3D 2, + .target_residency =3D 2, + }, + { + .name =3D "C1E", + .flags =3D MWAIT2flg(0x01), + .exit_latency =3D 15, + .target_residency =3D 25, + }, + { + .name =3D "C6", + .flags =3D MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED, + .exit_latency =3D 130, + .target_residency =3D 500, + }, + {} +}; + static void mwait_idle(void) { unsigned int cpu =3D smp_processor_id(); @@ -954,6 +980,11 @@ static const struct idle_cpu idle_cpu_dn .disable_promotion_to_c1e =3D 1, }; =20 +static const struct idle_cpu idle_cpu_snr =3D { + .state_table =3D snr_cstates, + .disable_promotion_to_c1e =3D true, +}; + #define ICPU(model, cpu) \ { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ALWAYS, &idle_cpu_##cpu} =20 @@ -995,7 +1026,7 @@ static const struct x86_cpu_id intel_idl ICPU(0x5c, bxt), ICPU(0x7a, bxt), ICPU(0x5f, dnv), - ICPU(0x86, dnv), + ICPU(0x86, snr), {} }; =20 From nobody Mon May 6 02:22:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1630933304; cv=pass; d=zohomail.com; s=zohoarc; b=n+wR/FL5C2hd5X1WoOBfmkdUbaXA9mJu5zvAeIpQmIgZ27egH60qp5UArZJpQVzHpr9EHf/ruWgZR+5+EFA1JMAKHAORcHgHHPCyH95fQcXZN3CxJNNtDgG/UJ4ecfxf96pXYxY5JHfRXxfXMl4Zu16/FIvLBJZXupla9xuigqo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630933304; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gXqC7kdE6vgcxzHsZu6LKPSCCwekAZOdkt0dRfJilCw=; b=X9PLdVq3rw8NleB0hIzsKekz2MQ7MFNHyJmJhuozwhkjX3I3Zrr//8zrjJCz+kqXnNrMdQRSVH5DrJIpGVy9vtii/NR28X8aCbiPWijUCrmnOomighwgQ+NyMgzNRMkQhISvYbD8A9DaZ37VvWdza3JpQSMvMNikNWj3W8wnbtI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 163093330456435.216466998262376; Mon, 6 Sep 2021 06:01:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.179831.326239 (Exim 4.92) (envelope-from ) id 1mNEFY-0007F7-Gz; Mon, 06 Sep 2021 13:01:24 +0000 Received: by outflank-mailman (output) from mailman id 179831.326239; Mon, 06 Sep 2021 13:01:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEFY-0007F0-Dv; Mon, 06 Sep 2021 13:01:24 +0000 Received: by outflank-mailman (input) for mailman id 179831; Mon, 06 Sep 2021 13:01:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEFW-00070n-L8 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:01:22 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 85213f56-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 13:01:16 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-4zTxguOhNJyKD5lOYhCkVA-1; Mon, 06 Sep 2021 15:01:14 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:01:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:01:13 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0181.eurprd02.prod.outlook.com (2603:10a6:20b:28e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85213f56-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gXqC7kdE6vgcxzHsZu6LKPSCCwekAZOdkt0dRfJilCw=; b=Ktcpexp4X1FT3W4pAC7pUsPQzrkGO2TVGTntuRgBWNeIFnI16yoYesiVD+RAxa7GN53VrY shfEaP0flxV2POE8B/TgQsqvVC3o0bYlbIzqzKUOYKSUhWrZYuRenu4Jlo5xtrnun3hVLM YQHEn2bR6i4iXVDjQxSoQXxcJfUxda0= X-MC-Unique: 4zTxguOhNJyKD5lOYhCkVA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OQ1hhvpzshOWV7M8HGtnj/xEGUliPqE+LcKtpQ9eTUvHV5LNbZzIAHP7dZsySbv1uMF328nXodfDda0OqBvFrE10edK+XIcNXYzvcsBAlNcPkw7Su5JhKA6/J6CQN8eQdpczJC5t2FWtKD9UM33HkaY8aQQem7Yu2nz9zFE8cbBv9ld+4zndlbw/Ag2SSg8PWixxSYFXpK/FI5VrTLGKGAk7BOqcJt6LP/VRRK5v+qpYC1DjfKf+zc1ZcgiEXmQtG0RMdqmY4BgwEPX59Dsvw+khjgvylPJbVeFZ8E3ETDbblvW8+Xka5Qq3P+9fJmwV21rZ5BI+eNuBNtL2REUeFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gXqC7kdE6vgcxzHsZu6LKPSCCwekAZOdkt0dRfJilCw=; b=Hc02hEB4Ogp1mEAvFDowtjsJA98bTzyr1E/ahMO1JN3d0GewcSEFwl9NeHAvXQboEPS2A6tX1ArvVagrydPWp57slRMa9qYg7NNfCjN7tDCNpSNMRhGZp7F6bCV1sjOvxWUK4CoThYJpFPN7czwXTBZysHYNNweOTmS8vhi40jcmhvDgho9U15zGAR64xcDw9dc74Rhny8deo84Wc+qieTrA+oeHgD29998eZbgVNHth657OcAiC4nt68jvYqupWLZEiqIrF44HDL6EAXxPNU2/oLV6E1iTzvX8FMbvZjRgPs8FnMdUAfuZGf1wFx0+iVHerZMqCSJT5sZl4155ACA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 3/5] x86/mwait-idle: update ICX C6 data From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Mon, 6 Sep 2021 15:01:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0181.eurprd02.prod.outlook.com (2603:10a6:20b:28e::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5dc565c-0990-49af-0609-08d9713667e4 X-MS-TrafficTypeDiagnostic: VI1PR04MB4608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1850; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Foml9KDVDTIII9oDRVhzQetiXWAASLxxWUp+CozyqOhQXp3CKUw21a/FoF0QBZ4cW/7cN94Kk27e2OeYJpxFY4oQpBNIlcxjYBytawQ2gZMGxUOppibIuhwHjCqTkvmTs4oNcd4qbbXh8SS77Fdboek8FoTA+ViiB7zytSRsidBGkf3fbtdQczBWZaf0JN/6WRNfi2t9yaLBGXMiW8vL5WPt7e5wPOfvtTZzBGPirM8JCWvckrShRe77ZsUXFuZfm9aqfU/kmflRTD46YLrBq4PA9a3AoQSZtJ47o9dOAF2NL+IvB8IisdX1vAsAU9axU1QJPFhBVqpECboPf2YiTezuUJWRtO2TcMy30w4HY8FKpkU4lpaODbQVUk0U5Hns72JpUBLQkNUGDq0WmmWTZWX2XnHTxjnd1cdHtccJ43cVIEts3fPkGjl12F5zI34nQHlgwofk7m7npf9GOt1axwEVcvogytnH0Mi2zcYPOaO7scaTk4m4bSg1DgnEaCogPItvXFFLGH79Pt+EffDNV4cbz/ZjZFsDzFZJjPhLREA3MX2Rm7Y3fYzl33b+KVxr0ekZR3XcjMQ0JpQSY8xg6iONG2LihnNiFIObnSM/ICu6XiFu8hYFtp2gvQVu38nmDy4bAtJGqF3dJx2BIPcS2VknG5u9rgCFyy4ke/08Av/69IB52+fggWpNzI6hgYkgcd0kVPykHGaRL99my2w2VwMDEqeHY+VJ/QWH8lV9V5Cb36vvHWAT7eZb87kv4hWN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(366004)(396003)(136003)(39860400002)(66476007)(66946007)(54906003)(478600001)(5660300002)(2616005)(6486002)(16576012)(8936002)(2906002)(31686004)(8676002)(316002)(956004)(4326008)(26005)(6916009)(86362001)(186003)(31696002)(38100700002)(36756003)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjFqVWpTdktXT3hJV1RDVmlvMFgrR1JxNWtNd0c3WExQNHpZUE9VZXhObHNL?= =?utf-8?B?UThQaWxrTEdqTG81MzZrTDRKRzNMSk1zM3FVUHNOOGdIcGlBS1VmM2lNTmEy?= =?utf-8?B?TnNoSjdzbWVhbVhWTEFxNU95L3RDWkNrK2UzQnZjVzN6a0xuQnNtMUhkbTRH?= =?utf-8?B?dW1xUlN6VlRTYzJTVy9KdWhVVkpjY2lBSEQ5cGw4SDJjL3gyNnpMbm5OdHdq?= =?utf-8?B?eGJjTnVNT3RWRDlLNTlpMlFhbSttQ3RvMy9OK1dpOHlaVVUzMHBoL1ZBeUc1?= =?utf-8?B?M0ZMRVhtTEdkQUxmQVA4QTlzNTFJOFJxWFFtYXJad09uT0dubGRLTE5nY1Zk?= =?utf-8?B?TXl0OXhYamE0SkpwQkRzVFJxbVJHZUlXRDNKSk1aZDkyTnhwL1YrMWlFdUxY?= =?utf-8?B?d2pEbUNTRy8vQzQyUTRKOVcxdGR0MVhFNVJTNVlMZFhZRy9RSzJ2YWdGSWVj?= =?utf-8?B?c213VG5ycHhpcU1oSlk5ZzQyT3RRYXFWOC9ZN2Jmd2JUM1M0dkl3R0VRS3o3?= =?utf-8?B?MUxHTFNWbko0bit1NlAxczRHVzhsQW5tTktPdWRBME1pQWFzYXNNSHNwamhJ?= =?utf-8?B?SmROOWJhSDU4S2FFRnMzdktjY01nZDg4bWNNRmo4YVZMQjBUejJhZ1BILzBU?= =?utf-8?B?SWtHT29jU0hKMEQycnFVY1MyTDFqUklURmVrcXlqMnRmMmVIVERVR2tuR0Qx?= =?utf-8?B?TlpGN0l2WHIrS1I4Z0lwM0svMGlHa2FpaXRrUFdPaGExQW5lcW1zZml2aGh0?= =?utf-8?B?eHRJbmFnQ0N3Q3NNdjR3U0U3V2ZmMHdBN1dzSlhqc3hKd0g5a2lBWEpHdElP?= =?utf-8?B?SnVqeHg0R0hlUXNuMjExa1ZZa2I0TWVJVXdWNlNIajcyT2s5WG5PRzdmSUky?= =?utf-8?B?Z0ZNNkduMUZpQ01KY0JLZ1YxaTRGUm9aRXlaRDd5blNiSDBqRms4YVRoeTFU?= =?utf-8?B?aU1RbzFiSlpRM2c2Y3hqQVlvY1N3RE1rOVV2NzZEQkU0THI4WnB4aDVCTitm?= =?utf-8?B?cEJLeVpscGs1VHpKWEpxa2FBVWJxRmo0czllYUFPeEM0QU9iVmJoWVpEQUxr?= =?utf-8?B?UE5rOE1sTmhLTk84eExiZ3J4UDhTTktESkMvalA2cm9oQU16b0dnUjdwUTZn?= =?utf-8?B?a0pZbkJMQUNQWkljcTVRcnlLUHc3Q0UwMklQVlJNWXBkcG5TSkVIOGxFNzlr?= =?utf-8?B?bE05MDVHcmxCYS9kU3NCZm9NSWFtWHRrdnM0TFZ5bVJLaWJqc2NpU0hNN2hM?= =?utf-8?B?aktIWmpXVnFnMGM2SjBiNUJFNHdvNUEreXdHaEZPSFJINzE3L2R6aEhDbU0z?= =?utf-8?B?cGlhWHR5TktBVnRNVi9rUmZ2MlJYYnAzYzQ5VFRCNlM0ZE5xSDd3Q1p3OWlE?= =?utf-8?B?SjZjS1NqM3MvbXcrcytNY2xqaWU5d0tZZlBHUjZuZkZiOXlJVVdjamc1UDhI?= =?utf-8?B?TlJmMXdRU0NFLysvSXFGV1hia0t4TVdvN0Y0SUh4ZGM2aDcyeU9iMitHZ3FC?= =?utf-8?B?MHI0UndwTFRUdW9hbTF3VE5sa0JpRE8xVDVQWXpVZm8xKytibHlTTnQ5akdR?= =?utf-8?B?MnZlS3c2TmplN2dBVDYweVFPcEJ4MzBFbnYyMmIrdmFyWWNqK0pYaG83NUtF?= =?utf-8?B?ZXcrQitOamFBUWJsS05BSFpGQ05jaFVQWjd0QVIyZkIxT1hia084UTBRTXE4?= =?utf-8?B?QnpNNWlWUHZGbGRMYm5TRFNpTnJpVExobFlBYmdXMzFOdzRyOU1VYVhaSjB2?= =?utf-8?Q?Rov4S/z/iy3boIpeBy/AWAYbIFGvkp9GjsKV3rQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5dc565c-0990-49af-0609-08d9713667e4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:01:13.5545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e86jtHR11cuJbPnyo8CNIznS+QrImzwD0T8IPf+jtAG84+eAbtziWKRHjawtb5uL0JY7IywiZSgCX6HHKrIe5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1630933315729100001 Content-Type: text/plain; charset="utf-8" From: Artem Bityutskiy Change IceLake Xeon C6 latency from 128 us to 170 us. The latency was measured with the "wult" tool and corresponds to the 99.99th percentile when measuring with the "nic" method. Note, the 128 us figure correspond to the median latency, but in intel_idle we use the "worst case" latency figure instead. C6 target residency was increased from 384 us to 600 us, which may result in less C6 residency in some workloads. This value was tested and compared to values 384, and 1000. Value 600 is a reasonable tradeoff between power and performance. Signed-off-by: Artem Bityutskiy Acked-by: Zhang Rui Signed-off-by: Rafael J. Wysocki [Linux commit: d484b8bfc6fa71a088e4ac85d9ce11aa0385867e] Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -574,8 +574,8 @@ static const struct cpuidle_state icx_cs { .name =3D "C6-ICX", .flags =3D MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED, - .exit_latency =3D 128, - .target_residency =3D 384, + .exit_latency =3D 170, + .target_residency =3D 600, }, {} }; From nobody Mon May 6 02:22:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1630933337; cv=pass; d=zohomail.com; s=zohoarc; b=C7HNjnoVFtm+ukCtf0lJR0nSjXdt6VGDnW74MGp1xf0uvKUlmBE7ApwhWPUMy7UiQXbLyo5sJH8F73hETbbbSRohwuLehcTuy9UEiVmeHYACXpCxhBuJ3wb49/mxRW1hJy9xUTFNJ1llLewPZU2NVc6X96TiCQhTGUOcIfcVbZ8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630933337; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C0VetijaR8xkFGTQTUwV6cJiozc54HeEusdPV3iHAi8=; b=cliaEiWLdJRdGQoZgUlYWjvc31EyQQEKaWIesAYL+CYyGO8JjEBHXLRxHRpnsgPllHJYMo1xVKTIJfPjd5NRaiCleUv60/L4FrGVp3VjMiRA2P5vvqFDeM8l470DfxrMOkADj2DcXolu7z5lBYif9kAL8ErQ/0k++g3kPKasyto= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1630933337447571.4957621632992; Mon, 6 Sep 2021 06:02:17 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.179837.326250 (Exim 4.92) (envelope-from ) id 1mNEG0-0007pb-Vp; Mon, 06 Sep 2021 13:01:52 +0000 Received: by outflank-mailman (output) from mailman id 179837.326250; Mon, 06 Sep 2021 13:01:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEG0-0007pU-R3; Mon, 06 Sep 2021 13:01:52 +0000 Received: by outflank-mailman (input) for mailman id 179837; Mon, 06 Sep 2021 13:01:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEG0-0007pK-0a for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:01:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 994aa0fa-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 13:01:51 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-20-A-cj4z9TPxa0qOumc9_p6w-1; Mon, 06 Sep 2021 15:01:49 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:01:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:01:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0226.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:01:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 994aa0fa-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C0VetijaR8xkFGTQTUwV6cJiozc54HeEusdPV3iHAi8=; b=UOa/xj8QqxMsM91USdtP/TgHQ3lZcGg68peADaIWNS7N8KIflac2ukZ4SCZwSGbAHJgcsz uZSjEJfZwEg+BlVennC51N3cTkfv43ak/AYdCak5MucW9+8bofx9uCBYnUW5O7a1H0lfmY j//yN4NOCz2bVRDrUV9bzJsgba4a6pA= X-MC-Unique: A-cj4z9TPxa0qOumc9_p6w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KrsUmg3yW6KZu0bukEOz0NRdeY/4rpJse07BhCHEWkbgLQr8Itr1Kj3+cMcdbccwLiD3Cjj/lDmfUGZpw2rEmwtrOV1o0zwwl6y15Ve02ICKH3cU75wHQyKO5h4hB1oxCtfte6QmpVe9bbpA5EVsEpnZWe4laLDAjRzp2S43QHg5VehRI0mE6oglth8FYbgoQmxQtvbLeo8t7LXLg6pDqLFMWzL0osvGNAAWSWO2SSQY6i7C1gF7ECg3ZFk/54orM+/zxFlF3UX74rkUwIcadlJEiizeLTWFEYZlEEPxcMMSiRF8Do0EYoBCuxn2vjj8kX65t8M/svQG7jWCfEgGZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C0VetijaR8xkFGTQTUwV6cJiozc54HeEusdPV3iHAi8=; b=JyFs+DCOG0DB8e3UF2xtNB4E5nlICNQquHcqO9YeI21xgUbJt/Vg2TJZxT7hedCORe0uorQL/si889p/Y8+Pmlq7R9/7KLOX8Q/y65xWuwVzBmgGeNt1MfZcfelqoVOha65tP/pfsSaPxhjDjvguhEbalMD3bBwHQBhIWDIsH6xZemzlKH8BMg6U8En7MQWXMRTi4tD6nY5xXHXFOQRcQ8DAgvqLCUAjSMHn5u8eM1Kj40yB3rRbOjdeOzPj+RrfrMMx+3dTPSHKN89QGMWGZbxRZaWhiMYDhCsTZhZ/DjuGBZdUHL847Ae+HmoJO9xzMcCEPtVSjpGSlZQiHd61vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 4/5] x86/mwait-idle: add Icelake-D support From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Mon, 6 Sep 2021 15:01:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR0P264CA0226.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 877498ab-33e6-4fa5-75b7-08d971367c48 X-MS-TrafficTypeDiagnostic: VI1PR04MB4608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:483; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: txKJ/x3HL6XEsk8VSDAPxfPxRVWf5wotqkw6RHCyU57bMCSD4kCO1DwYDnTOmfMLPxuR/T9ldhGy5bwR8KFQmL15w+2aFnVhdH/PfzBOtse6flTqTTbnkv3trrQ4vmrF4xA/rXpwRRDnYLKCpk9ZbtXtdItZTcwqKs6vEMsLWxE0z0sEdWTStnbe243cFJjFHWY+YmPT2P60mVw6a2Jw9MJZtX9tHOl2neDJ71JulngDDYuDyIHhMvR9rIPk+bvfZH6mOLzl9YxetKjNhPS/tEoyuQcGUthu8KkD0fpFIzbNCdptKyRCsSiPf1uq9UnyBOcVI2wRYDiG0kBrVyEwZ0/QI3zllb3965UANPvZPhGFvKXKWQUJvXcmhs+6XEAmO9neJh6PY6ejTrrDtFjASito7CfCQA0Gut9m9z0gBPHCQtCgOGpaJCgw57WcCOK3Zakrq1v1zAy5mY28+n9Ymj3Oci//GJZ/7qB195xHEfyjoeVrj2cEEBwZFGMFruUwUnIw+JZ7vD/6WJ9aFRjgfdZYfIJJ6bAut+Qh6OysRIAsmbJqKbZgWJAOvs3AYDb7V91PnFCbdbwKEHNs+nXxs320h2xKIp5ddK/6AoSjWg1ynpZzAtHbbtjYgXkardvsqS/YLAEom6AuQp9I6hTsN2hgpteLF8H1r/6zWKOIub7IuoU+qmAypx/cwHe8thwhuTtPK5X3HLmqJi3eAdFmY1IOe93KyoLUPt80W4Vhd/8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(366004)(346002)(376002)(26005)(4326008)(86362001)(186003)(6916009)(316002)(956004)(66556008)(4744005)(38100700002)(31696002)(36756003)(5660300002)(2616005)(66946007)(54906003)(66476007)(478600001)(8676002)(31686004)(6486002)(16576012)(8936002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWF3UkpMK2hyUmV0M1hTUDNNb3l0ZmRkQm83OEh0VmQyVzJ0dFBqT3pFQVcx?= =?utf-8?B?eDdNSVQ1SE8wWEsxUFRJcFBMYkxOQ0ltTUE3SWRML0wvNk1kQ0VLNU5IR29N?= =?utf-8?B?ZUhMWnJISFhQR1BOR3hSL1JZZURsS3JFNWtNRFRQUUhadlQxL3kxSUVyeEUv?= =?utf-8?B?Z1VrMzcvbHI2SzhYUzY1RzdoTVVmTGphaWpZUHVvM3JUeUoyWW5wdFMxcGJl?= =?utf-8?B?VzdtY0twZkFBR0sxSHdSWk9FamJWS0JGelJNcWI4OExtQXA0WTFIZi9zTmxh?= =?utf-8?B?Z0IxUmhxRDEvclRSOHRHa29DaytUTVV0UG5KbzJ5enpXdXJJeDkrUHkzWmlQ?= =?utf-8?B?Ymc5bktNMzhMbnByZEhWZ2VqNmFGTjRwTTVUM2JjRmN4bVk3Mm5oelFqOWwr?= =?utf-8?B?Wm9SN0FJV0JTS1NQVUROTUQvdEtabWJsYlgvNTJuS2Z2RDMxU0lsRXRMQ2dp?= =?utf-8?B?QmhRL0F3bEJ4aWlvZ0NTcGZ2L3AxVWtqWnRaOVdFU0t4KzFPRWpBRkVyRkM3?= =?utf-8?B?NkZudk5vLy8vdS94eXQ2a1UwVFgrME1LSEhKWklGZVA4TWhJQmdLbEwrMmR0?= =?utf-8?B?WXM5WjVuWEFOSXplczQwR3lwTHo3T3hzeU9zNm9BTzZDTXR5MWlkRnBkbVNS?= =?utf-8?B?RSt6elJzS2tGM0dZK0gyM0FsUU5Fb0hZZ0U1bUhHSmJnNEJ1SWdaNW5IRUEz?= =?utf-8?B?WlNPenhMQ1ZhTTNvU2JaaGVIWFJMdWFLRTEvdjFua0ZBaUFaRUtuYmhxeS9a?= =?utf-8?B?dkRQVGhWL0lvbEdNVUpRbXZGQWsrQ2dhdWV4RURFVGJ6WDlHSi9aR1lwODR2?= =?utf-8?B?NWc5dFdQclNNMXJMamwyKzJBTDlmd2l6S09uMXRVWldsVVB4UkMwT04rMlZB?= =?utf-8?B?MXRwOVpMT2YvS0s1Y3VLanVRYTlZZnhrekhMcklKWGUydGFTK2h0eWhNcWd0?= =?utf-8?B?SU8vTW51SS9lTXFPTnREeCszU0pHbmJVZHhhM1hKcXpMWm5yWXpHTDdyMGFW?= =?utf-8?B?MHRFdWtUR09ld0VhR0owandNY0RBK3J1N1N1SEhIVWNyNUYyQmMwRFpSRHI4?= =?utf-8?B?TzJ5MG5hZ0I3SXRid2VjSmswUUlMN1RRbnN5c3RQcnNkT3JFQUJUMkhBbnVL?= =?utf-8?B?c2pDNG45Y05DOWMvelBTRzgreVJMRi82QlRCbVl6ZnBTTW1ycDJYd0JBaGNU?= =?utf-8?B?THdrcVMxV242MEVuTmdwZ3pJNHd1Wms4TFZFMVJ2TjlTM2lIVGZTT0srMEoz?= =?utf-8?B?MUZLV2l3MjhtcWRlazNmOUVpeW1vdWdIQVQxdWIzYTJvcWd0WEx3VVRmNm16?= =?utf-8?B?RG01dVFvTlphdkgxSHFTQ1pCTEtqSUI1a2RUTDBJMko0WEFmSzBxK0pEeUhH?= =?utf-8?B?UytCejZRU3FidSt2K1dMYjdQOHpjN0RtdVVyYksyNkZ3OEdTdmt4RTd4bWdQ?= =?utf-8?B?OU14MWEvTEFWR0xRdStTRER4VUFjTkNSTWZCNS8rUXZzZXc3NWdBaHQrZndP?= =?utf-8?B?cUpJRzJsL0FhMTNMWW0wRXIxR0h5SHFjWUVwd21iYWkzcWlVRXY1NnE0WFR6?= =?utf-8?B?RG9majhKMjZ6YzZ5WHBMZ3hOOGJKaGdNcC9scHltWmxkOVpZcmEvZlNSdE9r?= =?utf-8?B?dnJ4QXVzUVZTak90U1NEWHA3cXl0WDdqZW0zSmVEYXhSTWY2RmxKeWpTQkZK?= =?utf-8?B?dElrZnNyZ2NsSnl4SzQ3c0FkV0g1S2FDZHJzM1laVVdMQ1B3Yms0R2QzdjVi?= =?utf-8?Q?g6SjCp7nkgPZiibm/vS9jUAWACVYG7MG/lQ8/BP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 877498ab-33e6-4fa5-75b7-08d971367c48 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:01:47.7651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LG5szUu94mJS1RPw6ilyEDfhU1Gv6yB8pB8NaGL9KMs+Ovb+MB0KUw/FnSh1/nCSAk5xjlXiv2amEQbsUcTMSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1630933343380100001 Content-Type: text/plain; charset="utf-8" This patch adds Icelake Xeon D support to the intel_idle driver. Since Icelake D and Icelake SP C-state characteristics the same, we use Icelake SP C-states table for Icelake D as well. Signed-off-by: Artem Bityutskiy Acked-by: Chen Yu Signed-off-by: Rafael J. Wysocki [Linux commit: 22141d5f411895bb1b0df2a6b05f702e11e63918] Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -1021,6 +1021,7 @@ static const struct x86_cpu_id intel_idl ICPU(0x9e, skl), ICPU(0x55, skx), ICPU(0x6a, icx), + ICPU(0x6c, icx), ICPU(0x57, knl), ICPU(0x85, knl), ICPU(0x5c, bxt), From nobody Mon May 6 02:22:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1630933362; cv=pass; d=zohomail.com; s=zohoarc; b=aXpeoYxJE7SmErVawvuPMXmOi7mOWOWXJKlXpEUYuzrE7Lswq0zAdVlHB7BJX+yVeU7xE4JdqMbotGoLMXVhVc+YyuV/pNMBXv2Pb/u65EJ3vnmXb2I1no9Ts9h6fZuzXItfRwCvjBg9kAsr2CZY6B6UwMCe32kXObLdW5x4NjU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630933362; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=q25vTfg9n5hflZMUVunRhlsx6PeE8kCcVjZSgImDym4=; b=av1oQ6GeZNCDIYj1O5C6HnOYTykS6OdojB1OIB8mY+peB4SurXztMtqiggAUIb0Nf9hQcFy5eVu0hBQG0WJfccsmJgOmvvW34nS5XaSPFaI7zYAsj4tFTRvtTQdZMzEBQFfNRIbz8XkeP13bLlYrZPcTDigCmvgJF+WTNrApo1s= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 163093336202117.97122632358696; Mon, 6 Sep 2021 06:02:42 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.179844.326261 (Exim 4.92) (envelope-from ) id 1mNEGR-0008V2-7s; Mon, 06 Sep 2021 13:02:19 +0000 Received: by outflank-mailman (output) from mailman id 179844.326261; Mon, 06 Sep 2021 13:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEGR-0008Ut-4V; Mon, 06 Sep 2021 13:02:19 +0000 Received: by outflank-mailman (input) for mailman id 179844; Mon, 06 Sep 2021 13:02:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEGQ-0008Ue-FX for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:02:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a92c2aa0-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 13:02:17 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-13-QMFLyJeKMY-g26Ww_Z7L6g-2; Mon, 06 Sep 2021 15:02:15 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:02:14 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:02:14 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Mon, 6 Sep 2021 13:02:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a92c2aa0-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q25vTfg9n5hflZMUVunRhlsx6PeE8kCcVjZSgImDym4=; b=Hil60oNA16WPL7nAR9GmglMgALqsmElPcmp7kYa1e99cTME/rfDrrxEITbHYqgWF4taPnx COm/MrHVqkV3SqXlYOPPhyQHaF+qouiLrLVht3Z/9Fkh+BBNp9jDtRP4ENGGgnZE486WiB AnMAzkBjxOao7l0ShqA1uwv9cFad578= X-MC-Unique: QMFLyJeKMY-g26Ww_Z7L6g-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wpk2a+RIrLwrozxDrlSrKSr+lrUEz7Qyzi0XBq5rCfDv1GoM4sHuR4rZFTI3lklQ5wW2FPvQLAJc71WboulW5/qvV94Vb61eHbWOkKEP6u4S/y182aEEumftrSyFyIXUVsGrd+Z6eQTV7eMUQA/8kcPdnDo3CVX4HF+EPRqaMpTWef9lYO+KLFlJQeaTWZYxsMsGtfsqbFljLGmhSW/cLG9dmrqWxtIHKtg6ZDKhLQG1YyKUiUxq5jxPdepKaeYlZpQNsUxUireO6QGkmSUky2RN0ZLilno7H7un/V3sqFTWDS2TIpL2qvB4dFR+AiDPTRO2CosbI1TkhBO9rX1X3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=q25vTfg9n5hflZMUVunRhlsx6PeE8kCcVjZSgImDym4=; b=hYJTTisj4WdVmIQ17WL2uPySfg1kK7K6LElXWrUDjAsXNoXYCNlNO7yYjFKgzEwN3FKA3boWAXwq2nJ6cVdwi6PNtjPKKKMThaxVSt0gyB6RgDmGalP1zpzIU14K5FnO3pIhArPr70TaT1NgCslFBXl3tPZtodqO57L2V/lvJgSJ03omu7gvOav990u28gRUN51F2H2qZkkz11SvfcDMj14cV2yRBt7IijKYcuarT2ZilM8eJO4nByXvs0ajsuI4XySd1Kt9DSnWX4DzdobNZaD6+LnB7HlFT8vqEs1/loegrkDjc5eCIj5LswxMes3b/kP6otqvQ3b6cJUMTcyPUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 5/5] x86/mwait-idle: adjust the SKX C6 parameters if PC6 is disabled From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Mon, 6 Sep 2021 15:02:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6c4a2ae-3b3a-4497-6e39-08d971368be8 X-MS-TrafficTypeDiagnostic: VI1PR04MB4608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sOgmmceWZFhjWuATx/r6y2TEs4E0O4koN+SZvZW1sgtpSVSlr+gW88szl4fS/17a6xf2zHUFAoBKtRl6GuIl6qtATTMIYeepIFt+IJy4FqAAplMGMibR/ZRaYSnNtmY0QcVLYrA3udvnmlL4qm3tOqfFhIHmYucLNv278yLxoegEwVwv1N446PKm/JHD8sjtI4E3cd5yKmCZuQU/gvDtk0FwZflk/Q6QTsPjHzxIUNyE6MwnsnDjhfX95Sqq9FQEU/39Uylu74NYVpyp/JXRLv0WOw7yGk7ZsB10fGQmrLg1R9xQcdVe1DzNo7j6XMTNrliiBZwF7m8bfo5bdkyEjlVf689DvmR5aonHh2TfDDg5zE43I05sOY24doNkR5MNkqy6vqYEqtVDNLNxqBFrcvyvuXy8cZaODeli7HZJHK5+9EdrjADOHKfVxpNQLalZ/02XNLlMi7OdSEQd5mCjx7I9x5H1EElUQL33en9XOWa6hrRjo3uw0h56At1BTNHSlAa6csds4KFBT+WqQYESiItiv7TqYK3wphunlJWHJW4ClCzU8tPsl/IhpC166btTw736q6voN+7Xb4x0f2FEkHj1EX8q9EXy66R5e+fyANtw567Xt+H4co4FuNKJkxVh3OCCD9mEKVwsi60riGakBvRuOv/6zuDul08Sl66CUbIkccrvo+t9mHXdr+jJ6uhv8R91JyJBa1PR8C8B2OTMgRYyoYlslVfGNPXhwWEFtOP7U0yBW2gYMHLkhNaO+kU/2REB8YRtvo3pY+8hTLOmc+ehYzPAay3AfBIoM6h/IEVzJ8tuVrGeW1S/hUwxZVuw X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(366004)(346002)(376002)(26005)(4326008)(86362001)(186003)(6916009)(316002)(956004)(66556008)(966005)(38100700002)(31696002)(36756003)(5660300002)(83380400001)(2616005)(66946007)(54906003)(66476007)(478600001)(8676002)(31686004)(6486002)(16576012)(8936002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTdJZ2ttbGdxNXF0WE9QdVNPQU9nVW1CTGxyamkvUlNsdzZTL04reDhrN2tj?= =?utf-8?B?TFRWaFRBeFF1OEQ0bzhXYzk2UG5WZG0vd21aZk1WK0JSbE1MV00vM1hVWHZM?= =?utf-8?B?WU9lMkp1M25yU3pqZ2hHSUkyZzdYQU1rT203b0YvY2dLQnZzdHEzUE93SEdO?= =?utf-8?B?VDdCU2RwYkdQSTFOMm1aazR4OUh2dzZ3M25xckgwS0JGSlFWcnZ1M1RPWXJu?= =?utf-8?B?Uy9pTUhZRGhHUVU1cWNZSDBSVU9lWkplWEplaTJGU3BXbzR1QmhPUTVpVDhW?= =?utf-8?B?NUZ6THgwQStqRUIxcEZhdEFybklZY1JUdGVvTUhLcG4vRm5sb3h0TG5WSlZE?= =?utf-8?B?ejZ1TjJBelZqcWdtdmdXZHNiQXB0RHVGdkM1Y0xsRmh4MzhIazJnazFnYzA4?= =?utf-8?B?cFBBazBSRGN2SnJ3dGVWQ09FL0Z2T1hjNGgwck5NSVVhU3ZNQ2JBcFlSUjFX?= =?utf-8?B?NHJNYzRlekJBemFnM3F6WXB5ejFFZUlSaHhqUkVWaDRObTNaNHd0bEI0TERk?= =?utf-8?B?dVpSTzJHbDlSczJrZ1o0M3BFWnhoM0VKZzRFUEhIQTNqUDR6V0xVUkFDcUlR?= =?utf-8?B?djZpdnpGSGZCVVh0aVJKUmoxR2lMY3FwemRDeEQwcStoMUpiRSt6NkIxZ3po?= =?utf-8?B?WGhrNTZmQTkrdG9KK1ZKbHF0QUZwYzk0eUJZUTRlbnlRekhJRUZQeG1qUGQ5?= =?utf-8?B?WVozQmtKNTRCaU1wQ1pNR2h1dFd5ekE5MVphQVh1cmF1d0EwekRhYTg3L0dr?= =?utf-8?B?a3E4UUVQMUE3MFlmQldOK2d3TTV0WEtxQWE4ZkVyTnpub0F6ZHc3Q1ZNVGwv?= =?utf-8?B?RVFaRVV3d01UZGE5TktlQ3daVkpxYXRzY0NqMGFBcGhHT0piQkJkeHpRY0Nj?= =?utf-8?B?WE9mU2E2YWZrVEhidkJubXJ2TEZPZktyQnAzcnpWWHJYd2VTWXhZVHBwY3lB?= =?utf-8?B?ek5PT2liVlpHL2RzNzNzK2RXNzlvZ0g2TWQzUVFBS2loTE4xUEs4a09kRFQv?= =?utf-8?B?MXZFMzNQcGZudG1oSjNwSWlHQ0VQTnJmcndsUEl4QWJ5aGFGZjBKazVzMUpH?= =?utf-8?B?Y3c5ZlVsRWg5NVp2TS9lSG9CWDF6VFBHQmxIOFJGK2NGb0Q3RFg2eUFWQ3pO?= =?utf-8?B?eFljTzkwSWRuWEZWek5FUTNsZHRpRVQveEtiSmMxSGxqY0N1aTl3dXR2cjdl?= =?utf-8?B?ZnBXd2VSRnZRSE4wYnRoN1pmb0xrSUc5cjRPVjlWYWJLeGJFT21xTzBYdjRr?= =?utf-8?B?SEdMYkM3em0vNGI2b0NRaWZpb1A1bU04aW1iV0tSWUVlVjlVRHBHNk5sdUo5?= =?utf-8?B?Z0hTamJFSUw5cGpXNnFZK0RjVjgvYVgzMzJaNjBWUGI3UGpmUnZHYWgrSnpE?= =?utf-8?B?djFYcGltYmdHeTBGOHkxSTZvb1lYdmhmZjFCYU5ONzRWK21tendXZytLeElG?= =?utf-8?B?SUc1MkhOOVJpRytaMUtMTWQvV2VmS1lGT3p5Y3orVUNJL3lvdldKY0hSN2c2?= =?utf-8?B?VVhoREY1TjFvdFl3anQ2cFRiZWpPaE9WMzlHM20xOFEwZWtMY0V2alFwRFJt?= =?utf-8?B?Z3lKcEJ6dWRaTHI1M2syN1Yrc25uVjBVMGhDVnVJczFKL053ajZ1LzFuR21B?= =?utf-8?B?S0tnaFZPYmVEM09QQzAvY3pHYk1pY3RPYkx5M1QzMjhqRFRiQzltVHM0T1JP?= =?utf-8?B?eGhPZ2E3VGgvMDdsS3cwcStDVnNTSWlUazFXZTdyRjgyQnBpSEY0QW5DdUVo?= =?utf-8?Q?6orz3kj96UWtAkQqJpg0HdyNl9tp7twDD8UoWyt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6c4a2ae-3b3a-4497-6e39-08d971368be8 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:02:13.9873 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qfIPbEufWImrkCsk6wMr8vC8dfpNpdXMi9d95/6Es/JsTHPQD9knzDbeBrYwJWERQZu70yt3oTC6PlFrSeBS8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1630933365362100001 Content-Type: text/plain; charset="utf-8" From: Chen Yu Because cpuidle assumes worst-case C-state parameters, PC6 parameters are used for describing C6, which is worst-case for requesting CC6. When PC6 is enabled, this is appropriate. But if PC6 is disabled in the BIOS, the exit latency and target residency should be adjusted accordingly. Exit latency: Previously the C6 exit latency was measured as the PC6 exit latency. With PC6 disabled, the C6 exit latency should be the one of CC6. Target residency: With PC6 disabled, the idle duration within [CC6, PC6) would make the idle governor choose C1E over C6. This would cause low energy-efficiency. We should lower the bar to request C6 when PC6 is disabled. To fill this gap, check if PC6 is disabled in the BIOS in the MSR_PKG_CST_CONFIG_CONTROL(0xe2) register. If so, use the CC6 exit latency for C6 and set target_residency to 3 times of the new exit latency. [This is consistent with how intel_idle driver uses _CST to calculate the target_residency.] As a result, the OS would be more likely to choose C6 over C1E when PC6 is disabled, which is reasonable, because if C6 is enabled, it implies that the user cares about energy, so choosing C6 more frequently makes sense. The new CC6 exit latency of 92us was measured with wult[1] on SKX via NIC wakeup as the 99.99th percentile. Also CLX and CPX both have the same CPU model number as SkX, but their CC6 exit latencies are similar to the SKX one, 96us and 89us respectively, so reuse the SKX value for them. There is a concern that it might be better to use a more generic approach instead of optimizing every platform. However, if the required code complexity and different PC6 bit interpretation on different platforms are taken into account, tuning the code per platform seems to be an acceptable tradeoff. Link: https://intel.github.io/wult/ # [1] Suggested-by: Len Brown Signed-off-by: Chen Yu Reviewed-by: Artem Bityutskiy [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki [Linux commit: 64233338499126c5c31e07165735ab5441c7e45a] Pull in Linux'es MSR_PKG_CST_CONFIG_CONTROL. Alongside the dropping of "const" from skx_cstates[] add __read_mostly, and extend that to other similar non-const tables. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -484,7 +484,7 @@ static const struct cpuidle_state bdw_cs {} }; =20 -static struct cpuidle_state skl_cstates[] =3D { +static struct cpuidle_state __read_mostly skl_cstates[] =3D { { .name =3D "C1-SKL", .flags =3D MWAIT2flg(0x00), @@ -536,7 +536,7 @@ static struct cpuidle_state skl_cstates[ {} }; =20 -static const struct cpuidle_state skx_cstates[] =3D { +static struct cpuidle_state __read_mostly skx_cstates[] =3D { { .name =3D "C1-SKX", .flags =3D MWAIT2flg(0x00), @@ -674,7 +674,7 @@ static const struct cpuidle_state knl_cs {} }; =20 -static struct cpuidle_state bxt_cstates[] =3D { +static struct cpuidle_state __read_mostly bxt_cstates[] =3D { { .name =3D "C1-BXT", .flags =3D MWAIT2flg(0x00), @@ -870,9 +870,9 @@ static void auto_demotion_disable(void * { u64 msr_bits; =20 - rdmsrl(MSR_NHM_SNB_PKG_CST_CFG_CTL, msr_bits); + rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_bits); msr_bits &=3D ~(icpu->auto_demotion_disable_flags); - wrmsrl(MSR_NHM_SNB_PKG_CST_CFG_CTL, msr_bits); + wrmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_bits); } =20 static void byt_auto_demotion_disable(void *dummy) @@ -1141,7 +1141,7 @@ static void __init sklh_idle_state_table if ((mwait_substates & (MWAIT_CSTATE_MASK << 28)) =3D=3D 0) return; =20 - rdmsrl(MSR_NHM_SNB_PKG_CST_CFG_CTL, msr); + rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr); =20 /* PC10 is not enabled in PKG C-state limit */ if ((msr & 0xF) !=3D 8) @@ -1161,6 +1161,36 @@ static void __init sklh_idle_state_table } =20 /* + * skx_idle_state_table_update - Adjust the Sky Lake/Cascade Lake + * idle states table. + */ +static void __init skx_idle_state_table_update(void) +{ + unsigned long long msr; + + rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr); + + /* + * 000b: C0/C1 (no package C-state support) + * 001b: C2 + * 010b: C6 (non-retention) + * 011b: C6 (retention) + * 111b: No Package C state limits. + */ + if ((msr & 0x7) < 2) { + /* + * Uses the CC6 + PC0 latency and 3 times of + * latency for target_residency if the PC6 + * is disabled in BIOS. This is consistent + * with how intel_idle driver uses _CST + * to set the target_residency. + */ + skx_cstates[2].exit_latency =3D 92; + skx_cstates[2].target_residency =3D 276; + } +} + +/* * mwait_idle_state_table_update() * * Update the default state_table for this CPU-id @@ -1178,6 +1208,9 @@ static void __init mwait_idle_state_tabl case 0x5e: /* SKL-H */ sklh_idle_state_table_update(); break; + case 0x55: /* SKL-X */ + skx_idle_state_table_update(); + break; } } =20 --- a/xen/include/asm-x86/msr-index.h +++ b/xen/include/asm-x86/msr-index.h @@ -45,6 +45,13 @@ #define MSR_CORE_CAPABILITIES 0x000000cf #define CORE_CAPS_SPLITLOCK_DETECT (_AC(1, ULL) << 5) =20 +#define MSR_PKG_CST_CONFIG_CONTROL 0x000000e2 +#define NHM_C3_AUTO_DEMOTE (_AC(1, ULL) << 25) +#define NHM_C1_AUTO_DEMOTE (_AC(1, ULL) << 26) +#define ATM_LNC_C6_AUTO_DEMOTE (_AC(1, ULL) << 25) +#define SNB_C3_AUTO_UNDEMOTE (_AC(1, ULL) << 27) +#define SNB_C1_AUTO_UNDEMOTE (_AC(1, ULL) << 28) + #define MSR_ARCH_CAPABILITIES 0x0000010a #define ARCH_CAPS_RDCL_NO (_AC(1, ULL) << 0) #define ARCH_CAPS_IBRS_ALL (_AC(1, ULL) << 1) @@ -175,11 +182,6 @@ #define MSR_IA32_A_PERFCTR0 0x000004c1 #define MSR_FSB_FREQ 0x000000cd =20 -#define MSR_NHM_SNB_PKG_CST_CFG_CTL 0x000000e2 -#define NHM_C3_AUTO_DEMOTE (1UL << 25) -#define NHM_C1_AUTO_DEMOTE (1UL << 26) -#define ATM_LNC_C6_AUTO_DEMOTE (1UL << 25) - #define MSR_MTRRcap 0x000000fe #define MTRRcap_VCNT 0x000000ff =20