From nobody Sun Apr 28 13:25:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1614961756; cv=none; d=zohomail.com; s=zohoarc; b=fevUnAwqKo9jHNzhGmSAmltbNWbE46kgVaZYed6P1lKu9IVi5tq4LfkuPee5d8TtTWot9DLFQf/1QdjeUDBd7q8gYC1Ujlx9GFpNF+vMBmUZunaef27yM1YjEz8YhG9J5fxwPzRo7OqnbqIRFFQdmN+5LuDwppe2H66SscbtmTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614961756; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/dFvgRp6OwKzIedO5BBFy/xt22+KtFLnejFnN6oawMY=; b=d+faMODLMfHdFvE/xmlrtaqEskYZD27R80MbJrmNR7Ib+bH0k2eAj26GEYs/FEu/l7pr0yugBmBnihv86OAnIoH3eh5lUmbwWYSx67Ca4vZ9+FNkXavK31dDIca069f7p8EMfsovGOd973gQqCbFE+uZ3lsT56sejNpBTBIRiF8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1614961756959892.9012304583003; Fri, 5 Mar 2021 08:29:16 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.93885.177336 (Exim 4.92) (envelope-from ) id 1lIDK1-0003WL-UA; Fri, 05 Mar 2021 16:29:01 +0000 Received: by outflank-mailman (output) from mailman id 93885.177336; Fri, 05 Mar 2021 16:29:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDK1-0003WE-R4; Fri, 05 Mar 2021 16:29:01 +0000 Received: by outflank-mailman (input) for mailman id 93885; Fri, 05 Mar 2021 16:28:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDJz-0003W9-SY for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:28:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fdba039f-2591-41cb-b087-f5625414504c; Fri, 05 Mar 2021 16:28:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 43FDAACBF; Fri, 5 Mar 2021 16:28:58 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdba039f-2591-41cb-b087-f5625414504c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614961738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/dFvgRp6OwKzIedO5BBFy/xt22+KtFLnejFnN6oawMY=; b=rokApWnhAxI+Pvw36mHyKEuyFmJDq2kA9/J7CFbNQyDEIyB4ivPLQ2dGVpC0h58sqkW4oz L1LhxxiHXKBnn8rJyzIDvQuKQVpcfbU8qwPtF4cA5U+2+T7uZyaFs/xhY/Vx5GHP2sQrGI TylL4WLRu1gUGrVtw+VbI4HKOkAmqaE= To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Wei Liu , Anthony Perard From: Jan Beulich Subject: [PATCH][4.15?] libxl/ACPI: add missing build dependency Message-ID: Date: Fri, 5 Mar 2021 17:28:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Just like all other object files - wherever *.o is mentioned, *.opic also needs mentioning to yield consistent behavior. Otherwise make may decide to (re)build the object before recursion into $(ACPI_PATH)/ (to update $(DSDT_FILES-y) and ssdt_*.h) was actually finished. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- A related but separate issue is that build.o* get rebuilt even if none of their file dependencies changed, merely - aiui - because of their dependency on the phony "acpi" target. It may be possible to limit this rebuilding by making both depend on $(DSDT_FILES-y) instead, but then they would still get rebuilt for no reason when that file (if any) changed (but ssdt_*.h didn't). --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -32,7 +32,7 @@ ACPI_PATH =3D $(XEN_ROOT)/tools/libacpi DSDT_FILES-$(CONFIG_X86) =3D dsdt_pvh.c ACPI_OBJS =3D $(patsubst %.c,%.o,$(DSDT_FILES-y)) build.o static_tables.o ACPI_PIC_OBJS =3D $(patsubst %.o,%.opic,$(ACPI_OBJS)) -$(DSDT_FILES-y) build.o: acpi +$(DSDT_FILES-y) build.o build.opic: acpi vpath build.c $(ACPI_PATH)/ vpath static_tables.c $(ACPI_PATH)/ =20