From nobody Thu Sep 24 20:23:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788436304; cv=none; d=zohomail.com; s=zohoarc; b=JOTF5iwGAjtdaxVxxrq36uRE5WViGNyaKyvLIy+leMr/hp9LQsKJ5rfDidlNjRxzsaFU0OgrHcXWwIQ7GItLYDhRooIXdaO4J6J+ouDsX9SeCWzi8patoYen175uNHsdUr7tHo3FOU16XeRoOPwpGk8daNzZcBRBns3zpwyQCdM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788436304; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zhIYR/oqHKXSjiZI2vs1xRVSb8E3/e1gFl+5UoCDK/g=; b=UTvHOqPBUDMFDxU5RyYXB75LUauOYVCZCQ+uhbEMY+/DvyGfs5JWJ2V4BHlii2G1KUu7kkrSMdVnTTkWiHhTBc5j7diGd7WVf8Hk6YrTo2KvE+uuTPhlJF4/zbGCrnC6MhOdGdkddww+B5jwAO0oNJ1a5L9Kt7e0sDj1CsBsLQw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788436304636612.7231089502129; Thu, 3 Sep 2026 04:51:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1406980.1640146 (Exim 4.92) (envelope-from ) id 1x25ye-00074H-SA; Thu, 03 Sep 2026 11:51:32 +0000 Received: by outflank-mailman (output) from mailman id 1406980.1640146; Thu, 03 Sep 2026 11:51:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x25ye-00074A-PA; Thu, 03 Sep 2026 11:51:32 +0000 Received: by outflank-mailman (input) for mailman id 1406980; Thu, 03 Sep 2026 11:51:32 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x25ye-00073w-2r for xen-devel@lists.xenproject.org; Thu, 03 Sep 2026 11:51:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x25yd-00AJ5A-Ec for xen-devel@lists.xenproject.org; Thu, 03 Sep 2026 13:51:31 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a995f3f-2eae-0a2a0a5409dd-0a2a4502a6a6-14 for ; Thu, 03 Sep 2026 13:51:31 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a995f42-6ca4-0a2a45020019-d1558029c1f6-3 for ; Thu, 03 Sep 2026 13:51:31 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49b8687630fso19214885e9.3 for ; Thu, 03 Sep 2026 04:51:30 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee60d9c6sm67076335e9.11.2026.09.03.04.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 04:51:29 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788436290; x=1789041090; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=zhIYR/oqHKXSjiZI2vs1xRVSb8E3/e1gFl+5UoCDK/g=; b=gZQ0InSQIIgnf/QN+fnhYNxM7L1ncmzMWz7WeaAIKm5wQa4UyMPQihbwStcWPqBOcN Ho5LefdzW923u1fKOiM3Xtutn71w8qP+NVV/16nQ/awD4MTLUga6FSLz/H4j50te8yDy aYOafifyTu509z8qUWDnztoFVy9D9Fm5iTCATN1JE4EOP7rSoxrJJIqI6fV1JmaRRtcq IWONGmWU6gFF1knuYo8WSWbxrzvNUreIQ77JA0kjtuvtkcjq7pakmOt1avOYX52djPYQ QdBWZwRJqUB5dU9/zNitJTkkmJW0SlzQoyghZjJz9+LabbRzLrOzxpwkY6L/JrktBAQ5 NCWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788436290; x=1789041090; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=zhIYR/oqHKXSjiZI2vs1xRVSb8E3/e1gFl+5UoCDK/g=; b=IrvnAUgSG/ZqoprsAFyrWXvtsFgpbXG5GCUt6vxTPYE/5/y1yfSGYCbO4JNCV8cTq/ Tf/RBHXj2JWIx18va3ilsnUn4JT9nb6ZY7vausKcMtz5m7DLOsmFjVCZS+8wojoxChZR vMMKCtsiGOqBJODrvUDQDtoC4tFTK41q7FI1J1b8srj6/WwENypuDQUV2Zs/AS0423Zk HKuGqMcQtWa8gzSgfAS7YWVENTVsec3LN4PO0RlnK4PFCmbOPV3jih6j8SNgybMRclu6 CG3OjOwlrEsYpEsPjQJgjWvY1V6LyNxSB2HiXV7h3tzD3acCclJNDJN0PBgUyelIPFgb NZlA== X-Gm-Message-State: AFuF++nmnDAvbYU60ig1ngTIS7SJeBuQKvgqgpRQ75funH/QbFwKP2iB EgBF1dj6bW3RtJQ511DUcABpwJX/AqjJEOljubCr8YY/4VVkSByG9ewZYhN+g7fRQBgSmBiQPDk +5fE2EA== X-Gm-Gg: AYBFou2lCXX6Y+MdwceoAga1hA2MM8oT4e0Q4/3tu5JD9Vhzf0RoHnJnIkQ957j+8qI LjotFu6dBwz7c2z0DbtuvhKo+zPJN5nTdYtX25NqVNS0m/P44MePdeQBhNUi3vqp6g+39z4SkzZ L0PCGn/2u5LdqBUN+prjqvfwktsYyvYpGy0KJWBpnhNjmhrGsD0Xvuh1tbKuG8Am46RmQxHjJIS kZ1AAvq6rpS2qw38AZ1qybc82o5EgbsLIMMK5zs3r1WFftYwKRtLe6Ok/v4Qi6DeG98ZiuWRxWL R5OIw1+SUQRAAlzs18r6j3m/J+w7giUWnKKMrFlFgYnHuBpsFn8EjjQf8Rj8tbZXAs1O2e3ACUT Vl1gKv5YlOVlBcyA+GtpZ0mEVowC8uHu7u6P87oZvVnYGTvU9T5o6zaXr6Plzm48rPn4BEL7+ZO 08lFCh5LAZtOS+vbjrQFII4tHKDpyuHVpLdnpjxraN0QSn4fii6yvVIy00V4GwOzxqx2jisV2VP Ba+GVBSdKoxlnj2o6FeUOqCeXIK7WhmOnVPq121ff2g53KLwXkG X-Received: by 2002:a05:600c:470d:b0:499:9240:9a1c with SMTP id 5b1f17b1804b1-49ce58363f8mr171708855e9.15.1788436289991; Thu, 03 Sep 2026 04:51:29 -0700 (PDT) Message-ID: Date: Thu, 3 Sep 2026 13:51:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/4] x86/pagewalk: avoid ACCESS_ONCE() in compound literals From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-720697/1788436291-F20A82AC-376B41CF/0/0 X-purgate-type: clean X-purgate-size: 2636 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788436306899158500 Content-Type: text/plain; charset="utf-8" Compound literals are also covered by Misra C:2012 rule 13.1 ("Initializer lists shall not contain persistent side effects"), and (sadly?) that rule also applies to lists with just a single element, or more generally with just a single side effect. Use intermediate variables to overcome this as well as ACCESS_ONCE()'s restriction to be usable on scalar types only. No functional change intended. Fixes: 0345b835dc97 ("x86/pagewalk: Read guest PTEs with ACCESS_ONCE()") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/guest_walk.c @@ -129,7 +129,9 @@ guest_walk_tables(const struct vcpu *v, guest_l4_table_offset(va) * sizeof(gw->l4e); if ( !hvmemul_read_cache(v, l4gpa, &gw->l4e, sizeof(gw->l4e)) ) { - gw->l4e =3D (guest_l4e_t){ ACCESS_ONCE(l4p[guest_l4_table_offset(v= a)].l4) }; + guest_intpte_t l4e =3D ACCESS_ONCE(l4p[guest_l4_table_offset(va)].= l4); + + gw->l4e =3D (guest_l4e_t){ l4e }; hvmemul_write_cache(v, l4gpa, &gw->l4e, sizeof(gw->l4e)); } gflags =3D guest_l4e_get_flags(gw->l4e); @@ -164,7 +166,9 @@ guest_walk_tables(const struct vcpu *v, guest_l3_table_offset(va) * sizeof(gw->l3e); if ( !hvmemul_read_cache(v, l3gpa, &gw->l3e, sizeof(gw->l3e)) ) { - gw->l3e =3D (guest_l3e_t){ ACCESS_ONCE(l3p[guest_l3_table_offset(v= a)].l3) }; + guest_intpte_t l3e =3D ACCESS_ONCE(l3p[guest_l3_table_offset(va)].= l3); + + gw->l3e =3D (guest_l3e_t){ l3e }; hvmemul_write_cache(v, l3gpa, &gw->l3e, sizeof(gw->l3e)); } gflags =3D guest_l3e_get_flags(gw->l3e); @@ -264,7 +268,9 @@ guest_walk_tables(const struct vcpu *v, l2gpa +=3D guest_l2_table_offset(va) * sizeof(gw->l2e); if ( !hvmemul_read_cache(v, l2gpa, &gw->l2e, sizeof(gw->l2e)) ) { - gw->l2e =3D (guest_l2e_t){ ACCESS_ONCE(l2p[guest_l2_table_offset(v= a)].l2) }; + guest_intpte_t l2e =3D ACCESS_ONCE(l2p[guest_l2_table_offset(va)].= l2); + + gw->l2e =3D (guest_l2e_t){ l2e }; hvmemul_write_cache(v, l2gpa, &gw->l2e, sizeof(gw->l2e)); } =20 @@ -353,7 +359,9 @@ guest_walk_tables(const struct vcpu *v, guest_l1_table_offset(va) * sizeof(gw->l1e); if ( !hvmemul_read_cache(v, l1gpa, &gw->l1e, sizeof(gw->l1e)) ) { - gw->l1e =3D (guest_l1e_t){ ACCESS_ONCE(l1p[guest_l1_table_offset(v= a)].l1) }; + guest_intpte_t l1e =3D ACCESS_ONCE(l1p[guest_l1_table_offset(va)].= l1); + + gw->l1e =3D (guest_l1e_t){ l1e }; hvmemul_write_cache(v, l1gpa, &gw->l1e, sizeof(gw->l1e)); } From nobody Thu Sep 24 20:23:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788436342; cv=none; d=zohomail.com; s=zohoarc; b=i4GCrNGcf+z67OpXMxO2ryBKSnB9JqiCv1BmozL1H2lxE2N6U9an8fdSlAIc03bSKGXICzmQkr6oJ3F1PUdiM92HqJJ+MG3KGlnslFIrlgYq0Xx8BrdzvcM3jo8EmdWGP7nyYsoM6GX4bVXiSXDd5x3AS/g/5bv3AVlCwrcwFpk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788436342; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Tdr/Gmp1cERSIVeOl3/iaDcbwecc4l4TxDPSodIgybQ=; b=SZopM1I0ijkbcaYuMV4hYfuLL8QSLEoGhBUfE4oACWvxB56PxwXKSCtzM1NHcLE5Sl9eazZrNDEopmaFU2DAl4WoKUiqn3iaCmdpmdtfgmr4GitNUjJsWTKSb30LKRiLFYWupBPMLklIEOSpaoIfi0OD/2NqNgjl07ZOeXc1O3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788436342462577.3307340727456; Thu, 3 Sep 2026 04:52:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1406986.1640155 (Exim 4.92) (envelope-from ) id 1x25zC-0007X4-2y; Thu, 03 Sep 2026 11:52:06 +0000 Received: by outflank-mailman (output) from mailman id 1406986.1640155; Thu, 03 Sep 2026 11:52:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x25zC-0007Wx-0G; Thu, 03 Sep 2026 11:52:06 +0000 Received: by outflank-mailman (input) for mailman id 1406986; Thu, 03 Sep 2026 11:52:04 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x25zA-0007Wc-QL for xen-devel@lists.xenproject.org; Thu, 03 Sep 2026 11:52:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x25zA-007Gry-6v for xen-devel@lists.xenproject.org; Thu, 03 Sep 2026 13:52:04 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a995f5f-8faa-0a2a0a5109dd-0a2a450bcbca-10 for ; Thu, 03 Sep 2026 13:52:04 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a995f63-b7e8-0a2a450b0019-d155802ac04d-3 for ; Thu, 03 Sep 2026 13:52:04 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49b8eeb3ff2so20476955e9.2 for ; Thu, 03 Sep 2026 04:52:04 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee5d1fa6sm71126955e9.1.2026.09.03.04.52.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 04:52:03 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788436323; x=1789041123; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Tdr/Gmp1cERSIVeOl3/iaDcbwecc4l4TxDPSodIgybQ=; b=DXY8sqcxV/GDAJDDH0Es6YoZcCm72JwauTXxi1LWLeRwinS6Dc5f/KFTLXoP/+EQR9 4ArwFXAQeDnwGjMkl6S01VoahY0FwvZjjF5u99ekvMqAXoXZvHGS3TD7cvDRCqo2+3Oe E5CSq5eI2CsJ6TX4gBIboq+VdTWaWxXXj9mLJ1zp98LORqeA2cZKif23qk4FHH+yNYg8 txLri98ac85ncuhMi/y9ueHazHwd+8+xy8ev0qAe3inRUQtVifC3cx5f7TVCNqGBzXnP LYPpCOTsLt1FKtQuh6zJ5rK7pLihj3iwl03owVKuHRW3dhO7tmWdXKAaT/slEjFloQxi QK8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788436323; x=1789041123; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Tdr/Gmp1cERSIVeOl3/iaDcbwecc4l4TxDPSodIgybQ=; b=lJxhHr8Y74bxKJoeZTXyd5+n5lVUJX1TTLGXn9VRXqd3KzqpqsxLZZd2HEXmn1ZSZS sIDCqVdmKwuUT+NddaEG8E2YG+NxuYTMdfqH+U0IOJFsFKe/ClRPCCtmkFVNcltaSK53 D3TlPiZfGidvDVnsX9BltWIR87jclDi/CHyKSEXj7cdfpwvQNbORoT4jMgSxGkRksy0C uyw0e09eICqGXRevq1ePblhotBzSoenvJk/phBA3aYEcthlmppEHXf+bP/WLbfuWOUjL aRWHnJeGjFMmiFkgMwfMIn4CzWD59+MvwzbMdrsKTG9XEs7zUC1l5NmGwFZAZsgbx6JP mawA== X-Gm-Message-State: AFuF++n0SgfaUP+rhKL1a91Xyp8Q4UpmzapWQjLNgPtGLvNs3TA7KP6V zEnjuD3rdc9+3ZmouHFIWB1N3sk07bhlg+rAAJolYH3kFSj1DKglsGiFExqZrafOpaDWt/DhHLo 6ruMJ7g== X-Gm-Gg: AYBFou0GtnubWLulT4Cf0zbCO7qo2bYwqkgyIhUjobJjjfBu3JoBrp0ITsw4GbdmXKt N+11+bROjIdNFgiSZ3Sn1oPBK22OpnHNnX9LRU8fwlOazpthFkrWq+u4mNBxTbtvKiNNVINRwBT QLfVfM92gNPRYyhOdw+Y/jHw+SPh639X0IZ2n+52dfzkNPrbJ+xbA7v5AlGPIpVdcRUq4o54qeQ s+dll2oHxZB3GCdveidxlklWjI6YvVJxhJefVkNilaXPVx03OU6ztZX24+8OlNfsE1GLWyTz/1Q l5VFmq5mEZ7k+hkaidykRBXvtN7BqHyfuGosW3nG+HTqJYa4RRNFYRGE7l6PCLJhwRM3/+/bLS+ dU+MTp9bgbQhHuPz77HgtqWcKryCmwiBujCPVUQ0xPxV9pUPBmj8bbfOywWXlGaOfLf1tTOzy5/ 7fNgflCWlhW/ZUi/HuIXbh8iRvRdUtiLJNOEZX7wicVxj4Ni20S6IRwcuKBYXAv6Ou9j6E/AKrH SFVn9vnGChtdXJXYOq9cLbxs/X3+eD7OXV8jwcDGzkXUC+gJ1j6 X-Received: by 2002:a05:600c:4e16:b0:49c:ee06:9c58 with SMTP id 5b1f17b1804b1-49cee069c79mr130970735e9.4.1788436323591; Thu, 03 Sep 2026 04:52:03 -0700 (PDT) Message-ID: <7424be87-9a97-4b83-b920-a8ccf4c1a889@suse.com> Date: Thu, 3 Sep 2026 13:52:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/4] Arm/guestcopy: avoid use of "current" in compound literals From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-42698a/1788436324-A9EC69EA-E371F59A/0/0 X-purgate-type: clean X-purgate-size: 2167 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788436343020158500 Content-Type: text/plain; charset="utf-8" Compound literals are also covered by Misra C:2012 rule 13.1 ("Initializer lists shall not contain persistent side effects"), and (sadly?) that rule also applies to lists with just a single element, or more generally with just a single side effect. Use intermediate variables to overcome this. No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Michal Orzel --- This is assumed to go on top of "Arm/guestcopy: deviate copy_guest() uses just like their x86 counterparts", conflicting contextually but not functionally. --- a/xen/arch/arm/guestcopy.c +++ b/xen/arch/arm/guestcopy.c @@ -109,29 +109,37 @@ static unsigned long copy_guest(void *bu =20 unsigned long raw_copy_to_guest(void *to, const void *from, unsigned int l= en) { + struct vcpu *curr =3D current; + return copy_guest((void *)from, /* COPY_to_guest doesn't modify */ - (vaddr_t)to, len, GVA_INFO(current), + (vaddr_t)to, len, GVA_INFO(curr), COPY_to_guest | COPY_linear); } =20 unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from, unsigned int len) { + struct vcpu *curr =3D current; + return copy_guest((void *)from, /* COPY_to_guest doesn't modify */ - (vaddr_t)to, len, GVA_INFO(current), + (vaddr_t)to, len, GVA_INFO(curr), COPY_to_guest | COPY_flush_dcache | COPY_linear); } =20 unsigned long raw_clear_guest(void *to, unsigned int len) { - return copy_guest(NULL, (vaddr_t)to, len, GVA_INFO(current), + struct vcpu *curr =3D current; + + return copy_guest(NULL, (vaddr_t)to, len, GVA_INFO(curr), COPY_to_guest | COPY_linear); } =20 unsigned long raw_copy_from_guest(void *to, const void __user *from, unsigned int len) { - return copy_guest(to, (vaddr_t)from, len, GVA_INFO(current), + struct vcpu *curr =3D current; + + return copy_guest(to, (vaddr_t)from, len, GVA_INFO(curr), COPY_from_guest | COPY_linear); } From nobody Thu Sep 24 20:23:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788870089; cv=none; d=zohomail.com; s=zohoarc; b=YgWyuHL/Pzvak+h+ApRvDgQzed/EM+BD0+Sv2NVut2UjOO3IQayvsU0/y5uSYtctSCC8sgT7L6Kd4rIv4R+e33S3Q0xCb/nT+vavvqt6pZKauyDdCtmLs/XQ1BKdWK9enqndfASY6+d4zBT8bT40cezV1X0Sjj7j7A6xhA4qbao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788870089; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y400oWD1wHNJh0ADtJXm8+RnBJvVktOI+IIWHcewNYQ=; b=XUEsVy+VO9+Gj0d7WdusoXS9+KnJBU42cAPXNNJLJN9fC3BOnyMqDC7P8C3oHe5u3FsG1GwnL/KL1WBVTEV2uD69omAa+KbtNRzWUf+wA69951aBA1O/nuPjzwkFtBso2d4O18HFBvos2WVn3y/d+Wd5ix1CNCK2QQs/seypRTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788870089119474.11746604587904; Tue, 8 Sep 2026 05:21:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1411877.1642344 (Exim 4.92) (envelope-from ) id 1x3up1-0003bg-Ca; Tue, 08 Sep 2026 12:21:07 +0000 Received: by outflank-mailman (output) from mailman id 1411877.1642344; Tue, 08 Sep 2026 12:21:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x3up1-0003bZ-9i; Tue, 08 Sep 2026 12:21:07 +0000 Received: by outflank-mailman (input) for mailman id 1411877; Tue, 08 Sep 2026 12:21:06 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x3up0-0003bR-6L for xen-devel@lists.xenproject.org; Tue, 08 Sep 2026 12:21:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x3uoz-00H5I8-FB for xen-devel@lists.xenproject.org; Tue, 08 Sep 2026 14:21:05 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a9ffda5-8faa-0a2a0a5109dd-0a2a45048360-46 for ; Tue, 08 Sep 2026 14:21:05 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a9ffdb1-b57f-0a2a45040019-d155802ee806-3 for ; Tue, 08 Sep 2026 14:21:05 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49d05d51553so24245895e9.2 for ; Tue, 08 Sep 2026 05:21:05 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce554d52esm333316485e9.3.2026.09.08.05.21.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2026 05:21:04 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788870065; x=1789474865; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:subject:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Y400oWD1wHNJh0ADtJXm8+RnBJvVktOI+IIWHcewNYQ=; b=R4atMQZMSmO7g+jWt/12Hcd3G9ax89Xi2wTBQYWr4PRfIcMH0JJ/GqYsfFGG4hY/qQ RLpV7RPoTiYXIuihpkfA8SBHtG3TI2lRmCm1Y7eAD3k+wVJqINswTRGdy8ckaHsXagIm 7mvHWkiZE8KaJtmjC1+Hh9NjxxKZKhWeSuOq+iGttqo+B4nzYV0/U7s3Maszzc/7P3R3 OHubq8Bb8XL4z2CdTi8Jmc8qpUs8SMT8wkvLvFVYv4y7TGxWQIGO/mvdo2t9L3wVJiBs IH1wQmmlHNBtTUXBxC8no409xCCL6pALmis70r3VoJPjkiDSiAt1s1Rus1tIuG07XiQE dqog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788870065; x=1789474865; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:subject:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Y400oWD1wHNJh0ADtJXm8+RnBJvVktOI+IIWHcewNYQ=; b=G4xRgMlCQeZOMqi1N6m9Hmo4TjA462J9Ul9SEsGtAXWD2CYeXRo4MrwhUkvI6mnVpB rWj3n0smQmG1mXvw9+P5qfUYp+BPV7/UGqQfcwIXrcQlvQCHykt/i5Wzby5muwNrC31K wQLCVy+b2NVLdDDjPvJWWjGKbuKiDtaWb8lK/LKDdgO2TjlrgA5hZkdUznvPkuEcgrIB 7B6OxrhLBXeNXPb+9jXM55+/XLlwHdAcpkybvvb1Rtg8Xe6hDpuzcAN8ekQRbeOVfJVq lTuFsDOvJGaD0uiX+DXgJA3ljH+zjmlboBW5sdHnVIEgzoPFuqpwgRytEEKipEzSdjZ1 66eg== X-Gm-Message-State: AFuF++mDgrcoadc4bdQcIO+pXS1T4FtrGf5YSJMliOuTFX23T8XdbiGu vvsbsTM/25eB3+1KpaMNcMoyOENG6eGFXwP4wq7hF/Y7NW3+U5VfKvSBXl/qPi+VMg9FfiFgBf2 XjZFTpw== X-Gm-Gg: AYBFou3Z84Qw1lFYz+32AiqzC7ga8kJquAXdg8Fj52GmOVsIfjCV1B/T3isbCBpwLLo vpgOTYJvafR6ytMbupJ27x1cgMt4G+RmKpPxngXQyHq2MGGsKf7ZduHCEuKz3/8JRw2qfcGiM+X B9b/tADMG+pobyXsPF5he6njoyHWS9fbTHGf1XmzvSEBJMsJFuhY5iuDKolh/W8GCvmj2LpAfGX PKIN/lv3T5DpIME+C7JDOL6Rbi6j3uTx/Aofm/p9rgh2TLwwcie8zzZ3q64F+tYxeq0OrGbZsQN /4I4WntUVLSKn2oKQma+btcrXEL7ICTerDfl5ilbSy0mFwcesQTu1b0Y51ZJRS/oYSmQkRNCYRG xAWYEoeFUZSSb95v1BCwsg3oQpctNi2TEbM41VaTJD62S+TvPimnFtoytizT3cmudi3oO5crt/v SN7zWj1G4tEYMVGwrUHl2bcVUtNoXH0qDBp79BeRBu71WjjiQoeZOJMFiaWnRdktmBAk/bKQ1Yf KbIx+CL24DzwIOrb6ouw+RfhXLighYuug3lrHuRGMj0qy6d6xtk X-Received: by 2002:a05:600c:8b88:b0:49c:fc6e:a3d8 with SMTP id 5b1f17b1804b1-49cffde8d95mr239986635e9.23.1788870064722; Tue, 08 Sep 2026 05:21:04 -0700 (PDT) Message-ID: <1ba6f97e-4745-4b12-bc80-dffebcadf576@suse.com> Date: Tue, 8 Sep 2026 14:21:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v1.1 3/4] sched/core: avoid use of "current" in initializer lists To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Juergen Gross , Dario Faggioli , George Dunlap References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ebf023/1788870065-C34C3B50-2175747A/0/0 X-purgate-type: clean X-purgate-size: 4943 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788870092189158500 Content-Type: text/plain; charset="utf-8" TRACE_TIME() uses an initializer list and hence is covered by Misra C:2012 rule 13.1 ("Initializer lists shall not contain persistent side effects"). Use intermediate variables to address this. In vcpu_yield() take the opportunity to rename the existing variable which better would have been used already before. In do_sched_op() extend the scope of and rename an existing variable. Use both variables throughout the function. Also drop a pointless (and slightly malformed, style-wise) cast there, and adjust to other one to by style conformant. No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- Note that the violations presently are reported only for Arm. Similar issues would exist on x86 in Clang builds, afaict. --- v1.1: Also replace further (unrelated) uses of current in do_sched_op(). --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1531,20 +1531,20 @@ static long do_poll(const struct sched_p /* Voluntarily yield the processor for this allocation. */ long vcpu_yield(void) { - struct vcpu * v=3Dcurrent; + struct vcpu *curr =3D current; spinlock_t *lock; =20 rcu_read_lock(&sched_res_rculock); =20 - lock =3D unit_schedule_lock_irq(v->sched_unit); - sched_yield(vcpu_scheduler(v), v->sched_unit); - unit_schedule_unlock_irq(lock, v->sched_unit); + lock =3D unit_schedule_lock_irq(curr->sched_unit); + sched_yield(vcpu_scheduler(curr), curr->sched_unit); + unit_schedule_unlock_irq(lock, curr->sched_unit); =20 rcu_read_unlock(&sched_res_rculock); =20 SCHED_STAT_CRANK(vcpu_yield); =20 - TRACE_TIME(TRC_SCHED_YIELD, current->domain->domain_id, current->vcpu_= id); + TRACE_TIME(TRC_SCHED_YIELD, curr->domain->domain_id, curr->vcpu_id); raise_softirq(SCHEDULE_SOFTIRQ); return 0; } @@ -1914,6 +1914,8 @@ typedef long ret_t; =20 ret_t do_sched_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { + struct vcpu *curr =3D current; + struct domain *currd =3D curr->domain; ret_t ret =3D 0; =20 switch ( cmd ) @@ -1938,9 +1940,9 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN if ( copy_from_guest(&sched_shutdown, arg, 1) ) break; =20 - TRACE_TIME(TRC_SCHED_SHUTDOWN, current->domain->domain_id, - current->vcpu_id, sched_shutdown.reason); - ret =3D domain_shutdown(current->domain, (u8)sched_shutdown.reason= ); + TRACE_TIME(TRC_SCHED_SHUTDOWN, currd->domain_id, curr->vcpu_id, + sched_shutdown.reason); + ret =3D domain_shutdown(currd, sched_shutdown.reason); =20 break; } @@ -1948,19 +1950,18 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN case SCHEDOP_shutdown_code: { struct sched_shutdown sched_shutdown; - struct domain *d =3D current->domain; =20 ret =3D -EFAULT; if ( copy_from_guest(&sched_shutdown, arg, 1) ) break; =20 - TRACE_TIME(TRC_SCHED_SHUTDOWN_CODE, d->domain_id, current->vcpu_id, + TRACE_TIME(TRC_SCHED_SHUTDOWN_CODE, currd->domain_id, curr->vcpu_i= d, sched_shutdown.reason); =20 - spin_lock(&d->shutdown_lock); - if ( d->shutdown_code =3D=3D SHUTDOWN_CODE_INVALID ) - d->shutdown_code =3D (u8)sched_shutdown.reason; - spin_unlock(&d->shutdown_lock); + spin_lock(&currd->shutdown_lock); + if ( currd->shutdown_code =3D=3D SHUTDOWN_CODE_INVALID ) + currd->shutdown_code =3D (uint8_t)sched_shutdown.reason; + spin_unlock(&currd->shutdown_lock); =20 ret =3D 0; break; @@ -1993,7 +1994,7 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN if ( d =3D=3D NULL ) break; =20 - ret =3D xsm_schedop_shutdown(XSM_DM_PRIV, current->domain, d); + ret =3D xsm_schedop_shutdown(XSM_DM_PRIV, currd, d); if ( likely(!ret) ) domain_shutdown(d, sched_remote_shutdown.reason); =20 @@ -2010,8 +2011,7 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN if ( copy_from_guest(&sched_watchdog, arg, 1) ) break; =20 - ret =3D domain_watchdog( - current->domain, sched_watchdog.id, sched_watchdog.timeout); + ret =3D domain_watchdog(currd, sched_watchdog.id, sched_watchdog.t= imeout); break; } =20 @@ -2021,7 +2021,7 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN unsigned int cpu; =20 ret =3D -EPERM; - if ( !is_hardware_domain(current->domain) ) + if ( !is_hardware_domain(currd) ) break; =20 ret =3D -EFAULT; @@ -2033,7 +2033,7 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN break; =20 cpu =3D sched_pin_override.pcpu < 0 ? NR_CPUS : sched_pin_override= .pcpu; - ret =3D vcpu_temporary_affinity(current, cpu, VCPU_AFFINITY_OVERRI= DE); + ret =3D vcpu_temporary_affinity(curr, cpu, VCPU_AFFINITY_OVERRIDE); =20 break; } From nobody Thu Sep 24 20:23:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788436447; cv=none; d=zohomail.com; s=zohoarc; b=UrTUeP5ghd6utUyz66tfnnFxSPZAtTAk96srmcAhg4fvqlHJGXe1M9uAjvlj6NGjmdWZllqvwYDhiyJM2JpmZyjbFewIqb4FIcJp3XMfIBJdXlp/D+1b2ct28N+Uwcxi3Xy3PrSDMoOhvfXH5txldmx1oFBBDgrhTI26AOiuP7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788436447; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lmUEz1BSQEnPvhNy1tvkOzeOlVh/J2cVvdziF4BKMjs=; b=CrMwQvXXR6B2L3JIDiopN6mfXcZc3vB3j/R9RsN0f4TBlsvuBB/t+dDXLxG+K0oix+ILeWbw270jpv34FnbrBt3tPCnb6gkIzaq0SZ3kqHrPE1BjmIu7iZ+lrX0o6yGWegv1Ip9xyAWr1Q7mZvqkn4Ig1nhIBWUY18gOdfVYlzg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788436447063100.64390268866327; Thu, 3 Sep 2026 04:54:07 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1407002.1640173 (Exim 4.92) (envelope-from ) id 1x260w-0000AZ-MH; Thu, 03 Sep 2026 11:53:54 +0000 Received: by outflank-mailman (output) from mailman id 1407002.1640173; Thu, 03 Sep 2026 11:53:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x260w-0000AS-Jg; Thu, 03 Sep 2026 11:53:54 +0000 Received: by outflank-mailman (input) for mailman id 1407002; Thu, 03 Sep 2026 11:53:53 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x260v-0000AD-C2 for xen-devel@lists.xenproject.org; Thu, 03 Sep 2026 11:53:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x260u-003Y8T-Ou for xen-devel@lists.xenproject.org; Thu, 03 Sep 2026 13:53:52 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a995fb9-bab6-0a2a0a5309dd-0a2a450abcaa-48 for ; Thu, 03 Sep 2026 13:53:52 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a995fd0-f2d2-0a2a450a0019-d155802dc9f2-3 for ; Thu, 03 Sep 2026 13:53:52 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-49ccfbe062eso18297455e9.3 for ; Thu, 03 Sep 2026 04:53:52 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee7febb4sm70596455e9.14.2026.09.03.04.53.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 04:53:51 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788436432; x=1789041232; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=lmUEz1BSQEnPvhNy1tvkOzeOlVh/J2cVvdziF4BKMjs=; b=Ih9vcgnhfcT2+mbykv0H8lESbARexyDsrzxiCQ3TT1xV/ItZXrkP1+4c/6u/ZUTv6V ktJuiLlbFbFa3HDuOui3GaRusR8T29bZVpOXqbAvDxRueQZyF5qoyQ/z4x+PvHIIbEpI H6UO3iqAE8PESTWaXNevnIzbtelLfaqKyuVbdBd31hf8NO/8SzDYb65Q3r19Bi2PQ8jY jKUk0U3fcIoA5+a8ZJDyfGuE+bkgWOMsaY4Z+A3GbE5E02zdiqxHJn8/kaIpvZiDzgVM P5eJN6isg7JqdpYJUsv/Ge8qR06o8GQ/qt2LYdjzY2ofJaMBfv2qJ23Gw1et0MbjITrY JiFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788436432; x=1789041232; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=lmUEz1BSQEnPvhNy1tvkOzeOlVh/J2cVvdziF4BKMjs=; b=fCPci9uj1dZZGVlqNO8xH+1xvmcitWXKrE5DOfxoDugTgzGhU6yC9NNFKZjMgFaOvp 3+jDXqD1RrVYRLMFO9up2SGi+ODJm9g9g1JJsqMCjhKcAMVA3vojN/G8abo9K+HuNq6b FSBZL6/RpRapfQn8Q+p2sWRiWmUKvmPb38NWEm1gwtd3KY+Z5VtOmAQ4KytQ/n88LZKR laKxLuYMsLoDYkLAgZb3bnlb9Pk0W64nDxwjofSacah/BXTUCBrCvISjHwf71zftZk5e 3BJUY+nPqMnTIM+KIc7IR75Pt2TJY4ZxZYDhiLkj4XR5HFBdY1W2QzacFCX0FKOI08ks 161Q== X-Gm-Message-State: AFuF++nLZXbNnvCFh6E8hAmQW4ia00EmWtF+qWZi+8m558Rany5muiLI cqxS+VtP16Ajonvv8gxIhdxbuQxz3OCsJJG2zik5pwN/Fw3oFPqhrHO0hQ1DjgAXURq6ZHsfnmF LiM/IFA== X-Gm-Gg: AYBFou0ib8vvIqkCSUTljC0KSYYBNLXWPxQ8r0HHliOL56JdAQDkixIz5KCqfBT4yRZ lXFJ9yomnvRMxExh2CvKz4xDQSrTEY0KGPvEjjs7p2k1eALir1sY/1zD0bbUFgM6e01fpwwzC+q 8cem3EFWnuNkzoDvrM7Py5SIsghOxrOQylXU8Pss5Mx2weumF+GJsMQhcfjmnp+ItLBk4UuYRc4 RanJ8mH4qWzBXVh9C1s4UVXcqcdYwdgZww5G2HT7Ytcl2o/tt5OyArAz0uYBVC36kUAArVAwDly ZWHICItmOyS4EPGYgCxRm353duLPMcg15o+6GX0FWc6nx/zLXrMMeBcgIhy+qOUFA43T7RAwD5J /wQvL1LQmRklVK+EQt0VwgRrPchinmvBFYwujzN6/m6y0WfmjphrLW5tsh0QYpsxFueTHz4Goym gUggmQJNHPsma1B7QJs6KZhOumqxmbf/E8btQb4h9FQvf10e7dZAeulSrHr2HDFUiTrlrUuu9U4 btbNPq9cyDvUy0M0ehniwQoacIsQ8DqdumhCfaTP5RjR2JnucOp X-Received: by 2002:a05:600c:3f19:b0:499:93b3:91ea with SMTP id 5b1f17b1804b1-49ce582959cmr243680975e9.15.1788436432199; Thu, 03 Sep 2026 04:53:52 -0700 (PDT) Message-ID: <4eaf8244-25ec-45d4-844d-3d8f6720f57b@suse.com> Date: Thu, 3 Sep 2026 13:53:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/4] sched/core: avoid use of "current" in initializer lists From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Juergen Gross , Dario Faggioli , George Dunlap References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-4011c0/1788436432-59FDECFC-B9F8711E/0/0 X-purgate-type: clean X-purgate-size: 3501 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788436447751158500 Content-Type: text/plain; charset="utf-8" TRACE_TIME() uses an initializer list and hence is covered by Misra C:2012 rule 13.1 ("Initializer lists shall not contain persistent side effects"). Use intermediate variables to address this. In vcpu_yield() take the opportunity to rename the existing variable which better would have been used already before. In do_sched_op() extend the scope of and rename an existing variable. Also drop a pointless (and slightly malformed, style-wise) cast there, and adjust to other one to by style conformant. No functional change intended. Signed-off-by: Jan Beulich --- Note that the violations presently are reported only for Arm. Similar issues would exist on x86 in Clang builds, afaict. --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1531,20 +1531,20 @@ static long do_poll(const struct sched_p /* Voluntarily yield the processor for this allocation. */ long vcpu_yield(void) { - struct vcpu * v=3Dcurrent; + struct vcpu *curr =3D current; spinlock_t *lock; =20 rcu_read_lock(&sched_res_rculock); =20 - lock =3D unit_schedule_lock_irq(v->sched_unit); - sched_yield(vcpu_scheduler(v), v->sched_unit); - unit_schedule_unlock_irq(lock, v->sched_unit); + lock =3D unit_schedule_lock_irq(curr->sched_unit); + sched_yield(vcpu_scheduler(curr), curr->sched_unit); + unit_schedule_unlock_irq(lock, curr->sched_unit); =20 rcu_read_unlock(&sched_res_rculock); =20 SCHED_STAT_CRANK(vcpu_yield); =20 - TRACE_TIME(TRC_SCHED_YIELD, current->domain->domain_id, current->vcpu_= id); + TRACE_TIME(TRC_SCHED_YIELD, curr->domain->domain_id, curr->vcpu_id); raise_softirq(SCHEDULE_SOFTIRQ); return 0; } @@ -1914,6 +1914,8 @@ typedef long ret_t; =20 ret_t do_sched_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { + const struct vcpu *curr =3D current; + struct domain *currd =3D curr->domain; ret_t ret =3D 0; =20 switch ( cmd ) @@ -1938,9 +1940,9 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN if ( copy_from_guest(&sched_shutdown, arg, 1) ) break; =20 - TRACE_TIME(TRC_SCHED_SHUTDOWN, current->domain->domain_id, - current->vcpu_id, sched_shutdown.reason); - ret =3D domain_shutdown(current->domain, (u8)sched_shutdown.reason= ); + TRACE_TIME(TRC_SCHED_SHUTDOWN, currd->domain_id, curr->vcpu_id, + sched_shutdown.reason); + ret =3D domain_shutdown(currd, sched_shutdown.reason); =20 break; } @@ -1948,19 +1950,18 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN case SCHEDOP_shutdown_code: { struct sched_shutdown sched_shutdown; - struct domain *d =3D current->domain; =20 ret =3D -EFAULT; if ( copy_from_guest(&sched_shutdown, arg, 1) ) break; =20 - TRACE_TIME(TRC_SCHED_SHUTDOWN_CODE, d->domain_id, current->vcpu_id, + TRACE_TIME(TRC_SCHED_SHUTDOWN_CODE, currd->domain_id, curr->vcpu_i= d, sched_shutdown.reason); =20 - spin_lock(&d->shutdown_lock); - if ( d->shutdown_code =3D=3D SHUTDOWN_CODE_INVALID ) - d->shutdown_code =3D (u8)sched_shutdown.reason; - spin_unlock(&d->shutdown_lock); + spin_lock(&currd->shutdown_lock); + if ( currd->shutdown_code =3D=3D SHUTDOWN_CODE_INVALID ) + currd->shutdown_code =3D (uint8_t)sched_shutdown.reason; + spin_unlock(&currd->shutdown_lock); =20 ret =3D 0; break; From nobody Thu Sep 24 20:23:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788436475; cv=none; d=zohomail.com; s=zohoarc; b=JKAcfbx3b50P/SrBAKKA/kD2mgWfEhVwXuDCuulhQxPHhAGRO/gP1rmeQeYDOKC1Yl0fziCEAQ9XewfOFd1pusV8XPB0Ze4TjvBW8+tJQ0h2qDAue5AFkbI+h4HGPgPct404WBdCDdNaHaOPSMXzuNmZOGEvu0YZlj+cPNZpNYY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788436475; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=l2RayKkAWwog2AMYT8SbLHsD8Cx1SeVefikMrauC6CU=; b=ZHIUV2SQM6I1uaCxQ4DbouGYKruabLVJ8L6wGPwvthmG3QVWQG43mW1eK7EwYWSKmRG6BeDKRr+NLBPsqXNd/c9pQW/7/J+/Qb7XKW71cU4YBK2HVKpzhf5wn8kgyDcsp/cArMNpfydG4IfApzd6nymhxE1FiowMPwx/d/3gB8s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788436475217270.2115663347033; Thu, 3 Sep 2026 04:54:35 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1407008.1640183 (Exim 4.92) (envelope-from ) id 1x261O-0000bt-Tj; Thu, 03 Sep 2026 11:54:22 +0000 Received: by outflank-mailman (output) from mailman id 1407008.1640183; Thu, 03 Sep 2026 11:54:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x261O-0000bm-Ql; Thu, 03 Sep 2026 11:54:22 +0000 Received: by outflank-mailman (input) for mailman id 1407008; Thu, 03 Sep 2026 11:54:21 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x261M-0000aF-Uc for xen-devel@lists.xenproject.org; Thu, 03 Sep 2026 11:54:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x261L-003YQI-T8 for xen-devel@lists.xenproject.org; Thu, 03 Sep 2026 13:54:19 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a995fe2-e002-0a2a0a5209dd-0a2a450cc452-28 for ; Thu, 03 Sep 2026 13:54:19 +0200 Received: from [209.85.221.46] (helo=mail-wr1-f46.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a995feb-f479-0a2a450c0019-d155dd2ea927-3 for ; Thu, 03 Sep 2026 13:54:19 +0200 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-48442ea8f59so684489f8f.1 for ; Thu, 03 Sep 2026 04:54:19 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf5135353sm9405235e9.2.2026.09.03.04.54.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 04:54:18 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788436459; x=1789041259; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=l2RayKkAWwog2AMYT8SbLHsD8Cx1SeVefikMrauC6CU=; b=TxOMqNHwCvvIzrBjBCNoqMlQPp8iABIo0C+Wahuo+H9mBrKLoYXYLRq9txu6g+ckrQ kk1VXfvKoI/251cZThUBAjpH9a5cntjlsYBl0GfM5eNCUzwV11IH9McXqRbPrdSjUgP5 BQx9BN1rguVVqlzPMJix0DipWCSNXVnqCs3mdbDHDIe1lpO05rxzOIkrq37BW6q2GsQ4 xyCfid2tpJelxvZ7kYDXmc7w3IaIL8yf4xJEpEJMt68tx1PHi5t7a3teKANPJ0M4FAWK PQwfqj6L24PH1v9x1jj0Xw6e8H13u+634p5hZhYdIhkhTc/tV/TJ7zv3SiFehi3XFPm5 ew9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788436459; x=1789041259; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=l2RayKkAWwog2AMYT8SbLHsD8Cx1SeVefikMrauC6CU=; b=gyT5Et8YWMNl84bJC0KU2h4fm08ZY3mKCJDSF8RrcACuP34nd6qenhU3T76POLan1L 6lbEj9fsvTqC2/E2YFdO3hDPBy864y6indaoE1Wlj+jWbkC+QjErnjpWoPUzvV+MZ1oh m6SSllSlAXjvhYEzhWgZUOFJno9FY1hoDdNcUDpd3f1tB/EYIwAnkg4x/SY+bib6uwrY XyVbSI4Ld9KK3BzswvF02HPcVkwkL5B3M3neP/LBalECYwXvJ7Jsbt9ikndkGmzeUzim AvjmPiS51TzrKoQWC3d0m07g5dlBMU4ogpHQ9rBNk3m0T3LDGYhIZw7zdedF+yyrHjuO NWrQ== X-Gm-Message-State: AFuF++nmUeMJwAc0MpAYtB9mcuOKgz7iMJaW5BQw3gmglKdOfGfAH6ft L5+nVECaciIoJEia5hKHcf/j9xoSoTJ2kxtVgt3kjurxIpm6eGQH9MlYH0hJVMQUuPWeqf0uft6 HOUoKng== X-Gm-Gg: AYBFou3I61E581Y6+F9s4/j4Jm6scet7aqAGDjr4xiFkS6Gs0Cd+dzWLsF9oNBaAA4C qSf7Wb6kBQVusfVtaUn+U56qpGXkWfL+F4HmRSibjSyrfFQmWv3PAEsk9ab/RLlhgQHXoENWdIm 7YeuAH9vNaRkytVr4g39bJoGyAPxsgrzKodX8DsiQcxoXANgVcF2e6Y1mmFPCkrSk8NdR+o2jHC hCokuvfC+5CNv5W32aUGoQAIFQe4dh7G4LTTHv07mro0RSZ4D3R6yqYQI/r5kQQFyh5/348wOb4 /Ot07hBjvRBApTMVZQtXoryL9VTI3Fdsc3KqhQeh4xQnqmrWJ/8PzTheL3n5kG7F5DlTSHFhZcp 5bXBFFJYP3VJHtTj7LPknNavO8Q3VlNo10NyOZBzS/5SC4BeQiJ86v/vg6iaLxO1J6GqDhrigvU jGZ+kumvOyFX6B1bCyfJYiCT+irSw8qNy0zEvMEZ008QpX2nIomo8WOuWyhkjcpzNefBPMriiaS BAoVl4yX2pzJ33zMYi9b4yPwxJNEoKGLS4W4FL96br0SpgsEm1b X-Received: by 2002:a05:600d:4445:20b0:499:59fd:dbfc with SMTP id 5b1f17b1804b1-49cf1577d23mr25009095e9.1.1788436459066; Thu, 03 Sep 2026 04:54:19 -0700 (PDT) Message-ID: <4952eacf-06ad-433e-8d0a-14b704888d21@suse.com> Date: Thu, 3 Sep 2026 13:54:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/4] automation/Eclair: tag rule 13.1 as clean From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-d25034/1788436459-03AD4A5B-2D375781/0/0 X-purgate-type: clean X-purgate-size: 343 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788436475733158500 Content-Type: text/plain; charset="utf-8" Remaining violations were addressed. Signed-off-by: Jan Beulich Reviewed-by: Nicola Vetrini --- a/automation/eclair_analysis/ECLAIR/tagging.ecl +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl @@ -66,6 +66,7 @@ MC3A2.R11.7|| MC3A2.R11.9|| MC3A2.R12.2|| MC3A2.R12.5|| +MC3A2.R13.1|| MC3A2.R13.2|| MC3A2.R13.6|| MC3A2.R14.1||