From nobody Tue May 21 16:59:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1712321996780896.22121972619; Fri, 5 Apr 2024 05:59:56 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.701287.1095626 (Exim 4.92) (envelope-from ) id 1rsjAV-0005e4-Om; Fri, 05 Apr 2024 12:59:43 +0000 Received: by outflank-mailman (output) from mailman id 701287.1095626; Fri, 05 Apr 2024 12:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rsjAV-0005dx-MF; Fri, 05 Apr 2024 12:59:43 +0000 Received: by outflank-mailman (input) for mailman id 701287; Fri, 05 Apr 2024 12:59:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rsjAV-0005dp-1u for xen-devel@lists.xenproject.org; Fri, 05 Apr 2024 12:59:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d8ba420-f34c-11ee-a1ef-f123f15fe8a2; Fri, 05 Apr 2024 14:59:40 +0200 (CEST) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id 0360B4EE073E; Fri, 5 Apr 2024 14:59:38 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d8ba420-f34c-11ee-a1ef-f123f15fe8a2 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall Subject: [XEN PATCH] xen/compiler: address violation of MISRA C Rule 20.9 Date: Fri, 5 Apr 2024 14:59:35 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1712321998224100001 Content-Type: text/plain; charset="utf-8" The rule states: "All identifiers used in the controlling expression of #if or #elif preprocessing directives shall be #define'd before evaluation". In this case, using defined(identifier) is a MISRA-compliant way to achieve the same effect. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- This is the only outstanding violation of the rule, given the current configurations. There are likely other sites that may benefit from a gradual refactor. --- xen/include/xen/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index fc87a2edad7f..179ff23e62c5 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -30,7 +30,7 @@ =20 #define __weak __attribute__((__weak__)) =20 -#if !CONFIG_CC_IS_CLANG || CONFIG_CLANG_VERSION >=3D 140000 +#if !defined(CONFIG_CC_IS_CLANG) || CONFIG_CLANG_VERSION >=3D 140000 # define nocall __attribute__((__error__("Nonstandard ABI"))) #else # define nocall --=20 2.34.1