From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658805647526898.5149994637391; Mon, 25 Jul 2022 20:20:47 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374928.607137 (Exim 4.92) (envelope-from ) id 1oGB7J-0002iQ-7e; Tue, 26 Jul 2022 03:20:17 +0000 Received: by outflank-mailman (output) from mailman id 374928.607137; Tue, 26 Jul 2022 03:20:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGB7J-0002iJ-4a; Tue, 26 Jul 2022 03:20:17 +0000 Received: by outflank-mailman (input) for mailman id 374928; Tue, 26 Jul 2022 03:20:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGB7H-0002i7-2v for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:20:15 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id da854759-0c91-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:20:11 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1A62D5C00D8; Mon, 25 Jul 2022 23:20:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 25 Jul 2022 23:20:09 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:20:07 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da854759-0c91-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805609; x=1658892009; bh=rHEDfxRD/a 8Xy6nGoB/Ufb5Aee8IzVX8gl6KkLM1ayE=; b=wAW4LsScsEW9GwH8cMjG+uZruz swQVvOLcmRP432nunHw3PdVzK/JeUdFn/IemDIhi9hK2hAnCXOqXBao7CC7s0sKS HVs5OvEKa60wTESaX2isJ6Wpg1jsf71ZFBt5og0hVPtSp7jF9bOE4W86DlaEEvMH mifLdxyE5Rfai7w21f3QU7JEfm+zpf4wBsj2Yk9RjPeyfrZo75/QaB4u11JWUP2I ymRb2pJVJhFqGDalglsiIEHzUqp2rQz95EjWssVy2SbHOzZtOMvI+rJDICWceXss pGeBgAdl4W2zEY7lXMR7EV3+MAg1vMcNKzf8+uO6Lfv6z2qmnImaPOz88BBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805609; x= 1658892009; bh=rHEDfxRD/a8Xy6nGoB/Ufb5Aee8IzVX8gl6KkLM1ayE=; b=X 2ZR3MWRXVWuT1Gyp77fS/gPkYCZZY3kHkIKuoiOBCgtZk6RaSRxIX4ehC/L3NMHm ptnmoEeG/WQrCxiGOXdAHqe7sStwQmjGZBAwVwW2qyOYPo1HKlClF9jEkz5w7tuD R/M5QNd0CURCOWkPiCVCMhasTv1EPj46C1nO3W7rmxITq7WKe4U4sl5zqe8Br/mU trHUU2rB+lDdKGN3FdhaZkEQKRvzEGq5Tjc8MJd5HoIPli8FRwDmnXIOv0tJdTtW V7b//5x47+YLLEkZQIlIEAQ8IqHenB7B/OxV8+8uvT8PLFmPF5z5Wt6Rgp0NvWZD +Awu3VllUrdMfbvkjQdkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeek udejueeuudetudffffdtheetteeileekkeefjeeljefhkeelffevueffkeelfeenucffoh hmrghinhepghhithhhuhgsrdgtohhmpdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsih gslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Connor Davis , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger Date: Tue, 26 Jul 2022 05:19:56 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805648467100001 From: Connor Davis [Connor] Xue is a cross-platform USB 3 debugger that drives the Debug Capability (DbC) of xHCI-compliant host controllers. This patch implements the operations needed for xue to initialize the host controller's DbC and communicate with it. It also implements a struct uart_driver that uses xue as a backend. Note that only target -> host communication is supported for now. To use Xue as a console, add 'console=3Ddbgp dbgp=3Dxhci' to the command line. [Marek] The Xue driver is taken from https://github.com/connojd/xue and heavily refactored to fit into Xen code base. Major changes include: - rename to xhci_dbc - drop support for non-Xen systems - drop xue_ops abstraction - use Xen's native helper functions for PCI access - move all the code to xue.c, drop "inline" - build for x86 only - annotate functions with cf_check - adjust for Xen's code style At this stage, only the first xHCI is considered. Later patch adds support for choosing specific one. The driver is initiallized before memory allocator works, so all the transfer buffers (about 230KiB of them) are allocated statically and will use memory even if XUE console is not selected. The driver can be disabled build time to reclaim this memory. Signed-off-by: Connor Davis Signed-off-by: Marek Marczykowski-G=C3=B3recki --- Changes in v3: - rename to xhci-dbc - add empty stub for xhci_dbc_uart_init(), to avoid #ifdef in setup.c - use PCI_BASE_ADDRESS_MEM_MASK - make strings init more readable - avoid infinite extended caps lookup - size the whole 64bit BAR - rename CONFIG_HAS_XHCI to CONFIG_XHCI - use cpu_relax(), drop xue_sys_pause() - disable memory decoding for the BAR sizing time, and enable it explicitly - drop mmio_size field - it's used only in init_xhc() function internally - use readl()/writel() for accessing MMIO - add pci_ro_device(), to protect device before later patch(es) add other protections - fix setting dequeue pointer based on events: TRB ring was page aligned, not 16-page aligned, so just taking DBC_TRB_RING_MASK bits doesn't work; instead, calculate distance from the ring beginning; while at it, fix off by one error there; dequeue pointer isn't used much yet, but it will be useful for RX handling - split dbc_ensure_running() out of dbc_flush() - it make dbc_flush() more logical, and will make even more sense with RX support added - make enum names upper case Changes in v2: - drop #pragma pack - fix indentation in Kconfig - minor style fixes - use cache_flush() - mark init functions as __init, and return bool - fix PCI_SBDF usage, use constants from pci_regs.h - add command line docs - allow disabling the driver in menuconfig, to reclaim 2MB allocated memory - guard unused debug functions with #ifdef XUE_DEBUG --- docs/misc/xen-command-line.pandoc | 5 +- xen/arch/x86/include/asm/fixmap.h | 4 +- xen/arch/x86/setup.c | 1 +- xen/drivers/char/Kconfig | 9 +- xen/drivers/char/Makefile | 1 +- xen/drivers/char/xhci-dbc.c | 1024 ++++++++++++++++++++++++++++++- xen/include/xen/serial.h | 5 +- 7 files changed, 1049 insertions(+) create mode 100644 xen/drivers/char/xhci-dbc.c diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line= .pandoc index da18172e50c5..f936283cd187 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -721,10 +721,15 @@ Available alternatives, with their meaning, are: =20 ### dbgp > `=3D ehci[ | @pci:. ]` +> `=3D xhci` =20 Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). =20 +Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (outp= ut +only). XHCI driver will wait indefinitely for the debug host to connect - = make +sure the cable is connected. + ### debug_stack_lines > `=3D ` =20 diff --git a/xen/arch/x86/include/asm/fixmap.h b/xen/arch/x86/include/asm/f= ixmap.h index 20746afd0a2a..bc39ffe896b1 100644 --- a/xen/arch/x86/include/asm/fixmap.h +++ b/xen/arch/x86/include/asm/fixmap.h @@ -25,6 +25,8 @@ #include #include =20 +#define MAX_XHCI_PAGES 16 + /* * Here we define all the compile-time 'special' virtual * addresses. The point is to have a constant address at @@ -43,6 +45,8 @@ enum fixed_addresses { FIX_COM_BEGIN, FIX_COM_END, FIX_EHCI_DBGP, + FIX_XHCI_BEGIN, + FIX_XHCI_END =3D FIX_XHCI_BEGIN + MAX_XHCI_PAGES - 1, #ifdef CONFIG_XEN_GUEST FIX_PV_CONSOLE, FIX_XEN_SHARED_INFO, diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f08b07b8dea6..e05189f64997 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -950,6 +950,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) ns16550.irq =3D 3; ns16550_init(1, &ns16550); ehci_dbgp_init(); + xhci_dbc_uart_init(); console_init_preirq(); =20 if ( pvh_boot ) diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index dec58bc99360..06350c387371 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -84,3 +84,12 @@ config SERIAL_TX_BUFSIZE the nearest power of 2. =20 Default value is 16384 (16kiB). + +config XHCI + bool "XHCI DbC UART driver" + depends on X86 + help + This selects the USB based XHCI debug capability to be usable as a UART. + Enabling this option makes Xen use extra ~230KiB memory, even if XHCI U= ART + is not selected. + If you have an x86 based system with USB3, say Y. diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile index 14e67cf072d7..e7e374775d32 100644 --- a/xen/drivers/char/Makefile +++ b/xen/drivers/char/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) +=3D mvebu-uart.o obj-$(CONFIG_HAS_OMAP) +=3D omap-uart.o obj-$(CONFIG_HAS_SCIF) +=3D scif-uart.o obj-$(CONFIG_HAS_EHCI) +=3D ehci-dbgp.o +obj-$(CONFIG_XHCI) +=3D xhci-dbc.o obj-$(CONFIG_HAS_IMX_LPUART) +=3D imx-lpuart.o obj-$(CONFIG_ARM) +=3D arm-uart.o obj-y +=3D serial.o diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c new file mode 100644 index 000000000000..f0e60d1b86aa --- /dev/null +++ b/xen/drivers/char/xhci-dbc.c @@ -0,0 +1,1024 @@ +/* + * drivers/char/xhci-dbc.c + * + * Xen port for the xue debugger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; If not, see . + * + * Copyright (c) 2019 Assured Information Security. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* uncomment to have dbc_uart_dump() debug function */ +/* #define DBC_DEBUG 1 */ + +#define DBC_POLL_INTERVAL 100 /* us */ + +#define DBC_PAGE_SIZE 4096U + +/* Supported xHC PCI configurations */ +#define DBC_XHC_CLASSC 0xC0330U + +/* DbC idVendor and idProduct */ +#define DBC_DBC_VENDOR 0x1D6B +#define DBC_DBC_PRODUCT 0x0010 +#define DBC_DBC_PROTOCOL 0x0000 + +/* DCCTRL fields */ +#define DBC_CTRL_DCR 0 +#define DBC_CTRL_HOT 2 +#define DBC_CTRL_HIT 3 +#define DBC_CTRL_DRC 4 +#define DBC_CTRL_DCE 31 + +/* DCPORTSC fields */ +#define DBC_PSC_PED 1 +#define DBC_PSC_CSC 17 +#define DBC_PSC_PRC 21 +#define DBC_PSC_PLC 22 +#define DBC_PSC_CEC 23 + +#define DBC_PSC_ACK_MASK = \ + ((1UL << DBC_PSC_CSC) | (1UL << DBC_PSC_PRC) | (1UL << DBC_PSC_PLC) | = \ + (1UL << DBC_PSC_CEC)) + +#define dbc_debug(...) printk("dbc debug: " __VA_ARGS__) +#define dbc_alert(...) printk("dbc alert: " __VA_ARGS__) +#define dbc_error(...) printk("dbc error: " __VA_ARGS__) + +/*************************************************************************= ***** + * TRB ring (summarized from the manual): + * + * TRB rings are circular queues of TRBs shared between the xHC and the dr= iver. + * Each ring has one producer and one consumer. The DbC has one event + * ring and two transfer rings; one IN and one OUT. + * + * The DbC hardware is the producer on the event ring, and + * dbc driver is the consumer. This means that event TRBs are read-only fr= om + * the dbc driver. + * + * OTOH, dbc drive is the producer of transfer TRBs on the two transfer + * rings, so dbc driver enqueues transfers, and the hardware dequeues + * them. The dequeue pointer of a transfer ring is read by + * dbc driver by examining the latest transfer event TRB on the event ring= . The + * transfer event TRB contains the address of the transfer TRB that genera= ted + * the event. + * + * To make each transfer ring circular, the last TRB must be a link TRB, w= hich + * points to the beginning of the next queue. Note that this implementation + * does not support multiple segments, so each link TRB points back to the + * beginning of its own segment. + *************************************************************************= *****/ + +/* TRB types */ +enum { + XHCI_TRB_NORM =3D 1, + XHCI_TRB_LINK =3D 6, + XHCI_TRB_TFRE =3D 32, + XHCI_TRB_PSCE =3D 34 +}; + +/* TRB completion codes */ +enum { + XHCI_TRB_CC_SUCCESS =3D 1, + XHCI_TRB_CC_TRB_ERR =3D 5, +}; + +/* DbC endpoint types */ +enum { + XHCI_EP_BULK_OUT =3D 2, + XHCI_EP_BULK_IN =3D 6, +}; + +/* DMA/MMIO structures */ +struct xhci_trb { + uint64_t params; + uint32_t status; + uint32_t ctrl; +}; + +/* log2(sizeof(struct xhci_trb)) */ +#define XHCI_TRB_SHIFT 4 + +struct xhci_erst_segment { + uint64_t base; + uint16_t size; + uint8_t rsvdz[6]; +}; + +/* Arbitrary length, must fit every DBC_STRING_* */ +#define MAX_STRING_LENGTH 16 + +#define DBC_STRINGS_COUNT 4 +#define DBC_STRING_LANGID "\x09\x04" +#define DBC_STRING_MANUFACTURER "Xen" +#define DBC_STRING_PRODUCT "Debug console" +#define DBC_STRING_SERIAL "0" + +#define XHCI_DT_STRING 3 + +struct xhci_string_descriptor { + uint8_t size; + uint8_t type; + uint16_t string[MAX_STRING_LENGTH]; +}; + +#define DBC_CTX_SIZE 16 +#define DBC_CTX_BYTES (DBC_CTX_SIZE * 4) + +struct xhci_dbc_ctx { + union { + uint32_t info[DBC_CTX_SIZE]; + struct { + uint64_t string0_ptr; + uint64_t manufacturer_ptr; + uint64_t product_ptr; + uint64_t serial_ptr; + uint8_t string0_size; + uint8_t manufacturer_size; + uint8_t product_size; + uint8_t serial_size; + }; + }; + uint32_t ep_out[DBC_CTX_SIZE]; + uint32_t ep_in[DBC_CTX_SIZE]; +}; + +struct dbc_reg { + uint32_t id; + uint32_t db; + uint32_t erstsz; + uint32_t rsvdz; + uint64_t erstba; + uint64_t erdp; + uint32_t ctrl; + uint32_t st; + uint32_t portsc; + uint32_t rsvdp; + uint64_t cp; + uint32_t ddi1; + uint32_t ddi2; +}; + +#define DBC_TRB_MAX_TFR (DBC_PAGE_SIZE << 4) +#define DBC_TRB_PER_PAGE (DBC_PAGE_SIZE / sizeof(struct xhci_trb)) + +/* Defines the size in bytes of TRB rings as 2^DBC_TRB_RING_ORDER * 4096 */ +#ifndef DBC_TRB_RING_ORDER +#define DBC_TRB_RING_ORDER 4 +#endif +#define DBC_TRB_RING_CAP (DBC_TRB_PER_PAGE * (1 << DBC_TRB_RING_ORDER)) +#define DBC_TRB_RING_BYTES (DBC_TRB_RING_CAP * sizeof(struct xhci_trb)) +#define DBC_TRB_RING_MASK (DBC_TRB_RING_BYTES - 1U) + +struct xhci_trb_ring { + struct xhci_trb *trb; /* Array of TRBs */ + uint32_t enq; /* The offset of the enqueue ptr */ + uint32_t deq; /* The offset of the dequeue ptr */ + uint8_t cyc; /* Cycle state toggled on each wrap-around */ + uint8_t db; /* Doorbell target */ + uint64_t dma; /* Physical address (for the device) */ +}; + +#define DBC_DB_OUT 0x0 +#define DBC_DB_IN 0x1 +#define DBC_DB_INVAL 0xFF + +/* Defines the size in bytes of work rings as 2^DBC_WORK_RING_ORDER * 4096= */ +#ifndef DBC_WORK_RING_ORDER +#define DBC_WORK_RING_ORDER 3 +#endif +#define DBC_WORK_RING_CAP (DBC_PAGE_SIZE * (1 << DBC_WORK_RING_ORDER)) +#define DBC_WORK_RING_BYTES DBC_WORK_RING_CAP + +#if DBC_WORK_RING_CAP > DBC_TRB_MAX_TFR +#error "DBC_WORK_RING_ORDER must be at most 4" +#endif + +struct dbc_work_ring { + uint8_t *buf; + uint32_t enq; + uint32_t deq; + uint64_t dma; +}; + +struct dbc { + struct dbc_reg __iomem *dbc_reg; + struct xhci_dbc_ctx *dbc_ctx; + struct xhci_erst_segment *dbc_erst; + struct xhci_trb_ring dbc_ering; + struct xhci_trb_ring dbc_oring; + struct xhci_trb_ring dbc_iring; + struct dbc_work_ring dbc_owork; + struct xhci_string_descriptor *dbc_str; + + pci_sbdf_t sbdf; + uint64_t xhc_mmio_phys; + uint64_t xhc_dbc_offset; + void __iomem *xhc_mmio; + + bool open; +}; + +static void *dbc_sys_map_xhc(uint64_t phys, size_t size) +{ + size_t i; + + if ( size !=3D MAX_XHCI_PAGES * DBC_PAGE_SIZE ) + return NULL; + + for ( i =3D FIX_XHCI_END; i >=3D FIX_XHCI_BEGIN; i-- ) + { + set_fixmap_nocache(i, phys); + phys +=3D DBC_PAGE_SIZE; + } + + /* + * The fixmap grows downward, so the lowest virt is + * at the highest index + */ + return fix_to_virt(FIX_XHCI_END); +} + +static bool __init dbc_init_xhc(struct dbc *dbc) +{ + uint32_t bar0; + uint64_t bar1; + uint64_t bar_size; + uint64_t devfn; + uint16_t cmd; + size_t xhc_mmio_size; + + /* + * Search PCI bus 0 for the xHC. All the host controllers supported so= far + * are part of the chipset and are on bus 0. + */ + for ( devfn =3D 0; devfn < 256; devfn++ ) + { + pci_sbdf_t sbdf =3D PCI_SBDF(0, 0, devfn); + uint8_t hdr =3D pci_conf_read8(sbdf, PCI_HEADER_TYPE); + + if ( hdr =3D=3D 0 || hdr =3D=3D 0x80 ) + { + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) =3D=3D D= BC_XHC_CLASSC ) + { + dbc->sbdf =3D sbdf; + break; + } + } + } + + if ( !dbc->sbdf.sbdf ) + { + dbc_error("Compatible xHC not found on bus 0\n"); + return false; + } + + /* ...we found it, so parse the BAR and map the registers */ + bar0 =3D pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_0); + bar1 =3D pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_1); + + /* IO BARs not allowed; BAR must be 64-bit */ + if ( (bar0 & PCI_BASE_ADDRESS_SPACE) !=3D PCI_BASE_ADDRESS_SPACE_MEMOR= Y || + (bar0 & PCI_BASE_ADDRESS_MEM_TYPE_MASK) !=3D PCI_BASE_ADDRESS_MEM= _TYPE_64 ) + return false; + + cmd =3D pci_conf_read16(dbc->sbdf, PCI_COMMAND); + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd & ~PCI_COMMAND_MEMORY); + + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFF); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, 0xFFFFFFFF); + bar_size =3D pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_0); + bar_size |=3D (uint64_t)pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_1)= << 32; + xhc_mmio_size =3D ~(bar_size & PCI_BASE_ADDRESS_MEM_MASK) + 1; + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, bar0); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, bar1); + + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + + dbc->xhc_mmio_phys =3D (bar0 & PCI_BASE_ADDRESS_MEM_MASK) | (bar1 << 3= 2); + dbc->xhc_mmio =3D dbc_sys_map_xhc(dbc->xhc_mmio_phys, xhc_mmio_size); + + if ( dbc->xhc_mmio =3D=3D NULL ) + return false; + + if ( (cmd & PCI_COMMAND_MEMORY) =3D=3D 0 ) + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd | PCI_COMMAND_MEMORY); + + return true; +} + +/** + * The first register of the debug capability is found by traversing the + * host controller's capability list (xcap) until a capability + * with ID =3D 0xA is found. The xHCI capability list begins at address + * mmio + (HCCPARAMS1[31:16] << 2). + */ +static struct dbc_reg __iomem *xhci_find_dbc(struct dbc *dbc) +{ + uint32_t *xcap; + uint32_t xcap_val; + uint32_t next; + uint32_t id =3D 0; + uint8_t *mmio =3D (uint8_t *)dbc->xhc_mmio; + uint32_t *hccp1 =3D (uint32_t *)(mmio + 0x10); + const uint32_t DBC_ID =3D 0xA; + int ttl =3D 48; + + xcap =3D (uint32_t *)dbc->xhc_mmio; + /* + * This is initially an offset to the first capability. All the offsets + * (both in HCCP1 and then next capability pointer are dword-based. + */ + next =3D (readl(hccp1) & 0xFFFF0000) >> 16; + + while ( id !=3D DBC_ID && next && ttl-- ) + { + xcap +=3D next; + xcap_val =3D readl(xcap); + id =3D xcap_val & 0xFF; + next =3D (xcap_val & 0xFF00) >> 8; + } + + if ( id !=3D DBC_ID ) + return NULL; + + dbc->xhc_dbc_offset =3D (uint64_t)xcap - (uint64_t)mmio; + return (struct dbc_reg __iomem *)xcap; +} + +/** + * Fields with the same interpretation for every TRB type (section 4.11.1). + * These are the fields defined in the TRB template, minus the ENT bit. Th= at + * bit is the toggle cycle bit in link TRBs, so it shouldn't be in the + * template. + */ +static uint32_t xhci_trb_cyc(const struct xhci_trb *trb) +{ + return trb->ctrl & 0x1; +} + +static uint32_t xhci_trb_type(const struct xhci_trb *trb) +{ + return (trb->ctrl & 0xFC00) >> 10; +} + +static void xhci_trb_set_cyc(struct xhci_trb *trb, uint32_t c) +{ + trb->ctrl &=3D ~0x1U; + trb->ctrl |=3D c; +} + +static void xhci_trb_set_type(struct xhci_trb *trb, uint32_t t) +{ + trb->ctrl &=3D ~0xFC00U; + trb->ctrl |=3D (t << 10); +} + +/* Fields for normal TRBs */ +static void xhci_trb_norm_set_buf(struct xhci_trb *trb, uint64_t addr) +{ + trb->params =3D addr; +} + +static void xhci_trb_norm_set_len(struct xhci_trb *trb, uint32_t len) +{ + trb->status &=3D ~0x1FFFFU; + trb->status |=3D len; +} + +static void xhci_trb_norm_set_ioc(struct xhci_trb *trb) +{ + trb->ctrl |=3D 0x20; +} + +/** + * Fields for Transfer Event TRBs (see section 6.4.2.1). Note that event + * TRBs are read-only from software + */ +static uint64_t xhci_trb_tfre_ptr(const struct xhci_trb *trb) +{ + return trb->params; +} + +static uint32_t xhci_trb_tfre_cc(const struct xhci_trb *trb) +{ + return trb->status >> 24; +} + +/* Fields for link TRBs (section 6.4.4.1) */ +static void xhci_trb_link_set_rsp(struct xhci_trb *trb, uint64_t rsp) +{ + trb->params =3D rsp; +} + +static void xhci_trb_link_set_tc(struct xhci_trb *trb) +{ + trb->ctrl |=3D 0x2; +} + +static void xhci_trb_ring_init(const struct dbc *dbc, + struct xhci_trb_ring *ring, int producer, + int doorbell) +{ + memset(ring->trb, 0, DBC_TRB_RING_CAP * sizeof(ring->trb[0])); + + ring->enq =3D 0; + ring->deq =3D 0; + ring->cyc =3D 1; + ring->db =3D (uint8_t)doorbell; + ring->dma =3D virt_to_maddr(ring->trb); + + /* + * Producer implies transfer ring, so we have to place a + * link TRB at the end that points back to trb[0] + */ + if ( producer ) + { + struct xhci_trb *trb =3D &ring->trb[DBC_TRB_RING_CAP - 1]; + xhci_trb_set_type(trb, XHCI_TRB_LINK); + xhci_trb_link_set_tc(trb); + xhci_trb_link_set_rsp(trb, virt_to_maddr(ring->trb)); + } +} + +static int xhci_trb_ring_full(const struct xhci_trb_ring *ring) +{ + return ((ring->enq + 1) & (DBC_TRB_RING_CAP - 1)) =3D=3D ring->deq; +} + +static int dbc_work_ring_full(const struct dbc_work_ring *ring) +{ + return ((ring->enq + 1) & (DBC_WORK_RING_CAP - 1)) =3D=3D ring->deq; +} + +static uint64_t dbc_work_ring_size(const struct dbc_work_ring *ring) +{ + if ( ring->enq >=3D ring->deq ) + return ring->enq - ring->deq; + + return DBC_WORK_RING_CAP - ring->deq + ring->enq; +} + +static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, + uint64_t dma, uint64_t len) +{ + struct xhci_trb trb; + + if ( ring->enq =3D=3D DBC_TRB_RING_CAP - 1 ) + { + /* + * We have to make sure the xHC processes the link TRB in order + * for wrap-around to work properly. We do this by marking the + * xHC as owner of the link TRB by setting the TRB's cycle bit + * (just like with normal TRBs). + */ + struct xhci_trb *link =3D &ring->trb[ring->enq]; + xhci_trb_set_cyc(link, ring->cyc); + + ring->enq =3D 0; + ring->cyc ^=3D 1; + } + + trb.params =3D 0; + trb.status =3D 0; + trb.ctrl =3D 0; + + xhci_trb_set_type(&trb, XHCI_TRB_NORM); + xhci_trb_set_cyc(&trb, ring->cyc); + + xhci_trb_norm_set_buf(&trb, dma); + xhci_trb_norm_set_len(&trb, (uint32_t)len); + xhci_trb_norm_set_ioc(&trb); + + ring->trb[ring->enq++] =3D trb; + cache_flush(&ring->trb[ring->enq - 1], sizeof(trb)); +} + +static int64_t dbc_push_work(struct dbc *dbc, struct dbc_work_ring *ring, + const char *buf, unsigned int len) +{ + unsigned int i =3D 0; + unsigned int end, start =3D ring->enq; + + while ( !dbc_work_ring_full(ring) && i < len ) + { + ring->buf[ring->enq] =3D buf[i++]; + ring->enq =3D (ring->enq + 1) & (DBC_WORK_RING_CAP - 1); + } + + end =3D ring->enq; + + if ( end > start ) + cache_flush(&ring->buf[start], end - start); + else if ( i > 0 ) + { + cache_flush(&ring->buf[start], DBC_WORK_RING_CAP - start); + cache_flush(&ring->buf[0], end); + } + + return i; +} + +/* + * Note that if IN transfer support is added, then this + * will need to be changed; it assumes an OUT transfer ring only + */ +static void dbc_pop_events(struct dbc *dbc) +{ + struct dbc_reg *reg =3D dbc->dbc_reg; + struct xhci_trb_ring *er =3D &dbc->dbc_ering; + struct xhci_trb_ring *tr =3D &dbc->dbc_oring; + struct xhci_trb *event =3D &er->trb[er->deq]; + uint64_t erdp =3D readq(®->erdp); + uint32_t portsc; + uint64_t event_ptr; + unsigned int trb_idx; + + BUILD_BUG_ON((1 << XHCI_TRB_SHIFT) !=3D sizeof(struct xhci_trb)); + + rmb(); + + while ( xhci_trb_cyc(event) =3D=3D er->cyc ) + { + switch (xhci_trb_type(event)) + { + case XHCI_TRB_TFRE: + event_ptr =3D xhci_trb_tfre_ptr(event); + /* + * trb_idx is just completed TRB, so set the dequeue ptr one + * position further. + */ + if ( event_ptr - tr->dma < DBC_TRB_RING_BYTES ) + { + trb_idx =3D (event_ptr - tr->dma) >> XHCI_TRB_SHIFT; + tr->deq =3D (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); + } + else + dbc_alert("event: TRB 0x%lx not found in any ring\n", + event_ptr); + break; + case XHCI_TRB_PSCE: + portsc =3D readl(®->portsc); + portsc |=3D DBC_PSC_ACK_MASK & portsc; + writel(portsc, ®->portsc); + break; + default: + break; + } + + er->cyc =3D (er->deq =3D=3D DBC_TRB_RING_CAP - 1) ? er->cyc ^ 1 : = er->cyc; + er->deq =3D (er->deq + 1) & (DBC_TRB_RING_CAP - 1); + event =3D &er->trb[er->deq]; + } + + erdp =3D er->dma + (er->deq << XHCI_TRB_SHIFT); + wmb(); + writeq(erdp, ®->erdp); +} + +/** + * dbc_init_ep + * + * Initializes the endpoint as specified in sections 7.6.3.2 and 7.6.9.2. + * Each endpoint is Bulk, so the MaxPStreams, LSA, HID, CErr, FE, + * Interval, Mult, and Max ESIT Payload fields are all 0. + * + * Max packet size: 1024 + * Max burst size: debug mbs (from dbc_reg->ctrl register) + * EP type: 2 for OUT bulk, 6 for IN bulk + * TR dequeue ptr: physical base address of transfer ring + * Avg TRB length: software defined (see 4.14.1.1 for suggested defaults) + */ +static void dbc_init_ep(uint32_t *ep, uint64_t mbs, uint32_t type, + uint64_t ring_dma) +{ + memset(ep, 0, DBC_CTX_BYTES); + + ep[1] =3D (1024 << 16) | ((uint32_t)mbs << 8) | (type << 3); + ep[2] =3D (ring_dma & 0xFFFFFFFF) | 1; + ep[3] =3D ring_dma >> 32; + ep[4] =3D 3 * 1024; +} + +static void dbc_init_string_single(struct xhci_string_descriptor *string, + char *ascii_str, + uint64_t *str_ptr, + uint8_t *str_size_ptr) +{ + size_t i, len =3D strlen(ascii_str); + + string->size =3D offsetof(typeof(*string), string) + len * 2; + string->type =3D XHCI_DT_STRING; + /* ASCII to UTF16 conversion */ + for (i =3D 0; i < len; i++) + string->string[i] =3D ascii_str[i]; + *str_ptr =3D virt_to_maddr(string); + *str_size_ptr =3D string->size; +} + +/* Initialize the DbC info with USB string descriptor addresses */ +static void dbc_init_strings(struct dbc *dbc, uint32_t *info) +{ + BUILD_BUG_ON(sizeof(DBC_STRING_LANGID) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_MANUFACTURER) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_PRODUCT) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_SERIAL) > MAX_STRING_LENGTH); + + dbc_init_string_single(&dbc->dbc_str[0], DBC_STRING_LANGID, + &dbc->dbc_ctx->string0_ptr, + &dbc->dbc_ctx->string0_size); + dbc_init_string_single(&dbc->dbc_str[1], DBC_STRING_MANUFACTURER, + &dbc->dbc_ctx->manufacturer_ptr, + &dbc->dbc_ctx->manufacturer_size); + dbc_init_string_single(&dbc->dbc_str[2], DBC_STRING_PRODUCT, + &dbc->dbc_ctx->product_ptr, + &dbc->dbc_ctx->product_size); + dbc_init_string_single(&dbc->dbc_str[3], DBC_STRING_SERIAL, + &dbc->dbc_ctx->serial_ptr, + &dbc->dbc_ctx->serial_size); +} + +static void dbc_enable_dbc(struct dbc *dbc) +{ + struct dbc_reg *reg =3D dbc->dbc_reg; + + wmb(); + writel(readl(®->ctrl) | (1U << DBC_CTRL_DCE), ®->ctrl); + wmb(); + + while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCE)) =3D=3D 0 ) + cpu_relax(); + + wmb(); + writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); + wmb(); + + while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCR)) =3D=3D 0 ) + cpu_relax(); +} + +static void dbc_disable_dbc(struct dbc *dbc) +{ + struct dbc_reg *reg =3D dbc->dbc_reg; + + writel(readl(®->portsc) & ~(1U << DBC_PSC_PED), ®->portsc); + wmb(); + writel(readl(®->ctrl) & ~(1U << DBC_CTRL_DCE), ®->ctrl); + + while ( readl(®->ctrl) & (1U << DBC_CTRL_DCE) ) + cpu_relax(); +} + +static int dbc_init_dbc(struct dbc *dbc) +{ + uint64_t erdp =3D 0; + uint64_t mbs =3D 0; + uint16_t cmd; + struct dbc_reg *reg =3D xhci_find_dbc(dbc); + + if ( !reg ) + return 0; + + dbc->dbc_reg =3D reg; + dbc_disable_dbc(dbc); + + xhci_trb_ring_init(dbc, &dbc->dbc_ering, 0, DBC_DB_INVAL); + xhci_trb_ring_init(dbc, &dbc->dbc_oring, 1, DBC_DB_OUT); + xhci_trb_ring_init(dbc, &dbc->dbc_iring, 1, DBC_DB_IN); + + erdp =3D virt_to_maddr(dbc->dbc_ering.trb); + if ( !erdp ) + return 0; + + memset(dbc->dbc_erst, 0, sizeof(*dbc->dbc_erst)); + dbc->dbc_erst->base =3D erdp; + dbc->dbc_erst->size =3D DBC_TRB_RING_CAP; + + mbs =3D (readl(®->ctrl) & 0xFF0000) >> 16; + + memset(dbc->dbc_ctx, 0, sizeof(*dbc->dbc_ctx)); + dbc_init_strings(dbc, dbc->dbc_ctx->info); + dbc_init_ep(dbc->dbc_ctx->ep_out, mbs, XHCI_EP_BULK_OUT, + dbc->dbc_oring.dma); + dbc_init_ep(dbc->dbc_ctx->ep_in, mbs, XHCI_EP_BULK_IN, + dbc->dbc_iring.dma); + + writel(1, ®->erstsz); + writeq(virt_to_maddr(dbc->dbc_erst), ®->erstba); + writeq(erdp, ®->erdp); + writeq(virt_to_maddr(dbc->dbc_ctx), ®->cp); + writel((DBC_DBC_VENDOR << 16) | DBC_DBC_PROTOCOL, ®->ddi1); + writel(DBC_DBC_PRODUCT, ®->ddi2); + + cache_flush(dbc->dbc_ctx, sizeof(*dbc->dbc_ctx)); + cache_flush(dbc->dbc_erst, sizeof(*dbc->dbc_erst)); + cache_flush(dbc->dbc_ering.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_oring.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_iring.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_owork.buf, DBC_WORK_RING_BYTES); + + cmd =3D pci_conf_read16(dbc->sbdf, PCI_COMMAND); + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd | PCI_COMMAND_MASTER); + + return 1; +} + +static void dbc_init_work_ring(struct dbc *dbc, + struct dbc_work_ring *wrk) +{ + wrk->enq =3D 0; + wrk->deq =3D 0; + wrk->dma =3D virt_to_maddr(wrk->buf); +} + +/** + * Initialize the DbC and enable it for transfers. First map in the DbC + * registers from the host controller's MMIO region. Then allocate and map + * DMA for the event and transfer rings. Finally, enable the DbC for + * the host to enumerate. On success, the DbC is ready to send packets. + * + * @param dbc the dbc to open (!=3D NULL) + * @return true iff dbc_open succeeded + */ +static bool __init dbc_open(struct dbc *dbc) +{ + if ( !dbc ) + return false; + + if ( !dbc_init_xhc(dbc) ) + return false; + + if ( !dbc_init_dbc(dbc) ) + return false; + + dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_enable_dbc(dbc); + dbc->open =3D true; + + return true; +} + +/* + * Ensure DbC is still running, handle events, and possibly re-enable if c= able + * was re-plugged. Returns true if DbC is operational. + */ +static bool dbc_ensure_running(struct dbc *dbc) +{ + struct dbc_reg *reg =3D dbc->dbc_reg; + uint32_t ctrl; + uint32_t cmd; + + dbc_pop_events(dbc); + + ctrl =3D readl(®->ctrl); + if ( !(ctrl & (1U << DBC_CTRL_DCR)) ) + { + return false; + } + + if ( ctrl & (1U << DBC_CTRL_DRC) ) + { + writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl); + writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); + wmb(); + } + + return true; +} + +/** + * Commit the pending transfer TRBs to the DbC. This notifies + * the DbC of any previously-queued data on the work ring and + * rings the doorbell. + * + * @param dbc the dbc to flush + * @param trb the ring containing the TRBs to transfer + * @param wrk the work ring containing data to be flushed + */ +static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, + struct dbc_work_ring *wrk) +{ + struct dbc_reg *reg =3D dbc->dbc_reg; + uint32_t db =3D (readl(®->db) & 0xFFFF00FF) | (trb->db << 8); + + if ( xhci_trb_ring_full(trb) ) + return; + + if ( wrk->enq =3D=3D wrk->deq ) + return; + else if ( wrk->enq > wrk->deq ) + { + dbc_push_trb(dbc, trb, wrk->dma + wrk->deq, wrk->enq - wrk->deq); + wrk->deq =3D wrk->enq; + } + else + { + dbc_push_trb(dbc, trb, wrk->dma + wrk->deq, + DBC_WORK_RING_CAP - wrk->deq); + wrk->deq =3D 0; + if ( wrk->enq > 0 && !xhci_trb_ring_full(trb) ) + { + dbc_push_trb(dbc, trb, wrk->dma, wrk->enq); + wrk->deq =3D wrk->enq; + } + } + + wmb(); + writel(db, ®->db); +} + +/** + * Queue a single character to the DbC. A transfer TRB will be created + * if the character is a newline and the DbC will be notified that data is + * available for writing to the debug host. + * + * @param dbc the dbc to write to + * @param c the character to write + * @return the number of bytes written + */ +static int64_t dbc_putc(struct dbc *dbc, char c) +{ + if ( !dbc_push_work(dbc, &dbc->dbc_owork, &c, 1) ) + return 0; + + if ( !dbc_ensure_running(dbc) ) + return 1; + + if ( c =3D=3D '\n' ) + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + + return 1; +} + +struct dbc_uart { + struct dbc dbc; + struct timer timer; + spinlock_t *lock; +}; + +static struct dbc_uart dbc_uart; + +static void cf_check dbc_uart_poll(void *data) +{ + struct serial_port *port =3D data; + struct dbc_uart *uart =3D port->uart; + struct dbc *dbc =3D &uart->dbc; + unsigned long flags =3D 0; + + if ( spin_trylock_irqsave(&port->tx_lock, flags) ) + { + if ( dbc_ensure_running(dbc) ) + { + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + dbc_enqueue_in(dbc, &dbc->dbc_iring, &dbc->dbc_iwork); + } + spin_unlock_irqrestore(&port->tx_lock, flags); + } + + serial_tx_interrupt(port, guest_cpu_user_regs()); + set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); +} + +static void __init cf_check dbc_uart_init_preirq(struct serial_port *port) +{ + struct dbc_uart *uart =3D port->uart; + uart->lock =3D &port->tx_lock; +} + +static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) +{ + struct dbc_uart *uart =3D port->uart; + + serial_async_transmit(port); + init_timer(&uart->timer, dbc_uart_poll, port, 0); + set_timer(&uart->timer, NOW() + MILLISECS(1)); + + if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to mark read-only %pp used for XHCI console\n", + &uart->dbc.sbdf); +} + +static int cf_check dbc_uart_tx_ready(struct serial_port *port) +{ + struct dbc_uart *uart =3D port->uart; + struct dbc *dbc =3D &uart->dbc; + + return DBC_WORK_RING_CAP - dbc_work_ring_size(&dbc->dbc_owork); +} + +static void cf_check dbc_uart_putc(struct serial_port *port, char c) +{ + struct dbc_uart *uart =3D port->uart; + dbc_putc(&uart->dbc, c); +} + +static void cf_check dbc_uart_flush(struct serial_port *port) +{ + s_time_t goal; + struct dbc_uart *uart =3D port->uart; + struct dbc *dbc =3D &uart->dbc; + + if ( dbc_ensure_running(dbc) ) + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + + goal =3D NOW() + MICROSECS(DBC_POLL_INTERVAL); + if ( uart->timer.expires > goal ) + set_timer(&uart->timer, goal); +} + +static struct uart_driver dbc_uart_driver =3D { + .init_preirq =3D dbc_uart_init_preirq, + .init_postirq =3D dbc_uart_init_postirq, + .tx_ready =3D dbc_uart_tx_ready, + .putc =3D dbc_uart_putc, + .flush =3D dbc_uart_flush, +}; + +static struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; +static struct xhci_trb out_trb[DBC_TRB_RING_CAP]; +static struct xhci_trb in_trb[DBC_TRB_RING_CAP]; +static struct xhci_erst_segment erst __aligned(64); +static struct xhci_dbc_ctx ctx __aligned(64); +static uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); +static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; +static char __initdata opt_dbgp[30]; + +string_param("dbgp", opt_dbgp); + +void __init xhci_dbc_uart_init(void) +{ + struct dbc_uart *uart =3D &dbc_uart; + struct dbc *dbc =3D &uart->dbc; + + if ( strncmp(opt_dbgp, "xhci", 4) ) + return; + + memset(dbc, 0, sizeof(*dbc)); + + dbc->dbc_ctx =3D &ctx; + dbc->dbc_erst =3D &erst; + dbc->dbc_ering.trb =3D evt_trb; + dbc->dbc_oring.trb =3D out_trb; + dbc->dbc_iring.trb =3D in_trb; + dbc->dbc_owork.buf =3D out_wrk_buf; + dbc->dbc_str =3D str_buf; + + if ( dbc_open(dbc) ) + serial_register_uart(SERHND_DBGP, &dbc_uart_driver, &dbc_uart); +} + +#ifdef DBC_DEBUG +static void dbc_dump(struct dbc *dbc) +{ + struct dbc_reg *r =3D dbc->dbc_reg; + + dbc_debug("XHCI DBC DUMP:\n"); + dbc_debug(" ctrl: 0x%x stat: 0x%x psc: 0x%x\n", + readl(&r->ctrl), readl(&r->st), readl(&r->portsc)); + dbc_debug(" id: 0x%x, db: 0x%x\n", + readl(&r->id), readl(&r->db)); + dbc_debug(" erstsz: %u, erstba: 0x%lx\n", + readl(&r->erstsz), readq(&r->erstba)); + dbc_debug(" erdp: 0x%lx, cp: 0x%lx\n", + readq(&r->erdp), readq(&r->cp)); + dbc_debug(" ddi1: 0x%x, ddi2: 0x%x\n", + readl(&r->ddi1), readl(&r->ddi2)); + dbc_debug(" erstba =3D=3D virt_to_dma(erst): %d\n", + readq(&r->erstba) =3D=3D virt_to_maddr(dbc->dbc_erst)); + dbc_debug(" erdp =3D=3D virt_to_dma(erst[0].base): %d\n", + readq(&r->erdp) =3D=3D dbc->dbc_erst[0].base); + dbc_debug(" cp =3D=3D virt_to_dma(ctx): %d\n", + readq(&r->cp) =3D=3D virt_to_maddr(dbc->dbc_ctx)); +} + +static void dbc_uart_dump(void) +{ + struct dbc_uart *uart =3D &dbc_uart; + struct dbc *dbc =3D &uart->dbc; + + dbc_dump(dbc); +} +#endif diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 6548f0b0a9cf..181e026967bc 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -171,6 +171,11 @@ struct ns16550_defaults { }; void ns16550_init(int index, struct ns16550_defaults *defaults); void ehci_dbgp_init(void); +#ifdef CONFIG_XHCI +void xhci_dbc_uart_init(void); +#else +static void inline xhci_dbc_uart_init(void) {}; +#endif =20 void arm_uart_init(void); =20 --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658805842048555.8780827734059; Mon, 25 Jul 2022 20:24:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374936.607170 (Exim 4.92) (envelope-from ) id 1oGBAV-0003wK-FO; Tue, 26 Jul 2022 03:23:35 +0000 Received: by outflank-mailman (output) from mailman id 374936.607170; Tue, 26 Jul 2022 03:23:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAV-0003w9-BY; Tue, 26 Jul 2022 03:23:35 +0000 Received: by outflank-mailman (input) for mailman id 374936; Tue, 26 Jul 2022 03:23:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAT-0003P0-SL for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:33 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52d2e04c-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:31 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1E3605C00E4; Mon, 25 Jul 2022 23:23:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:31 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:29 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52d2e04c-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805811; x=1658892211; bh=mn0z1OH9eg gVIVHY4O0/oZ9aMMverVaOFzZCSUteg7c=; b=glyArnG9S9fGItYdmV6xuIABX5 FhM7J6AkqfUzfPh2O7CVhcjHsDrn7PO5FMQqiIr+fZUPQ5TPMxNUjFxrTBdZgqVh OkTmGiHQl3joPxAxosiLnyuirErBkMVPuc8GZP5Cq1gxPcKcj99Ml5Kt9ao/dnzG 8x2Vd3NH1Gh+WBtkhq8enqPrvgFfEGPNcG7+ebW3MxbPpy3xRjXaEzw5UGKokKwB 6nbnETABu/fgP9cWXq7u0x0KvFzW9MRdMlEnhRokQwSznX1oojyY/DXZr6rQGUKu WWBIhHVMB28SnHTrvjmpUOKNDHbH0YCJyiVaHfrSmLY8MiAR1n8u/VHIzz2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805811; x= 1658892211; bh=mn0z1OH9eggVIVHY4O0/oZ9aMMverVaOFzZCSUteg7c=; b=Q lyKL0uHEipv1rrru2WwJyMUJQaNjeg4nDF+9uELy6xyvm/OEixaJkKYQ0ApF8oXZ qWPtLiBjr/DfeMh8QW+unVX8uBBvHXilEPtIRQ8i/lWP5Psa3E23tgWM9X+oKg3t g/CHzhwkKKudqZmSCzlpNLd38Gt3MIZs6QagGcb6C2plPKjQHGTI+5Jx4AKj0J6M ZGuszkvtgmsq5cFPe1zZAlJyk+Mlnf4K7la8EHTqFiZrq4S7uL8IZuwiGA2cvHUB 5RZvFXmTWj9+rcPDEshWS7gqfr9co+LvQjwhj/a5ldQVOwKkEEV1YsyE+za7GuVs HvaU9M2d4LyR22NKVCZiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 02/10] drivers/char: reset XHCI ports when initializing dbc Date: Tue, 26 Jul 2022 05:23:07 +0200 Message-Id: <0f26cc3299e340f7cea58aa59fcd462abd3215da.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805843131100007 Reset ports, to force host system to re-enumerate devices. Otheriwse it will require the cable to be re-plugged, or will wait in the "configuring" state indefinitely. Trick and code copied from Linux: drivers/usb/early/xhci-dbc.c:xdbc_start()->xdbc_reset_debug_port() Signed-off-by: Marek Marczykowski-G=C3=B3recki Acked-by: Jan Beulich --- Changes in v3: - adjust for renamed driver - use readl() etc for MMIO - simplify xcap lookup - drop acked-by Changes in v2: - use uint32_t instead of u32 - code style --- xen/drivers/char/xhci-dbc.c | 75 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 75 insertions(+) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index f0e60d1b86aa..53c39eedd4a6 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -63,6 +63,10 @@ ((1UL << DBC_PSC_CSC) | (1UL << DBC_PSC_PRC) | (1UL << DBC_PSC_PLC) | = \ (1UL << DBC_PSC_CEC)) =20 +#define XHC_EXT_PORT_MAJOR(x) (((x) >> 24) & 0xff) +#define PORT_RESET (1 << 4) +#define PORT_CONNECT (1 << 0) + #define dbc_debug(...) printk("dbc debug: " __VA_ARGS__) #define dbc_alert(...) printk("dbc alert: " __VA_ARGS__) #define dbc_error(...) printk("dbc error: " __VA_ARGS__) @@ -660,6 +664,73 @@ static void dbc_init_strings(struct dbc *dbc, uint32_t= *info) &dbc->dbc_ctx->serial_size); } =20 +static void dbc_do_reset_debug_port(struct dbc *dbc, + unsigned int id, unsigned int count) +{ + uint32_t __iomem *ops_reg; + uint32_t __iomem *portsc; + uint32_t val, cap_length; + unsigned int i; + + cap_length =3D readl(dbc->xhc_mmio) & 0xff; + ops_reg =3D dbc->xhc_mmio + cap_length; + + id--; + for ( i =3D id; i < (id + count); i++ ) + { + portsc =3D ops_reg + 0x100 + i * 0x4; + val =3D readl(portsc); + if ( !(val & PORT_CONNECT) ) + writel(val | PORT_RESET, portsc); + } +} + +static void dbc_reset_debug_port(struct dbc *dbc) +{ + uint32_t val, port_offset, port_count; + uint32_t __iomem *xcap; + uint32_t xcap_val; + uint32_t next; + uint32_t id; + uint8_t __iomem *mmio =3D (uint8_t *)dbc->xhc_mmio; + uint32_t __iomem *hccp1 =3D (uint32_t *)(mmio + 0x10); + const uint32_t PROTOCOL_ID =3D 0x2; + int ttl =3D 48; + + xcap =3D (uint32_t *)dbc->xhc_mmio; + /* + * This is initially an offset to the first capability. All the offsets + * (both in HCCP1 and then next capability pointer are dword-based. + */ + next =3D (readl(hccp1) & 0xFFFF0000) >> 16; + + /* + * Look for "supported protocol" capability, major revision 3. + * There may be multiple of them. + */ + while ( next && ttl-- ) + { + xcap +=3D next; + xcap_val =3D readl(xcap); + id =3D xcap_val & 0xFF; + next =3D (xcap_val & 0xFF00) >> 8; + + if ( id !=3D PROTOCOL_ID ) + continue; + + if ( XHC_EXT_PORT_MAJOR(xcap_val) !=3D 0x3 ) + continue; + + /* extract ports offset and count from the capability structure */ + val =3D readl(xcap + 2); + port_offset =3D val & 0xff; + port_count =3D (val >> 8) & 0xff; + + /* and reset them all */ + dbc_do_reset_debug_port(dbc, port_offset, port_count); + } +} + static void dbc_enable_dbc(struct dbc *dbc) { struct dbc_reg *reg =3D dbc->dbc_reg; @@ -671,6 +742,10 @@ static void dbc_enable_dbc(struct dbc *dbc) while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCE)) =3D=3D 0 ) cpu_relax(); =20 + /* reset ports on initial open, to force re-enumerating by the host */ + if ( !dbc->open ) + dbc_reset_debug_port(dbc); + wmb(); writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); wmb(); --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658805842633290.0407891389982; Mon, 25 Jul 2022 20:24:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374937.607181 (Exim 4.92) (envelope-from ) id 1oGBAW-0004Dn-P5; Tue, 26 Jul 2022 03:23:36 +0000 Received: by outflank-mailman (output) from mailman id 374937.607181; Tue, 26 Jul 2022 03:23:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAW-0004D1-JO; Tue, 26 Jul 2022 03:23:36 +0000 Received: by outflank-mailman (input) for mailman id 374937; Tue, 26 Jul 2022 03:23:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAU-0003P0-SU for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:34 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53c69a50-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:33 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B00DB5C00D2; Mon, 25 Jul 2022 23:23:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 25 Jul 2022 23:23:32 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:31 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53c69a50-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805812; x=1658892212; bh=3+Myjyd1Ql jUjc3rIyJbwALSLpFyz/2kcKDHAc8UTjU=; b=jUaEBIvUae6flJleBjXEEGUdFe JAgTIwisnWqcQvdsZCoYNpqROwJ6mMBWsWMe07I2VpM3XHBPiUxUIJya53PcsT3s dEFEjZccdU5uplmijE33r65KMhJmh85GbQ7PsF6DW+oTu9BKCka0i2BmSb3z/WRC TztkyKNO15+yxHt+btr7BlQMjhaaltCO6VuxDo/Tf3Dro6cJsBVib7Gpx+ZS/0ev 6HMYyBjtnhhvFCUAUFBzbw5oTYn9uX+iKsasLWIvLMcKGCfecE8iTSi/PEdapsT1 2j+acUrTBpVRrNBdn7KuXUniK0XxIZcMyx17L3ST1PGQH0ZmZqjh8D2M+bAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805812; x= 1658892212; bh=3+Myjyd1QljUjc3rIyJbwALSLpFyz/2kcKDHAc8UTjU=; b=z 2RPsAdyciG6IBHebVkU63AHlkXtawGFyZoTcWMYv8EJGOuL3THT343Ytxu1zA17s geCjuVORzo0Fg65LckTxdbsyMkax3NEwyNPxwZOn1ff9E7lnSN/8X6xhJPTE2qZD AN9UIIuamYi++MKNOgNrJ0rgTlJ5fMFCW++ViHRPlWWFhHq5ptBymwDJmhBcC0Wt MY8e7TeqieqQArEVxbp56FeRcbe81DGyn+Ht9/pYAv2e0yHc5FmTDBSDKPmkHbd9 YTh7TZ1PLBH9orceO6vcyzWW/fEToARRhaJjZLmFHm8kX+qBUz6LZqw/9wa4PLlp XsJ1G4FgXrsfMI2mWI/8g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 03/10] drivers/char: add support for selecting specific xhci Date: Tue, 26 Jul 2022 05:23:08 +0200 Message-Id: <97e54ccf5f9a21cf1226a1e9de6aae8dc09d2406.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805843128100006 Handle parameters similar to dbgp=3Dehci. Implement this by not resettting dbc->sbdf again in dbc_init_xhc(), but using a value found there if non-zero. Additionally, add xue->xhc_num to select n-th controller. Signed-off-by: Marek Marczykowski-G=C3=B3recki Reviewed-by: Jan Beulich --- Changes in v3: - adjust for xhci-dbc rename - drop redundant check in parsing dbgp=3D option Changes in v2: - unsigned int xhc_num - code style --- docs/misc/xen-command-line.pandoc | 2 +- xen/drivers/char/xhci-dbc.c | 54 ++++++++++++++++++++++++-------- 2 files changed, 43 insertions(+), 13 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line= .pandoc index f936283cd187..d594bd5c7436 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -721,7 +721,7 @@ Available alternatives, with their meaning, are: =20 ### dbgp > `=3D ehci[ | @pci:. ]` -> `=3D xhci` +> `=3D xhci[ | @pci:. ]` =20 Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 53c39eedd4a6..11026d3b71f0 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -243,6 +243,7 @@ struct dbc { void __iomem *xhc_mmio; =20 bool open; + unsigned int xhc_num; /* look for n-th xhc */ }; =20 static void *dbc_sys_map_xhc(uint64_t phys, size_t size) @@ -274,24 +275,37 @@ static bool __init dbc_init_xhc(struct dbc *dbc) uint16_t cmd; size_t xhc_mmio_size; =20 - /* - * Search PCI bus 0 for the xHC. All the host controllers supported so= far - * are part of the chipset and are on bus 0. - */ - for ( devfn =3D 0; devfn < 256; devfn++ ) + if ( dbc->sbdf.sbdf =3D=3D 0 ) { - pci_sbdf_t sbdf =3D PCI_SBDF(0, 0, devfn); - uint8_t hdr =3D pci_conf_read8(sbdf, PCI_HEADER_TYPE); - - if ( hdr =3D=3D 0 || hdr =3D=3D 0x80 ) + /* + * Search PCI bus 0 for the xHC. All the host controllers supporte= d so + * far are part of the chipset and are on bus 0. + */ + for ( devfn =3D 0; devfn < 256; devfn++ ) { - if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) =3D=3D D= BC_XHC_CLASSC ) + pci_sbdf_t sbdf =3D PCI_SBDF(0, 0, devfn); + uint8_t hdr =3D pci_conf_read8(sbdf, PCI_HEADER_TYPE); + + if ( hdr =3D=3D 0 || hdr =3D=3D 0x80 ) { - dbc->sbdf =3D sbdf; - break; + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) =3D= =3D + DBC_XHC_CLASSC ) + { + if ( dbc->xhc_num-- ) + continue; + dbc->sbdf =3D sbdf; + break; + } } } } + else + { + /* Verify if selected device is really xHC */ + if ( (pci_conf_read32(dbc->sbdf, PCI_CLASS_REVISION) >> 8) !=3D + DBC_XHC_CLASSC ) + dbc->sbdf.sbdf =3D 0; + } =20 if ( !dbc->sbdf.sbdf ) { @@ -1047,12 +1061,28 @@ void __init xhci_dbc_uart_init(void) { struct dbc_uart *uart =3D &dbc_uart; struct dbc *dbc =3D &uart->dbc; + const char *e; =20 if ( strncmp(opt_dbgp, "xhci", 4) ) return; =20 memset(dbc, 0, sizeof(*dbc)); =20 + if ( isdigit(opt_dbgp[4]) ) + { + dbc->xhc_num =3D simple_strtoul(opt_dbgp + 4, &e, 10); + } + else if ( strncmp(opt_dbgp + 4, "@pci", 4) =3D=3D 0 ) + { + unsigned int bus, slot, func; + + e =3D parse_pci(opt_dbgp + 8, NULL, &bus, &slot, &func); + if ( !e || *e ) + return; + + dbc->sbdf =3D PCI_SBDF(0, bus, slot, func); + } + dbc->dbc_ctx =3D &ctx; dbc->dbc_erst =3D &erst; dbc->dbc_ering.trb =3D evt_trb; --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658805841853173.3244960555902; Mon, 25 Jul 2022 20:24:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374938.607187 (Exim 4.92) (envelope-from ) id 1oGBAX-0004Hp-5P; Tue, 26 Jul 2022 03:23:37 +0000 Received: by outflank-mailman (output) from mailman id 374938.607187; Tue, 26 Jul 2022 03:23:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAW-0004Fq-TN; Tue, 26 Jul 2022 03:23:36 +0000 Received: by outflank-mailman (input) for mailman id 374938; Tue, 26 Jul 2022 03:23:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAW-000459-BF for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:36 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54a90892-0c92-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 05:23:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 38A6F5C00C4; Mon, 25 Jul 2022 23:23:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 25 Jul 2022 23:23:34 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:32 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54a90892-0c92-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805814; x=1658892214; bh=hSsEZHy6kJ LcmqWZuPa/umq2lr+G/hdZU1gW2QDjIRI=; b=hIFn0DIgOSL3dauKE5PXTJegSt GlpZO47OaT7GxSTdX0cGtkv2FrVfxKey4WVaAAOY4bGZ39yt4fH1TLVjRkKXNnCx XoMAhkufI4fVrw6vdwug8YOoWm/cuVdKLHtN1iHHqW9MHr6t8CeRYH9nVoMfd6s8 V7TiIS8GepYCkUUQLA+voybRNnIBcAQuy46XpPh9UA4HsJjmeJpiT8eu10PO+FeP 6n9OtNVi2N3FcgY42baDW0rWAXngKInIF2Z/eJDpnRQS9azDFC7z2L5DaQNFyIa/ sRqHJWx7RiqKZt8tJdUY7lSm8ujXgzZJMf2mocgzZLZAImRoKDUkFN5+r9+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805814; x= 1658892214; bh=hSsEZHy6kJLcmqWZuPa/umq2lr+G/hdZU1gW2QDjIRI=; b=O rxHoquYpjEzNSsjsYn2n1ZBx9j6TSD60CNrjkV9STnEzNXC98XoDNZHvyNmO2TB2 +dQWEg57TvAtL4ughDcqq3R/EOnK8ZNSPZcV9l42T5bbl9kpx9PjuiS9CDn8fbzE u+NDcA2nZgoWJOAhf6+oZL2T0n4FeGx9rfK1ULygvPrOUPOF9P39D2/zYNuaA0W1 FfdtVDSYDZ/+rf2OzEkLaXRp3k/aXN5xyGuLY/2UcqBgxjZs1neE0lTlWBMP1VBm FoP1zBXGihE5b0mKtbAii0zaNXzcUXw4Ob01p0q3xzvhyVtN/pxGIhn4tDZhjFD6 MRDRbGGY5Pmgpf3C3o2Nw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 04/10] console: support multiple serial console simultaneously Date: Tue, 26 Jul 2022 05:23:09 +0200 Message-Id: <14411aa674b61d22d9626a3455206454793b6a37.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805843199100011 Previously only one serial console was supported at the same time. Using console=3Dcom1,dbgp,vga silently ignored all but last serial console (in this case: only dbgp and vga were active). Fix this by storing not a single sercon_handle, but an array of them, up to MAX_SERCONS entries. The value of MAX_SERCONS can be chosen in kconfig, the default (4) is arbitrary, inspired by the number of SERHND_IDX values. Make console_steal() aware of multiple consoles too. It can now either steal output from specific console (for gdbstub), or from all of them at once (for console suspend). Signed-off-by: Marek Marczykowski-G=C3=B3recki --- Changes in v3: - adjust console_steal() for multiple consoles too - add MAX_SERCONS to kconfig - add warning about sync_console impact - add warning if too many consoles are configured - log issue with PCI spec parsing --- docs/misc/xen-command-line.pandoc | 4 +- xen/drivers/char/Kconfig | 11 ++++- xen/drivers/char/console.c | 97 ++++++++++++++++++++++++-------- xen/drivers/char/xhci-dbc.c | 6 +- xen/include/xen/serial.h | 1 +- 5 files changed, 95 insertions(+), 24 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line= .pandoc index d594bd5c7436..e53efdb324b3 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -433,6 +433,9 @@ only available when used together with `pv-in-pvh`. `none` indicates that Xen should not use a console. This option only makes sense on its own. =20 +Specifying more than one serial console will increase console latency, +especially when `sync_console` option is used. + ### console_timestamps > `=3D none | date | datems | boot | raw` =20 @@ -2372,6 +2375,7 @@ vulnerabilities. =20 Flag to force synchronous console output. Useful for debugging, but not suitable for production environments due to incurred overhead. +If multiple consoles are configured, the incurred overhead is even bigger. =20 ### tboot (x86) > `=3D 0x` diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index 06350c387371..1010436d245c 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -85,6 +85,17 @@ config SERIAL_TX_BUFSIZE =20 Default value is 16384 (16kiB). =20 +config MAX_SERCONS + int "Maximum number of serial consoles active at once" + default 4 + help + Controls how many serial consoles can be active at once. Configuring= more + using `console=3D` parameter will be ignored. + When multiple consoles are configured, overhead of `sync_console` op= tion + is even bigger. + + Default value is 4. + config XHCI bool "XHCI DbC UART driver" depends on X86 diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index f9937c5134c0..2ffc919445c6 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -113,7 +113,9 @@ static char *__read_mostly conring =3D _conring; static uint32_t __read_mostly conring_size =3D _CONRING_SIZE; static uint32_t conringc, conringp; =20 -static int __read_mostly sercon_handle =3D -1; +#define MAX_SERCONS CONFIG_MAX_SERCONS +static int __read_mostly sercon_handle[MAX_SERCONS]; +static int __read_mostly nr_sercon_handle =3D 0; =20 #ifdef CONFIG_X86 /* Tristate: 0 disabled, 1 user enabled, -1 default enabled */ @@ -393,32 +395,59 @@ long read_console_ring(struct xen_sysctl_readconsole = *op) static char serial_rx_ring[SERIAL_RX_SIZE]; static unsigned int serial_rx_cons, serial_rx_prod; =20 -static void (*serial_steal_fn)(const char *, size_t nr) =3D early_puts; +/* The last entry means "steal from all consoles" */ +static void (*serial_steal_fn[MAX_SERCONS+1])(const char *, size_t nr) =3D= { + [MAX_SERCONS] =3D early_puts, +}; =20 +/* + * Redirect console *handle* output to *fn*. Use SERHND_STEAL_ALL as *hand= le* to + * redirect all the consoles.=20 + */ int console_steal(int handle, void (*fn)(const char *, size_t nr)) { - if ( (handle =3D=3D -1) || (handle !=3D sercon_handle) ) - return 0; + int i; + + if ( handle =3D=3D -1 ) + return -ENOENT; + if ( serial_steal_fn[MAX_SERCONS] !=3D NULL ) + return -EBUSY; + if ( handle =3D=3D SERHND_STEAL_ALL ) + { + serial_steal_fn[MAX_SERCONS] =3D fn; + return MAX_SERCONS; + } + for ( i =3D 0; i < nr_sercon_handle; i++ ) + if ( handle =3D=3D sercon_handle[i] ) + break; + if ( i =3D=3D nr_sercon_handle ) + return -ENOENT; =20 - if ( serial_steal_fn !=3D NULL ) + if ( serial_steal_fn[i] !=3D NULL ) return -EBUSY; =20 - serial_steal_fn =3D fn; - return 1; + serial_steal_fn[i] =3D fn; + return i; } =20 void console_giveback(int id) { - if ( id =3D=3D 1 ) - serial_steal_fn =3D NULL; + if ( id >=3D 0 && id <=3D MAX_SERCONS ) + serial_steal_fn[id] =3D NULL; } =20 void console_serial_puts(const char *s, size_t nr) { - if ( serial_steal_fn !=3D NULL ) - serial_steal_fn(s, nr); + int i; + + if ( serial_steal_fn[MAX_SERCONS] !=3D NULL ) + serial_steal_fn[MAX_SERCONS](s, nr); else - serial_puts(sercon_handle, s, nr); + for ( i =3D 0; i < nr_sercon_handle; i++ ) + if ( serial_steal_fn[i] !=3D NULL ) + serial_steal_fn[i](s, nr); + else + serial_puts(sercon_handle[i], s, nr); =20 /* Copy all serial output into PV console */ pv_console_puts(s, nr); @@ -956,7 +985,7 @@ void guest_printk(const struct domain *d, const char *f= mt, ...) void __init console_init_preirq(void) { char *p; - int sh; + int sh, i; =20 serial_init_preirq(); =20 @@ -977,8 +1006,12 @@ void __init console_init_preirq(void) continue; else if ( (sh =3D serial_parse_handle(p)) >=3D 0 ) { - sercon_handle =3D sh; - serial_steal_fn =3D NULL; + if ( nr_sercon_handle < MAX_SERCONS ) + sercon_handle[nr_sercon_handle++] =3D sh; + else + printk("Too many consoles (max %d), ignoring '%s'\n", + MAX_SERCONS, p); + serial_steal_fn[MAX_SERCONS] =3D NULL; } else { @@ -996,7 +1029,8 @@ void __init console_init_preirq(void) opt_console_xen =3D 0; #endif =20 - serial_set_rx_handler(sercon_handle, serial_rx); + for ( i =3D 0; i < nr_sercon_handle; i++ ) + serial_set_rx_handler(sercon_handle[i], serial_rx); pv_console_set_rx_handler(serial_rx); =20 /* HELLO WORLD --- start-of-day banner text. */ @@ -1014,7 +1048,8 @@ void __init console_init_preirq(void) =20 if ( opt_sync_console ) { - serial_start_sync(sercon_handle); + for ( i =3D 0; i < nr_sercon_handle; i++ ) + serial_start_sync(sercon_handle[i]); add_taint(TAINT_SYNC_CONSOLE); printk("Console output is synchronous.\n"); warning_add(warning_sync_console); @@ -1121,13 +1156,19 @@ int __init console_has(const char *device) =20 void console_start_log_everything(void) { - serial_start_log_everything(sercon_handle); + int i; + + for ( i =3D 0; i < nr_sercon_handle; i++ ) + serial_start_log_everything(sercon_handle[i]); atomic_inc(&print_everything); } =20 void console_end_log_everything(void) { - serial_end_log_everything(sercon_handle); + int i; + + for ( i =3D 0; i < nr_sercon_handle; i++ ) + serial_end_log_everything(sercon_handle[i]); atomic_dec(&print_everything); } =20 @@ -1149,23 +1190,32 @@ void console_unlock_recursive_irqrestore(unsigned l= ong flags) =20 void console_force_unlock(void) { + int i; + watchdog_disable(); spin_debug_disable(); spin_lock_init(&console_lock); - serial_force_unlock(sercon_handle); + for ( i =3D 0 ; i < nr_sercon_handle ; i++ ) + serial_force_unlock(sercon_handle[i]); console_locks_busted =3D 1; console_start_sync(); } =20 void console_start_sync(void) { + int i; + atomic_inc(&print_everything); - serial_start_sync(sercon_handle); + for ( i =3D 0 ; i < nr_sercon_handle ; i++ ) + serial_start_sync(sercon_handle[i]); } =20 void console_end_sync(void) { - serial_end_sync(sercon_handle); + int i; + + for ( i =3D 0; i < nr_sercon_handle; i++ ) + serial_end_sync(sercon_handle[i]); atomic_dec(&print_everything); } =20 @@ -1291,7 +1341,8 @@ static int suspend_steal_id; =20 int console_suspend(void) { - suspend_steal_id =3D console_steal(sercon_handle, suspend_steal_fn); + if ( nr_sercon_handle ) + suspend_steal_id =3D console_steal(SERHND_STEAL_ALL, suspend_steal= _fn); serial_suspend(); return 0; } diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 11026d3b71f0..14a2d3eb0ee2 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -1078,8 +1078,12 @@ void __init xhci_dbc_uart_init(void) =20 e =3D parse_pci(opt_dbgp + 8, NULL, &bus, &slot, &func); if ( !e || *e ) + { + printk(XENLOG_ERR + "Invalid dbgp=3D PCI device spec: '%s'\n", + opt_dbgp); return; - + } dbc->sbdf =3D PCI_SBDF(0, bus, slot, func); } =20 diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 181e026967bc..c3bca000e238 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -99,6 +99,7 @@ struct uart_driver { #define SERHND_HI (1<<2) /* Mux/demux each transferred char by MSB. = */ #define SERHND_LO (1<<3) /* Ditto, except that the MSB is cleared. = */ #define SERHND_COOKED (1<<4) /* Newline/carriage-return translation? = */ +#define SERHND_STEAL_ALL 0xff /* Synthetic handle used in console_steal()= */ =20 /* Three-stage initialisation (before/during/after IRQ-subsystem setup). */ void serial_init_preirq(void); --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658805840514322.1368768975992; Mon, 25 Jul 2022 20:24:00 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374939.607202 (Exim 4.92) (envelope-from ) id 1oGBAY-0004iO-Kr; Tue, 26 Jul 2022 03:23:38 +0000 Received: by outflank-mailman (output) from mailman id 374939.607202; Tue, 26 Jul 2022 03:23:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAY-0004hn-Ct; Tue, 26 Jul 2022 03:23:38 +0000 Received: by outflank-mailman (input) for mailman id 374939; Tue, 26 Jul 2022 03:23:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAX-0003P0-3o for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:37 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 556b9709-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 757E45C00CC; Mon, 25 Jul 2022 23:23:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 25 Jul 2022 23:23:35 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:34 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 556b9709-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805815; x=1658892215; bh=r/M8YO8NxS 0KXBQpVOXd9NU+IPTWyvROd1xBgr9fbs4=; b=vXZrlGKoAaUGT1udv1cL6dhpyg wCRG4ZpDq9IXG21Z6avFkoAdI66wWzgq3BO6INFDP882IlG/BHY3XM+qiTAqNaLN bJOODnXTsmVrtoJgBNsgywuJDSX+QZcCYcYygy7mUP0zzIyxVIL7P6l+7+epJfM7 eh+EjlsfGDUOTgGGSG+FFPkCv33FzmLXrvcElFXPzlAkF4/1PAU4+WgP30D20uOj fR9+yZRDzaW3JVAiW5IxrVlKT0R7+vtCSwYQzYtDOXiP766jNgzVffmwRQNJZSZy 3E3Vynw88a+IjzIbo1A3/dO5yZKjoLu8DatbYTKjU4/KFAR++S9BgSrRYkHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805815; x= 1658892215; bh=r/M8YO8NxS0KXBQpVOXd9NU+IPTWyvROd1xBgr9fbs4=; b=S n5ZcBWVs6JXO2qrBfnsQe5Fx4mMs60ftfsPf8MiNJp74+jEiyT824eDwhb2U8U2o fPSO1VKu0QGCIzIYSubMa5831nCxv7X7jGQz6lk9seQl6XR/yGCUqZvLAAeNxR5j GXq2V26Sls4wMtPHkZgusNwMHvyH1DRFy/zF8aTLfTxJUNigdqR3DKoFytvAH6O6 UxwdvDD0LtBlW9RAyzaGb7kSAezM1jxZwQRFdkNnFwaD1h2NOY+eC0Mya+drY3tf hH8SbOFTQ2U6QDi1gzL4+/Yq+gOGt84xZ4IYYrFbPNXw0EM9FkPKzFzTD0m7ymoF Kzgy59Y7vJ0OaOVICXtnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 05/10] IOMMU: add common API for device reserved memory Date: Tue, 26 Jul 2022 05:23:10 +0200 Message-Id: <6a99f9b99b419a20e895d54db2e345c80270248c.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805841155100002 Add API similar to rmrr=3D and ivmd=3D arguments, but in a common code. This will allow drivers to register reserved memory regardless of the IOMMU vendor. The direct reason for this API is xhci-dbc console driver (aka xue), that needs to use DMA. But future change may unify command line arguments for user-supplied reserved memory, and it may be useful for other drivers in the future too. This commit just introduces an API, subsequent patches will plug it in appropriate places. The reserved memory ranges needs to be saved locally, because at the point when they are collected, Xen doesn't know yet which IOMMU driver will be used. Signed-off-by: Marek Marczykowski-G=C3=B3recki --- Changes in v3: - adjust code style --- xen/drivers/passthrough/iommu.c | 45 ++++++++++++++++++++++++++++++++++- xen/include/xen/iommu.h | 13 ++++++++++- 2 files changed, 58 insertions(+) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iomm= u.c index 77f64e61748d..74efd865ab69 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -651,6 +651,51 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_= feature feature) return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features= ); } =20 +#define MAX_EXTRA_RESERVED_RANGES 20 +struct extra_reserved_range { + unsigned long start; + unsigned long nr; + uint32_t sbdf; +}; +static unsigned int __initdata nr_extra_reserved_ranges; +static struct extra_reserved_range __initdata + extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES]; + +int iommu_add_extra_reserved_device_memory(unsigned long start, + unsigned long nr, + uint32_t sbdf) +{ + unsigned int idx; + + if ( nr_extra_reserved_ranges >=3D MAX_EXTRA_RESERVED_RANGES ) + return -ENOMEM; + + idx =3D nr_extra_reserved_ranges++; + extra_reserved_ranges[idx].start =3D start; + extra_reserved_ranges[idx].nr =3D nr; + extra_reserved_ranges[idx].sbdf =3D sbdf; + + return 0; +} + +int iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, void *ctxt) +{ + unsigned int idx; + int ret; + + for ( idx =3D 0; idx < nr_extra_reserved_ranges; idx++ ) + { + ret =3D func(extra_reserved_ranges[idx].start, + extra_reserved_ranges[idx].nr, + extra_reserved_ranges[idx].sbdf, + ctxt); + if ( ret < 0 ) + return ret; + } + + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 79529adf1fa5..aa87c3fd9ebc 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -297,6 +297,19 @@ struct iommu_ops { #endif }; =20 +/* + * To be called by Xen internally, to register extra RMRR/IVMD ranges. + * Needs to be called before IOMMU initialization. + */ +extern int iommu_add_extra_reserved_device_memory(unsigned long start, + unsigned long nr, + uint32_t sbdf); +/* + * To be called by specific IOMMU driver during initialization, + * to fetch ranges registered with iommu_add_extra_reserved_device_memory(= ). + */ +extern int iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, void= *ctxt); + #include =20 #ifndef iommu_call --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658805844678988.4597897117877; Mon, 25 Jul 2022 20:24:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374940.607213 (Exim 4.92) (envelope-from ) id 1oGBAZ-000538-UU; Tue, 26 Jul 2022 03:23:39 +0000 Received: by outflank-mailman (output) from mailman id 374940.607213; Tue, 26 Jul 2022 03:23:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAZ-00052T-OM; Tue, 26 Jul 2022 03:23:39 +0000 Received: by outflank-mailman (input) for mailman id 374940; Tue, 26 Jul 2022 03:23:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAY-000459-78 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:38 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56027e2f-0c92-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 05:23:37 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 794525C00D1; Mon, 25 Jul 2022 23:23:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:36 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:35 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56027e2f-0c92-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805816; x=1658892216; bh=CFew235jgq 1Bpcgaw8qOFpTlwBPLlNuYoSmc12fF7k4=; b=WRQxw3OBitWNGCYieQr8QttJD9 sPQ2lLMqsM/Nh/JLOEvFCaxTO2BhR3ADv/pSQCO8UgBZT0Z/Suo8H7yqROmh/fgW mE1b0VRHSTBjkUtsfl9OWIZCc5ZrBHkEqwpRsB19c5v9z+kGiMKwayF0Uiclb0Jp ukVWO9+avzXAWHKbl4ANpJgxWAfbFu0Wo+Y2o0+0rWUErfYw0MRIgWoduEJV0tl2 zCjc+6Ovb0zgJHQB6VBZ0XcDd9XaEY2ZFW1eUjPfGA+Ieay0wlukrMirnVN/84ED P7fXE5uswll5D+wMXxKEy+x+e162wk2wy8HzIQI8bFi0rFzH5ydnr3GYH+Ew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805816; x= 1658892216; bh=CFew235jgq1Bpcgaw8qOFpTlwBPLlNuYoSmc12fF7k4=; b=1 S4K2OoRNLnrAkd15WJgBuqPqoAzm/RQTVblxpSrLXXZGPdGo7tYulxJOdDVLZewB +htgDQXvNgtsmA8dEMj+gvh1EP9Arnpc5kgATXB+0cYYRkvqTCgWv7X7ZNvr2UoH If+PTitycJ9FMqKVSUddbjCOA5XzBO1cUGnVLKLAtnvOP3iU3opzW3ttZKEmhjhW 7kMP6ZzP3ie2PuyWRmXHPUwXiPX/jp8hvoQgsUhLuGSTYemqT+iz7jsxDmsycwh0 Ii48Kt/wqUIoNZtfrMY1ytN6Qo2OMOieP7tiAZ+8u+AJkjTrfPdfyrJbSpLQ6K5P jebwbx02OXfM35jIQbNdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Kevin Tian Subject: [PATCH v3 06/10] IOMMU/VT-d: wire common device reserved memory API Date: Tue, 26 Jul 2022 05:23:11 +0200 Message-Id: <0670dc3600aac44532d73fced60b457848ec2ceb.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805845142100013 Re-use rmrr=3D parameter handling code to handle common device reserved memory. Signed-off-by: Marek Marczykowski-G=C3=B3recki --- Changes in v3: - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR --- xen/drivers/passthrough/vtd/dmar.c | 201 +++++++++++++++++------------- 1 file changed, 119 insertions(+), 82 deletions(-) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/v= td/dmar.c index 367304c8739c..3df5f6b69719 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -861,111 +861,139 @@ static struct user_rmrr __initdata user_rmrrs[MAX_U= SER_RMRR]; =20 /* Macro for RMRR inclusive range formatting. */ #define ERMRRU_FMT "[%lx-%lx]" -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn +#define ERMRRU_ARG base_pfn, end_pfn + +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf); =20 static int __init add_user_rmrr(void) { + unsigned int i; + int ret; + + for ( i =3D 0; i < nr_rmrr; i++ ) + { + ret =3D add_one_user_rmrr(user_rmrrs[i].base_pfn, + user_rmrrs[i].end_pfn, + user_rmrrs[i].dev_count, + user_rmrrs[i].sbdf); + if ( ret < 0 ) + return ret; + } + return 0; +} + +/* Returns 1 on success, 0 when ignoring and < 0 on error. */ +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf) +{ struct acpi_rmrr_unit *rmrr, *rmrru; - unsigned int idx, seg, i; - unsigned long base, end; + unsigned int idx, seg; + unsigned long base_iter; bool overlap; =20 - for ( i =3D 0; i < nr_rmrr; i++ ) + if ( iommu_verbose ) + printk(XENLOG_DEBUG VTDPREFIX + "Adding RMRR for %d device ([0]: %#x) range "ERMRRU_FMT"\n", + dev_count, sbdf[0], ERMRRU_ARG); + + if ( base_pfn > end_pfn ) { - base =3D user_rmrrs[i].base_pfn; - end =3D user_rmrrs[i].end_pfn; + printk(XENLOG_ERR VTDPREFIX + "Invalid RMRR Range "ERMRRU_FMT"\n", + ERMRRU_ARG); + return 0; + } =20 - if ( base > end ) + overlap =3D false; + list_for_each_entry(rmrru, &acpi_rmrr_units, list) + { + if ( pfn_to_paddr(base_pfn) <=3D rmrru->end_address && + rmrru->base_address <=3D pfn_to_paddr(end_pfn) ) { printk(XENLOG_ERR VTDPREFIX - "Invalid RMRR Range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", + ERMRRU_ARG, + paddr_to_pfn(rmrru->base_address), + paddr_to_pfn(rmrru->end_address)); + overlap =3D true; + break; } + } + /* Don't add overlapping RMRR. */ + if ( overlap ) + return 0; =20 - if ( (end - base) >=3D MAX_USER_RMRR_PAGES ) + base_iter =3D base_pfn; + do + { + if ( !mfn_valid(_mfn(base_iter)) ) { printk(XENLOG_ERR VTDPREFIX - "RMRR range "ERMRRU_FMT" exceeds "\ - __stringify(MAX_USER_RMRR_PAGES)" pages\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Invalid pfn in RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + break; } + } while ( base_iter++ < end_pfn ); =20 - overlap =3D false; - list_for_each_entry(rmrru, &acpi_rmrr_units, list) - { - if ( pfn_to_paddr(base) <=3D rmrru->end_address && - rmrru->base_address <=3D pfn_to_paddr(end) ) - { - printk(XENLOG_ERR VTDPREFIX - "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", - ERMRRU_ARG(user_rmrrs[i]), - paddr_to_pfn(rmrru->base_address), - paddr_to_pfn(rmrru->end_address)); - overlap =3D true; - break; - } - } - /* Don't add overlapping RMRR. */ - if ( overlap ) - continue; + /* Invalid pfn in range as the loop ended before end_pfn was reached. = */ + if ( base_iter <=3D end_pfn ) + return 0; =20 - do - { - if ( !mfn_valid(_mfn(base)) ) - { - printk(XENLOG_ERR VTDPREFIX - "Invalid pfn in RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - break; - } - } while ( base++ < end ); + rmrr =3D xzalloc(struct acpi_rmrr_unit); + if ( !rmrr ) + return -ENOMEM; =20 - /* Invalid pfn in range as the loop ended before end_pfn was reach= ed. */ - if ( base <=3D end ) - continue; + rmrr->scope.devices =3D xmalloc_array(u16, dev_count); + if ( !rmrr->scope.devices ) + { + xfree(rmrr); + return -ENOMEM; + } =20 - rmrr =3D xzalloc(struct acpi_rmrr_unit); - if ( !rmrr ) - return -ENOMEM; + seg =3D 0; + for ( idx =3D 0; idx < dev_count; idx++ ) + { + rmrr->scope.devices[idx] =3D sbdf[idx]; + seg |=3D PCI_SEG(sbdf[idx]); + } + if ( seg !=3D PCI_SEG(sbdf[0]) ) + { + printk(XENLOG_ERR VTDPREFIX + "Segments are not equal for RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + scope_devices_free(&rmrr->scope); + xfree(rmrr); + return 0; + } =20 - rmrr->scope.devices =3D xmalloc_array(u16, user_rmrrs[i].dev_count= ); - if ( !rmrr->scope.devices ) - { - xfree(rmrr); - return -ENOMEM; - } + rmrr->segment =3D seg; + rmrr->base_address =3D pfn_to_paddr(base_pfn); + /* Align the end_address to the end of the page */ + rmrr->end_address =3D pfn_to_paddr(end_pfn) | ~PAGE_MASK; + rmrr->scope.devices_cnt =3D dev_count; =20 - seg =3D 0; - for ( idx =3D 0; idx < user_rmrrs[i].dev_count; idx++ ) - { - rmrr->scope.devices[idx] =3D user_rmrrs[i].sbdf[idx]; - seg |=3D PCI_SEG(user_rmrrs[i].sbdf[idx]); - } - if ( seg !=3D PCI_SEG(user_rmrrs[i].sbdf[0]) ) - { - printk(XENLOG_ERR VTDPREFIX - "Segments are not equal for RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - scope_devices_free(&rmrr->scope); - xfree(rmrr); - continue; - } + if ( register_one_rmrr(rmrr) ) + printk(XENLOG_ERR VTDPREFIX + "Could not register RMMR range "ERMRRU_FMT"\n", + ERMRRU_ARG); =20 - rmrr->segment =3D seg; - rmrr->base_address =3D pfn_to_paddr(user_rmrrs[i].base_pfn); - /* Align the end_address to the end of the page */ - rmrr->end_address =3D pfn_to_paddr(user_rmrrs[i].end_pfn) | ~PAGE_= MASK; - rmrr->scope.devices_cnt =3D user_rmrrs[i].dev_count; + return 1; +} =20 - if ( register_one_rmrr(rmrr) ) - printk(XENLOG_ERR VTDPREFIX - "Could not register RMMR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - } +static int __init cf_check add_one_extra_rmrr(xen_pfn_t start, xen_ulong_t= nr, u32 id, void *ctxt) +{ + u32 sbdf_array[] =3D { id }; + return add_one_user_rmrr(start, start+nr, 1, sbdf_array); +} =20 - return 0; +static int __init add_extra_rmrr(void) +{ + return iommu_get_extra_reserved_device_memory(add_one_extra_rmrr, NULL= ); } =20 #include @@ -1010,7 +1038,7 @@ int __init acpi_dmar_init(void) { iommu_init_ops =3D &intel_iommu_init_ops; =20 - return add_user_rmrr(); + return add_user_rmrr() || add_extra_rmrr(); } =20 return ret; @@ -1108,6 +1136,15 @@ static int __init cf_check parse_rmrr_param(const ch= ar *str) else end =3D start; =20 + if ( (end - start) >=3D MAX_USER_RMRR_PAGES ) + { + printk(XENLOG_ERR VTDPREFIX + "RMRR range "ERMRRU_FMT" exceeds "\ + __stringify(MAX_USER_RMRR_PAGES)" pages\n", + start, end); + return -E2BIG; + } + user_rmrrs[nr_rmrr].base_pfn =3D start; user_rmrrs[nr_rmrr].end_pfn =3D end; =20 --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 16588058426281015.7417592084043; Mon, 25 Jul 2022 20:24:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374941.607224 (Exim 4.92) (envelope-from ) id 1oGBAb-0005Mf-DO; Tue, 26 Jul 2022 03:23:41 +0000 Received: by outflank-mailman (output) from mailman id 374941.607224; Tue, 26 Jul 2022 03:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAb-0005MB-5J; Tue, 26 Jul 2022 03:23:41 +0000 Received: by outflank-mailman (input) for mailman id 374941; Tue, 26 Jul 2022 03:23:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAZ-0003P0-6Q for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:39 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56b4385f-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:38 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9AB7A5C00C4; Mon, 25 Jul 2022 23:23:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:37 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:36 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56b4385f-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805817; x=1658892217; bh=I6siKunDYx GQP0S8ZLOM5K5jIoXt/ZQrNSId/g+ijJY=; b=pElV3R8p4/TAoXjNMneelUeSOc WzEfG7cV2LTGPTH5QUdU3X2zdZnYZ7lpbS2L1kKeQDktgzMeMC0bFZ16UUniqLyt OcwIWGF+C6WlrsxSM558fb3eMAo04E6i/k9oX0Vg8CSLyUljlCJ/5kDMOIm844NP OFzJmg06dEgY3qUfYSjZzL6RLJkpQ/DtAgsJCKUBnzBHtHNhXkLayicD5fXNhhXE JVPMBCppJsRSJyaPrD9yk1+ykL9CuKh3WRkCo/zM0dyA73jOxZnrxU7XBVO29imL PDW8qfhRZQaHeceit3TqT+nqM8786vqrK20InMlzuVEj0xb3uqom3kNn9ATw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805817; x= 1658892217; bh=I6siKunDYxGQP0S8ZLOM5K5jIoXt/ZQrNSId/g+ijJY=; b=c nKHTVFf4cw8/jsjUXCGdJyxr3HQe1zCGUfYCoUnvjjdYpPLXwtxK+pU6M0s8rKoE do8tg3kb8w/nAz+XYNIChEwqwOPk6CTQ9I5UJt+5ztjFS9ESOVwq1d5bZexMqLdP gqSf9wSlFQFBvuxvG0Ye9O1l6BefvnrLnigrRY22IomrRpZkNlRss3IwLS26XHrm YEgkhLIdpoeFTG6b+A3YWaP1uabR8dW/EHn1+W3zNY8tJePb2rhJulea3dtAXgXa wquOpYjsM18IvQyFz0GuwIN668vaA+pS0AZIhMt3J9nfQFiTX+9apQ7VgXiHTFgy Es7zc8z/biUfSFY/Pd6+Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper Subject: [PATCH v3 07/10] IOMMU/AMD: wire common device reserved memory API Date: Tue, 26 Jul 2022 05:23:12 +0200 Message-Id: <68b7a172fcdad2495fb928e47f33ebe5bafcf953.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805843127100005 Register common device reserved memory similar to how ivmd=3D parameter is handled. Signed-off-by: Marek Marczykowski-G=C3=B3recki Acked-by: Jan Beulich --- Changes in v3: - use variable initializer - use pfn_to_paddr() --- xen/drivers/passthrough/amd/iommu_acpi.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthr= ough/amd/iommu_acpi.c index ac6835225bae..3b577c9b390c 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -1078,6 +1078,25 @@ static inline bool_t is_ivmd_block(u8 type) type =3D=3D ACPI_IVRS_TYPE_MEMORY_IOMMU); } =20 +static int __init cf_check add_one_extra_ivmd(unsigned long start, + unsigned long nr, + uint32_t id, void *ctxt) +{ + struct acpi_ivrs_memory ivmd =3D { + .header =3D { + .length =3D sizeof(ivmd), + .flags =3D ACPI_IVMD_UNITY | ACPI_IVMD_READ | ACPI_IVMD_WRITE, + .device_id =3D id, + .type =3D ACPI_IVRS_TYPE_MEMORY_ONE, + }, + }; + + ivmd.start_address =3D pfn_to_paddr(start); + ivmd.memory_length =3D pfn_to_paddr(nr); + + return parse_ivmd_block(&ivmd); +} + static int __init cf_check parse_ivrs_table(struct acpi_table_header *tabl= e) { const struct acpi_ivrs_header *ivrs_block; @@ -1121,6 +1140,8 @@ static int __init cf_check parse_ivrs_table(struct ac= pi_table_header *table) AMD_IOMMU_DEBUG("IVMD: %u command line provided entries\n", nr_ivm= d); for ( i =3D 0; !error && i < nr_ivmd; ++i ) error =3D parse_ivmd_block(user_ivmds + i); + if ( !error ) + error =3D iommu_get_extra_reserved_device_memory(add_one_extra_ivm= d, NULL); =20 /* Each IO-APIC must have been mentioned in the table. */ for ( apic =3D 0; !error && iommu_intremap && apic < nr_ioapics; ++api= c ) --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658805845460584.1153891072562; Mon, 25 Jul 2022 20:24:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374942.607235 (Exim 4.92) (envelope-from ) id 1oGBAc-0005hT-T4; Tue, 26 Jul 2022 03:23:42 +0000 Received: by outflank-mailman (output) from mailman id 374942.607235; Tue, 26 Jul 2022 03:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAc-0005gr-N1; Tue, 26 Jul 2022 03:23:42 +0000 Received: by outflank-mailman (input) for mailman id 374942; Tue, 26 Jul 2022 03:23:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAa-0003P0-SQ for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:40 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57a688ba-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:40 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 365C65C00C4; Mon, 25 Jul 2022 23:23:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:39 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:37 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57a688ba-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805819; x=1658892219; bh=3kwK8JcWbh LtjVsgq8YPYw4utn8O/FJoTtsnfytYm9A=; b=jY+5mrm5AnkRJ55gXNeVKy+7ya hVLHsSlfuBpNYRTCXGgH6Z+gnuxjKtFCZktjgc+b3bMDYVPWWiMRjQTALmhJkZGv wtEGGsoj/7j9Twk9ODa2AOx/alSMP2fMBgIr7GVmKszSTm9i2xy2AE/1Wsr1Et5e KZGlqy1zX69hipxq1Kle1k888w8ehv88MOkPzbRCsnqyO/JHy2uB8Ar9rEjo+hmI uu+Njn1uj1Ld8vRKQDGAMjexbJyeeyX1xGknPIlZ2Z0+nPTKWsRIb2HLqsjnvjAO H1PxcPxGl/kAALW5cpAOMTiNhcYsNP/ou/ROyzMEcYmNyZUE+VZ8FI5WZY3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805819; x= 1658892219; bh=3kwK8JcWbhLtjVsgq8YPYw4utn8O/FJoTtsnfytYm9A=; b=R XD6WVK0xA+m0sWGLNWwKOcwsKeTCIEkq2bHNbRPbs+cZkS/ppAjgsy3/LBR1qRU7 UuVpjmr7e8BXKmOFS7wj3ENtLKqjeCzn+JOCWhaCB7BgqBa7Ce5m8SDM7I61t9Yi 2/a4KBtEWlSlD2HZLh04CbzLhZyGTNs0o/g/mP/ePVEFRb8cyd38ucyWZzZQs2Bh tO0d415yWzzEtu9vMmFB7reLFai9R1xWxDZeH8Vc1Ta6k7W40rbH8xfqi8t7TgzH e+V7bUDNMlqeLlSkYlHY4qoBR4zdc3LbgAUWWy+P+8zA0WDC4OMxTcgRsxXNgXU/ ZCywdOcrl2hxbFAMlysCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 08/10] drivers/char: mark DMA buffers as reserved for the XHCI Date: Tue, 26 Jul 2022 05:23:13 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805847160100017 The important part is to include those buffers in IOMMU page table relevant for the USB controller. Otherwise, DbC will stop working as soon as IOMMU is enabled, regardless of to which domain device assigned (be it xen or dom0). If the device is passed through to dom0 or other domain (see later patches), that domain will effectively have access to those buffers too. It does give such domain yet another way to DoS the system (as is the case when having PCI device assigned already), but also possibly steal the console ring content. Thus, such domain should be a trusted one. In any case, prevent anything else being placed on those pages by adding artificial padding. Signed-off-by: Marek Marczykowski-G=C3=B3recki --- Changes in v3: - adjust for xhci-dbc rename - do not raise MAX_USER_RMRR_PAGES - adjust alignment of DMA buffers --- xen/drivers/char/xhci-dbc.c | 42 +++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 14a2d3eb0ee2..546231a75894 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -20,6 +20,7 @@ */ =20 #include +#include #include #include #include @@ -1046,13 +1047,20 @@ static struct uart_driver dbc_uart_driver =3D { .flush =3D dbc_uart_flush, }; =20 -static struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; -static struct xhci_trb out_trb[DBC_TRB_RING_CAP]; -static struct xhci_trb in_trb[DBC_TRB_RING_CAP]; -static struct xhci_erst_segment erst __aligned(64); -static struct xhci_dbc_ctx ctx __aligned(64); -static uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); -static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; +struct dbc_dma_bufs { + struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; + struct xhci_trb out_trb[DBC_TRB_RING_CAP]; + struct xhci_trb in_trb[DBC_TRB_RING_CAP]; + uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); + struct xhci_erst_segment erst __aligned(16); + struct xhci_dbc_ctx ctx __aligned(16); + struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; + /* + * Don't place anything else on this page - it will be + * DMA-reachable by the USB controller. + */ +}; +static struct dbc_dma_bufs dbc_dma_bufs __section(".bss.page_aligned"); static char __initdata opt_dbgp[30]; =20 string_param("dbgp", opt_dbgp); @@ -1087,16 +1095,22 @@ void __init xhci_dbc_uart_init(void) dbc->sbdf =3D PCI_SBDF(0, bus, slot, func); } =20 - dbc->dbc_ctx =3D &ctx; - dbc->dbc_erst =3D &erst; - dbc->dbc_ering.trb =3D evt_trb; - dbc->dbc_oring.trb =3D out_trb; - dbc->dbc_iring.trb =3D in_trb; - dbc->dbc_owork.buf =3D out_wrk_buf; - dbc->dbc_str =3D str_buf; + dbc->dbc_ctx =3D &dbc_dma_bufs.ctx; + dbc->dbc_erst =3D &dbc_dma_bufs.erst; + dbc->dbc_ering.trb =3D dbc_dma_bufs.evt_trb; + dbc->dbc_oring.trb =3D dbc_dma_bufs.out_trb; + dbc->dbc_iring.trb =3D dbc_dma_bufs.in_trb; + dbc->dbc_owork.buf =3D dbc_dma_bufs.out_wrk_buf; + dbc->dbc_str =3D dbc_dma_bufs.str_buf; =20 if ( dbc_open(dbc) ) + { + iommu_add_extra_reserved_device_memory( + PFN_DOWN(virt_to_maddr(&dbc_dma_bufs)), + PFN_UP(sizeof(dbc_dma_bufs)), + uart->dbc.sbdf.sbdf); serial_register_uart(SERHND_DBGP, &dbc_uart_driver, &dbc_uart); + } } =20 #ifdef DBC_DEBUG --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658805844390963.9537356501567; Mon, 25 Jul 2022 20:24:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.374943.607245 (Exim 4.92) (envelope-from ) id 1oGBAe-00061z-RM; Tue, 26 Jul 2022 03:23:44 +0000 Received: by outflank-mailman (output) from mailman id 374943.607245; Tue, 26 Jul 2022 03:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAe-00061K-Dc; Tue, 26 Jul 2022 03:23:44 +0000 Received: by outflank-mailman (input) for mailman id 374943; Tue, 26 Jul 2022 03:23:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAc-0003P0-O2 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:42 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 589110a6-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:41 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B49FD5C0196; Mon, 25 Jul 2022 23:23:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 25 Jul 2022 23:23:40 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:39 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 589110a6-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805820; x=1658892220; bh=JtMaNlSkIU jNbemR38QZSlvj6PVIS1fPR5IHNRRgKE0=; b=e8/MkaZB3yB2Z08i7UAYEqex/T /Fhelk6WSsBSpD8S09l5kVyNZwv2yQF/AqSi3dX4RMOia41Fo5xzlw3oeJ4MHIR5 +KW8fiPjdlM5nS/yyw4JmuJWGmowNBQPrigsDpjqwF5WyeJ87X33bahdRpfpzSdz zPxY0h/lqUqGwsB8MnWP0/yfkRwiy4YQX1coJe8wMNT1IvKo1SLliyxn0ZrB+vWt mMoQgvWFRYvmvfwUp7RyMhQpPXf1p+ykPoO8nIzxz/MdAMDKb0gixlBC6Fxg3PVG AV8abe7lALeRyJHPDUCUi9NThFaBpgz8LmLs/rh00asgiHJ7I4+W+hs6jWOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805820; x= 1658892220; bh=JtMaNlSkIUjNbemR38QZSlvj6PVIS1fPR5IHNRRgKE0=; b=n Zko7ir08z3laZ3+yVu1VvBprnlVVNFJf+G9hCQmML83ZZaqItoBOXQdgKra2AwJV nNbcrg3DFJsV6uj/GG5KvLt4zVuWwvP3I/nUwQZrl3HpkqvgwcysL7uMwdlN0Lh9 4SFN8zJKw5mE9SshSxkomZlTiDfQ34cAMSUMRr/h3vZwemZWTosFtI06GwAIiolM qIipkW0hpcpPqr9/nwf/2INSuXWaEN6zAFHAjOo44BEKJki5pOPwYb2jZqDEISu5 zyRrRITzrp8UmRChk/NzXEQjPN+UTnkB8/AdhgmjR9gbrJs503YhMREMwidBWOz1 qXA4V7A7OUII+ppfyL5kA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 09/10] drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC Date: Tue, 26 Jul 2022 05:23:14 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658805845171100014 That's possible, because the capability was designed specifically to allow separate driver handle it, in parallel to unmodified xhci driver (separate set of registers, pretending the port is "disconnected" for the main xhci driver etc). It works with Linux dom0, although requires an awful hack - re-enabling bus mastering behind dom0's backs. Linux driver does similar thing - see drivers/usb/early/xhci-dbc.c:xdbc_handle_events(). Add an option to allow/deny other domains to use the USB controller. By default, if XHCI console is enabled, Xen will take the whole controller for itself, using `dbgp=3Dxhci,share=3Dhwdom` or `=3Dany` allows other ports to be used by either only dom0 or any dom0 that get this PCI device assigned. In any case, to avoid Linux messing with the DbC, mark this MMIO area as read-only. Signed-off-by: Marek Marczykowski-G=C3=B3recki --- Changes in v3: - adjust for xhci-dbc rename - adjust for dbc_ensure_running() split - wrap long lines - add runtime option for sharing USB controller --- docs/misc/xen-command-line.pandoc | 12 ++- xen/drivers/char/xhci-dbc.c | 115 ++++++++++++++++++++++++++++--- 2 files changed, 118 insertions(+), 9 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line= .pandoc index e53efdb324b3..cc1e1989b17e 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -724,7 +724,7 @@ Available alternatives, with their meaning, are: =20 ### dbgp > `=3D ehci[ | @pci:. ]` -> `=3D xhci[ | @pci:. ]` +> `=3D xhci[ | @pci:. ][,share=3Dnone|hwdom|any= ]` =20 Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). @@ -732,6 +732,16 @@ over the PCI busses sequentially) or by PCI device (mu= st be on segment 0). Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (outp= ut only). XHCI driver will wait indefinitely for the debug host to connect - = make sure the cable is connected. +The `share` option for xhci controls who else can use the controller: +* `none`: use the controller exclusively for console, even hardware domain + (dom0) cannot use it; this is the default +* `hwdom`: hardware domain may use the controller too, ports not used for = debug + console will be available for normal devices +* `any`: the controller can be assigned to any domain; it is not safe to a= ssign + the controller to untrusted domain + +Choosing `share=3Dhwdom` or `share=3Dany` allows a domain to reset the con= troller, +which may cause small portion of the console output to be lost. =20 ### debug_stack_lines > `=3D ` diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 546231a75894..805b447f2300 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -228,6 +229,12 @@ struct dbc_work_ring { uint64_t dma; }; =20 +enum xhci_share { + XHCI_SHARE_NONE =3D 0, + XHCI_SHARE_HWDOM, + XHCI_SHARE_ANY +}; + struct dbc { struct dbc_reg __iomem *dbc_reg; struct xhci_dbc_ctx *dbc_ctx; @@ -244,6 +251,7 @@ struct dbc { void __iomem *xhc_mmio; =20 bool open; + enum xhci_share share; unsigned int xhc_num; /* look for n-th xhc */ }; =20 @@ -871,8 +879,9 @@ static bool __init dbc_open(struct dbc *dbc) } =20 /* - * Ensure DbC is still running, handle events, and possibly re-enable if c= able - * was re-plugged. Returns true if DbC is operational. + * Ensure DbC is still running, handle events, and possibly + * re-enable/re-configure if cable was re-plugged or controller was reset. + * Returns true if DbC is operational. */ static bool dbc_ensure_running(struct dbc *dbc) { @@ -880,6 +889,42 @@ static bool dbc_ensure_running(struct dbc *dbc) uint32_t ctrl; uint32_t cmd; =20 + if ( dbc->share !=3D XHCI_SHARE_NONE ) + { + /* + * Re-enable memory decoding and later bus mastering, if dom0 (or + * other) disabled it in the meantime. + */ + cmd =3D pci_conf_read16(dbc->sbdf, PCI_COMMAND); + if ( !(cmd & PCI_COMMAND_MEMORY) ) + { + cmd |=3D PCI_COMMAND_MEMORY; + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + } + + if ( dbc->open && !(readl(®->ctrl) & (1U << DBC_CTRL_DCE)) ) + { + if ( !dbc_init_dbc(dbc) ) + return false; + + dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_enable_dbc(dbc); + } + else + { + /* + * dbc_init_dbc() takes care about it, so check only if it was= n't + * called. + */ + cmd =3D pci_conf_read16(dbc->sbdf, PCI_COMMAND); + if ( !(cmd & PCI_COMMAND_MASTER) ) + { + cmd |=3D PCI_COMMAND_MASTER; + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + } + } + } + dbc_pop_events(dbc); =20 ctrl =3D readl(®->ctrl); @@ -1005,10 +1050,32 @@ static void __init cf_check dbc_uart_init_postirq(s= truct serial_port *port) init_timer(&uart->timer, dbc_uart_poll, port, 0); set_timer(&uart->timer, NOW() + MILLISECS(1)); =20 - if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) - printk(XENLOG_WARNING - "Failed to mark read-only %pp used for XHCI console\n", - &uart->dbc.sbdf); + switch ( uart->dbc.share ) + { + case XHCI_SHARE_NONE: + if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to mark read-only %pp used for XHCI console\n", + &uart->dbc.sbdf); + break; + case XHCI_SHARE_HWDOM: + if ( pci_hide_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to hide %pp used for XHCI console\n", + &uart->dbc.sbdf); + break; + case XHCI_SHARE_ANY: + /* Do not hide. */ + break; + } +#ifdef CONFIG_X86 + if ( rangeset_add_range(mmio_ro_ranges, + PFN_DOWN(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offse= t), + PFN_UP(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset + + sizeof(*uart->dbc.dbc_reg)) - 1) ) + printk(XENLOG_INFO + "Error while adding MMIO range of device to mmio_ro_ranges\= n"); +#endif } =20 static int cf_check dbc_uart_tx_ready(struct serial_port *port) @@ -1069,13 +1136,14 @@ void __init xhci_dbc_uart_init(void) { struct dbc_uart *uart =3D &dbc_uart; struct dbc *dbc =3D &uart->dbc; - const char *e; + const char *e, *opt; =20 if ( strncmp(opt_dbgp, "xhci", 4) ) return; =20 memset(dbc, 0, sizeof(*dbc)); =20 + e =3D &opt_dbgp[4]; if ( isdigit(opt_dbgp[4]) ) { dbc->xhc_num =3D simple_strtoul(opt_dbgp + 4, &e, 10); @@ -1085,7 +1153,7 @@ void __init xhci_dbc_uart_init(void) unsigned int bus, slot, func; =20 e =3D parse_pci(opt_dbgp + 8, NULL, &bus, &slot, &func); - if ( !e || *e ) + if ( !e || (*e && *e !=3D ',') ) { printk(XENLOG_ERR "Invalid dbgp=3D PCI device spec: '%s'\n", @@ -1094,6 +1162,37 @@ void __init xhci_dbc_uart_init(void) } dbc->sbdf =3D PCI_SBDF(0, bus, slot, func); } + opt =3D e; + + /* other options */ + while ( opt && *opt =3D=3D ',' ) + { + opt++; + e =3D strchr(opt, ','); + if ( !e ) + e =3D strchr(opt, '\0'); + + if ( !strncmp(opt, "share=3D", 6) ) + { + if ( !cmdline_strcmp(opt + 6, "none") ) + dbc->share =3D XHCI_SHARE_NONE; + else if ( !cmdline_strcmp(opt + 6, "hwdom") ) + dbc->share =3D XHCI_SHARE_HWDOM; + else if ( !cmdline_strcmp(opt + 6, "any") ) + dbc->share =3D XHCI_SHARE_ANY; + else + break; + } + else + break; + + opt =3D e; + } + if ( !opt || *opt ) + { + printk(XENLOG_ERR "Invalid dbgp=3D parameters: '%s'\n", opt_dbgp); + return; + } =20 dbc->dbc_ctx =3D &dbc_dma_bufs.ctx; dbc->dbc_erst =3D &dbc_dma_bufs.erst; --=20 git-series 0.9.1 From nobody Fri May 3 05:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1658806028778328.26848861723886; Mon, 25 Jul 2022 20:27:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.375006.607258 (Exim 4.92) (envelope-from ) id 1oGBDc-00016U-EX; Tue, 26 Jul 2022 03:26:48 +0000 Received: by outflank-mailman (output) from mailman id 375006.607258; Tue, 26 Jul 2022 03:26:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBDc-00016N-C0; Tue, 26 Jul 2022 03:26:48 +0000 Received: by outflank-mailman (input) for mailman id 375006; Tue, 26 Jul 2022 03:26:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAf-0003P0-9s for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:45 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 597f4bba-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:43 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4E87C5C00C4; Mon, 25 Jul 2022 23:23:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 25 Jul 2022 23:23:42 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:40 -0400 (EDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 597f4bba-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805822; x=1658892222; bh=3vE9DGYbhI DJep8SC3VFi3wWujuEwVBs1IYyq266dMs=; b=DNewsGpK5rLAbc6QqSmb64oajs YI/gPl81TyM+Psc/HlywUIII+Gj81IIHTqM9T3ejn2RGPHbb2VN8sx95AplC7ddL cjftQ2BuINq2hLvRJCOj/3lUArkN2yq3Zfdmh4klEAeLqqt1AdOB1ROJK+ok8p1I Omtp5P7XLFeqEM42a0hOkr6VGb1JeUthYjhirhfFecfcF6WTfi38jej7+lAU6XUF RU8liaDYrS5JlHmLXGqvt+8rNCOM4bB9qSNMxVKMsyW7obD4wNrwSAkX8ZyB4EYk hANv91UMpBMtK+Lp1PfSoOYK+DJ8M1XU5FB+IUn0f9r5kaGB/ooS7phv/1mQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805822; x= 1658892222; bh=3vE9DGYbhIDJep8SC3VFi3wWujuEwVBs1IYyq266dMs=; b=r uADkbeaSQDVLdT/4gy1rcV4vqbqcISvVmaOnhBuyt4cnJW6WPViTYxeEf+WsOOg/ ZzeK/5NUiXT0Yh6mxoUS+t35Kyqc8KdL8dWMTM70BoSICdhmqj4yXbWIs6dajAwT 8hzDcSt5WmG6Tcz+iiDDxnYB3HJMIVVsIWYjQJmBkz9LNIxisWs2Zc/1vlyKUMjm SV9Ow6nNbvk4FJ2hUi652OIeBVMzcT/fsf9bYMbXDskbMs9XZwpxcc8xgzSjOSsi I9EXlmtPV3cqNUoPDLqPqLNeQ+7Chf0SU3pqGNjLmmWxmEVBk7+slzjq/y+hrVOB D2aAah+1+10JcjtS0WgpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 10/10] driver/char: add RX support to the XHCI driver Date: Tue, 26 Jul 2022 05:23:15 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1658806029615100001 Add another work ring buffer for received data, and point IN TRB at it. Ensure there is always at least one pending IN TRB, so the controller has a way to send incoming data to the driver. Note that both "success" and "short packet" completion codes are okay - in fact it will be "short packet" most of the time, as the TRB length is about maximum size, not required size. Signed-off-by: Marek Marczykowski-G=C3=B3recki --- New patch in v3 --- docs/misc/xen-command-line.pandoc | 4 +- xen/drivers/char/xhci-dbc.c | 121 +++++++++++++++++++++++++++++++- 2 files changed, 123 insertions(+), 2 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line= .pandoc index cc1e1989b17e..07174badac8f 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -729,8 +729,8 @@ Available alternatives, with their meaning, are: Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). =20 -Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (outp= ut -only). XHCI driver will wait indefinitely for the debug host to connect - = make +Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability. +XHCI driver will wait indefinitely for the debug host to connect - make sure the cable is connected. The `share` option for xhci controls who else can use the controller: * `none`: use the controller exclusively for console, even hardware domain diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 805b447f2300..ccf4f9bbe2b7 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -109,6 +109,7 @@ enum { enum { XHCI_TRB_CC_SUCCESS =3D 1, XHCI_TRB_CC_TRB_ERR =3D 5, + XHCI_TRB_CC_SHORT_PACKET =3D 13, }; =20 /* DbC endpoint types */ @@ -243,6 +244,7 @@ struct dbc { struct xhci_trb_ring dbc_oring; struct xhci_trb_ring dbc_iring; struct dbc_work_ring dbc_owork; + struct dbc_work_ring dbc_iwork; struct xhci_string_descriptor *dbc_str; =20 pci_sbdf_t sbdf; @@ -440,6 +442,16 @@ static void xhci_trb_norm_set_ioc(struct xhci_trb *trb) trb->ctrl |=3D 0x20; } =20 +static uint64_t xhci_trb_norm_buf(struct xhci_trb *trb) +{ + return trb->params; +} + +static uint32_t xhci_trb_norm_len(struct xhci_trb *trb) +{ + return trb->status & 0x1FFFF; +} + /** * Fields for Transfer Event TRBs (see section 6.4.2.1). Note that event * TRBs are read-only from software @@ -454,6 +466,12 @@ static uint32_t xhci_trb_tfre_cc(const struct xhci_trb= *trb) return trb->status >> 24; } =20 +/* Amount of data _not_ transferred */ +static uint32_t xhci_trb_tfre_len(const struct xhci_trb *trb) +{ + return trb->status & 0x1FFFF; +} + /* Fields for link TRBs (section 6.4.4.1) */ static void xhci_trb_link_set_rsp(struct xhci_trb *trb, uint64_t rsp) { @@ -495,6 +513,14 @@ static int xhci_trb_ring_full(const struct xhci_trb_ri= ng *ring) return ((ring->enq + 1) & (DBC_TRB_RING_CAP - 1)) =3D=3D ring->deq; } =20 +static int xhci_trb_ring_size(const struct xhci_trb_ring *ring) +{ + if ( ring->enq >=3D ring->deq ) + return ring->enq - ring->deq; + + return DBC_TRB_RING_CAP - ring->deq + ring->enq; +} + static int dbc_work_ring_full(const struct dbc_work_ring *ring) { return ((ring->enq + 1) & (DBC_WORK_RING_CAP - 1)) =3D=3D ring->deq; @@ -508,6 +534,14 @@ static uint64_t dbc_work_ring_size(const struct dbc_wo= rk_ring *ring) return DBC_WORK_RING_CAP - ring->deq + ring->enq; } =20 +static uint64_t dbc_work_ring_space_to_end(const struct dbc_work_ring *rin= g) +{ + if ( ring->enq >=3D ring->deq ) + return DBC_WORK_RING_CAP - ring->enq; + + return ring->deq - ring->enq; +} + static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, uint64_t dma, uint64_t len) { @@ -568,6 +602,31 @@ static int64_t dbc_push_work(struct dbc *dbc, struct d= bc_work_ring *ring, return i; } =20 +static void dbc_rx_trb(struct dbc *dbc, struct xhci_trb *trb, + uint64_t not_transferred) +{ + struct dbc_work_ring *ring =3D &dbc->dbc_iwork; + unsigned int rx_len; + unsigned int end, start =3D ring->enq; + + if ( xhci_trb_type(trb) !=3D XHCI_TRB_NORM ) + /* Can be Link TRB for example. */ + return; + + ASSERT(xhci_trb_norm_buf(trb) =3D=3D ring->dma + ring->enq); + ASSERT(xhci_trb_norm_len(trb) >=3D not_transferred); + rx_len =3D xhci_trb_norm_len(trb) - not_transferred; + + /* It can hit the ring end, but should not wrap around. */ + ASSERT(ring->enq + rx_len <=3D DBC_WORK_RING_CAP); + ring->enq =3D (ring->enq + rx_len) & (DBC_WORK_RING_CAP - 1); + + end =3D ring->enq; + + if ( end > start ) + cache_flush(&ring->buf[start], end - start); +} + /* * Note that if IN transfer support is added, then this * will need to be changed; it assumes an OUT transfer ring only @@ -577,6 +636,7 @@ static void dbc_pop_events(struct dbc *dbc) struct dbc_reg *reg =3D dbc->dbc_reg; struct xhci_trb_ring *er =3D &dbc->dbc_ering; struct xhci_trb_ring *tr =3D &dbc->dbc_oring; + struct xhci_trb_ring *ir =3D &dbc->dbc_iring; struct xhci_trb *event =3D &er->trb[er->deq]; uint64_t erdp =3D readq(®->erdp); uint32_t portsc; @@ -602,6 +662,14 @@ static void dbc_pop_events(struct dbc *dbc) trb_idx =3D (event_ptr - tr->dma) >> XHCI_TRB_SHIFT; tr->deq =3D (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); } + else if ( event_ptr - ir->dma < DBC_TRB_RING_BYTES ) + { + trb_idx =3D (event_ptr - ir->dma) >> XHCI_TRB_SHIFT; + if ( xhci_trb_tfre_cc(event) =3D=3D XHCI_TRB_CC_SUCCESS || + xhci_trb_tfre_cc(event) =3D=3D XHCI_TRB_CC_SHORT_PACK= ET ) + dbc_rx_trb(dbc, &ir->trb[trb_idx], xhci_trb_tfre_len(e= vent)); + ir->deq =3D (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); + } else dbc_alert("event: TRB 0x%lx not found in any ring\n", event_ptr); @@ -872,6 +940,7 @@ static bool __init dbc_open(struct dbc *dbc) return false; =20 dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_init_work_ring(dbc, &dbc->dbc_iwork); dbc_enable_dbc(dbc); dbc->open =3D true; =20 @@ -985,6 +1054,33 @@ static void dbc_flush(struct dbc *dbc, struct xhci_tr= b_ring *trb, } =20 /** + * Ensure DbC has a pending transfer TRB to receive data into. + * + * @param dbc the dbc to flush + * @param trb the ring for the TRBs to transfer + * @param wrk the work ring to receive data into + */ +static void dbc_enqueue_in(struct dbc *dbc, struct xhci_trb_ring *trb, + struct dbc_work_ring *wrk) +{ + struct dbc_reg *reg =3D dbc->dbc_reg; + uint32_t db =3D (readl(®->db) & 0xFFFF00FF) | (trb->db << 8); + + /* Check if there is already queued TRB */ + if ( xhci_trb_ring_size(trb) >=3D 1 ) + return; + + if ( dbc_work_ring_full(wrk) ) + return; + + dbc_push_trb(dbc, trb, wrk->dma + wrk->enq, + dbc_work_ring_space_to_end(wrk)); + + wmb(); + writel(db, ®->db); +} + +/** * Queue a single character to the DbC. A transfer TRB will be created * if the character is a newline and the DbC will be notified that data is * available for writing to the debug host. @@ -1007,6 +1103,19 @@ static int64_t dbc_putc(struct dbc *dbc, char c) return 1; } =20 +static int dbc_getc(struct dbc *dbc, char *c) +{ + struct dbc_work_ring *wrk =3D &dbc->dbc_iwork; + + if ( dbc_work_ring_size(wrk) =3D=3D 0 ) + return 0; + + *c =3D wrk->buf[wrk->deq]; + wrk->deq =3D (wrk->deq + 1) & (DBC_WORK_RING_CAP - 1); + + return 1; +} + struct dbc_uart { struct dbc dbc; struct timer timer; @@ -1032,6 +1141,9 @@ static void cf_check dbc_uart_poll(void *data) spin_unlock_irqrestore(&port->tx_lock, flags); } =20 + while ( dbc_work_ring_size(&dbc->dbc_iwork) ) + serial_rx_interrupt(port, guest_cpu_user_regs()); + serial_tx_interrupt(port, guest_cpu_user_regs()); set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); } @@ -1092,6 +1204,12 @@ static void cf_check dbc_uart_putc(struct serial_por= t *port, char c) dbc_putc(&uart->dbc, c); } =20 +static int cf_check dbc_uart_getc(struct serial_port *port, char *c) +{ + struct dbc_uart *uart =3D port->uart; + return dbc_getc(&uart->dbc, c); +} + static void cf_check dbc_uart_flush(struct serial_port *port) { s_time_t goal; @@ -1111,6 +1229,7 @@ static struct uart_driver dbc_uart_driver =3D { .init_postirq =3D dbc_uart_init_postirq, .tx_ready =3D dbc_uart_tx_ready, .putc =3D dbc_uart_putc, + .getc =3D dbc_uart_getc, .flush =3D dbc_uart_flush, }; =20 @@ -1119,6 +1238,7 @@ struct dbc_dma_bufs { struct xhci_trb out_trb[DBC_TRB_RING_CAP]; struct xhci_trb in_trb[DBC_TRB_RING_CAP]; uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); + uint8_t in_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); struct xhci_erst_segment erst __aligned(16); struct xhci_dbc_ctx ctx __aligned(16); struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; @@ -1200,6 +1320,7 @@ void __init xhci_dbc_uart_init(void) dbc->dbc_oring.trb =3D dbc_dma_bufs.out_trb; dbc->dbc_iring.trb =3D dbc_dma_bufs.in_trb; dbc->dbc_owork.buf =3D dbc_dma_bufs.out_wrk_buf; + dbc->dbc_iwork.buf =3D dbc_dma_bufs.in_wrk_buf; dbc->dbc_str =3D dbc_dma_bufs.str_buf; =20 if ( dbc_open(dbc) ) --=20 git-series 0.9.1