[Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

Lars Kurth posted 3 patches 31 weeks ago

[Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

Posted by Lars Kurth 31 weeks ago
This change provides sufficient information to allow get_maintainer.pl /
add_maintainers.pl scripts to be run on xen sister repositories such as
mini-os.git, osstest.git, etc

A suggested template for sister repositories of Xen is

========================================================
This file follows the same conventions as outlined in
xen.git:MAINTAINERS. Please refer to the file in xen.git
for more information.

THE REST
M:      MAINTAINER1 <maintainer1@email.com>
M:      MAINTAINER2 <maintainer2@email.com>
L:      xen-devel@lists.xenproject.org
S:      Supported
F:      *
F:      */
V:      xen-maintainers-1
========================================================

Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 77413e0..bb3da43 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -97,6 +97,9 @@ Descriptions of section entries:
 	      matches patches or files that contain one or more of the words
 	      printk, pr_info or pr_err
 	   One regex pattern per line.  Multiple K: lines acceptable.
+	V: Version identifier that must be under THE REST and follows
+	   the format:
+	   xen-maintainers-<version format number of this file>
 
 
 The meaning of nesting:
@@ -541,3 +544,4 @@ L:	xen-devel@lists.xenproject.org
 S:	Supported
 F:	*
 F:	*/
+V:	xen-maintainers-1
-- 
git-series 0.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

Posted by Julien Grall 30 weeks ago
Hi Lars,

On 9/4/19 12:30 PM, Lars Kurth wrote:
> This change provides sufficient information to allow get_maintainer.pl /
> add_maintainers.pl scripts to be run on xen sister repositories such as
> mini-os.git, osstest.git, etc
> 
> A suggested template for sister repositories of Xen is
> 
> ========================================================
> This file follows the same conventions as outlined in
> xen.git:MAINTAINERS. Please refer to the file in xen.git
> for more information.
> 
> THE REST
> M:      MAINTAINER1 <maintainer1@email.com>
> M:      MAINTAINER2 <maintainer2@email.com>
> L:      xen-devel@lists.xenproject.org
> S:      Supported
> F:      *
> F:      */
> V:      xen-maintainers-1
> ========================================================
> 
> Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

Posted by Julien Grall 30 weeks ago
Hi,

Actually, I have one question about the template (my ack still stands).

On 9/10/19 4:18 PM, Julien Grall wrote:
> Hi Lars,
> 
> On 9/4/19 12:30 PM, Lars Kurth wrote:
>> This change provides sufficient information to allow get_maintainer.pl /
>> add_maintainers.pl scripts to be run on xen sister repositories such as
>> mini-os.git, osstest.git, etc
>>
>> A suggested template for sister repositories of Xen is
>>
>> ========================================================
>> This file follows the same conventions as outlined in
>> xen.git:MAINTAINERS. Please refer to the file in xen.git
>> for more information.
>>
>> THE REST
>> M:      MAINTAINER1 <maintainer1@email.com>
>> M:      MAINTAINER2 <maintainer2@email.com>
>> L:      xen-devel@lists.xenproject.org

I was under the impression that the scripts would be used for Unikraft. 
If so, do we expect them to CC xen-devel everytime?

If the answer is no, then we will probably want to add_maintainers.pl.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

Posted by Lars Kurth 30 weeks ago
On 10/09/2019, 16:31, "Julien Grall" <julien.grall@arm.com> wrote:

    Hi,
    
    Actually, I have one question about the template (my ack still stands).
    
    On 9/10/19 4:18 PM, Julien Grall wrote:
    > Hi Lars,
    > 
    > On 9/4/19 12:30 PM, Lars Kurth wrote:
    >> This change provides sufficient information to allow get_maintainer.pl /
    >> add_maintainers.pl scripts to be run on xen sister repositories such as
    >> mini-os.git, osstest.git, etc
    >>
    >> A suggested template for sister repositories of Xen is
    >>
    >> ========================================================
    >> This file follows the same conventions as outlined in
    >> xen.git:MAINTAINERS. Please refer to the file in xen.git
    >> for more information.
    >>
    >> THE REST
    >> M:      MAINTAINER1 <maintainer1@email.com>
    >> M:      MAINTAINER2 <maintainer2@email.com>
    >> L:      xen-devel@lists.xenproject.org
    
    I was under the impression that the scripts would be used for Unikraft. 
    If so, do we expect them to CC xen-devel everytime?

In that case, the template has to be adapted. I was mainly thinking of 
XTF, OSSTEST, livepatch-build-tools. If it were used say for minios
(which I think it should)  the L: field would obviously need changing
 
Once this series is through, I will submit maintainer files for all those
projects making sure that they have the right L: field.

    If the answer is no, then we will probably want to add_maintainers.pl.
    
I basically dropped the original patch for Unikraft as nobody has responded.
I was not planning to pick this up, unless someone from Unikraft runs with it 

Regards
Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

Posted by Julien Grall 30 weeks ago
Hi Lars,

On 9/10/19 4:35 PM, Lars Kurth wrote:
> 
> On 10/09/2019, 16:31, "Julien Grall" <julien.grall@arm.com> wrote:
> 
>      Hi,
>      
>      Actually, I have one question about the template (my ack still stands).
>      
>      On 9/10/19 4:18 PM, Julien Grall wrote:
>      > Hi Lars,
>      >
>      > On 9/4/19 12:30 PM, Lars Kurth wrote:
>      >> This change provides sufficient information to allow get_maintainer.pl /
>      >> add_maintainers.pl scripts to be run on xen sister repositories such as
>      >> mini-os.git, osstest.git, etc
>      >>
>      >> A suggested template for sister repositories of Xen is
>      >>
>      >> ========================================================
>      >> This file follows the same conventions as outlined in
>      >> xen.git:MAINTAINERS. Please refer to the file in xen.git
>      >> for more information.
>      >>
>      >> THE REST
>      >> M:      MAINTAINER1 <maintainer1@email.com>
>      >> M:      MAINTAINER2 <maintainer2@email.com>
>      >> L:      xen-devel@lists.xenproject.org
>      
>      I was under the impression that the scripts would be used for Unikraft.
>      If so, do we expect them to CC xen-devel everytime?
> 
> In that case, the template has to be adapted. I was mainly thinking of
> XTF, OSSTEST, livepatch-build-tools. If it were used say for minios
> (which I think it should)  the L: field would obviously need changing
>   
> Once this series is through, I will submit maintainer files for all those
> projects making sure that they have the right L: field.
> 
>      If the answer is no, then we will probably want to add_maintainers.pl.
>      
> I basically dropped the original patch for Unikraft as nobody has responded.
> I was not planning to pick this up, unless someone from Unikraft runs with it

It makes sense. Thank you for the explanation!

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel