From nobody Fri Sep 25 21:36:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1790283526; cv=pass; d=zohomail.com; s=zohoarc; b=UXxXnNdlF0d0GjhYk+NWUFbDHqV1Om6Z2GEZozUti4fsVxW7FyLstIkW3vbUx6+M6bfs8FtisJEebAZ5DtZUsG0r06jihCA/JYDI28nQSu8qk0EE9+QEJXzAgj7hSXfj4AaEBDeyNjztc+emuOxId3BZwBulIC/T0YedM7n5sOk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790283526; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2cKreGMUElULo1QhsKeoGyzZB+m+nWVmEkjFZ6Y0E/o=; b=EkJLxbAFf6/HKPIxGRnACsWSTk1RTD/B3xBDsYB0kfYAsXVvyC6llZbksLNXiylF20JYNIxP+kr7UApaPjaaFjCDVvSNWtJpBy+fUwzBIrZ7raBg8wklfcQ27ZtHe2oaCZUbwZ9t32kzpbF50aVevXGw20fdewRJgXJH15qYiaU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 179028352638051.80545949143789; Thu, 24 Sep 2026 13:58:46 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1433042.1653881 (Exim 4.92) (envelope-from ) id 1x9qWK-0005f9-Gt; Thu, 24 Sep 2026 20:58:20 +0000 Received: by outflank-mailman (output) from mailman id 1433042.1653881; Thu, 24 Sep 2026 20:58:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x9qWK-0005f2-E7; Thu, 24 Sep 2026 20:58:20 +0000 Received: by outflank-mailman (input) for mailman id 1433042; Thu, 24 Sep 2026 20:58:19 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x9qWJ-0005eb-K5 for xen-devel@lists.xenproject.org; Thu, 24 Sep 2026 20:58:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x9qWJ-006bdo-0u for xen-devel@lists.xenproject.org; Thu, 24 Sep 2026 22:58:19 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ab58eca-bab6-0a2a0a5309dd-0a2a4507bfe2-20 for ; Thu, 24 Sep 2026 22:58:19 +0200 Received: from [52.101.72.96] (helo=AM0PR02CU008.outbound.protection.outlook.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ab58eea-b4ea-0a2a45070019-346548602343-3 for ; Thu, 24 Sep 2026 22:58:18 +0200 Received: from DB3PR0302MB9208.eurprd03.prod.outlook.com (2603:10a6:10:430::13) by GV1PR03MB10503.eurprd03.prod.outlook.com (2603:10a6:150:16f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.18; Thu, 24 Sep 2026 20:58:16 +0000 Received: from DB3PR0302MB9208.eurprd03.prod.outlook.com ([fe80::f257:38e:c0af:df28]) by DB3PR0302MB9208.eurprd03.prod.outlook.com ([fe80::f257:38e:c0af:df28%5]) with mapi id 15.21.0451.014; Thu, 24 Sep 2026 20:58:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZMRtPN43aJim3Ip0+0Q0UQxof+rJp+A4Ec8ws1UvIvPhEWFK3Jf4akODFHz2BTqIMP7uSzgwXgBasCBkLnLNopwtt3PjoiQNLtgMaxuJ//8IlpB8bnBJVgvi9YPYhrIo5OCVQO1HeM6WISA/2WKqFCkOzI/elEP/imtCgjBoTw3+4pQCNFAfZzAKiypTNcxCkjaD35qbw+ow52RKjXnGsICv+NxFOZ1rVXN9tMlXw+eKls3VCQrwrB1VC9oeYeVGB/aTnZDZpBjSqhunP+zPpC6Az0zOtyA2LY45ARfO5qFpb0cu7cfoBkdMnbGcCiXtZh6srN6Olvr34BSlXTiDiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2cKreGMUElULo1QhsKeoGyzZB+m+nWVmEkjFZ6Y0E/o=; b=Tn+YWP29nsFVC+g2Z2JaJ4TL+UGgm0yM3O915rFZkK3IsU74s5Z3cXp+nk56F1K6mffYGHlgIIaWImCyEoABF/e4A2AqD+zecmDXM07XJVrxE/4c6QHSV4gP769SYfKLeYWtkvm6RePnYu+PBmrO4PoQowFUmAsoltbvi0ioEhw4nj7b16ZlpZ8jqfZvJKH+5xtlvWzu/ZhiZlKziFx7NROMeKS23HVVEH/+LK3IwHo19Hxhgh712qTrvWYr26PuAvr+3/lXqdy/KOzM7pWFF62lDGkanJOM0lKTAWkaEOnVsH4LjFtJvA0LrbokIyYDlXx5fzovcCQx6zhb6vJ5Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2cKreGMUElULo1QhsKeoGyzZB+m+nWVmEkjFZ6Y0E/o=; b=hPlv2lfsDxTDaCwTcIxVXiKoHZKpCj6FplNFesJkwFccG63xU1YARr60ocOeUZ6PmlncMdT+QUCcpQaJ0UXzdAAxEGxeQEYzXR0ELeu/Li/npefyOgsDttIbPPYUQ8xWtz1dZTvxWiATgLvLC60QtNscgwHI4RrP0A3kVpg+7znHnwBIM1/3nfq0OdSDH5CtCmasWc5KJ9NvfOhhSrNb3nreZVI/KgVMOxS79RySOs4yEEzphma2Ve/Xo9Gxljz5THj9goJsMvNhQ3LmZgyRNdT8gTPHwlM/yxC9JVpEVNw4D8ZzHkCooWpSV1Rqy1+ojMwFjadH4O4ldbuiJlhh3A== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jens Wiklander , Volodymyr Babchuk Subject: [PATCH v5 1/4] xen/arm: handle irq_set_type() failures Date: Thu, 24 Sep 2026 23:57:53 +0300 Message-ID: X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA0P291CA0022.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::22) To DB3PR0302MB9208.eurprd03.prod.outlook.com (2603:10a6:10:430::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR0302MB9208:EE_|GV1PR03MB10503:EE_ X-MS-Office365-Filtering-Correlation-Id: eaeb7763-ca84-45bb-1ccd-08df1a7e8e64 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|7416014|376014|1800799024|11063799006|56012099006|10067099003|22082099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info: ICH174TeE8r+OFrdJ2Q0P3mLL7/E5HVNEZVh5QOKpn5GcmRK1DNZtjUlga3hb1H/hwblQf39oKvItpcEx3MSWiOcEACg9rt6IFc0JyWURGNpP3x2kBW5PKppNmlXiLBSkmIOOTZMsVMI7C63g9lJQvBD3TEu30OXvRVLZ+RZ8JX69TIWjfMaaPm/K7iOBnn1a+fEgNYnqF6uD7EfhC4uTozyIg9CQN3KM8ixGBYuwCk7tVzlDcqqB+MGhLuWA4IsqOzHwCiJ67idxIA56WCYlSXR0FJeJH3vgiaQyAkpV+kjvXcfEXYasHbAO1z5+O08CHH0U84rj+N5xMiw/ItyfDAd9J3Wq6SwXN88qhk8DHldgcVFoXtm72DAZ5mrm4mAtrJvwOx4BeiexdFqb1on8FqU+UwN8On1pwuCT23DkMit977y4s6x2SPoXnd4ZcuSHwf4xHYBwH3z2JdaJNBgH8dvRlV2qOoj1tbL10d+sTcOUmYwHzmcbDZrO6RAvrTpE+kVFYPvrsw5KB27SDHYzJ7zYJDy4AFLMBxyL+hswRShcQkaJiezc+uU4DVELPTAkKgX1tlY/aAO/vjXd+sT/JwOaGIQ72jaIxL3aWrjmwWo7rIpWfGIyDGIzJQXN5LV5xn2QkH+S4nghGF3tO2wcOBB0AMzARVgCiqQC/ONkLI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB3PR0302MB9208.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(7416014)(376014)(1800799024)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HI4go001o3bIuJJ8JD5j6WUOjT7vYlRZoJMK/vJeFocV927H8SjFSW06qr1g?= =?us-ascii?Q?5MGSq5rG9YZ+c6ukunkvICE3gpc/F7N592AeNH2nDzde+CdNDXbu0MRA52ju?= =?us-ascii?Q?gyC+KNNVRsm5IWG4aZe+s+Oqkz+jjR9SVf5FjQJiZkdG0lZLqpN0H968fy9d?= =?us-ascii?Q?O+kTi+eIUZJOmWjpUxQDIVEQwbv27XaKcGhVybCxFqVM+4EhBtOD95rSdhw6?= =?us-ascii?Q?9J/OuM4KHNx1QZed5XfI4omLlV7GVhMLvh2smMjCrdieg+MG5X3Vldvfk8Ir?= =?us-ascii?Q?GxQ/yW3quNVn/4gKjvyHrlki1LfGjG7qLaLLndPAPkg4vlHn/6IEymUl3rwd?= =?us-ascii?Q?Fr+vEtIcr+XhU4w3h8QKlWTVvXODc34be5ZlSfa+uZ4akYbxugGqjrBn1FmD?= =?us-ascii?Q?RKPcqi8ymQ9dny+6nbDBQydbyXbddm49Xds74c575MRUpWyB4Y/dvPLHnxdN?= =?us-ascii?Q?QR5WOlalUCTvm9hKvof6umjJayIGVa56qwjPJlDNG3wwXfjd2Aw0LGI0i8hd?= =?us-ascii?Q?EBEeoJEO6GmhJAmHD8CfpWC05O+q8XPDjSI2uWaZW4z747iK9JD2jKQs7mcA?= =?us-ascii?Q?10yXeexb8VTCxsgN9smoL1ryuSekcK/CxJlwM2We0/zbrdCjQYsL6TcpLY70?= =?us-ascii?Q?+nlaWmcvGEKGrqbKUNtToIpS/CGF1quZbqpa14B7TLKC2BviNimOD2LBEY+x?= =?us-ascii?Q?Y6xk4zNj6PsByIJTrpmTbMN45gzdqRZu3hm7VICRU5eX0SXV6TPc+Fe+tzG+?= =?us-ascii?Q?fRNeq9sI7FWWUYApgZs6OMFFqLr2wyC/cYLODDlMIzGn+NlDPZItBXDP9/8P?= =?us-ascii?Q?x8HI7iHRGq2vS5BuFSUYPqkoz5I4REyweeAQLfZf5rzBK+FAd25ea+Hkh8H2?= =?us-ascii?Q?7Phs2o9w8d7Y+jIwlbqysKivl8zZ9TJPWOP/D7djEoORqRwTzQqUdsSzRMO8?= =?us-ascii?Q?B9EHS8HfaVCrdgASXI2uHCSDnf0YGh2C2M4dMekaQU167AlGu1hAOAfO2lsi?= =?us-ascii?Q?o6Usd4ubMMzA9MpmN8vGPm/fDC4FSQdrTQatQ/tc6mivQle/x/kRxIXf+4Bv?= =?us-ascii?Q?Gx9bDmeN3uFiTrTY6ZzkMLBt6lp7/jYFaqjXaCrVNMAA0VdpX0sOGyFInQJb?= =?us-ascii?Q?PJqoO0bKxltsTeCTH3IYYsIFiRV8SAt0fopd8dCLOOGUcmY6G2M+ekpp0TIK?= =?us-ascii?Q?3zsCe8VVSfsgBuqCjfAT57DQ2i6ydRRlKeSjoFyqZIKAQjxn7QN25E+Lvrkv?= =?us-ascii?Q?0pXO5TruXxwKu+MpYlGpk59anO08U6ZZW4SK9pP93eElk3gOIFj+WuYZl53C?= =?us-ascii?Q?/nloD+JVrLTKHUyp42Ql8WkJe9kzT/U1GSsL0vX0Uvb0qOzsRz+x2R78XSFE?= =?us-ascii?Q?Uw5sT2ui90YUhOXbA7QB/q5x7g71me+nl+QIWgqtr7JoElgB1EjMBH7keNRF?= =?us-ascii?Q?xaP2mWeozcK0Cpsn/7D7XorCiNCqkmUm9zCK4je8bnmT66+BIcf7A9HdTEce?= =?us-ascii?Q?7+KeDUXS28k4WmRXTluVJ+D4lEPtRErQNIRebFKXsxQl4bWM9MXTA0tWm9vD?= =?us-ascii?Q?I18fa/JCWv0NPrLKA0A9DyGcyGDJgBYqKY4Fa+LUrRR3JyXApfDPYd7oSbgv?= =?us-ascii?Q?uZcptWHbfWpV1LLMXBwO+pbi5OVOqLFoMLugp3EFQcYYizR6uhiSnUg8nlMo?= =?us-ascii?Q?txU+jRmZkH1KIS5dDmo3rJoIDfKdfLea8TWO/A4FJDBuYx66cGa31q9rTo+x?= =?us-ascii?Q?MUWhHjnCag=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: eaeb7763-ca84-45bb-1ccd-08df1a7e8e64 X-MS-Exchange-CrossTenant-AuthSource: DB3PR0302MB9208.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2026 20:58:16.8019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zF3QyVmAavuCDFfeJTg52Z0a8cWhq9Ojj+hjUfLC9xP2huwTaaG1DCCj5nf0+NbZDL/Sr4+AZyp1yRsrpRNUQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR03MB10503 X-purgate-ID: tlsNG-ef75cf/1790283498-A58C1AE4-2EE4BAF3/0/0 X-purgate-type: clean X-purgate-size: 8128 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1790283528344158500 Content-Type: text/plain; charset="utf-8" Several Arm firmware initialization paths discard irq_set_type()'s return value, violating MISRA C Rule 17.7. If trigger configuration fails, initialization continues with an IRQ that was not configured as requested. GTDT and MADT retain rejected timer and maintenance INTIDs. check_timer_irq_cfg() and release_irq() later perform unconditional descriptor lookups on those values. Xen has no backing descriptors for INTIDs 1024 through 4095, so retaining one can cause an out-of-bounds access. Check the return value in the GTDT, MADT, SPCR, and FF-A paths. Store timer INTIDs only after successful trigger configuration, make GTDT parsing failure fatal, and stop UART or notification setup when trigger configuration fails. Signed-off-by: Mykola Kvach Reviewed-by: Volodymyr Babchuk Reviewed-by: Michal Orzel --- Changes in v3: - Avoid partial state updates and simplify maintenance IRQ setup. Changes in v2: - New patch. --- xen/arch/arm/gic-v2.c | 15 +++++++++------ xen/arch/arm/gic-v3.c | 15 +++++++++------ xen/arch/arm/tee/ffa_notif.c | 11 ++++++++++- xen/arch/arm/time.c | 18 ++++++++++++++---- xen/drivers/char/ns16550.c | 8 ++++++-- xen/drivers/char/pl011.c | 4 +++- 6 files changed, 51 insertions(+), 20 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index d05c574d88..87eda9d322 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -1166,17 +1166,20 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header= *header, /* Read from APIC table and fill up the GIC variables */ if ( cpu_base_assigned =3D=3D 0 ) { + int rc; + + rc =3D irq_set_type(processor->vgic_interrupt, + processor->flags & ACPI_MADT_VGIC_IRQ_MODE ? + IRQ_TYPE_EDGE_BOTH : IRQ_TYPE_LEVEL_MASK); + + if ( rc ) + return rc; + cbase =3D processor->base_address; csize =3D SZ_8K; hbase =3D processor->gich_base_address; vbase =3D processor->gicv_base_address; gicv2_info.maintenance_irq =3D processor->vgic_interrupt; - - if ( processor->flags & ACPI_MADT_VGIC_IRQ_MODE ) - irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_EDGE_BOTH); - else - irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_LEVEL_MASK); - cpu_base_assigned =3D 1; } else diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index acdac22953..b32a9b5009 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1743,15 +1743,18 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header= *header, /* Read from APIC table and fill up the GIC variables */ if ( !cpu_base_assigned ) { + int rc; + + rc =3D irq_set_type(processor->vgic_interrupt, + processor->flags & ACPI_MADT_VGIC_IRQ_MODE ? + IRQ_TYPE_EDGE_BOTH : IRQ_TYPE_LEVEL_MASK); + + if ( rc ) + return rc; + cbase =3D processor->base_address; vbase =3D processor->gicv_base_address; gicv3_info.maintenance_irq =3D processor->vgic_interrupt; - - if ( processor->flags & ACPI_MADT_VGIC_IRQ_MODE ) - irq_set_type(gicv3_info.maintenance_irq, IRQ_TYPE_EDGE_BOTH); - else - irq_set_type(gicv3_info.maintenance_irq, IRQ_TYPE_LEVEL_MASK); - cpu_base_assigned =3D 1; } else diff --git a/xen/arch/arm/tee/ffa_notif.c b/xen/arch/arm/tee/ffa_notif.c index 186e726412..d08d0a3366 100644 --- a/xen/arch/arm/tee/ffa_notif.c +++ b/xen/arch/arm/tee/ffa_notif.c @@ -407,7 +407,16 @@ void ffa_notif_init(void) irq =3D resp.a2; notif_sri_irq =3D irq; if ( irq >=3D NR_GIC_SGI ) - irq_set_type(irq, IRQ_TYPE_EDGE_RISING); + { + ret =3D irq_set_type(irq, IRQ_TYPE_EDGE_RISING); + if ( ret ) + { + printk(XENLOG_ERR + "ffa: irq_set_type irq %u failed: error %d\n", + irq, ret); + return; + } + } ret =3D request_irq(irq, 0, notif_irq_handler, "FF-A notif", NULL); if ( ret ) { diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index be54b87438..ccfb76e20f 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -60,20 +60,27 @@ static int __init arch_timer_acpi_init(struct acpi_tabl= e_header *header) { u32 irq_type; struct acpi_table_gtdt *gtdt; + int rc; =20 gtdt =3D container_of(header, struct acpi_table_gtdt, header); =20 /* Initialize all the generic timer IRQ variable from GTDT table */ irq_type =3D acpi_get_timer_irq_type(gtdt->non_secure_el1_flags); - irq_set_type(gtdt->non_secure_el1_interrupt, irq_type); + rc =3D irq_set_type(gtdt->non_secure_el1_interrupt, irq_type); + if ( rc ) + return rc; timer_irq[TIMER_PHYS_NONSECURE_PPI] =3D gtdt->non_secure_el1_interrupt; =20 irq_type =3D acpi_get_timer_irq_type(gtdt->virtual_timer_flags); - irq_set_type(gtdt->virtual_timer_interrupt, irq_type); + rc =3D irq_set_type(gtdt->virtual_timer_interrupt, irq_type); + if ( rc ) + return rc; timer_irq[TIMER_VIRT_PPI] =3D gtdt->virtual_timer_interrupt; =20 irq_type =3D acpi_get_timer_irq_type(gtdt->non_secure_el2_flags); - irq_set_type(gtdt->non_secure_el2_interrupt, irq_type); + rc =3D irq_set_type(gtdt->non_secure_el2_interrupt, irq_type); + if ( rc ) + return rc; timer_irq[TIMER_HYP_PPI] =3D gtdt->non_secure_el2_interrupt; =20 return 0; @@ -81,7 +88,10 @@ static int __init arch_timer_acpi_init(struct acpi_table= _header *header) =20 static void __init preinit_acpi_xen_time(void) { - acpi_table_parse(ACPI_SIG_GTDT, arch_timer_acpi_init); + int rc =3D acpi_table_parse(ACPI_SIG_GTDT, arch_timer_acpi_init); + + if ( rc ) + panic("Timer: Failed to configure interrupts from GTDT: %d\n", rc); } #else static void __init preinit_acpi_xen_time(void) { } diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 120ac09d23..eb608ab8b4 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1928,6 +1928,7 @@ static int __init ns16550_acpi_uart_init(const void *= data) struct acpi_table_header *table; struct acpi_table_spcr *spcr; acpi_status status; + int rc; /* * Same as the DT part. * Only support one UART on ARM which happen to be ns16550_com[0]. @@ -1959,6 +1960,11 @@ static int __init ns16550_acpi_uart_init(const void = *data) return -EINVAL; } =20 + /* The trigger/polarity information is not available in spcr. */ + rc =3D irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); + if ( rc ) + return rc; + ns16550_init_common(uart); =20 /* @@ -1975,8 +1981,6 @@ static int __init ns16550_acpi_uart_init(const void *= data) uart->reg_shift =3D spcr->serial_port.bit_offset; uart->reg_width =3D spcr->serial_port.access_width; =20 - /* The trigger/polarity information is not available in spcr. */ - irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); uart->irq =3D spcr->interrupt; =20 uart->vuart.base_addr =3D uart->io_base; diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index a336241033..97c53c11e0 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -363,7 +363,9 @@ static int __init pl011_acpi_uart_init(const void *data) spcr->interface_type =3D=3D ACPI_DBG2_SBSA_32); =20 /* trigger/polarity information is not available in spcr */ - irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); + res =3D irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); + if ( res ) + return res; =20 /* TODO - mmio32 proper handling (for now set to true) */ res =3D pl011_uart_init(spcr->interrupt, spcr->serial_port.address, --=20 2.53.0 From nobody Fri Sep 25 21:36:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1790283517; cv=pass; d=zohomail.com; s=zohoarc; b=DsubpSzlcTessY6fNks2QYPt5Ks5ZvO218cqOKGyTaCuCL6s7g8psmiertON5RdRrNBsEF5F5ULeGI9lx2oDMqxbWlcm75lzH/gSN5y+y0uvvIb+sKYvJj6c6VnptEMfnr/veORNJfbrF1ZLE7XIpV0x+xVIPTQ+5a9sSSRVhBU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790283517; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XZJm9VptMgDBtMucbsn2Dy/QZZTYVwTGm6Ztac11StQ=; b=GX1Ehea4ow50JYkO2Sniq5I8+56JDa+dH9FBIdCap8EFvrUhrCBfyB25SdYf5Fca/SPuMND6XDIKjXX16dOFmaRmapLqwLWZnQGxXj3vKKJD7qdK1MiOc54J96+K5QVDlVAYq0QxP1Q8E9Xa9Eg5ijBTJlr1cRB9g3EBpQe3BcU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1790283517193252.67103707015758; Thu, 24 Sep 2026 13:58:37 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1433043.1653891 (Exim 4.92) (envelope-from ) id 1x9qWM-0005tE-Pm; Thu, 24 Sep 2026 20:58:22 +0000 Received: by outflank-mailman (output) from mailman id 1433043.1653891; Thu, 24 Sep 2026 20:58:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x9qWM-0005t7-Lq; Thu, 24 Sep 2026 20:58:22 +0000 Received: by outflank-mailman (input) for mailman id 1433043; Thu, 24 Sep 2026 20:58:21 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x9qWL-0005oP-Ar for xen-devel@lists.xenproject.org; Thu, 24 Sep 2026 20:58:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x9qWK-00HWJ6-Ny for xen-devel@lists.xenproject.org; Thu, 24 Sep 2026 22:58:20 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ab58ebe-e002-0a2a0a5209dd-0a2a4501e560-46 for ; Thu, 24 Sep 2026 22:58:20 +0200 Received: from [52.101.66.86] (helo=DUZPR83CU001.outbound.protection.outlook.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ab58eec-5984-0a2a45010019-346542567440-3 for ; Thu, 24 Sep 2026 22:58:20 +0200 Received: from DB3PR0302MB9208.eurprd03.prod.outlook.com (2603:10a6:10:430::13) by GV1PR03MB10503.eurprd03.prod.outlook.com (2603:10a6:150:16f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.18; Thu, 24 Sep 2026 20:58:18 +0000 Received: from DB3PR0302MB9208.eurprd03.prod.outlook.com ([fe80::f257:38e:c0af:df28]) by DB3PR0302MB9208.eurprd03.prod.outlook.com ([fe80::f257:38e:c0af:df28%5]) with mapi id 15.21.0451.014; Thu, 24 Sep 2026 20:58:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kcrtg0u8XideqywdwzVLW1qFyOrF+fQW9OfUJ5MFRaZij363b61NNhvkcDd/Nw+dHR8wCohcZ9ZZJFgrWalKOBNI8nGnqwOPyqkeklXWTjxZo3RkjSdWOzViYDmPGLgkAc6UBk4pLbWWlhWN6Ug6G+YG+R3qWN16sZwyxUpn685wkML1PHAIZSgLOsllwC1wX4jE3EN0wi3QtK1nUYD1Invziljb5dJo4Clq/2/mGPZsgmDM/Mu06p4gHGsWNfIwB/SqGcfY3RxMFfNXlv2XhDryhktdCVUDgG8YwrHx+3HbflwnLCFl1Bji3AnMeYJCZeaMnRNq/sVrTyfZ+wG84w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XZJm9VptMgDBtMucbsn2Dy/QZZTYVwTGm6Ztac11StQ=; b=OSDWt047dQq7kHiJu5n8vHwg6UGozeRTXEGogxoiiHugPntlvEtXi9BlZ4N6BKLZWTSZDnBUaM6OPltDIaAO0KiXAtlI4tTlNvx06luI8EdIvTuLLNUUjpWU99do0AgjFwUBkw0whJ8XimcjcE7ektwRJ0b3pHdeRo3OV0sqk0g5xnmFcP2JYeuCWbk/LRH3pP0axPDWcK0maS9Ally88JLoAnbhjnvC4SnZbY7b59vcJqN5TqUD3roB+XiB7znfS8h7pbglDWbAuS1nGSwdocBUewGkcFUIwlcF7dtZAn6pglFWPTEy//9ZPOSuI2bo9Hq1rzAbJg0/zenc3sRnhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XZJm9VptMgDBtMucbsn2Dy/QZZTYVwTGm6Ztac11StQ=; b=VKFbK7WPkyKGdvQ7JVVIUeVus5R45nQZhPOc30v1RsueK3Cerk+TQ+NBOcC4e1RdRmWWwadOo6heo7pifhMzBcqt0aZHI6DXOGXy9WX4mVTYIuDQjlTnDKGSHnEWIuEauikV7blMdf9z6LkQmLj1+OYLXzYjKCN148mfbDsj+kAnaBC8bGrf+H8WrJ8I9npib6/pHItoArW9AKxeBs73TuhMBEA4UgFOZYiBuE5qrLQJj7bLGTmTWH55gpqzu64OSYG5QmK3KaxgdKw5kBORaZC6dTq/6foeoRbZWpf4jNGJzALnIEcEsS8ixqJ3rIK7emYC6hhPU5nI/a+lJgGeRw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH v5 2/4] xen/arm: make is_espi() a pure range predicate Date: Thu, 24 Sep 2026 23:57:54 +0300 Message-ID: <8aa55bb41ec944bd249a77959e7702e001a8329d.1790160605.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA0P291CA0022.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::22) To DB3PR0302MB9208.eurprd03.prod.outlook.com (2603:10a6:10:430::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR0302MB9208:EE_|GV1PR03MB10503:EE_ X-MS-Office365-Filtering-Correlation-Id: f7ddf65c-3137-411c-56c6-08df1a7e8f77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|11063799006|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: lBq4e3nCmNinhfdFSAPSZ0dosj47bmxTp8Jy93aHdy8DsZqKOK5ir/1l9Eq3eFILQs/zoUsNmH5zcWD5IX45+QYCJsxrHVxmBBZB2fE8d4TUgExCT74fijKDcGJ0Mg8pJ4dL6L1BvwVvoU3FeVljAMkXqbJ7QljXbWh2K81G/OIHNJ9bjZFHiJwSYTFvp1UVxdcxy+C86hnJ/mRkXmUbOSp6hbFiECVF2PdyUka6R1OXtOWd4jzdk8lvH7dzZznCttn5yehij9GiEFItCapq2JvHoor9HlxzLq1Fkzejmfm+eteDKIJf0uZEgezz2AT8aLyIHonXFM9ESJjSllAtPoDhTYAmK5xH3JGadNeMSCF/wqD0vQoHh+YRq3wyC1L1jZsrhba8i/EPUnNVCAsGHjCr2xksW9/p6BPr97uD5fdFG1ORwj6JIFlOlSUHJMIvg3RECJ7qaHmUwTl5kJmtN0GIEaL9zCwqm//vrjsfrLwoFM1eKC7yjFqr0W2YlMO87pYFrYF+b8cTqiwTs2BquF+/6J4Ll/pxRR2quZbw8QYBJtmV9pg7XPXRbuE4WMvDmORjEPhyNoHy2wr0habfjsp+Mw2EmWEC2zMCgD09z05t+UDhSy/l55zOS1yl1utZmDuNWBj4B/799dH5WAWa18RRWDXAzirxGC6f+UpyGd4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB3PR0302MB9208.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0X3+vHs5s4xIS43txTFDDsc5XdtOEJJqrkbefXlDPinkKuxPB26oi8iLGDcp?= =?us-ascii?Q?bnmiGNDFUro4Xm/M/AFrv/HDjanj5JAymmvaDM7e/GdAsjFqXctxzOMHmtMj?= =?us-ascii?Q?wPPy1/L4qnpQQwa/GytaVOt49ZQbZco+IlYklC5EIhWmF94TaDvNqKWVcPiT?= =?us-ascii?Q?Oc9cYG0qkj20Ph4ukZ3selUjgQaNaWeT/XZXbHPckxXwqoB1JkSosUwMjbbI?= =?us-ascii?Q?5Z1hGPBk4og3mAdWACuD3IV+D9B9Ni0+ong0Kz/AnRthM3GYGdVZHaComLJG?= =?us-ascii?Q?eKH/q7ohIeS72aCA7nAv4lbjFbRImiyYTz+kj9ntCGXEAWaOKQgVTkXOoICO?= =?us-ascii?Q?FsbArCRNZJeKhzp3+X2fTomnXiLv+bCrqZ1t8ucujcMiNa3Sd/nRr01puDy+?= =?us-ascii?Q?MrI4hFz5FIZVtRt9UXTNzMiOO3k1pi5ni1Put5nWJ5uR5pD0lWGE6ngRdaSC?= =?us-ascii?Q?u8rBoUHyiY0IKknT5hG8zmo3immjbJ0iXQb6nkFCdUQyKVlNCL0vzWpsb3fS?= =?us-ascii?Q?/Bnf3FWms8wvLJqYFCZdvoSxq+/OjVbGMUZJGr4uu0swZb7uHI5y+BkmUBz5?= =?us-ascii?Q?mHUZHbJ71vjutOYdYfDqjTPRHiTXMWfiBJ0Qlf9TmWaJwl6QAVVu/YziERVl?= =?us-ascii?Q?i+Yol8Va4YS/mIn8zDQPHP69K/OuJX2LN+z52a+JdtgmNKMFA+B5zwm83FGj?= =?us-ascii?Q?MzWg5ZFKdSc7T0z47HOjzqV0W5SGtSlSZPjKy66l8AXTzqW61OAX1CY1JyFZ?= =?us-ascii?Q?8xxytPGeb3TdlNgVBaJH12fjfTqtj7N3/6Il6h3YI3Wwohga3mE92gnKEwLW?= =?us-ascii?Q?gQWwqsqAdlk0dcs2gDeknGYE76ziSwkYSAwoQuq2kDYB4JUOOW/lG/JZuyKZ?= =?us-ascii?Q?dDtuyHLcaeJKVOPGAavkZyW0je9aCY5s+nUba7r1q2xO7JvVNqRlHSSA3BCY?= =?us-ascii?Q?2nyP+I8VfAfNhiH/ZzulKLH6eBj2BwSGkOHNLwQaXJT0/meqlThxNRJhts7o?= =?us-ascii?Q?OzhVjBCZolq6N3PojNSGIgsGBFRbztowa1gI2bpYV81YSqSJ4ULadCZgihz3?= =?us-ascii?Q?utbyI8lIiD4tQbXgTswTjqhl+IblXRk0+7wuLxl7pkOk07siKSNt9GRnEiTY?= =?us-ascii?Q?cqXHwSTAuskOvCjdM4pJYRfbX/F4bsJQIalzWdSDEv3nzobbz35drqRm8tcn?= =?us-ascii?Q?vGR8Eybi7rM6htjXIkZTXPQEoNUuDglsF49wRxtrjIwwQZqY9slxGEUWareB?= =?us-ascii?Q?vfdH6vXLOxz4+xNV55aJtojWJsebCk4UvLAjTx+zm5wpiVpZRVK31o6JxlA6?= =?us-ascii?Q?mKIO5aqmJYIPdnpus3arMMXixjwb2EWxxQ0wJEiQbPxmhDoXbhQh+udT5ZF3?= =?us-ascii?Q?BzSd84Fqkvnga3O+/dDtbYJ5cbOJL5OkIb7XEB5aB8L4jOxdNYgkRxxgHrUX?= =?us-ascii?Q?XOZBlQ0kCYZYlxW/57v0r525nSnIYqle5C2+cuvP+fk4rpz/6lt9atcmJoOS?= =?us-ascii?Q?6qeAnJD7aFRFhbW8N7ePPUGiMTgBK66wX6MQe1JilhBNENVoF+RMxXUIhLnG?= =?us-ascii?Q?wzdnfoVO+j3M9dlWvrY6xgdVjKZlSJyWSCKc5lNg+sKc3hLUlMubpvl7Wy8J?= =?us-ascii?Q?x71l4/tsTLKiBzkIEp+jcDUxYqnBZGnw1nLhGSXsrPrtx6VKBemOySGR+gBd?= =?us-ascii?Q?MyoOqbpCtaBayW+nTOBZzWQjEyaFt4dFQSr0Z+W8ckrn/CBgVWNrIyxZU6Qp?= =?us-ascii?Q?hp4LL3frrA=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7ddf65c-3137-411c-56c6-08df1a7e8f77 X-MS-Exchange-CrossTenant-AuthSource: DB3PR0302MB9208.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2026 20:58:18.6155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O+y03ZeGpq3XaKtwHHOC5sd7RRjDOKI28F+HxW5M3wfYmd/eFY/Z2/FHEivYjncf2jXW/tBrzo4OVIIg4C60Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR03MB10503 X-purgate-ID: tlsNG-d62444/1790283500-1E27A757-4B8DA43C/0/0 X-purgate-type: clean X-purgate-size: 5307 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1790283518209158500 Content-Type: text/plain; charset="utf-8" is_espi() currently changes its result according to CONFIG_GICV3_ESPI. Without eSPI support, it returns false, and its assertion fails if an eSPI INTID is passed. Callers therefore use it both to identify eSPIs and to exclude eSPI handling when support is disabled. Make is_espi() report only whether an INTID is in the architectural eSPI range. Check for eSPI support at the call sites. Use BUG_ON() if the GIC reports an eSPI without compiled-in support, matching the handling of unsupported LPIs. Treat virtual eSPI lookup without support as unreachable, with a NULL return from the espi_to_pending() stub. Signed-off-by: Mykola Kvach Reviewed-by: Michal Orzel Reviewed-by: Volodymyr Babchuk --- Changes in v5: - Explain why an eSPI cannot be handled without compiled-in support. - Make both espi_to_pending() helpers static inline and constify d. - Add ASSERT_UNREACHABLE() to the espi_to_pending() stub. - Preserve the unmapped LPI comment and clarify that an eSPI lookup without support must not occur. Changes in v4: - Clarify the existing is_espi() behavior in the commit message. - Drop the unrelated blank-line removal in vgic.c. - Use BUG_ON() if the GIC reports an eSPI without eSPI support. - Drop the redundant CONFIG_GICV3_ESPI check in IRQ dispatch. - Return NULL for virtual eSPI lookup when eSPI support is disabled. Changes in v3: - New preparatory cleanup requested during review. --- xen/arch/arm/gic.c | 6 ++++++ xen/arch/arm/include/asm/irq.h | 11 ----------- xen/arch/arm/vgic.c | 30 ++++++++++++++++++------------ 3 files changed, 24 insertions(+), 23 deletions(-) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 078049e741..cdae6afb07 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -348,6 +348,12 @@ void gic_interrupt(struct cpu_user_regs *regs, int is_= fiq) /* Reading IRQ will ACK it */ irq =3D gic_hw_ops->read_irq(); =20 + /* + * Without CONFIG_GICV3_ESPI, there is no IRQ descriptor or + * pending_irq storage for eSPIs, so we cannot handle them. + */ + BUG_ON(!IS_ENABLED(CONFIG_GICV3_ESPI) && is_espi(irq)); + if ( likely(irq >=3D GIC_SGI_STATIC_MAX && irq < 1020) || is_espi(= irq) ) { isb(); diff --git a/xen/arch/arm/include/asm/irq.h b/xen/arch/arm/include/asm/irq.h index 09788dbfeb..c29f3d04a3 100644 --- a/xen/arch/arm/include/asm/irq.h +++ b/xen/arch/arm/include/asm/irq.h @@ -66,18 +66,7 @@ static inline bool is_lpi(unsigned int irq) =20 static inline bool is_espi(unsigned int irq) { -#ifdef CONFIG_GICV3_ESPI return irq >=3D ESPI_BASE_INTID && irq <=3D ESPI_MAX_INTID; -#else - /* - * The function should not be called for eSPIs when CONFIG_GICV3_ESPI = is - * disabled. Returning false allows the compiler to optimize the code - * when the config is disabled, while the assert ensures that out-of-r= ange - * array resources are not accessed. - */ - ASSERT(!(irq >=3D ESPI_BASE_INTID && irq <=3D ESPI_MAX_INTID)); - return false; -#endif } =20 static inline unsigned int espi_intid_to_idx(unsigned int intid) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index e5aca17dcb..0ba13e18da 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -62,6 +62,14 @@ static inline struct vgic_irq_rank *vgic_get_espi_rank(s= truct vcpu *v, return &v->domain->arch.vgic.ext_shared_irqs[EXT_RANK_NUM2IDX(rank)]; } =20 +static inline struct pending_irq *espi_to_pending(const struct domain *d, + unsigned int irq) +{ + unsigned int idx =3D espi_intid_to_idx(irq) + d->arch.vgic.nr_spis; + + return &d->arch.vgic.pending_irqs[idx]; +} + #else static inline bool is_valid_espi_rank(struct domain *d, unsigned int rank) { @@ -78,6 +86,13 @@ static inline struct vgic_irq_rank *vgic_get_espi_rank(s= truct vcpu *v, ASSERT_UNREACHABLE(); return NULL; } + +static inline struct pending_irq *espi_to_pending(const struct domain *d, + unsigned int irq) +{ + ASSERT_UNREACHABLE(); + return NULL; +} #endif =20 static inline struct vgic_irq_rank *vgic_get_rank(struct vcpu *v, @@ -698,6 +713,7 @@ bool vgic_to_sgi(struct vcpu *v, register_t sgir, enum = gic_sgi_mode irqmode, * interrupt. * This can return NULL if called for an LPI which has been unmapped * meanwhile. + * This must not be called for an eSPI when CONFIG_GICV3_ESPI is disabled. */ struct pending_irq *irq_to_pending(struct vcpu *v, unsigned int irq) { @@ -715,22 +731,12 @@ struct pending_irq *irq_to_pending(struct vcpu *v, un= signed int irq) =20 struct pending_irq *spi_to_pending(struct domain *d, unsigned int irq) { - unsigned int idx; - ASSERT(irq >=3D NR_LOCAL_IRQS); =20 if ( is_espi(irq) ) - { - unsigned int nr_spis =3D d->arch.vgic.nr_spis; + return espi_to_pending(d, irq); =20 - idx =3D espi_intid_to_idx(irq) + nr_spis; - } - else - { - idx =3D irq - NR_LOCAL_IRQS; - } - - return &d->arch.vgic.pending_irqs[idx]; + return &d->arch.vgic.pending_irqs[irq - NR_LOCAL_IRQS]; } =20 void vgic_clear_pending_irqs(struct vcpu *v) --=20 2.53.0 From nobody Fri Sep 25 21:36:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1790283525; cv=pass; d=zohomail.com; s=zohoarc; b=MHmO+tVOdQXOcdMcPT3tlpTWDxfciSYUJc4M6wAiBCrRqFGqYbDmxqiRoGLgoz7wPIt++wzxsRQniJRwIGpiS1CliuLrvNWutv2bp5uF54HrypxQ1QnuZwSGPXHZBwiZzkgPZJua/JUcj5kTGilVDmpHyawjhUXgPPExgs0GN2M= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790283525; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S1X45a1bjO90dQ/nHOuk0lZMguN6rIuX4USnlTBTDpU=; b=GiCywXOew+ivu/f2sWKDvk1r8lD7NwxCJ6zJ0cyD9Exb7LR9BLzgDWlILIqkVZvrf3wGAOUIs8GD9WVJjU60rcmvkagYa7lkrG4ew8WOAk50pZLAzxoPQwuxNEGLzFYLMhX3J0HANGzjbg7p8SBxXnpA2VtFoNHrL/+3AIL4pxY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1790283524885724.0954317565476; Thu, 24 Sep 2026 13:58:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1433044.1653900 (Exim 4.92) (envelope-from ) id 1x9qWO-00068y-5Z; Thu, 24 Sep 2026 20:58:24 +0000 Received: by outflank-mailman (output) from mailman id 1433044.1653900; Thu, 24 Sep 2026 20:58:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x9qWO-00068i-0y; Thu, 24 Sep 2026 20:58:24 +0000 Received: by outflank-mailman (input) for mailman id 1433044; Thu, 24 Sep 2026 20:58:22 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x9qWM-0005t6-M1 for xen-devel@lists.xenproject.org; Thu, 24 Sep 2026 20:58:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x9qWM-00HWLS-2v for xen-devel@lists.xenproject.org; Thu, 24 Sep 2026 22:58:22 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ab58ea4-8faa-0a2a0a5109dd-0a2a450bd730-44 for ; Thu, 24 Sep 2026 22:58:22 +0200 Received: from [40.107.130.143] (helo=MRWPR03CU001.outbound.protection.outlook.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ab58eed-b7e8-0a2a450b0019-286b828f2f50-3 for ; Thu, 24 Sep 2026 22:58:21 +0200 Received: from DB3PR0302MB9208.eurprd03.prod.outlook.com (2603:10a6:10:430::13) by GV1PR03MB10503.eurprd03.prod.outlook.com (2603:10a6:150:16f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.18; Thu, 24 Sep 2026 20:58:20 +0000 Received: from DB3PR0302MB9208.eurprd03.prod.outlook.com ([fe80::f257:38e:c0af:df28]) by DB3PR0302MB9208.eurprd03.prod.outlook.com ([fe80::f257:38e:c0af:df28%5]) with mapi id 15.21.0451.014; Thu, 24 Sep 2026 20:58:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=meGH4WxeuPVP4MAZTO7adCw6H91j2xa4eIsAQzrF2xGl/tMw7Qjx/HJcjphAZfqDdnkek+3cRtyr2AdyYAJhUR/tT4+n87F0kOMi/unpRimLCNTJnxNTygMwWbYKUg93RXzOdyRuPBGUK2EktcLI10TmkO60/HLWwk8qZA9RT2XPlESgQP7W7rPDXd05XtL2vuNOLbE8wF7P0k1ruRy7nez9vI61WPp0+Fdks8kBggziZAEy9GgtZBvo7KyqtVC3CENjHuZq65rahnBuuOI0aYQZaaPIsHRB6vAQyP1BVzXYaLcVd8enwUjoNYedFkhFOv0gqzT+Sr+AM6G7I5UW5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S1X45a1bjO90dQ/nHOuk0lZMguN6rIuX4USnlTBTDpU=; b=zQVmSuapbvtoL4ahaByiL+fpeya/INXk/QIsQvGO8Y9ub/N9yYhAP2wSpZKRQq2DDngxqnQ5Tvcsi9CF02+ayJQaklaN0Ml2ampIir6PN8PFPzC5/CJVdAHNJphUrj/BAU2l6ErDD4T9Kg6S2+/9dJnFgoJ2mW0wSriPVIai3FpoVyL5xS/E1VlggjY9a48nDRDTTHQrwcxKuY5iyeXW7H/QZga4nhTY2zoVd6QiDFO5LMcoy8+TFQ/qvZxZhi0+Ez1oyErI73JH4776fGQNMv9gFchASy9q7CYhjKwTmLIOL1S9or4yzLa1qedsmGOM5QchMUjaNMH5eeahIqR0lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S1X45a1bjO90dQ/nHOuk0lZMguN6rIuX4USnlTBTDpU=; b=uTMRvf0+yl9WAyAMOe9zEI6GuhObGerZiU3ZSlLN96KWuuCJ9McFOk8JJ6mmobPaC/QTkf0Hl1a4doF6P07ZH5HH25Te8jwMb10xWgFTAhQABFe0Ue6Cg/S7OpYJZNrPf1F97xOJS/XttsrfrdDH6GiZzzccbWOBjVWE3CpdZWE+S/01/r63SOq6QY9P9BcbzyKJE8GZMtAkrR+tZLnaBFhMGlBv3IQSPq45aVDoegM/s+I2J92jSgqhKCq84ifkiCgOKimQ9V6S/4XQYVgIcnnrrCwDqGLRagzNkicUp0wimSjLb+1kmzz6pckIkH/J15aXhilqkgCJCR/w01OHFg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH v5 3/4] xen/arm: validate IRQs before descriptor lookup Date: Thu, 24 Sep 2026 23:57:55 +0300 Message-ID: <1cbd9431b0cacc1406cc1716636a305ebe2b7ed2.1790160605.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA0P291CA0022.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::22) To DB3PR0302MB9208.eurprd03.prod.outlook.com (2603:10a6:10:430::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR0302MB9208:EE_|GV1PR03MB10503:EE_ X-MS-Office365-Filtering-Correlation-Id: c63ba9f8-9213-4955-58bf-08df1a7e904a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|11063799006|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: /6T3SB/1OzZqAI2uTvkFUYH+52QjUY38IZtHUuliEZVPzic6gB+BzfFpIu+0OJQwcdZhofBwchkPySkQBkKTJyh0mquI2Srf8JxNgJ/BBCxWBFD6+BTUMfOfSiKvZV10ixl0Nu01Lw73MxNlE0bSxzfejFJVkem/2mVoM8OltL0se4LN4S1v6mjMS2UVlp0vD1FMA3WOhwbru5+Ye9H4wfQtIJGBhgAcCdQ9embEHDx2WQ5slI0R6/JvZ3M6/rt3fcvNPZmIjwdl3nTb5IXFca0vYIpl7ro7YXgwrI5zFsa16e4ouos4Mi0p5Zjzf70Ty96GPGwBnLYt+3cWkeMyKa/lETSMGd1w2PWfFMUYvEwgHlF0s5xetNcf6Qx0Mhydy0tgShxf5hFz75cBdrVIXOmGcakJR9447fdaemPZYDfvTySwI/Bsj+hzOO16N/okHfJpS0GgEaZSxKElgBGQtL36kzTJngU0Lb/VpHoAz91XVi7UgkaKZBWHf3ZfA1SHrMbKJFDUPeX5AtNs6ExxV7kLi2qrnnSVPMFcJKb/mn2BGdekWWsh++hKih0ATmunlE6nN5Xwca/k3o7uiCz84IWW5LMp91TFUPNuoLYPUb/FY52doXDilF8wDoko6UGSnbpkldY1DwjZZBhJnBC+gUtIuxOhThaNAhCaw8nBd4Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB3PR0302MB9208.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vJJHrM18Iq3R/uRcifIEnrLvgXfWSJ+/SqjfeArE4sOnxvA4EDvo1wevRArF?= =?us-ascii?Q?cbqf3PmZgB1fRQsloIj818Ro2v1VW6MvagLJt0HxT+cG792QpFDQiByJlEeC?= =?us-ascii?Q?g3rfx3aVBk/xT1RowW4KDIrvLN3PRnMvrrX+K1VbHqIQYkkoUlX5bUaIWb1i?= =?us-ascii?Q?IfWGVVhdH4haClMUpT/lTeEDKOiefiFL7jI8ydCD+z8wS205s4N1QG8ZlQAR?= =?us-ascii?Q?2qTI5PLUzy1gMwjleguAUcuU8mHglpM2brVzEQWfH1bj9t10TNzGyjPjtrnB?= =?us-ascii?Q?OwIJ5zVcDNvc8RHx9MNtgPMhxRITASFsMw3Xt9f7Jr+8MZwKFnXBLAgCP0HT?= =?us-ascii?Q?iG6XvwTsmgCHPTLaZHp+HFnIkBhhcub0VzUPdHiu029xxrCiR7//UDC/eG7/?= =?us-ascii?Q?vlUBwynJr4KrQZSW/Uyz2/XvkxYG0OtMDl8IbefllNTV5L1shDpPwqSVsg71?= =?us-ascii?Q?jSVhHgR7RCZxe1aXHVS+39cIyH3wwhusopBvNHrWIHxTN7l7mAnsvK1ZvNpV?= =?us-ascii?Q?FJfc1DQOm5DzRp8UtyExligoFSiXlDgI+HJJf1vP680W1wrwdicQo6ujpdJj?= =?us-ascii?Q?tMQPtJjlDwtUQa0daw/EIB/k7VvI4f6zv8qZIb2lCm8VvnIVnn7p475PRC2g?= =?us-ascii?Q?YJBQgbzoQXWdkPHxCrknvXoQ66dZ3UlHLnnwto9dvqn55lR+iVUkD4V3UKbF?= =?us-ascii?Q?kdSUV9xAmeqUkHyX+h7QRVbPFNslYk4UAzf7JZj6V4Fp1aUJiUjMaipznByK?= =?us-ascii?Q?6U3Y/ZlIWcMPisu2DUCuC7DGLw5pf6n7+o37U5xI7qJ8/ZgnsPd8XVetNtCq?= =?us-ascii?Q?+pqEHpVJTfVpMaVr3yRjfLfHw9ddkM5pCzE7uxFNrbQoLIh34QXjpjFqFeam?= =?us-ascii?Q?wluUoW2BFNH9Ze/H5eGGYnJKAX45cSfFDZbITgn7Nb0HlF/1mgC1o1QL5knA?= =?us-ascii?Q?a/YbjEZVfJI2QeXmqQrbADFHqvPIC3NrzxSj77IQ0tdy+ufisTjuR7376pOC?= =?us-ascii?Q?2koSW3MYskLPj3saC1WD6IZS68WUhoGhyL/qG8sMu1+IGqP1fci8mdBvVHop?= =?us-ascii?Q?eOCkjfQLqiJGsnxYGD868CyibTWor/9GRXljJB2+v8jwtXB+bm1Ve/3cyZnn?= =?us-ascii?Q?J7kog44gXiNRc8FVKXNmhaxnVtzD6N5HYF2Vd6DpvXpycxRAQlREit7/LbON?= =?us-ascii?Q?a4AaIP3LiQ2rLlqPyp4DqekWkmLICsgK1Y41J1qwmHkW4GMABf0tauw3Sl7T?= =?us-ascii?Q?N5xiFzNllNTXf24WveuARzGmWJtzVnamjMrWij6oBP4K3oEQSWa7bXgMIhei?= =?us-ascii?Q?3+jQ85RTLnuCzHv6h7T8Zx646S8dTvOHDTe/atlIOx1PKJSa1BrNlg4yb3Xt?= =?us-ascii?Q?Qb+l3U7QCTmWCGCkU6HtAM1Syu5XOhWD8mNhiBagP/Qd39xhZ3rfrBf924FD?= =?us-ascii?Q?uVYFewnwE7oMXzXfv7RFu7gcrthwpTqEocmf0bMqUlWrRn+03GZK34gFaD+X?= =?us-ascii?Q?3XlM3rY0YYF33gYZzMfg3Ova/3aeuSrnrxyrS25IWEBC1D+KKU/5A7NM39pO?= =?us-ascii?Q?4cy76CIaTr6259s7rYcf6K23REotPkITbZb5P3xR8X1yagQ4/pgLEAqDMwy6?= =?us-ascii?Q?Y0KEGdeG1Ppsc3sqF1OXPc+gvgOyuXoSUH07kUCwuBRY23aMs2gjc+ZdR7Tm?= =?us-ascii?Q?PVMSF5AmkhyDxw0H0gztebxcjj7WzdWMYCA7ogzp1df8pjRQOP37ZaN3x95p?= =?us-ascii?Q?RzzJDLGcWA=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: c63ba9f8-9213-4955-58bf-08df1a7e904a X-MS-Exchange-CrossTenant-AuthSource: DB3PR0302MB9208.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2026 20:58:19.9926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qpnoNm2mODLXOh8cXzFqM7EN3bqOT8tWJCR/Hv0B8Lg6ii0USaoShez3waoppJv1FvGkaB38060itjhM24RMow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR03MB10503 X-purgate-ID: tlsNG-42698a/1790283502-18AC89EA-79862BB6/0/0 X-purgate-type: clean X-purgate-size: 3693 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1790283526144158500 Content-Type: text/plain; charset="utf-8" GICv3 eSPI support makes nr_irqs span the architectural INTID namespace through ESPI_MAX_INTID, but descriptor storage is sparse. local_irq_desc[] and irq_desc[] cover INTIDs below NR_IRQS, while espi_desc[] covers eSPIs. INTIDs 1024 through 4095 have no backing descriptors. Validation based only on nr_irqs accepts an INTID in this gap. __irq_to_desc() then indexes beyond irq_desc[], and callers may lock or update unrelated Xen memory. Reject INTIDs that the GIC reports as unimplemented in setup_irq() before looking up a descriptor. irq_set_spi_type() can run before the implemented GIC line counts are available, so validate descriptor-backed ranges there before looking up a descriptor. Use the same descriptor range check in irq_set_spi_type() and the assertion in __irq_to_desc() to keep them in sync. Log the IRQ number when setup_irq() rejects an invalid line. Fixes: 98f7060b9ed5 ("xen/arm/irq: add handling for IRQs in the eSPI range") Signed-off-by: Mykola Kvach Reviewed-by: Michal Orzel --- Changes in v4: - Share irq_has_desc() with the assertion in __irq_to_desc(). - Log invalid IRQs rejected by setup_irq(). - Drop the unrelated blank line removal. Changes in v3: - Add the requested bound assertion and retain the SPI-only comment. Changes in v2: - Validate descriptor-backed ranges in irq_set_spi_type(). - Validate implemented GIC lines in setup_irq(). - Preserve is_espi() validation with CONFIG_GICV3_ESPI disabled. --- xen/arch/arm/irq.c | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 73e58a5108..8d3517e761 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -85,6 +85,12 @@ static int __init init_espi_data(void) =20 static DEFINE_PER_CPU(irq_desc_t[NR_LOCAL_IRQS], local_irq_desc); =20 +static bool irq_has_desc(unsigned int irq) +{ + return irq < NR_IRQS || + (IS_ENABLED(CONFIG_GICV3_ESPI) && is_espi(irq)); +} + struct irq_desc *__irq_to_desc(unsigned int irq) { if ( irq < NR_LOCAL_IRQS ) @@ -95,6 +101,8 @@ struct irq_desc *__irq_to_desc(unsigned int irq) return espi_to_desc(irq); #endif =20 + ASSERT(irq_has_desc(irq)); + return &irq_desc[irq-NR_LOCAL_IRQS]; } =20 @@ -416,6 +424,12 @@ int setup_irq(unsigned int irq, unsigned int irqflags,= struct irqaction *new) struct irq_desc *desc; bool disabled; =20 + if ( !gic_is_valid_line(irq) ) + { + printk(XENLOG_ERR "Cannot set up IRQ %u: invalid GIC interrupt\n",= irq); + return -EINVAL; + } + desc =3D irq_to_desc(irq); =20 spin_lock_irqsave(&desc->lock, flags); @@ -647,13 +661,21 @@ static bool irq_validate_new_type(unsigned int curr, = unsigned int new) int irq_set_spi_type(unsigned int spi, unsigned int type) { unsigned long flags; - struct irq_desc *desc =3D irq_to_desc(spi); + struct irq_desc *desc; int ret =3D -EBUSY; =20 - /* This function should not be used for other than SPIs */ - if ( spi < NR_LOCAL_IRQS ) + /* + * This function should not be used for other than SPIs. + * + * The implemented GIC line counts are not available when early + * callers configure IRQ types. Check descriptor storage here; setup_i= rq() + * validates the implemented line before the interrupt is used. + */ + if ( spi < NR_LOCAL_IRQS || !irq_has_desc(spi) ) return -EINVAL; =20 + desc =3D irq_to_desc(spi); + spin_lock_irqsave(&desc->lock, flags); =20 if ( !irq_validate_new_type(desc->arch.type, type) ) --=20 2.53.0 From nobody Fri Sep 25 21:36:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1790283525; cv=pass; d=zohomail.com; s=zohoarc; b=ZLieyUFgd9nExTiUFFWKe9vZRAjFiWfM7ScAdgEtHcN5AiTs5z+jlrE5H8ETaBCX0QdI1cgbIWEEa+bLr3WxlB/f8RGoU583TTibvDnr04+2Ct9qaN/pwjfUu1n14tDj7EHjkp731YIXmfOv4nhbgh4Pt8QxQUrfK7oeZ916qAI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790283525; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S2lkmYG7n/ygHugPAF7XixSg3rxPx+xoxz3SzwwUq4A=; b=bjpg/mDDBrzsUmDmp9NGgNhjPIkRBWrWmOZteTA5DfqFnraeUcJixQi40xf6mkuXSan4S94RX9QsuZ69ghK5TiUPYwYCmTMGJh/JZ2kbNY/LrX15yOAoLZukBgfK/6WUUDgtTbe1q8+7k7hrc4O+E/xh+Q4RsVPxTkw48fGghAE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1790283525829803.6161082471388; Thu, 24 Sep 2026 13:58:45 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1433045.1653909 (Exim 4.92) (envelope-from ) id 1x9qWP-0006N5-Bl; Thu, 24 Sep 2026 20:58:25 +0000 Received: by outflank-mailman (output) from mailman id 1433045.1653909; Thu, 24 Sep 2026 20:58:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x9qWP-0006Mw-8K; Thu, 24 Sep 2026 20:58:25 +0000 Received: by outflank-mailman (input) for mailman id 1433045; Thu, 24 Sep 2026 20:58:24 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x9qWN-00066Y-TF for xen-devel@lists.xenproject.org; Thu, 24 Sep 2026 20:58:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x9qWN-00HWJ6-A4 for xen-devel@lists.xenproject.org; Thu, 24 Sep 2026 22:58:23 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ab58e9f-e002-0a2a0a5209dd-0a2a4502901e-28 for ; Thu, 24 Sep 2026 22:58:23 +0200 Received: from [52.101.66.119] (helo=DUZPR83CU001.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ab58eee-6ca4-0a2a45020019-346542773085-3 for ; Thu, 24 Sep 2026 22:58:23 +0200 Received: from DB3PR0302MB9208.eurprd03.prod.outlook.com (2603:10a6:10:430::13) by GV1PR03MB10503.eurprd03.prod.outlook.com (2603:10a6:150:16f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.18; Thu, 24 Sep 2026 20:58:21 +0000 Received: from DB3PR0302MB9208.eurprd03.prod.outlook.com ([fe80::f257:38e:c0af:df28]) by DB3PR0302MB9208.eurprd03.prod.outlook.com ([fe80::f257:38e:c0af:df28%5]) with mapi id 15.21.0451.014; Thu, 24 Sep 2026 20:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FZF4JepcOw763500uSu/hpe9KrjlsR5DxLumocDnDjJPfTx/zdqNEljc2nYDaSUwi7PGsouMbUqo3Ptjf3PWP8dG+e3WnWcm+0E3hgSpdTjJ9tGc9wW2pGahHywN7ioLTQa8BmOJ2VBI7XWxOBBqfjSDdHzhA23NyRCRPhuWeq+k2IjbswnwKRxbTKKhPrQz9vAAnAWrt3rQ++WnLlVHCcOGnSWgH2G6RQpP09mVtdhmWnMoTBhZAs2A/+LP7SpaXBeBMGgtT6A3om4yICUBlLGSRqWu6pGp9csxR/0Ho9tbqVm85ksfHE0dz1g2Gi4xWCFFj3cVHB9kmDgMlkBeCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S2lkmYG7n/ygHugPAF7XixSg3rxPx+xoxz3SzwwUq4A=; b=gu/a+pFbwdPLDgtgaitaS+DGxuX6BtWOUeiSoNZgM0+Po9uBdHhCus19exaPkOCENhiTTQ11tYX+hu5U6Vjhdi7y2SKoKGc8y02L0yYGgjegaaZuCMK1itD4WSSOMY5PZ+EsOmHnqGme4mBsE4ZxoGWCFQnTEtYCMFvLe1mdzsDbrONhyp0xe8Sy6uEOuVsGWG/LQeDJqAgSvdZ24uYUnH1V5i0dJWTcgBp6Y9L1wlKm4XIvpC1pMKOcd9O7fAZBcKjrSgkXn5xIKST3QcxH0XMnIxpvPVUvQGATYiq5htJCgwnS9GbtNk0dLrLGEpBqgQcnhZZclWc0h/ycB4UKpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S2lkmYG7n/ygHugPAF7XixSg3rxPx+xoxz3SzwwUq4A=; b=LmUZzgx6IfigCIvLDEu6u/REWpqjw6IARYvIwLf/e7LHwzMWm022+oSbKenj3dVd/P2sPDIiZqA4MpMvGN88VGlvicX5X5tU5n9pfvpSqNmgRAhsZiys5A26SC7Es7g0eB9vUfXeLv3zId/27V91pWx9CFm3cf2VAVk/U9fn7TtU/nRJ21VIjcRp+EcR80OWMkzkFonLuJ7zjLaa3FtWO2HD9hnztEr65G+xidTEbTZ1/2DRR71ydWNdR5qTgp4ByEp7mH9UM2iyw8C9D6Te9gwijBPkmFpeedsHADAr8Fgjr9dd76EQ6UisnkglPRSUFmFOHHJXRMYZJg5F8Cjdyg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH v5 4/4] xen/arm: vgic: free eSPIs using the bitmap index Date: Thu, 24 Sep 2026 23:57:56 +0300 Message-ID: <8c61cf31b69377737d1f688bded43d123ac55d00.1790160605.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA0P291CA0022.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::22) To DB3PR0302MB9208.eurprd03.prod.outlook.com (2603:10a6:10:430::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR0302MB9208:EE_|GV1PR03MB10503:EE_ X-MS-Office365-Filtering-Correlation-Id: e722cc51-7bf7-435a-5f8a-08df1a7e9118 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|11063799006|56012099006|10067099003|22082099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info: 21UexnDn8z+7il3TUWVxXY4u2DdhvoBu9QfkJFiRXSuwDhsBXj64QvheeIqoLpUdevetUyS0cBxbPtSL55OsSKdor5pGA1HrpbdxLP/9klLARWxDuV5sDv6Cqp3reHd4Qh4NqzB4yW96v666U/Q1DjBro1bvwZBf4+maiojanq+QK5CCkwQYKtzrfb/+6jrrIIWCxV9+/5aqKnU17ko/z3lM5Di96fHWz/ynM+rI79o0jVIDmRyP1CAZRgNIJYj40Vm55JksdvKd6cEKvpQu6tQ5P/hpUcoufRsywuc27W2PaE01xc4S4xcUmdXYDgrUySdjHtqLx1Apqruh9NO2sJ+4Y/Oauqt8Qky0V0yigI0HzvU+VPIa/3jTLQYW5FPeMIJbdObu0tk5/fcTIthU/bcUwnFktnEPI/gs9x/ajCY5PNlCrFcJkRGs35MqGS89UAAoKo0sBjxOYT5GWBZAyLzjVpqyNwZb0iyPZhzVMf9PXkQ96GCmX5xNLSSAxZ2MSj2eJNZyWxQ+DDDFXFjvfEoTaJv5JjC3A2vkt6/yd/Vor74zBUJn1kLq973W79mWYz51CsGhdZnFlBmG9iX0BGkeiFQx0fM1n6FGRcASMOlKFu4OGE2AGdxgmghBFETG6qdYeJ89w7vVmEKTMNLhJGDO0ArGOoIpeRiKofjAyBc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB3PR0302MB9208.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Fo6khaXhSFPvxngmiZTTRkWTqeTS1eZtt1lDCLOYdb6VXxny46WodMZKqzhF?= =?us-ascii?Q?MZYpGkppPbGmQSNp+A+KXEbwPgNccd1sO+06nj1o65eh4zF4hVMNedPhxpsh?= =?us-ascii?Q?6vLci+QPbgqSRmI4P0rSq0jd2bwH3hf9N52dLY8jDRQ0cNjDLJM7vL4mUk+N?= =?us-ascii?Q?5rL/DBpc0pPGXvIsfAG9Wo4NDBAS6IYLIyshcTKrV8qhgE6WkWd1K7suL1OB?= =?us-ascii?Q?9kEYzWcBJ496bbjje/KHI/IlukesGLU9s9/FWKUhvhaWFMxrl9IeK9vFdb7q?= =?us-ascii?Q?dIs2M0qNfBDUzb4C0qdOQJko+nFcHtQNHdAC9zmtl06QEGdqldCIxw0knU4J?= =?us-ascii?Q?53I2YNNjniXYu2d9YGBhRnIXsFRxICHeWcIxOP6ORWqib1hJDBwmb7u3ht3p?= =?us-ascii?Q?Q1l41yF1oezLIEwTOlD+8NMiOLUew00rjuHDJ4nkniOVehI6vmi2QTi96Efp?= =?us-ascii?Q?DDryVLN8dx182D25+oqVkj6Wr0P6qefjerdVKesS86icY+d9LenTxwKqEdwo?= =?us-ascii?Q?0lNuIP3WSj+sUDEx6Kt5ZsjwDd85lySA+ILcZoZZGq0to7hlpzb8IJw4m3S6?= =?us-ascii?Q?yHbI/iHqjzRbbgf43I/IM6CEyyUg25Qt6E2WAtkB9NXmDxpq6nDT5DuNvrI5?= =?us-ascii?Q?XU0/ilMZhVl1E+XGACc3aTQt76Mj8Mvjw2VE3aaZbMtr5fIYI1iFYXdwpwfi?= =?us-ascii?Q?2saHlEnuKUcgVSBRNJQWERrdSiPxT16zo4/OaQspHAu5rvG9aHqoZ8x2F357?= =?us-ascii?Q?Tcc39wehUGWdk0YKza7qjZpvCVSMVuOKLnGfSnaK0tIcMfYafFr2KFDXDUfA?= =?us-ascii?Q?o/7c2X+8NU6siS+7iSYi7zKvuVrTFJpgHdZmpo9h0hTfzayvibpePui4RSbB?= =?us-ascii?Q?oeNuXqnSBfNQE2Lrs5/F5/36ewBVs9PrAT/Nzq+K8esIIXx6lr6/423RiCvE?= =?us-ascii?Q?uA+TbqwvfA6Nob/T6woZRfllAmQ0OajW3Inr6T1ZcdLOCENxISxWz56zjWUf?= =?us-ascii?Q?nI80kf+6ElNHkEy4/meYhZZp0z2zZiUErv8fks9Tx7vEMIAL4vdG6eRSE2i3?= =?us-ascii?Q?dIp7iaIG+7AdpubK9Fx0pkPDZFupFZbo8rv0UrdHGCGJ/XVDYqZcAWuTfukS?= =?us-ascii?Q?gNHvTpcLxe+B0knqHgZGwrmtUHxPsKUcQEkEaWTRqbIXTWgzDlRXaGDFuxT1?= =?us-ascii?Q?RSQc7HMfqKcq3xB5dOX/BTRBGxbK6HSzGkQyNx4lEH7ZLMmRNLyzEXLKeOxO?= =?us-ascii?Q?Z+iy9WJ/r2/M2/8wO1Brljmxf23DTH/jvH5IWA66R5J7L4vdUVYyB3FVpzai?= =?us-ascii?Q?Aw80RubBTPqnaRuj7ncPJLSxSO5tnfda494QuMw3hQSbCGuZrkf8m/TQds2R?= =?us-ascii?Q?tBEaj5iAaGxK2OhqnT9cuUeaGCY2djfIj/hFeiaWmVIFh3QjpZCQWKtGvKIM?= =?us-ascii?Q?nj5DPnhCtbn7Anbv9bsspHaMfiLHHnE2UVEgdeYbo+vHT2OoRXdUKz9Kwdw2?= =?us-ascii?Q?iBq5XTim9O6aTqNyBafDoj5RUD39dCi8HyB9Fj1EOqy/ThpodMtFRrDejKAr?= =?us-ascii?Q?Ox+EjAgQMI94WQAlooY2WXIfjmXfEHqCgcHDlLf2KfHRoNzUNZvH7Mhlurjr?= =?us-ascii?Q?pl8eKtlpGn2BO6ioKHc/7kJQ9czCXeKykDiklyBUymhKiKz0YkGjNE3wU03O?= =?us-ascii?Q?/pW5xM8u8AsvXxUMBaXVdo4IMl372o4rp23lRDtMFAyMkfzM+aE3sRfDESjd?= =?us-ascii?Q?KTGxpb1t1w=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: e722cc51-7bf7-435a-5f8a-08df1a7e9118 X-MS-Exchange-CrossTenant-AuthSource: DB3PR0302MB9208.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2026 20:58:21.3556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +zGqKfQwZA+8/tDR6B3Ix3kE+UCinS9VsQt7aRvP0f7Z6G/pxFmjrRL9pVmWGXScPQucaiJvUauHTLdpmsGviA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR03MB10503 X-purgate-ID: tlsNG-720697/1790283503-F10A02AC-A3A39AA6/0/0 X-purgate-type: clean X-purgate-size: 4869 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1790283528329158500 Content-Type: text/plain; charset="utf-8" The allocated_irqs bitmap in the existing vGIC implementation stores eSPI allocation bits immediately after the regular vIRQ bits. vgic_reserve_virq() converts an eSPI INTID to this compressed bitmap index, but vgic_free_virq() used the raw INTID. Freeing INTID 4096 therefore clears bit 4096 instead of the first eSPI bit. This writes beyond allocated_irqs and leaves the intended eSPI bit set. Valid eSPIs reach this path during DOMCTL bind failure cleanup and unbind, and during vPL011 teardown. Add virq_to_idx(), the inverse of idx_to_virq(), and use it when reserving and freeing vIRQs. Use vgic_is_valid_line() for the validity checks when reserving and freeing vIRQs in both vGIC implementations. Fixes: bdde400c6e1b ("xen/arm: vgic: add resource management for extended S= PIs") Signed-off-by: Mykola Kvach Reviewed-by: Michal Orzel --- Changes in v5: - Add the vgic_is_valid_line() guard to vgic_free_virq() in the new vGIC implementation and use the same helper in vgic_reserve_virq(). Changes in v4: - Document the compressed bitmap layout with an ASCII diagram above the conversion helpers and refer to struct vgic_dist for the full layout. Changes in v3: - Adapt virq_to_idx() to the configuration-neutral is_espi() helper. Changes in v2: - Call is_espi() without a configuration guard. --- xen/arch/arm/vgic.c | 42 +++++++++++++++++++++++++++++----------- xen/arch/arm/vgic/vgic.c | 5 ++++- 2 files changed, 35 insertions(+), 12 deletions(-) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 0ba13e18da..acded6a40f 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -25,6 +25,21 @@ #include =20 =20 +/* + * The allocated_irqs bitmap is compressed: eSPI bits immediately follow + * regular IRQ bits, skipping the gap in the INTID space. + * + * +-----------+-----------+-------------------+-------------------+ + * | SGIs | PPIs | SPIs | eSPIs | + * +-----------+-----------+-------------------+-------------------+ + * 0 16 32 vgic_num_irqs(d) + * + * INTID ESPI_BASE_INTID maps to bitmap index vgic_num_irqs(d). + * The following idx_to_virq() and virq_to_idx() convert between INTIDs + * and bitmap indexes. + * + * See also the allocated_irqs comment in struct vgic_dist. + */ static inline unsigned int idx_to_virq(struct domain *d, unsigned int idx) { if ( idx >=3D vgic_num_irqs(d) ) @@ -33,6 +48,16 @@ static inline unsigned int idx_to_virq(struct domain *d,= unsigned int idx) return idx; } =20 +static inline unsigned int virq_to_idx(struct domain *d, unsigned int virq) +{ + ASSERT(IS_ENABLED(CONFIG_GICV3_ESPI) || !is_espi(virq)); + + if ( IS_ENABLED(CONFIG_GICV3_ESPI) && is_espi(virq) ) + return espi_intid_to_idx(virq) + vgic_num_irqs(d); + + return virq; +} + bool vgic_is_valid_line(struct domain *d, unsigned int virq) { #ifdef CONFIG_GICV3_ESPI @@ -854,19 +879,11 @@ bool vgic_emulate(struct cpu_user_regs *regs, union h= sr hsr) =20 bool vgic_reserve_virq(struct domain *d, unsigned int virq) { - unsigned int idx =3D virq; - if ( !vgic_is_valid_line(d, virq) ) return false; =20 - if ( is_espi(virq) ) - { - unsigned int num_regular_irqs =3D vgic_num_irqs(d); - - idx =3D espi_intid_to_idx(virq) + num_regular_irqs; - } - - return !test_and_set_bit(idx, d->arch.vgic.allocated_irqs); + return !test_and_set_bit(virq_to_idx(d, virq), + d->arch.vgic.allocated_irqs); } =20 int vgic_allocate_virq(struct domain *d, bool spi) @@ -903,7 +920,10 @@ int vgic_allocate_virq(struct domain *d, bool spi) =20 void vgic_free_virq(struct domain *d, unsigned int virq) { - clear_bit(virq, d->arch.vgic.allocated_irqs); + if ( !vgic_is_valid_line(d, virq) ) + return; + + clear_bit(virq_to_idx(d, virq), d->arch.vgic.allocated_irqs); } =20 unsigned int vgic_max_vcpus(unsigned int domctl_vgic_version) diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c index ba029b8a3b..84212bbefe 100644 --- a/xen/arch/arm/vgic/vgic.c +++ b/xen/arch/arm/vgic/vgic.c @@ -712,7 +712,7 @@ bool vgic_evtchn_irq_pending(struct vcpu *v) =20 bool vgic_reserve_virq(struct domain *d, unsigned int virq) { - if ( virq >=3D vgic_num_irqs(d) ) + if ( !vgic_is_valid_line(d, virq) ) return false; =20 return !test_and_set_bit(virq, d->arch.vgic.allocated_irqs); @@ -756,6 +756,9 @@ int vgic_allocate_virq(struct domain *d, bool spi) =20 void vgic_free_virq(struct domain *d, unsigned int virq) { + if ( !vgic_is_valid_line(d, virq) ) + return; + clear_bit(virq, d->arch.vgic.allocated_irqs); } =20 --=20 2.53.0