From nobody Sat May 23 21:03:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1779389029; cv=none; d=zohomail.com; s=zohoarc; b=IWIVXGeUGJ+4PeIL2gCGycGKIEEUS0uUowgdTslj45a14zcm96VW9pPMjsswvykb+rBuCMmoUghKgMEhNHKypANp5e1nWsDv9TuSE+pEU3xRPJ0Kbs/gzvoMi2PzfuyaDr3BHENnoW2KYtaFSKL6D4EPl3kyxjCyRla7tZWA1t8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779389029; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ljEMYEkr4A++xDwBUmB/QQXR4E0ZeG++aH7cfc2SFig=; b=hH4kYkedNcGLrDwXd6o2oluihM+kPWy1UTr6VI1DNu6vPlhET+6roqNNBPMuSjHkHOpK1dmRnCBZ9mYT4f6WwlbM1bC1d6VQOIMwRNhWlK37smFF+wCsk35fIgrL/F/D6SilCCyBc1qKe1gYqxjcWj+M0gvwAAXSIVZxWPp796M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1779389029827677.1994901414013; Thu, 21 May 2026 11:43:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1315794.1585485 (Exim 4.92) (envelope-from ) id 1wQ8Mk-00036F-Le; Thu, 21 May 2026 18:43:30 +0000 Received: by outflank-mailman (output) from mailman id 1315794.1585485; Thu, 21 May 2026 18:43:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wQ8Mk-000368-G0; Thu, 21 May 2026 18:43:30 +0000 Received: by outflank-mailman (input) for mailman id 1315794; Thu, 21 May 2026 18:43:28 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wQ8Mi-00032y-SU for xen-devel@lists.xenproject.org; Thu, 21 May 2026 18:43:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wQ8Mi-00HU6L-8W for xen-devel@lists.xenproject.org; Thu, 21 May 2026 20:43:28 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a0f523f-e002-0a2a0a5209dd-0a2a450add6c-28 for ; Thu, 21 May 2026 20:43:28 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a0f5250-56b3-0a2a450a0019-d1558033e549-3 for ; Thu, 21 May 2026 20:43:28 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48e8132c6d0so42393015e9.1 for ; Thu, 21 May 2026 11:43:28 -0700 (PDT) Received: from EPUAKYIW02F7.. ([45.12.24.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49035c6766fsm42558855e9.2.2026.05.21.11.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 11:43:27 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779389008; x=1779993808; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ljEMYEkr4A++xDwBUmB/QQXR4E0ZeG++aH7cfc2SFig=; b=c9lAF4n8wFvBWvBIYGmXLRJyvESG7eCY69h5hGWKrX+KRfvY5wFM2n845SOHuir3sB LvYyRLsLfTKTakKhzGhy2WOUdzKk+YuEY6j4jlnNqXqRcGirpZ0YDUXCL+Jw2DSl+1AE guySLor4zdcN8P4n6rVe0G7B1oRYHtMfoxLC1TOelpDSh7YTh4OFSblfZWPkuCKR1oxG 7TcS2vMlHhSKTX5mTQgcIbAft1nby8lnFk6TFMU/oJ6ol160UbdbAm9hJMMOr7FsMa5s fyBQi+VmLbBJwUlJUHfOCC9jR0GZ4h4rmacGv5nBHzr7Yt4J3MS/yWKHY3uOM8pYWw2X MUTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779389008; x=1779993808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ljEMYEkr4A++xDwBUmB/QQXR4E0ZeG++aH7cfc2SFig=; b=I13g1mONgxE2aZCPdhTBFfpDPRADI1NmV41fElRv+aWdaxDf/AW36K+kUTFSvOWVhX 313eDU+T6z3zORdYypP7q8uxen1ElcXFJvF09y6GhOGIC2lY3aSxCZNlVSEHXYmp81IQ DzcwnX8nc1wrDEpAUHgD2HwjpQ1kfNE8OLkfbEE6VJ4rqWS+/IKvBtEmsB+WRpogo3Gq F7a8bWGH7aUma2HqooVPhL47MkrQJFlVA1xTFeWqGD4jA0Wrf2mdnN9vX5CKZ0nDuV1s ABUO5I99eKJqYvvVaH2uw9+CTPqeVW4ENU06XI/NPNqA1Btb1Tm90NCEupHgh9zaW3Fy MCNg== X-Gm-Message-State: AOJu0Yxrd/7hiFzZmKINIXJ8OW5X7NowrvsDKVtnnjd6a5NsdmlnLRwr D762mp0m61EsqloV1gVahLphCgSypnhN4hnl+WKAP0XJ1SrXDU3t9icPcTxW5VNl X-Gm-Gg: Acq92OEi/urH8hgu8P7Mt96F1ohKEuXapqQ+QPDgoMC64s7WCvOmSE0BBtEGH339JoR GF88rYPDjAn0JqRr5QGxdEWxkBwW6+tL9TEWzk57E+Q/WZ1LuhmdAW4Y0BJ3VHJ91lxRmXGWBeK JB2zpE2b4cv+vgwdMThoMs+8tAC11LEEYUSvlQz76eLDgf29rX4ajJhxbrUTnrVp5RNlot6bPDc etn4k0uIYcCQ3UBfA2dX/NzI+HG8FmN5WkV0BuipcnITN0YJDXO//tCJxMxwVqJxWDDqoClPUZz kBSkGPfTrZmldAYC71Y662YiVRY3o0HLwQQWd21RhzyUth0IyrvulCy4lT8NyzHEJp1DlX0GB6S Ej0+Wd4cPavg9511U/kkujti/Ss2XNIMddE7teQWCmhfiwKiEnFyCIx/oiFXObRL/hLqDxMusmc OtjI8834cE2OS3b+/dkaTJN5q4EZ2YPJWlQXlp X-Received: by 2002:a05:600c:4fc9:b0:48f:fe2a:107c with SMTP id 5b1f17b1804b1-4904248ac8cmr185605e9.6.1779389007490; Thu, 21 May 2026 11:43:27 -0700 (PDT) From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Carlo Nonato , Marco Solieri , Luca Miccio , Mykola Kvach , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Denis Mukhin Subject: [PATCH v2 1/2] xen/common: llc-coloring: clear color count on parse failure Date: Thu, 21 May 2026 21:41:21 +0300 Message-ID: <61c93d1364b24f19215db24f4ca88cf7a5014f24.1779388510.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-4011c0/1779389008-7015A8B7-563894AE/0/0 X-purgate-type: clean X-purgate-size: 1898 X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1779389031239154100 Content-Type: text/plain; charset="utf-8" From: Mykola Kvach parse_color_config() updates the caller-provided color count while parsing. If parsing later fails, leave the count at zero so callers do not consume a partially parsed configuration. The bug is reachable in practice: cmdline_parse() ignores the -EINVAL from a custom_param callback, so boot continues with the partial xen_num_colors / dom0_num_colors that llc_coloring_init() and dom0_set_llc_colors() then consume. Fixes: 6cdea3444eaf ("xen/arm: add Dom0 cache coloring support") Signed-off-by: Mykola Kvach Reviewed-by: Michal Orzel Reviewed-by: Denis Mukhin --- Changes in v2: - Clarify that the partial color count can be consumed after a command-line parse failure. - Add Reviewed-by tags. --- xen/common/llc-coloring.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/xen/common/llc-coloring.c b/xen/common/llc-coloring.c index 6dc614739a..2606cb0977 100644 --- a/xen/common/llc-coloring.c +++ b/xen/common/llc-coloring.c @@ -79,7 +79,7 @@ static int __init parse_color_config(const char *buf, uns= igned int colors[], if ( end >=3D NR_LLC_COLORS || start > end || (end - start) >=3D (UINT_MAX - *num_colors) || (*num_colors + (end - start)) >=3D max_num_colors ) - return -EINVAL; + goto fail; =20 /* Colors are range checked in check_colors() */ for ( color =3D start; color <=3D end; color++ ) @@ -91,7 +91,14 @@ static int __init parse_color_config(const char *buf, un= signed int colors[], break; } =20 - return *s ? -EINVAL : 0; + if ( *s ) + goto fail; + + return 0; + + fail: + *num_colors =3D 0; + return -EINVAL; } =20 static int __init parse_dom0_colors(const char *s) --=20 2.43.0 From nobody Sat May 23 21:03:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1779389038; cv=none; d=zohomail.com; s=zohoarc; b=kWw5eLLkSt5RQLNJ2rS4XZtKSaIvGvFI2Fw3PNG77XoWLOBaFzJcNpcJISbuIUKdo0HyYNPoscGzD7kIyohqnzfwb4dfTERpYez5iT2dEDL0gLVq+wy2Iz+KshOO7jCsts3sMrlsEgLW8tH65U52BQEYirt4AOf/pbJbXNC3JIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779389038; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=de30ilZc1Pk5ATstxlEw7kAS0ReXrVMylgNlp1/IE6M=; b=cKemebYEz5e7kS4U+dHDNtYJamYNAn/TwlGZ57EP0v7Vm6B2EoIsYC5m21vtg60ljsB1tD5Q9Hl8zP/jL/1CL3RLx7HO/IHcd7jWH+NYfh8zKmi5Kc4ZI2s+zdWMj8/dCsfHVkRNE7Kd7I/AkmMK8yrbcxC9IXZ6va/mBJU8QEY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1779389038013280.00078190923136; Thu, 21 May 2026 11:43:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1315795.1585494 (Exim 4.92) (envelope-from ) id 1wQ8Ml-0003FJ-27; Thu, 21 May 2026 18:43:31 +0000 Received: by outflank-mailman (output) from mailman id 1315795.1585494; Thu, 21 May 2026 18:43:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wQ8Mk-0003DH-SF; Thu, 21 May 2026 18:43:30 +0000 Received: by outflank-mailman (input) for mailman id 1315795; Thu, 21 May 2026 18:43:29 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wQ8Mj-000334-LX for xen-devel@lists.xenproject.org; Thu, 21 May 2026 18:43:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wQ8Mj-00EkKx-1m for xen-devel@lists.xenproject.org; Thu, 21 May 2026 20:43:29 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a0f5228-5cb7-0a2a0a5109dd-0a2a4508df64-48 for ; Thu, 21 May 2026 20:43:28 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a0f5250-63b5-0a2a45080019-d1558032e55e-3 for ; Thu, 21 May 2026 20:43:28 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48e8132c6d0so42393085e9.1 for ; Thu, 21 May 2026 11:43:28 -0700 (PDT) Received: from EPUAKYIW02F7.. ([45.12.24.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49035c6766fsm42558855e9.2.2026.05.21.11.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 11:43:28 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779389008; x=1779993808; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=de30ilZc1Pk5ATstxlEw7kAS0ReXrVMylgNlp1/IE6M=; b=aJPXv+tP/CNHQJe4rAx+OcaMg1unpfB9hsXCf81wXnc9xUbMCHBvz28pqh+t3zv2cl dPyIVjjjF7LnVJl6/Hzat7Orr75xBFm++dONdxmoIbUJhRRaHu5Y5+nSvvnzbUudZkV9 2SUfSJmEtbb28GbGROzUA5pBW1omQVdJSAi3zp9FmgtyXiuNzR5f4OUlQM7bnc/qXKas AEluoINNpWu1uRxjvvwfk/jB5sBEi8qdYMMCIXqrPhiCNHiWh9JZviiSmgyAhdNOGPLf jCbA2bDkQWrKd5/lNSY+zoBvtR2qoz7QGPyVZcBCFnvtIGj4yrQY7F7HhpMm1De1+XgC MhpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779389008; x=1779993808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=de30ilZc1Pk5ATstxlEw7kAS0ReXrVMylgNlp1/IE6M=; b=X+/xj//cYcBjk4lKUjhrpfLg9Zg3s3i/u/hT0VFb2uR7DxKI8WfzNw6RZRLIaxoBYv Z5gjTN/uQRau8tqYAHYgLOuqyvNncotRJeN3HRiX4rWiUxf7phEzbaHPphITMh+6ucEm PHjhVhbTk5E44pKgrkDeXnheNiKDu4AnIV2LBZpE/a//zrL3SudBjZzIKF+vTKbcSMxq 1MFRPinqD5QVHdHunVSoSIenKLjfxDanGSCFwgacUBUohFYggUm4jfxAbtvBWUr1TMql uBtXqNi8So0Jj6FHSPbb+cepylBdiehBFlFryBdE3AsV0fJIAh6QfA9oSIYUJ9ilQhus ij7w== X-Gm-Message-State: AOJu0YzqgGyhBlOUuh2bQm07BMTAGIEwApp8VXhMF+53xfPPLfg7fRqK S9zywd9xeuiXs4gPMNEq9bXVfgGZhjY+9DtAFd+K+9oHus7nSj41ZmXpFAJCHo1w X-Gm-Gg: Acq92OGs6aL++l7N4rvuPjAr901PLYHJYIOQAl9+WjjCwkYTZZ5MMfqzlI1ZGOxoHmX wKHt2+8gsc1KNGNH6z09jOx5D7DCieb5s7eMIWLGenFdqKcEVXhdCfIYdwD483VPXQejr9gOfZY SRzy4Whzd8fLpu3RDBkFUFP/gnQNgaCLgjfJojgGzthhjDdsmExi3ZCYg7Nk9lEKjMHjvQLmopl OTxn3v+8P4x5BjWxUtbdLTedUGL8+E3huaTK/PCSx7LpP1HS9339cuk3PyRPMUUlg4nWmpx8LrL hqbCLKABA/DcVsJcdfzSHeiBhHqBljV4nqLNxq8PqNyUQdGVdYmO5W0z3DIyIl5N36e575G2NpG bNv7yKcjBFNDbYB1KViCtDRZ8KKxdF/nRbnEM3D5557TmelajVJBwVmDE99VK/XO11Kkcl+QSkl 9T0Q6CsZtMkTrumW0fHYOp9263Ww== X-Received: by 2002:a05:600c:4649:b0:48d:35e:84a0 with SMTP id 5b1f17b1804b1-490360b366cmr37723645e9.28.1779389008391; Thu, 21 May 2026 11:43:28 -0700 (PDT) From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Carlo Nonato , Marco Solieri , Luca Miccio , Mykola Kvach , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v2 2/2] xen/common: llc-coloring: reject empty color tokens Date: Thu, 21 May 2026 21:41:22 +0300 Message-ID: <94d7290edbda36c652579b625acaa4d7cdf1aa68.1779388510.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c1860d/1779389008-BFD7BDB1-6B4CC5E8/0/0 X-purgate-type: clean X-purgate-size: 2155 X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1779389040182158501 Content-Type: text/plain; charset="utf-8" From: Mykola Kvach parse_color_config() currently accepts delimiters where a color value is expected because simple_strtoul() returns zero without advancing the input pointer. This makes strings such as ",2-6", "-10,19-20" or "1,,2" look as if an empty value was color 0. Also fix the DT color parsing error message by adding the missing newline and including the domain ID, matching the style of the color validation error below. Fixes: 6cdea3444eaf ("xen/arm: add Dom0 cache coloring support") Signed-off-by: Mykola Kvach Reviewed-by: Michal Orzel Reviewed-by: Denis Mukhin --- Changes in v2: - Include the domain ID in the LLC color parsing error message. - Add Reviewed-by tag. --- xen/common/llc-coloring.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/xen/common/llc-coloring.c b/xen/common/llc-coloring.c index 2606cb0977..b5de5787c1 100644 --- a/xen/common/llc-coloring.c +++ b/xen/common/llc-coloring.c @@ -64,14 +64,21 @@ static int __init parse_color_config(const char *buf, u= nsigned int colors[], =20 while ( *s !=3D '\0' ) { + const char *endp; unsigned int color, start, end; =20 - start =3D simple_strtoul(s, &s, 0); + start =3D simple_strtoul(s, &endp, 0); + if ( endp =3D=3D s ) + goto fail; + s =3D endp; =20 if ( *s =3D=3D '-' ) /* Range */ { s++; - end =3D simple_strtoul(s, &s, 0); + end =3D simple_strtoul(s, &endp, 0); + if ( endp =3D=3D s ) + goto fail; + s =3D endp; } else /* Single value */ end =3D start; @@ -334,7 +341,7 @@ int __init domain_set_llc_colors_from_str(struct domain= *d, const char *str) err =3D parse_color_config(str, colors, max_nr_colors, &num_colors); if ( err ) { - printk(XENLOG_ERR "Error parsing LLC color configuration"); + printk(XENLOG_ERR "%pd: error parsing LLC color configuration\n", = d); xfree(colors); return err; } --=20 2.43.0