From nobody Fri Dec 12 19:32:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1764967030; cv=pass; d=zohomail.com; s=zohoarc; b=JAds331PMZTPk9kE0nrIqVpRNRr4pDFDYrN/I5XasMVvJPIS19OyUOWLF3Ywq9mFjnBCrk1r9RbqEyijwqicXymXCBO7X0XeMRORzonGXHl9XpDjzY2xQ4f4Ppl9NuWcWlmhlrE1vX09pBcme1l8Wm8Q+V5fm3ktCAl01+culF0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764967030; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=H9U3lVm3LdZ4OeMGAuKbjx6qHerHHmDtfUlIblUbFDM=; b=hD8foo2e7KxWX8tUTgLNygLnQczxT7I2/cTpS+antjowyH3dFNTqf4roXk14gAO6Wfrd4ZpoOeR5+NsErqL3iTnH+LAPdBeFHYTTgERnJFsemcbtKG++J2o49NCPm7YQQGB/jbNcRm64QTUzhlpuzlqki3HUhVOZHWaPWRToXlA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1764967030938369.7441067249882; Fri, 5 Dec 2025 12:37:10 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1179432.1502934 (Exim 4.92) (envelope-from ) id 1vRcXm-0006cP-Vn; Fri, 05 Dec 2025 20:36:46 +0000 Received: by outflank-mailman (output) from mailman id 1179432.1502934; Fri, 05 Dec 2025 20:36:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vRcXm-0006cF-St; Fri, 05 Dec 2025 20:36:46 +0000 Received: by outflank-mailman (input) for mailman id 1179432; Fri, 05 Dec 2025 20:36:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vRcXm-0006OM-5O for xen-devel@lists.xenproject.org; Fri, 05 Dec 2025 20:36:46 +0000 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com [2a01:111:f403:c201::3]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ce83b1a-d21a-11f0-980a-7dc792cee155; Fri, 05 Dec 2025 21:36:44 +0100 (CET) Received: from AS8PR03MB8322.eurprd03.prod.outlook.com (2603:10a6:20b:509::16) by AM7PR03MB6182.eurprd03.prod.outlook.com (2603:10a6:20b:140::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.12; Fri, 5 Dec 2025 20:36:42 +0000 Received: from AS8PR03MB8322.eurprd03.prod.outlook.com ([fe80::e577:995:fb9d:38fb]) by AS8PR03MB8322.eurprd03.prod.outlook.com ([fe80::e577:995:fb9d:38fb%5]) with mapi id 15.20.9388.011; Fri, 5 Dec 2025 20:36:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ce83b1a-d21a-11f0-980a-7dc792cee155 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CKm3mAZ7hEXoJ5rHtfeeOU728sqESQjmyFUgxNxkDYnGE60w6EUeoLP/fPtYzZc1dkdtQuVRkrjvHS92m5mVvvq0mSMTOyoqgTCtXqh4Bbg+Bwau68JVE44OSov3VPtXr75JDp/pcF7TOdKKOOQ/JHPCsmDXKDzxNlEfQyyDjztpM/AiETK/XzzIUsqYk44GqCUBEKVpwP8wClhFATbDx5i+EKYxqr2sNhriEOUUdnBs2ze+cOVHh4+MhJMpwP4jTHXIgZVGGRU7/dSgr3vlcPKbqr6hQ5Xnutb+6HbwSZC+lG153HPBb5k4t3HuslVnF1SBGZr0lNbMmyIeFHIENQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H9U3lVm3LdZ4OeMGAuKbjx6qHerHHmDtfUlIblUbFDM=; b=mURkJR74nTDr7U6KjLSby/vonmgjo6LuM7lBnKrwN92e5ZH9S/nsAnKOzKav8WrCLypjaAWSszwMww8/9RFO0QbIdIL5GnO2NlSVL8q1p09WYBRA0sCMqlPO2AFCcuMCzdUa2OviPB5/c4nX4t+3V+i/HIujRyzCqHla6HuJMGAEThTqs37N6QcFr0DiPA/4Ah+L/CgZpXDhha455ZPbqkaE9KrgQU5pgyyKtEQvJyJQ3EwzKv42jZa9Ww6MBCul1oVNm1PKVlvCy4UHdgAqqw+CzK8sqS72XHyh9OSwjlIkMnpRxCp0WPVuc+7RcZHzmzbyYMRP2O9l2HFaLgZAXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H9U3lVm3LdZ4OeMGAuKbjx6qHerHHmDtfUlIblUbFDM=; b=XdvMka9bHeZ5hjsPAFtORMxwqBzqzPYWSIp4V4+VFpB40B3z/NCqh4+m1uSsM210yItJlEP7EVXiGpp72wcl8nvrzja2xovaXuWrvFou6AOf8/sSPrF+QDgweUlEfTkS4BxmScdHdAIga+TEdxwxhEzdEfAnIQ2P14+lOMo8XuYUquldIzwY6XJXkO5IK5+1kHklJBdvbh3LVoqy1XEuW3WoXmr1/B7UGBOrNWNWHEQ3hnIl/sCacmQ+fbZfPLQ/7wt6q4Vu4hqUN5ItfKSDjH4WSN+oSOYugnbIrMWFAB2qAV3NQ0CC5m41qm/e/BnxObAUt/NjzcgIBRSsWJpH8w== From: Milan Djokic To: "xen-devel@lists.xenproject.org" CC: Milan Djokic , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH 1/4] arm/domain: Update SBSA_VUART_CONSOLE config option handling Thread-Topic: [PATCH 1/4] arm/domain: Update SBSA_VUART_CONSOLE config option handling Thread-Index: AQHcZibd6UEW2KUo/EaT5vMEhVUoyA== Date: Fri, 5 Dec 2025 20:36:42 +0000 Message-ID: <723a873c8c35f54d1cb29866c9b68211f6a977e7.1764961645.git.milan_djokic@epam.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR03MB8322:EE_|AM7PR03MB6182:EE_ x-ms-office365-filtering-correlation-id: 4e2ecab3-75b3-4ab2-7e01-08de343e0019 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|38070700021; x-microsoft-antispam-message-info: =?iso-8859-1?Q?gv4pGKpN4egyPMYK1hWWLDzFFnJGAGPulxz2o20FkBS92g+gOR++Pih7Sa?= =?iso-8859-1?Q?hT+Acp45+WI3iX5a+eprB2wkoPAGafRCM8KfhfebgRfWwoQLDxXZorqMIf?= =?iso-8859-1?Q?Puigx8J0eymrw6gxdHZwSrc2CWtDzRzBryuY3CoDzGvuZ6DcY2swbgsfmF?= =?iso-8859-1?Q?XDpDgM4GSdAgp0tRegsPqmuQYE8V3VIezW4U7nEs4zMeSZnuMpQX8vAYHR?= =?iso-8859-1?Q?csqQvqfLME37ECKCA4adF2ZuyRFNDGRC3866Hmo/4HsU+v9J3OxPRu3WCF?= =?iso-8859-1?Q?07fHXZDCbsCeoPWZNv9lf+95Cq6TVGSAqG6FifF3NL32xj72eHk44LWHOd?= =?iso-8859-1?Q?SjcC6qRGitjLhLPTGaJGZTbed0SLz1BIZV8bYsSn3/Xft+PembLk3aXzF3?= =?iso-8859-1?Q?4jH+BI5/95mi6eHQZwQZm2bE8MGk3A8mkiPR9U8zDnwtivkm1ZT6yTu5te?= =?iso-8859-1?Q?S85GZHQazUGUY/qEek9Nry4bnwn0dYKeXsetOB/JKPTA4McE6aHNtH/SnH?= =?iso-8859-1?Q?pKNDRuAnVrufJP0RZJNayIVSKLPLpubvj+f+Lz5Wk+3ltSijY5CdsvX2dr?= =?iso-8859-1?Q?wfTNWP/B2uLupD/sWgvvbhWWY217FytKu4zysPZaGDt383fsvW5DH4fdFM?= =?iso-8859-1?Q?36TflFVGa8Pd2Y4RLHiPdm9ZBfnrnqwWyYRvEFoCW/F5Xo/0Z+eVUEq/Va?= =?iso-8859-1?Q?PJmdGeqnihpAT4ZFAJfCGl3GV9zmp6OcCHvTzN1HOBu8uktn5CrIODntZ/?= =?iso-8859-1?Q?OWsd3uUxZxaggmOfn0Oe65nT5S5y3ppxogWvjyf+SF5FYPPD7cWQyn2rAJ?= =?iso-8859-1?Q?RsouzuW7UtJ/XSjUqZ0l3zr3oSVc2ZpZLf4jfvUYM+AW9JhLnAt0Jvah8T?= =?iso-8859-1?Q?UNxmmdfs0ZXVZHfeq7pFbB7yBd3AbdIOmL0fe3h92XyIlW1P6PftcNzHAL?= =?iso-8859-1?Q?GTFF9CPU2FFB1X0vHvzK9Zu0sHK6uffU6OiZFF2wPyQXA6YyLDpzIZZQpp?= =?iso-8859-1?Q?tSIRiij8N1T1XG3xWwIvFxIIwIF9u0+xxNCYG2IvUCXIpvXVnhufDKlGKr?= =?iso-8859-1?Q?CB/IvL2LxHxQ5pdy0b0HmAeE2F6XQHY/f8dLqQMSDAJW0MRi23vKiGQw79?= =?iso-8859-1?Q?GtmWRhIqEZUfw+JJ7hwt7S3NOyaUoAg1PlRswgfmG20Uhu4IeAWyNcXzjl?= =?iso-8859-1?Q?ZSe1PuFpUbdm8NfG5C+2V6h85LlUCuHZP21IExZUbje1IGrHTu3b3ceVl+?= =?iso-8859-1?Q?NCxXScjarWitGT0vVZ641BD1vwAZf9Df+Ch1ubwu/4ZajEp/cDtGsuCK/3?= =?iso-8859-1?Q?9JndkRwoi8WjNmew7s9B/8gm8fz9T7EkQ/CgD1PR4zBTFcs0L5qVT23hSc?= =?iso-8859-1?Q?StiW0Um54+D4j449OcSCkn1NXm9yMwI8NHNhzky038T19mXfQrSrRI6zzE?= =?iso-8859-1?Q?pLMyJEUiT6Doh/gl2bzqlJeb73eLKhVlVRutClXGkjrJKx2QoJAMryZaS7?= =?iso-8859-1?Q?0NdFChFwUl1i4LEDatuYCsHGRrkaCcROpEDDA4utdGuaf/8xBOAAf2G4IX?= =?iso-8859-1?Q?loNSmLj6sLN3KPy4agOqiurWeBjB?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB8322.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?1gPaSQixAO2uYEK74Bee5w99oOmAj+3zLUruhmu2v0wmcPBe+6KUlYeu/Y?= =?iso-8859-1?Q?Mkl7SEt2UeyvSKhrMHqESljk4paSaOt2NqzFPO0o2wYsTWTMOdyXIEl/Q7?= =?iso-8859-1?Q?2iVmYGFvw9yRbK1PX5LHLW/5SXYlZkPMqjhVRJydMemUiXtHp5ezLG+b3O?= =?iso-8859-1?Q?siXRXsPaCz9K++jSTi0qDj1vyzwOfvwITUZPrAcnYGW5lockgvqI5wXpx3?= =?iso-8859-1?Q?pAyYhhXXp4A7Obm6JT4tNv1fwX+SeQN3gHBQTqW08Y7dP1WhOVL/vcAGdc?= =?iso-8859-1?Q?AjUFMuYDrhVlcVtmNvH4A3t0zOpNvHpMf3kraiTkkRXTJ5t75hJFnw/wOA?= =?iso-8859-1?Q?YiRkxFR9xsefyMqmw9sfNUNfvAz4NyobVRe/I9AT66OHsAlvv/l5wx0qVc?= =?iso-8859-1?Q?gV9HtrDeBXoKdPwbol1fjMRuDOXBTFyfDIVHFYg/Uf2EevNCRB1jfhVkYr?= =?iso-8859-1?Q?ZGViUJRTGPaln+zz6rVD4vyM2jFJVQ2PS8VehX1HuvNq9U/LIRvWU9JV/O?= =?iso-8859-1?Q?KVMV4M4BeCVHzz2u/qAlA7C4DMtscEUMs9x0B1VL/fh+LVMaAD4iZEpDhM?= =?iso-8859-1?Q?HUjHiMmHw5WA4kaS5ayX7/7n5Oul74j/VDfDNb1Vitms54TZcAm1Le1Osg?= =?iso-8859-1?Q?WmdKcdF+vfxt6qQLp7mGZXQxroWgXZx5XH/A3gZYEwUHS8CJCPCNDe0c6Z?= =?iso-8859-1?Q?PjVFVjEF/rYJskxI8Jwqr9OlQuat9SyVG7MUypTygSi+slTfF0j0JC76JN?= =?iso-8859-1?Q?Iortoj2+e9EQP0zLVEo1Mv9wTaGv87F+ugnAQH9a6SRuNRNK0J2LmHBZPQ?= =?iso-8859-1?Q?ODUUItUmSCSC6svFzVjD61Hf+T4NzTRuZJrMfo8vNyfOBsk0YbUCe4dYnP?= =?iso-8859-1?Q?jplpoPMsAMhvdNBeeDCRaq1kVf1rTkkMiszl4h/z1ThcSlDybfASmJuGfD?= =?iso-8859-1?Q?LWfwUt8AKDotFDRCYRdM/rZ8hfBusox/fWePt5FW+FCmML4IC//FNm7ARh?= =?iso-8859-1?Q?47BHDgAsdDxB7pjjkLcI+KK3e0Kbi/qRsq4BnJKOfGnwDmgf4IdXPZwGk2?= =?iso-8859-1?Q?pG6OF7qF1V5S8yzkLLrYOsyfrL3Uz3w+gU/NQ5C35DNrPuz3frVBFSIoi5?= =?iso-8859-1?Q?CRSRYD069/kOeqe1aIBBPA1YL0qWUoLduV43inmRtsJSGSL7BnFB1yr9e9?= =?iso-8859-1?Q?DAcSCyci0AvOvfoMLBVFuWmRTR/BT9snvujrUJtu6ItZ8RRgk/56chvBfz?= =?iso-8859-1?Q?n/sJJOxBjIZ4trrz43pBXNhDPxgz3HadXD7RMs4QSmM26ulzrHMuUNtXPP?= =?iso-8859-1?Q?TVTERzFhstpO9dqf/bVDckv/LhbVEgbcTF+GSEEZiLHUywSL71KXjaPn6C?= =?iso-8859-1?Q?m426az03pH0rHTFWQS3FAwkGqLshBacKES9O54bev356xy8B4lOWJ+4VcE?= =?iso-8859-1?Q?blov8i5NoOAMvkw3Jb2Obc5bCWH/l+wd02k2nMUx3D0gVtAxJJolYFGE8G?= =?iso-8859-1?Q?j1EFNAGjurBkS6ziunR6TceY9o1yXXN7aRv47mahDnzN3vKOf1OG4EcpWs?= =?iso-8859-1?Q?WypTXNVSfNpkh3R6oxvJ4aIIGXW0Wd6KNYCvqM13KpzXptMcrMZ/2DV5mr?= =?iso-8859-1?Q?YT31qavdMB8z9Ok6W07o9+3SaWxAz4xWVi?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB8322.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e2ecab3-75b3-4ab2-7e01-08de343e0019 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2025 20:36:42.7319 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pkx259Dvr9Xjp6DCQLc72BZ/6HbbZxSZ4nhU9JY4aKiVJBjwAo4BN9QvAfGZnDzjBMXBYwL156AgVt3KnhUiHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6182 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1764967033514019200 Content-Type: text/plain; charset="utf-8" Update XEN_DOMCTL_vuart_op command handling to return -EOPNOTSUPP when vpl011 is disabled, informing the control domain that this feature is unavailable. Added dom0less config sanity check for vpl011 property Signed-off-by: Milan Djokic --- xen/arch/arm/dom0less-build.c | 4 ++++ xen/arch/arm/domctl.c | 3 +++ xen/arch/arm/include/asm/vpl011.h | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index 4181c10538..57980d2abe 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -322,6 +322,10 @@ int __init arch_parse_dom0less_node(struct dt_device_n= ode *node, if ( domu_dt_sci_parse(node, d_cfg) ) panic("Error getting SCI configuration\n"); =20 + if ( dt_property_read_bool(node, "vpl011") && + !IS_ENABLED(CONFIG_SBSA_VUART_CONSOLE) ) + panic("'vpl011' property found, but CONFIG_SBSA_VUART_CONSOLE not = selected\n"); + if ( !dt_property_read_u32(node, "nr_spis", &d_cfg->arch.nr_spis) ) { int vpl011_virq =3D GUEST_VPL011_SPI; diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c index ad914c915f..250e20a9fb 100644 --- a/xen/arch/arm/domctl.c +++ b/xen/arch/arm/domctl.c @@ -156,6 +156,9 @@ long arch_do_domctl(struct xen_domctl *domctl, struct d= omain *d, unsigned int i; struct xen_domctl_vuart_op *vuart_op =3D &domctl->u.vuart_op; =20 + if ( !IS_ENABLED(CONFIG_SBSA_VUART_CONSOLE) ) + return -EOPNOTSUPP; + /* check that structure padding must be 0. */ for ( i =3D 0; i < sizeof(vuart_op->pad); i++ ) if ( vuart_op->pad[i] ) diff --git a/xen/arch/arm/include/asm/vpl011.h b/xen/arch/arm/include/asm/v= pl011.h index cc83868281..b8f4d85651 100644 --- a/xen/arch/arm/include/asm/vpl011.h +++ b/xen/arch/arm/include/asm/vpl011.h @@ -74,7 +74,7 @@ int vpl011_rx_char_xen(struct domain *d, char c); static inline int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info) { - return -ENOSYS; + return -EOPNOTSUPP; } =20 static inline void domain_vpl011_deinit(struct domain *d) { } --=20 2.43.0 From nobody Fri Dec 12 19:32:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1764967037; cv=pass; d=zohomail.com; s=zohoarc; b=F8JSLWHQJ5tobqI4WD9IqNUiUpVZ/HllCoq4GwgY+wMZd1YP72lXzLI+e7/SS/yJbKrG4XqOgERZEMp9eOpXZxOb9OIX3DVkFurf7OklQOLgkoGyapFh4sllJyb0Llvrd6Ur1WQlsUSkgsZM8XHH02+La2kjxneDsVlrWCOvng8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764967037; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lB6qJppX2KWYBujGwJWemEjd9Q9RzSskT3pkFV3zoUc=; b=gHFPHz4oVHd1+n619tR9J2c/ZQ9cNTJfMFfqA/TEQo+LUw02diIAfj407EPyij3JtbC3hzQdgGhsNMtCSX/Y86RqJwYAzS5BXOuaZtHyixv2byKQo8to2xJuzVciOaibM8T4aW23XE8rPhUetHRYokEhIJSuaCklWRwwbEA5xak= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1764967037651292.96155417620605; Fri, 5 Dec 2025 12:37:17 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1179434.1502943 (Exim 4.92) (envelope-from ) id 1vRcXt-0006u4-AO; Fri, 05 Dec 2025 20:36:53 +0000 Received: by outflank-mailman (output) from mailman id 1179434.1502943; Fri, 05 Dec 2025 20:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vRcXt-0006tw-7T; Fri, 05 Dec 2025 20:36:53 +0000 Received: by outflank-mailman (input) for mailman id 1179434; Fri, 05 Dec 2025 20:36:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vRcXr-0006OM-FJ for xen-devel@lists.xenproject.org; Fri, 05 Dec 2025 20:36:51 +0000 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com [2a01:111:f403:c200::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1fe9e26e-d21a-11f0-980a-7dc792cee155; Fri, 05 Dec 2025 21:36:49 +0100 (CET) Received: from AS8PR03MB8322.eurprd03.prod.outlook.com (2603:10a6:20b:509::16) by AM7PR03MB6182.eurprd03.prod.outlook.com (2603:10a6:20b:140::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.12; Fri, 5 Dec 2025 20:36:48 +0000 Received: from AS8PR03MB8322.eurprd03.prod.outlook.com ([fe80::e577:995:fb9d:38fb]) by AS8PR03MB8322.eurprd03.prod.outlook.com ([fe80::e577:995:fb9d:38fb%5]) with mapi id 15.20.9388.011; Fri, 5 Dec 2025 20:36:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fe9e26e-d21a-11f0-980a-7dc792cee155 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GCrHIOy3HrLam35iH975ZHj+8/ZCuNbaUj8XMlwE4C5U/2ZQAv4GkLx63ZEvkAriM0rDqavaK/cuVLO3aUdqbltMAaE7a0/XgIlzwb6wgAtF4DRyO4XqfytzeGpo5M0I/e/Vto3dkk2UJM8XatMiWbCKLWXzoJly6Hno45XGLwr6SkqMZ28vVMLVqIpROL94j5hu0EjPU1eCAoDWr1bKhAgqglXVoQSuZHsbfcvIJMXDp3M8XiTMRL1STH/cwdjIJOpXkcWyDaxuepBL9cdh4v5vLLbiO3fU7W1SO2Bvpi7KEHdUr58y/tYLu/bw/PxMljDCJHByeCRM4hgZxeUHnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lB6qJppX2KWYBujGwJWemEjd9Q9RzSskT3pkFV3zoUc=; b=ZYOsj/o++7WIe+A1ctbfuq3nV7z0J+EutwFjnUUmcJ3NMCqVuUMxaHaPSSejYl/Vrm3g4m7MPZLNLfoojKZusND7hcQc/86fw/v4ERA+JGKOsU2poiT+GueuqHL/ihoSyTN8AthThJ1DZyqfEvVjEld2zX3ohj/88BoBUAHMKCFEwpl30o4pRgAcHN+NYe3GZUQzy/1DBt1zIAKeQdmbQFmXpZr2IJ1blLCShSyDzxCc5u3wYB8Crp6hqndLJaZ31H1Kx5bseGZh2GBPWAauRQLgqnOmm3eXt0X4sa6FQvMbid+EtBezIGBRRd55Hb0emGmxWdl6sNcHrQ18GJIhVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lB6qJppX2KWYBujGwJWemEjd9Q9RzSskT3pkFV3zoUc=; b=MvBohx52GHY0ppaLrtAaaDJAmRE0QaL3Vqzvko7Z0mA/0SMDOzlOgQylY674yHqDkrUwbnGP3OzGMcxuCKB4KvhzucaQSm6B2zIwPqDeZ4ZIs61ecMT1FpBYzk/jasZ7VPWmAs1K/VJzTnPhlwSXwADOOis1WbNaHPclDPb9moBAQ3rkk6rcJNJpxWZPkCQpYRueeFO6BiyNiKP+cgtf/dR1Z3LV/Q2ZFNVhXN+MCvt9VMVP+Ccxchni4494gvwgMuP3lG+ieCsOiYFzp+WLtwZeLKFNmLgdPrr0wkojAD9VPvqZi6wuzTDO29kvfoR4sHKybCRpJ031jRXaq/HJ8A== From: Milan Djokic To: "xen-devel@lists.xenproject.org" CC: Milan Djokic , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini , "Daniel P. Smith" Subject: [PATCH 2/4] domctl: Provide appropriate error code when PIRQs are not supported Thread-Topic: [PATCH 2/4] domctl: Provide appropriate error code when PIRQs are not supported Thread-Index: AQHcZibgOinge/Jy20Oi61t8GSsw2g== Date: Fri, 5 Dec 2025 20:36:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR03MB8322:EE_|AM7PR03MB6182:EE_ x-ms-office365-filtering-correlation-id: 9a3cd245-d047-4b65-55f3-08de343e037a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|38070700021; x-microsoft-antispam-message-info: =?iso-8859-1?Q?e54tHWWdAstptkeL1fqcI/c469cVsFbbty25udQGYgl+/G2BJjjDGutycu?= =?iso-8859-1?Q?ACdsp7Uf9jZpctpdnN/LcanyVrNIfvw9NHFeHTOGwLHTRzm0U09AlK3pmr?= =?iso-8859-1?Q?B8jruEKG+YJLYcEHQ9xy6I5WL39ifcTZH7S2SS6F75dhw9okhH32hGvlLw?= =?iso-8859-1?Q?hWBMOG5Tg5oDonqemdTAFVQoZHxbEtE0+gM1sdF/JJnSZe80tJuvPQpSp/?= =?iso-8859-1?Q?OImIULDoZ9DvCdSHF40Ol65xg/cjFoaUEW8ZFk5WAMghzH/ZNphWv4GVHq?= =?iso-8859-1?Q?XRgK+f8cd7ddllPP14W4MrdO/83E+IGETw3DonIleZW45hh+BfSvOAUj8v?= =?iso-8859-1?Q?02SRt0yBEK0pTYh/0d4rOTiAqFUv+AZUSxzUdkZUNUhJi9yiCPIm9Kl8Eb?= =?iso-8859-1?Q?rK5LcvKSbhzwBVENG7CBGQUp2JjZyYpjyXM80PrQVkc1oOlCnCxLj4TdZf?= =?iso-8859-1?Q?0HszhKuAhmEqOVkf+KULMozbRoXXLQzWziYHigo8VkWsmN8pPk41arifr+?= =?iso-8859-1?Q?gc67E19ynBwfOwuxHrfdZN0ymeMhO6HHRI2iJ+tkrrVqJmcxqhqU58o+VQ?= =?iso-8859-1?Q?jPO7FBU8SoEw1l5Dckn0a8KsdT094lzxtVhPVYL04Q0BJWKE/6Hg1MSzDj?= =?iso-8859-1?Q?Fsz0DW3tAnHiuArPa2V15aiNzD1YL6jgkLLLpYpixzxhcoFrMqzSNturyA?= =?iso-8859-1?Q?Lk9IVX9BjDjGws7SnZ58B7xgc5G0AxXZh9Ui5CL+w3+ZXDG73wgjnQMQW2?= =?iso-8859-1?Q?m1/sigXieD/rOdvix/Q54GYhgPgy6ye1N2RmuHJPjhq8eLo3QXJEBaUkks?= =?iso-8859-1?Q?zWZwCso93QVjHEYT0jZgLEqYStuBpj3I/TTXVnxfL2veQqW4Oj6+BR4joS?= =?iso-8859-1?Q?OQq1fDrpvFvp5G882VnDiO9BZI0GRPnX8pOlrlVKA89TkNax1IItlCb7dF?= =?iso-8859-1?Q?221cA4rOe4Wi1JJlvcUmGag9W8Ni7L+Prkhc2uL3nOumNvUAJZ3T4Pn3Kl?= =?iso-8859-1?Q?+yVgV1qZV7OZDp9+O0/pIN6B/L7RdcwVGcpNcM+94GAe2KuzJOS1be6Sur?= =?iso-8859-1?Q?UzNGRJS2LJXe0Ds3pCpkzGT3H8226YUg1a3ZKgNMzT9KvaFdno2X/QSMNK?= =?iso-8859-1?Q?RS4QXJ0CTemuEH8WI/Bc6xKof27XpX5vtZqK2yq1W9ZwJJa/7H1ylek0rI?= =?iso-8859-1?Q?bpAQ6ekl+9So+gISrEywK2lNd2+BKvSWxS38aTuSgI1aVoltoLAzSisTYC?= =?iso-8859-1?Q?GNkPgynHssGxfYqdJL79bEIDDRZx76MVZoKjqVTkySfI+AfEh0VPXGkmdt?= =?iso-8859-1?Q?VSYUi/aDCjn4Vx/IGQ+4YO/dQfhSRT8+2DEbJN3i811W9ybFR2Z984ZqTn?= =?iso-8859-1?Q?ugbJoXf22K+Oh733/lq/slaBmZiE7oQdtnOwohfqSQI0Y4M3gIWvgQzStX?= =?iso-8859-1?Q?axiitJmgIbnUUXywErIhmJrzVNRPU9Pd7RCBvPB/MoMjSQdgwft7G48COG?= =?iso-8859-1?Q?gU19yxlSVqBf6E/isQBSf4ItnblVojMw+bVvGduFS2tsYQU50IOds1wLrn?= =?iso-8859-1?Q?1Zwq0HjQM0nbRFw5sFNr7fihz/vI?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB8322.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ozjSlGNEutnzFN71IRtxqAOJ9xjrgX9d+SQjMkWb4ls5X/1uOk/5n6ipTZ?= =?iso-8859-1?Q?mlbQi5zWzX7dStrdXFYxSLYP/lcl3452OOWWQIJ+pcsjUqPhxRTYSO7SlE?= =?iso-8859-1?Q?hWwMifzig2F89uFZzSXmtp9U4PwOe2FC+MBN1b8fHUSWla8wrBzPWsM1Z4?= =?iso-8859-1?Q?s+9fnXNXasB8yIj+aAGo6WAA3N1LcZapwhSQrQsJZL/+unPM8h5jF6uk2U?= =?iso-8859-1?Q?a9ccNEmB3SzWQ0b14GCX4uc0fn6h8sDsdYx4czOXHKLr4iJnKnChOXtOgE?= =?iso-8859-1?Q?FQEAC7YDVDHOSnmDb3oKneR91x+DxoUxFH9OQ0T/va3xgRZZlnvrdqjUcF?= =?iso-8859-1?Q?W3NPZz4i3dJMtxSg+Qw1O9sZ4rbPZTQl/kSk+unapc2QmRkkcZVgR5cHcL?= =?iso-8859-1?Q?DC+d1a8XXevV/5hmL9ILHJx4KFFHzyCBb1MaKyeyREsvrmzrcYxc+8mJP6?= =?iso-8859-1?Q?oqRMosw/D3OTLKkbfw3J2euUwqg53/tCGpDlecJ9ZCxrR1bf0ehyTa9jVm?= =?iso-8859-1?Q?ujiuhrI9K5LK+AHJpzegxVKUEWmDuBJJW4P/WqAMEbOlcxMIHbAsfuW6RV?= =?iso-8859-1?Q?SO7fOCn0dRD5HGd+7bmVsz6c5wIYb7VHeAgAVGwyeXI9Aw3HttPQk9FkjZ?= =?iso-8859-1?Q?mingRtgNEqUxbkICnvuR5g2k/XHSUFOvZHdJLOuIyDiaNS2VdfFBXRwbN4?= =?iso-8859-1?Q?sx+kKSz+rBU9yHyI6NtkQHmzedMG/dcuRrbrds6Xqai0oxANpsqIyt/EZG?= =?iso-8859-1?Q?/Iv46EOjGoElei9CJhZjOtrzrwKaHjqy8NUnAUoXA4RxQfkPsS6P4UId69?= =?iso-8859-1?Q?U+Ib9EoweBSZJRhwMGteINoTSY3GBeIucAHIK9GNv3uNHaBRgyU7wiEbyA?= =?iso-8859-1?Q?NCzNByLRj8Xqfo/duSiQgiIY0LgJEvuMtddFr61ab4YtT6UU73l4CtzkXB?= =?iso-8859-1?Q?2rTWchcmzVvNvMLyQ3DJw7jJfQtA6CTFm6aYIh6+lZFOidtZjObyieMo9h?= =?iso-8859-1?Q?UVWvKm96IH7NWn69qXiL2H2qeqG+WhQ63fenRJc0Zisi0QSP6W8mbKzBjT?= =?iso-8859-1?Q?ExrX3f1IIGTyiSx16X1os/2/mes24Du42G3f4ftjH4uYMgxoUjRyuvgeFA?= =?iso-8859-1?Q?qcDo6F6bXZHi9y82Ge46ROAZK2XtiQYpcpdST33VouRhop0bSU3fgYtLRC?= =?iso-8859-1?Q?MXYnKL+4Aq6Eh0/XBPRHf/Av7SRenF6qbpJkkxsE2jeA4a7OItvqclkQ51?= =?iso-8859-1?Q?geZZvoIGp471Ny7s0N8jzYWEsPAVgk8F8fYJvl0YAbsOSvlsLCr3V7ptAx?= =?iso-8859-1?Q?yRgIMcOB0hsNm4OI7hJwRwfTbNAdl8dakTw902Er7z1NAbxj0K0hAijC4F?= =?iso-8859-1?Q?iSHQ/Omz46MK8IU0Qu234J7xUAuht7+DEmKzdoUodkzG0E59biflNAnH73?= =?iso-8859-1?Q?6MUqnqxb3Ns8eCb28riCZSN68PTELYjadTXJ39XUl5Qs8tLPle3lw8oTo7?= =?iso-8859-1?Q?zzdjv5dnMsYrapRLTyHnVa89kvOh2CwuYBjJtGhVFj9AUMGMpggyzaDENP?= =?iso-8859-1?Q?qRr/OIVu77mKXITmZ8hNqhtNNSWYrH04i4o7ktNzHSmTl9Zva0iU2ojPnb?= =?iso-8859-1?Q?XWNShz/EaXMt9+C+h3ZwKFNVatyg5/FRnR?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB8322.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a3cd245-d047-4b65-55f3-08de343e037a X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2025 20:36:48.3861 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: COriHAsR/iYO4KXNu385DGOj612BajCkUISveMJ63pxLCf0cXG1dGg9/jqCgvdbUkij686M3B+Uy0vUW97V9wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6182 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1764967039105019200 Content-Type: text/plain; charset="utf-8" When PIRQs are not supported (e.g. for arm), XEN_DOMCTL_irq_permission command is not handled. This results with default (-ENOSYS) error code returned to control domain. Update command handling to return -EOPNOTSUPP if control domain invokes it by mistake when PIRQs are not supported. Also exclude xsm_irq_permission hooks from compilation when PIRQs are not supported. Signed-off-by: Milan Djokic --- xen/common/domctl.c | 6 ++++-- xen/include/xsm/dummy.h | 4 ++-- xen/include/xsm/xsm.h | 6 ++++-- xen/xsm/dummy.c | 2 ++ xen/xsm/flask/hooks.c | 5 ++++- 5 files changed, 16 insertions(+), 7 deletions(-) diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 29a7726d32..159864bc99 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -638,9 +638,9 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_d= omctl) } break; =20 -#ifdef CONFIG_HAS_PIRQ case XEN_DOMCTL_irq_permission: { +#ifdef CONFIG_HAS_PIRQ unsigned int pirq =3D op->u.irq_permission.pirq, irq; int allow =3D op->u.irq_permission.allow_access; =20 @@ -656,9 +656,11 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_= domctl) ret =3D irq_permit_access(d, irq); else ret =3D irq_deny_access(d, irq); +#else + ret =3D -EOPNOTSUPP; +#endif break; } -#endif =20 case XEN_DOMCTL_iomem_permission: { diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index e801dbcdba..6f6de161f9 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -555,14 +555,14 @@ static XSM_INLINE int cf_check xsm_unmap_domain_irq( XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } - +#ifdef CONFIG_HAS_PIRQ static XSM_INLINE int cf_check xsm_irq_permission( XSM_DEFAULT_ARG struct domain *d, int pirq, uint8_t allow) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } - +#endif static XSM_INLINE int cf_check xsm_iomem_permission( XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allo= w) { diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 2d831d7745..b85cf9933a 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -113,7 +113,9 @@ struct xsm_ops { int (*unmap_domain_irq)(struct domain *d, int irq, const void *data); int (*bind_pt_irq)(struct domain *d, struct xen_domctl_bind_pt_irq *bi= nd); int (*unbind_pt_irq)(struct domain *d, struct xen_domctl_bind_pt_irq *= bind); +#ifdef CONFIG_HAS_PIRQ int (*irq_permission)(struct domain *d, int pirq, uint8_t allow); +#endif int (*iomem_permission)(struct domain *d, uint64_t s, uint64_t e, uint8_t allow); int (*iomem_mapping)(struct domain *d, uint64_t s, uint64_t e, @@ -504,13 +506,13 @@ static inline int xsm_unbind_pt_irq( { return alternative_call(xsm_ops.unbind_pt_irq, d, bind); } - +#ifdef CONFIG_HAS_PIRQ static inline int xsm_irq_permission( xsm_default_t def, struct domain *d, int pirq, uint8_t allow) { return alternative_call(xsm_ops.irq_permission, d, pirq, allow); } - +#endif static inline int xsm_iomem_permission( xsm_default_t def, struct domain *d, uint64_t s, uint64_t e, uint8_t a= llow) { diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index 96dc82ac2e..28ef4a0beb 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -73,7 +73,9 @@ static const struct xsm_ops __initconst_cf_clobber dummy_= ops =3D { .unmap_domain_irq =3D xsm_unmap_domain_irq, .bind_pt_irq =3D xsm_bind_pt_irq, .unbind_pt_irq =3D xsm_unbind_pt_irq, +#ifdef CONFIG_HAS_PIRQ .irq_permission =3D xsm_irq_permission, +#endif .iomem_permission =3D xsm_iomem_permission, .iomem_mapping =3D xsm_iomem_mapping, .pci_config_permission =3D xsm_pci_config_permission, diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 9f3915617c..63e4b4c353 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1110,13 +1110,14 @@ static int cf_check flask_unbind_pt_irq( { return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE); } - +#ifdef CONFIG_HAS_PIRQ static int cf_check flask_irq_permission( struct domain *d, int pirq, uint8_t access) { /* the PIRQ number is not useful; real IRQ is checked during mapping */ return current_has_perm(d, SECCLASS_RESOURCE, resource_to_perm(access)= ); } +#endif =20 struct iomem_has_perm_data { uint32_t ssid; @@ -1943,7 +1944,9 @@ static const struct xsm_ops __initconst_cf_clobber fl= ask_ops =3D { .unmap_domain_irq =3D flask_unmap_domain_irq, .bind_pt_irq =3D flask_bind_pt_irq, .unbind_pt_irq =3D flask_unbind_pt_irq, +#ifdef CONFIG_HAS_PIRQ .irq_permission =3D flask_irq_permission, +#endif .iomem_permission =3D flask_iomem_permission, .iomem_mapping =3D flask_iomem_mapping, .pci_config_permission =3D flask_pci_config_permission, --=20 2.43.0 From nobody Fri Dec 12 19:32:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1764967041; cv=pass; d=zohomail.com; s=zohoarc; b=PLnDizMG7XzgX/ZfCaKy39fvkrCC6zX1wJPmC10eY4iTecAzF79c+TXJ3CZvmL7gNhcLUMtVRqCPO0spqZuw22CiGTXG3FDHWxt977SVCuKtpjWqR7r8B/lep88NFn94w0puCGIFP3lidy/WuPcamnYpcscXus9RKt9rVoIWasY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764967041; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5yMP3Tz77lZyIHFAGIFCclXZDcQr3lxGx6rzXnYKPZs=; b=YxYKp6EsuxGIqN/pHMCwYxM20UxZXaRjAsFX2r5AV0QqzzECnuMeJyKnsvehWKwSUJuKK2L1hIa2OpPvvegm4/NEGW0qFpZWcK9SEbnruIMNv0898p6Cw89tg/ruh9SoV1SK9vFMViY/Md3xykNNKhODXgkSDmnq2jT+GUSz+H0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1764967041042203.83012223071182; Fri, 5 Dec 2025 12:37:21 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1179435.1502953 (Exim 4.92) (envelope-from ) id 1vRcXw-0007BU-Hk; Fri, 05 Dec 2025 20:36:56 +0000 Received: by outflank-mailman (output) from mailman id 1179435.1502953; Fri, 05 Dec 2025 20:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vRcXw-0007BN-Em; Fri, 05 Dec 2025 20:36:56 +0000 Received: by outflank-mailman (input) for mailman id 1179435; Fri, 05 Dec 2025 20:36:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vRcXv-0006OM-F9 for xen-devel@lists.xenproject.org; Fri, 05 Dec 2025 20:36:55 +0000 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com [2a01:111:f403:c201::6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 223da751-d21a-11f0-980a-7dc792cee155; Fri, 05 Dec 2025 21:36:53 +0100 (CET) Received: from AS8PR03MB8322.eurprd03.prod.outlook.com (2603:10a6:20b:509::16) by AM7PR03MB6182.eurprd03.prod.outlook.com (2603:10a6:20b:140::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.12; Fri, 5 Dec 2025 20:36:50 +0000 Received: from AS8PR03MB8322.eurprd03.prod.outlook.com ([fe80::e577:995:fb9d:38fb]) by AS8PR03MB8322.eurprd03.prod.outlook.com ([fe80::e577:995:fb9d:38fb%5]) with mapi id 15.20.9388.011; Fri, 5 Dec 2025 20:36:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 223da751-d21a-11f0-980a-7dc792cee155 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xHxFJcxGFBQDpY+56liR25hKkQ1H5lmAfXFWiFL5i2dEgYvcalX4EOXWHi1mzqDouhEmFFjbVmz7ov5xkP5hNYcR8cdvL0VPUSplSRjJxksBdGe53eTedLsUcWeNiZhOrOxzutcebt1PrsMcYwnsgw3f97Z+/CRHgWtB8atQFCxk8ZjzKZ2zZGQJgz91P9pDGBPMbQsCeZ0k9f3FOY0PoNS+zcDl9pWnQh8hxY5+6SD9ql1Z9+EwvMfSY/gzrmG55VL/tiUqncHMpE1sLYUEhFkGVW4qbZ5Y4hUrAVXb5uZtD9HUsFbo2YU73u2D1zXhwr0egEM7a8YZee+7oY0Klg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5yMP3Tz77lZyIHFAGIFCclXZDcQr3lxGx6rzXnYKPZs=; b=BpHfM9XR/egSMquInMoIYCYtdN5m0kabhrqnT/xIy4qkh23E176gJKuiHu1XqZ0qglhZkpTAue8wK5XUpbNMQeGw+QKg1JevWi0QSGAzVuC+DS3bHjNayBbYujLFtcuepCDwacF9N+yuUA24ZtuFspr9fws+MgLdmhBqDPX6a5bP1td0PCC2UHvPbAdavem3mxunWd1mjt55QBhJhwZNk+DvaPYKUe3mnBrxFvkdSZoY+/F419apbLP//JlRRPfMTnz6hedP+mhW5AwZNPXqYvnidNRfvcRO5XTsEYg61i9BsmS5xPQ5Mx5+FloMDpBKIFJtbiwMMXbgZpTNZyqn/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5yMP3Tz77lZyIHFAGIFCclXZDcQr3lxGx6rzXnYKPZs=; b=ilYlRFuY68ScLeK7H5FbP7kqK3k8vN1iLq1Szq1QLU47fNo7lwZOID2SjuNJ1zwpRlm0yqXuTgX5oY5ahMpWszN3QKjRrHlqRMZDwXFZKEg4Cg18PAaeMSWa9PpJ1JRhMK4XOm2/tYc56v48ZGhx3cme3wPfpaM3kgJ2hlcGIn6MUiwf2S75Nz3OSEQi17t0uIpW4EL4607a8iUB6lwfgXWi0Q0ZvoxUIK+wLnPd2aZaHDKDWuM5sgU1CK1PVrnjgikxESWvBoLU7N7YtuZRH1xf+ayuE7kDlTjBBEPUVZDD+O7Bkkxjbcv3OGI1BVHi588YJsq1XFouXuPHE6n1Ag== From: Milan Djokic To: "xen-devel@lists.xenproject.org" CC: Milan Djokic , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini Subject: [PATCH 3/4] domctl: Provide appropriate error code when VM events are not supported Thread-Topic: [PATCH 3/4] domctl: Provide appropriate error code when VM events are not supported Thread-Index: AQHcZibiNA76ACBTxUmW3HNmbMMsdQ== Date: Fri, 5 Dec 2025 20:36:50 +0000 Message-ID: <99f899addf349543eaaaa328596dd9bf90004214.1764961645.git.milan_djokic@epam.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR03MB8322:EE_|AM7PR03MB6182:EE_ x-ms-office365-filtering-correlation-id: 24a9efc3-a44e-4c1f-4707-08de343e04ee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|38070700021; x-microsoft-antispam-message-info: =?iso-8859-1?Q?FH5gIeSy/grFVN04JXmlVztRKAdcAMyAlXk3veU25J8WjKeL6bOUKd0uFQ?= =?iso-8859-1?Q?GrcgB0aY0TIpUS0PpqhE+n4Icytatf6nYXHzl+GfZgdXfIKnSkUs4Zq3CH?= =?iso-8859-1?Q?H02822biv3QM1ORxPK4K0QH8k3UXS5ivMQG/8GzgY4c4qat3+G12CTq1fA?= =?iso-8859-1?Q?YereJNuok/FnXl/X3ICbOQ3wPd+0928EROlXKp7J03iunW1UNZ17Nu5z57?= =?iso-8859-1?Q?MsKt/C+nT7wbncro41jjK4sQCOlkBzLTuYayBe9bVaF2S1pDayVRiDj+Wv?= =?iso-8859-1?Q?KAy691U3l446DJw7HqYVjeXPJ75c4ihKK9lb0w3INbVq40vIyxIJiwSawm?= =?iso-8859-1?Q?Hus4Dv+eA6RFpccBdNp/dmY0W+vNPVGKcvnvQDfbPyk4pytJ942R3eWeyv?= =?iso-8859-1?Q?yJHLZuCur1jbdOctgo3lAyBW7M13OhS1hBvvsFLoKEFqdGclCtCV8Vyqdq?= =?iso-8859-1?Q?XBL0Kais5swIAg8q4gQv/9+PtnqQjk4GcRUeWPuMmdCorb5a8sFJAFcHlZ?= =?iso-8859-1?Q?o46Qi6fzpMz/oxHvSoBtO2G87d4Q8NitBI5i4sXC22+GKPNsZU8u6dSbNX?= =?iso-8859-1?Q?Snv7aQdEfrnJqMynmKCYVEKdEe8Va7EHv56Y7IAv4lXRVwdlFnFF/aMzTz?= =?iso-8859-1?Q?5f+Jt1/VT+l3+AA/w+ohLciDDdHCdqb4LpiChcY8T5q8QOA/5+o1VXfnY7?= =?iso-8859-1?Q?XDi2Bggjtd4X1xjqAr4smOEoxKVDDn4QdQhwNSIY2FBU0mTAqjp0atf8p8?= =?iso-8859-1?Q?sdFFk79u+rKNI/QoUYmdnwH18OfSRvt13JRCfqoEz73V5ZDEO897sFDP2N?= =?iso-8859-1?Q?2k2Ez/IiGp5RriVyuX31Huyn7e82uWUgMbc90O/+ZBG3WDWXXT9LX74JxZ?= =?iso-8859-1?Q?EKmg4hh+G2E8zFzAymrw3h7+gBASt6sVBptzzviNPD3gsiQHen+PfVnF8C?= =?iso-8859-1?Q?CC6v+orudLVPXL8/YvgN7fEk/EX7tpuKnhJUnvcQ0rnQl6V+AHeO5E0P6N?= =?iso-8859-1?Q?Z+22izkAl/V5UXL1D3aeVF6HA/uMImj5X/js3/BEooHDGGToglNv0/0IVN?= =?iso-8859-1?Q?kck+5jt602W7dtxCcByCsUh1pSXAK+T0ukL/GAunJ7/HjFHa5o8Lm9Mmkw?= =?iso-8859-1?Q?Jc2A3+hRGzsPr359Qern4BMWZ3o1Fb73OFAXCyj0iF491KOmjOqnoi82PE?= =?iso-8859-1?Q?Z9brB0mvIsG9ibWLIQlU3v4IgpNGvhj1UNpEeFyLjjlzlHbvzS1Aif0SZG?= =?iso-8859-1?Q?FEq5g1HD1gu7jFiQN8Cm95DWpt05v4/FddeEVFv9mUIAUidXRHhkRU6OTQ?= =?iso-8859-1?Q?X4y6NVKGJgry1IUyhpAJ8sfGu6IygvsBYTptLpqXVDbkN7R+xnUBrHUdSb?= =?iso-8859-1?Q?Ea14OKj0XeN90UXcwwHca4m8X4IuP8ILcejYGs56Zu8yQQQRhbDkK9ykD3?= =?iso-8859-1?Q?8EbCcDtgGRehfcJeIb0pKo9pZCy0qTgDlE4+sQ1hnLHjedZleXVTre5Iw9?= =?iso-8859-1?Q?mR2oTTvRH5GOzy8+PlSehHyg+CYk9C7cgrdu4H+jUh1Q7NYPOogWZuILj+?= =?iso-8859-1?Q?Fiye8MymoO+J0Zq2Pi2McfMOsZHX?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB8322.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?EXvRR67QPWQqoa2ViEwh2cysSbD2J4oPpnMWyrQZTfPXkqQj8vy8doXlsd?= =?iso-8859-1?Q?gKYrDhUiglNOL6wPtaBYw1ESg5De6o4jEwR+3asyhkTqswQuSNwOG1+CR+?= =?iso-8859-1?Q?PgGMYNUmMrnzXsu3K90vkJ27oiDlrabZHDAvZ+CzeomSMLmrvdfjJxEio+?= =?iso-8859-1?Q?8sW8XF1NoKzn7FzfXF2UKMYbxmkA6ZqLAfYW8dS4YnQxTK7dtZMrieOM+N?= =?iso-8859-1?Q?CQ08ZkCJdckbi0iBTeI60PRcR+3yHR1bmNC3yPJ//HOZNPIsZb1zFSSEbJ?= =?iso-8859-1?Q?1eWLM59v0AsX9GWaBZvLsVzhalZOEIJ1P+e5UaBio+lHlbsxvCqxWhfbJv?= =?iso-8859-1?Q?49MyXvuugjtVkHrpp9Tj486ZY3EvDFqL4kEbdly08A32tpibbQG5d0Abm3?= =?iso-8859-1?Q?tN1XTCBKy3F0RIW2NjY98950Ps6NJfVfFY3zqPpZXsSeeJd1q6C8XqLrpK?= =?iso-8859-1?Q?nn8ZcLnCPVZ4mLJRMazfyXmswideqAIJWsEcgqWS4UgUKz2kZp0XfElP2T?= =?iso-8859-1?Q?b4eeqq9T+9T2htR1AqlMcRNC/3qxz00n/4xf6i4WzkpmEHJDKhop8bBThd?= =?iso-8859-1?Q?IIIi56JkLYipfYLHmPMLuVQRyup8lB/TX4vGOU0tz1imI5OjqThdo4iZE0?= =?iso-8859-1?Q?NdTT1EnjHz+mxTUZswophFv/V6y3HPwc4SNYTd3xyRDNPfUWB+IdSylv6B?= =?iso-8859-1?Q?hj5RLNiOrnNCyqVpsVtpb7iT7qvtD1X4CAzBVM3VMbjYB7e5vCivvEI3CK?= =?iso-8859-1?Q?9dXcqVpKCj+b2N8Ni3IkvcpoNXoDPJdd+lb0Lb5+pSH8bzvh2o5iWpZNMM?= =?iso-8859-1?Q?KuGTTVVEm0chYsEMmzopBvrAze7354mMlKAtGdd/7ShImqmCOOTN7laNqt?= =?iso-8859-1?Q?A/YPk2qdQsPQ6WV1I5jlNNKyQ1EO0mNkL+X19rsh7nML3laKzrixN8imHs?= =?iso-8859-1?Q?/Xzrngs1GiXSW4aFACJwsPsP6LBr7rN0YfNh958ANsyVbDcxplqbH0L1tK?= =?iso-8859-1?Q?ZOtODBnZPkDj0nJ3jVWPzlyi2dz1xxtjgoRI8bcJROoj+9h0nom8ycZY2a?= =?iso-8859-1?Q?B/SmoR80E1RQdcuT0ffksHxqR3YSM0/oD1z9LIFXqrT5YrC9sft7bKjCBS?= =?iso-8859-1?Q?yJh6WIM5ZV0Z0enIuZlibBZ4fboVHxQ3/nmELmf0T93I3h3cBuSWZm77yX?= =?iso-8859-1?Q?WDP4PkJb8iHs1BLWIB9gxKfte4I+2ZFbAYHRiyIuebpjVDXODsgNg/R29r?= =?iso-8859-1?Q?7l9ACuoYoHB1OXSV5jfF13Hoo3vnP2D/8yZIOE41PMlMDdNAVAQetx45x3?= =?iso-8859-1?Q?Z6gNiktYvpqfchj85DzVLOVBBLt/fgoE49WnBqbLtNrcHStbPX26T3DiEL?= =?iso-8859-1?Q?lVpU6jFIJa6sKJbSKwD4u67oJs5T6U55AO1SavfKS5DwHzeD1ryC24Laqh?= =?iso-8859-1?Q?VSYvjmyHPORQxd8C8KItNTc8Iz9sCEtDgyEpu6QGlrGY31stzY0scZHTj3?= =?iso-8859-1?Q?fB61w+kD6Sa4pTSm7ZajOCvK2QYswbfnohtJVrmy42gEC435Pop6TPDAF+?= =?iso-8859-1?Q?HaegH2qsCsH/i6b+y8Ousa4Kne9XfAwINIeTNAdNjtlSvZ4Vva1im4OUI7?= =?iso-8859-1?Q?s9C6NbfmoMiWV8w6Orfm9jMn58+nASJZBQ?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB8322.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24a9efc3-a44e-4c1f-4707-08de343e04ee X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2025 20:36:50.8123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0WYdXBzYZn+3udlZrwvzXZJwNO5OQiJm2lp7fcwaMQufIcuonQF+9QE/fN+LktHsWmHEYV1g2Pw0pr6jiqtE/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6182 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1764967043018019200 Content-Type: text/plain; charset="utf-8" Return -EOPNOTSUPP when XEN_DOMCTL_set_access_required command is invoked while VM events and monitoring support is disabled. Signed-off-by: Milan Djokic --- xen/common/domctl.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 159864bc99..5284524b42 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -787,19 +787,22 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u= _domctl) copyback =3D true; break; =20 -#ifdef CONFIG_VM_EVENT case XEN_DOMCTL_set_access_required: - if ( unlikely(current->domain =3D=3D d) ) /* no domain_pause() */ - ret =3D -EPERM; + if ( !IS_ENABLED(CONFIG_VM_EVENT) ) + ret =3D -EOPNOTSUPP; else { - domain_pause(d); - arch_p2m_set_access_required(d, - op->u.access_required.access_required); - domain_unpause(d); + if ( unlikely(current->domain =3D=3D d) ) /* no domain_pause()= */ + ret =3D -EPERM; + else + { + domain_pause(d); + arch_p2m_set_access_required(d, + op->u.access_required.access_required); + domain_unpause(d); + } } break; -#endif =20 case XEN_DOMCTL_set_virq_handler: ret =3D set_global_virq_handler(d, op->u.set_virq_handler.virq); --=20 2.43.0 From nobody Fri Dec 12 19:32:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1764967041; cv=pass; d=zohomail.com; s=zohoarc; b=XcIcnWE1hc4y/o4Lrx0trEemQ2dEFB5aqvAe5eO6owZNIAQDyhvgjBKjJno8nx9uHOBPWtL7fyNNKJrb1PuAvc2g6lpmobQPDiOAlH3A1rxqqDyp4RA8SOEdcFrb6dmhUnf4cuh3GCC2vrLIK74D0xoaoc+U4M9rsbTE1eBKgwA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764967041; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S3hht+B/Z3BXKM33lvD97f0jezcDIH+75DFkaQV/1GI=; b=grXYH7BzXUq4iFl+Tx0xksIuvx+WexIsaWiJZt7XJM9YmbthF0Z9m6czyDScvWS8LfQpez7UJ91XWTiSLiSGP3tDjclvSWX95tpvWx2Nk9Spn0YWqe+WANiY2RhUlv5gqE1o/jJzk9zHCYJ+rmLwQctI4HxS1GfvbQjyxOiUlPw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1764967041061159.00323872996069; Fri, 5 Dec 2025 12:37:21 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1179436.1502963 (Exim 4.92) (envelope-from ) id 1vRcXy-0007Rv-S8; Fri, 05 Dec 2025 20:36:58 +0000 Received: by outflank-mailman (output) from mailman id 1179436.1502963; Fri, 05 Dec 2025 20:36:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vRcXy-0007Rj-OG; Fri, 05 Dec 2025 20:36:58 +0000 Received: by outflank-mailman (input) for mailman id 1179436; Fri, 05 Dec 2025 20:36:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vRcXx-0006OM-0T for xen-devel@lists.xenproject.org; Fri, 05 Dec 2025 20:36:57 +0000 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com [2a01:111:f403:c201::6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23689d4c-d21a-11f0-980a-7dc792cee155; Fri, 05 Dec 2025 21:36:55 +0100 (CET) Received: from AS8PR03MB8322.eurprd03.prod.outlook.com (2603:10a6:20b:509::16) by AM7PR03MB6182.eurprd03.prod.outlook.com (2603:10a6:20b:140::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.12; Fri, 5 Dec 2025 20:36:53 +0000 Received: from AS8PR03MB8322.eurprd03.prod.outlook.com ([fe80::e577:995:fb9d:38fb]) by AS8PR03MB8322.eurprd03.prod.outlook.com ([fe80::e577:995:fb9d:38fb%5]) with mapi id 15.20.9388.011; Fri, 5 Dec 2025 20:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23689d4c-d21a-11f0-980a-7dc792cee155 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a5bqKK0zmCGQWij/mtSg4UqVPs89U+UqKnV/wM1Ve0TmJ0Z/AEaN4OOuSv76Xp++3pW7hdqhcBvYV+9W8Kar4tRvYFuZw6OjFtV4eVSyS+gUWfbCswkzJPGv7n91BVth1HSKKKs6thGMTFacBUM/Mcb1QnBdyyTwGlZeAjeUsQXtBcr/KH5WPuFWY7wNjkWFG6pVE4m9jsMkowzQbFU2x9HINZG/KgI5nB3sjelKxDU9UWqk0YAzVsFaL4brjQsn5kHQ7YyXGLfBCuc4Er8fDVSTwcSuvGsRdu3+8q3wzEKrbrovV1AJJtSkUR4MGpYscKP1cv5utJPsabkHQzKq/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S3hht+B/Z3BXKM33lvD97f0jezcDIH+75DFkaQV/1GI=; b=JJ/0mAiU0nQr5cKil2pQQv/nuT5V2nN2P94cGR4BCKELf2Of4tSGACAe7++tlMS++ohxmRzNiKp7E+X63EHDuk3+Xl6wjKopceCzEDB73YZPQ/ieXjYqRfCfmD/aEscmCS4/CwNAF88zFEqn3gR36T1aSuofCYAhX/eUic+a/SJqTJEF2aiQDwl3kLPbKNIOWTGkNW6v0Uyj1ypXqRWi+MMNDzDYEsPiVcMW/z7XN6S0r1bFZnRINjE6BQV/JwD5D2OhwEa2T5uhp1fX4GQO/kpNHsUt7o6HOOYRScJGZBvNUH/RI3koXJ+5544/qUFlZr2EVhbPEnAHAAVOQnPvPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S3hht+B/Z3BXKM33lvD97f0jezcDIH+75DFkaQV/1GI=; b=IJbTpA46w+dzRoftvYZ9BUWz+SSGpId9e6oVJxes9Vhl+7tR/xg7vi5NN3PI086LLAmoEV1kpbGisTyW5At6imcMUywywd7f2U11PSnjymYgiM5S+1WILe2ohUUH0nNB1iHjHoqt0nDdSUxEExCJ6fEQ4eKNb8myZBdO8//v8ACuug+33isnlMYJWHGSA7x6cicCGBJQD/iMU5GLhw7GX1TJQVyNBs+fOXu1CfmkWJu9D/EAMUwMxVRfzHcvmF3wsm/i5bHK0uX+rNiu8QvXed8LfJPoJIeVRSzESPIJxAHAj5URE0AFflNAQn6IvM6e0aFTFq4XRQo10s91Wy/LNA== From: Milan Djokic To: "xen-devel@lists.xenproject.org" CC: Milan Djokic , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini , Ross Lagerwall Subject: [PATCH 4/4] sysctl: align handling of unsupported commands Thread-Topic: [PATCH 4/4] sysctl: align handling of unsupported commands Thread-Index: AQHcZibkme3OGvWxDky6ckEgDIZ95g== Date: Fri, 5 Dec 2025 20:36:53 +0000 Message-ID: <6c7cc11e3569f69b185d32809d63b8cdca67aa25.1764961645.git.milan_djokic@epam.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR03MB8322:EE_|AM7PR03MB6182:EE_ x-ms-office365-filtering-correlation-id: ae5f47c4-96ba-4233-5a04-08de343e0688 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|38070700021; x-microsoft-antispam-message-info: =?iso-8859-1?Q?b87e5TVUdR21dga6uFPvdOOyklBWDB/h9DMsTPrIxCJFHeD7378yZ53Knr?= =?iso-8859-1?Q?SSjyjeiOIlVTvNQrmJMpQeIy1zBa6JxihfWcagiiTnKPn7CTSy95X9V08Z?= =?iso-8859-1?Q?jMIt5NssL3Gq2/NWK/4L7cpGpXO/juS0zkRLlVBQeKjoU4Z3g5W0md6sLt?= =?iso-8859-1?Q?nwV8cruInIp/9Mss4XusgabxZcr6YWCNkzZG8aCRaL860nd7QwJ9qzZMdh?= =?iso-8859-1?Q?MgCqyXJhnMO4YpnyE8AxJ9M0qHYBDD/2CuiMAawUdgk0RwNHcy+8NgK2hf?= =?iso-8859-1?Q?mfmXZHb0enY2OIIUn779teMkYDeukettVKs+IPdMusoymJslF9xAH00N8N?= =?iso-8859-1?Q?55J27h+G+pcBaB4MPY+zk6yb5TQ1gdxTX8fiP4NmXNg2gbJADkMnRY05+E?= =?iso-8859-1?Q?Qj4ELxceQsdcY2lA6eu5g/3kbeJfzyDLVu91UjRNzJYKSAV3r7IFvekTbs?= =?iso-8859-1?Q?3TX9dgWfl/dI7g+8i9/i/2Lgyq+iGEuDHHcHUxyeKxNy1UJMLHm5HAWw/n?= =?iso-8859-1?Q?t1QREM94uNoAHSqUZqKl4rxSU0pahgJkq0rIj91LcItHcxN6nCeQ+9PzKW?= =?iso-8859-1?Q?4Iq50BaNZ+PTOEbHLlWFRRVDMfy5kWJ4vywL4oYQdrljtX8WyJnKbHixqT?= =?iso-8859-1?Q?1g0eJo+IwSflKisk/bKGDC48V1/iedKKObWiFZ7KfGclW+8qZcvu+AbSV4?= =?iso-8859-1?Q?4p4KCXoMyw7d8XcQ679VZZRe0dgHpD5FzXWdkrG430/yMsl9PK9HTT/bvo?= =?iso-8859-1?Q?lvXpfuB4TXK8sbI1tZE86AiLp/PgnCLW2Cl8xouQ7C1QaeNdxstMELkcsP?= =?iso-8859-1?Q?oZxwlpP1eMoyxXnC6R8YX7jDv+zqjbbF02IZ2QG5fNMWrwSLzBLWhAcA5r?= =?iso-8859-1?Q?x3WtUhuHSh1XNZOAuSIDZ5FSVT8TGfxjEdEGSbtV4lCJb/izv4ac2Kwtql?= =?iso-8859-1?Q?aOc/YOarg3HziR3gdiSYTVxHRUQKfNkWCcm0Ui/5Ub/DId1HX8NCg9UIaF?= =?iso-8859-1?Q?0TGB3EmGBFJ5UfUar0oUgFE//edbpyBW2lrV21dFOTJ7urBA/3pVDTqT0z?= =?iso-8859-1?Q?cqy9K43QLKDlz0nQPJ/AVgNnymFQHoPY2Yw1nBRFzJ4LBLd46bJGwgmco/?= =?iso-8859-1?Q?DSgHs/irQe8wx5YpYjhNrWGA82/X47paLwaD3xbUQGQI79f7fDa0Inpyrc?= =?iso-8859-1?Q?GIYoo2lpndIT/KxTSrLXTbcqXSKX5Jio/YQyRS475dTVisKz6SrKpjzi1E?= =?iso-8859-1?Q?bK9cND3FZAwHhIobDh+iYq+tLj6czpbzNZ2L5P0a51VzIqpb59fVJ7gpsh?= =?iso-8859-1?Q?hZCUQ+rZmAdcwhtOjBrISG/u81H1S/CdrngzQehqsgvGF3ygn1fvLtnVZq?= =?iso-8859-1?Q?GcYX1p5MlWBUWkbRM+HlY2ymQ02QyHmTL8Wya5I6Xad7eeUSVFRuszVXYE?= =?iso-8859-1?Q?Ul3J/aApleAOMdpRvF7i4mJgaDCd7DKk7ooqxBHqGB/RlgWzTt9J48HQMo?= =?iso-8859-1?Q?xqrJLIRqzxBm7faB+EMMgfXPURmo1BmGzHmCARjNjop7rBHGxpYd2wrpf3?= =?iso-8859-1?Q?WBnj8CaPxOuSAvYUCVOYG9mIg66S?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB8322.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?GO1N3MwwGLX4fqYJLJSGeZm1GZ0lb5maYrkaNW/4Ssl7YCsdRdzsTpia75?= =?iso-8859-1?Q?6cJIff/CAaH6OCRoQnIk54IA5+c7hn9DO8fomAthwaQ6U/w6JDYf2qUUW+?= =?iso-8859-1?Q?18QIaL0YIreGZxl3oZg+ktxenf0VHvwpyfYYsDWv13U+FRqTI6Hr6JK+zN?= =?iso-8859-1?Q?ZKJrbNKiKZs1z0ifutZxiYai7ZsO3Zz4XONtM8yEvdS8eOjOsMdFBbz01+?= =?iso-8859-1?Q?DuKLLge7SEIuP/csmgB0PzQuaKU9X9SbD/oY1RXaAvHH4/udSIvU9u5i0n?= =?iso-8859-1?Q?y58GZBv9BXcNLtB99zLLKYauIAWzfRsb4tY6cYhfD902PkBIR+d7A+TJ3o?= =?iso-8859-1?Q?eXiw7O6plTqHcpjFzqgwLpNjxNQOD9x7yMP6ItvrdiF8Rodfp+MfXLzL73?= =?iso-8859-1?Q?zLonMT6CtgQm95C31UXSoN3jsNjcfcIwxY4jo6F6ICI62+XOcUHdA07UbE?= =?iso-8859-1?Q?CyaD0EqAMwBgtdsBOcbq+cECDvVWhSRHNdc+Z8QHY1LNeLX5YN5EzJ0MKy?= =?iso-8859-1?Q?Jw46JhiHMGpsLxt501UYqBZ0Rwr+anBkPaw4V48oe81apUXJRz8ZJ0PjUP?= =?iso-8859-1?Q?ZpDvwL6XYwc6EWn4KZ7qBBw+U/Ox7VaRRLtN80xIREtMtoKZkKmVuwjH0b?= =?iso-8859-1?Q?lKBjYPD8AwHHUtzT8z8q2gC4S3xhf/FunOXGnCTU+N04QIUDlGH9c/RlyL?= =?iso-8859-1?Q?+ZBL4Xu1gPedvP+9x/9/bejgZtHkN5ITAhKNlR8W0I3PAyMAm375oKAgE/?= =?iso-8859-1?Q?AKQ5MJcCJz3MkeF1l+MwnBzr3Kvv2oTZB2cQugiCzNsVOqPx9Ql3rIIkdL?= =?iso-8859-1?Q?op8gVWwHFqbXNABVXkLXv7+YZUnMqx0dVYf2v96d+i85Wv6H2cODpp9pcC?= =?iso-8859-1?Q?JfFefGaCXo6RJqVLLRtmLlQBpYZlL68pZgSG0/wX6CUn1ibH5EilCTqB1l?= =?iso-8859-1?Q?l4qFvKVxH/jdoiJ6bHcpC940y9JrKIbgk4z8ZfDBIy1y1MyfptUZXMOcdG?= =?iso-8859-1?Q?fVOkbtgrNqEujHc9zEYH7iluFYtbkvl3uV0HleNRkamzxtAa15y8ykIcN6?= =?iso-8859-1?Q?58CuvcOXf1S5o8Rc6YYE2LDtUY6CmUtf74i/2JOLXuOSy/sz4H4r49DMUY?= =?iso-8859-1?Q?0MA94nTyuNatbH3iR7oClzSU7MNHlx0vqyPaWFZ6TxuvPSROPPbUb5QFDU?= =?iso-8859-1?Q?KFtLJIL87j1aljQIRPh34hNQHa/+FrRrUmtdsEPq3A7rVlULrrS27I3o0w?= =?iso-8859-1?Q?QyOdLPI/TONNjksDTEXFS7TX+obOiv2Gt0DYl2KGIfnm8p246yIcoCmF1a?= =?iso-8859-1?Q?3klCthwlx3vGI6PNzMmg+uZUNsMT5uNBjvXxlm3gwvW4bfUjzB/f1p7lhZ?= =?iso-8859-1?Q?VjopXJJFBK0dDcdqb1BbVvoUTiW2jpMtfnqLp29Z+Q5uxWRg9g5ESt/Snr?= =?iso-8859-1?Q?D2ofXDDP0GClOxp2K34Yg/v4/yNwa+1ZznvcYluc5OvpP9zcVftdohapPS?= =?iso-8859-1?Q?KjQ+iT9jgauotQoHGtrBf/NK0Hz4F4ewT0ln479fQZbIw6bbk74XtCkIhP?= =?iso-8859-1?Q?/0Qbwr6mUe52boAcg/n68MJSHfV/6cHGBI6IUfduwgN4JFWUvLHXrRBzc8?= =?iso-8859-1?Q?TD0HZekuhSz8dBYynf6yBfUH2fT+SBGIwW?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB8322.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae5f47c4-96ba-4233-5a04-08de343e0688 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2025 20:36:53.5131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MgrgwS6FBdzIJyP+ZVh5v14mgwDypBHvyG+9J49KmGk0yvcv3LPwvyt4lr+B35+PS4Bdc43UFSK+kzOmmzQgQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6182 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1764967043159019200 Content-Type: text/plain; charset="utf-8" Handling of unsupported sysctl commands currently diverges: some commands return -EOPNOTSUPP, while others fall back to generic -ENOSYS. Unify the behavior so that unsupported commands consistently return the appropriate error code, allowing the control domain to correctly identify unsupported operations. Using IS_ENABLED() macro to identify disabled commands, allowing dead code to be removed at compile time. Signed-off-by: Milan Djokic --- xen/common/sysctl.c | 34 ++++++++++++++++++++-------------- xen/include/xen/livepatch.h | 2 +- xen/include/xen/perfc.h | 4 +++- xen/include/xen/spinlock.h | 6 +++--- xen/include/xen/trace.h | 2 +- 5 files changed, 28 insertions(+), 20 deletions(-) diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index 5207664252..1c4e0b60d8 100644 --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -113,17 +113,20 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u= _sysctl) } break; =20 -#ifdef CONFIG_PERF_COUNTERS case XEN_SYSCTL_perfc_op: - ret =3D perfc_control(&op->u.perfc_op); + if ( !IS_ENABLED(CONFIG_PERF_COUNTERS) ) + ret =3D -EOPNOTSUPP; + else + ret =3D perfc_control(&op->u.perfc_op); break; -#endif =20 -#ifdef CONFIG_DEBUG_LOCK_PROFILE case XEN_SYSCTL_lockprof_op: - ret =3D spinlock_profile_control(&op->u.lockprof_op); + if ( !IS_ENABLED(CONFIG_DEBUG_LOCK_PROFILE) ) + ret =3D -EOPNOTSUPP; + else + ret =3D spinlock_profile_control(&op->u.lockprof_op); break; -#endif + case XEN_SYSCTL_debug_keys: { char c; @@ -170,19 +173,22 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u= _sysctl) op->u.availheap.avail_bytes <<=3D PAGE_SHIFT; break; =20 -#ifdef CONFIG_PM_STATS case XEN_SYSCTL_get_pmstat: - ret =3D do_get_pm_info(&op->u.get_pmstat); + if ( !IS_ENABLED(CONFIG_PM_STATS) ) + ret =3D -EOPNOTSUPP; + else + ret =3D do_get_pm_info(&op->u.get_pmstat); break; -#endif =20 -#ifdef CONFIG_PM_OP case XEN_SYSCTL_pm_op: - ret =3D do_pm_op(&op->u.pm_op); - if ( ret =3D=3D -EAGAIN ) - copyback =3D 1; + if ( !IS_ENABLED(CONFIG_PM_OP) ) + ret =3D -EOPNOTSUPP; + else { + ret =3D do_pm_op(&op->u.pm_op); + if ( ret =3D=3D -EAGAIN ) + copyback =3D 1; + } break; -#endif =20 case XEN_SYSCTL_page_offline_op: { diff --git a/xen/include/xen/livepatch.h b/xen/include/xen/livepatch.h index d074a5bebe..1601b860d8 100644 --- a/xen/include/xen/livepatch.h +++ b/xen/include/xen/livepatch.h @@ -157,7 +157,7 @@ void revert_payload_tail(struct payload *data); =20 static inline int livepatch_op(struct xen_sysctl_livepatch_op *op) { - return -ENOSYS; + return -EOPNOTSUPP; } =20 static inline void check_for_livepatch_work(void) {} diff --git a/xen/include/xen/perfc.h b/xen/include/xen/perfc.h index bf0eb032f7..a44c2f74a1 100644 --- a/xen/include/xen/perfc.h +++ b/xen/include/xen/perfc.h @@ -92,7 +92,6 @@ DECLARE_PER_CPU(perfc_t[NUM_PERFCOUNTERS], perfcounters); #endif =20 struct xen_sysctl_perfc_op; -int perfc_control(struct xen_sysctl_perfc_op *pc); =20 extern void cf_check perfc_printall(unsigned char key); extern void cf_check perfc_reset(unsigned char key); @@ -114,4 +113,7 @@ extern void cf_check perfc_reset(unsigned char key); =20 #endif /* CONFIG_PERF_COUNTERS */ =20 +struct xen_sysctl_perfc_op; +extern int perfc_control(struct xen_sysctl_perfc_op *pc); + #endif /* __XEN_PERFC_H__ */ diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index ca9d8c7ec0..10ee81b7db 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -7,6 +7,7 @@ =20 #include #include +#include =20 #define SPINLOCK_CPU_BITS 16 =20 @@ -40,8 +41,6 @@ union lock_debug { }; =20 #ifdef CONFIG_DEBUG_LOCK_PROFILE =20 -#include - /* lock profiling on: =20 @@ -164,7 +163,6 @@ void _lock_profile_deregister_struct(int32_t type, #define lock_profile_deregister_struct(type, ptr) = \ _lock_profile_deregister_struct(type, &((ptr)->profile_head)) =20 -extern int spinlock_profile_control(struct xen_sysctl_lockprof_op *pc); extern void cf_check spinlock_profile_printall(unsigned char key); extern void cf_check spinlock_profile_reset(unsigned char key); =20 @@ -360,4 +358,6 @@ static always_inline void nrspin_lock_irq(rspinlock_t *= l) #define nrspin_unlock_irqrestore(l, f) _nrspin_unlock_irqrestore(l, f) #define nrspin_unlock_irq(l) _nrspin_unlock_irq(l) =20 +extern int spinlock_profile_control(struct xen_sysctl_lockprof_op *pc); + #endif /* __SPINLOCK_H__ */ diff --git a/xen/include/xen/trace.h b/xen/include/xen/trace.h index 30ebdcc47f..fff3a4f451 100644 --- a/xen/include/xen/trace.h +++ b/xen/include/xen/trace.h @@ -48,7 +48,7 @@ void __trace_hypercall(uint32_t event, unsigned long op, =20 static inline int tb_control(struct xen_sysctl_tbuf_op *tbc) { - return -ENOSYS; + return -EOPNOTSUPP; } =20 static inline int trace_will_trace_event(uint32_t event) --=20 2.43.0