From nobody Thu Oct 30 18:31:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1756803856; cv=none; d=zohomail.com; s=zohoarc; b=Z+yK6cCNLjSqVvX5hVqCD79qfv5MpWgUzNxAIpNXxG6A1HQEWSoo/mDVDVVFZgOTFGuapNhr9NWgc/qm8iGh2IasNhw42RDe9qhhXZjaNca32NzxolKjg21+X7ET/0DRUNPRLXq+gFWMISdinWLmVhP3vWc9pXCWLwA9XsNAg/E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756803856; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iMTZeV1RLqj8sJpYIV/jbQJb4350elWFSvSX2DVPWHc=; b=BonAI1s9LndF+GRZCEEbbvNXncr39Xf1N6HPeaN+w//C7LWjeewnFZB1AHtUofRn/68Y4hB+ToBytyIQIx1BDFr6m0s2eZs7ECWJrLdzlo/UPvr65rUUweXRgbw6CeE/nXuODrjsFCW4YNm3CLVQxxYOynHq9XLJvJ9Gmw55Rvc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756803856255511.7838001730818; Tue, 2 Sep 2025 02:04:16 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1105849.1456676 (Exim 4.92) (envelope-from ) id 1utMvl-0000J0-JY; Tue, 02 Sep 2025 09:03:57 +0000 Received: by outflank-mailman (output) from mailman id 1105849.1456676; Tue, 02 Sep 2025 09:03:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utMvl-0000Hc-D0; Tue, 02 Sep 2025 09:03:57 +0000 Received: by outflank-mailman (input) for mailman id 1105849; Tue, 02 Sep 2025 09:03:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utMvk-0000FE-8m for xen-devel@lists.xenproject.org; Tue, 02 Sep 2025 09:03:56 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bfede0b8-87db-11f0-8dd7-1b34d833f44b; Tue, 02 Sep 2025 11:03:53 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-55f78e3cdf9so2564869e87.1 for ; Tue, 02 Sep 2025 02:03:53 -0700 (PDT) Received: from yp-VivoBook-ASUSLaptop-M1503QA-M1503QA.. ([95.67.15.120]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-560827aabf5sm524019e87.137.2025.09.02.02.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 02:03:51 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfede0b8-87db-11f0-8dd7-1b34d833f44b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756803833; x=1757408633; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iMTZeV1RLqj8sJpYIV/jbQJb4350elWFSvSX2DVPWHc=; b=MvpUj7D11uo7SjuS56QFFBy1KNjJjT45KMCNiuLhMo4vZbF8ipcAb4F4m2qteAjmqV WrG1Z//akAs5iVQ89Hfv202ejN80LEdsxNghCv0ao9fGlB2TX9+Iqkf9AVQuYWtS+G2V yHNj0BXpFJcERSJGOzC7w+pV+1oaZAUOoIt6j81IpXg8JM+WuvJjECrP8CdM0OCll7BC BaijBkSfr3rACkyavLMm4p6lvZxEYHXybv8IIV62FOk23Iy9UsJTdyJ32LMA7jpgVN78 OqvY7SMhMBuCVmK9RH4KsQ3sD2CcA4nry5TTKdcnbx/TxXOvDZM8+Gnb5VQvrOT6ym5P EAYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756803833; x=1757408633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iMTZeV1RLqj8sJpYIV/jbQJb4350elWFSvSX2DVPWHc=; b=DzOvwi2cfyLw/YFayNy1bpkGZn2u+xTvedplp0SwyuaIjGwhOXsTH6gBL98kAvhKyf crCuv5CJ2q229Nj/T4mNTpad7VotCJKrceRcYBFoGyDCzl+B5fIoi1RRrWTQfJeMc+EB wZpa4oYeyN+ij3XWRhBX32bPq+RjhwnYfoc48MqWfODec4dz63OvcM5jr3Nyvd+qmHaH z5Nfv/1NE7uE9iadJNetR1L7hWj96rBf0KnvwUYiB18giPIM5r8Nngs5TNdAWrNOK+ZQ k9SHgeRBYVV7kDzncl7LfYFi/qbLetbm8yAeQDNa0JJZpSenWnKL1vXgc5owz+LqlFn1 fyOw== X-Gm-Message-State: AOJu0YyNbPEZYn2snKbjDt86fWB8WK+NrNwYdpV/Lr+xGPJ4VBZMwyal Dw+uiAFEgSzDqs7U0qtEdDHtT+3grYW2oXkGY0WxXYhu2DnpF6w7rEIe3c6j9ruI X-Gm-Gg: ASbGnctfdKy+MTJAxDcnFwd+xkLWnXnl1WY0xSPtuSqvQlbDIpdAJpl56t9kIK6sSVP LYC38YGo/xxt/Qw+sxerXcF+MvZf9Kq7rF/oa7QpVv2d1mxl4G3z5RWkC+2xfT72hBOhIP4mHmK LMU42fz3ibYvGlAY0BVjtG0Tze8ze1To+4deQehCvMY5RGubgesq+Lt7ND5lDkN2mRKPQ/ZuOuq hAUj99l/dPfiXkjKvi4dDE6t9OiZalPgotNzCnpIZuyb3IzfuzvM6UMKsRxYFG/gUdPgKUks32g 8nhAn4r2Pm+2PLrBP6i2fQx45rO/vTNvEKt3UiUkky9HO9/jh3jIugpk1ZnTcKWAq1/XfzD509n Ild53mbV5qdApYgUXuPTX3eTfzZSUGbYNrT2t09tumQt7YLI77fGHdYm0YRrqXA== X-Google-Smtp-Source: AGHT+IEW/uO8bExTCAWVsP75Hs6qPB7WKcfr8U/dDlSXDxKlAstSE0vL7MmDMw/oC+fIWQgrVF1QlQ== X-Received: by 2002:a05:6512:239e:b0:55f:34e8:b1b8 with SMTP id 2adb3069b0e04-55f709b9c2dmr2943696e87.55.1756803832393; Tue, 02 Sep 2025 02:03:52 -0700 (PDT) From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Mykola Kvach , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Volodymyr Babchuk Subject: [PATCH v13 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests Date: Tue, 2 Sep 2025 12:03:45 +0300 Message-ID: <53cc6a9cf7a73d12c632bf8b8eee2f7069e6b0f1.1756803419.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1756803858150116600 Content-Type: text/plain; charset="utf-8" From: Mykola Kvach Add support for the PSCI SYSTEM_SUSPEND function in the vPSCI interface, allowing guests to request suspend via the PSCI v1.0 SYSTEM_SUSPEND call (both 32-bit and 64-bit variants). Implementation details: - Add SYSTEM_SUSPEND function IDs to PSCI definitions - Trap and handle SYSTEM_SUSPEND in vPSCI - Allow only non-hardware domains to invoke SYSTEM_SUSPEND; return PSCI_NOT_SUPPORTED for the hardware domain to avoid halting the system in hwdom_shutdown() via domain_shutdown - Require all secondary VCPUs of the calling domain to be offline before suspend, as mandated by the PSCI specification The arch_domain_resume() function is an architecture-specific hook that is invoked during domain resume to perform any necessary setup or restoration steps required by the platform. The new vpsci_vcpu_up_prepare() helper is called on the resume path to set = up the vCPU context (such as entry point, some system regs and context ID) bef= ore resuming a suspended guest. This keeps ARM/vPSCI-specific logic out of comm= on code and avoids intrusive changes to the generic resume flow. Usage: For Linux-based guests, suspend can be initiated with: echo mem > /sys/power/state or via: systemctl suspend Resuming the guest is performed from control domain using: xl resume Signed-off-by: Mykola Kvach Reviewed-by: Volodymyr Babchuk --- Changes in V13: - use __has_include plus static inline function instead of arch_domain_resume stubs Changes in v12: - Use the input vCPU from vpsci_vcpu_up_prepare function argument instead o= f current. - Add a check for the wake_cpu pointer on resume. - Call arch_domain_resume() under shutdown_lock. - Drop redundant vgic_clear_pending_irqs() call from vpsci_vcpu_up_prepare(= ). - Cosmetic fixes. Changes in V11: - introduce arch_domain_resume() and vpsci_vcpu_up_prepare(), which are now called on the resume path to avoid extra modifications to common code. The vCPU context is now updated during domain resume. Changes in V10: - small changes to the commit message reflect updates introduced in this version of the patch. - Comments are improved, clarified, and expanded, especially regarding PSCI requirements and context handling. - An ARM-specific helper (domain_resume_nopause_helper) - gprintk() and PRIregister are used for logging in vPSCI code. - An isb() is added before p2m_save_state - The is_64bit_domain check is dropped when masking the upper part of entry point and cid for SMC32 SYSTEM_SUSPEND PSCI calls Changes in V9: - no functional changes - cosmetic chnages after review - enhance commit message and add extra comment to the code after review Changes in V8: - GIC and virtual timer context must be saved when the domain suspends - rework locking - minor changes after code review Changes in V7: - add proper locking - minor changes after code review Changes in V6: - skip execution of ctxt_switch_from for vcpu that is in paused domain - add implementation of domain_resume without domain_pause - add helper function to determine if vcpu is suspended or not - ignore upper 32 bits of argument values when the domain is 64-bit and calls the SMC32 SYSTEM_SUSPEND function - cosmetic changes after review Changes in V5: - don't use standby mode, restore execution in a provided by guest point - move checking that all CPUs, except current one, are offline to after pausing the vCPUs - provide ret status from arch_domain_shutdown and handle it in domain_shutdown - adjust VPSCI_NR_FUNCS to reflect the number of newly added PSCI functions Changes in V4: Dropped all changes related to watchdog, domain is marked as shutting down in domain_shutdown and watchdog timeout handler won't trigger because of it. Previous versions included code to manage Xen watchdog timers during suspen= d, but this was removed. When a guest OS starts the Xen watchdog (either via t= he kernel driver or xenwatchdogd), it is responsible for managing that state across suspend/resume. On Linux, the Xen kernel driver properly stops the watchdog during suspend. However, when xenwatchdogd is used instead, suspend handling is incomplete, potentially leading to watchdog-triggered resets on resume. Xen leaves watchdog handling to the guest OS and its services. Dropped all changes related to VCPU context, because instead domain_shutdown is used, so we don't need any extra changes for suspending domain. Changes in V3: Dropped all domain flags and related code (which touched common functions l= ike vcpu_unblock), keeping only the necessary changes for Xen suspend/resume, i= .e. suspend/resume is now fully supported only for the hardware domain. Proper support for domU suspend/resume will be added in a future patch. This patch does not yet include VCPU context reset or domain context restoration in VCPU. --- xen/arch/arm/domain.c | 37 ++++++++ xen/arch/arm/include/asm/domain.h | 6 ++ xen/arch/arm/include/asm/perfc_defn.h | 1 + xen/arch/arm/include/asm/psci.h | 2 + xen/arch/arm/include/asm/suspend.h | 18 ++++ xen/arch/arm/include/asm/vpsci.h | 5 +- xen/arch/arm/vpsci.c | 116 +++++++++++++++++++++----- xen/common/domain.c | 9 ++ xen/include/xen/domain.h | 11 +++ 9 files changed, 183 insertions(+), 22 deletions(-) create mode 100644 xen/arch/arm/include/asm/suspend.h diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 863ae18157..7d7358abe5 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -12,6 +12,8 @@ #include #include =20 +#include + #include #include #include @@ -27,6 +29,7 @@ #include #include #include +#include #include =20 #include "vpci.h" @@ -880,6 +883,40 @@ void arch_domain_creation_finished(struct domain *d) p2m_domain_creation_finished(d); } =20 +int arch_domain_resume(struct domain *d) +{ + int rc; + typeof(d->arch.resume_ctx) *ctx =3D &d->arch.resume_ctx; + + if ( !d->is_shutting_down || d->shutdown_code !=3D SHUTDOWN_suspend ) + { + dprintk(XENLOG_WARNING, + "%pd: Invalid domain state for resume: is_shutting_down=3D= %d, shutdown_code=3D%d\n", + d, d->is_shutting_down, d->shutdown_code); + return -EINVAL; + } + + /* + * It is still possible to call domain_shutdown() with a suspend reason + * via some hypercalls, such as SCHEDOP_shutdown or SCHEDOP_remote_shu= tdown. + * In these cases, the resume context will be empty. + * This is not expected to cause any issues, so we just warn about the + * situation and return without error, allowing the existing logic to + * proceed as expected. + */ + if ( !ctx->wake_cpu ) + { + dprintk(XENLOG_WARNING, "%pd: Invalid wake CPU pointer for resume\= n", + d); + return 0; + } + + rc =3D vpsci_vcpu_up_prepare(ctx->wake_cpu , ctx->ep, ctx->cid); + memset(ctx, 0, sizeof(*ctx)); + + return rc; +} + static int is_guest_pv32_psr(uint32_t psr) { switch (psr & PSR_MODE_MASK) diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/d= omain.h index a3487ca713..68185fc4d6 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -121,6 +121,12 @@ struct arch_domain void *tee; #endif =20 + struct resume_info { + register_t ep; + register_t cid; + struct vcpu *wake_cpu; + } resume_ctx; + } __cacheline_aligned; =20 struct arch_vcpu diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/a= sm/perfc_defn.h index effd25b69e..8dfcac7e3b 100644 --- a/xen/arch/arm/include/asm/perfc_defn.h +++ b/xen/arch/arm/include/asm/perfc_defn.h @@ -33,6 +33,7 @@ PERFCOUNTER(vpsci_system_reset, "vpsci: system_res= et") PERFCOUNTER(vpsci_cpu_suspend, "vpsci: cpu_suspend") PERFCOUNTER(vpsci_cpu_affinity_info, "vpsci: cpu_affinity_info") PERFCOUNTER(vpsci_features, "vpsci: features") +PERFCOUNTER(vpsci_system_suspend, "vpsci: system_suspend") =20 PERFCOUNTER(vcpu_kick, "vcpu: notify other vcpu") =20 diff --git a/xen/arch/arm/include/asm/psci.h b/xen/arch/arm/include/asm/psc= i.h index 4780972621..48a93e6b79 100644 --- a/xen/arch/arm/include/asm/psci.h +++ b/xen/arch/arm/include/asm/psci.h @@ -47,10 +47,12 @@ void call_psci_system_reset(void); #define PSCI_0_2_FN32_SYSTEM_OFF PSCI_0_2_FN32(8) #define PSCI_0_2_FN32_SYSTEM_RESET PSCI_0_2_FN32(9) #define PSCI_1_0_FN32_PSCI_FEATURES PSCI_0_2_FN32(10) +#define PSCI_1_0_FN32_SYSTEM_SUSPEND PSCI_0_2_FN32(14) =20 #define PSCI_0_2_FN64_CPU_SUSPEND PSCI_0_2_FN64(1) #define PSCI_0_2_FN64_CPU_ON PSCI_0_2_FN64(3) #define PSCI_0_2_FN64_AFFINITY_INFO PSCI_0_2_FN64(4) +#define PSCI_1_0_FN64_SYSTEM_SUSPEND PSCI_0_2_FN64(14) =20 /* PSCI v0.2 affinity level state returned by AFFINITY_INFO */ #define PSCI_0_2_AFFINITY_LEVEL_ON 0 diff --git a/xen/arch/arm/include/asm/suspend.h b/xen/arch/arm/include/asm/= suspend.h new file mode 100644 index 0000000000..c8ea84bd40 --- /dev/null +++ b/xen/arch/arm/include/asm/suspend.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __ASM_ARM_SUSPEND_H__ +#define __ASM_ARM_SUSPEND_H__ + +int arch_domain_resume(struct domain *d); + +#endif /* __ASM_ARM_SUSPEND_H__ */ + + /* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/vpsci.h b/xen/arch/arm/include/asm/vp= sci.h index 0cca5e6830..d790ab3715 100644 --- a/xen/arch/arm/include/asm/vpsci.h +++ b/xen/arch/arm/include/asm/vpsci.h @@ -23,12 +23,15 @@ #include =20 /* Number of function implemented by virtual PSCI (only 0.2 or later) */ -#define VPSCI_NR_FUNCS 12 +#define VPSCI_NR_FUNCS 14 =20 /* Functions handle PSCI calls from the guests */ bool do_vpsci_0_1_call(struct cpu_user_regs *regs, uint32_t fid); bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uint32_t fid); =20 +int vpsci_vcpu_up_prepare(struct vcpu *v, register_t entry_point, + register_t context_id); + #endif /* __ASM_VPSCI_H__ */ =20 /* diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c index 7ba9ccd94b..22c3a5f544 100644 --- a/xen/arch/arm/vpsci.c +++ b/xen/arch/arm/vpsci.c @@ -10,32 +10,16 @@ =20 #include =20 -static int do_common_cpu_on(register_t target_cpu, register_t entry_point, - register_t context_id) +int vpsci_vcpu_up_prepare(struct vcpu *v, register_t entry_point, + register_t context_id) { - struct vcpu *v; - struct domain *d =3D current->domain; - struct vcpu_guest_context *ctxt; int rc; + struct domain *d =3D v->domain; bool is_thumb =3D entry_point & 1; - register_t vcpuid; - - vcpuid =3D vaffinity_to_vcpuid(target_cpu); - - if ( (v =3D domain_vcpu(d, vcpuid)) =3D=3D NULL ) - return PSCI_INVALID_PARAMETERS; - - /* THUMB set is not allowed with 64-bit domain */ - if ( is_64bit_domain(d) && is_thumb ) - return PSCI_INVALID_ADDRESS; - - if ( !test_bit(_VPF_down, &v->pause_flags) ) - return PSCI_ALREADY_ON; + struct vcpu_guest_context *ctxt; =20 if ( (ctxt =3D alloc_vcpu_guest_context()) =3D=3D NULL ) - return PSCI_DENIED; - - vgic_clear_pending_irqs(v); + return -ENOMEM; =20 memset(ctxt, 0, sizeof(*ctxt)); ctxt->user_regs.pc64 =3D (u64) entry_point; @@ -76,8 +60,37 @@ static int do_common_cpu_on(register_t target_cpu, regis= ter_t entry_point, free_vcpu_guest_context(ctxt); =20 if ( rc < 0 ) + return rc; + + return 0; +} + +static int do_common_cpu_on(register_t target_cpu, register_t entry_point, + register_t context_id) +{ + struct vcpu *v; + struct domain *d =3D current->domain; + int rc; + bool is_thumb =3D entry_point & 1; + register_t vcpuid; + + vcpuid =3D vaffinity_to_vcpuid(target_cpu); + + if ( (v =3D domain_vcpu(d, vcpuid)) =3D=3D NULL ) + return PSCI_INVALID_PARAMETERS; + + /* THUMB set is not allowed with 64-bit domain */ + if ( is_64bit_domain(d) && is_thumb ) + return PSCI_INVALID_ADDRESS; + + if ( !test_bit(_VPF_down, &v->pause_flags) ) + return PSCI_ALREADY_ON; + + rc =3D vpsci_vcpu_up_prepare(v, entry_point, context_id); + if ( rc ) return PSCI_DENIED; =20 + vgic_clear_pending_irqs(v); vcpu_wake(v); =20 return PSCI_SUCCESS; @@ -197,6 +210,48 @@ static void do_psci_0_2_system_reset(void) domain_shutdown(d,SHUTDOWN_reboot); } =20 +static int32_t do_psci_1_0_system_suspend(register_t epoint, register_t ci= d) +{ + int32_t rc; + struct vcpu *v; + struct domain *d =3D current->domain; + bool is_thumb =3D epoint & 1; + + /* THUMB set is not allowed with 64-bit domain */ + if ( is_64bit_domain(d) && is_thumb ) + return PSCI_INVALID_ADDRESS; + + /* SYSTEM_SUSPEND is not supported for the hardware domain yet */ + if ( is_hardware_domain(d) ) + return PSCI_NOT_SUPPORTED; + + /* Ensure that all CPUs other than the calling one are offline */ + domain_lock(d); + for_each_vcpu ( d, v ) + { + if ( v !=3D current && is_vcpu_online(v) ) + { + domain_unlock(d); + return PSCI_DENIED; + } + } + domain_unlock(d); + + rc =3D domain_shutdown(d, SHUTDOWN_suspend); + if ( rc ) + return PSCI_DENIED; + + d->arch.resume_ctx.ep =3D epoint; + d->arch.resume_ctx.cid =3D cid; + d->arch.resume_ctx.wake_cpu =3D current; + + gprintk(XENLOG_DEBUG, + "SYSTEM_SUSPEND requested, epoint=3D0x%"PRIregister", cid=3D0x= %"PRIregister"\n", + epoint, cid); + + return rc; +} + static int32_t do_psci_1_0_features(uint32_t psci_func_id) { /* /!\ Ordered by function ID and not name */ @@ -214,6 +269,8 @@ static int32_t do_psci_1_0_features(uint32_t psci_func_= id) case PSCI_0_2_FN32_SYSTEM_OFF: case PSCI_0_2_FN32_SYSTEM_RESET: case PSCI_1_0_FN32_PSCI_FEATURES: + case PSCI_1_0_FN32_SYSTEM_SUSPEND: + case PSCI_1_0_FN64_SYSTEM_SUSPEND: case ARM_SMCCC_VERSION_FID: return 0; default: @@ -344,6 +401,23 @@ bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uin= t32_t fid) return true; } =20 + case PSCI_1_0_FN32_SYSTEM_SUSPEND: + case PSCI_1_0_FN64_SYSTEM_SUSPEND: + { + register_t epoint =3D PSCI_ARG(regs, 1); + register_t cid =3D PSCI_ARG(regs, 2); + + if ( fid =3D=3D PSCI_1_0_FN32_SYSTEM_SUSPEND ) + { + epoint &=3D GENMASK(31, 0); + cid &=3D GENMASK(31, 0); + } + + perfc_incr(vpsci_system_suspend); + PSCI_SET_RESULT(regs, do_psci_1_0_system_suspend(epoint, cid)); + return true; + } + default: return false; } diff --git a/xen/common/domain.c b/xen/common/domain.c index 104e917f07..667017c5e1 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1352,6 +1352,7 @@ int domain_shutdown(struct domain *d, u8 reason) void domain_resume(struct domain *d) { struct vcpu *v; + int rc; =20 /* * Some code paths assume that shutdown status does not get reset under @@ -1361,6 +1362,13 @@ void domain_resume(struct domain *d) =20 spin_lock(&d->shutdown_lock); =20 + rc =3D arch_domain_resume(d); + if ( rc ) + { + printk("%pd: Failed to resume domain (ret %d)\n", d, rc); + goto fail; + } + d->is_shutting_down =3D d->is_shut_down =3D 0; d->shutdown_code =3D SHUTDOWN_CODE_INVALID; =20 @@ -1371,6 +1379,7 @@ void domain_resume(struct domain *d) v->paused_for_shutdown =3D 0; } =20 + fail: spin_unlock(&d->shutdown_lock); =20 domain_unpause(d); diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index e10baf2615..63b81f8fba 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -8,6 +8,10 @@ =20 #include =20 +#if __has_include() +#include +#endif + struct guest_area { struct page_info *pg; void *map; @@ -109,6 +113,13 @@ int arch_domain_soft_reset(struct domain *d); =20 void arch_domain_creation_finished(struct domain *d); =20 +#if !__has_include() +static inline int arch_domain_resume(struct domain *d) +{ + return 0; +} +#endif /* !__has_include() */ + void arch_p2m_set_access_required(struct domain *d, bool access_required); =20 int arch_set_info_guest(struct vcpu *v, vcpu_guest_context_u c); --=20 2.48.1 From nobody Thu Oct 30 18:31:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1756803860; cv=none; d=zohomail.com; s=zohoarc; b=UHPjFviKknecjJ22ClgfjanZWY/yLWRt+vlDdBau1kE5FtWCZ9rH30iG3STYAcEcrzAuB/tCVLkr/B9UHLvAXVoIHtqCisbp7GisPo57zuet+oxfJttKN01swuIxrJJVuiYfyCr6iRJ9sn6e/7R7rewMDiK73CmwO1qvsJ/Ss0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756803860; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iKQtb2yDXXgVIM20M/9ZKDqMqVSaENj70H3OApwPWOA=; b=Xq3x3e/I28Qt8jLPmxfcek5Y5HV4fq9Gowbc8EcRJUq2J3SoLb0uvmBuVqEgto9HA18kukP76KGB4bYCI8dazT1NY7lJ45QepupISbrC0BfZ90wmFBSKlliif+b8sryZiu7sxOyJrl2abZhvPcBHfTMsRATuCEtbYH72FJ4U2zo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756803860565676.3012706675509; Tue, 2 Sep 2025 02:04:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1105852.1456709 (Exim 4.92) (envelope-from ) id 1utMvq-0001DK-Bb; Tue, 02 Sep 2025 09:04:02 +0000 Received: by outflank-mailman (output) from mailman id 1105852.1456709; Tue, 02 Sep 2025 09:04:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utMvq-0001D3-8X; Tue, 02 Sep 2025 09:04:02 +0000 Received: by outflank-mailman (input) for mailman id 1105852; Tue, 02 Sep 2025 09:04:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utMvo-0000FE-RS for xen-devel@lists.xenproject.org; Tue, 02 Sep 2025 09:04:00 +0000 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [2a00:1450:4864:20::231]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c036c170-87db-11f0-8dd7-1b34d833f44b; Tue, 02 Sep 2025 11:03:54 +0200 (CEST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-336bbcebca9so27128181fa.1 for ; Tue, 02 Sep 2025 02:03:54 -0700 (PDT) Received: from yp-VivoBook-ASUSLaptop-M1503QA-M1503QA.. ([95.67.15.120]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-560827aabf5sm524019e87.137.2025.09.02.02.03.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 02:03:52 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c036c170-87db-11f0-8dd7-1b34d833f44b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756803833; x=1757408633; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iKQtb2yDXXgVIM20M/9ZKDqMqVSaENj70H3OApwPWOA=; b=Mrw+WBgRuEPBe/fKIgym6g029AmtebPFYdTWgpyryjuY7ONrd1nqBN1gAz7kxCfZMf 95VxTGF2bdac1EWNKGlZklXMSn4vRnPQ2TeBeAPYMwLHu2yITF9kPgUM94fbc8rrEETq NfPUDskod38zj0/cEZEm4dtZk9IlKVdgnIK2F/rYA4rfgmwwlUKzCPcaAtIJNDgsSpxO N51TLV+8HLTFg+ZovxgbcO/kmz1Rxh/affSmh5WYrapUlYnrLgDl/h0PEicdU7IaXRgW kvNlnPEZGiP26gLs5w0avRVy+QWrBobkeCTSHitsjDQHp3WrRHXAxpI3muV7DGUmGmZW Ro5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756803833; x=1757408633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iKQtb2yDXXgVIM20M/9ZKDqMqVSaENj70H3OApwPWOA=; b=CmnIhyyyPYnx7ki7LvnLxbRC3Si+V8z0zvqKCg5jJJeQqQK36cMutPSlH2h8EItD1p 8/8NOcloseQSZlU3enQg8XtatiyW0FQlF2Xxj2QxD2wulgBuGGMUg2PX9JJABV4Fq8GN VQv6fBq5AaapF16t60OEN4dYhtU4Shz35xjk7KA5vPNngdmGAc5sha74+rqsi+LsKgv5 W5tOGaPXyBgt+LySeJYjHT1bMy7hj5wPMqvIJt7UXSotLKb6XYnQyoWyrqdN45GusHxE bKAFKkz6RN30FG5Dh3wp0j2bAnfYkWnTqxSKjMEKgN6sNMMGtAUFgaTQSmH2ZxQd1xEX Wp/A== X-Gm-Message-State: AOJu0Yw82+HvFvbPmihKq2jTHxEemZDj7k1OGyZMm5cc2U0wzuHVY2Qt h4vDTLBECRHQ0Uha1KdX5bNefLIEYQWotZSeoti9YoxGxiQn5AOuqQTrihw3oApv X-Gm-Gg: ASbGncus30o4RK1RXUu9p29A8dNT+fer/rjTCl2nT8n/5X2XDXu5SH2ZXwUAsO9fbS2 kAovmeihLneoLQC2n9xvAUChImb6QFYTYinKzp9UgsOf2a3raNyBM/Ohqb4AU+U/08vwODlpPvt UYfvIx+0NVyd2E+fuWNNUbBKW3N65gRh+RFgxrwf3vTWbHhI0aQKiOIqSPjDM6nHRAuBkBjWs7v vHA6hMU2oykNQkmqfhPf4sBmUexy0TEra4uuMMQL2yMGlaLoU/95/Zbt/Nl2zT9aZPy78GElQVn V72IEGpgE4XvN8S7MmaljeAzGJJMNGZXxveeSiMNkwhdJXcP9Tsq0zGOWwoOW6bHkEi6bGb63J6 d6WUuovB1a2fYuxcMNGNWsv9TI94MHL4HpTe7r3BY+GZS5/kVWiS3y5hWvpV1dQ== X-Google-Smtp-Source: AGHT+IHWIeHHjMI4/q8ByA7QG0siSIFWtMD4pXqXFl9/kNEueqD20PIykgcXRmt500riGkhpKcKNMw== X-Received: by 2002:a05:651c:150b:b0:336:e0b3:235a with SMTP id 38308e7fff4ca-336e0b33082mr22657221fa.8.1756803833160; Tue, 02 Sep 2025 02:03:53 -0700 (PDT) From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Mykola Kvach , Anthony PERARD , Juergen Gross Subject: [PATCH v13 2/4] tools/xl: Allow compilation of 'xl resume' command on Arm Date: Tue, 2 Sep 2025 12:03:46 +0300 Message-ID: <6553b10eb258b6f3a481d70d535731b397607c75.1756803419.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1756803861952116600 Content-Type: text/plain; charset="utf-8" From: Mykola Kvach The "xl resume" command was previously excluded from Arm builds because system suspend/resume (e.g., SYSTEM_SUSPEND via vPSCI) was not implemented. On x86, this command is used for resume. This change enables compilation of `xl resume` on Arm regardless of the underlying implementation status, making the tool available for testing and future feature support. The relevant libxl infrastructure and handler functions are already present and usable. Note: This does not imply full system suspend/resume support on Arm. The `xl suspend` command still does not work on Arm platforms. Signed-off-by: Mykola Kvach Acked-by: Anthony PERARD --- Changes in v7: - dropped renaming of LIBXL_HAVE_NO_SUSPEND_RESUME macro Changes in v6: - Renamed macro from LIBXL_HAVE_NO_SUSPEND_RESUME to LIBXL_HAVE_NO_SUSPEND to better reflect the scope of this change - Applied cosmetic changes based on review feedback --- tools/include/libxl.h | 1 - tools/xl/xl.h | 4 ++-- tools/xl/xl_cmdtable.c | 4 ++-- tools/xl/xl_migrate.c | 2 +- tools/xl/xl_saverestore.c | 2 +- tools/xl/xl_vmcontrol.c | 12 ++++++------ 6 files changed, 12 insertions(+), 13 deletions(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 185f74d8a8..b204fc5e2e 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1140,7 +1140,6 @@ typedef struct libxl__ctx libxl_ctx; * restoring or migrating a domain. In this case the related functions * should be expected to return failure. That is: * - libxl_domain_suspend - * - libxl_domain_resume * - libxl_domain_remus_start */ #if defined(__arm__) || defined(__aarch64__) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 45745f0dbb..9233b73f85 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -65,7 +65,7 @@ static const char migrate_permission_to_go[]=3D "domain is yours, you are cleared to unpause"; static const char migrate_report[]=3D "my copy unpause results are as follows"; -#endif +#endif /* !LIBXL_HAVE_NO_SUSPEND_RESUME */ =20 /* followed by one byte: * 0: everything went well, domain is running @@ -130,8 +130,8 @@ int main_migrate_receive(int argc, char **argv); int main_save(int argc, char **argv); int main_migrate(int argc, char **argv); int main_suspend(int argc, char **argv); +#endif /* !LIBXL_HAVE_NO_SUSPEND_RESUME */ int main_resume(int argc, char **argv); -#endif int main_dump_core(int argc, char **argv); int main_pause(int argc, char **argv); int main_unpause(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 06a0039718..bcb2d233cc 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -198,12 +198,12 @@ const struct cmd_spec cmd_table[] =3D { "Suspend a domain to RAM", "", }, +#endif /* !LIBXL_HAVE_NO_SUSPEND_RESUME */ { "resume", &main_resume, 0, 1, "Resume a domain from RAM", "", }, -#endif { "dump-core", &main_dump_core, 0, 1, "Core dump a domain", @@ -548,7 +548,7 @@ const struct cmd_spec cmd_table[] =3D { " checkpoint must be disabled.\n" "-p Use COLO userspace proxy." }, -#endif +#endif /* !LIBXL_HAVE_NO_SUSPEND_RESUME */ { "devd", &main_devd, 0, 1, "Daemon that listens for devices and launches backends", diff --git a/tools/xl/xl_migrate.c b/tools/xl/xl_migrate.c index b8594f44a5..4b4a379aa1 100644 --- a/tools/xl/xl_migrate.c +++ b/tools/xl/xl_migrate.c @@ -767,7 +767,7 @@ int main_remus(int argc, char **argv) close(send_fd); return EXIT_FAILURE; } -#endif +#endif /* !LIBXL_HAVE_NO_SUSPEND_RESUME */ =20 =20 /* diff --git a/tools/xl/xl_saverestore.c b/tools/xl/xl_saverestore.c index 953d791d1a..747094ec7b 100644 --- a/tools/xl/xl_saverestore.c +++ b/tools/xl/xl_saverestore.c @@ -270,7 +270,7 @@ int main_save(int argc, char **argv) return EXIT_SUCCESS; } =20 -#endif /* LIBXL_HAVE_NO_SUSPEND_RESUME */ +#endif /* !LIBXL_HAVE_NO_SUSPEND_RESUME */ =20 =20 =20 diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index c813732838..93766f631b 100644 --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -38,11 +38,6 @@ static void suspend_domain(uint32_t domid) libxl_domain_suspend_only(ctx, domid, NULL); } =20 -static void resume_domain(uint32_t domid) -{ - libxl_domain_resume(ctx, domid, 1, NULL); -} - int main_suspend(int argc, char **argv) { int opt; @@ -55,6 +50,12 @@ int main_suspend(int argc, char **argv) =20 return EXIT_SUCCESS; } +#endif /* !LIBXL_HAVE_NO_SUSPEND_RESUME */ + +static void resume_domain(uint32_t domid) +{ + libxl_domain_resume(ctx, domid, 1, NULL); +} =20 int main_resume(int argc, char **argv) { @@ -68,7 +69,6 @@ int main_resume(int argc, char **argv) =20 return EXIT_SUCCESS; } -#endif =20 static void pause_domain(uint32_t domid) { --=20 2.48.1 From nobody Thu Oct 30 18:31:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1756803861; cv=none; d=zohomail.com; s=zohoarc; b=XUf4iIUemjS8ZqQX6xkqMuzuHSUlOugHfXaz270U3MWaDgf3LYf+swEj4dmSH+P8CoFUwTD7pzLdExBf66VnOzeDv3kqSbaMBPT/LRiZBdnPKKjbyZDXFOU+VGQ3Scx/z/L6IGmsxH+jTFrss/wRZKpJQ4DwYXLTu28FVlA5kJw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756803861; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Xe9xi3DaBptNnLW1VEAJiUhAp27nm19FtXNKIdaX+1M=; b=DbOcwCTL61YAq0UbpVVdO61M4F1Mjq++gZnv7M5f3NuyYglV7xhZj/7AuJ0n9oFu++grR5v8q92qBuBHJtCt+5Ora4FyxWgdMWqiBHx2mgmYrGRsMza8hBxuOxztr1OO1CSZNZE7hpaS5t6YUkmJqf1jgZPs+1RnHN3KTNxKpkE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756803861746926.8309634264289; Tue, 2 Sep 2025 02:04:21 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1105850.1456689 (Exim 4.92) (envelope-from ) id 1utMvm-0000hM-RD; Tue, 02 Sep 2025 09:03:58 +0000 Received: by outflank-mailman (output) from mailman id 1105850.1456689; Tue, 02 Sep 2025 09:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utMvm-0000hF-Ng; Tue, 02 Sep 2025 09:03:58 +0000 Received: by outflank-mailman (input) for mailman id 1105850; Tue, 02 Sep 2025 09:03:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utMvk-0000FD-Pp for xen-devel@lists.xenproject.org; Tue, 02 Sep 2025 09:03:56 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c0ef90bc-87db-11f0-8adc-4578a1afcccb; Tue, 02 Sep 2025 11:03:55 +0200 (CEST) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-55f7c0fb972so1927606e87.3 for ; Tue, 02 Sep 2025 02:03:55 -0700 (PDT) Received: from yp-VivoBook-ASUSLaptop-M1503QA-M1503QA.. ([95.67.15.120]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-560827aabf5sm524019e87.137.2025.09.02.02.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 02:03:53 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0ef90bc-87db-11f0-8adc-4578a1afcccb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756803834; x=1757408634; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xe9xi3DaBptNnLW1VEAJiUhAp27nm19FtXNKIdaX+1M=; b=dUL+aX5qWSZNxFaHkRwM5RoMixoEbY9aAmIg18v57t7A1EVRjEWvnZ4AjSwunaiisp JULIoYOv/TGfcFANWe4Blc/sVPv2I6EoJS9LbZdoHcENy1kT4NIukxB3IA6GmO1xRSCn Fr6oOQKbq9L3TzMvvXYow0kuLBGfEkEonRvqa+iI7ZRfpwNt8qnW7WygKXxIuK6iCaoi y3S64km5zL5+BXF1hmwJ0AonUid6oPTjjltgJzsLfnEFsJSwBszSTfQ7mSWPC4pM/CbI zN4MZLikh6JoV2s54/g/F28mj5R3VIN8/prMfkO/jKGmFOJfwRxh0w260cdrC9dcmtH2 Srmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756803834; x=1757408634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xe9xi3DaBptNnLW1VEAJiUhAp27nm19FtXNKIdaX+1M=; b=RXj3rcckjFrWnmfxc/iCA0mFawvAYJPW6UpUMcsdJ5EGLESh4E01sJu5H5JHilELeQ rxINy4tToFhHu4mFPg4o4Q1kHAXDtF0CDluLqRyVP6QVKkafOTpVto3S4HRg+LtO/3nJ jerY+MRP0UqfjUHjxn243wLy4EAGaq/rp1RcRiLjDiezfpzZmAOConrps9exT28MOcnW OIzFehifD7V9lgY4V2QILxYOpqN+F65i9ZLMJFkXbtts+XoBjNVogko7m8tgBdZl/SeS JDoX11Udj7Nej0e9cIqfFEXhYWIR6pFaI3VhkU5iTu03Q8iEC5wcaMycQ4h6KevvKife N2hw== X-Gm-Message-State: AOJu0YyzGXM6IIiyP3iivgV8YEK8VJroT/lnRmXCKSYrx9CBnzd7/IC7 0U/XQRDYCSta1f8FxyHC28bm+37MxpOKEN8QxHw24HI66Y0THVqqqOh6GHx5VLMq X-Gm-Gg: ASbGncuMmzVY8G4M8JMGFW9dkzugjEfflxUI5efqgAJ1SgFdFWXq9RReUFDRVB4uimc 5PB7tKd13uEsmgeERURJ+HfYjAxqFYEVE5PPmFwCuWD5bdbVpGIEI1qlpElEBTHPU9waN/MEd+M OlB8bhHKlupKb5qhi0plSYxL5i6e0o4Ev56p/gzsHJgAg0tguzFyP4dcJd2KQOuJrU0yCfiegky y/rfrdqr4cuDqbQssJq3QQ0vS2sSrQZPthbsL+EydjkC0L1fBdfzp3t54eZYDtHpKW1bZp/swFg SRvZVb+Jp70wUk5yiE04mCFuge1AvahHWgAHDo32AQ5LjkIp11dY/eHY+fCzV3TlLsUyxt8NEbM BL4NQb9rj0nWS9/6WnrVqhxT0+7R3RWvrWfZSzpt3wuJ/57fSPFN4UlAkpgGRyvukTsPXhaSv X-Google-Smtp-Source: AGHT+IHNUanPnwKzxrXpPti+ujHJgeQYiDpY8lmWUWwQAx5lCpBYMktXUYgjBdwMwKKiXPGz921lJA== X-Received: by 2002:a05:6512:12c9:b0:55f:5428:eb72 with SMTP id 2adb3069b0e04-55f708ec77fmr2907330e87.35.1756803834283; Tue, 02 Sep 2025 02:03:54 -0700 (PDT) From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Mykola Kvach , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v13 3/4] SUPPORT.md: Document PSCI SYSTEM_SUSPEND support for guests Date: Tue, 2 Sep 2025 12:03:47 +0300 Message-ID: <9dffe19e3ba29020a8f35c0fcf12f088de6b9eea.1756803419.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1756803865371124100 Content-Type: text/plain; charset="utf-8" From: Mykola Kvach Add a new entry under the "Virtual Hardware, QEMU" section documenting support for the optional PSCI SYSTEM_SUSPEND function exposed to guests. This function is available via the virtual PSCI (vPSCI) interface and allows guest domains (domUs) to initiate system suspend operations. The feature is currently marked as "Tech Preview". Signed-off-by: Mykola Kvach Acked-by: Julien Grall --- Changes in V10: - Status of vPSCI SYSTEM_SUSPEND changed from "Experimental" to "Tech Preview" Changes in v6: - Dropped the generic guest PSCI support entry (merged in a separate patch) - This patch now documents only the SYSTEM_SUSPEND optional function - Reworded commit message to match the final form after rebase Changes in v5: - Dropped ARM/PSCI entry: this refers to internal use of PSCI SMC calls, which is not relevant for SUPPORT.md - Added a dedicated entry for PSCI SYSTEM_SUSPEND instead of generic guest PSCI info; guest PSCI support was documented in a separate patch --- SUPPORT.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index 6a82a92189..0ce0903cb1 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -962,8 +962,9 @@ Emulated PSCI interface exposed to guests. We support a= ll mandatory functions of PSCI 1.1. See below for the list of optional PSCI call implemented and their status. =20 - Status, Mandatory: Supported - Status, MIGRATE_INFO_TYPE: Supported + Status, Mandatory: Supported + Status, MIGRATE_INFO_TYPE: Supported + Status, SYSTEM_SUSPEND: Tech Preview =20 ## Virtual Hardware, QEMU =20 --=20 2.48.1 From nobody Thu Oct 30 18:31:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1756803856; cv=none; d=zohomail.com; s=zohoarc; b=HFlbsw9Cf6OOqeR61pq6Ksz8ndWtUevE1HkXCZCFTjJ+sV9hgVpcK3AQMn0m0rh/PSqiZqeTBoh8/8HQ61NFYIjBvehVQrvZyoTwM2NYsdJQoTLmEPjM+vHXfQWCs9MnY4yFmv4wSOEhntPg0Ng2GEMltosvLOohGGrlwKhuagE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756803856; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hngrpYued6VRjNdXSCXsejFnZ9+NvVTFmNBYrfCV2Ms=; b=A+jC75XQs1R7099MVnoMLZedlN76WbmtgeAMjwGzNlDN1oMYJjiKzDyIyFf47ITnWcaHDfJldl0bp4w910uzWSrpsVgm4vTj478ldRQmA0ZUCnQDzdPIkL0j5owcY+MWg+ExTnGfyr1A4uKSuSM+rKxZPIHc8tDGIlWeed23pGU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17568038566482.7503619799039143; Tue, 2 Sep 2025 02:04:16 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1105851.1456699 (Exim 4.92) (envelope-from ) id 1utMvo-0000w4-30; Tue, 02 Sep 2025 09:04:00 +0000 Received: by outflank-mailman (output) from mailman id 1105851.1456699; Tue, 02 Sep 2025 09:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utMvn-0000vu-VO; Tue, 02 Sep 2025 09:03:59 +0000 Received: by outflank-mailman (input) for mailman id 1105851; Tue, 02 Sep 2025 09:03:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utMvm-0000FE-Ef for xen-devel@lists.xenproject.org; Tue, 02 Sep 2025 09:03:58 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1d77575-87db-11f0-8dd7-1b34d833f44b; Tue, 02 Sep 2025 11:03:56 +0200 (CEST) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-55f78e3cdf9so2564900e87.1 for ; Tue, 02 Sep 2025 02:03:56 -0700 (PDT) Received: from yp-VivoBook-ASUSLaptop-M1503QA-M1503QA.. ([95.67.15.120]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-560827aabf5sm524019e87.137.2025.09.02.02.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 02:03:54 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1d77575-87db-11f0-8dd7-1b34d833f44b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756803836; x=1757408636; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hngrpYued6VRjNdXSCXsejFnZ9+NvVTFmNBYrfCV2Ms=; b=Dt37LKb5Rp5PCjx+5YgLP99BEMwk83BXN/4N2GhrZNooVM2nYxIPN+791CPP526JQq 5KDL92vf/kdISxdwz3gnh4qs7I9tcVpc8aT7FwaepTs42yNqOswASv4paf/ThEwpGsn4 KnMuqG3TtWGx5UdLociaC0eAUrJZRdCVIpwHnoCmVT2Np2UzQUkuDfh8xEwQuTkSjWoh W9+YEeNJfXHz9D11+qMd9Hrs+8Q9fDGtzptnpIyeme6pLG0aY8tavOmxR7oqG7qVo+YT POt5AKk0sbk+Q5kScm54a96S0TBSVBi67OZqO9MR687qbetWjo3e7zd60ThTwSnz1K3s /h/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756803836; x=1757408636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hngrpYued6VRjNdXSCXsejFnZ9+NvVTFmNBYrfCV2Ms=; b=nv/gpr+42NrkSyQ9J3j0kiBSasZQDLee2VVbIUOJrRwnB9S4+nURpZOV9yldyRIJ1l y+v9BO2lCzaloJZIvJpGs/st6LCQQIe1nlX6d+dHnapnXxBIyFez4Pe56tZWPqBurf7E QXbLTJJhMZ7ah+phVgtteeosuf4WZnCN7x9Fybk0MUslzePAuqkGOICOSHDX4flHUZmt hiIrR8tm5cPa6KCxWluwzL9wq97M3QssGyAjWDMxAq7kIcaidgoaIlfJfcNaYm5NOUrf Akl65SDDkFkDll3dpPGtXAGwn3D1MZEm9EjoXPlCQ5knQUnsqorv0KOq2XntEgdah9cl NVNg== X-Gm-Message-State: AOJu0YwxsquG8hxBLq97rbqXEaYVX3JrxC1OQaix2UJz/7czlDiHireQ OUwfULPgY7ODHet6PerRxmXmWMN1RZmdFKd74PV4y4a+RWJn6becrdwQxDTsOgSc X-Gm-Gg: ASbGnctjYOD//K4IfzzOmjE276B1LMpIddWRk24QMQLSb+xUz2X13wNImppaQCRE/lx 97+4AEe4adUESKSPCz9xJ2K0QmpvUFUqLXjMf6oEYdfkrDLCwCODm2FTzxxC6mgK/CP0j2BP1v0 X/7Qb+yQDm7BxpR2Xp2hanQSHZY7HlzaIWRAQCikmUkBfq1AqdLvtfuoKE73lhUQeugth86xTjf 8vW2M+igUeP/CMeG2nCQAW+rZpT6/PIYjK4+3iLDmJe4pL8qQFNgbWZcyu44tjB/drD2rKV9s8p 3c1FulD3FM+RWkwwLuoNclI3xHjifU3m4Cd2ZDaiC1ha6Alzu2MH6tWwCfPif/2dNl0Znhhh++M G/PUTYP4TBNMbd5IuZ6WbXwIuUNPh+hcPozxYCx5Z2NX4cIi0WzVbd6U6HQpYRkhXSg45q7Zi X-Google-Smtp-Source: AGHT+IEGDR0zvIgC8giLGGenf6ffDNeOkUoGx5o3gXyi/iwQLHqrZHPK8kf1eGYeTBmfAMeKuFRvEg== X-Received: by 2002:a05:6512:4045:10b0:55f:71ad:5913 with SMTP id 2adb3069b0e04-55f71ad6048mr2708786e87.50.1756803835517; Tue, 02 Sep 2025 02:03:55 -0700 (PDT) From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Mykola Kvach , Oleksii Kurochko , Community Manager Subject: [PATCH v13 4/4] CHANGELOG: Document guest suspend/resume to RAM support on Arm Date: Tue, 2 Sep 2025 12:03:48 +0300 Message-ID: <2b9c5acca22150548c122a851931304c5d1ec565.1756803419.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1756803857954116601 Content-Type: text/plain; charset="utf-8" From: Mykola Kvach Mention the newly added support for guest suspend and resume to/from RAM via vPSCI on Arm platforms. This support is limited to non-hardware domain guests. Signed-off-by: Mykola Kvach Acked-by: Oleksii Kurochko --- Chnages in v6: - removed reduntand explanation that thi support added for both arm32 and arm64. Changes in v5: - adjustments to the commit title and message - expanded the changelog entry to include more context about suspend/resume support introduced in this patch series --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cd34ea87b8..7a75bd37cb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,8 @@ The format is based on [Keep a Changelog](https://keepach= angelog.com/en/1.0.0/) =20 - On Arm: - Ability to enable stack protector + - Support for guest suspend and resume to/from RAM via vPSCI. + Applies only to non-hardware domain guests. =20 ### Removed - On x86: --=20 2.48.1