From nobody Thu Oct 30 23:21:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1751661606; cv=pass; d=zohomail.com; s=zohoarc; b=ETrMF5MEnBot4ZKp1gl8o4ybQVZkerGDkmuNAgktjux3y1z770rCQgpGKjD/hjjCqHY9/TMCTbQP2WHd0j6/42t5xCfrXDSuQSA0qDcnoQUFAHpK9wrUNzr63beC1yW++v50LzZLXm1eridHvHAmXYykda1My9XarlBe7z3zxbI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751661606; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HwsGS5179KhQq+DoYylCMb1ujqL+m54UlfDUzyF979w=; b=iRTeBPpbFO1xL3w2IVDcA1497bpf45HZrufNy5BI4UAfBfZl3lYj6i9Ra2qpJRYyCuKIOJ4983UtxsPSehYEUdk4tzVQwa5m2hrG/gEOI44IMMfLGjZaOfY/8Z5Dp3AmkDgrQnbHHN9p1ldwrsWjZ8+w5B5RLpiCcaayRlacehs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1751661606730204.86051425351104; Fri, 4 Jul 2025 13:40:06 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1033717.1407033 (Exim 4.92) (envelope-from ) id 1uXnCB-00070N-7F; Fri, 04 Jul 2025 20:39:43 +0000 Received: by outflank-mailman (output) from mailman id 1033717.1407033; Fri, 04 Jul 2025 20:39:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnCB-00070E-3p; Fri, 04 Jul 2025 20:39:43 +0000 Received: by outflank-mailman (input) for mailman id 1033717; Fri, 04 Jul 2025 20:39:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnC9-0006X7-4y for xen-devel@lists.xenproject.org; Fri, 04 Jul 2025 20:39:41 +0000 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com [2a01:111:f403:c20a::7]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 019df714-5917-11f0-b894-0df219b8e170; Fri, 04 Jul 2025 22:39:39 +0200 (CEST) Received: from PAVPR03MB10142.eurprd03.prod.outlook.com (2603:10a6:102:32a::16) by AS8PR03MB9414.eurprd03.prod.outlook.com (2603:10a6:20b:5a1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.20; Fri, 4 Jul 2025 20:39:34 +0000 Received: from PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673]) by PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673%3]) with mapi id 15.20.8901.018; Fri, 4 Jul 2025 20:39:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 019df714-5917-11f0-b894-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ITNrJ4M0P6kqifRbj86j9jRFnaKDiLsiDucd1FHYK+CIElqZA46ujZllcK7OLmQAsB0ifx54q+QgEmLJJdTQLnOWSMApm8IwPUryeFh8An/2Vl3yhlDKWJNIS0LhhKAW8/CkDW1HIWrswjpm4/hqVcfc9dvN5sFFCGqmdDWhrxn6y7u/MxPEv2f41eLM3QthULdRGD3K7usKXnnaQyIozUaA7DFsiVSCxlCK6s6UzT+4Ld292/IoLBLojzBR5OGsWdKaklVLKaDaqI4in09vZHiqlygl1A2P5ZXpydriA1FuWLeLYLT9Oa/v/K7LuR1SzbcOIj7IeyfJWbXiHIK8NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HwsGS5179KhQq+DoYylCMb1ujqL+m54UlfDUzyF979w=; b=B/cVCuVlEiwRXmMUkhS2gXqKhVqRERIjONqNUPOTxwGYb/ccjx/vM6rqPTMG4Z0uojyCO066YCG76a8Xwg0Z+aKePhMpmL3O3baK0TVXc10GUYmZgyd2C1KkkaDXlO7LhYdjeK0245ELFM/3Hk+yT1DPjtUimsz8wE9F2W4XPgF4gP1uww8S2yuRZvo8Gl2MLYAknpkQD8i8etxNs0PnBJo1fYEFoSIDMT/Ss23xZQe2k27vLqGAVgksc6qqGxIJkqyti3+P6lXDh4Qp1BwL1DXJeKYbKL96D/Nf0L60rpy7io/FNYU/oKiGA32K98StK1u3KL0WuX/DeApvXiG39A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HwsGS5179KhQq+DoYylCMb1ujqL+m54UlfDUzyF979w=; b=j0SnW8PC7ucj4etNRfx47NKEyJCAiJP7WjdebFWDwOOCxU1mMsy6hwoXhLldUTiwwbBSl/CoSfOzsPkjSPRQZafRfP48UOpo7k88LMqH+zouFecStzSYBuN91nZqglHrMgpoPtc+O+bWvcWHuPOGFewrmJBxSXE67qYPPbCkYMUbEOQGjod6FArtGOoYzfeQKR1o/XWYGsOuM7ano9NS3yuTXaq/9Ucp/TV667DozS7yWCz68TZC/bMEd04TNsACvS0dMnqvSUTOaqYPB2YmeW2beCNw+ZuUfnPBzDpwLexx+dYxNLOqeaKN6ZsGAUWJuXpMK1B7fGyNVMXyFa2A1g== From: Dmytro Prokopchuk1 To: "xen-devel@lists.xenproject.org" CC: Dmytro Prokopchuk1 , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini Subject: [XEN PATCH 1/5] gnttab: address violation of MISRA C Rule 5.5 Thread-Topic: [XEN PATCH 1/5] gnttab: address violation of MISRA C Rule 5.5 Thread-Index: AQHb7SO/ocKpxuM76k2AQCjdidhw/g== Date: Fri, 4 Jul 2025 20:39:33 +0000 Message-ID: <12b31e64625806bcd82d3d820f39c44e71479e1d.1751659393.git.dmytro_prokopchuk1@epam.com> References: In-Reply-To: Accept-Language: en-US, uk-UA, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAVPR03MB10142:EE_|AS8PR03MB9414:EE_ x-ms-office365-filtering-correlation-id: 112e3124-ab08-4208-eaec-08ddbb3ae28e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|42112799006|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?5+E1+Zy0LM/g7EUx8VUtu4yykUv26hCzLvVK8chEFmvWJEkpcbo/WkCPZq?= =?iso-8859-1?Q?Od0b2u8Fna3Dt75gr+dpfVh9Hk9PBNdAZy4dAWiJ50bVQf95Rz/MB9Tv8B?= =?iso-8859-1?Q?hDkTFd3d79kDjBkIVgJ5TkpS98qoWKx6yQuuWETCgbHwZEi4jCaaSkCn5R?= =?iso-8859-1?Q?tczU0iI2qGnSw8akpkHRUOulFYgwJgIexZoXrF31YENA3vjzLWPWWNGz7h?= =?iso-8859-1?Q?biS1QpxdB7niuJ0kdjiOy4q3G7raz9DKq9BS7OgfbUDY9cvGKAooyCiYH+?= =?iso-8859-1?Q?kRGbdls4eXSQDao5hL9bzBdx2zbgGAAt/Q3naYxWcvOKaMN+PMeTq4i2yp?= =?iso-8859-1?Q?wesbcIdj8qYqXyKQr46GE5jlDnyrAGuQIm0EX/2AqE7RNCp1KU2zlB68V9?= =?iso-8859-1?Q?8HMjLWdj+FITESlgoA0MnWFs1rSy+OmqGT3HNKaRmTeCfKTn9bCgGqSyBm?= =?iso-8859-1?Q?ntC99S067eN6Scw3PyKhKa4iMISGW8A3E+y50M+V+SQh+LBCBCFS4jRA56?= =?iso-8859-1?Q?nXqjTFp6kO8pK2M9Lt0Ik2qoF+PE1Bg+jqtasQwlGbIzSkY6wvvNtigRVH?= =?iso-8859-1?Q?T72l/PWhu6MFD1rtbazLL9EpjwkTCUFdd75pvwWieaGwzFOrb3jxA7j+7Z?= =?iso-8859-1?Q?G8uC9+RC1ZPbi0pc62MS2uoCYDLjIe7HILZBXYPQuXxaWe+rP6XMiutA8S?= =?iso-8859-1?Q?fWbBoY7/rcLbSqOzI5B+0eMY1xLepcXlrKMJAJ2J0NAtZ02Rn3SW1uMxLq?= =?iso-8859-1?Q?iuy2uAXQJTkH4Dwp6+dee00VfDax/ypKtRSGUOvBcr6FfJPGdKVG3V0/u4?= =?iso-8859-1?Q?/SlAxLD4bWhZxe/vzhuTrs5ZB9Qx/xhV5mY0aKlTbGscbHW8qrTz9iZhzy?= =?iso-8859-1?Q?nuD57aOvKHLi+swY23hZWoWc38FdgJnarm7yosPh9fcW1kkuo5U1ka5dc9?= =?iso-8859-1?Q?v7OpUvIJKUIFPo2YnjYGPsOZNUnZ8nOlkyrjkxWj4SFypr4/qmIWQuhVj3?= =?iso-8859-1?Q?wplzEIKsc+1gIGzcbav3xUv1NnG5RwAKkBSKnqNXCAdgeV3m2spW7KJ+qj?= =?iso-8859-1?Q?uSk6yQzRGjPdUndZd/tcP8WSchB4WPMv4AJe8P/C57yg055nIWU/OUf2SW?= =?iso-8859-1?Q?wQb3hiEIuoTFucQc5dkORPge48oGMxtv6T6oIYdT+4sh9NE/QKG5aZDoNa?= =?iso-8859-1?Q?toL0xeVSncqZWv7A4wBxLmOwJmWlJe9ckLaNG9YK7mLW9c8pK4zYM/zwNh?= =?iso-8859-1?Q?MkkxI5LToN/gh546yVGCwwjrvr+5GIii1ajWjSqNQX7Si8TQD4GgVtKFyO?= =?iso-8859-1?Q?e4yrIn39SoW1SmufQmQCuLmhNMHQpDkwe+lvhxq4pr7bo3TmwHXkN96NLe?= =?iso-8859-1?Q?31d+swieVHcswOPYr3ESm/PRwlQXvUrYBrbpUTLTQhHIPEs5l8Hm1yyLv/?= =?iso-8859-1?Q?3QZWd9og7yUMZJPrG4sYFLqZMbeZ5p0zYE37Xdl/a4epLkTdzSz+YcORog?= =?iso-8859-1?Q?qAskGqgnekNTFX+XY7cyhIomhpq76MmZyDNccU4FFuyw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAVPR03MB10142.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(42112799006)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?/FGucPtR1QBcgQBfGG12mma96qrcZ8FzCo1Pv7wfGaOTl8UpJjOa3NA+uX?= =?iso-8859-1?Q?gqR+yvcO+AJif5n6/knaQdbBMCX9GcxVmKUbk/++dDH8Wg8vfaCvSKN2SQ?= =?iso-8859-1?Q?XJd99fYOwlvW7WCiLnIGdq1yybFZ5GVnz9jA/LG2W1myNzxG05djNPKNbL?= =?iso-8859-1?Q?SmoGlp4TxPPFdz+g99hGlHurnX6PQv2h9bZZt1DEeDWlzhQLGSXogi6pRx?= =?iso-8859-1?Q?dzCR9f/VEuotCVBU9HDVIJM+nNZO60hi0DfHr0Jdgp60rLzSt3f2HuEKlq?= =?iso-8859-1?Q?zFPnCgnb/rLxvVM0lTjbcXmxXiUUozTFA6DbMKuQvIPGJNsKU5Gm4tWGvk?= =?iso-8859-1?Q?70Kv36GqWrm55R3qBjC3GhJRSFGrI8rdBFzgiQ19MOHXm9V2npostFFRS3?= =?iso-8859-1?Q?hSOXg6r0aionzp7P3D31b624qpe/tP30Fn9dmWcL4+Zqakr44GLcLOLQ1e?= =?iso-8859-1?Q?vP3a5kXmpZYWd/9keFd3tcJgVnxmdC+EbghRoRegCRWG0lhMrN010xAgs+?= =?iso-8859-1?Q?lDsBnACqGKYsM7qPZk6TVdtzjP1hq9hTRa4IKNtSlSd3fq6gIi5dV/S5WK?= =?iso-8859-1?Q?6gNBbSn7igN47H8NfJz0F7wmoD1LQjOj1NjXDSZ/4GkUEFuO2SZt9tORhF?= =?iso-8859-1?Q?+t4gcoRZqWoJ4dBkmNzj2n+tRD5IoaAUXXEvTLXpZkSJ4K6g1MXuKTh2uk?= =?iso-8859-1?Q?1A+WZjqfKLW5z6IKAXZMHihNqAPIFQQrZDZeEIzerWat4poaDzNwSTDt42?= =?iso-8859-1?Q?zZ2gwY1I/Non0l8dcsDszCEFKE4jeJNV8BbNvO6SthBtLjJrgKyApIQQVr?= =?iso-8859-1?Q?wdVA2ax9hNfUshrWVOsXIUvX6tWxINOaCdiRgDhvCB57ke5fKo/qTjuAbR?= =?iso-8859-1?Q?H66D3o6KzfFeEXZZStGiltRo/STIADWY3Le5XqzE3E5IVijj2RfUeFV3TJ?= =?iso-8859-1?Q?xu0wdLuk1b2FMBSaCJ7R5MRhL6q5VCeegIBVM7Z2UfZLblTle8vP12k8Bo?= =?iso-8859-1?Q?wxyzvLxz/4gcjTQ400kIUb1rCFOI83nMBxP0+NLuJ/yLP+mVBIEFw6jCUB?= =?iso-8859-1?Q?R6SLwE/IiP+ujmqGzQcF3tXBiTaP2zbOGzRnLU4K4YaibGISUMDhgPekd1?= =?iso-8859-1?Q?HZqA3y2C//yavZNiIt+PwGlr5mhLAu9uNoKRz3U1WS0Nqf9/ISBFM/vNc0?= =?iso-8859-1?Q?TIZuDw04H3/3FWTI5IVPWT73HaIf1BXTLDnecfEJweYH57HQm7CQ/wtUi4?= =?iso-8859-1?Q?Pz7yyNLPSPujU4jHiSoDOZ1GdELPYBK7qn6LfIOrGsFItxtEOyXWg5dtit?= =?iso-8859-1?Q?iNnWNHw4EpgyViYh/XAZG0g4I2XH2MwheTlkWOrUZHdh644+MuEXK3BO8F?= =?iso-8859-1?Q?IW6CY+4GGPomkrafuiHpPjPcQtjFE7wCrKtOjVSicjb8Ua1grioYIT617D?= =?iso-8859-1?Q?9g9dQhNR2tB/bRft9x8U4Bt2Z8HVsNLv+C1lOuEkLF3X8WRndwxIy0LOF/?= =?iso-8859-1?Q?gFKCrcvbJr+D9LDfEJmCQACcfsYR5z5ODvfxMfrUFae8ZtHQrfH9LpY6em?= =?iso-8859-1?Q?dEjhu6EmKDdifa0qCk+OOjOzHtA/X5Q8PiArd/zGLLPbcOA6k34Y/ce/Xu?= =?iso-8859-1?Q?YXEehizVzSED/kRqYaFBUzqkh02v0nrINvDA16Luc7KXMrwun94sPWsQ?= =?iso-8859-1?Q?=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAVPR03MB10142.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 112e3124-ab08-4208-eaec-08ddbb3ae28e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2025 20:39:33.8306 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9QzMRoFZFEQ/v6pTjIRlcXH5KdEhc0QJxJvfeedgOmwoL3J9zTk90V4FyEnggt1ndv25ztnL7XD/gQ8qcGpfDMpD2OFw5GKqSPKojvoVOBI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB9414 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1751661607893116600 Content-Type: text/plain; charset="utf-8" Address a violation of MISRA C:2012 Rule 5.5: "Identifiers shall be distinct from macro names". Reports for service MC3A2.R5.5: xen/common/grant_table.c: non-compliant macro 'update_gnttab_par' xen/common/grant_table.c: non-compliant macro 'parse_gnttab_limit' The macros above are intended to discard function arguments (unused1, unuse= d2) when compiling with different configurations of CONFIG_HYPFS. This can lead to confusion and unexpected behavior because the macro name and the function name are identical. Split the code and create two distinct function signatures. This ensures that the code behaves predictably and remains compliant. Signed-off-by: Dmytro Prokopchuk --- xen/common/grant_table.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index cf131c43a1..f3282a1d7b 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -126,18 +126,12 @@ static void __init cf_check max_maptrack_frames_init(= struct param_hypfs *par) update_gnttab_par(opt_max_maptrack_frames, par, opt_max_maptrack_frames_val); } -#else -#define update_gnttab_par(v, unused1, unused2) update_gnttab_par(v) -#define parse_gnttab_limit(a, v, unused1, unused2) parse_gnttab_limit(a, v) - -static void update_gnttab_par(unsigned int val, struct param_hypfs *par, - char *parval) -{ -} -#endif =20 static int parse_gnttab_limit(const char *arg, unsigned int *valp, struct param_hypfs *par, char *parval) +#else +static int parse_gnttab_limit(const char *arg, unsigned int *valp) +#endif { const char *e; unsigned long val; @@ -150,7 +144,9 @@ static int parse_gnttab_limit(const char *arg, unsigned= int *valp, return -ERANGE; =20 *valp =3D val; +#ifdef CONFIG_HYPFS update_gnttab_par(val, par, parval); +#endif =20 return 0; } @@ -161,9 +157,13 @@ custom_runtime_param("gnttab_max_frames", parse_gnttab= _max_frames, =20 static int cf_check parse_gnttab_max_frames(const char *arg) { +#ifdef CONFIG_HYPFS return parse_gnttab_limit(arg, &opt_max_grant_frames, param_2_parfs(parse_gnttab_max_frames), opt_max_grant_frames_val); +#else + return parse_gnttab_limit(arg, &opt_max_grant_frames); +#endif } =20 static int cf_check parse_gnttab_max_maptrack_frames(const char *arg); @@ -173,9 +173,13 @@ custom_runtime_param("gnttab_max_maptrack_frames", =20 static int cf_check parse_gnttab_max_maptrack_frames(const char *arg) { +#ifdef CONFIG_HYPFS return parse_gnttab_limit(arg, &opt_max_maptrack_frames, param_2_parfs(parse_gnttab_max_maptrack_fram= es), opt_max_maptrack_frames_val); +#else + return parse_gnttab_limit(arg, &opt_max_maptrack_frames); +#endif } =20 #ifndef GNTTAB_MAX_VERSION --=20 2.43.0 From nobody Thu Oct 30 23:21:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1751661608; cv=pass; d=zohomail.com; s=zohoarc; b=Dls1m08QieH4WKEo5GA2Ik9Tzq5JmSnQZ2dixblWD8T+3OBVyBpIgSZ/qHOjSPxEyB5dGHzV61s/vMjsSHj+7Q7kJDR3hVb31tY80aNvsaKoAF+5oZVWf7WnGmDsZ1YbBHVWWgvq08FOpl22aocX/VulbDzG8HzEBf46yMEaTHo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751661608; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LFEhnjI1bfoyDLK3xv+TPUZ1vpS2vxUiyW7XQCXI7eA=; b=cqupt7ku4KKEp7J1T4YPbzwTS0i6bt7DBSYADcoZHiz/eMeOfYoUWpFPKjaxuopkTRCdLg09j10PGlEHA9nqHo+9mbGIh53B9xtk6+9PaN25qgguwQZXwHDcbeVlwezgjnTabzRpdEFXQLHvoWJI4TyPrEfjBtjELcp5QAcLnb8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1751661608797357.2809992966537; Fri, 4 Jul 2025 13:40:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1033716.1407022 (Exim 4.92) (envelope-from ) id 1uXnC8-0006l8-Rg; Fri, 04 Jul 2025 20:39:40 +0000 Received: by outflank-mailman (output) from mailman id 1033716.1407022; Fri, 04 Jul 2025 20:39:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnC8-0006l1-Nh; Fri, 04 Jul 2025 20:39:40 +0000 Received: by outflank-mailman (input) for mailman id 1033716; Fri, 04 Jul 2025 20:39:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnC7-0006X7-Ia for xen-devel@lists.xenproject.org; Fri, 04 Jul 2025 20:39:39 +0000 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com [2a01:111:f403:c20a::7]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 008bc39b-5917-11f0-b894-0df219b8e170; Fri, 04 Jul 2025 22:39:38 +0200 (CEST) Received: from PAVPR03MB10142.eurprd03.prod.outlook.com (2603:10a6:102:32a::16) by AS8PR03MB9414.eurprd03.prod.outlook.com (2603:10a6:20b:5a1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.20; Fri, 4 Jul 2025 20:39:36 +0000 Received: from PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673]) by PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673%3]) with mapi id 15.20.8901.018; Fri, 4 Jul 2025 20:39:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 008bc39b-5917-11f0-b894-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xBjoLqraoelj018rEINNCjAUwK2j7eUSb1VFeUHkRAJArsdFiB/pmf9hVUMyV+HN0OjeOSlHu77sfPYZOYiClhY9goNUOCiFYlpg3Uv/qM3r0EnPkvBv/wk8i0KretRieistP5pcXg+b8D19UhXkoiimzVA3E9kMmICSVzWLgWxItFecxNf2jLTEMbqTEKCWLw/cI72x/3SUUd7UYeggv81E4tc4D6QVy385UgzvNJWzaYsQlQ605Z/QoPJn6eJhZRFF9s3lZ7MB5+UP3en9Sg+dQgMON/REGEtjPeJlbeYG3UzcjJxH232RVu+sI2VNgMKCi2kb2HxhTal4/gM+ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LFEhnjI1bfoyDLK3xv+TPUZ1vpS2vxUiyW7XQCXI7eA=; b=eCkoNQyLE50ScpXcdZ+FpgXpyBAX2e9w/gsPxqvhvuFhH1HgZDhaQac4bszAMiaONMxur2S0n0igymIf1rF9+vKDrDpbNVVJ8xaR1U3Mg+48xNY4PYI6s+CesY20LnGQHVRxTPdfrNYUNBFrE6fETePZV9JZchnTpdJ2GHOs6ga88tCvJEFS7I3FnuOH9miZAAqIV1PBHdgAdvg3jKAjTlgINeJPLvJ+7Bp6FsskyGIfblv3d6WZQMOrB8ZiqKQ4VO8t8F9qA/9XC5AxkKBFd5MajS5xPLd4Qkbt3kmTYR2leAVY+feLJqsXBrRht5KQRXK66je/uKyEge3FHtwuKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LFEhnjI1bfoyDLK3xv+TPUZ1vpS2vxUiyW7XQCXI7eA=; b=kS6DPuuIQloBBmo3tda925EQGfihAvYU/PirXjj1tkSbpjyTTxzi3SCxhUxFBMX6aYlHIINEAf63DxMXeNLrvGsvwGC9PT5kqM4ogjbmGVLvjdoxsJaD/kG9+6c0aN5aPgO9wHlNQ3XYKYGn7bJtssaan4jHwYQgY8ntGb1rXAFzu8tfVEUbYapwbrxl2JGIiHmxHlXMG58oX6aZer3e5BBPvE3mPFcgNimPOhDznUuSR4qfLROBV1JgoZsJM5tCVxC3LVY4nbqzFw92PcoPuotBViYxAWcM5sUXyffHk0+ZEmnk+C/1vfH4FGFiSHSbwmf9bS8+NmM1cTiS0S5Ejw== From: Dmytro Prokopchuk1 To: "xen-devel@lists.xenproject.org" CC: Dmytro Prokopchuk1 , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: [XEN PATCH 2/5] iommu: address violation of MISRA C Rule 5.5 Thread-Topic: [XEN PATCH 2/5] iommu: address violation of MISRA C Rule 5.5 Thread-Index: AQHb7SPBz9lylza3OEK8worIo7OoNA== Date: Fri, 4 Jul 2025 20:39:35 +0000 Message-ID: <29ba418db4a7a193fe07fa9927b4ab75e0355fcb.1751659393.git.dmytro_prokopchuk1@epam.com> References: In-Reply-To: Accept-Language: en-US, uk-UA, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAVPR03MB10142:EE_|AS8PR03MB9414:EE_ x-ms-office365-filtering-correlation-id: f224c584-2c52-4018-d94e-08ddbb3ae39e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|42112799006|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?+DL1qFnAtdlgw9MZ8jnnVIPk/P40iqHcD76f3vuzRCx8ep34CwWUG6v2K5?= =?iso-8859-1?Q?b7aoBHXYSkVhCI08IA818jkBiPfu7pd81OhkeEQj0U880MCvN7or5juUFl?= =?iso-8859-1?Q?YcT3CepWDI4odiDkpnRr2QQ14JMN6nj9PNYtw3sBGR+HrSRghjbSft0EQM?= =?iso-8859-1?Q?htkFQEQ7E41tLsnuFGubjPxlCw8vM849niQXIPf4Hzq8YUrqYhSciF/7By?= =?iso-8859-1?Q?nWwoFNGTemDivgssZx/PQ+vPTA35f6lPJW88HcsAqD0mPAEGfrbjKUEJ6a?= =?iso-8859-1?Q?mzRcNKqxTkCffAPoorkTWRlDyTiVl5GMHKwKtBD5AFyBfuOSNo34fvqtLv?= =?iso-8859-1?Q?cd92NmdyV8gKkZNiSQy1AUCqroHZkMHxdHpnul+xVfkqjwtv9D6XyIQkp6?= =?iso-8859-1?Q?qHIG8vNzGgZchm3f8dricdh/8lc7BDqksDenQgyrodHvBZTjQdHVR8vfPK?= =?iso-8859-1?Q?LnUadpM8i0tHpXscxSRtZ0CazQK63xXxEBLcZVbcTYZXIBVVD239vuDhDa?= =?iso-8859-1?Q?OKOdn9cbtTCeEO35hLwltajoYbkNhKMVcegx4YYTR8aKKKqqRHKVW1cCwS?= =?iso-8859-1?Q?1ZVdy3NI3TpHlGL08dO7OpidCMG7Q4qIsPVAjDPHFMMlXFeX618iJe0Itn?= =?iso-8859-1?Q?EldHtul0nreDyrsHHvhKtssy/ye2xa/Wc2zUpbpDxRhFbmCYi8SXvEBjiN?= =?iso-8859-1?Q?4rbKrje5aI6lplExB2b4tKIOMU/8S83HDQOO04YJ/aCZOpn14lTblasGfO?= =?iso-8859-1?Q?y4tDx8h+CxY6pZjDPh0ANXgLpj4KXoTZF4JVQ/K6LqqwVjrC3qXfUISHsg?= =?iso-8859-1?Q?gYO5xENIBsq/8HlhuoEazkDj60EzWUJjSVvBjtxhYJq/DlF+nX3CgYJ1li?= =?iso-8859-1?Q?QiHCxxAUqx+Co1PoVhRGLhb8hnvSZq84FC1K6kAK24DTUHOZq/PlVBZu11?= =?iso-8859-1?Q?ui3HGie1gqYcr/yFi76RzPxQ6bx0QLx5NjIK4i9ZVL059j4op7J1sHUyBS?= =?iso-8859-1?Q?qGTpmn8YjJCri7vjp6jyW1D1v+v7InGzixy2P/ASwAqJu0X+3n8u5nqctJ?= =?iso-8859-1?Q?VU8Q110lBsv8DHfMmrMDUN3X6epcGb/PLPfjomcU0eMn4pdWD6EBZn49hK?= =?iso-8859-1?Q?DdJ//rDqGiO1MFvqh9uhRBcZWENcLryIc3vrlmARymGnzn7tTW6zIqVBMu?= =?iso-8859-1?Q?MiNVsE2QylGepzMu/FIi2+TaKjRS+ijkdkYg+sGkQJMFbGprlUzmjMSMIf?= =?iso-8859-1?Q?bSCREfybDtHykNUiUNEohYlWYO73+jo6dPrMvCUH+OK7XXgVgXdfy1IjaJ?= =?iso-8859-1?Q?EVsrXGdSIfWqUoiq9fSVJJ0R+jd1WDhO/hl/b2FgYYdkDcU6HtehngdVSJ?= =?iso-8859-1?Q?9Iw6SFcwfJFk9pDDtA0OslyQYN98TrzcLRiNWf8AuGW4QZV7+wtk79uteS?= =?iso-8859-1?Q?mUiZJEppKEtZztxAxz3I8VdSlIEAsjVGKHx74rTN7BZ/wWCl3uwxZfYYK1?= =?iso-8859-1?Q?yFTFdfHDCDLwTlNZCMbv8Se58VVynG5sHCyfs3oGsKGQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAVPR03MB10142.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(42112799006)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?tZuAu3Hva/wwYekEOOXPUCAxvGmy2x7/Uxqr4qaBQu1RTlMblTj+fj7Z1g?= =?iso-8859-1?Q?ClSB84h+CsJhtK3EVWkwRgXBn82Z4fNykCc3za4KkbFuf9wUy00ZijP6I4?= =?iso-8859-1?Q?NDwo/P60CF0in4uo5NnxQgANA+EE71GIXs2gDUWXX8RE4gUWFjDBI0RfIU?= =?iso-8859-1?Q?CfBWYIxmWKL0NovgLfLkIS24XOLrY0MNfYVOD/wlK0m+HzYwaslU9AJG4l?= =?iso-8859-1?Q?1HpX9Hmc0GWORDVzmzcarnoQ2/YXDJExsmAAi3EdPLfJXD00UELwTZubSe?= =?iso-8859-1?Q?HzRPUG45aOw6stDYExw60+xvrm2Z7YQTE0X66kjh5B+Qmj6Y4Ubsrz6a1T?= =?iso-8859-1?Q?756GfAV8BPTauSUlBBr2LxVuKMkBQ5haby2zPdvchZ9SvsBxqLOKb2QkNq?= =?iso-8859-1?Q?TrKgx+wvP4xK291I5YvualMioKez67SA2SPhJQI8DA4mcFtom23Og5qDUG?= =?iso-8859-1?Q?y1zKukv2LdL3RHWDVnezbTtEFCPJroFSgC6wRitinTcDhXjeEAw2RzLE1t?= =?iso-8859-1?Q?h/6LJRmQSq0H7hRm7e0PiPi1pxw+T/EReG5dnd7ZmI6Ty+t2cP22NPBGNp?= =?iso-8859-1?Q?YOLNZzP/f6llXNyP0IaZC8+g7fCbhrGP6UAbOS5LKK5BJb1hxJS1Ey9ZsS?= =?iso-8859-1?Q?JQCJ837lgzDzVzbjaPqCVFyvV2+2BGBycJXLncZYldlJLYgDUHMcrAtlfe?= =?iso-8859-1?Q?JjZCwMHnXtMTU/l++MlY7bw4hu5MSTHNrCgFF8TledncdvmoUZKMKQd1kD?= =?iso-8859-1?Q?FQmvixBgBpq7c6WycDxIqkZP1QWyyPzgvfG9eEb1z7F6GrcLdJhoTRZkMH?= =?iso-8859-1?Q?qvl0LqWRNaHskRxszhv5U4aU45PcdXjUXcx5kCGFuyPGuYf03DMz8n9B/J?= =?iso-8859-1?Q?G0x7T1FkZaI/UyPL4/sri96tcvMTnraK/1mN2NbcB7vGTWtopnhhGMsGAO?= =?iso-8859-1?Q?IvQ62jfwyB/c0GUN6abj7QEyN3RWarbm+ReeoW/QDnca5GBwWSCLOKndHO?= =?iso-8859-1?Q?rmTFHcni0T/ugLO08R9lq93CScNrFJNFAEjHxeyqfpFwZBrZ2hhB/IJXVU?= =?iso-8859-1?Q?y5zvQZoeGol7BQ6vP/8Od2FJEXmJsWZhZ2GbI0U/QZq7pMGRuc3iACWtb7?= =?iso-8859-1?Q?PSRgu1k+pL5vjviMlypyN8RslvEd+Zps0RmtaltM4AqKUWC6RRxiI7mqnR?= =?iso-8859-1?Q?5PF73Jt74I5KWuUU96ESKTK5o6MVHAXg3FlZPK3N+63G75/WDemP56Qth+?= =?iso-8859-1?Q?eyowquiGCEZDgbAv9Kjai6bs52336jaM24UY0ue43shG9DMjaKtNggIvas?= =?iso-8859-1?Q?hy22sXL/5wNlupgpJzjtBpIhNGgiG2XaSjgDaY/MwX4KvZ6tpUtEpMGKV/?= =?iso-8859-1?Q?kBowNpDug9DOP1cfL6ZTe2+TXOzZ/ew1ACMkrKN2dl+SOQoA0uMxjZsFuM?= =?iso-8859-1?Q?D/MvhAqMp4LZIaNkb4xZGoHhxU1RKfREsJFqzpcOlXjzKz2QjEhEyEdWpq?= =?iso-8859-1?Q?3Fi+dpJqufkUFqezmCuqR2ZcTWpRKEQxdqv+y6dxnSi598I1MnajtgChpf?= =?iso-8859-1?Q?JcDAVZGGpLzSD2/1TRNGFn9fz1iLFLzFkSIxgcGMwtAlASI5XPtDAr/9Kk?= =?iso-8859-1?Q?Z3SVKOaryC98smvvE4DP5HN/eIGINoUenH37TDZLND9d5oPKOgvLBMtw?= =?iso-8859-1?Q?=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAVPR03MB10142.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f224c584-2c52-4018-d94e-08ddbb3ae39e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2025 20:39:35.7216 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3p0J3WkdLzXjP2Sr4IHnRpArVGvl7iKI5jaKdCtnRp/r6GPs8wahLrPrNI/e8/pi3U4UWpzknIaPInIzBfFRiBEbtbW8Ukk4jQKYLhEPcY4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB9414 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1751661609933116600 Content-Type: text/plain; charset="utf-8" Address a violation of MISRA C:2012 Rule 5.5: "Identifiers shall be distinct from macro names". Reports for service MC3A2.R5.5: xen/include/xen/iommu.h: non-compliant struct 'page_list_head' xen/include/xen/mm.h: non-compliant macro 'page_list_head' xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine' xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine' These external variables ('iommu_pt_cleanup_lock' and 'iommu_pt_cleanup_list') are no longer used in the codebase. Removing them eliminates dead code and ensures compliance with coding standards. Fixes: b5622eb627 (iommu: remove unused iommu_ops method and tasklet, 2020-= 09-22) The variable 'iommu_quarantine' makes sence to use only if 'CONFIG_HAS_PCI=3Dy', so place it inside '#ifdef'. Signed-off-by: Dmytro Prokopchuk --- xen/include/xen/iommu.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index ebfada1d88..57f338e2a0 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -53,7 +53,9 @@ static inline bool dfn_eq(dfn_t x, dfn_t y) extern bool iommu_enable, iommu_enabled; extern bool force_iommu, iommu_verbose; /* Boolean except for the specific purposes of drivers/passthrough/iommu.c= . */ +#ifdef CONFIG_HAS_PCI extern uint8_t iommu_quarantine; +#endif /* CONFIG_HAS_PCI */ #else #define iommu_enabled false #endif @@ -500,9 +502,6 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, st= ruct pci_dev *pdev); */ DECLARE_PER_CPU(bool, iommu_dont_flush_iotlb); =20 -extern struct spinlock iommu_pt_cleanup_lock; -extern struct page_list_head iommu_pt_cleanup_list; - bool arch_iommu_use_permitted(const struct domain *d); =20 #ifdef CONFIG_X86 --=20 2.43.0 From nobody Thu Oct 30 23:21:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1751661602; cv=pass; d=zohomail.com; s=zohoarc; b=cGjyL/m6SBNVl8l8j7OB6LErGP2kiuIhVPvLeqYKcIYQjTiOqS/R7h4pSq90aU40uDR3RjyQ2Q2XvAG/7wnuDbS+9vElkGgihy9xNQhhlFb/ybQknr5orVahRoUhJxMFHgB33gmjSwinrMhaDqfj5GX65RWM8RxbwBBhZeaEcCw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751661602; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Zvriup+5D2WBdsWjxZrf1fWKGFJvH+SHsOGJOGyvEEo=; b=GWeebpOMo3pZ8x+h3IlRIX7oj3LvE8ZRaniRT78NeUHVSgoxVCqj5csdIdR9ZzurRtfMi2WRRQMbgmSL7TluUmNyCcPNnIpCrmLqj7GQqD3zXfLyNw8AC1L1zrUtVOCjRsslkRDhWHtwXvEx+U4OX/scHpjUhEypWZiVLEPXim0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1751661602567327.4968320549691; Fri, 4 Jul 2025 13:40:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1033718.1407043 (Exim 4.92) (envelope-from ) id 1uXnCD-0007FK-Ei; Fri, 04 Jul 2025 20:39:45 +0000 Received: by outflank-mailman (output) from mailman id 1033718.1407043; Fri, 04 Jul 2025 20:39:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnCD-0007FD-Bb; Fri, 04 Jul 2025 20:39:45 +0000 Received: by outflank-mailman (input) for mailman id 1033718; Fri, 04 Jul 2025 20:39:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnCC-0006X7-EQ for xen-devel@lists.xenproject.org; Fri, 04 Jul 2025 20:39:44 +0000 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com [2a01:111:f403:c20a::7]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 028f53c0-5917-11f0-b894-0df219b8e170; Fri, 04 Jul 2025 22:39:42 +0200 (CEST) Received: from PAVPR03MB10142.eurprd03.prod.outlook.com (2603:10a6:102:32a::16) by AS8PR03MB9414.eurprd03.prod.outlook.com (2603:10a6:20b:5a1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.20; Fri, 4 Jul 2025 20:39:38 +0000 Received: from PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673]) by PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673%3]) with mapi id 15.20.8901.018; Fri, 4 Jul 2025 20:39:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 028f53c0-5917-11f0-b894-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EqtahM5i7KK1CkiJv8WLM2efR8zcNb+/7NGN+VhmSJlpgyl2le7jIGefoDuPjJwhok3PvWkBVajOMbQLFyI/f2LQOBWF/SscPLpLS0RJeSp9dluT84ttn1eb4iFgcV7AvxVfW22QtwljqRQfQvmBmoDxCZfk5BttgYpp+KhpQL/fK7tW/yXFfDuR5vEM7vAymqZ4Xy3vsl5ljV5ATDd5vSHqRV/8o16kXAsi//hvD6S2yncGLx3viVbOiuvnpQupXGjd2ga1kOUgG6OsfXgmX/QqfRpWCqtlmRYS6LQsGg4/p44lEPCYYdI+YF5oCwi3qmuuMTgxNdrirRfyXts/fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zvriup+5D2WBdsWjxZrf1fWKGFJvH+SHsOGJOGyvEEo=; b=rB7/PlNxGLKNZvdhM5ir72BXi7WEdSl6Dv1Y09sbRANBNSzSt5E06aH38cKr2Vg9EoUJD8qPj9U6t0X4QzOHpoThqToSAKMHP5KsG57tZtCyRPHi2srn+p2uxP0BvyRSV6ZKXfeeMIpZxdaQFHTwYYap5F/R2Cnoc8Xw48xYlo7uPro/8/q8l8LEihK1duZ8i7cwUST8QVaZvyHhUKM+TNGshx3+TZ9Cy2q9qxrKSFh/C9D4k9/KgLbGcpO74AoWtKVxZGmJxsejRGq+a3RB1ZlVxjMR0j9Y7XWD9G/9p0F7vD7PufKcbJHOUDPrBlcJ0gSzTYymRjtDhu+7w9Kfgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zvriup+5D2WBdsWjxZrf1fWKGFJvH+SHsOGJOGyvEEo=; b=GG102NcVgCzuTd+8EZeTCnVXlM6kcbA6fuBNTJPY445ylc5lmII6m7gAbVBdhrIua5OUQPGx47isLXMe3aVmBk7PHA9mtkq5c1mWvmBu7bmZ/f8a/eJ23CcLbr5CRVBssRmFA9lAE0exp3cwo+Y2xubMUT3WB0dgHYm0OLZL/eecqfryR8tK+Iqbsnfq+ydTuLhGPPXfzoy07eyTk66hbYpNZdIrIyOvfzg/Ohr0H6IqASSAcf3xv43sO4rENGUBlbei8qBbdVGhcsX+1YVCXT7opfk+IVs+RzkmfUcb2OQGyLreHyjUHMTaLmWNaigP/hmQdQAm4JNylBugJdyEhA== From: Dmytro Prokopchuk1 To: "xen-devel@lists.xenproject.org" CC: Dmytro Prokopchuk1 , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini Subject: [XEN PATCH 3/5] x86/irq: address violation of MISRA C Rule 5.5 Thread-Topic: [XEN PATCH 3/5] x86/irq: address violation of MISRA C Rule 5.5 Thread-Index: AQHb7SPCcQgXyJtRukKOfLrFemIDFA== Date: Fri, 4 Jul 2025 20:39:38 +0000 Message-ID: <0e289fdb9187902d59dce3fc7368facf5eafa2ff.1751659393.git.dmytro_prokopchuk1@epam.com> References: In-Reply-To: Accept-Language: en-US, uk-UA, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAVPR03MB10142:EE_|AS8PR03MB9414:EE_ x-ms-office365-filtering-correlation-id: d2607316-0a57-4a73-3920-08ddbb3ae515 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|42112799006|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?WlshR3prhaTMLp3lRQ+JWP9Ng9pVb7TBgJQsOs0p014oL9M0JeikKswQ0Q?= =?iso-8859-1?Q?JRjs8YWIFmlWga9FD+ivwkR0GzKJR1Oo44XISpTZGsRKZ/tXICw00TSzlv?= =?iso-8859-1?Q?7bS0NDAGmBy8Q3TC3rt55VfMw676hKl/w8YQ1rNYQhGlCcMREJT4A3x8zM?= =?iso-8859-1?Q?Zae3Olpl2nVYBC+OaxGGuhjppBWZnq26laUL3/fgy22a/jYJZFFoN9mzEH?= =?iso-8859-1?Q?2nVEpR3dwQbJgm/UOvgbBl6uuoF11DqtmLBxt6A5IHwE0VsjVYI/0FB3jo?= =?iso-8859-1?Q?foQKqkx5wmD8fvB0WaoteXbL2HB1yZbqQX0yL5aSYZ2fDb6MeyL54MQxep?= =?iso-8859-1?Q?UyT5T9g3KN7+3+AdWy2Bhm0/Alh+wJs6zUpuGN59Ggq90+lDx6VULXHPlN?= =?iso-8859-1?Q?DgswWNtKFNxUBqMKhma3O8Lilbsojgd93KU6kg/aRm9ZpYBl8w7vVtIDhc?= =?iso-8859-1?Q?mIewACm2VrFMkVxPKaUcCzIsYCYYwM43Q1tMKySWcx9UT4zE9Z+XFFW5M3?= =?iso-8859-1?Q?utKhNKGMKROvAmutTW60lWmSsQ4mdcbzceVgHEmjiHM2xlKEGmS+79nCJZ?= =?iso-8859-1?Q?JWSHlkYnFCpWyspeXsjLSnSl0AucUrdjU9kD8NuBmuvokD8ekS/euQP7/P?= =?iso-8859-1?Q?qI4qACRUPvM5HYAErT68ki9BPqL6xFoZgd8zPjLSQAk3cbAwBois8vRRpU?= =?iso-8859-1?Q?P4K7YdKJ027ModrWFCileRLbWpLTwicD46TeC0y4SGUJwDloUVUCwwdK4o?= =?iso-8859-1?Q?Espd/AQbAiWxn257Nt3NMx4hIKsEkhVrnnPoE/FxdulNl8XueZezI9G1Vk?= =?iso-8859-1?Q?HjMWZ6aeSj2c1d8K83AFjfPwgLvtrgmIuyH1sTUzTC3X/sGAnKbGiOa1Cz?= =?iso-8859-1?Q?PV93LLQfnONi1jXu3ZHrKSGUtpqM8t92UbqpJSunTim5MMUPWZ6keQ7+EA?= =?iso-8859-1?Q?yhGnwbkw7KLUzPiYRDtIQcdE2K1HYs1dLfglqtJN00eJbzHndJA4qgbsMn?= =?iso-8859-1?Q?eHL/8P0gsLUM/aKh3y8j8f4UPxDja+duyGv8bclUp/BGx3xuqlNBbXWDlg?= =?iso-8859-1?Q?mnxJit367H+bhJum3Xy+UXhLNA3TYPQ6Tkrrba29m7TWTUNvljmlpfDZUU?= =?iso-8859-1?Q?Nm0vwme0tVVOk34w48Ju5uK975haQPpmrwjy01nQ7T5oLcjmfuSmGypuqi?= =?iso-8859-1?Q?Pk1cWLuQFoo6+DkYKMPAr+diynhg4BGciqkw01hKQqKFy/1qhCQRmV1wWp?= =?iso-8859-1?Q?P9I/hYSksScGT23r/Q80H770JDO2Vqwer8QUJ8N+WSuPsqi0VGlfFFkJSX?= =?iso-8859-1?Q?Q2mSxUKNjpOnd5OuzwbrwQsepo6w7ZPJQ7Q8pwhkCGoUYrJeZy6/BDzYIq?= =?iso-8859-1?Q?ZCnwJu41kJxnDRgfU4KmcZKB0+n87LFM2FH8Oj1PRMGJe6PRYGOpIXX/ta?= =?iso-8859-1?Q?RDU1Yam3rDZx4LyU1GZM6A/TuJqDYSG7BvEV3CI6+VHRCO8TxpBzFPA7m/?= =?iso-8859-1?Q?44NkLOaSahcqJ9FsolnMM80Dn8po5vReLECKkpLLJK2g=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAVPR03MB10142.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(42112799006)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?d1mUEpT08ovKsVQt9MM0q3np+mE7oUb1tZh61lStlmY/zI7pGbNUczt2+j?= =?iso-8859-1?Q?mnVAREsct2XvcnxqbL2XRMvLMiruHn1WNwP21IS8AUnBu7R+RtbXrIqoet?= =?iso-8859-1?Q?P5BuM39KMc3yXq/9pW/epYaL1gbIKVQXcthz6rWGbZdyZyluiPZc8pYwzB?= =?iso-8859-1?Q?CK+J2k04Xg6B34OTlVGDzggNvwAipcIkdL+LwwwqasETxIHhmhXqKBjt3B?= =?iso-8859-1?Q?uJBam01UkcBEhMOdlQkaZx1XUUSs9Mpwf2n5xfN8AR6mt0EyFCQSv3dfx5?= =?iso-8859-1?Q?Trq/9NN4mj2snt4lMcLLPaxlspreqe/0P9RDc2CfOOt3OHJLkQ985ykQ1n?= =?iso-8859-1?Q?9eFOhIgBQcQ9I8q3LaxkQVD7sDl/3+5vP38QX7E8t4lUQUuL3/b8E1QgkA?= =?iso-8859-1?Q?0E8m3NkTgk9VYiK/iF2b1KrmzBJY4jxTxUhFtd0KrGO2i64cHGw3ghktTi?= =?iso-8859-1?Q?6UHtr69qFMVB99+4CZ5vjpbN+NDjkGDxmvrY7q0zR5RUlr2DCX8C9plqGL?= =?iso-8859-1?Q?tKBgBY/6dmIu2obEbtv+nkJEl+KdiiHdy7IOKpAn5ZQ4PCW7HQs980AsU6?= =?iso-8859-1?Q?cUi57/3L6GejdLd7BYs1DO1yNHpQ2WJqHsj+MZvAAEmEse8Td7L2lpbJ+m?= =?iso-8859-1?Q?NsXSCTJ8fUfoUYoWw9gjEaL0kdh1jEt0vp4fqfpSuAkUmMC6LL7/xelkO8?= =?iso-8859-1?Q?27ywajj2Q52ucEsMm6UBd3xemp9HVc3lVg/HnpIEdTx12r3p5sLPMH9adU?= =?iso-8859-1?Q?40degZO2eI7MndY67BmcnosZajPDNDWXWUtwIfLVRKtqXDE8QdnFvPKJnf?= =?iso-8859-1?Q?2KTh6nEg9MhFcCNXbyiUcCxSoMMZWk0MEXbV3ffOeFL37s3QaT12xfGUJy?= =?iso-8859-1?Q?uwWTtiZgzpUQroU8HWJvAFAyPX2Lhe6bfve7e+2ggAil3FRUmEiNUYJWAJ?= =?iso-8859-1?Q?5sbuo78752MAqabh5Az/Mra82G2+WPk4dMNbxdshPz/2gdcAIRHCC5i9BQ?= =?iso-8859-1?Q?VJ0akbVkeQ8bEeivmaunY87cK/z/Bbqa+596x32B6zt3s78VZpHgx/s6Qo?= =?iso-8859-1?Q?A0dS4zA1+7fQmwkJa0B0dvJrLwd/e6PWNby7garr0QYYmqluyWJwvRmMMY?= =?iso-8859-1?Q?u8zrRfL063js0HNLz+l2t9K1SwmcFYumpBnIAv+/CUlgyXc3ksm5ZyS++D?= =?iso-8859-1?Q?0ciS7nJK7xEFoH5IqZo4kRWC/K5R6/ZsMO56KCo2pafhYZ4is0Xw+cV29u?= =?iso-8859-1?Q?yw/ZYfVYJp/d0UtPrdj8jcOsrP1kHyv+H8gFhSp8zbUiDUFqRro/uQNmAn?= =?iso-8859-1?Q?a6iBVgZeFHFXCJ+TAteftUEvh9zM+o3v8I311DWbvmJlwjXKTAAk9JteIG?= =?iso-8859-1?Q?/TjCktasGFalh/lkgFnkqohsOYbZhQUT1X28++pt85Z8IeIjKahixfd6WJ?= =?iso-8859-1?Q?vWB8dUrzwQnfZj/QEBA1bXy1EkFqN591rteq8qdRowY4HUB2BHH7czTOeg?= =?iso-8859-1?Q?X4uw2KWGOsGJfptaUraCNYXtbJnp6Eh3B8ejAHMBGFJhOIZ4icvVCz/i4c?= =?iso-8859-1?Q?uX06cYNrOt92dxMvAG4te4r/8vYAi59CVgHKoJxcs3Mp721rD43hYWOM/b?= =?iso-8859-1?Q?ZFst1D40O9PwnB7LdowWDETgrpHoisjinLdOXiTTWub8mEruTlCMeFHA?= =?iso-8859-1?Q?=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAVPR03MB10142.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2607316-0a57-4a73-3920-08ddbb3ae515 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2025 20:39:38.1757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gjMry5OHhA7NmqRB8dsMpPv8gJmLjv5rTdALtr76KIlzXeQ+9N8tiXhzF2ufEB6pSjAnLefkPw9Md06gF5pBc/C3Xb3Cako69XlcIlCPfNc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB9414 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1751661603924116600 Content-Type: text/plain; charset="utf-8" Address a violation of MISRA C:2012 Rule 5.5: "Identifiers shall be distinct from macro names". Reports for service MC3A2.R5.5: xen/include/xen/irq.h: non-compliant function `pirq_cleanup_check(struct pi= rq*, struct domain*)' xen/include/xen/irq.h: non-compliant macro `pirq_cleanup_check' The primary issue stems from the macro and function having identical names, which is confusing and non-compliant with common coding standards. Change the function name by adding two underscores at the end. Signed-off-by: Dmytro Prokopchuk --- xen/arch/x86/irq.c | 2 +- xen/include/xen/irq.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 556134f85a..d61720aa60 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -1383,7 +1383,7 @@ struct pirq *alloc_pirq_struct(struct domain *d) return pirq; } =20 -void (pirq_cleanup_check)(struct pirq *pirq, struct domain *d) +void pirq_cleanup_check__(struct pirq *pirq, struct domain *d) { /* * Check whether all fields have their default values, and delete diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index 95034c0d6b..02f686a999 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -183,10 +183,10 @@ extern struct pirq *pirq_get_info(struct domain *d, i= nt pirq); #define pirq_to_evtchn(d, pirq) pirq_field(d, pirq, evtchn, 0) #define pirq_masked(d, pirq) pirq_field(d, pirq, masked, 0) =20 -void pirq_cleanup_check(struct pirq *pirq, struct domain *d); +void pirq_cleanup_check__(struct pirq *pirq, struct domain *d); =20 #define pirq_cleanup_check(pirq, d) \ - (!(pirq)->evtchn ? pirq_cleanup_check(pirq, d) : (void)0) + (!(pirq)->evtchn ? pirq_cleanup_check__(pirq, d) : (void)0) =20 extern void pirq_guest_eoi(struct pirq *pirq); extern void desc_guest_eoi(struct irq_desc *desc, struct pirq *pirq); --=20 2.43.0 From nobody Thu Oct 30 23:21:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1751661606; cv=pass; d=zohomail.com; s=zohoarc; b=Z01qUCwFEr+nZqY/pR26/2I5ENK+zb4sOekxSjiDnj5u2gFDKopJlYVOpYvObqXpWO9PzTytaMJWPvV7k4A0nOf3ScFCjSNHvRgSkxdtC4sq/mhMEjtqrGBct52qxy3npwsQBAKeHplL6eW9OnN1u0X4wPg+FI21lJuMEQuRIGY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751661606; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YXPq5jXea6CNVBo0+QzCRwtwX65T7vX6q4vY/Alq6eA=; b=AR8zq6moAa4k9w0YvnDnpEfcAKdPCYNzfqBebOpCq7lAEkddg4qtNand/oXMjyGRf0kTB40kFAiOjIt9kKWXV99/bPVkutDOHbHeTMkeMUN+u20NRVH9sxxht0KaZrC3GudEH6i/32+j6bsvu9e6ccycOtmoHmgs4wpG/zsm5Ts= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1751661606295281.62529105152714; Fri, 4 Jul 2025 13:40:06 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1033719.1407053 (Exim 4.92) (envelope-from ) id 1uXnCF-0007Vi-LL; Fri, 04 Jul 2025 20:39:47 +0000 Received: by outflank-mailman (output) from mailman id 1033719.1407053; Fri, 04 Jul 2025 20:39:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnCF-0007VX-Hz; Fri, 04 Jul 2025 20:39:47 +0000 Received: by outflank-mailman (input) for mailman id 1033719; Fri, 04 Jul 2025 20:39:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnCE-0007SZ-Lv for xen-devel@lists.xenproject.org; Fri, 04 Jul 2025 20:39:46 +0000 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com [2a01:111:f403:c20f::7]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0523f47d-5917-11f0-a315-13f23c93f187; Fri, 04 Jul 2025 22:39:45 +0200 (CEST) Received: from PAVPR03MB10142.eurprd03.prod.outlook.com (2603:10a6:102:32a::16) by AS8PR03MB9414.eurprd03.prod.outlook.com (2603:10a6:20b:5a1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.20; Fri, 4 Jul 2025 20:39:40 +0000 Received: from PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673]) by PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673%3]) with mapi id 15.20.8901.018; Fri, 4 Jul 2025 20:39:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0523f47d-5917-11f0-a315-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KAvuwgUn9Z9LIj1AV707YfNIqA5m/eOCrfHYeTwLwJPrsA1pNLGv0TzttYEcOIQjnl5M/hbB5a6YOi4TET28rEelVjrddbbNt7KZyaICFqDkneDurk+oAyCn3asfJ/8IBjvK3lw9QHoRkzNOeh3ATEyoBd+h65aqfv01bIcU6hR/ZQNuK3mrxQndaMJ6hHr4jAJLkQyGVZouT1gNLWPNKOacDcNsVzla6FQ72dcgOnU8g1tTzrmQyTpBC48kwU3jSXmoJcSTZz9rMcx1ktI/JDLJLRHzBgo5b6HL9WetQ87Scvg2Xz9PuG3DN8xMM95USI2X+TT1rkAJrOxvvhBM7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YXPq5jXea6CNVBo0+QzCRwtwX65T7vX6q4vY/Alq6eA=; b=Cl4KyF0SIocNiW9h8/r+pTbrUYLriU6HA3T0CmGu0VBC3fKg9VVrzDhX4wpqFhc7nvCyuKBYQqo1adwv14RuYsCA7eG+ctPyUmD1zzBGf4/bYSAdVoR0aeV2LsnhqbZ8KrJxOJc81rRHdR+nizXmKq+3z0FM1eYShY9BPXPj8gwcutp9yvXcEMQ7mvIp6pXbTIRM6YECikGB5m+qldg64dO4hNdiLcuKPFm8bJqNvByKuRJfKDxP6KVjKtaQnBiB3UgDvBSn0dyo3vD+w4FCXjlD+cDVSblTFoDDzOHRH+LS1IUbnMQ+Yb6GyQmVsGF8HJWFyU8CdxeIW2vUbMWYQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YXPq5jXea6CNVBo0+QzCRwtwX65T7vX6q4vY/Alq6eA=; b=HtakpzTtyGs1oAD63iewgGCv2MdQ5UqiknpCjsfMN3jnhxKwaA+VUSGbeJvP7SwxzI4hG5A+0ggM0rLxk2h4J1Etu+40z4mlOujXDFRE3os3mULDObgukfi3YR7j48jNbKRKeSgGUGRvEMBzfS6Fkal6YNlW3Prq7giyODL0R9v6zq50hGLg+HFtNj/51skymNIKHKIIjbf8A+ZecvnHM53Ie1U+ZqJZsaXqNYu2KMdwRzer38DJJnQfVPMbSCBMBUpMcqgxNdb7s82oFKbWvv2L+lzMMEyS/rg2Nl8Y3ifXZ83y80CEOsF+vuzFSseyTKSaex7LhLM4vmIqi3e7bQ== From: Dmytro Prokopchuk1 To: "xen-devel@lists.xenproject.org" CC: Dmytro Prokopchuk1 , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Andrew Cooper , Anthony PERARD , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: [XEN PATCH 4/5] device-tree: address violation of MISRA C Rule 5.5 Thread-Topic: [XEN PATCH 4/5] device-tree: address violation of MISRA C Rule 5.5 Thread-Index: AQHb7SPE33xTLuD5VESNE7+QBAPvrA== Date: Fri, 4 Jul 2025 20:39:40 +0000 Message-ID: <3dc32625a870200e4bae20959a10be6a786a9763.1751659393.git.dmytro_prokopchuk1@epam.com> References: In-Reply-To: Accept-Language: en-US, uk-UA, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAVPR03MB10142:EE_|AS8PR03MB9414:EE_ x-ms-office365-filtering-correlation-id: 151de091-8f38-4fe4-44e4-08ddbb3ae6af x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|42112799006|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?kWLF8lWFjLBViXAZhcTYMmAKGnCW05I++b5feLqZQd85mOGypUrX/1eeRF?= =?iso-8859-1?Q?BDEq94GM1varoxThN9nWF+qnliKj56uYs63ZxIKlqjmU8INGxHJU5NuB3s?= =?iso-8859-1?Q?5X36PpPm0tkEzaF3/DcjrAgo/JAY8W6e+TQcHN1VigcZprsu8xSgUHH7PD?= =?iso-8859-1?Q?Q4rQQpIdYJqHUuWzGmN5JUY280lpH/IQnbMtUkRT154jhTu0UEMPjpM7Ij?= =?iso-8859-1?Q?HXdOvFouPUPHZnJZgDvUv5/3RdgW5fmCLo+CEfydGl8S2LE9Z+HkPDVwSc?= =?iso-8859-1?Q?a+UxjIOfW/4i9OBcJV8dPVKMIwfVAoYimUKxyuWM0GRe4nfL6F07QEQbpa?= =?iso-8859-1?Q?ioxzLj+DXWAqlT2Yzn/hK6vUIPqCNyEdOn06BxH4msUUbxSaiOr1t48ks7?= =?iso-8859-1?Q?1ioIKWT746yrAYgSrNuXnzcbOHvK4fwq18oXFE713pSnTO7t7QhKtdk1gu?= =?iso-8859-1?Q?gWtVQMXBpcUULB1fqBEfTmGNO3dqJJsib+GVhtHE/MtC2X6q3h4nAI9R8a?= =?iso-8859-1?Q?/elVrRjTbGwTEJ66yeYcqXGBcZe9f3XYXKPRl9JwRaYNnLpjcOA2rPXVr1?= =?iso-8859-1?Q?/h/742qM9UPWOh5Pzlts8GYbfFm6iEGyc+82Phn0DUrvbYjO2PvHSmtHN1?= =?iso-8859-1?Q?5z9LG58yJvIhva3uPPl46QA0AQBth4RUJBviZoD79iuaw/8HKOg2tcO5OA?= =?iso-8859-1?Q?qbpnzsg//D3XZlUcHIXko4IPv1z+3T2NaO8ZjZ10R9dyLrMib6hB/f1fKy?= =?iso-8859-1?Q?VVdgueZ9QBjwrXYq+9nLWilR58IsxFeAfZWvq/VfxTUh8YJ48y+aJE/ivx?= =?iso-8859-1?Q?eVm4YceSCQ8CMWZlMlZVFt3hP7aKzAiRzkj6mYfwan3PZOBWHhFrFZSiXX?= =?iso-8859-1?Q?Kleio2MSFwhUY+Og+3od0vutBHtUGju1VbtUvSD2yo3lPZGZf0TKzOfUdZ?= =?iso-8859-1?Q?oW9nEmDLvT3x/QrtTN+ZoUNit5u5oCTuaGgZvBtsE0FxhmMyyG3qWQdLHr?= =?iso-8859-1?Q?JqHzJsJp/thldheivHoBYmnpTbUhCVvWe0Xnrunlie5ESU89TEzrNy7lbX?= =?iso-8859-1?Q?fikMbLOAXeaQlveXfwc9Tn+KVGWhj1T/o/3jXBDBuxI8sekoWdt33K6S7X?= =?iso-8859-1?Q?b4iRHs5QhT08mITA/zRzwR7wDCdHU4EP3PFlyotiCpDhFpfTUzV8PEEtHs?= =?iso-8859-1?Q?bTI1nlHVuF7CZzfKXAWESN2n5TGYC+yCdsziakzASYVU9wVnMkn1NCbGFa?= =?iso-8859-1?Q?23/dCSCk0+rOcidBAU5oCUzbNMwqIToJE0ie5HPMfu45IPc1iWxQucZiuD?= =?iso-8859-1?Q?eBcQPYfM+ToUcniA1H/8pbaXech6izvkoDFaBtF42V1KL5xZ9vT4xgeQZi?= =?iso-8859-1?Q?jgVmRC7tmEwXPSdu5rpxZSbNCf2mXC4qnVJ11vQliIT6Ugj2OJlFqHK27x?= =?iso-8859-1?Q?ldravTV1CvaoUVogiK1ZObhQyhyDmA21GDPIEOvY6eD0T4eDPldzkh2Kx2?= =?iso-8859-1?Q?LRWtSGUcOXRM+NUiIzyRMAOwIkwNFBQl5rzi9ifLtScA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAVPR03MB10142.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(42112799006)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rPLkBGQBo0qYw9HEWscfYAEkdiHl0V/Vxb02z5CnEtn2XE48yODWpJP3WD?= =?iso-8859-1?Q?lJo2bQPsQVKQDTJV2REGNDdkBplDztEUkuQGjNcPS9MEea4niKgcK02c88?= =?iso-8859-1?Q?6keAUqlwLl8IEzO8erW3loVMpjk/gGtgukIf+gfgeiDoanXK+vgBoJlDx8?= =?iso-8859-1?Q?Mgm3wMf3kj7G/BTLSsRhlyxNCSYJs0alAPU4QK9LfETeUESxrHqsQYVamE?= =?iso-8859-1?Q?Aa2/HONvxG0cR1tbI4iJzirpnC86OpyYAn+0RvVXZ5yZJvaP1AaaYInDPo?= =?iso-8859-1?Q?y+wI5hcD79xAcnIdS8iN84gHPgaX/aXcSx2WnzeLbgrc5gC7O8ef4HeUkD?= =?iso-8859-1?Q?3AFOyN5TNVDtwjyAAJuQ9k8xgyDg4Bu1MNNDiTESPsnjy84YyVU58FBKOc?= =?iso-8859-1?Q?2Tie69VjIp/WkIrOxw2BgmhdDJ0G6+g39YNiX5ZwY0Hb0RLNj0zHt923zn?= =?iso-8859-1?Q?lZifJ1AzNBDG/XQzGrF1AOn9Nra2fQJII05bJ6YClkmg69EsF/wjBAlvnz?= =?iso-8859-1?Q?5YXraWNHRTmIUNTACvYwCgPYMFt+boW0ho4Im6MvkolHH1/7Ed9zN1p75e?= =?iso-8859-1?Q?V+383+YNeK6RONeO3wVvhCabQohvvztUIRPDwkdES+XbZi5L9zVB/0sSbP?= =?iso-8859-1?Q?dzidQ6GWQnCVenZs9QKCDNTVBdGIW0a/3nrcYZzu6S73Fxg28wtyf1XSNe?= =?iso-8859-1?Q?HrTy08KHtCbI7i9fJSdWLStg2l5h+VWT1uJwdNsvdkhAjk+RVnQpxp+ZZv?= =?iso-8859-1?Q?z1W5XKcvxTs3U75GGspWLTOQVYG3mj2DyW22ljvW/0ktZJQAX9mWG9BU1S?= =?iso-8859-1?Q?zD4mc6k//b+93q3NStYy122CRO+fYlJvK2gAyTCfaEfDixF4ij8N/z5yPw?= =?iso-8859-1?Q?QtzZ55kVNwsEN27PeR60lMghdkDwZ1Y3ct9TynSmhm7+AZRjpVXjtuRcfa?= =?iso-8859-1?Q?wRBZsIMhoGbJgqewB4aos02EjGLzZoHxachRAF5HryYIfu2VwyrXrp2BAn?= =?iso-8859-1?Q?worcMlP4Sw7DHkueGFUm4PjW9ipVIzEUmErJdn13quzlElkA93vd95lRL7?= =?iso-8859-1?Q?48X0MYmTdDiZPqenM0f++LPtabz01HMlN44UNUe7LJj28VOKoLrSdcGGrN?= =?iso-8859-1?Q?tCTqd61CZdS8EuIqBbxaMZZ6lYj5WFZ65K+U2SgqKiGHU/umPmL4n2kESU?= =?iso-8859-1?Q?KhlBF9WOkUSYA/pnQpnM9E+L9/CB7c/lDC5QAXJq5h0bYxGvuUEwk/pOel?= =?iso-8859-1?Q?MSDfgHNehPBRfA6djPu3/Y2+yfpinQJedwH+L0WRWagT0QMtxuHgIxlCb8?= =?iso-8859-1?Q?pX8sIFCIMRcwYs7lMCqTYJ4ucgU+yTIvirZpWEmrDjfkifQkwzVXYq9E/D?= =?iso-8859-1?Q?WAoWCLdvpNBZEUW11qfbsxwxx021hhzPoXs05RMjbiM7tXtChKhCBSkE+6?= =?iso-8859-1?Q?AHA2pWq/Q/TUG7mdVxNCD/lODKmb+GloO9WPXwQMjMiSiE6N2FhZj+3rDn?= =?iso-8859-1?Q?CGAmJENZvzPAn81/ILblZ8VFMJjFPqFpIg4ZlpTteIatqs9FGH0H8ElR3Z?= =?iso-8859-1?Q?aw8W/WIPH7rhdtpKnNNi/FziA43OyHD3FolMm2zSNhLj2p35UYqrsgqQAy?= =?iso-8859-1?Q?AaonhqrLYQTTOdElnPDlJygCj5f5cX8fRyKBdguZ9fNNpGynOlzBhwdQ?= =?iso-8859-1?Q?=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAVPR03MB10142.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 151de091-8f38-4fe4-44e4-08ddbb3ae6af X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2025 20:39:40.8838 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8JO6NHDoECzs8SgD8eRkWs7i5uCzzH4/AY5/BLju1Dq9vZJs4ywKrxTFmcS6+2RVwIaR+2TePX66I3zALGfrskB+y8VZOYoQL2l9+5Cgsz8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB9414 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1751661607884116600 Content-Type: text/plain; charset="utf-8" Address a violation of MISRA C:2012 Rule 5.5: "Identifiers shall be distinct from macro names". Reports for service MC3A2.R5.5: xen/include/xen/fdt-domain-build.h: non-compliant parameter 'copy_to_guest' xen/include/xen/guest_access.h: non-compliant macro 'copy_to_guest' Rename 'copy_to_guest' function parameter to 'cb' for compliance. No functional changes. Signed-off-by: Dmytro Prokopchuk Reviewed-by: Stefano Stabellini --- xen/common/device-tree/domain-build.c | 9 ++++----- xen/include/xen/fdt-domain-build.h | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/xen/common/device-tree/domain-build.c b/xen/common/device-tree= /domain-build.c index cd01a8b4bc..2b009547d0 100644 --- a/xen/common/device-tree/domain-build.c +++ b/xen/common/device-tree/domain-build.c @@ -331,7 +331,7 @@ void __init allocate_memory(struct domain *d, struct ke= rnel_info *kinfo) } =20 void __init dtb_load(struct kernel_info *kinfo, - copy_to_guest_phys_cb copy_to_guest) + copy_to_guest_phys_cb cb) { unsigned long left; =20 @@ -339,7 +339,7 @@ void __init dtb_load(struct kernel_info *kinfo, kinfo->d, kinfo->dtb_paddr, kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt)); =20 - left =3D copy_to_guest(kinfo->d, kinfo->dtb_paddr, + left =3D cb(kinfo->d, kinfo->dtb_paddr, kinfo->fdt, fdt_totalsize(kinfo->fdt)); =20 @@ -350,7 +350,7 @@ void __init dtb_load(struct kernel_info *kinfo, } =20 void __init initrd_load(struct kernel_info *kinfo, - copy_to_guest_phys_cb copy_to_guest) + copy_to_guest_phys_cb cb) { const struct boot_module *mod =3D kinfo->initrd; paddr_t load_addr =3D kinfo->initrd_paddr; @@ -393,8 +393,7 @@ void __init initrd_load(struct kernel_info *kinfo, if ( !initrd ) panic("Unable to map the %pd initrd\n", kinfo->d); =20 - res =3D copy_to_guest(kinfo->d, load_addr, - initrd, len); + res =3D cb(kinfo->d, load_addr, initrd, len); if ( res !=3D 0 ) panic("Unable to copy the initrd in the %pd memory\n", kinfo->d); =20 diff --git a/xen/include/xen/fdt-domain-build.h b/xen/include/xen/fdt-domai= n-build.h index 45981dbec0..3a20623cf5 100644 --- a/xen/include/xen/fdt-domain-build.h +++ b/xen/include/xen/fdt-domain-build.h @@ -50,10 +50,10 @@ typedef unsigned long (*copy_to_guest_phys_cb)(struct d= omain *d, unsigned int len); =20 void initrd_load(struct kernel_info *kinfo, - copy_to_guest_phys_cb copy_to_guest); + copy_to_guest_phys_cb cb); =20 void dtb_load(struct kernel_info *kinfo, - copy_to_guest_phys_cb copy_to_guest); + copy_to_guest_phys_cb cb); =20 int find_unallocated_memory(const struct kernel_info *kinfo, const struct membanks *mem_banks[], --=20 2.43.0 From nobody Thu Oct 30 23:21:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1751661607; cv=pass; d=zohomail.com; s=zohoarc; b=MHnFqeu/S7PGPttdAHQvqS9qNq933VOsWK8a9bmFLoQiFtO9ejoPMGn78p476Ob/PCqtxFT1j6tNklFsQX6rOoV5mv97b2cu63T1HthMFt+z030pbOMwITcCxrYuT9Z+1wbvBCBIPVJtz6HKCJEf6tIHK/2uU+gOMakTJishsoA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751661607; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9AYqjgn4wMRBeycg61AUz8EvZb80nLOwwK9+zoOne+Y=; b=DeW7KuS7s0ma6Udy9iHWxpMYQkhz0k/ehtGiUx2YhGHCXH+8hPA8rzcx2pcENt1qj+DTQZKRnZXya07xhnlA1qkq11zYmhIuIYXAL1xPQaHZmDzoaFpwgsC7upZkRHfRBFwMDqhMc2ebnSPc1z+epGQFxvJTHV7xMAo+/NsbG0s= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1751661606992656.9134627734549; Fri, 4 Jul 2025 13:40:06 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1033720.1407062 (Exim 4.92) (envelope-from ) id 1uXnCH-0007mc-2Z; Fri, 04 Jul 2025 20:39:49 +0000 Received: by outflank-mailman (output) from mailman id 1033720.1407062; Fri, 04 Jul 2025 20:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnCG-0007mH-Ub; Fri, 04 Jul 2025 20:39:48 +0000 Received: by outflank-mailman (input) for mailman id 1033720; Fri, 04 Jul 2025 20:39:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uXnCF-0007SZ-SQ for xen-devel@lists.xenproject.org; Fri, 04 Jul 2025 20:39:47 +0000 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com [2a01:111:f403:c20f::7]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 06413156-5917-11f0-a315-13f23c93f187; Fri, 04 Jul 2025 22:39:47 +0200 (CEST) Received: from PAVPR03MB10142.eurprd03.prod.outlook.com (2603:10a6:102:32a::16) by AS8PR03MB9414.eurprd03.prod.outlook.com (2603:10a6:20b:5a1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.20; Fri, 4 Jul 2025 20:39:43 +0000 Received: from PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673]) by PAVPR03MB10142.eurprd03.prod.outlook.com ([fe80::61c8:1ce8:e4ea:c673%3]) with mapi id 15.20.8901.018; Fri, 4 Jul 2025 20:39:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06413156-5917-11f0-a315-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nrhH1FWqtGoE0YXhgcEzctHIlD4BxSNmK6ncvGQuWODuzIeNjUJv0Z01zu57RDZ+XY5ZhuJWd/X6Hy6gZXkF/qewVza0EQuBFNLhljO1cMYKqvt92l8xO7fDSlSjq7IJNOknsr6tFEsXuSvKAI3s1F1myaTnPRM2RvM9VTFfw6Tp8vm2uznisqSyWbQxNWODXJq+hyxtzUGw6yPzKwFfvIaTYG1MNePESZSDGTMxClvC8p2RzFEZiRDShY3r2ARb8YhlaTH5mTNmt5Nh5eX5mCKlY5Gf0/stk7WIWVGnyFS3n7P36UjV4xzEohg1hRDpCaiOF7lomQW819Dbyqc+Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9AYqjgn4wMRBeycg61AUz8EvZb80nLOwwK9+zoOne+Y=; b=CvZKZTMQ0Din2e2XJPmok0ruORP9bGcCZ7ilTJargZDSdBPAbdv27A3JGQq9h24iHOfvJ1vWF9CQ5CWliJ2lQwzzMCsDtuQNfQOiVXfJ9pbbuZCybZrBRrFM1S9j6lS2lPjR3/wv4v+j3XT4mgH///KqITW+qrfUPnRtFUUiuIp50l5aUvVyCjUCFnw/YSMnzDuRzqtipdoDNtIpPn0DPGZOF9exiq7dWSBeEwy1vUgI7rXcFlqP6uBRNJYTO73LCHCyN87f4JCcC4mfBuf6OXxqXmDLBZMG8bz2hDH94soTQwEpyxF1nqfASau7ISNx2EHk8tO+oDyoRjx+/ko1cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9AYqjgn4wMRBeycg61AUz8EvZb80nLOwwK9+zoOne+Y=; b=PVAsc9MtXxMzYAJoESYZs+LRj88cejbtb+H6bnWgcxTND6UGWghP5IcS13wO7Ix+Yn9bkm1L+/fM8L72zqnk78LocofGakLzTPy49Qbvwm6iyuwclqtTq3tkukaLnESDDSSZpxWo4A+Zz+AsDy9U+YSeLOt+E7k3cbh25M/ZvpgM7PbedGB3e3Ugu4Gfmpz1t5vq24SUXWuDkctR+JBv0K1x7YvI0NNfoV7IwAOoefY+/XGVM0lJCeQfuAe+g5b+/DzNrBCYJ6avVMkIC/6dIGNMeCCnHhRyqxro8tcR/mf9IBINa40Y0kcrenXKdlyE3bGghVxhUnp3VCvGxvXh7Q== From: Dmytro Prokopchuk1 To: "xen-devel@lists.xenproject.org" CC: Dmytro Prokopchuk1 , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini Subject: [XEN PATCH 5/5] xen/bitops: address violation of MISRA C Rule 5.5 Thread-Topic: [XEN PATCH 5/5] xen/bitops: address violation of MISRA C Rule 5.5 Thread-Index: AQHb7SPFdtGhMfiyuEObKwCZWDm70g== Date: Fri, 4 Jul 2025 20:39:43 +0000 Message-ID: <2f921089abc6cc396c430f3edf4e7151294a649f.1751659393.git.dmytro_prokopchuk1@epam.com> References: In-Reply-To: Accept-Language: en-US, uk-UA, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAVPR03MB10142:EE_|AS8PR03MB9414:EE_ x-ms-office365-filtering-correlation-id: 714cae98-3352-4ae0-5ca8-08ddbb3ae85c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|42112799006|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?BGS7DixRxM82rmXksliu/h2wHjgaxwWpBPUnus5zr+4vnOFaEuIzrmxL/z?= =?iso-8859-1?Q?M1PV+5tSBtaW7BVklMZqDC0n1JZfA3LRrZBaU3eCdbOtDW+DDlYAEdoyFV?= =?iso-8859-1?Q?ftlm4FfeI/Xwxe9cQpnA08jXvlipwf6oz/pACh8UESk7N4sRThSvxQhnyb?= =?iso-8859-1?Q?Jtwu/kQ1zr3Slv0Deox1uaHcaG1b0EjSHo1KlkEyfJouQGWpkMTxav5L+3?= =?iso-8859-1?Q?KVOs6phBPD3DFEvneTEnpW9nRxjdp9nLfl4C31qf6tXHw+xHJmg6gkYhwE?= =?iso-8859-1?Q?qpSMSGcFcgdfIhbd55ZNeIxT2icsgs3sZhwYkG4QkfB/+8YNU+TzY1c6og?= =?iso-8859-1?Q?W87lnGuhqp5CM9igDqVj64awXcGRYc7+zUm5R5TtwdF+ZzqnG1Av5k9a02?= =?iso-8859-1?Q?e74bOalIGxPJBjO5/+DgS95utGKDyL+G/KbtAhotu0gl0ONHSPPksdPEBG?= =?iso-8859-1?Q?XDff4V9hT2Ch9TVFjsTlRde/uMuF0KsUwxlrb29bONuHSAFo3EF41TsFab?= =?iso-8859-1?Q?8sQKKD8GnvOfwHHYCUFE7+IcPNEndbQIu8ZM9ayf1+zKp6xLrQrdlZcg09?= =?iso-8859-1?Q?m3w6qM1vSHumAXSNpOcQCU8hglLjcQp00V5W9KwymFHgY7wR+XfyWA+oEj?= =?iso-8859-1?Q?AAyBf+BbN6CrXqmcQDU0nUimFUxOluC3Ko6ayFyC8pfdLvUaq5BZr4Wvqe?= =?iso-8859-1?Q?ELTTKryawXhIw3JVO1HyEDrEmQh38mQLGxBTc6xJ0uXX7VfwEZ1W5pxszN?= =?iso-8859-1?Q?icrxWwuIB6KqjuwuQNLurttXdNVKWMVObbP55suF4yfOxAekypeT1Lt0M2?= =?iso-8859-1?Q?HVRv39m3f7IapWsSRLRJSJ+Oq5Rg2YgKQ8WS4z7fElYB0pszZWLCd2jZez?= =?iso-8859-1?Q?uxTKiHxq5TIAjo6kRr7NVybkhRC+4HLtCgJug71YKspWBGxde6tuG/QfT/?= =?iso-8859-1?Q?oN19Vhv3xCQ1+e5N2/guwmGlWAHwIeyZu27PC+elmUI9br6goI8tVYXQWo?= =?iso-8859-1?Q?LJZeUFJoKs/8DfRpCvJqQ1kbN0N9eS9pIsLUkJbP4y23MQ/oBchVpYD2JA?= =?iso-8859-1?Q?yDKaYcNReQS86OMXZ6A2XKBdkslFEc5ZrNDwO2+8dV/H8w1RiByWdssyf2?= =?iso-8859-1?Q?b3+m5rlxx+TWrg0SOpO3qrZuBYS8iuydgomqDpuewTTLyts27wbgXQPG7G?= =?iso-8859-1?Q?P99v2wiNvST2mviiopho5/lpnZ9YmuAkh7J4m9IS5CMxnbo8BPfXR/qAXX?= =?iso-8859-1?Q?xU3iy4UtwVBOUdFMWwHOxoV5vOkkPLk8evpW1IToe1sXrhIrUGAwaCNSw4?= =?iso-8859-1?Q?OkHZKt86fECggjAlObPA6PogYFxk+KNorGBcyMN9D5Gb/MbQqeMkIUT0Q7?= =?iso-8859-1?Q?rMPcFXevzMh7CZCI2pV6nommEW7g2H2HS7+kJC8PGDVF/SDb0Fa/F+oZvg?= =?iso-8859-1?Q?SyrJPcw1vLIYEUWuBbknaBKBX94PpXfaHaGoFU0QA189sMxf1lLcJT9pvz?= =?iso-8859-1?Q?2vcl0caTpx7wzrhzY6YZkhooPT31VCkx3joGRHsYhodA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAVPR03MB10142.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(42112799006)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?O1OjofehpvWSL+l1oj3rZehYi6m4Cq5PHi0LaGRDzJVO5O3RsBEZIjuOOL?= =?iso-8859-1?Q?V7SjfvbpPwXM2eJ906r+BaYUQ3tC+ljw7HGPUAQfuhq0NZ2m3vTRjc7ej2?= =?iso-8859-1?Q?G+2nXSPLGPmxFRV7tEV62926Oookvs09SY3tfvk0S0Kb9q0+9utnFahH+m?= =?iso-8859-1?Q?5brxNWOA1XjYPZ1FlA086DhFt3EWTqo0i0buQ5N/CsJQeA8KlMn/Xb6iju?= =?iso-8859-1?Q?tDNt/ALGZ1b9cLuNW+lxdOb4P+7zCoF3hiS5OO5szMlUTTIh6UHZ4b8liC?= =?iso-8859-1?Q?iunXE9ia2HRjYI+aZoj32ewa/hiOOQ3CtB0dAxzOui3CHp4d1DlPgC+bTa?= =?iso-8859-1?Q?pjt0k6MYTpOiHug99jim2DoTBrqi6VKvRP14L8OxMcGis9slRlKgMj1NDH?= =?iso-8859-1?Q?NYip4xrlt8g9kkQy+2U2Rtkd9Ub7h8VzgltJjpIMSZVbya5eA0aMgUoy4f?= =?iso-8859-1?Q?X4g8Ly2SPQXqHXUikvJNpkI6XVde0jf/Dqw3mDcqsyDum7HklQPKvFVNHU?= =?iso-8859-1?Q?3Gp71vxbgCxdBmvPmSWLeJ+AlVqxF4oyrRIyTOf3ZZH3MH0gLmybg/u4+e?= =?iso-8859-1?Q?d+hUyUIxVGS6MgXuTP1XVwxd74Y4KW1Ba/lRJ3CcH0wcXrx8gK5j4nU9fS?= =?iso-8859-1?Q?ph/IM3xYnR9QpMT/C0wHvpi9LjryGZMyIcc6jpAYCRYKoA5nVWJ5hZCbnh?= =?iso-8859-1?Q?oDqbVgyVliqJYgVkLGnIdsmp20M0KSow9F0ulT8qRKbrnbOPTfSLc3tCti?= =?iso-8859-1?Q?C78qVOOJMEk9U1RRXqI1i3UuBSpb4RtsGPryC+p+kjLeE4OuMudaBS3xG/?= =?iso-8859-1?Q?U3mq7DkKrBarooNOcAp1est0HF+om8qcF/WgMfyeB8Ev7GqHTlY+heEmLc?= =?iso-8859-1?Q?vvYdaYnUofbC3J1/sgDjB2gQ1C/sBFFopHwr80TY+C/0mNUk4BQ06+s09B?= =?iso-8859-1?Q?kRybe1Q3PqK/4HXI/EfruCUqeT7Ff41fdKOAPLTkF2Ebg5bU2d2srQSy8z?= =?iso-8859-1?Q?cU8gekMpGvTDZXIge3UnqmX4EqDmP9L4ib6V9PJyU5IeWTzasEx2tJByGX?= =?iso-8859-1?Q?ZOEuavJ+JvI3w2ttTyHvHqZlsNZ7ahcGEZXcozPu+1njn5L1WPVN1L5Nsp?= =?iso-8859-1?Q?yZyuwKvAX4IFLR2S5K31eQ4Wugj4dCq6KFGLuejY7IAsSc4pT2zvo3UEwf?= =?iso-8859-1?Q?B0bOZNxjxWdfyxZSj6R0BtOfq3DMtLsY0OiTFrLS3LvfZpOEhcLgTt33SS?= =?iso-8859-1?Q?8gIBpXyTrEJoYIZ+gAYFLYTOZulXe60NnM1444/xLMmP1lMj0tqaHFRhEq?= =?iso-8859-1?Q?RibGIjkGKWBAqhFQ5IQSyI6A5dWBYe4Koj+ouZ50cS+T0Ch917iXRZryV2?= =?iso-8859-1?Q?jonrXrb5oxl+DAog6gfWEYMno4bv1V+Q3UqzYKog1TlOKBasB1HTzo3EqH?= =?iso-8859-1?Q?jlfr6qpkndGvFc+Gy0vqiqHA2Io86qH7kMGB51AcibrNYLemdQLCeSRQkv?= =?iso-8859-1?Q?DuznsdFsvyQHpvev8nwOBzA3nqDoazx8Icpy3KXh0zAW/viSlZQi2i9WpN?= =?iso-8859-1?Q?dYeqo/P+uVW0k/6uUOetSybj7FLrICDETaK4Ej5IheKvbyYg950IsGDhN8?= =?iso-8859-1?Q?c060Mo9QdSMLEl+gunvROWN6ZF8fZ+hmY5jU35hfINrApAWqs6AJJmKw?= =?iso-8859-1?Q?=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAVPR03MB10142.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 714cae98-3352-4ae0-5ca8-08ddbb3ae85c X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2025 20:39:43.6855 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bCzQLmgivnjqNBkvzM5FfRB7pefz2y64X5WpZRG3dqlnk6t+VMeNI0Ewsp0i6aj76lBv2T2CX6Y76pyTKoerTw5UzWKxBLi2PzVxwL3bzB0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB9414 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1751661607966116600 Content-Type: text/plain; charset="utf-8" Address a violation of MISRA C:2012 Rule 5.5: "Identifiers shall be distinct from macro names". Reports for service MC3A2.R5.5: xen/include/xen/bitops.h: non-compliant function '__test_and_set_bit(int, v= olatile void*)' xen/include/xen/bitops.h: non-compliant macro '__test_and_set_bit' xen/include/xen/bitops.h: non-compliant function '__test_and_clear_bit(int,= volatile void*)' xen/include/xen/bitops.h: non-compliant macro '__test_and_clear_bit' xen/include/xen/bitops.h: non-compliant function '__test_and_change_bit(int= , volatile void*)' xen/include/xen/bitops.h: non-compliant macro '__test_and_change_bit' xen/include/xen/bitops.h: non-compliant function 'test_bit(int, const volat= ile void*)' xen/include/xen/bitops.h: non-compliant macro 'test_bit' The primary issue stems from the macro and function having identical names, which is confusing and non-compliant with common coding standards. Change the functions names by adding two underscores at the end. No functional changes. Signed-off-by: Dmytro Prokopchuk --- xen/include/xen/bitops.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h index a4d31ec02a..b292470ad7 100644 --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -120,7 +120,7 @@ static always_inline bool generic_test_bit(int nr, cons= t volatile void *addr) } =20 /** - * __test_and_set_bit - Set a bit and return its old value + * __test_and_set_bit__ - Set a bit and return its old value * @nr: Bit to set * @addr: Address to count from * @@ -129,7 +129,7 @@ static always_inline bool generic_test_bit(int nr, cons= t volatile void *addr) * but actually fail. You must protect multiple accesses with a lock. */ static always_inline bool -__test_and_set_bit(int nr, volatile void *addr) +__test_and_set_bit__(int nr, volatile void *addr) { #ifndef arch__test_and_set_bit #define arch__test_and_set_bit generic__test_and_set_bit @@ -139,11 +139,11 @@ __test_and_set_bit(int nr, volatile void *addr) } #define __test_and_set_bit(nr, addr) ({ \ if ( bitop_bad_size(addr) ) __bitop_bad_size(); \ - __test_and_set_bit(nr, addr); \ + __test_and_set_bit__(nr, addr); \ }) =20 /** - * __test_and_clear_bit - Clear a bit and return its old value + * __test_and_clear_bit__ - Clear a bit and return its old value * @nr: Bit to clear * @addr: Address to count from * @@ -152,7 +152,7 @@ __test_and_set_bit(int nr, volatile void *addr) * but actually fail. You must protect multiple accesses with a lock. */ static always_inline bool -__test_and_clear_bit(int nr, volatile void *addr) +__test_and_clear_bit__(int nr, volatile void *addr) { #ifndef arch__test_and_clear_bit #define arch__test_and_clear_bit generic__test_and_clear_bit @@ -162,11 +162,11 @@ __test_and_clear_bit(int nr, volatile void *addr) } #define __test_and_clear_bit(nr, addr) ({ \ if ( bitop_bad_size(addr) ) __bitop_bad_size(); \ - __test_and_clear_bit(nr, addr); \ + __test_and_clear_bit__(nr, addr); \ }) =20 /** - * __test_and_change_bit - Change a bit and return its old value + * __test_and_change_bit__ - Change a bit and return its old value * @nr: Bit to change * @addr: Address to count from * @@ -175,7 +175,7 @@ __test_and_clear_bit(int nr, volatile void *addr) * but actually fail. You must protect multiple accesses with a lock. */ static always_inline bool -__test_and_change_bit(int nr, volatile void *addr) +__test_and_change_bit__(int nr, volatile void *addr) { #ifndef arch__test_and_change_bit #define arch__test_and_change_bit generic__test_and_change_bit @@ -185,11 +185,11 @@ __test_and_change_bit(int nr, volatile void *addr) } #define __test_and_change_bit(nr, addr) ({ \ if ( bitop_bad_size(addr) ) __bitop_bad_size(); \ - __test_and_change_bit(nr, addr); \ + __test_and_change_bit__(nr, addr); \ }) =20 /** - * test_bit - Determine whether a bit is set + * test_bit__ - Determine whether a bit is set * @nr: bit number to test * @addr: Address to start counting from * @@ -197,7 +197,7 @@ __test_and_change_bit(int nr, volatile void *addr) * If two examples of this operation race, one can appear to succeed * but actually fail. You must protect multiple accesses with a lock. */ -static always_inline bool test_bit(int nr, const volatile void *addr) +static always_inline bool test_bit__(int nr, const volatile void *addr) { #ifndef arch_test_bit #define arch_test_bit generic_test_bit @@ -207,7 +207,7 @@ static always_inline bool test_bit(int nr, const volati= le void *addr) } #define test_bit(nr, addr) ({ \ if ( bitop_bad_size(addr) ) __bitop_bad_size(); \ - test_bit(nr, addr); \ + test_bit__(nr, addr); \ }) =20 /* --------------------- Please tidy above here --------------------- */ --=20 2.43.0