From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892173258894.5641221765957; Thu, 20 Jun 2024 07:02:53 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744609.1151684 (Exim 4.92) (envelope-from ) id 1sKIN2-00083w-SA; Thu, 20 Jun 2024 14:02:36 +0000 Received: by outflank-mailman (output) from mailman id 744609.1151684; Thu, 20 Jun 2024 14:02:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN2-00083n-OA; Thu, 20 Jun 2024 14:02:36 +0000 Received: by outflank-mailman (input) for mailman id 744609; Thu, 20 Jun 2024 14:02:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN1-0007p2-2p for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:35 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bda636d8-2f0d-11ef-90a3-e314d9c70b13; Thu, 20 Jun 2024 16:02:33 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 7F0E14EE0755; Thu, 20 Jun 2024 16:02:32 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bda636d8-2f0d-11ef-90a3-e314d9c70b13 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Simone Ballarin , Doug Goldstein , Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall Subject: [XEN PATCH 01/13] automation/eclair: consider also hypened fall-through Date: Thu, 20 Jun 2024 16:02:12 +0200 Message-Id: <10af9145252a2f5c31ea0f13cbb67cbe76a8ba3a.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892174258100003 Content-Type: text/plain; charset="utf-8" Update ECLAIR configuration to deviate MISRA C Rule 16.3 using different version of hypened fall-through and search for the comment for 2 lines after the last statement. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 2 +- docs/misra/deviations.rst | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/= eclair_analysis/ECLAIR/deviations.ecl index b8f9155267..b99a6b8a92 100644 --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -400,7 +400,7 @@ safe." -doc_end =20 -doc_begin=3D"Switch clauses ending with an explicit comment indicating th= e fallthrough intention are safe." --config=3DMC3R1.R16.3,reports+=3D{safe, "any_area(end_loc(any_exp(text(^(?= s).*/\\* [fF]all ?through.? \\*/.*$,0..1))))"} +-config=3DMC3R1.R16.3,reports+=3D{safe, "any_area(end_loc(any_exp(text(^(?= s).*/\\* [fF]all[ -]?through.? \\*/.*$,0..2))))"} -doc_end =20 -doc_begin=3D"Switch statements having a controlling expression of enum ty= pe deliberately do not have a default case: gcc -Wall enables -Wswitch whic= h warns (and breaks the build as we use -Werror) if one of the enum labels = is missing from the switch." diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst index 41cdfbe5f5..411e1fed3d 100644 --- a/docs/misra/deviations.rst +++ b/docs/misra/deviations.rst @@ -353,6 +353,10 @@ Deviations related to MISRA C:2012 Rules: However, the use of such comments in new code is deprecated: the pseudo-keyword "fallthrough" shall be used. - Tagged as `safe` for ECLAIR. The accepted comments are: + - /\* fall-through \*/ + - /\* Fall-through. \*/ + - /\* Fall-through \*/ + - /\* fall-through. \*/ - /\* fall through \*/ - /\* fall through. \*/ - /\* fallthrough \*/ --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892177102939.7006497490896; Thu, 20 Jun 2024 07:02:57 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744610.1151689 (Exim 4.92) (envelope-from ) id 1sKIN3-00086s-4e; Thu, 20 Jun 2024 14:02:37 +0000 Received: by outflank-mailman (output) from mailman id 744610.1151689; Thu, 20 Jun 2024 14:02:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN2-00086K-VT; Thu, 20 Jun 2024 14:02:36 +0000 Received: by outflank-mailman (input) for mailman id 744610; Thu, 20 Jun 2024 14:02:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN1-0007p2-9v for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:35 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be091fc4-2f0d-11ef-90a3-e314d9c70b13; Thu, 20 Jun 2024 16:02:34 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 881EC4EE0756; Thu, 20 Jun 2024 16:02:33 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be091fc4-2f0d-11ef-90a3-e314d9c70b13 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 02/13] x86/cpuid: use fallthrough pseudo keyword Date: Thu, 20 Jun 2024 16:02:13 +0200 Message-Id: <23fa8f1061b894d4dd121bc9c2fcaf2c3ad312f3.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892178201100008 Content-Type: text/plain; charset="utf-8" The current comment making explicit the fallthrough intention does not follow the agreed syntax: replace it with the pseduo keyword. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/cpuid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index a822e80c7e..2a777436ee 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -97,9 +97,8 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, if ( is_viridian_domain(d) ) return cpuid_viridian_leaves(v, leaf, subleaf, res); =20 + fallthrough; /* - * Fallthrough. - * * Intel reserve up until 0x4fffffff for hypervisor use. AMD rese= rve * only until 0x400000ff, but we already use double that. */ --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892179239916.636685056996; Thu, 20 Jun 2024 07:02:59 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744611.1151704 (Exim 4.92) (envelope-from ) id 1sKIN4-00005m-8X; Thu, 20 Jun 2024 14:02:38 +0000 Received: by outflank-mailman (output) from mailman id 744611.1151704; Thu, 20 Jun 2024 14:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN4-00005e-5Z; Thu, 20 Jun 2024 14:02:38 +0000 Received: by outflank-mailman (input) for mailman id 744611; Thu, 20 Jun 2024 14:02:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN2-0007p2-3t for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:36 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be6ff81b-2f0d-11ef-90a3-e314d9c70b13; Thu, 20 Jun 2024 16:02:35 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 2DA334EE0754; Thu, 20 Jun 2024 16:02:34 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be6ff81b-2f0d-11ef-90a3-e314d9c70b13 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 03/13] x86/domctl: add missing break statement Date: Thu, 20 Jun 2024 16:02:14 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892180248100013 Content-Type: text/plain; charset="utf-8" Add missing break statement to address a violation of MISRA C Rule 16.3. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/domctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 9190e11faa..68b5b46d1a 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -517,6 +517,7 @@ long arch_do_domctl( =20 default: ret =3D -ENOSYS; + break; } break; } --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892175852643.722004055012; Thu, 20 Jun 2024 07:02:55 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744612.1151709 (Exim 4.92) (envelope-from ) id 1sKIN4-000080-Kq; Thu, 20 Jun 2024 14:02:38 +0000 Received: by outflank-mailman (output) from mailman id 744612.1151709; Thu, 20 Jun 2024 14:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN4-00007c-Do; Thu, 20 Jun 2024 14:02:38 +0000 Received: by outflank-mailman (input) for mailman id 744612; Thu, 20 Jun 2024 14:02:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN3-0007p3-82 for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:37 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id beec8c11-2f0d-11ef-b4bb-af5377834399; Thu, 20 Jun 2024 16:02:35 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id D86744EE0756; Thu, 20 Jun 2024 16:02:34 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: beec8c11-2f0d-11ef-b4bb-af5377834399 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 04/13] x86/vpmu: address violations of MISRA C Rule 16.3 Date: Thu, 20 Jun 2024 16:02:15 +0200 Message-Id: <2b08ef10fb4907255688d5fb38b5928e972407e9.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892176175100005 Content-Type: text/plain; charset="utf-8" Add missing break statements to address violations of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/cpu/vpmu.c | 3 +++ xen/arch/x86/cpu/vpmu_intel.c | 1 + 2 files changed, 4 insertions(+) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index a7bc0cd1fc..b2ba999412 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -663,6 +663,8 @@ long do_xenpmu_op( =20 if ( pmu_params.version.maj !=3D XENPMU_VER_MAJ ) return -EINVAL; + + break; } =20 switch ( op ) @@ -776,6 +778,7 @@ long do_xenpmu_op( =20 default: ret =3D -EINVAL; + break; } =20 return ret; diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index cd414165df..46f3ff86e7 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -713,6 +713,7 @@ static int cf_check core2_vpmu_do_rdmsr(unsigned int ms= r, uint64_t *msr_content) break; default: rdmsrl(msr, *msr_content); + break; } } else if ( msr =3D=3D MSR_IA32_MISC_ENABLE ) --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892178696455.4824787022536; Thu, 20 Jun 2024 07:02:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744613.1151724 (Exim 4.92) (envelope-from ) id 1sKIN5-0000aQ-QF; Thu, 20 Jun 2024 14:02:39 +0000 Received: by outflank-mailman (output) from mailman id 744613.1151724; Thu, 20 Jun 2024 14:02:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN5-0000Zu-LK; Thu, 20 Jun 2024 14:02:39 +0000 Received: by outflank-mailman (input) for mailman id 744613; Thu, 20 Jun 2024 14:02:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN4-0007p3-9N for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:38 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf5b4856-2f0d-11ef-b4bb-af5377834399; Thu, 20 Jun 2024 16:02:36 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 9DE464EE0754; Thu, 20 Jun 2024 16:02:35 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf5b4856-2f0d-11ef-b4bb-af5377834399 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 05/13] x86/traps: use fallthrough pseudo keyword Date: Thu, 20 Jun 2024 16:02:16 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892180282100015 Content-Type: text/plain; charset="utf-8" Add break or pseudo keyword fallthrough to address violations of MISRA C Rule 16.3. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/traps.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 9906e874d5..cbcec3fafb 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1186,6 +1186,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, ui= nt32_t leaf, =20 default: ASSERT_UNREACHABLE(); + break; } } =20 @@ -1748,6 +1749,7 @@ static void io_check_error(const struct cpu_user_regs= *regs) { case 'd': /* 'dom0' */ nmi_hwdom_report(_XEN_NMIREASON_io_error); + fallthrough; case 'i': /* 'ignore' */ break; default: /* 'fatal' */ @@ -1768,6 +1770,7 @@ static void unknown_nmi_error(const struct cpu_user_r= egs *regs, { case 'd': /* 'dom0' */ nmi_hwdom_report(_XEN_NMIREASON_unknown); + fallthrough; case 'i': /* 'ignore' */ break; default: /* 'fatal' */ --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892176636470.6307951579561; Thu, 20 Jun 2024 07:02:56 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744615.1151739 (Exim 4.92) (envelope-from ) id 1sKIN7-0000wI-HZ; Thu, 20 Jun 2024 14:02:41 +0000 Received: by outflank-mailman (output) from mailman id 744615.1151739; Thu, 20 Jun 2024 14:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN7-0000vj-7u; Thu, 20 Jun 2024 14:02:41 +0000 Received: by outflank-mailman (input) for mailman id 744615; Thu, 20 Jun 2024 14:02:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN5-0007p3-89 for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:39 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bfc834f3-2f0d-11ef-b4bb-af5377834399; Thu, 20 Jun 2024 16:02:37 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 597F64EE0757; Thu, 20 Jun 2024 16:02:36 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfc834f3-2f0d-11ef-b4bb-af5377834399 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 06/13] x86/mce: add missing break statements Date: Thu, 20 Jun 2024 16:02:17 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892178194100007 Content-Type: text/plain; charset="utf-8" Add missing break statements to address violations of MISRA C Rule 16.3. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/cpu/mcheck/mce_amd.c | 1 + xen/arch/x86/cpu/mcheck/mce_intel.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mc= e_amd.c index 3318b8204f..4f06a3153b 100644 --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -201,6 +201,7 @@ static void mcequirk_amd_apply(enum mcequirk_amd_flags = flags) =20 default: ASSERT(flags =3D=3D MCEQUIRK_NONE); + break; } } =20 diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/= mce_intel.c index dd812f4b8a..9574dedbfd 100644 --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -896,6 +896,8 @@ static void intel_init_ppin(const struct cpuinfo_x86 *c) ppin_msr =3D 0; else if ( c =3D=3D &boot_cpu_data ) ppin_msr =3D MSR_PPIN; + + break; } } =20 --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17188921802947.061396937400104; Thu, 20 Jun 2024 07:03:00 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744617.1151744 (Exim 4.92) (envelope-from ) id 1sKIN7-0000zs-Re; Thu, 20 Jun 2024 14:02:41 +0000 Received: by outflank-mailman (output) from mailman id 744617.1151744; Thu, 20 Jun 2024 14:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN7-0000z2-HM; Thu, 20 Jun 2024 14:02:41 +0000 Received: by outflank-mailman (input) for mailman id 744617; Thu, 20 Jun 2024 14:02:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN6-0007p3-8U for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:40 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0367b87-2f0d-11ef-b4bb-af5377834399; Thu, 20 Jun 2024 16:02:37 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 1C7C14EE0758; Thu, 20 Jun 2024 16:02:37 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0367b87-2f0d-11ef-b4bb-af5377834399 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 07/13] x86/hvm: address violations of MISRA C Rule 16.3 Date: Thu, 20 Jun 2024 16:02:18 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892182271100020 Content-Type: text/plain; charset="utf-8" MISRA C Rule 16.3 states that "An unconditional `break' statement shall terminate every switch-clause". Add pseudo keyword fallthrough and missing break statement to address violations of the rule. As a defensive measure, return -EOPNOTSUPP in case an unreachable return statement is reached. Signed-off-by: Federico Serafini --- xen/arch/x86/hvm/emulate.c | 3 +++ xen/arch/x86/hvm/hvm.c | 6 ++++++ xen/arch/x86/hvm/hypercall.c | 1 + xen/arch/x86/hvm/irq.c | 1 + 4 files changed, 11 insertions(+) diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 02e378365b..6d0fba9285 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -2674,6 +2674,7 @@ static int _hvm_emulate_one(struct hvm_emulate_ctxt *= hvmemul_ctxt, =20 default: ASSERT_UNREACHABLE(); + break; } =20 if ( hvmemul_ctxt->ctxt.retire.singlestep ) @@ -2764,6 +2765,7 @@ int hvm_emulate_one_mmio(unsigned long mfn, unsigned = long gla) /* fallthrough */ default: hvm_emulate_writeback(&ctxt); + break; } =20 return rc; @@ -2803,6 +2805,7 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, un= signed int trapnr, default: ctx.set_context =3D (kind =3D=3D EMUL_KIND_SET_CONTEXT_DATA); rc =3D hvm_emulate_one(&ctx, VIO_no_completion); + break; } =20 switch ( rc ) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 7f4b627b1f..c263e562ff 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4919,6 +4919,8 @@ static int do_altp2m_op( =20 default: ASSERT_UNREACHABLE(); + rc =3D -EOPNOTSUPP; + break; } =20 out: @@ -5020,6 +5022,8 @@ static int compat_altp2m_op( =20 default: ASSERT_UNREACHABLE(); + rc =3D -EOPNOTSUPP; + break; } =20 return rc; @@ -5283,6 +5287,8 @@ void hvm_get_segment_register(struct vcpu *v, enum x8= 6_segment seg, * %cs and %tr are unconditionally present. SVM ignores these pre= sent * bits and will happily run without them set. */ + fallthrough; + case x86_seg_cs: reg->p =3D 1; break; diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c index 7fb3136f0c..2271afe02a 100644 --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -111,6 +111,7 @@ int hvm_hypercall(struct cpu_user_regs *regs) case 8: eax =3D regs->rax; /* Fallthrough to permission check. */ + fallthrough; case 4: case 2: if ( currd->arch.monitor.guest_request_userspace_enabled && diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index 210cebb0e6..1eab44defc 100644 --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -282,6 +282,7 @@ static void hvm_set_callback_irq_level(struct vcpu *v) __hvm_pci_intx_assert(d, pdev, pintx); else __hvm_pci_intx_deassert(d, pdev, pintx); + break; default: break; } --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892177617541.8995212039883; Thu, 20 Jun 2024 07:02:57 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744614.1151734 (Exim 4.92) (envelope-from ) id 1sKIN7-0000sy-2o; Thu, 20 Jun 2024 14:02:41 +0000 Received: by outflank-mailman (output) from mailman id 744614.1151734; Thu, 20 Jun 2024 14:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN6-0000sr-WF; Thu, 20 Jun 2024 14:02:41 +0000 Received: by outflank-mailman (input) for mailman id 744614; Thu, 20 Jun 2024 14:02:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN5-0007p2-4n for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:39 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c0ac3d35-2f0d-11ef-90a3-e314d9c70b13; Thu, 20 Jun 2024 16:02:38 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id CC3CC4EE0756; Thu, 20 Jun 2024 16:02:37 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0ac3d35-2f0d-11ef-90a3-e314d9c70b13 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 08/13] x86/vpt: address a violation of MISRA C Rule 16.3 Date: Thu, 20 Jun 2024 16:02:19 +0200 Message-Id: <5b9dbf5595a0aa8d7454dcd7be9fae3a12bf2630.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892178203100009 Content-Type: text/plain; charset="utf-8" Add pseudo keyword fallthrough to meet the requirements to deviate a violation of MISRA C Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/hvm/vpt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index e1d6845a28..c76a9a272b 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -121,6 +121,8 @@ static int pt_irq_masked(struct periodic_time *pt) } =20 /* Fallthrough to check if the interrupt is masked on the IO APIC. */ + fallthrough; + case PTSRC_ioapic: { int mask =3D vioapic_get_mask(v->domain, gsi); --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892182922981.3150753381533; Thu, 20 Jun 2024 07:03:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744618.1151756 (Exim 4.92) (envelope-from ) id 1sKIN9-0001QE-75; Thu, 20 Jun 2024 14:02:43 +0000 Received: by outflank-mailman (output) from mailman id 744618.1151756; Thu, 20 Jun 2024 14:02:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN8-0001PU-UZ; Thu, 20 Jun 2024 14:02:42 +0000 Received: by outflank-mailman (input) for mailman id 744618; Thu, 20 Jun 2024 14:02:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN7-0007p3-8W for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:41 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1323561-2f0d-11ef-b4bb-af5377834399; Thu, 20 Jun 2024 16:02:39 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 9B80D4EE0755; Thu, 20 Jun 2024 16:02:38 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1323561-2f0d-11ef-b4bb-af5377834399 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 09/13] x86/mm: add defensive return Date: Thu, 20 Jun 2024 16:02:20 +0200 Message-Id: <282da9981826370ca839503477fb515af14ff4b5.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892184207100023 Content-Type: text/plain; charset="utf-8" Add defensive return statement at the end of an unreachable default case. Other than improve safety, this meets the requirements to deviate a violation of MISRA C Rule 16.3. Signed-off-by: Federico Serafini --- xen/arch/x86/mm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 648d6dd475..2e19ced15e 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -916,6 +916,7 @@ get_page_from_l1e( return 0; default: ASSERT_UNREACHABLE(); + return 0; } } else if ( l1f & _PAGE_RW ) --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 171889218116960.42651724603229; Thu, 20 Jun 2024 07:03:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744623.1151784 (Exim 4.92) (envelope-from ) id 1sKINC-00029i-BH; Thu, 20 Jun 2024 14:02:46 +0000 Received: by outflank-mailman (output) from mailman id 744623.1151784; Thu, 20 Jun 2024 14:02:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKINB-000285-Vy; Thu, 20 Jun 2024 14:02:45 +0000 Received: by outflank-mailman (input) for mailman id 744623; Thu, 20 Jun 2024 14:02:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN9-0007p3-8w for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1b879de-2f0d-11ef-b4bb-af5377834399; Thu, 20 Jun 2024 16:02:40 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 772614EE0756; Thu, 20 Jun 2024 16:02:39 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1b879de-2f0d-11ef-b4bb-af5377834399 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 10/13] x86/mpparse: add break statement Date: Thu, 20 Jun 2024 16:02:21 +0200 Message-Id: <317de680730ffebaae490be5841a7d413c420a54.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892182203100019 Content-Type: text/plain; charset="utf-8" Add a missing break statement to address a violation of MISRA C Rule 16.3. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/mpparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/mpparse.c b/xen/arch/x86/mpparse.c index d8ccab2449..306d8ed97a 100644 --- a/xen/arch/x86/mpparse.c +++ b/xen/arch/x86/mpparse.c @@ -544,6 +544,7 @@ static inline void __init construct_default_ISA_mptable= (int mpc_default_type) case 4: case 7: memcpy(bus.mpc_bustype, "MCA ", 6); + break; } MP_bus_info(&bus); if (mpc_default_type > 4) { --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892178952690.5693412880875; Thu, 20 Jun 2024 07:02:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744619.1151764 (Exim 4.92) (envelope-from ) id 1sKIN9-0001Up-Pm; Thu, 20 Jun 2024 14:02:43 +0000 Received: by outflank-mailman (output) from mailman id 744619.1151764; Thu, 20 Jun 2024 14:02:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN9-0001Tf-B0; Thu, 20 Jun 2024 14:02:43 +0000 Received: by outflank-mailman (input) for mailman id 744619; Thu, 20 Jun 2024 14:02:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN7-0007p2-Lk for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:41 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c22d24bd-2f0d-11ef-90a3-e314d9c70b13; Thu, 20 Jun 2024 16:02:41 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 57AD74EE0757; Thu, 20 Jun 2024 16:02:40 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c22d24bd-2f0d-11ef-90a3-e314d9c70b13 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 11/13] x86/pmtimer: address a violation of MISRA C Rule 16.3 Date: Thu, 20 Jun 2024 16:02:22 +0200 Message-Id: <3cdd3de1e1d91fb9fbef173f3f1a3470e7dadbca.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892180250100014 Content-Type: text/plain; charset="utf-8" Add missing break statement to address a violation of MISRA C Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/hvm/pmtimer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c index 97099ac305..87a7a01c9f 100644 --- a/xen/arch/x86/hvm/pmtimer.c +++ b/xen/arch/x86/hvm/pmtimer.c @@ -185,6 +185,7 @@ static int cf_check handle_evt_io( gdprintk(XENLOG_WARNING,=20 "Bad ACPI PM register write: %x bytes (%x) at %x\= n",=20 bytes, *val, port); + break; } } /* Fix up the SCI state to match the new register state */ --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892182195884.3670843301938; Thu, 20 Jun 2024 07:03:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744622.1151777 (Exim 4.92) (envelope-from ) id 1sKINB-00023a-Qe; Thu, 20 Jun 2024 14:02:45 +0000 Received: by outflank-mailman (output) from mailman id 744622.1151777; Thu, 20 Jun 2024 14:02:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKINB-00021i-FT; Thu, 20 Jun 2024 14:02:45 +0000 Received: by outflank-mailman (input) for mailman id 744622; Thu, 20 Jun 2024 14:02:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN9-0007p2-5T for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2a66b2c-2f0d-11ef-90a3-e314d9c70b13; Thu, 20 Jun 2024 16:02:42 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id 26FD04EE0754; Thu, 20 Jun 2024 16:02:41 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2a66b2c-2f0d-11ef-90a3-e314d9c70b13 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 12/13] x86/vPIC: address a violation of MISRA C Rule 16.3 Date: Thu, 20 Jun 2024 16:02:23 +0200 Message-Id: <22c3d314f769b683241f8bdabf006225714aa07a.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892184215100024 Content-Type: text/plain; charset="utf-8" Add pseudokeyword fallthrough to meet the requirements to deviate a violation of MISRA C Rul 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/hvm/vpic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/hvm/vpic.c b/xen/arch/x86/hvm/vpic.c index 7c3b5c7254..6427b08086 100644 --- a/xen/arch/x86/hvm/vpic.c +++ b/xen/arch/x86/hvm/vpic.c @@ -309,6 +309,7 @@ static void vpic_ioport_write( if ( !(vpic->init_state & 8) ) break; /* CASCADE mode: wait for write to ICW3. */ /* SNGL mode: fall through (no ICW3). */ + fallthrough; case 2: /* ICW3 */ vpic->init_state++; --=20 2.34.1 From nobody Mon Nov 25 03:56:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892507013728.4478580872617; Thu, 20 Jun 2024 07:08:27 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744703.1151804 (Exim 4.92) (envelope-from ) id 1sKISN-0006XD-R6; Thu, 20 Jun 2024 14:08:07 +0000 Received: by outflank-mailman (output) from mailman id 744703.1151804; Thu, 20 Jun 2024 14:08:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKISN-0006X6-OS; Thu, 20 Jun 2024 14:08:07 +0000 Received: by outflank-mailman (input) for mailman id 744703; Thu, 20 Jun 2024 14:08:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKINC-0007p3-9N for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:46 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c30e5dbd-2f0d-11ef-b4bb-af5377834399; Thu, 20 Jun 2024 16:02:42 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id EA6BE4EE0758; Thu, 20 Jun 2024 16:02:41 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c30e5dbd-2f0d-11ef-b4bb-af5377834399 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 13/13] x86/vlapic: address a violation of MISRA C Rule 16.3 Date: Thu, 20 Jun 2024 16:02:24 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892508989100001 Content-Type: text/plain; charset="utf-8" Add missing break statement to address a violation of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/hvm/vlapic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 9cfc82666a..2ec9594271 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -367,6 +367,7 @@ static void vlapic_accept_irq(struct vcpu *v, uint32_t = icr_low) gdprintk(XENLOG_ERR, "TODO: unsupported delivery mode in ICR %x\n", icr_low); domain_crash(v->domain); + break; } } =20 --=20 2.34.1