From nobody Tue May 21 12:31:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1709896893142729.2187063437708; Fri, 8 Mar 2024 03:21:33 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.690220.1076005 (Exim 4.92) (envelope-from ) id 1riYHq-0006Lr-0P; Fri, 08 Mar 2024 11:21:14 +0000 Received: by outflank-mailman (output) from mailman id 690220.1076005; Fri, 08 Mar 2024 11:21:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHp-0006Lk-TS; Fri, 08 Mar 2024 11:21:13 +0000 Received: by outflank-mailman (input) for mailman id 690220; Fri, 08 Mar 2024 11:21:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHo-00067H-2M for xen-devel@lists.xenproject.org; Fri, 08 Mar 2024 11:21:12 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f70e9300-dd3d-11ee-a1ee-f123f15fe8a2; Fri, 08 Mar 2024 12:21:10 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id 0CAA94EE074D; Fri, 8 Mar 2024 12:21:08 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f70e9300-dd3d-11ee-a1ee-f123f15fe8a2 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [XEN PATCH v2 1/7] xen/spinlock: address violations of MISRA C Rule 20.7 Date: Fri, 8 Mar 2024 12:20:58 +0100 Message-Id: <59e9749d3c6a22469bc9fb804b7b7c13850e9e94.1709896401.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709896894493100001 Content-Type: text/plain; charset="utf-8" MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- xen/include/xen/spinlock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index 1cd9120eac7a..0e6a083dfb9e 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -94,7 +94,7 @@ struct lock_profile_qhead { int32_t idx; /* index for printout */ }; =20 -#define _LOCK_PROFILE(lockname) { .name =3D #lockname, .lock =3D &lockname= , } +#define _LOCK_PROFILE(lockname) { .name =3D #lockname, .lock =3D &(locknam= e), } #define _LOCK_PROFILE_PTR(name) = \ static struct lock_profile * const __lock_profile_##name = \ __used_section(".lockprofile.data") =3D = \ --=20 2.34.1 From nobody Tue May 21 12:31:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1709896897302477.3684938620405; Fri, 8 Mar 2024 03:21:37 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.690221.1076009 (Exim 4.92) (envelope-from ) id 1riYHq-0006P5-7n; Fri, 08 Mar 2024 11:21:14 +0000 Received: by outflank-mailman (output) from mailman id 690221.1076009; Fri, 08 Mar 2024 11:21:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHq-0006Om-4d; Fri, 08 Mar 2024 11:21:14 +0000 Received: by outflank-mailman (input) for mailman id 690221; Fri, 08 Mar 2024 11:21:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHo-00067S-Te for xen-devel@lists.xenproject.org; Fri, 08 Mar 2024 11:21:12 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f80cadda-dd3d-11ee-afda-a90da7624cb6; Fri, 08 Mar 2024 12:21:12 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id 5DC274EE074E; Fri, 8 Mar 2024 12:21:10 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f80cadda-dd3d-11ee-afda-a90da7624cb6 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [XEN PATCH v2 2/7] xen/include: address violations of MISRA C Rule 20.7 Date: Fri, 8 Mar 2024 12:20:59 +0100 Message-Id: <5be252bfb30682d33aecca11921dcdfcc17f9ae6.1709896401.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709896898517100005 Content-Type: text/plain; charset="utf-8" MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- Changes in v2: - split from an earlier patch --- xen/include/xen/bug.h | 2 +- xen/include/xen/init.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/include/xen/bug.h b/xen/include/xen/bug.h index 2c45c462fc63..77fe1e1ba840 100644 --- a/xen/include/xen/bug.h +++ b/xen/include/xen/bug.h @@ -80,7 +80,7 @@ struct bug_frame { [bf_type] "i" (type), = \ [bf_ptr] "i" (ptr), = \ [bf_msg] "i" (msg), = \ - [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) = \ + [bf_line_lo] "i" (((line) & ((1 << BUG_LINE_LO_WIDTH) - 1)) = \ << BUG_DISP_WIDTH), = \ [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) =20 diff --git a/xen/include/xen/init.h b/xen/include/xen/init.h index 1d7c0216bc80..0a4223833755 100644 --- a/xen/include/xen/init.h +++ b/xen/include/xen/init.h @@ -63,9 +63,9 @@ typedef int (*initcall_t)(void); typedef void (*exitcall_t)(void); =20 #define presmp_initcall(fn) \ - const static initcall_t __initcall_##fn __init_call("presmp") =3D fn + const static initcall_t __initcall_##fn __init_call("presmp") =3D (fn) #define __initcall(fn) \ - const static initcall_t __initcall_##fn __init_call("1") =3D fn + const static initcall_t __initcall_##fn __init_call("1") =3D (fn) #define __exitcall(fn) \ static exitcall_t __exitcall_##fn __exit_call =3D fn =20 --=20 2.34.1 From nobody Tue May 21 12:31:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1709896893742644.3263286436137; Fri, 8 Mar 2024 03:21:33 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.690222.1076014 (Exim 4.92) (envelope-from ) id 1riYHq-0006VM-I6; Fri, 08 Mar 2024 11:21:14 +0000 Received: by outflank-mailman (output) from mailman id 690222.1076014; Fri, 08 Mar 2024 11:21:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHq-0006U9-Db; Fri, 08 Mar 2024 11:21:14 +0000 Received: by outflank-mailman (input) for mailman id 690222; Fri, 08 Mar 2024 11:21:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHp-00067S-JD for xen-devel@lists.xenproject.org; Fri, 08 Mar 2024 11:21:13 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f86ed5ae-dd3d-11ee-afda-a90da7624cb6; Fri, 08 Mar 2024 12:21:12 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id EE06F4EE074F; Fri, 8 Mar 2024 12:21:11 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f86ed5ae-dd3d-11ee-afda-a90da7624cb6 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [XEN PATCH v2 3/7] xen/list: address violations of MISRA C Rule 20.7 Date: Fri, 8 Mar 2024 12:21:00 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709896894591100005 Content-Type: text/plain; charset="utf-8" MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- Changes in v2: - changes to list.h are all in this patch; - Parenthesized some instances of "pos" and "n" even when already covered by the deviation on the lhs of an assingment for consistency. --- xen/include/xen/list.h | 83 +++++++++++++++++++++--------------------- 1 file changed, 41 insertions(+), 42 deletions(-) diff --git a/xen/include/xen/list.h b/xen/include/xen/list.h index b5eab3a1eb6c..27cafcce2c82 100644 --- a/xen/include/xen/list.h +++ b/xen/include/xen/list.h @@ -479,9 +479,9 @@ static inline void list_splice_init(struct list_head *l= ist, * @n: another &struct list_head to use as temporary storage * @head: the head for your list. */ -#define list_for_each_backwards_safe(pos, n, head) \ - for ( pos =3D (head)->prev, n =3D pos->prev; pos !=3D (head); \ - pos =3D n, n =3D pos->prev ) +#define list_for_each_backwards_safe(pos, n, head) \ + for ( (pos) =3D (head)->prev, n =3D (pos)->prev; (pos) !=3D (head); \ + (pos) =3D n, n =3D (pos)->prev ) =20 /** * list_for_each_entry - iterate over list of given type @@ -490,9 +490,9 @@ static inline void list_splice_init(struct list_head *l= ist, * @member: the name of the list_struct within the struct. */ #define list_for_each_entry(pos, head, member) \ - for (pos =3D list_entry((head)->next, typeof(*pos), member); \ - &pos->member !=3D (head); \ - pos =3D list_entry(pos->member.next, typeof(*pos), member)) + for ((pos) =3D list_entry((head)->next, typeof(*(pos)), member); \ + &(pos)->member !=3D (head); \ + (pos) =3D list_entry((pos)->member.next, typeof(*(pos)), member)) =20 /** * list_for_each_entry_reverse - iterate backwards over list of given type. @@ -501,9 +501,9 @@ static inline void list_splice_init(struct list_head *l= ist, * @member: the name of the list_struct within the struct. */ #define list_for_each_entry_reverse(pos, head, member) \ - for (pos =3D list_entry((head)->prev, typeof(*pos), member); \ - &pos->member !=3D (head); \ - pos =3D list_entry(pos->member.prev, typeof(*pos), member)) + for ((pos) =3D list_entry((head)->prev, typeof(*(pos)), member); \ + &(pos)->member !=3D (head); \ + (pos) =3D list_entry((pos)->member.prev, typeof(*(pos)), member)) =20 /** * list_prepare_entry - prepare a pos entry for use in @@ -516,7 +516,7 @@ static inline void list_splice_init(struct list_head *l= ist, * list_for_each_entry_continue. */ #define list_prepare_entry(pos, head, member) \ - ((pos) ? : list_entry(head, typeof(*pos), member)) + ((pos) ? : list_entry(head, typeof(*(pos)), member)) =20 /** * list_for_each_entry_continue - continue iteration over list of given ty= pe @@ -527,10 +527,10 @@ static inline void list_splice_init(struct list_head = *list, * Continue to iterate over list of given type, continuing after * the current position. */ -#define list_for_each_entry_continue(pos, head, member) \ - for (pos =3D list_entry(pos->member.next, typeof(*pos), member); \ - &pos->member !=3D (head); \ - pos =3D list_entry(pos->member.next, typeof(*pos), member)) +#define list_for_each_entry_continue(pos, head, member) \ + for ((pos) =3D list_entry((pos)->member.next, typeof(*(pos)), member);= \ + &(pos)->member !=3D (head); = \ + (pos) =3D list_entry((pos)->member.next, typeof(*(pos)), member)) =20 /** * list_for_each_entry_from - iterate over list of given type from the @@ -542,8 +542,8 @@ static inline void list_splice_init(struct list_head *l= ist, * Iterate over list of given type, continuing from current position. */ #define list_for_each_entry_from(pos, head, member) \ - for (; &pos->member !=3D (head); \ - pos =3D list_entry(pos->member.next, typeof(*pos), member)) + for (; &(pos)->member !=3D (head); \ + (pos) =3D list_entry((pos)->member.next, typeof(*(pos)), member)) =20 /** * list_for_each_entry_safe - iterate over list of given type safe @@ -554,10 +554,10 @@ static inline void list_splice_init(struct list_head = *list, * @member: the name of the list_struct within the struct. */ #define list_for_each_entry_safe(pos, n, head, member) \ - for (pos =3D list_entry((head)->next, typeof(*pos), member), \ - n =3D list_entry(pos->member.next, typeof(*pos), member); \ - &pos->member !=3D (head); \ - pos =3D n, n =3D list_entry(n->member.next, typeof(*n), member)) + for ((pos) =3D list_entry((head)->next, typeof(*(pos)), member), \ + (n) =3D list_entry((pos)->member.next, typeof(*(pos)), member); \ + &(pos)->member !=3D (head); \ + (pos) =3D (n), (n) =3D list_entry((n)->member.next, typeof(*(n)),= member)) =20 /** * list_for_each_entry_safe_continue @@ -569,11 +569,11 @@ static inline void list_splice_init(struct list_head = *list, * Iterate over list of given type, continuing after current point, * safe against removal of list entry. */ -#define list_for_each_entry_safe_continue(pos, n, head, member) \ - for (pos =3D list_entry(pos->member.next, typeof(*pos), member), \ - n =3D list_entry(pos->member.next, typeof(*pos), member); \ - &pos->member !=3D (head); \ - pos =3D n, n =3D list_entry(n->member.next, typeof(*n), member)) +#define list_for_each_entry_safe_continue(pos, n, head, member) \ + for ((pos) =3D list_entry((pos)->member.next, typeof(*(pos)), member),= \ + (n) =3D list_entry((pos)->member.next, typeof(*(pos)), member); = \ + &(pos)->member !=3D (head); = \ + (pos) =3D (n), (n) =3D list_entry((n)->member.next, typeof(*(n)),= member)) =20 /** * list_for_each_entry_safe_from @@ -586,9 +586,9 @@ static inline void list_splice_init(struct list_head *l= ist, * removal of list entry. */ #define list_for_each_entry_safe_from(pos, n, head, member) \ - for (n =3D list_entry(pos->member.next, typeof(*pos), member); \ - &pos->member !=3D (head); \ - pos =3D n, n =3D list_entry(n->member.next, typeof(*n), member)) + for ((n) =3D list_entry((pos)->member.next, typeof(*(pos)), member); \ + &(pos)->member !=3D (head); \ + (pos) =3D (n), (n) =3D list_entry((n)->member.next, typeof(*(n)),= member)) =20 /** * list_for_each_entry_safe_reverse @@ -601,10 +601,10 @@ static inline void list_splice_init(struct list_head = *list, * of list entry. */ #define list_for_each_entry_safe_reverse(pos, n, head, member) \ - for (pos =3D list_entry((head)->prev, typeof(*pos), member), \ - n =3D list_entry(pos->member.prev, typeof(*pos), member); \ - &pos->member !=3D (head); \ - pos =3D n, n =3D list_entry(n->member.prev, typeof(*n), member)) + for ((pos) =3D list_entry((head)->prev, typeof(*(pos)), member), \ + (n) =3D list_entry((pos)->member.prev, typeof(*(pos)), member); \ + &(pos)->member !=3D (head); \ + (pos) =3D (n), (n) =3D list_entry((n)->member.prev, typeof(*(n)),= member)) =20 /** * list_for_each_rcu - iterate over an rcu-protected list @@ -616,14 +616,14 @@ static inline void list_splice_init(struct list_head = *list, * as long as the traversal is guarded by rcu_read_lock(). */ #define list_for_each_rcu(pos, head) \ - for (pos =3D (head)->next; \ + for ((pos) =3D (head)->next; \ rcu_dereference(pos) !=3D (head); \ - pos =3D pos->next) + (pos) =3D (pos)->next) =20 #define __list_for_each_rcu(pos, head) \ - for (pos =3D (head)->next; \ + for ((pos) =3D (head)->next; \ rcu_dereference(pos) !=3D (head); \ - pos =3D pos->next) + (pos) =3D (pos)->next) =20 /** * list_for_each_safe_rcu @@ -638,9 +638,9 @@ static inline void list_splice_init(struct list_head *l= ist, * as long as the traversal is guarded by rcu_read_lock(). */ #define list_for_each_safe_rcu(pos, n, head) \ - for (pos =3D (head)->next; \ - n =3D rcu_dereference(pos)->next, pos !=3D (head); \ - pos =3D n) + for ((pos) =3D (head)->next; \ + (n) =3D rcu_dereference(pos)->next, (pos) !=3D (head); \ + (pos) =3D (n)) =20 /** * list_for_each_entry_rcu - iterate over rcu list of given type @@ -653,9 +653,9 @@ static inline void list_splice_init(struct list_head *l= ist, * as long as the traversal is guarded by rcu_read_lock(). */ #define list_for_each_entry_rcu(pos, head, member) \ - for (pos =3D list_entry((head)->next, typeof(*pos), member); \ + for ((pos) =3D list_entry((head)->next, typeof(*(pos)), member); \ &rcu_dereference(pos)->member !=3D (head); \ - pos =3D list_entry(pos->member.next, typeof(*pos), member)) + (pos) =3D list_entry((pos)->member.next, typeof(*(pos)), member)) =20 /** * list_for_each_continue_rcu @@ -977,4 +977,3 @@ static inline void hlist_add_after_rcu(struct hlist_nod= e *prev, pos =3D pos->next) =20 #endif /* __XEN_LIST_H__ */ - --=20 2.34.1 From nobody Tue May 21 12:31:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1709896897329724.2773787449479; Fri, 8 Mar 2024 03:21:37 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.690223.1076035 (Exim 4.92) (envelope-from ) id 1riYHs-00074d-To; Fri, 08 Mar 2024 11:21:16 +0000 Received: by outflank-mailman (output) from mailman id 690223.1076035; Fri, 08 Mar 2024 11:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHs-00074W-R7; Fri, 08 Mar 2024 11:21:16 +0000 Received: by outflank-mailman (input) for mailman id 690223; Fri, 08 Mar 2024 11:21:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHr-00067H-Fd for xen-devel@lists.xenproject.org; Fri, 08 Mar 2024 11:21:15 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f8c7a6ae-dd3d-11ee-a1ee-f123f15fe8a2; Fri, 08 Mar 2024 12:21:13 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id 938824EE0751; Fri, 8 Mar 2024 12:21:12 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8c7a6ae-dd3d-11ee-a1ee-f123f15fe8a2 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [XEN PATCH v2 4/7] xen/param: address violations of MISRA C Rule 20.7 Date: Fri, 8 Mar 2024 12:21:01 +0100 Message-Id: <6ad91190bd777ee76d94efbe71341a38dbcdb428.1709896401.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709896898512100003 Content-Type: text/plain; charset="utf-8" MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- xen/include/xen/param.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/xen/include/xen/param.h b/xen/include/xen/param.h index 13607e0e50e0..1bdbab34ab1f 100644 --- a/xen/include/xen/param.h +++ b/xen/include/xen/param.h @@ -45,42 +45,42 @@ extern const struct kernel_param __setup_start[], __set= up_end[]; #define TEMP_NAME(base) _TEMP_NAME(base, __LINE__) =20 #define custom_param(_name, _var) \ - __setup_str __setup_str_##_var[] =3D _name; \ + __setup_str __setup_str_##_var[] =3D (_name); \ __kparam __setup_##_var =3D \ { .name =3D __setup_str_##_var, \ .type =3D OPT_CUSTOM, \ - .par.func =3D _var } + .par.func =3D (_var) } #define boolean_param(_name, _var) \ - __setup_str __setup_str_##_var[] =3D _name; \ + __setup_str __setup_str_##_var[] =3D (_name); \ __kparam __setup_##_var =3D \ { .name =3D __setup_str_##_var, \ .type =3D OPT_BOOL, \ .len =3D sizeof(_var) + \ BUILD_BUG_ON_ZERO(sizeof(_var) !=3D sizeof(bool)), \ - .par.var =3D &_var } + .par.var =3D &(_var) } #define integer_param(_name, _var) \ - __setup_str __setup_str_##_var[] =3D _name; \ + __setup_str __setup_str_##_var[] =3D (_name); \ __kparam __setup_##_var =3D \ { .name =3D __setup_str_##_var, \ .type =3D OPT_UINT, \ .len =3D sizeof(_var), \ - .par.var =3D &_var } + .par.var =3D &(_var) } #define size_param(_name, _var) \ - __setup_str __setup_str_##_var[] =3D _name; \ + __setup_str __setup_str_##_var[] =3D (_name); \ __kparam __setup_##_var =3D \ { .name =3D __setup_str_##_var, \ .type =3D OPT_SIZE, \ .len =3D sizeof(_var), \ - .par.var =3D &_var } + .par.var =3D &(_var) } #define string_param(_name, _var) \ - __setup_str __setup_str_##_var[] =3D _name; \ + __setup_str __setup_str_##_var[] =3D (_name); \ __kparam __setup_##_var =3D \ { .name =3D __setup_str_##_var, \ .type =3D OPT_STR, \ .len =3D sizeof(_var), \ - .par.var =3D &_var } + .par.var =3D &(_var) } #define ignore_param(_name) \ - __setup_str TEMP_NAME(__setup_str_ign)[] =3D _name; \ + __setup_str TEMP_NAME(__setup_str_ign)[] =3D (_name); \ __kparam TEMP_NAME(__setup_ign) =3D \ { .name =3D TEMP_NAME(__setup_str_ign), \ .type =3D OPT_IGNORE } --=20 2.34.1 From nobody Tue May 21 12:31:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1709896898016682.915122041773; Fri, 8 Mar 2024 03:21:38 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.690225.1076055 (Exim 4.92) (envelope-from ) id 1riYHv-0007cr-Gz; Fri, 08 Mar 2024 11:21:19 +0000 Received: by outflank-mailman (output) from mailman id 690225.1076055; Fri, 08 Mar 2024 11:21:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHv-0007cb-Cu; Fri, 08 Mar 2024 11:21:19 +0000 Received: by outflank-mailman (input) for mailman id 690225; Fri, 08 Mar 2024 11:21:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHt-00067H-Fp for xen-devel@lists.xenproject.org; Fri, 08 Mar 2024 11:21:17 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f916982d-dd3d-11ee-a1ee-f123f15fe8a2; Fri, 08 Mar 2024 12:21:13 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id 2DF404EE0750; Fri, 8 Mar 2024 12:21:13 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f916982d-dd3d-11ee-a1ee-f123f15fe8a2 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Volodymyr Babchuk Subject: [XEN PATCH v2 5/7] xen/arm: address some violations of MISRA C Rule 20.7 Date: Fri, 8 Mar 2024 12:21:02 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709896898562100009 Content-Type: text/plain; charset="utf-8" MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- Style in arm64/cpufeature.c has not been amended, because this file seems to be kept in sync with its Linux counterpart. Changes in v2: - Added parentheses for consistency --- xen/arch/arm/arm64/cpufeature.c | 14 ++++----- xen/arch/arm/cpuerrata.c | 8 +++--- xen/arch/arm/include/asm/arm64/sysregs.h | 2 +- xen/arch/arm/include/asm/guest_atomics.h | 4 +-- xen/arch/arm/include/asm/mm.h | 2 +- xen/arch/arm/include/asm/smccc.h | 36 ++++++++++++------------ xen/arch/arm/include/asm/vgic-emul.h | 8 +++--- xen/arch/arm/vcpreg.c | 5 ++-- 8 files changed, 40 insertions(+), 39 deletions(-) diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeatur= e.c index 864413d9cc03..6fb8974ade7f 100644 --- a/xen/arch/arm/arm64/cpufeature.c +++ b/xen/arch/arm/arm64/cpufeature.c @@ -78,13 +78,13 @@ =20 #define __ARM64_FTR_BITS(SIGNED, VISIBLE, STRICT, TYPE, SHIFT, WIDTH, SAFE= _VAL) \ { \ - .sign =3D SIGNED, \ - .visible =3D VISIBLE, \ - .strict =3D STRICT, \ - .type =3D TYPE, \ - .shift =3D SHIFT, \ - .width =3D WIDTH, \ - .safe_val =3D SAFE_VAL, \ + .sign =3D (SIGNED), \ + .visible =3D (VISIBLE), \ + .strict =3D (STRICT), \ + .type =3D (TYPE), \ + .shift =3D (SHIFT), \ + .width =3D (WIDTH), \ + .safe_val =3D (SAFE_VAL), \ } =20 /* Define a feature with unsigned values */ diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c index a28fa6ac78cc..2b7101ea2524 100644 --- a/xen/arch/arm/cpuerrata.c +++ b/xen/arch/arm/cpuerrata.c @@ -461,13 +461,13 @@ static bool has_ssbd_mitigation(const struct arm_cpu_= capabilities *entry) =20 #define MIDR_RANGE(model, min, max) \ .matches =3D is_affected_midr_range, \ - .midr_model =3D model, \ - .midr_range_min =3D min, \ - .midr_range_max =3D max + .midr_model =3D (model), \ + .midr_range_min =3D (min), \ + .midr_range_max =3D (max) =20 #define MIDR_ALL_VERSIONS(model) \ .matches =3D is_affected_midr_range, \ - .midr_model =3D model, \ + .midr_model =3D (model), \ .midr_range_min =3D 0, \ .midr_range_max =3D (MIDR_VARIANT_MASK | MIDR_REVISION_MASK) =20 diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/includ= e/asm/arm64/sysregs.h index 3fdeb9d8cdef..b593e4028b53 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -465,7 +465,7 @@ /* Access to system registers */ =20 #define WRITE_SYSREG64(v, name) do { \ - uint64_t _r =3D v; \ + uint64_t _r =3D (v); \ asm volatile("msr "__stringify(name)", %0" : : "r" (_r)); \ } while (0) #define READ_SYSREG64(name) ({ \ diff --git a/xen/arch/arm/include/asm/guest_atomics.h b/xen/arch/arm/includ= e/asm/guest_atomics.h index a1745f8613f6..8893eb9a55d7 100644 --- a/xen/arch/arm/include/asm/guest_atomics.h +++ b/xen/arch/arm/include/asm/guest_atomics.h @@ -32,7 +32,7 @@ static inline void guest_##name(struct domain *d, int nr,= volatile void *p) \ perfc_incr(atomics_guest_paused); = \ = \ domain_pause_nosync(d); = \ - name(nr, p); = \ + (name)(nr, p); = \ domain_unpause(d); = \ } =20 @@ -52,7 +52,7 @@ static inline int guest_##name(struct domain *d, int nr, = volatile void *p) \ perfc_incr(atomics_guest_paused); = \ = \ domain_pause_nosync(d); = \ - oldbit =3D name(nr, p); = \ + oldbit =3D (name)(nr, p); = \ domain_unpause(d); = \ = \ return oldbit; = \ diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index cbcf3bf14767..48538b5337aa 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -250,7 +250,7 @@ static inline void __iomem *ioremap_wc(paddr_t start, s= ize_t len) #define gaddr_to_gfn(ga) _gfn(paddr_to_pfn(ga)) #define mfn_to_maddr(mfn) pfn_to_paddr(mfn_x(mfn)) #define maddr_to_mfn(ma) _mfn(paddr_to_pfn(ma)) -#define vmap_to_mfn(va) maddr_to_mfn(virt_to_maddr((vaddr_t)va)) +#define vmap_to_mfn(va) maddr_to_mfn(virt_to_maddr((vaddr_t)(va))) #define vmap_to_page(va) mfn_to_page(vmap_to_mfn(va)) =20 /* Page-align address and convert to frame number format */ diff --git a/xen/arch/arm/include/asm/smccc.h b/xen/arch/arm/include/asm/sm= ccc.h index 1adcd37443c7..a289c48b7ffd 100644 --- a/xen/arch/arm/include/asm/smccc.h +++ b/xen/arch/arm/include/asm/smccc.h @@ -122,56 +122,56 @@ struct arm_smccc_res { #define __constraint_read_7 __constraint_read_6, "r" (r7) =20 #define __declare_arg_0(a0, res) \ - struct arm_smccc_res *___res =3D res; \ - register unsigned long r0 ASM_REG(0) =3D (uint32_t)a0; \ + struct arm_smccc_res *___res =3D (res); \ + register unsigned long r0 ASM_REG(0) =3D (uint32_t)(a0); \ register unsigned long r1 ASM_REG(1); \ register unsigned long r2 ASM_REG(2); \ register unsigned long r3 ASM_REG(3) =20 #define __declare_arg_1(a0, a1, res) \ - typeof(a1) __a1 =3D a1; \ - struct arm_smccc_res *___res =3D res; \ - register unsigned long r0 ASM_REG(0) =3D (uint32_t)a0; \ + typeof(a1) __a1 =3D (a1); \ + struct arm_smccc_res *___res =3D (res); \ + register unsigned long r0 ASM_REG(0) =3D (uint32_t)(a0); \ register unsigned long r1 ASM_REG(1) =3D __a1; \ register unsigned long r2 ASM_REG(2); \ register unsigned long r3 ASM_REG(3) =20 #define __declare_arg_2(a0, a1, a2, res) \ - typeof(a1) __a1 =3D a1; \ - typeof(a2) __a2 =3D a2; \ - struct arm_smccc_res *___res =3D res; \ - register unsigned long r0 ASM_REG(0) =3D (uint32_t)a0; \ + typeof(a1) __a1 =3D (a1); \ + typeof(a2) __a2 =3D (a2); \ + struct arm_smccc_res *___res =3D (res); \ + register unsigned long r0 ASM_REG(0) =3D (uint32_t)(a0); \ register unsigned long r1 ASM_REG(1) =3D __a1; \ register unsigned long r2 ASM_REG(2) =3D __a2; \ register unsigned long r3 ASM_REG(3) =20 #define __declare_arg_3(a0, a1, a2, a3, res) \ - typeof(a1) __a1 =3D a1; \ - typeof(a2) __a2 =3D a2; \ - typeof(a3) __a3 =3D a3; \ - struct arm_smccc_res *___res =3D res; \ - register unsigned long r0 ASM_REG(0) =3D (uint32_t)a0; \ + typeof(a1) __a1 =3D (a1); \ + typeof(a2) __a2 =3D (a2); \ + typeof(a3) __a3 =3D (a3); \ + struct arm_smccc_res *___res =3D (res); \ + register unsigned long r0 ASM_REG(0) =3D (uint32_t)(a0); \ register unsigned long r1 ASM_REG(1) =3D __a1; \ register unsigned long r2 ASM_REG(2) =3D __a2; \ register unsigned long r3 ASM_REG(3) =3D __a3 =20 #define __declare_arg_4(a0, a1, a2, a3, a4, res) \ - typeof(a4) __a4 =3D a4; \ + typeof(a4) __a4 =3D (a4); \ __declare_arg_3(a0, a1, a2, a3, res); \ register unsigned long r4 ASM_REG(4) =3D __a4 =20 #define __declare_arg_5(a0, a1, a2, a3, a4, a5, res) \ - typeof(a5) __a5 =3D a5; \ + typeof(a5) __a5 =3D (a5); \ __declare_arg_4(a0, a1, a2, a3, a4, res); \ register typeof(a5) r5 ASM_REG(5) =3D __a5 =20 #define __declare_arg_6(a0, a1, a2, a3, a4, a5, a6, res) \ - typeof(a6) __a6 =3D a6; \ + typeof(a6) __a6 =3D (a6); \ __declare_arg_5(a0, a1, a2, a3, a4, a5, res); \ register typeof(a6) r6 ASM_REG(6) =3D __a6 =20 #define __declare_arg_7(a0, a1, a2, a3, a4, a5, a6, a7, res) \ - typeof(a7) __a7 =3D a7; \ + typeof(a7) __a7 =3D (a7); \ __declare_arg_6(a0, a1, a2, a3, a4, a5, a6, res); \ register typeof(a7) r7 ASM_REG(7) =3D __a7 =20 diff --git a/xen/arch/arm/include/asm/vgic-emul.h b/xen/arch/arm/include/as= m/vgic-emul.h index e52fbaa3ec04..fd0cfa2175fe 100644 --- a/xen/arch/arm/include/asm/vgic-emul.h +++ b/xen/arch/arm/include/asm/vgic-emul.h @@ -6,11 +6,11 @@ * a range of registers */ =20 -#define VREG32(reg) reg ... reg + 3 -#define VREG64(reg) reg ... reg + 7 +#define VREG32(reg) (reg) ... ((reg) + 3) +#define VREG64(reg) (reg) ... ((reg) + 7) =20 -#define VRANGE32(start, end) start ... end + 3 -#define VRANGE64(start, end) start ... end + 7 +#define VRANGE32(start, end) (start) ... ((end) + 3) +#define VRANGE64(start, end) (start) ... ((end) + 7) =20 /* * 64 bits registers can be accessible using 32-bit and 64-bit unless diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c index a2d050070473..019cf34f003a 100644 --- a/xen/arch/arm/vcpreg.c +++ b/xen/arch/arm/vcpreg.c @@ -39,7 +39,8 @@ */ =20 #ifdef CONFIG_ARM_64 -#define WRITE_SYSREG_SZ(sz, val, sysreg) WRITE_SYSREG((uint##sz##_t)val, s= ysreg) +#define WRITE_SYSREG_SZ(sz, val, sysreg) \ + WRITE_SYSREG((uint##sz##_t)(val), sysreg) #else /* * WRITE_SYSREG{32/64} on arm32 is defined as variadic macro which imposes @@ -64,7 +65,7 @@ static bool func(struct cpu_user_regs *regs, type##sz##_t= *r, bool read) \ bool cache_enabled =3D vcpu_has_cache_enabled(v); = \ = \ GUEST_BUG_ON(read); = \ - WRITE_SYSREG_SZ(sz, *r, reg); = \ + WRITE_SYSREG_SZ(sz, *(r), reg); = \ = \ p2m_toggle_cache(v, cache_enabled); = \ = \ --=20 2.34.1 From nobody Tue May 21 12:31:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1709896893443451.7369796280244; Fri, 8 Mar 2024 03:21:33 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.690224.1076045 (Exim 4.92) (envelope-from ) id 1riYHu-0007Lb-9O; Fri, 08 Mar 2024 11:21:18 +0000 Received: by outflank-mailman (output) from mailman id 690224.1076045; Fri, 08 Mar 2024 11:21:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHu-0007LM-3q; Fri, 08 Mar 2024 11:21:18 +0000 Received: by outflank-mailman (input) for mailman id 690224; Fri, 08 Mar 2024 11:21:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHs-00067H-Fl for xen-devel@lists.xenproject.org; Fri, 08 Mar 2024 11:21:16 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f97d751c-dd3d-11ee-a1ee-f123f15fe8a2; Fri, 08 Mar 2024 12:21:14 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id AB5144EE074C; Fri, 8 Mar 2024 12:21:13 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f97d751c-dd3d-11ee-a1ee-f123f15fe8a2 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 6/7] x86/irq: parenthesize negative constants Date: Fri, 8 Mar 2024 12:21:03 +0100 Message-Id: <9b7e9135952e51043427e3233305917126c95659.1709896401.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709896894494100002 Content-Type: text/plain; charset="utf-8" These constants are parenthesized to avoid them from possibly influencing the semantics of the constructs where it is used, especially inside macros invocations. This also resolves some violations of MISRA C Rule 20.7 ("Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses"). No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- Changes in v2: - dropped the controversial GUARD(1) hunk --- xen/arch/x86/include/asm/irq.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/include/asm/irq.h b/xen/arch/x86/include/asm/irq.h index 082a3d6bbc6a..7d49f3c1904a 100644 --- a/xen/arch/x86/include/asm/irq.h +++ b/xen/arch/x86/include/asm/irq.h @@ -172,16 +172,16 @@ void cleanup_domain_irq_mapping(struct domain *d); void *__ret =3D radix_tree_lookup(&(d)->arch.irq_pirq, irq); \ __ret ? radix_tree_ptr_to_int(__ret) : 0; \ }) -#define PIRQ_ALLOCATED -1 +#define PIRQ_ALLOCATED (-1) #define domain_pirq_to_emuirq(d, pirq) pirq_field(d, pirq, \ arch.hvm.emuirq, IRQ_UNBOUND) #define domain_emuirq_to_pirq(d, emuirq) ({ \ void *__ret =3D radix_tree_lookup(&(d)->arch.hvm.emuirq_pirq, emuirq);\ __ret ? radix_tree_ptr_to_int(__ret) : IRQ_UNBOUND; \ }) -#define IRQ_UNBOUND -1 -#define IRQ_PT -2 -#define IRQ_MSI_EMU -3 +#define IRQ_UNBOUND (-1) +#define IRQ_PT (-2) +#define IRQ_MSI_EMU (-3) =20 bool cpu_has_pending_apic_eoi(void); =20 --=20 2.34.1 From nobody Tue May 21 12:31:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1709896903965733.49290318393; Fri, 8 Mar 2024 03:21:43 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.690226.1076060 (Exim 4.92) (envelope-from ) id 1riYHv-0007fF-Sz; Fri, 08 Mar 2024 11:21:19 +0000 Received: by outflank-mailman (output) from mailman id 690226.1076060; Fri, 08 Mar 2024 11:21:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHv-0007du-KY; Fri, 08 Mar 2024 11:21:19 +0000 Received: by outflank-mailman (input) for mailman id 690226; Fri, 08 Mar 2024 11:21:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1riYHu-00067H-G7 for xen-devel@lists.xenproject.org; Fri, 08 Mar 2024 11:21:18 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9d9c3dd-dd3d-11ee-a1ee-f123f15fe8a2; Fri, 08 Mar 2024 12:21:15 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id 5E37C4EE0752; Fri, 8 Mar 2024 12:21:14 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9d9c3dd-dd3d-11ee-a1ee-f123f15fe8a2 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Rahul Singh , Volodymyr Babchuk Subject: [XEN PATCH v2 7/7] arm/smmu: address some violations of MISRA C Rule 20.7 Date: Fri, 8 Mar 2024 12:21:04 +0100 Message-Id: <21369cdaa0aa34253716d4c999956faee60445ab.1709896401.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709896904620100001 Content-Type: text/plain; charset="utf-8" MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- xen/drivers/passthrough/arm/smmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/a= rm/smmu.c index 625ed0e41961..83196057a937 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -242,7 +242,7 @@ struct arm_smmu_xen_device { struct iommu_group *group; }; =20 -#define dev_archdata(dev) ((struct arm_smmu_xen_device *)dev->iommu) +#define dev_archdata(dev) ((struct arm_smmu_xen_device *)(dev)->iommu) #define dev_iommu_domain(dev) (dev_archdata(dev)->domain) #define dev_iommu_group(dev) (dev_archdata(dev)->group) =20 @@ -627,7 +627,7 @@ struct arm_smmu_master_cfg { }; #define INVALID_SMENDX -1 #define for_each_cfg_sme(cfg, i, idx, num) \ - for (i =3D 0; idx =3D cfg->smendx[i], i < num; ++i) + for (i =3D 0; idx =3D (cfg)->smendx[i], (i) < (num); ++(i)) =20 struct arm_smmu_master { struct device_node *of_node; --=20 2.34.1