From nobody Sat May 11 22:14:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1702286111063113.17059576904262; Mon, 11 Dec 2023 01:15:11 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.651526.1017195 (Exim 4.92) (envelope-from ) id 1rCcN4-0001fz-0v; Mon, 11 Dec 2023 09:14:38 +0000 Received: by outflank-mailman (output) from mailman id 651526.1017195; Mon, 11 Dec 2023 09:14:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rCcN3-0001eB-Ta; Mon, 11 Dec 2023 09:14:37 +0000 Received: by outflank-mailman (input) for mailman id 651526; Mon, 11 Dec 2023 09:14:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rCcN2-0001ce-It for xen-devel@lists.xenproject.org; Mon, 11 Dec 2023 09:14:36 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b39f2a11-9805-11ee-98e8-6d05b1d4d9a1; Mon, 11 Dec 2023 10:14:35 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 5143E4EE0741; Mon, 11 Dec 2023 10:14:34 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b39f2a11-9805-11ee-98e8-6d05b1d4d9a1 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v3 1/3] xen/x86: add missing instances of asmlinkage attributes Date: Mon, 11 Dec 2023 10:14:27 +0100 Message-Id: <2282f4b7ff0143f513f9677e0cca2d68c0f2a08c.1702285639.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1702286111396100005 Content-Type: text/plain; charset="utf-8" No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/arch/x86/efi/efi-boot.h | 5 +++-- xen/arch/x86/smpboot.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 86467da301e5..8ea64e31cdc2 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -808,8 +808,9 @@ static const char *__init get_option(const char *cmd, c= onst char *opt) return o; } =20 -void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste= mTable, - const char *cmdline) +void asmlinkage __init efi_multiboot2(EFI_HANDLE ImageHandle, + EFI_SYSTEM_TABLE *SystemTable, + const char *cmdline) { EFI_GRAPHICS_OUTPUT_PROTOCOL *gop; EFI_HANDLE gop_handle; diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index 4c54ecbc91d7..8aa621533f3d 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -310,7 +310,7 @@ static void set_cpu_sibling_map(unsigned int cpu) } } =20 -void start_secondary(void *unused) +void asmlinkage start_secondary(void *unused) { struct cpu_info *info =3D get_cpu_info(); =20 --=20 2.34.1 From nobody Sat May 11 22:14:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1702286111675994.467349891611; Mon, 11 Dec 2023 01:15:11 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.651528.1017218 (Exim 4.92) (envelope-from ) id 1rCcN6-00029r-Im; Mon, 11 Dec 2023 09:14:40 +0000 Received: by outflank-mailman (output) from mailman id 651528.1017218; Mon, 11 Dec 2023 09:14:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rCcN6-00029j-Dq; Mon, 11 Dec 2023 09:14:40 +0000 Received: by outflank-mailman (input) for mailman id 651528; Mon, 11 Dec 2023 09:14:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rCcN5-0001w8-Eg for xen-devel@lists.xenproject.org; Mon, 11 Dec 2023 09:14:39 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4793a83-9805-11ee-9b0f-b553b5be7939; Mon, 11 Dec 2023 10:14:36 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 3150F4EE0742; Mon, 11 Dec 2023 10:14:35 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4793a83-9805-11ee-9b0f-b553b5be7939 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Nicola Vetrini , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [XEN PATCH v3 2/3] x86/viridian: make build_assertions static Date: Mon, 11 Dec 2023 10:14:28 +0100 Message-Id: <2bc69a77a0fae290902019822230dd863b1041b5.1702285639.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1702286113420100001 Content-Type: text/plain; charset="utf-8" This is consistent with other instances of the same function and also resolves a violation of MISRA C:2012 Rule 8.4. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini Acked-by: Paul Durrant --- xen/arch/x86/hvm/viridian/synic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridian/= synic.c index 8cf600cec68f..3375e55e95ca 100644 --- a/xen/arch/x86/hvm/viridian/synic.c +++ b/xen/arch/x86/hvm/viridian/synic.c @@ -18,7 +18,7 @@ #include "private.h" =20 =20 -void __init __maybe_unused build_assertions(void) +static void __init __maybe_unused build_assertions(void) { BUILD_BUG_ON(sizeof(struct hv_message) !=3D HV_MESSAGE_SIZE); } --=20 2.34.1 From nobody Sat May 11 22:14:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1702286115443550.3899525299232; Mon, 11 Dec 2023 01:15:15 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.651527.1017211 (Exim 4.92) (envelope-from ) id 1rCcN6-00026R-7j; Mon, 11 Dec 2023 09:14:40 +0000 Received: by outflank-mailman (output) from mailman id 651527.1017211; Mon, 11 Dec 2023 09:14:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rCcN6-00026K-5G; Mon, 11 Dec 2023 09:14:40 +0000 Received: by outflank-mailman (input) for mailman id 651527; Mon, 11 Dec 2023 09:14:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rCcN4-0001ce-UI for xen-devel@lists.xenproject.org; Mon, 11 Dec 2023 09:14:38 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5729684-9805-11ee-98e8-6d05b1d4d9a1; Mon, 11 Dec 2023 10:14:38 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 88D164EE0741; Mon, 11 Dec 2023 10:14:36 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5729684-9805-11ee-98e8-6d05b1d4d9a1 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Nicola Vetrini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Shawn Anastasio Subject: [XEN PATCH v3 3/3] xen/mm: add declaration for first_valid_mfn Date: Mon, 11 Dec 2023 10:14:29 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1702286117415100001 Content-Type: text/plain; charset="utf-8" Such declaration is needed because a compatible declaration is not visible in xen/common/page_alloc.c, where the variable is defined. That variable can't yet be static because of the lack of support from ARM and PPC for NUMA. On the occasion, use drop a use of u8. No functional change. Signed-off-by: Nicola Vetrini --- Having this declaration essentially sidesteps the current impossibility of having a static variable, as described in the comments in ARM and PCC's asm/numa.h. Changes in v3: - Drop redundant declarations of first_valid_mfn in asm/numa.h for Arm and = PPC. --- xen/arch/arm/include/asm/numa.h | 8 ++++---- xen/arch/ppc/include/asm/numa.h | 7 +++---- xen/include/xen/mm.h | 2 ++ 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/num= a.h index e2bee2bd8223..44b689f67db8 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -2,8 +2,9 @@ #define __ARCH_ARM_NUMA_H =20 #include +#include =20 -typedef u8 nodeid_t; +typedef uint8_t nodeid_t; =20 #ifndef CONFIG_NUMA =20 @@ -12,10 +13,9 @@ typedef u8 nodeid_t; #define node_to_cpumask(node) (cpu_online_map) =20 /* - * TODO: make first_valid_mfn static when NUMA is supported on Arm, this - * is required because the dummy helpers are using it. + * TODO: define here first_valid_mfn as static when NUMA is supported on A= rm, + * this is required because the dummy helpers are using it. */ -extern mfn_t first_valid_mfn; =20 /* XXX: implement NUMA support */ #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) diff --git a/xen/arch/ppc/include/asm/numa.h b/xen/arch/ppc/include/asm/num= a.h index 7fdf66c3da74..152305ebe446 100644 --- a/xen/arch/ppc/include/asm/numa.h +++ b/xen/arch/ppc/include/asm/numa.h @@ -1,8 +1,8 @@ #ifndef __ASM_PPC_NUMA_H__ #define __ASM_PPC_NUMA_H__ =20 -#include #include +#include =20 typedef uint8_t nodeid_t; =20 @@ -11,10 +11,9 @@ typedef uint8_t nodeid_t; #define node_to_cpumask(node) (cpu_online_map) =20 /* - * TODO: make first_valid_mfn static when NUMA is supported on PPC, this - * is required because the dummy helpers are using it. + * TODO: define here first_valid_mfn as static when NUMA is supported on P= PC, + * this is required because the dummy helpers are using it. */ -extern mfn_t first_valid_mfn; =20 /* XXX: implement NUMA support */ #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 3d9b2d05a5c8..a13a9a46ced7 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -118,6 +118,8 @@ int destroy_xen_mappings(unsigned long s, unsigned long= e); /* Retrieve the MFN mapped by VA in Xen virtual address space. */ mfn_t xen_map_to_mfn(unsigned long va); =20 +extern mfn_t first_valid_mfn; + /* * Create only non-leaf page table entries for the * page range in Xen virtual address space. --=20 2.34.1