From nobody Sun May 19 09:08:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1701942678622586.9449417720963; Thu, 7 Dec 2023 01:51:18 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.649722.1014536 (Exim 4.92) (envelope-from ) id 1rBB28-00049X-Bo; Thu, 07 Dec 2023 09:51:04 +0000 Received: by outflank-mailman (output) from mailman id 649722.1014536; Thu, 07 Dec 2023 09:51:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rBB28-00049Q-7B; Thu, 07 Dec 2023 09:51:04 +0000 Received: by outflank-mailman (input) for mailman id 649722; Thu, 07 Dec 2023 09:51:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rBB26-00048w-EC for xen-devel@lists.xenproject.org; Thu, 07 Dec 2023 09:51:02 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f34fa2d-94e6-11ee-9b0f-b553b5be7939; Thu, 07 Dec 2023 10:50:58 +0100 (CET) Received: from beta.station (net-37-182-35-120.cust.vodafonedsl.it [37.182.35.120]) by support.bugseng.com (Postfix) with ESMTPSA id B5F134EE073A; Thu, 7 Dec 2023 10:50:57 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f34fa2d-94e6-11ee-9b0f-b553b5be7939 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Maria Celeste Cesario , Jan Beulich , Andrew Cooper , Kevin Tian , Simone Ballarin Subject: [PATCH 1/3] AMD/IOMMU: address violations of MISRA C:2012 Rule 14.4 Date: Thu, 7 Dec 2023 10:48:42 +0100 Message-Id: <097df7703c372a687206251fe97bfc5df18222b6.1701941924.git.maria.celeste.cesario@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1701942679216100001 Content-Type: text/plain; charset="utf-8" From: Maria Celeste Cesario The xen sources contain violations of MISRA C:2012 Rule 14.4 whose headline states: "The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type". Add comparisons to avoid using enum constants as controlling expressions to comply with Rule 14.4. No functional change. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini --- xen/drivers/passthrough/amd/iommu_init.c | 4 ++-- xen/drivers/passthrough/vtd/iommu.c | 4 ++-- xen/drivers/passthrough/vtd/quirks.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthr= ough/amd/iommu_init.c index 5515cb70fd..e02a09a9a7 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -1480,7 +1480,7 @@ int __init amd_iommu_init(bool xt) goto error_out; } =20 - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) register_keyhandler('V', &amd_iommu_dump_intremap_tables, "dump IOMMU intremap tables", 0); =20 @@ -1498,7 +1498,7 @@ int __init amd_iommu_init_late(void) =20 /* Further initialize the device table(s). */ pci_init =3D true; - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) rc =3D iterate_ivrs_mappings(amd_iommu_setup_device_table); =20 for_each_amd_iommu ( iommu ) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/= vtd/iommu.c index e13b7d99db..bd6d69a6f5 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2543,7 +2543,7 @@ static int __must_check init_vtd_hw(bool resume) /* * Enable interrupt remapping */ =20 - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) { int apic; for ( apic =3D 0; apic < nr_ioapics; apic++ ) @@ -2559,7 +2559,7 @@ static int __must_check init_vtd_hw(bool resume) } } } - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) { for_each_drhd_unit ( drhd ) { diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough= /vtd/quirks.c index 5a56565ea8..950dcd56ef 100644 --- a/xen/drivers/passthrough/vtd/quirks.c +++ b/xen/drivers/passthrough/vtd/quirks.c @@ -392,7 +392,7 @@ void __init platform_quirks_init(void) map_igd_reg(); =20 /* Tylersburg interrupt remap quirk */ - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) tylersburg_intremap_quirk(); } =20 --=20 2.40.0 From nobody Sun May 19 09:08:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1701942688520560.0399131800682; Thu, 7 Dec 2023 01:51:28 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.649723.1014544 (Exim 4.92) (envelope-from ) id 1rBB2H-0004Rw-HX; Thu, 07 Dec 2023 09:51:13 +0000 Received: by outflank-mailman (output) from mailman id 649723.1014544; Thu, 07 Dec 2023 09:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rBB2H-0004Rp-Eb; Thu, 07 Dec 2023 09:51:13 +0000 Received: by outflank-mailman (input) for mailman id 649723; Thu, 07 Dec 2023 09:51:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rBB2F-00048w-Rv for xen-devel@lists.xenproject.org; Thu, 07 Dec 2023 09:51:11 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 264f2883-94e6-11ee-9b0f-b553b5be7939; Thu, 07 Dec 2023 10:51:10 +0100 (CET) Received: from beta.station (net-37-182-35-120.cust.vodafonedsl.it [37.182.35.120]) by support.bugseng.com (Postfix) with ESMTPSA id 91B904EE073A; Thu, 7 Dec 2023 10:51:09 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 264f2883-94e6-11ee-9b0f-b553b5be7939 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Maria Celeste Cesario , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Simone Ballarin Subject: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4 Date: Thu, 7 Dec 2023 10:48:43 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1701942689273100001 Content-Type: text/plain; charset="utf-8" From: Maria Celeste Cesario The xen sources contain violations of MISRA C:2012 Rule 14.4 whose headline states: "The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type". Add comparisons to avoid using enum constants as controlling expressions to comply with Rule 14.4. No functional change. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini --- xen/arch/x86/hpet.c | 6 +++--- xen/arch/x86/msi.c | 4 ++-- xen/arch/x86/x86_emulate/x86_emulate.c | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index 7be26c6a9b..d1ddc8ddf6 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel *ch= , struct msi_msg *msg) { ch->msi.msg =3D *msg; =20 - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) { int rc =3D iommu_update_ire_from_msi(&ch->msi, msg); =20 @@ -353,7 +353,7 @@ static int __init hpet_setup_msi_irq(struct hpet_event_= channel *ch) u32 cfg =3D hpet_read32(HPET_Tn_CFG(ch->idx)); irq_desc_t *desc =3D irq_to_desc(ch->msi.irq); =20 - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) { ch->msi.hpet_id =3D hpet_blockid; ret =3D iommu_setup_hpet_msi(&ch->msi); @@ -372,7 +372,7 @@ static int __init hpet_setup_msi_irq(struct hpet_event_= channel *ch) ret =3D __hpet_setup_msi_irq(desc); if ( ret < 0 ) { - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) iommu_update_ire_from_msi(&ch->msi, NULL); return ret; } diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index 7f8e794254..72dce2e4ab 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -189,7 +189,7 @@ static int write_msi_msg(struct msi_desc *entry, struct= msi_msg *msg) { entry->msg =3D *msg; =20 - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) { int rc; =20 @@ -555,7 +555,7 @@ int msi_free_irq(struct msi_desc *entry) destroy_irq(entry[nr].irq); =20 /* Free the unused IRTE if intr remap enabled */ - if ( iommu_intremap ) + if ( iommu_intremap !=3D iommu_intremap_off ) iommu_update_ire_from_msi(entry + nr, NULL); } =20 diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emul= ate/x86_emulate.c index cf780da501..00b7365ed3 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1320,7 +1320,7 @@ x86_emulate( ea.bytes =3D 2; goto srcmem_common; case SrcMem: - if ( state->simd_size ) + if ( state->simd_size !=3D simd_none ) break; ea.bytes =3D (d & ByteOp) ? 1 : op_bytes; srcmem_common: @@ -1460,7 +1460,7 @@ x86_emulate( /* Becomes a normal DstMem operation from here on. */ case DstMem: generate_exception_if(ea.type =3D=3D OP_MEM && evex.z, X86_EXC_UD); - if ( state->simd_size ) + if ( state->simd_size !=3D simd_none ) { generate_exception_if(lock_prefix, X86_EXC_UD); break; @@ -8176,7 +8176,7 @@ x86_emulate( goto done; } =20 - if ( state->rmw ) + if ( state->rmw !=3D rmw_NONE ) { ea.val =3D src.val; op_bytes =3D dst.bytes; @@ -8205,7 +8205,7 @@ x86_emulate( =20 dst.type =3D OP_NONE; } - else if ( state->simd_size ) + else if ( state->simd_size !=3D simd_none ) { generate_exception_if(!op_bytes, X86_EXC_UD); generate_exception_if((vex.opcx && (d & TwoOp) && --=20 2.40.0 From nobody Sun May 19 09:08:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1701942693072654.053371442878; Thu, 7 Dec 2023 01:51:33 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.649724.1014555 (Exim 4.92) (envelope-from ) id 1rBB2O-0004rQ-PO; Thu, 07 Dec 2023 09:51:20 +0000 Received: by outflank-mailman (output) from mailman id 649724.1014555; Thu, 07 Dec 2023 09:51:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rBB2O-0004r8-M4; Thu, 07 Dec 2023 09:51:20 +0000 Received: by outflank-mailman (input) for mailman id 649724; Thu, 07 Dec 2023 09:51:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rBB2N-0004o2-Rs for xen-devel@lists.xenproject.org; Thu, 07 Dec 2023 09:51:19 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2b15ea27-94e6-11ee-98e7-6d05b1d4d9a1; Thu, 07 Dec 2023 10:51:18 +0100 (CET) Received: from beta.station (net-37-182-35-120.cust.vodafonedsl.it [37.182.35.120]) by support.bugseng.com (Postfix) with ESMTPSA id 0F9654EE073A; Thu, 7 Dec 2023 10:51:18 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b15ea27-94e6-11ee-98e7-6d05b1d4d9a1 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Maria Celeste Cesario , Simone Ballarin , Doug Goldstein , Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [PATCH 3/3] xen: address violations of MISRA C:2012 Rule 14.4 Date: Thu, 7 Dec 2023 10:48:44 +0100 Message-Id: <3012fb117b4ef6458bdb5cfd046c86bce60a6d51.1701941924.git.maria.celeste.cesario@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1701942695468100001 Content-Type: text/plain; charset="utf-8" From: Maria Celeste Cesario The xen sources contain violations of MISRA C:2012 Rule 14.4 whose headline states: "The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type". Struct domain member is_dying is an anonymous enum designed to act as boole= an. Add deviation to mark its uses in controlling expressions as deliberate. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 6 ++++++ docs/misra/deviations.rst | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/= eclair_analysis/ECLAIR/deviations.ecl index b0c79741b5..683f2bbfe8 100644 --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -321,6 +321,12 @@ statements are deliberate" -config=3DMC3R1.R14.3,statements=3D{deliberate , "wrapped(any(),node(if_st= mt))" } -doc_end =20 +-doc_begin=3D"The XEN team relies on the fact that the enum is_dying has t= he +constant with assigned value 0 act as false and the other ones as true, +therefore have the same behavior of a boolean" +-config=3DMC3R1.R14.4,etypes+=3D{deliberate, "stmt(child(cond,child(expr,r= ef(^?::is_dying$))))","src_type(enum)"} +-doc_end + # # Series 20. # diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst index 6e7c4f25b8..eda3c8100c 100644 --- a/docs/misra/deviations.rst +++ b/docs/misra/deviations.rst @@ -270,6 +270,12 @@ Deviations related to MISRA C:2012 Rules: statements are deliberate. - Project-wide deviation; tagged as `disapplied` for ECLAIR. =20 + * - R14.4 + - The XEN team relies on the fact that the enum is_dying has the + constant with assigned value 0 act as false and the other ones as t= rue, + therefore have the same behavior of a boolean. + - Project-wide deviation; tagged as `deliberate` for ECLAIR. + * - R20.7 - Code violating Rule 20.7 is safe when macro parameters are used: (1) as function arguments; --=20 2.40.0