From nobody Mon May 13 09:15:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1691567758868502.4288291506746; Wed, 9 Aug 2023 00:55:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.580726.909127 (Exim 4.92) (envelope-from ) id 1qTe2Y-00080J-57; Wed, 09 Aug 2023 07:55:34 +0000 Received: by outflank-mailman (output) from mailman id 580726.909127; Wed, 09 Aug 2023 07:55:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2Y-00080C-2O; Wed, 09 Aug 2023 07:55:34 +0000 Received: by outflank-mailman (input) for mailman id 580726; Wed, 09 Aug 2023 07:55:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2W-0007py-Fv for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 07:55:32 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c34454b-368a-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 09:55:30 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 77E3C4EE0741; Wed, 9 Aug 2023 09:55:29 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c34454b-368a-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 Date: Wed, 9 Aug 2023 09:55:08 +0200 Message-Id: <37bb5dc6f323bd2dc250c519523d05b66d17fdee.1691567429.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1691567760285100005 Content-Type: text/plain; charset="utf-8" The local variables 'irq_desc' shadow the homonymous global variable, declared in 'xen/arch/x86/include/asm/irq.h', therefore they are renamed 'irqd' for consistency. Signed-off-by: Nicola Vetrini Reviewed-by: Jan Beulich --- xen/arch/x86/hvm/vmsi.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 3cd4923060..128f236362 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -462,7 +462,7 @@ static void del_msixtbl_entry(struct msixtbl_entry *ent= ry) =20 int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t gtab= le) { - struct irq_desc *irq_desc; + struct irq_desc *irqd; struct msi_desc *msi_desc; struct pci_dev *pdev; struct msixtbl_entry *entry, *new_entry; @@ -482,14 +482,14 @@ int msixtbl_pt_register(struct domain *d, struct pirq= *pirq, uint64_t gtable) if ( !new_entry ) return -ENOMEM; =20 - irq_desc =3D pirq_spin_lock_irq_desc(pirq, NULL); - if ( !irq_desc ) + irqd =3D pirq_spin_lock_irq_desc(pirq, NULL); + if ( !irqd ) { xfree(new_entry); return r; } =20 - msi_desc =3D irq_desc->msi_desc; + msi_desc =3D irqd->msi_desc; if ( !msi_desc ) goto out; =20 @@ -508,7 +508,7 @@ found: r =3D 0; =20 out: - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); xfree(new_entry); =20 if ( !r ) @@ -533,7 +533,7 @@ out: =20 void msixtbl_pt_unregister(struct domain *d, struct pirq *pirq) { - struct irq_desc *irq_desc; + struct irq_desc *irqd; struct msi_desc *msi_desc; struct pci_dev *pdev; struct msixtbl_entry *entry; @@ -544,11 +544,11 @@ void msixtbl_pt_unregister(struct domain *d, struct p= irq *pirq) if ( !msixtbl_initialised(d) ) return; =20 - irq_desc =3D pirq_spin_lock_irq_desc(pirq, NULL); - if ( !irq_desc ) + irqd =3D pirq_spin_lock_irq_desc(pirq, NULL); + if ( !irqd ) return; =20 - msi_desc =3D irq_desc->msi_desc; + msi_desc =3D irqd->msi_desc; if ( !msi_desc ) goto out; =20 @@ -559,14 +559,14 @@ void msixtbl_pt_unregister(struct domain *d, struct p= irq *pirq) goto found; =20 out: - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); return; =20 found: if ( !atomic_dec_and_test(&entry->refcnt) ) del_msixtbl_entry(entry); =20 - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); } =20 void msixtbl_init(struct domain *d) --=20 2.34.1 From nobody Mon May 13 09:15:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1691567756018306.11768648573684; Wed, 9 Aug 2023 00:55:56 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.580727.909132 (Exim 4.92) (envelope-from ) id 1qTe2Y-00083C-Dg; Wed, 09 Aug 2023 07:55:34 +0000 Received: by outflank-mailman (output) from mailman id 580727.909132; Wed, 09 Aug 2023 07:55:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2Y-000822-8s; Wed, 09 Aug 2023 07:55:34 +0000 Received: by outflank-mailman (input) for mailman id 580727; Wed, 09 Aug 2023 07:55:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2X-0007py-5M for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 07:55:33 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ca55bb2-368a-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 09:55:31 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 2F0374EE0740; Wed, 9 Aug 2023 09:55:30 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ca55bb2-368a-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 2/2] xen/delay: address MISRA C:2012 Rule 5.3. Date: Wed, 9 Aug 2023 09:55:09 +0200 Message-Id: <47e2c8770e38ab064cbcdfaafa8467c5e733f11d.1691567429.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1691567758239100003 Content-Type: text/plain; charset="utf-8" The variable 'msec' declared in the macro shadows the local variable in 'ehci_dbgp_bios_handoff', but to prevent any future clashes with other functions the macro is converted to a static inline function. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Julien Grall --- xen/include/xen/delay.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h index 9d70ef035f..9150226271 100644 --- a/xen/include/xen/delay.h +++ b/xen/include/xen/delay.h @@ -4,7 +4,11 @@ /* Copyright (C) 1993 Linus Torvalds */ =20 #include -#define mdelay(n) (\ - {unsigned long msec=3D(n); while (msec--) udelay(1000);}) + +static inline void mdelay(unsigned long msec) +{ + while ( msec-- ) + udelay(1000); +} =20 #endif /* defined(_LINUX_DELAY_H) */ --=20 2.34.1