[PATCH v1 0/7] tools/ocaml code and build cleanups

Edwin Török posted 7 patches 1 year, 8 months ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/cover.1659116941.git.edvin.torok@citrix.com
Makefile                                      |  5 ++
tools/.gitignore                              |  7 ++
tools/configure                               |  4 +-
tools/configure.ac                            |  2 +
tools/dune                                    |  5 ++
tools/dune-project                            |  1 +
tools/ocaml/Makefile.dune                     | 88 +++++++++++++++++++
tools/ocaml/Makefile.rules                    |  2 +
tools/ocaml/dune-project                      | 27 ++++++
tools/ocaml/dune-workspace.dev.in             |  2 +
tools/ocaml/dune-workspace.in                 | 18 ++++
tools/ocaml/libs/eventchn/dune                | 11 +++
tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++-
tools/ocaml/libs/mmap/dune                    |  9 ++
tools/ocaml/libs/xb/dune                      | 10 +++
tools/ocaml/libs/xb/xb.ml                     |  3 +
tools/ocaml/libs/xb/xb.mli                    |  9 +-
tools/ocaml/libs/xc/dune                      | 16 ++++
tools/ocaml/libs/xs/Makefile                  |  5 --
tools/ocaml/libs/xs/dune                      | 15 ++++
tools/ocaml/libs/xs/paths.ml.in               |  1 +
tools/ocaml/xenstored/Makefile                |  5 --
tools/ocaml/xenstored/connection.ml           | 10 +--
tools/ocaml/xenstored/dune                    | 51 +++++++++++
tools/ocaml/xenstored/paths.ml.in             |  4 +
tools/ocaml/xenstored/process.ml              |  5 +-
26 files changed, 315 insertions(+), 29 deletions(-)
create mode 100644 tools/.gitignore
create mode 100644 tools/dune
create mode 100644 tools/dune-project
create mode 100644 tools/ocaml/Makefile.dune
create mode 100644 tools/ocaml/dune-project
create mode 100644 tools/ocaml/dune-workspace.dev.in
create mode 100644 tools/ocaml/dune-workspace.in
create mode 100644 tools/ocaml/libs/eventchn/dune
create mode 100644 tools/ocaml/libs/mmap/dune
create mode 100644 tools/ocaml/libs/xb/dune
create mode 100644 tools/ocaml/libs/xc/dune
create mode 100644 tools/ocaml/libs/xs/dune
create mode 100644 tools/ocaml/libs/xs/paths.ml.in
create mode 100644 tools/ocaml/xenstored/dune
create mode 100644 tools/ocaml/xenstored/paths.ml.in
[PATCH v1 0/7] tools/ocaml code and build cleanups
Posted by Edwin Török 1 year, 8 months ago
Various OCaml code cleanups to make building and working on Oxenstored easier,
including compatibility with newer language versions.
This does not yet change the minimum version of OCaml.

A version of this series in a git repository is publicly available at:
https://github.com/edwintorok/xen.git
https://github.com/edwintorok/xen/compare/private/edvint/public?expand=1

Edwin Török (7):
  tools/ocaml/Makefile: do not run ocamldep during make clean
  tools/ocaml/*/Makefile: generate paths.ml from configure
  tools/ocaml/*/dune: dune based build system
  tools/ocaml: Makefile to drive dune
  tools/ocaml: fix compiler warnings
  tools/ocaml/libs/xb: hide type of Xb.t
  tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0
    compat

 Makefile                                      |  5 ++
 tools/.gitignore                              |  7 ++
 tools/configure                               |  4 +-
 tools/configure.ac                            |  2 +
 tools/dune                                    |  5 ++
 tools/dune-project                            |  1 +
 tools/ocaml/Makefile.dune                     | 88 +++++++++++++++++++
 tools/ocaml/Makefile.rules                    |  2 +
 tools/ocaml/dune-project                      | 27 ++++++
 tools/ocaml/dune-workspace.dev.in             |  2 +
 tools/ocaml/dune-workspace.in                 | 18 ++++
 tools/ocaml/libs/eventchn/dune                | 11 +++
 tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++-
 tools/ocaml/libs/mmap/dune                    |  9 ++
 tools/ocaml/libs/xb/dune                      | 10 +++
 tools/ocaml/libs/xb/xb.ml                     |  3 +
 tools/ocaml/libs/xb/xb.mli                    |  9 +-
 tools/ocaml/libs/xc/dune                      | 16 ++++
 tools/ocaml/libs/xs/Makefile                  |  5 --
 tools/ocaml/libs/xs/dune                      | 15 ++++
 tools/ocaml/libs/xs/paths.ml.in               |  1 +
 tools/ocaml/xenstored/Makefile                |  5 --
 tools/ocaml/xenstored/connection.ml           | 10 +--
 tools/ocaml/xenstored/dune                    | 51 +++++++++++
 tools/ocaml/xenstored/paths.ml.in             |  4 +
 tools/ocaml/xenstored/process.ml              |  5 +-
 26 files changed, 315 insertions(+), 29 deletions(-)
 create mode 100644 tools/.gitignore
 create mode 100644 tools/dune
 create mode 100644 tools/dune-project
 create mode 100644 tools/ocaml/Makefile.dune
 create mode 100644 tools/ocaml/dune-project
 create mode 100644 tools/ocaml/dune-workspace.dev.in
 create mode 100644 tools/ocaml/dune-workspace.in
 create mode 100644 tools/ocaml/libs/eventchn/dune
 create mode 100644 tools/ocaml/libs/mmap/dune
 create mode 100644 tools/ocaml/libs/xb/dune
 create mode 100644 tools/ocaml/libs/xc/dune
 create mode 100644 tools/ocaml/libs/xs/dune
 create mode 100644 tools/ocaml/libs/xs/paths.ml.in
 create mode 100644 tools/ocaml/xenstored/dune
 create mode 100644 tools/ocaml/xenstored/paths.ml.in

-- 
2.34.1


Re: [PATCH v1 0/7] tools/ocaml code and build cleanups
Posted by Christian Lindig 1 year, 7 months ago

On 29 Jul 2022, at 18:53, Edwin Török <edvin.torok@citrix.com<mailto:edvin.torok@citrix.com>> wrote:

Various OCaml code cleanups to make building and working on Oxenstored easier,
including compatibility with newer language versions.
This does not yet change the minimum version of OCaml.

A version of this series in a git repository is publicly available at:
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fedwintorok%2Fxen.git&amp;data=05%7C01%7Cchristian.lindig%40citrix.com%7C0e39bbb48174454226b008da718b57ff%7C335836de42ef43a2b145348c2ee9ca5b%7C0%7C0%7C637947140547020875%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=KsQgF0l%2FDzSxyIkvG7t15wGfHtNlG5VMJuinI5eZ4AM%3D&amp;reserved=0
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fedwintorok%2Fxen%2Fcompare%2Fprivate%2Fedvint%2Fpublic%3Fexpand%3D1&amp;data=05%7C01%7Cchristian.lindig%40citrix.com%7C0e39bbb48174454226b008da718b57ff%7C335836de42ef43a2b145348c2ee9ca5b%7C0%7C0%7C637947140547020875%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=sHJfI4P4aUSdUVFpbo3NNzkdfzOgXejRSI%2FNicHQ750%3D&amp;reserved=0

Edwin Török (7):
tools/ocaml/Makefile: do not run ocamldep during make clean
tools/ocaml/*/Makefile: generate paths.ml from configure
tools/ocaml/*/dune: dune based build system
tools/ocaml: Makefile to drive dune
tools/ocaml: fix compiler warnings
tools/ocaml/libs/xb: hide type of Xb.t
tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0
compat

Makefile | 5 ++
tools/.gitignore | 7 ++
tools/configure | 4 +-
tools/configure.ac | 2 +
tools/dune | 5 ++
tools/dune-project | 1 +
tools/ocaml/Makefile.dune | 88 +++++++++++++++++++
tools/ocaml/Makefile.rules | 2 +
tools/ocaml/dune-project | 27 ++++++
tools/ocaml/dune-workspace.dev.in | 2 +
tools/ocaml/dune-workspace.in | 18 ++++
tools/ocaml/libs/eventchn/dune | 11 +++
tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++-
tools/ocaml/libs/mmap/dune | 9 ++
tools/ocaml/libs/xb/dune | 10 +++
tools/ocaml/libs/xb/xb.ml | 3 +
tools/ocaml/libs/xb/xb.mli | 9 +-
tools/ocaml/libs/xc/dune | 16 ++++
tools/ocaml/libs/xs/Makefile | 5 --
tools/ocaml/libs/xs/dune | 15 ++++
tools/ocaml/libs/xs/paths.ml.in | 1 +
tools/ocaml/xenstored/Makefile | 5 --
tools/ocaml/xenstored/connection.ml | 10 +--
tools/ocaml/xenstored/dune | 51 +++++++++++
tools/ocaml/xenstored/paths.ml.in | 4 +
tools/ocaml/xenstored/process.ml | 5 +-
26 files changed, 315 insertions(+), 29 deletions(-)
create mode 100644 tools/.gitignore
create mode 100644 tools/dune
create mode 100644 tools/dune-project
create mode 100644 tools/ocaml/Makefile.dune
create mode 100644 tools/ocaml/dune-project
create mode 100644 tools/ocaml/dune-workspace.dev.in
create mode 100644 tools/ocaml/dune-workspace.in
create mode 100644 tools/ocaml/libs/eventchn/dune
create mode 100644 tools/ocaml/libs/mmap/dune
create mode 100644 tools/ocaml/libs/xb/dune
create mode 100644 tools/ocaml/libs/xc/dune
create mode 100644 tools/ocaml/libs/xs/dune
create mode 100644 tools/ocaml/libs/xs/paths.ml.in
create mode 100644 tools/ocaml/xenstored/dune
create mode 100644 tools/ocaml/xenstored/paths.ml.in

Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.lindig@citrix.com>>