From nobody Wed Apr 24 01:53:15 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1570630885; cv=none; d=zoho.com; s=zohoarc; b=b9H4yUE050n/TpIBrg8UhoFNYaXKC+LJ/WbkMDyFdnl5+rt9nm2hK7xyNsHO0zZM9otM+Exq7TV9LOJSQ7AQI8dobVqbB0aZ4UgO64H+yg9VWv1hW7jbYVpuuqAsAQWnU21NqOi18ykbwttRFl4t/3KTC3Pf3ASNCP3z8YP1qCs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570630885; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CxW2uIcZbFhxu4dXNNK2E4eSqKWUu8w4DUBAHhNDehk=; b=VqCVVNxW80A0ljp8POjD7W0+ceaX4Gz/8Ib8G2ycxEk60onYzB+OMu5FfTl4lRFcKuQnusA3A13PmIDN2aMk04dvSnnmr/LgtVaGy58CJtT+ea1aIvtDVeNgEb3Qrg3M7xTWNucQwc0uslV78kGNjdvQmwMwBl+JuPr8pQAvD/k= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1570630885122111.8405281434093; Wed, 9 Oct 2019 07:21:25 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iICpK-0007TR-98; Wed, 09 Oct 2019 14:20:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iICpI-0007TA-Mt for xen-devel@lists.xenproject.org; Wed, 09 Oct 2019 14:20:28 +0000 Received: from mail-lf1-x143.google.com (unknown [2a00:1450:4864:20::143]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eeb3f100-ea9f-11e9-80e3-bc764e2007e4; Wed, 09 Oct 2019 14:20:24 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id r2so1796909lfn.8 for ; Wed, 09 Oct 2019 07:20:24 -0700 (PDT) Received: from EPUAKYIW0594.kyiv.epam.com (ll-74.141.223.85.sovam.net.ua. [85.223.141.74]) by smtp.gmail.com with ESMTPSA id i142sm526702lfi.5.2019.10.09.07.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 07:20:22 -0700 (PDT) X-Inumbo-ID: eeb3f100-ea9f-11e9-80e3-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qM44EJGVuGB1UjO/9duOt6HnkcTEDzfeyY6UzBKj3FE=; b=Un/6iF44gxYHdhnvoIMFE7xhLweq4Cpqr1Ek6gMT4TXMQDA5J1MoKZvouf1Sq0/HGz /IJwiW4H9JY1+T1bkGhl7fROxutkVkgPg6ydStZIaKR7MjqI0RK17r12+CNEXQUu2Nsv tdGg6aNLKn+zuUi6UiIS/yQnhytQY4Gl8AiuXggph3NdgO0QBwYp0NbPxZYvmM2ALPQP LA7ey3tMkSinzLVOqF3ONZoGrB16VoqqW92pEy3ppteOZ2orE6UMcooTtweMo+UoAgN2 wBEpHIXATLYFcFDJc9da3ERxxrrOzgfqVHi3zJhi3WeviG8tCMBNE7jKi7aMTNJyE19L l5FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qM44EJGVuGB1UjO/9duOt6HnkcTEDzfeyY6UzBKj3FE=; b=URQf1KiAUa1Hq4buPpJgu6iAtuyMJ9e51evhkb4P66B6CcyXdqNjgr7AIlHpuBC104 G6YW7IAZCREwLxNoB5TjGxs4lFdQgK+m7/xQldO0NBfJ3nYewCVlKZeExfnWHWyl7jzG CvMV4GgNRLTBqwGxhhQ5qR/wTYvThKCh3ICf9vxKTO3NLhsnB+niOAi0mPMCFXgMa5uB neMRJnErFRN3k7ipXTDpq4tYAtFNp4L8pTEFeLXFJZUIbRLQkUEP89Szq0GtneXx6bXB vlH7rdl9XgNXuNxEWtL9zdngiJeLdmYUZWZBCqgykmCSJ5Y9teox1MPNBGL8VzJlrJH9 0t6w== X-Gm-Message-State: APjAAAULPv7eXuUSVF5/D98GCrzieaKicc5alvEsd59NmCPxOvH3bhPB n35c4ZLtKolp6sxd0WGspS5wzV1dSsY= X-Google-Smtp-Source: APXvYqwP4vcqw88gzfbBPZX491PzH/EzJJe0rsHT1fp0auFub5xYXGLjyjlPihaGIvHLdo4jBy7Vlw== X-Received: by 2002:ac2:5542:: with SMTP id l2mr2220612lfk.119.1570630822990; Wed, 09 Oct 2019 07:20:22 -0700 (PDT) From: Artem Mygaiev To: xen-devel@lists.xenproject.org Date: Wed, 9 Oct 2019 17:20:15 +0300 Message-Id: <5eec779f850fec88caeb67a090a25092792689ba.1570628924.git.artem_mygaiev@epam.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 1/3] Consistent use for lock variable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Artem Mygaiev , Daniel De Graaf , Artem Mygaiev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) ... for both lock and unlock Coverity-ID: 1381840 Signed-off-by: Artem Mygaiev Acked-by: Julien Grall --- xen/xsm/flask/avc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/xsm/flask/avc.c b/xen/xsm/flask/avc.c index 87ea38b7a0..3a9507f62a 100644 --- a/xen/xsm/flask/avc.c +++ b/xen/xsm/flask/avc.c @@ -320,7 +320,7 @@ static inline int avc_reclaim_node(void) head =3D &avc_cache.slots[hvalue]; lock =3D &avc_cache.slots_lock[hvalue]; =20 - spin_lock_irqsave(&avc_cache.slots_lock[hvalue], flags); + spin_lock_irqsave(lock, flags); rcu_read_lock(&avc_rcu_lock); hlist_for_each_entry(node, next, head, list) { --=20 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Wed Apr 24 01:53:15 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1570630890; cv=none; d=zoho.com; s=zohoarc; b=EMZOSz9Hgyo1BoKFIxbbEsyG2ymffy+W+suRQ/lpnTcM7/edu9BBgkUGv7Fj0bBx0pzCzs4QuVLAca20ODjKbLp7cO8JFnko/1x/bugme0FhqY3fAhWiathYY481FnI5z9CymykpDffOEKOyLRbBaC1QY5JP9YFMynud8dnvWZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570630890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h2RiSx2Iiw+wqcNrwZ6XRH3tFhPkOdfYRjrgtw35H18=; b=jrGzKKzvixxZ4wHpMWnHZop0BzsPdh2BnUCsD5Bc0QLke2xegHKLme62BYTQsX8/q5aCosK6vDURSpJ/LMg7OrxrTrsAMJZsUzuj23tswLgclZZK0Jaci3jNxUz0voTn1Wr4E0qyrwWmInilJuOTdgmVHmCWwx/OJ2+CHnObHl4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1570630890099585.0000716437316; Wed, 9 Oct 2019 07:21:30 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iICpP-0007V5-J3; Wed, 09 Oct 2019 14:20:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iICpN-0007US-Ml for xen-devel@lists.xenproject.org; Wed, 09 Oct 2019 14:20:33 +0000 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id efd55e20-ea9f-11e9-80e3-bc764e2007e4; Wed, 09 Oct 2019 14:20:26 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id f5so2680728ljg.8 for ; Wed, 09 Oct 2019 07:20:26 -0700 (PDT) Received: from EPUAKYIW0594.kyiv.epam.com (ll-74.141.223.85.sovam.net.ua. [85.223.141.74]) by smtp.gmail.com with ESMTPSA id i142sm526702lfi.5.2019.10.09.07.20.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 07:20:23 -0700 (PDT) X-Inumbo-ID: efd55e20-ea9f-11e9-80e3-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ymknUH33Rb304RHiPhugySmwwZfHcvQEz4Gc9cR3kzs=; b=TyEkZZc7KLZ7vLnhxPb7d3+md3FwkBDIr070bOPKHI2BKuBvsRzjX6JmcwiV2YjXvr pCFNz+SAtNm8ueOyMenJRz4FnKKbWTOvj3/10pdX0ZrycNIfSs2DJjNBAve7h+bdgvx5 kMdmOmB9N9DNBQg5gjEf65/qI0eDy0hDmChG61BhIbhvaKHfm/Qfn11WIhiJtoMkvt6F VC2tCTEaIwH+wQobhWasI54GfMxXApBu5hJbRJ9UsBoOB8X8h7SyNGbRk5thGJHgcAoG jKBPnpxlSlsQnfjVw+bo1Xo4I47wgtauNUbihXffnHK57b+UzkHv+jv1db+tvd8m7Esi aJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ymknUH33Rb304RHiPhugySmwwZfHcvQEz4Gc9cR3kzs=; b=YJncX4kEO2hwwPIMCef5yW6XqXiKXNdNE86hPYj2oG85wvShiyiYhiVoZEUZBe6G5w kAEAZtI6xvhcCGOEJeyHIW7fvGPjUEQDH5uHiaEchc7tUu1CE8Jm+7qxCwC8b+QxG0Db uBcQ285tygPLAO4waV3UUQwbMngEIQlaJF3de7sgtA794++zktKRz3TAY5xfXFgbd2zc HQI/v0Ej+h2jvg+SLPkpr5kAOFiX4BU4LiFn7iDB3Cgz7Q2LS/6e37wRWv7Ly6u3/G2w mdf3Q8I76NPXbG8Oehr3xV0O62jW8A/aNIcPkJjiR9kW6PlQph9d1Dm6vbDv3qj2Mx2s paOg== X-Gm-Message-State: APjAAAVGTS3i7SpYbHOuNO6sXDMocXfmjSZ82TsJs6BZ9gWXYd3FjXpn tztAs2wOFpLRRAwa8VhokEgdoXCVcca5VQ== X-Google-Smtp-Source: APXvYqx3EwmXWBXQ7J7TctRrteRPwO0+dyyFwa7GuYX/5e1+IdEI9Q+GyjO9T0rIfkBgXM9QrUkmyA== X-Received: by 2002:a2e:9759:: with SMTP id f25mr2560650ljj.173.1570630824242; Wed, 09 Oct 2019 07:20:24 -0700 (PDT) From: Artem Mygaiev To: xen-devel@lists.xenproject.org Date: Wed, 9 Oct 2019 17:20:16 +0300 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/3] Remove useless ASSERT condition X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Artem Mygaiev , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Artem Mygaiev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) cnt is unsigned, so always >=3D0 Coverity-ID: 1381848 Signed-off-by: Artem Mygaiev Acked-by: Julien Grall --- xen/drivers/char/scif-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c index fa0b8274ca..9d3f66b55b 100644 --- a/xen/drivers/char/scif-uart.c +++ b/xen/drivers/char/scif-uart.c @@ -205,7 +205,7 @@ static int scif_uart_tx_ready(struct serial_port *port) =20 /* Check number of data bytes stored in TX FIFO */ cnt =3D scif_readw(uart, SCIF_SCFDR) >> 8; - ASSERT( cnt >=3D 0 && cnt <=3D params->fifo_size ); + ASSERT( cnt <=3D params->fifo_size ); =20 return (params->fifo_size - cnt); } --=20 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Wed Apr 24 01:53:15 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1570630895; cv=none; d=zoho.com; s=zohoarc; b=HR4twBTPv5sEAaPtA9uyvQt+DHJXZ+65Z8+Vyq8IBhzIZZmtMKAE93w3j34URV8j8Oc0OLx/aKqu2d3xE3RJ0dmg/xTDByqEK3RPT8c57ypXu3hCUsIxcQCTSPatUb8HIaEEN2Cuvceu+m8H/BV9dSZQDq/ABwgKiyoYFnol6i4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570630895; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ryUw4N/FOwczyrzSihWCNmqFkJEWROG8EiRfW0aPWG4=; b=MPhrmYzLUeMXGRvWA97XYAmLnEZVFXoBtMZKvQa8amQyGoMcC3Jw78aDn1A+RB4wUgukkHLW5lJnTFXE+vqsHZBr02H6euL6OMaADSDxpqZ/mMwTi7LEUuGYr5iMVhpn5HdhzzHucfwhaVAODBzu1X7ckXEPlm/Yv35VsBdJf/4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1570630895599155.7122123516757; Wed, 9 Oct 2019 07:21:35 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iICpT-0007Wt-UE; Wed, 09 Oct 2019 14:20:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iICpS-0007WQ-ML for xen-devel@lists.xenproject.org; Wed, 09 Oct 2019 14:20:38 +0000 Received: from mail-lj1-x244.google.com (unknown [2a00:1450:4864:20::244]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f043e430-ea9f-11e9-8c93-bc764e2007e4; Wed, 09 Oct 2019 14:20:27 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id q64so2659684ljb.12 for ; Wed, 09 Oct 2019 07:20:26 -0700 (PDT) Received: from EPUAKYIW0594.kyiv.epam.com (ll-74.141.223.85.sovam.net.ua. [85.223.141.74]) by smtp.gmail.com with ESMTPSA id i142sm526702lfi.5.2019.10.09.07.20.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 07:20:24 -0700 (PDT) X-Inumbo-ID: f043e430-ea9f-11e9-8c93-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xGgtXiJIJl4Hr2B92YhsDwNUlTE+vt8BHFmgy66Qd2w=; b=D2q4aFYgkIf+3Gspn7QlwYzwEFtdtDUdHpoOapmursuo1fZZn7Ovbv0l504uxncVkp eQMuRsxgrqxeQAcC41YJ0SPpxQnyC5ndtoDsTqWX/eunb7yplfGGTdLmHKI3rBMz2/P3 bcPKdkk58E50z+zUwpxRDHoJVaPJFS1UeqlT5v5wV9sgtQFsGI/hPj5jPr9h3HWU/pUS AlZA/uENeUPlUIssy2R+B6nTiw0oH8lGnhog88DLvNIWXO3OEOHBmLKgQKQQXY2bs6+Y vzKkEbog0H7pmSb7TgtG/w9y4JQEtwAU+oq9NE5XBgeqX5hMXDh3/vKjO5AWIbyDNfi/ TG3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xGgtXiJIJl4Hr2B92YhsDwNUlTE+vt8BHFmgy66Qd2w=; b=GN1arMG1GdplhljANJCHbG9mJuZ9UPuhqI8nlk9XZvJdeUrAexZvBksJ8Jr5yV3Vwv S3OkMIiDyBZ3yVtbpq/hVBUvTz/R32WdG/JXwO8XFOdfFTcnTnbjRsnslTmAb6ShM1cy ZWCxccxBhmmTaS5j6nOy1kEnIX6jFO7ej9VdurcRbwxZwsrRqvTRmVOyzPailkQ2YVz6 I0iugfkN3NmSjNTbhFxWszF6+PTl/5CHupAvg9A0RCWEyeUSEyxeqczba4jlka7SNjZL vWU+7c/P4+u5SQnZxNAfCKem+zFVrSHafhGjq40JBxHumPwaZTj4jWb2On9htGbDpmL+ 5zuQ== X-Gm-Message-State: APjAAAXpY+tr3EalW3iGh2FqNUqI0FkFk1q8tvCIAEAb5y8+B35YWyVi e33C8Cx42ylDKWx14Z92etwELZs9OFP2nQ== X-Google-Smtp-Source: APXvYqwjwHCxuDo9hL6xLBnAdVT7U5XmSy9bDqSX9ttaKDnAxl8Mt8Ux+n0rV+MonN5FdTcByjTt0A== X-Received: by 2002:a2e:9117:: with SMTP id m23mr2566135ljg.82.1570630825577; Wed, 09 Oct 2019 07:20:25 -0700 (PDT) From: Artem Mygaiev To: xen-devel@lists.xenproject.org Date: Wed, 9 Oct 2019 17:20:17 +0300 Message-Id: <6575cd1b9c82f5b28cd29d78308dc23821c9d246.1570628924.git.artem_mygaiev@epam.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 3/3] Free allocated resource on error X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Artem Mygaiev , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Artem Mygaiev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Also do not set mark device as SMMU protected when there are no more SMMU resources left Coverity-ID: 1381862 Signed-off-by: Artem Mygaiev --- xen/drivers/passthrough/arm/smmu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/a= rm/smmu.c index f151b9f5b5..cf42335eed 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -804,9 +804,6 @@ static int register_smmu_master(struct arm_smmu_device = *smmu, master->of_node =3D masterspec->np; master->cfg.num_streamids =3D masterspec->args_count; =20 - /* Xen: Let Xen know that the device is protected by an SMMU */ - dt_device_set_protected(masterspec->np); - for (i =3D 0; i < master->cfg.num_streamids; ++i) { u16 streamid =3D masterspec->args[i]; =20 @@ -815,10 +812,15 @@ static int register_smmu_master(struct arm_smmu_devic= e *smmu, dev_err(dev, "stream ID for master device %s greater than maximum allowed (%d)\n", masterspec->np->name, smmu->num_mapping_groups); + devm_free(master); return -ERANGE; } master->cfg.streamids[i] =3D streamid; } + + /* Xen: Let Xen know that the device is protected by an SMMU */ + dt_device_set_protected(masterspec->np); + return insert_smmu_master(smmu, master); } =20 --=20 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel