From nobody Thu May 2 17:47:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1618837343; cv=none; d=zohomail.com; s=zohoarc; b=hV4+8BvXT1HHENUPXTcw6etaNbkg8nwWngvwWUvu0Mjnz3y3IUWLfuiyvRmQCYFOK0J5Y4V+0D+bzo+29pdYU/CctR1qu/m+9IeM7goySxHVXwvNqoHtXCK9Wp3TjXaCWJh+T3KzQU9eZXEg5h2KzdQfL33eZRJQoAD684okQnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618837343; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=FX7yWde6o2yjVWFfT/4Uu78sqzuk0RAh3AypdKq1pls=; b=DbpsymABX6WQQqZW16YQ7JDXvKEniICUDoZThAB7ODQiTFQBkkUasbUWbIMKEGG2qibxVWspMRd1RkENBv3nDWanocVN22cjpPCG9RTwYGM+PpMauNse1pIMmKrlkgka6TBNrFc+vLlKlSw8nTF0zMxZ4/dGlQGaqd9ld+BEi8c= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618837342586186.36621980405448; Mon, 19 Apr 2021 06:02:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.112900.215231 (Exim 4.92) (envelope-from ) id 1lYTXH-0000Kz-0i; Mon, 19 Apr 2021 13:01:55 +0000 Received: by outflank-mailman (output) from mailman id 112900.215231; Mon, 19 Apr 2021 13:01:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYTXG-0000Ks-TW; Mon, 19 Apr 2021 13:01:54 +0000 Received: by outflank-mailman (input) for mailman id 112900; Mon, 19 Apr 2021 13:01:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYTXF-0000Kj-TS for xen-devel@lists.xenproject.org; Mon, 19 Apr 2021 13:01:53 +0000 Received: from mx.upb.ro (unknown [141.85.13.200]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 50124ff3-ad54-47c9-9f1c-e51125f8ae7e; Mon, 19 Apr 2021 13:01:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mx.upb.ro (Postfix) with ESMTP id C6E48B560053; Mon, 19 Apr 2021 16:01:50 +0300 (EEST) Received: from mx.upb.ro ([127.0.0.1]) by localhost (mx.upb.ro [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GJZW3Ua5WQdA; Mon, 19 Apr 2021 16:01:48 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by mx.upb.ro (Postfix) with ESMTP id CF696B5600AE; Mon, 19 Apr 2021 16:01:48 +0300 (EEST) Received: from mx.upb.ro ([127.0.0.1]) by localhost (mx.upb.ro [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QFE4my-dm-kM; Mon, 19 Apr 2021 16:01:48 +0300 (EEST) Received: from localhost.localdomain (unknown [188.25.174.245]) by mx.upb.ro (Postfix) with ESMTPSA id 6FD45B560053; Mon, 19 Apr 2021 16:01:48 +0300 (EEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50124ff3-ad54-47c9-9f1c-e51125f8ae7e X-Virus-Scanned: amavisd-new at upb.ro From: Costin Lupu To: xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH] tools/libs/light: Remove unnecessary libxl_list_vm() call Date: Mon, 19 Apr 2021 16:01:42 +0300 Message-Id: X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The removed lines were initially added by commit 314e64084d31, but the subsequent code which was using the nb_vm variable was later removed by commit 2ba368d13893, which makes these lines of code an overlooked reminiscence. Moreover, the call becomes very expensive when there is a considerable number of VMs (~1000 instances) running on the host. Signed-off-by: Costin Lupu Acked-by: Wei Liu --- tools/libs/light/libxl_create.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_creat= e.c index 0c64268f66..43e9ba9c63 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -578,7 +578,7 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_conf= ig *d_config, uint32_t *domid, bool soft_reset) { libxl_ctx *ctx =3D libxl__gc_owner(gc); - int ret, rc, nb_vm; + int ret, rc; const char *dom_type; char *uuid_string; char *dom_path, *vm_path, *libxl_path; @@ -586,7 +586,6 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_conf= ig *d_config, struct xs_permissions rwperm[1]; struct xs_permissions noperm[1]; xs_transaction_t t =3D 0; - libxl_vminfo *vm_list; =20 /* convenience aliases */ libxl_domain_create_info *info =3D &d_config->c_info; @@ -869,14 +868,6 @@ retry_transaction: ARRAY_SIZE(rwperm)); } =20 - vm_list =3D libxl_list_vm(ctx, &nb_vm); - if (!vm_list) { - LOGD(ERROR, *domid, "cannot get number of running guests"); - rc =3D ERROR_FAIL; - goto out; - } - libxl_vminfo_list_free(vm_list, nb_vm); - xs_write(ctx->xsh, t, GCSPRINTF("%s/uuid", vm_path), uuid_string, strl= en(uuid_string)); xs_write(ctx->xsh, t, GCSPRINTF("%s/name", vm_path), info->name, strle= n(info->name)); =20 --=20 2.20.1