From nobody Fri May 17 13:26:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1632921229; cv=pass; d=zohomail.com; s=zohoarc; b=T+L8+4twcxfsuIpBOVKaPKpxe30+pcsOFs6tNkTjD4ITN3+PYDitvYalBgRk8dOI/sD3Hu6BLgx9HUDpcrd87k0p50izp50P3WT+6garXGsYy+ZROj6sCByQMY3FOVq8ze9bTtNFVRklPqkarlgY4wnFSuckCNmtHR8QN9ov6Bg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632921229; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=K8riSR7WaBkT+h9mazx+moSRxeE0eWzN0eTXIGip8o4=; b=XKY1ConNz4HKm1GK6+yyiilV9UzZ2GlB3do0MWLu+XAUYMY7lU7RdlUlUiamCrtisiT3HL+pgZoZJr/xjxfAPh6dWvvKGJ/FU1fL+WemyrkxjqrxmcKVtLag09Wbf12b5doH59MxQ/xGm92uwQI/PnTvjAGanaVd1Yar1LnhjEQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1632921229507819.0858779764109; Wed, 29 Sep 2021 06:13:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.199068.352894 (Exim 4.92) (envelope-from ) id 1mVZOt-0000Fm-Fu; Wed, 29 Sep 2021 13:13:31 +0000 Received: by outflank-mailman (output) from mailman id 199068.352894; Wed, 29 Sep 2021 13:13:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZOt-0000Ff-Cm; Wed, 29 Sep 2021 13:13:31 +0000 Received: by outflank-mailman (input) for mailman id 199068; Wed, 29 Sep 2021 13:13:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZOs-0000FX-3a for xen-devel@lists.xenproject.org; Wed, 29 Sep 2021 13:13:30 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 555b93f5-22d5-4a13-a4b9-60bd8575a494; Wed, 29 Sep 2021 13:13:29 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-39-ZXZ70dRTNBqTnbNPCsaFTw-1; Wed, 29 Sep 2021 15:13:26 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Wed, 29 Sep 2021 13:13:26 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Wed, 29 Sep 2021 13:13:25 +0000 Received: from [10.156.60.236] (37.24.206.209) by AS8PR04CA0094.eurprd04.prod.outlook.com (2603:10a6:20b:31e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Wed, 29 Sep 2021 13:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 555b93f5-22d5-4a13-a4b9-60bd8575a494 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1632921208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8riSR7WaBkT+h9mazx+moSRxeE0eWzN0eTXIGip8o4=; b=eIG2E56kxFd1N8jEN00fltlinortw/dCKUW2ECpVy8AcT2ruVnsyEXqs7PM4uenOrhA+Mg 8YtJ+En5P3E8VoSzwSgKkWY+bvge+KWxH7ZRotEcnwsIA6oXoAgb4oGMA6sli5JzdSqQC2 RQ65fjEnTZywzduF9pSCcP+x24d9el4= X-MC-Unique: ZXZ70dRTNBqTnbNPCsaFTw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fW7nLgIeU3yeeIdJ7tE9Neir+vYLBsKSxsSDUYI8hIhg2wgojB0uXfLF1gJW1NArR80ZBwNlJ5A1zM1hbwRyo2i8ka0wOMkoHI9JzcNqEMmyAi/kAMioV6WJeM+bFRtFt1hl3BwFsyEyOeNcUq0n7U/NlPDJmDibiuHUARR9aVP5ACNvNuWQxJFOT3wUNplXOIjwYQV0v5uC+ozGnL3lVugffchRA66/5wSnLmUqaTyB5RKTXv4SYt6dmYuwQ6SFTU64be1SXJ2BHPVTKTXV93Q8gyQKtwH147+PC+lhsBPUFyB+y4XPfofdzmXNz/QRQFFLZJix9ZlOsrU9YxlZrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=K8riSR7WaBkT+h9mazx+moSRxeE0eWzN0eTXIGip8o4=; b=CZLJkZGrUrGUA7F0b4tN8oglObcB+ep+pphNA8ICHT7E5JbUGr+ZvolYTVaIVhqf2I+UcPMy2USGRGk1Dn1FjHTu1JWZfsVhgh8EJOeHApKz2wHdrEifCpacwL/prV8WbVQfDs7LdCJvCarA9sJLgQFkd10fnevHBO4EO/z9WAICRh/CJn+fcPrCJ/H+AuIa4pj9voTGTSfw47dlKj0apkkeO90nYq9sDugLPdTttRGfjyFmh6cvPKxUXchmtMesoTXLkD4z+w71Pt4lhkWTZdnvuk691q0EDa2VqivS4dtszccgSmoVqrs40b3k0JjGuVkCsmdpX51IaiZHrt9pUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v4 1/6] x86/PVH: improve Dom0 memory size calculation From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <4684f314-2c4e-f662-bd4e-132be001da9e@suse.com> Date: Wed, 29 Sep 2021 15:13:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0094.eurprd04.prod.outlook.com (2603:10a6:20b:31e::9) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2aa6dc84-7f8a-4ca5-997c-08d9834aebe9 X-MS-TrafficTypeDiagnostic: VI1PR04MB4352: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EVJM8OMEARLRE00bSES6mAfvXvn1lYwUhwYQwIsvfhBLyL25Gr/TjnpAW+XqrS+2im+co2XJZG4POspn9Ly5RDzf6cXh8KJd354nhQO1W+zemsAebmkjRWaGf2+W2Qc8wyKw/024+XSbZWQJ+hkE6nCn+53bCkHhFN3DSPkdl862mGUxMG/fbZfL0zRHOiAtD+DBQ8g+7f3+FrKUr7em5j3S/wtwZXiRI7ues79YjA+hBrqGjDaE9+UMYwexzoNVpDGcYXjE73GWCc9MwbjvNql9H0gia+GioZw4agzdsdmaw1aIqLy5/FxubNjN5Mhbb2gx5f4qFRBzLdM/wEg+jjlA2CMw5H+oQqXee4sRGbmtV07ULDzvjh6mCy/yIgJZB4rPb7WEjj2OiY9QigdluOjTGObk4wGC5+Z4wC9ooquBTE8X6GBKC8hC5XeW4sWEyg7hivezQCywCal+gZ92IaHHXk7PmZta4Aeikee/WgIGtSYrBRyObiCOSqUFgOHbOpM4Dxc1K7A6hLQLlcyUPfyELgQRSFRKvkML1nMwTZ0alJw9JeUClnPly8H+Q7wzGZSayDPIlN5XP037W30H7p3bUO/U8XT9mC5SPGQCV2n+jmFvToY8oiAZIK5H3Xb12gnlfp9kG7LZmuqzzXqYMJYGAQghhIICpK3/RBl2NY0dfRNEoe7/J8WZgBfmDRZh5AMkaiX0fr7BBO3GKx1oaqMv1l3DehjxtE0DXJhGGoxMYVfOkVpLv+Fk4y3bJ1pTOU/vuTy/YzXgoM225LEDMA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(83380400001)(6916009)(5660300002)(38100700002)(54906003)(8676002)(956004)(8936002)(186003)(26005)(31696002)(316002)(86362001)(66946007)(31686004)(4326008)(2906002)(36756003)(16576012)(66476007)(66556008)(508600001)(6486002)(25903002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHJ2S3VITXVZcG9DNnhVTkNnaE9Ka2p1VjB2cy96d0h5dldDb1F1TVg3Z1Z2?= =?utf-8?B?NDlCT2JYMmVPS3lPMCtQdHVQYWhtWG1WdHBXSEw4NXUvRjZkaDZTR3RPcWp5?= =?utf-8?B?czhramhTaUdNZi9zOWxER3Rxc2xVTE9DREpsRXRNRDdVY3dGRkJmVlpHbmhz?= =?utf-8?B?QmJ4N2FrUnFxcit1a04yUTdnOXVxeWtJdURCNncvYzcweklEa2l0VjZMQ2ZM?= =?utf-8?B?ekRaYmRFcHN4bllVRllpMG5VNTV3Wjc5NjdpVFdFbEFmeW5jNlNMR3FjRE5n?= =?utf-8?B?cmtjcDZGc09IQlpwcTFJZGI5Q1Y4cnhQNXN5SmZKUXBwSFZDU2FubDlGVDhT?= =?utf-8?B?bGNscDJlaFdEdEhPdlpkNmxlZlJzZXA2M050WGVxdFI1VGZpZExjMlBoNTYw?= =?utf-8?B?YmR1VWFqSmdWRG4ranQ0bDc2eGs5WHIwZ0gzNDVrTWY5TlFWbkpYbzNzeU1X?= =?utf-8?B?VitOZVFwWkxDSEdwa29iQUMzSE5wdkFHMjc0eVM4clR1a1c0dmRpU2hOZ2p5?= =?utf-8?B?alVWKzUvY0w0dWM4dkNZZTZQYm5SbnZNeUdwNlAzV1UrbTJJL2cwNXpQdnlz?= =?utf-8?B?TEt1SU55c0JLLzVVTXJ4RzNvYWNrQUNaSWVINUJXRyt2T0g3TXAyMHI1Ly9G?= =?utf-8?B?NVVLQVV2MG1XWDB4Sm0za3duQWVnODRWdmNNTlh5c0xVUmpKNitzaWZ0UmdC?= =?utf-8?B?RmNpZnRBOHZBVENJRHR1U1crOHBzc3FEaWh4YmVzc3NUUE1EUDNJOWpLZVV6?= =?utf-8?B?UDd5a04yaklZSHFNYlYwRkZMWEI2cjRmOWNjUkRHV3F6UHEvMHZSV2ZEeFF3?= =?utf-8?B?UlFMTW8zYmRNMitHcWFjd0hrTEtDbHYvZTk4disxSnZwY29zOTZtQlAzVmJU?= =?utf-8?B?dnZhd2F4WXJvckl4T2RrWlZhczFHV1EvdTB5Z2tuckNpRGorOXAxektUeTg0?= =?utf-8?B?K20vVXhHbGNVTEF0REIwSFlRa3ZPNjlCdzYzYzU3MjcvU05YVFNOWWN5NEU2?= =?utf-8?B?dCtFTS9HWFEzSUZIR0l4M1FwbGs1RlpJRjZXcS8ydytRdElXbGI2dS9GZkVF?= =?utf-8?B?dkN3ZnlkVXZXVUFBRjFrWGlyVUMwdDFBTnMrWmZMUHRnclA3S2IxQjdEM0JH?= =?utf-8?B?eFVGZ1BuUHJtRFdsMDJ0QWxXT3lXdlhnNWhpc0p1QTJlNGNXWWxEL01Cd3da?= =?utf-8?B?Ni9wSlRhdVdud0F3QkVrSjdkN1VDM0EveUp5VWRiUmsyRks0UFhsTkgyVE4y?= =?utf-8?B?eGJMak9KalJzUG81cjR5VXhOQVdOQTlXcjFsOFpMVTZkZXgzM3YwWFJER1BT?= =?utf-8?B?T3p1cnhkS3gya2w4enkvUThwcGZBS0N2V2t1dzJENXkwZ3RvM1FNbzVpc2k2?= =?utf-8?B?WmU2bk9WUlR1ZmxJemszYkJ2UzF3MzdwRFpQQ3UydGZxL0FqRUdYRGwzcW9v?= =?utf-8?B?bUFZck5Fd1ViT05Kanh2NW85eXJDdjQ1VS92NjI4Q0tiS3dzQWdFeGJkVlBU?= =?utf-8?B?b21zbHErWEhycU9qaDhCQUFQLzFJbHBkZSs0MTFtVEhqQVhvWW9LN3hXVk9T?= =?utf-8?B?TFI4MTVMWmZ1ZU1qajFnR01CMHRCWVRDcDBGV2ptSnJHQkFUK2piU1hEZElF?= =?utf-8?B?RXlGcUFyQjlHcHBwVlFqNWtwenMwYzhHNXNPek80TzdZZWFZRTZtcUgyVUV3?= =?utf-8?B?SmNQZlIwd2c5VVVWZ0FRWUt5VTBqR1NveGFFbnFodXA2VWpBbVgzSjJLVzZH?= =?utf-8?Q?KI0MoQkEIw9I61SQRtEJxMuJILiTa8S+UT+MNpS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aa6dc84-7f8a-4ca5-997c-08d9834aebe9 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 13:13:25.8999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m6ZTRnhIRCxP4aRn5naJvXYlmpR7WVURBaOasgnJGSiQQeFG5JQEmRINkP0x+hIUh0FFz/SZ/BAGl1PW2OxqqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1632921231397100003 Content-Type: text/plain; charset="utf-8" Assuming that the accounting for IOMMU page tables will also take care of the P2M needs was wrong: dom0_paging_pages() can determine a far higher value, high enough for the system to run out of memory while setting up Dom0. Hence in the case of shared page tables the larger of the two values needs to be used (without shared page tables the sum of both continues to be applicable). To not further complicate the logic, eliminate the up-to-2-iteration loop in favor of doing a few calculations twice (before and after calling dom0_paging_pages()). While this will lead to slightly too high a value in "cpu_pages", it is deemed better to account a few too many than a few too little. Also uniformly use paging_mode_enabled(), not is_hvm_domain(). While there also account for two further aspects in the PV case: With "iommu=3Ddom0-passthrough" no IOMMU page tables would get allocated, so none need accounting for. And if shadow mode is to be enabled, setting aside a suitable amount for the P2M pool to get populated is also necessary (i.e. similar to the non-shared-page-tables case of PVH). Signed-off-by: Jan Beulich --- I wonder whether this isn't enough to drop the "PVH dom0 without dom0_mem" warning. --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -318,8 +318,7 @@ unsigned long __init dom0_compute_nr_pag struct domain *d, struct elf_dom_parms *parms, unsigned long initrd_le= n) { nodeid_t node; - unsigned long avail =3D 0, nr_pages, min_pages, max_pages; - bool need_paging; + unsigned long avail =3D 0, nr_pages, min_pages, max_pages, iommu_pages= =3D 0; =20 /* The ordering of operands is to work around a clang5 issue. */ if ( CONFIG_DOM0_MEM[0] && !dom0_mem_set ) @@ -337,53 +336,65 @@ unsigned long __init dom0_compute_nr_pag avail -=3D d->max_vcpus - 1; =20 /* Reserve memory for iommu_dom0_init() (rough estimate). */ - if ( is_iommu_enabled(d) ) + if ( is_iommu_enabled(d) && !iommu_hwdom_passthrough ) { unsigned int s; =20 for ( s =3D 9; s < BITS_PER_LONG; s +=3D 9 ) - avail -=3D max_pdx >> s; + iommu_pages +=3D max_pdx >> s; + + avail -=3D iommu_pages; + } + + nr_pages =3D get_memsize(&dom0_size, avail); + + /* + * If allocation isn't specified, reserve 1/16th of available memory f= or + * things like DMA buffers. This reservation is clamped to a maximum of + * 128MB. + */ + if ( !nr_pages ) + { + nr_pages =3D avail - (pv_shim ? pv_shim_mem(avail) + : min(avail / 16, 128UL << (20 - PAGE_SHIFT))); + if ( paging_mode_enabled(d) ) + /* + * Temporary workaround message until internal (paging) memory + * accounting required to build a pvh dom0 is improved. + */ + printk("WARNING: PVH dom0 without dom0_mem set is still unstab= le. " + "If you get crashes during boot, try adding a dom0_mem = parameter\n"); } =20 - need_paging =3D is_hvm_domain(d) && - (!iommu_use_hap_pt(d) || !paging_mode_hap(d)); - for ( ; ; need_paging =3D false ) + if ( paging_mode_enabled(d) || opt_dom0_shadow ) { - nr_pages =3D get_memsize(&dom0_size, avail); - min_pages =3D get_memsize(&dom0_min_size, avail); - max_pages =3D get_memsize(&dom0_max_size, avail); + unsigned long cpu_pages; =20 /* - * If allocation isn't specified, reserve 1/16th of available memo= ry - * for things like DMA buffers. This reservation is clamped to a - * maximum of 128MB. + * Clamp according to min/max limits and available memory + * (preliminary). */ - if ( !nr_pages ) - { - nr_pages =3D avail - (pv_shim ? pv_shim_mem(avail) - : min(avail / 16, 128UL << (20 - PAGE_SHI= FT))); - if ( is_hvm_domain(d) && !need_paging ) - /* - * Temporary workaround message until internal (paging) me= mory - * accounting required to build a pvh dom0 is improved. - */ - printk("WARNING: PVH dom0 without dom0_mem set is still un= stable. " - "If you get crashes during boot, try adding a dom0_= mem parameter\n"); - } - - - /* Clamp according to min/max limits and available memory. */ - nr_pages =3D max(nr_pages, min_pages); - nr_pages =3D min(nr_pages, max_pages); + nr_pages =3D max(nr_pages, get_memsize(&dom0_min_size, avail)); + nr_pages =3D min(nr_pages, get_memsize(&dom0_max_size, avail)); nr_pages =3D min(nr_pages, avail); =20 - if ( !need_paging ) - break; + cpu_pages =3D dom0_paging_pages(d, nr_pages); =20 - /* Reserve memory for shadow or HAP. */ - avail -=3D dom0_paging_pages(d, nr_pages); + if ( !iommu_use_hap_pt(d) ) + avail -=3D cpu_pages; + else if ( cpu_pages > iommu_pages ) + avail -=3D cpu_pages - iommu_pages; } =20 + nr_pages =3D get_memsize(&dom0_size, avail); + min_pages =3D get_memsize(&dom0_min_size, avail); + max_pages =3D get_memsize(&dom0_max_size, avail); + + /* Clamp according to min/max limits and available memory (final). */ + nr_pages =3D max(nr_pages, min_pages); + nr_pages =3D min(nr_pages, max_pages); + nr_pages =3D min(nr_pages, avail); + if ( is_pv_domain(d) && (parms->p2m_base =3D=3D UNSET_ADDR) && !memsize_gt_zero(&dom0_siz= e) && (!memsize_gt_zero(&dom0_min_size) || (nr_pages > min_pages)) ) From nobody Fri May 17 13:26:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=quarantine dis=none) header.from=suse.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 163292125134310.967426138336691; Wed, 29 Sep 2021 06:14:11 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.199073.352905 (Exim 4.92) (envelope-from ) id 1mVZPF-0000mU-Ph; Wed, 29 Sep 2021 13:13:53 +0000 Received: by outflank-mailman (output) from mailman id 199073.352905; Wed, 29 Sep 2021 13:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZPF-0000mN-Mc; Wed, 29 Sep 2021 13:13:53 +0000 Received: by outflank-mailman (input) for mailman id 199073; Wed, 29 Sep 2021 13:13:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZPF-0000mA-06 for xen-devel@lists.xenproject.org; Wed, 29 Sep 2021 13:13:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 169cc90c-2127-11ec-bcfe-12813bfff9fa; Wed, 29 Sep 2021 13:13:51 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-21-WOIg97fLNrqFzSoAqQtHEw-1; Wed, 29 Sep 2021 15:13:49 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Wed, 29 Sep 2021 13:13:48 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Wed, 29 Sep 2021 13:13:48 +0000 Received: from [10.156.60.236] (37.24.206.209) by AS8PR04CA0109.eurprd04.prod.outlook.com (2603:10a6:20b:31e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Wed, 29 Sep 2021 13:13:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 169cc90c-2127-11ec-bcfe-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1632921230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZu5l7MohBWThL4D4aCcbxZpD036n9ZohT52VmFvYFE=; b=e2xohw6Zc32sgvCWh0kK1RK4w1I0TJKfeSrtfRwkUoMsd4Deurwr6CvPVoEULS0oz9Mx6R nTAF8uGW5FIfeET0yxPuDwHzhdjl70ITjge6aNkb4bcdlnQLJZT6AVFQHIrgQUKkR1np7C 9A5qT+ObAzMVnJQ3zHhWcH457bLmssE= X-MC-Unique: WOIg97fLNrqFzSoAqQtHEw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+Rikq+LTX/UwQp7WaEpQONCOFK00ku5+GfhXga7RcKwwrbnFDl79dxF8Ac1GGQfZxApemiooJBq6xvV3f6kIBPBWwItAEWsreFHdigKryfN3QsONtlsmKEUX2Mu0g0PUN4Leq1ey0xzH+NQxVcCukOUCUaqbGQYriSHaQd6HPsYkKfhGXyUuwFAZ+KwK6poovjP4W9YB8HAoDzCP1ChRJHfGq2KEsS0hZQcLcc6xvH0sfcTAVgjVFcGjsvh/Z9iOwMmya+YMamfBUexypOU8YkJNACiMEmJNHsXNDzruBEqaivIjPscq7+WmL5IShU/q8z2pooPwAzHcFL5EhO2xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w1MgNXQPIZRI2m7FHe+SKi50wAOF1utIT72Ti22BWx0=; b=Eg24EybU/QF+yhw6CmwU4Bhw/3Twfq8tXgD+7kueMKjGCKQZbfpyYe49pC6rU1MyIt/KHTgnCU/caw4cPnpVkbudqtZ+1E+vXwhc1VaX8uj56AG82C6FHFn7vkDA1EXIu4Wx2RmsS56+OZOWxxZaoA+BBGdGDxZ0H3nGNcwEjcbT84rbiQKZgSeqxR3y8lOandvhiiDbSRl/KAWnjKvePB7PX6OHFFeDzrPxwNFlGDDzw0qI/g34FTKgLxBIbnOy17PvGmz70m3hVHYvp0FfnFKeTj10DdxE3rFOtjoDMoB0tL5L8Tvesjq203gubCTuY2i809kPglRr2PvF5YJiGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH v4 2/6] x86/PV: properly set shadow allocation for Dom0 From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan References: Message-ID: <803917ef-2bd2-0223-8bf8-23d129baf277@suse.com> Date: Wed, 29 Sep 2021 15:13:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0109.eurprd04.prod.outlook.com (2603:10a6:20b:31e::24) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8351a5e-cdb8-4dfc-cd92-08d9834af985 X-MS-TrafficTypeDiagnostic: VI1PR04MB4352: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZFT817FByKbhEIlq1RcaVsOLMYzAg0sqRhFpzHfMhIpiBWgCn6ZBxnpBPxX075otoV+peuGYE8sspYV4hYj/fvACK/mlTyJGdzXJHgc+6vbvj3h22SGocC8SJIDgNhmFi0i/mVMdWQ9+ii+Caqtsx7ceVFyMfp8I4HonC3BPgbbLDzoIo5hptX312nTI85iMXtwhkfzdjoP6KWk17eDiLMwd9p7+Y4ND0k9cjx5WAQmPHg6FzI32qKXaVRFTDMky1Xpi4v+F3UbxEdNMzZ9Lf5mADbClzxE+p9LOEhloih/0E26PnAp2A9gpR0Tl28gFF9l+LiuMNtxSeqZMAWRH1/CrKdfcWnYqb9NWaLKXNwXarRpISvue/suLFG01dRARlI+Ga777fC24QxXgv4n8/I6c/SNPRrZBKrQSiMogERYZQ5A2xUjMaJBQDKm+E8vSGQA1tzODTculvBdNmS/MHWniz8Nd3hKxj8W4DCz/6OXKb9v3cb4gFE3qBxsWVs8/GxxBSF4f0YO3LylxySYCQNGRvHPW1BT3us4YJFHumuXSm8Vo+3ikWd9+Ki/9vjMKV6vjGqdCG6e8bxRP682XZyUySFIT8Z0tTlRa6vjioNvU5oXiQ9dv3Zaa3S5Wxb2fo1DsX7m/F76HFbp3M7PS+ooc++fzvzqsPQZXxs28dIZtQ9CA0/NpOjpq0nQhoJf6aeu9jv4bKaimLtw1U10Mf68uEgJFd7MEKJLjm5oYbVU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(83380400001)(6916009)(5660300002)(38100700002)(54906003)(8676002)(956004)(8936002)(186003)(26005)(31696002)(316002)(86362001)(66946007)(31686004)(4326008)(2906002)(36756003)(16576012)(66476007)(66556008)(508600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fg7GhRs2ZXn+VCjAw9y+GOkRxFxywyhwnSgJZ7GFqnlS6gjDrxd/hrEPI4Xs?= =?us-ascii?Q?xIN7HOKxZj4JBeO0AE64v7LvF38d+qxNxWtKyewMDALIMBVnawiwGe3qi0be?= =?us-ascii?Q?XLvAYD3W0jYlNKt+M9mR3AXbJfP6JvSR+Bi1AsmStFUvrWcqHawoW8r7VdZj?= =?us-ascii?Q?L22cBx+zDjfl/qk64KlACs+44gdZ63/O5mhUE1si1ZE2cxTv88W97sMOZoii?= =?us-ascii?Q?rlj+GXT/70859p+zmXnut8Fs9ooubwohWEEtfQpFeFh/GCIpPq9+iSmBHEbp?= =?us-ascii?Q?tXcy5WBhKMA5LJPfB4iW/7yCyLet4/M/5sF6QFUVBIVs//0q9MMzXml4MjjN?= =?us-ascii?Q?DWLwgd7B/7otkdTpN4xiFj041uGudixDqjOgFFwXJICFPEr1SdWdtgE49R+J?= =?us-ascii?Q?35sUU7lJuP1Uqa3VaBsMEEsdXKEQIFk95Rdpg+HHfMLo/dMRkC3DtPu36/pA?= =?us-ascii?Q?1ovUvhOpO1DVxVuj19tx8rpSPYdcL/Z3h8W9XWpq0/mdi69xXabIVlrGARzH?= =?us-ascii?Q?/DLGetotFHpV/ycJv9XFmlEoaOsTexYohC3cyy/mZ8LvPcd22zShOs3ZgTYX?= =?us-ascii?Q?6eiNuSJxLArSzTJ3YsxjKWGjBpZngH1ByxhIBhdio2GG4ZGZsCImZYW6Caum?= =?us-ascii?Q?kvD8bEOKCcrL76qrJHZtsCJdV+WeH3NMYeCU6IL2gkvFGeEX9WFUk8FVTcFG?= =?us-ascii?Q?6tLYdu2sUPCv5KSk9iqEHlzw+w7FtOJ35wzjddMnP4q9xgkxmslG6KKC5DBs?= =?us-ascii?Q?8PRepUB1wneBNQemtakCJBlJWpS7al2zc16w5LxjtMJgkytocfyuJPFkiB74?= =?us-ascii?Q?NwGmWXcCkivEJfVVUxa1MfuXugjag5mUel3AfbxTuq3gFAg5Ny3u5Kumrm2X?= =?us-ascii?Q?/71DQ+I3NpPkJUGE2LFjf73lav+NfrxR4ZbbrJh8E16K//jUt1bjufvOVqmI?= =?us-ascii?Q?PFGanFl8tCw6UNG/QJXWhqAa9UbBt7sl0fSKTxA2EXzIdW5fcil0nFTnWrrc?= =?us-ascii?Q?Mlpr50F40LZyl9r/c0SRXgOyu4T0ptAB4++2+G3z5bBwNHk+lYRKwKCHfiJ9?= =?us-ascii?Q?wmGy9YQ/b9xilpSqr47mMp7oPTy+4jMnd0yQf/r7WCHGPPnsuO3HVEJ5zTwd?= =?us-ascii?Q?5qS5mKQ3N7Tcme4UfDVX+n7NYZLzPd/uvnzRdAnoEv/y6ltvhU7Ryl4L5arx?= =?us-ascii?Q?ns7hvRj6WmMIhVEWfb33hvelJCltIJlGj0cZ+Set/oKTNpxL/7rxrIeb5cMy?= =?us-ascii?Q?lHxaNnljGLr+VBO2841pKO46rlVtVtxiYz8F6c5aUZVc8HlMN3dMRoJIlPYn?= =?us-ascii?Q?QWgcUtn3VmRbvwuakOYee/q3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8351a5e-cdb8-4dfc-cd92-08d9834af985 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 13:13:48.7289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mPTuO0/Kqn+RYdyiMuQHaPNYdf7MebcM5k3oCr+aB6i8LP5TT5ZpCSdbc49jX2D+b2DfZG7jRl2YdBqS5h40FA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1632921253517100001 Content-Type: text/plain; charset="utf-8" Leaving shadow setup just to the L1TF tasklet means running Dom0 on a minimally acceptable shadow memory pool, rather than what normally would be used (also, for example, for PVH). Populate the pool before triggering the tasklet (or in preparation for L1TF checking logic to trigger it), on a best effort basis (again like done for PVH). Signed-off-by: Jan Beulich Acked-by: Tim Deegan Reviewed-by: Roger Pau Monn=C3=A9 --- v4: Also fill pool when opt_pv_l1tf_hwdom is set. v2: Latch dom0_paging_pages() result. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1298,7 +1298,7 @@ int shadow_set_allocation(struct domain { struct page_info *sp; =20 - ASSERT(paging_locked_by_me(d)); + ASSERT(paging_locked_by_me(d) || system_state < SYS_STATE_active); =20 if ( pages > 0 ) { --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -21,6 +21,7 @@ #include #include #include +#include =20 /* Allow ring-3 access in long mode as guest cannot use ring 1 ... */ #define BASE_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_USER) @@ -928,8 +929,22 @@ int __init dom0_construct_pv(struct doma if ( d->domain_id =3D=3D hardware_domid ) iommu_hwdom_init(d); =20 - /* Activate shadow mode, if requested. Reuse the pv_l1tf tasklet. */ #ifdef CONFIG_SHADOW_PAGING + /* Fill the shadow pool if necessary. */ + if ( opt_dom0_shadow || opt_pv_l1tf_hwdom ) + { + bool preempted; + + nr_pt_pages =3D dom0_paging_pages(d, nr_pages); + + do { + preempted =3D false; + shadow_set_allocation(d, nr_pt_pages, &preempted); + process_pending_softirqs(); + } while ( preempted ); + } + + /* Activate shadow mode, if requested. Reuse the pv_l1tf tasklet. */ if ( opt_dom0_shadow ) { printk("Switching dom0 to using shadow paging\n"); From nobody Fri May 17 13:26:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1632921276; cv=pass; d=zohomail.com; s=zohoarc; b=W2m28iq8kMGV3PU3uC3eCe08G+KozjJ21GS0xwNYVNQQ3rE/07obS++st4VBDgZlotyQFzt8ltvcHTBtwxZdz+GdhOFP+/u+l9HDJ2QkjdrFYlrUXxdBiQOwDz/122eY9BDFnTy8Aj+W/n2pKFAjVXMQgumgCUIqrVKbi7+820s= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632921276; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Le5BJdNW9ne/Xmuzk0IFXev47snchE6r7a8FNfwFXaI=; b=FjVtOU98UdYE3qCYoA1ftHkXH8RfTk8zYn991ItYBeTQRXL0Cn4y3YRRIxGzMHIQOR3aTzG2ODfc/81/i7rJXz3HzDO7aH71KS8rTxZlUZvHS/aHoLmiguu57f+WxCjoCvnNJOj5ve5nZSQrztTHVnRcUbj1frZz3BNtK2juJ94= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1632921276552710.1285164082038; Wed, 29 Sep 2021 06:14:36 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.199079.352916 (Exim 4.92) (envelope-from ) id 1mVZPg-0001Ne-2S; Wed, 29 Sep 2021 13:14:20 +0000 Received: by outflank-mailman (output) from mailman id 199079.352916; Wed, 29 Sep 2021 13:14:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZPf-0001NX-V8; Wed, 29 Sep 2021 13:14:19 +0000 Received: by outflank-mailman (input) for mailman id 199079; Wed, 29 Sep 2021 13:14:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZPe-0001NJ-Up for xen-devel@lists.xenproject.org; Wed, 29 Sep 2021 13:14:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6f65c171-facb-4f78-9ad8-bd66e0b63ff2; Wed, 29 Sep 2021 13:14:18 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-5-1Hr4OE5JMYGecOgmdzLptQ-1; Wed, 29 Sep 2021 15:14:16 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Wed, 29 Sep 2021 13:14:15 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Wed, 29 Sep 2021 13:14:15 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM6PR01CA0070.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Wed, 29 Sep 2021 13:14:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f65c171-facb-4f78-9ad8-bd66e0b63ff2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1632921257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Le5BJdNW9ne/Xmuzk0IFXev47snchE6r7a8FNfwFXaI=; b=jVzA3KkMCAgyEEzDyakJPzQvqXQDvaNxtdFT7cSpdHODA03ztpxdw23t+deBhPhNlQPgxO GPHZAzD2Df6M1r6uf6ueJ5Zn6H2LHyOeArrERaOLsw0lpZBIYL8toZ+uPyxkIRPK+OECTQ RGR64opFRVbow6ItAd+dJJlDuOq6VgM= X-MC-Unique: 1Hr4OE5JMYGecOgmdzLptQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pa70P8gc42nrhMzTduy6SDxlH5qd3UO/ngbw/+cAe3IVXwkSZ2qKjkip8D+/unc72MTUZfnmodjNlqdszToP9P4NN0d4DuF6r1mciUUBpO62X25urL4zcSLYpen2xxvu2SoFWAt/HZaikGyMldbuBDDVzEASmH6DHuZCR8lcfqN6Qr9nPJLgT+mDTsOqjeK6+gUhAcXNkanVUwwjVXbqHGtcePYgoBdrATgqkTmJVN2BkIuDS4EFYkVRo8D8I4caRxy/C4ytq/3Gxe+soqv+VqnnhD0jpQB0GYP/e+6ibDKgLNmpDu71b9ZXRkFRAigCJbMc4IPuaA0LjghRVomeyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Le5BJdNW9ne/Xmuzk0IFXev47snchE6r7a8FNfwFXaI=; b=gQpLzv+oOu6U5g7uL1B8nU321iyQ6d7bKLQKBSnBGFRe69dOiMPKKKwi4FqGrNmM3vcACEo7M7u/64e4VzeTmebefSdw+bcUHPsopXr7z1XKXqF50RAF95DuKmCfGTPkc+UXtbvaNnnVUi+0ujaxQJlz1A7ge2dGkZXulVVutTon9YwfGIg9Nu5Z9PWx3eVoUspTzPPfHakX3zweGDg7fJasoouZP5KQpeE/LOYK5TLt4l5v8B1dXusbWSZZ2H0CXk9LhrfEcQ4sFOVEghgK8XwPNc1R3bGxjnDLetAJIG0vklz53oVGZirFHZbDbGdzT2X4M+ZtPGAu2q5MXZ9xAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v4 3/6] x86/PVH: permit more physdevop-s to be used by Dom0 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Wed, 29 Sep 2021 15:14:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR01CA0070.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::47) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cdfd7ed1-bf90-4928-51da-08d9834b097b X-MS-TrafficTypeDiagnostic: VI1PR04MB4352: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8fg1eFR7mqDHdR2QtkDYfmq3AFHlXbA4h2xrfxmREYz5CYm5BpsDEGj6Z01lot/bmnX58Y1l7fbDRCpP724EVqZPNjv6bw/gj5/2ssK1bW5qHGCzrv+dOVsmow+0a/HfvZvO+xktB182VoUzcvP+vHkhUHAxTWMPb6zrJEYXGEc7NAAR15TSpyEDl/W63sYpV5dWYfBQ1yvg7pyDL78AD8hcJ51Y4sjLJBAjsDMU7lID0OoILEE9CpiQ7Wqcy/izCbd9ikHyjrngSmb6+HjWmmuR1Ol5CYU2GnOcl/3rP337ZobrCQYoQUcykq2VRTh4by3fWoujhkMdRQLoq1cjDRPQvZNzS5FMGDM9Z0IX/+GC8KBd/eBV0ktvPrpcnOpJZ2tO8CXx49IuKpo+hyQFTNi8uMwJw6clrnbfHULY7uFprrjkJgJWKXk3vZKz5kTdFg6rpcbNYAfFRd6nqMJ/8tDGANyLIcdNAKx+KUvu2JjGJ/mt0XVz8dIQPM9+qByIsuJ7uKHivyjLLR4DohtvhiRL9jMl0l2juBgXxhEXhy0OAFKQkJn4ZljSw5Rmk1z4VAcVI8wN6+/eXAJ43TCIG5K9liqAS2+srX1jy8+vXx5NsQBW2He5XDJePxUNscGzWjjBy++/xcefpscxNEH6Kv+51/A/hCYDE4KSAS9hbgyCZIGXPi+kzyepmHHPv7nc+nGWruZghQq+aKqf8Q4W+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(83380400001)(6916009)(5660300002)(38100700002)(54906003)(8676002)(956004)(8936002)(186003)(26005)(31696002)(316002)(86362001)(66946007)(31686004)(4326008)(2906002)(36756003)(16576012)(66476007)(66556008)(508600001)(6486002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkdmVmR3c1lvMTl2bkVUSDE4c2w3RThUSnZSUGJ2a0tHWXZxM3VScVhSQU1N?= =?utf-8?B?dzZOSFAzZm9FVzVza1lzQ0FveUhKaDNOSDFrVGprTHRjRUFNZU5YUnRiWVF3?= =?utf-8?B?RjJ1am5UWElmYnR4dkxEcDVyUC9kd09ZdjBXWm1RQkVXUjMzTHU0bk5sVUlJ?= =?utf-8?B?MTJJaWZ2dGc2cGJGdTJrVHp4MVpYaDlBK0QvZlBCeVNvYjJTT3J2cDNWZTFt?= =?utf-8?B?QzhNN3J3Kyt1bzdRUlBSYmZYbVAzU1dDMG11MEt5MEwwaG5ONU44QVlMWWNl?= =?utf-8?B?Lytrbks3bStHSXBzb1BLN3o4OFhmcGpPb25zWVVyVzdiTFcyOGdMSzIzbHpj?= =?utf-8?B?Mjc1U01RVW1UM1FLVzRwNEFudnVNMFQ4YkhVMm42aEFRZ3ZHbkV2WUM2c25B?= =?utf-8?B?UkxkN29GaXlDS3gwWUNPbUNWMW9jSlBzckM3UjFLMXpvbXBmMXdaaW1SQVd1?= =?utf-8?B?WmxiOFVKM1VoUGxUZ2Zua3hKeWpBclpnODlGaVhkRHZYdnlFL3FwbGNlcE1U?= =?utf-8?B?MmFrdlIzclEzRWtLU3pUT1BmU1NDSUlWK09tWGlvbnFSN3p1K01NYysxNU9n?= =?utf-8?B?ck5pSG5rMkswdGZrTmZrRXZjWkx1WE1pdnhDNDBnWmhZbkJJMUdxTnY0RGpk?= =?utf-8?B?TUZmRnVyb2xKTVlXWU50am1ETHVwMzdjdzFVeWVEZXI0MzF3OVhZMWM3VTIw?= =?utf-8?B?WjN2eCs5Y2R1WVM3NGduZjk1SnRQSUt0MUczaUtHeVFFU2drN0xpZys2dU0v?= =?utf-8?B?OGFGSTBSSEptQVFFWmdlNFpTRzRMMmtJMk1sbG84NDFxcUdmTElSY21ZQ0ti?= =?utf-8?B?Q055cUhJZjlXaXdKb043djl4RzZ3YVVpVmZ6dTZVZGZXeEtmTUFHeTRhSEh4?= =?utf-8?B?c2Q3Q3NLendWQ3JJV0MwTHc5dzBIWXJ1bEpJdU4xbnRSZ05xVnFKRmszS1Ev?= =?utf-8?B?OHI1b3VYbGNtUXh3TlB3OVBNa0h4eTdkRHZBS2JHNzA4WTBSN1gxd29ydTVy?= =?utf-8?B?OUljSnFzVlU5L3NhWmQwYmtJanR4WTdNTXpTaC9NREkzUDhWeWlIM0tGSTRw?= =?utf-8?B?NVpCem5yS3kwYVlMVUJ3T3pUeER0bEZWUXFSTWtlNGZQdmkvWmU1V2N5Z0Jh?= =?utf-8?B?dVFUWkRFM0RVcEpIbWUrV3k2NVJlSlhkNVEvWVJkZktFSWFOMUFKZm9mUDJU?= =?utf-8?B?dzc5Q0p1T0xzUDczSm9Oa2N1SFBKWHNzd0EzUE1hMzd4bVptcytZekorM05n?= =?utf-8?B?RHo3OWJscCt6QjdENHdXdU12OTRDdlV4dGpNcGppVWc5VUZId2JBZmtoVDBk?= =?utf-8?B?R2NkNnRJMjJLczdRaVA5cWxWYXBnRnhHeGdnNnBzaVFSNDBieFFQalRhN1Y1?= =?utf-8?B?NVd3VDZsbEc1UWRaMXdmY3pZeGpuNDhaRlhkY25BSk93UlNqU2ZBYnovR0J6?= =?utf-8?B?QnBvN2FONXA2K1dCOGxMbDgrRGNic2ZLTnBaQlIwdTV5OVZ2dlF2VUE2dVg1?= =?utf-8?B?dDlqVWx4L2dveWN4Sk5Jc2hyNlR3eXdCb1pMR3FlR3RvYWU0VEVvcWRPZFI1?= =?utf-8?B?OXFtMnhDb29jM2ExS2Q5Y1ZNRzhzWnhPaTNUc3FFNHhxOHlybHVOaGxjdjVt?= =?utf-8?B?czhwQ0JDNk0vUjRva3pJVmw5NUVJR3luaTFPNHVQSVA5eFJYQUtwT2ttTEpF?= =?utf-8?B?bGZBV1BsNjlCNWx5VjJTOE9peUxJNFgrdW1Ta0dEMnRNNXNyT2E4TkUrWVZL?= =?utf-8?Q?8XeYtbEdrJgsJ1FIf0hLlo2AI+C8j5mZUZfqJT1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdfd7ed1-bf90-4928-51da-08d9834b097b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 13:14:15.5447 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UR8z8fFJToAsruZwi84K/Tl1R3UgHsesdCpTcyKMP29xs+w5YTbNEjuHpuinF5VvSp0S+xAOR3Xug+wBYhN61A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1632921278075100001 Content-Type: text/plain; charset="utf-8" Certain notifications of Dom0 to Xen are independent of the mode Dom0 is running in. Permit further PCI related ones (only their modern forms). Also include the USB2 debug port operation at this occasion. Signed-off-by: Jan Beulich --- I'm uncertain about the has_vpci() part of the check: I would think is_hardware_domain() is both sufficient and concise. Without vPCI a PVH Dom0 won't see any PCI devices in the first place (and hence would effectively be non-functioning). Dropping this would in particular make PHYSDEVOP_dbgp_op better fit in the mix. --- v3: New. --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -94,6 +94,12 @@ static long hvm_physdev_op(int cmd, XEN_ break; =20 case PHYSDEVOP_pci_mmcfg_reserved: + case PHYSDEVOP_pci_device_add: + case PHYSDEVOP_pci_device_remove: + case PHYSDEVOP_restore_msi_ext: + case PHYSDEVOP_dbgp_op: + case PHYSDEVOP_prepare_msix: + case PHYSDEVOP_release_msix: if ( !has_vpci(currd) || !is_hardware_domain(currd) ) return -ENOSYS; break; From nobody Fri May 17 13:26:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1632921315; cv=pass; d=zohomail.com; s=zohoarc; b=P9BC7TJVWOHBnyrSoPPDRKRUr6J5P/mOXvj8/H6gTMB7aExwSU2RXirybM5IQInPJ+Y7JPWuV9H6YIypJVBrjeBdhGCl7tZqtizORCTopwev92VMhTHWRf3rhr3OFWojBbdyZKhqrfbxObpAXtOG6YVrkS3rpsV1nUahSUkbbGc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632921315; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eW/2cF3lu6QYOHTIXUs9q6QXeBV+Luo/7Lua57wsjCU=; b=DWpruvsQEem33xySaRrVaII7o30xzT5Ss5vmt884RdASXHN83lBjcwEfnnHQ7MXCDzF7o4Z7qlmtn8fsFmbl+/QyHJZDypyUqQvzXChUen+22u5ypSpA3GtCnO7J57Chl9dVN2KFEzBkEL/GOkBD6GibNjmuu3u0bfSOhvPBBx0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 163292131520573.89506847013388; Wed, 29 Sep 2021 06:15:15 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.199086.352927 (Exim 4.92) (envelope-from ) id 1mVZQF-000241-GH; Wed, 29 Sep 2021 13:14:55 +0000 Received: by outflank-mailman (output) from mailman id 199086.352927; Wed, 29 Sep 2021 13:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZQF-00023u-DG; Wed, 29 Sep 2021 13:14:55 +0000 Received: by outflank-mailman (input) for mailman id 199086; Wed, 29 Sep 2021 13:14:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZQD-00023a-LH for xen-devel@lists.xenproject.org; Wed, 29 Sep 2021 13:14:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3b126ad0-2127-11ec-bcfe-12813bfff9fa; Wed, 29 Sep 2021 13:14:52 +0000 (UTC) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-12-Q5pSGNuuPzuE5k3J6YPxDg-1; Wed, 29 Sep 2021 15:14:50 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 29 Sep 2021 13:14:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Wed, 29 Sep 2021 13:14:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR2P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.10 via Frontend Transport; Wed, 29 Sep 2021 13:14:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b126ad0-2127-11ec-bcfe-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1632921291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eW/2cF3lu6QYOHTIXUs9q6QXeBV+Luo/7Lua57wsjCU=; b=RFwuWuizdH85sv3rGnCKzKjZkR86mObT8tviw5uiDjaaDcong++gAcrJsWlHTamv88v+Lx gqM81AMiWlJypjllbhTxlSp2H7JUpLsctOqvAMg91JXEEFQUAeEtb1VXLSzqpHqi2eyvc9 WuN6To0h1VKxVs+yfUZkmpDPyESMW80= X-MC-Unique: Q5pSGNuuPzuE5k3J6YPxDg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hO+bq2XZYZuU4NVXmDz0OiVOj56/iXgRQE3QFAH9IUJ4BDp2oQdTVaSlvUFnryPn6XwHnxWLwY3RwSDIO/dLUzHnYqBqLvdpngf3SyL6J+nnxMokpJtupMEq3gwZD4M/YMbQ7QaTDXTUfBsKgpLfHWpkkH+Yz2q41fZyhXtEbvC8tlAs6mooBg2+uQ4rTOkilYAbqDnjzptx+5sU3tSxD20Fk0KqpML6jZn1Tq1Fxa5KeCj91XCr7POeNL54/m+c4OQS3R11hlTARF7ayz9W5ffJwTfL9Q/Wny7JYhNvt9so0yXL8gE9OV8oZnwytV7/G24zR1Th5+KHnSmD/1wQPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eW/2cF3lu6QYOHTIXUs9q6QXeBV+Luo/7Lua57wsjCU=; b=LE7xNH0JaXtIoBkxN4JgLUV3+TfN1ISvfg2NbNU5E2EfMho/eapi/8XljV0II4pY9mZuYP3AnwOJCr8UlmrGT0WnDeg2pRJ82xRbvp7VE7hDGU3jtKqvcUhZRhjMHvxWjV4bFX+6jYojxXfgDLJsMISVVRxrMOdnYL+V/S80gGc4jpcD8Aj5l07NRe4/O7tR81OOaZHPj8vcGyNVPoX/d3x+mta+yON4UomsXNVlK8ppR3OoRnZZftst74PA3Ag9laWtuPPf8UsrN26tbx8LNYh3YGmelsUSKCIrO9N3pu/d6Sr0evgRYTgx8/T8ldoe0tfjuy/rbcbpoFgxbeKiDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v4 4/6] x86/HVM: also dump stacks from show_execution_state() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Wed, 29 Sep 2021 15:14:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bb73bed-6c89-412a-2339-08d9834b1cb7 X-MS-TrafficTypeDiagnostic: VI1PR04MB7150: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3ZNlQTUaLyH8/6MqA5ptf9H4lJCoeMLgR5EWxt0q0aFA+aI+CDmJQHMvPdFA0JEz6CX9kcdipFCbplFOoloHtpDw9l6QEioW4DVdTnSGZWfcg+8vQqJMz57YiRIOL7+V58PNl/hCfXfAV7GxL55hu4PyjIryd/PHEA6ioNrpvqM/5Qq3bWx4VCvhI+0dmaZRg0tESvchrKqA23JhhtIvB8oFW469qp+iXUWFvlBtNWbLGRI33V7FXsECWeqC1SNfEz1NmnKXZBqYE/vTVMJY6wtv/ZJ5wA6NcneTGiFCxLhQ25cZyE4QMMrhCXpQ0YMJW7Dgj9Ew+9fYTBrffCUFBL4RwK616H4hGtqvyR49aZpNA5YpKlZRWhQhW0HC+l94ifd5VcsIBHyW2UwMcZuJK+3okURHcBNYs+Lid1wn8gJSr50iRXdX+PXqmGWFeiBd2ijxVwZ53hSGdjr04ltQ5k2wFkzFmEgtyxl9pPhvk71hoWWyro9B3lpP/7Z84rU3UQkTUX5/5BE+FE382ZQTUDA5M9qvksfIIfOrwjYA984Jl0i8zCR+iWxIfGSvjcyCS3aOuwoEXgpx9GFkKLH2cR5qVc0mTbd558FSp6x0KDEdjIUcluU2AtykoOi4e3cXxnqlf1E9SqREsKX4IEJfJMxfB2mlrOwr1lUFCeSwtvHrjRc8fvaUzp7eXIXEhZ4E4O9N82Yzsz4ikNAVb+LERjAXR7ghe+LJvepiOqhBKsk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(66556008)(186003)(2906002)(16576012)(316002)(5660300002)(26005)(66946007)(8936002)(31686004)(83380400001)(8676002)(54906003)(66476007)(6486002)(86362001)(508600001)(36756003)(6916009)(956004)(4326008)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmowbVNNNU5weklQZGhPMW1LSUwwbmZsb0VhMG1uaVVHajZJNlRVTis2WTJI?= =?utf-8?B?SVVPS3JSb3lVME5DUWJWYzVKdDBDVFJnV0JDNnFTWjlOMnRCTDNGSmxqYkVH?= =?utf-8?B?Njh3MGZ4bWExWEcyNnhCYmJpQnNtRHgwVHRHQ3psa3kyNERBa25MTnd2elpx?= =?utf-8?B?OGl0dDBKMm5Ebis0TnFvcVVVQTFSeFRBMVVsS0c0dkxTVkp0dVlGMDNzSWJs?= =?utf-8?B?eHl6dk9vbXpzSVF1L1BNNHFFbnZYTERSTzk1QUpnckpZQzJoazZFNlFUMHRY?= =?utf-8?B?YlB5OUI0RlBCWDFlMXNIcWtXcTdYUFlIcDd2bTQzbjdYVWIxNDhnQndPK1hn?= =?utf-8?B?V2FQdHNhSjV1VEpkdTAydUdoV3JObWIwUWovdFBjRXNtS3pxUHA1MWgzbG00?= =?utf-8?B?KzJpM3Fia2NjajU2MmR3bTZmdkdyTGZpSnEra1l5L0tNTm4vZmQzOXZqREov?= =?utf-8?B?T2FpWURVQlVJaEFNOHdNR0g3MW83bzFFS2lxZVJ4QVljN3dSOVBDbUJyQm1C?= =?utf-8?B?RUxHRXcybm1wQTVwSU5KZzlXRnNSaWd2WFRQb2wrRCtOdFhqWGJaWXZJcXpr?= =?utf-8?B?ZFlGdmkrSkFvQnc1bytuMlhGeVAzRXB0ZEFvYnBqQzdFOHIvY3o5NmhrQVlv?= =?utf-8?B?cTJQK2N3bkhyZ0xQNmE2N1UyeUd5SUtuajZVVGtQOEZQNEJKUkk0Tm9DVnYv?= =?utf-8?B?L2duSFpuenBjMlpuamZWVGtaeUNtOWFVTDR3YW9CelBVeW1ldFh4QkFxa3RT?= =?utf-8?B?NUZVbFBUOHlrTW9MVThtS09lS2xaN1d5TUlzek9hbHNvUjF6NkhiYkY0Z0Y5?= =?utf-8?B?Yk9Mc3hrLzkydTVxdTZoZk81WE5PNnlTbDd4VFEyVkNxVVp4bHdtQ1l0MFBl?= =?utf-8?B?dkoySGVtanR4UHpEQXdWQW9aR1ZLdXptNndrRFNFS2w4OHRudWFjczFPRkdO?= =?utf-8?B?NGhnYW5uM0xpTFlORGMzOU52T25ENmRZdUpJYUcvbFNZRlM1dTZ4VWF2OGh3?= =?utf-8?B?dXBkSkFERlpiV09QQ091R05ZbjJ0RTkvTXhSQUdpVU5aQkh6RHFUZTIwK3pu?= =?utf-8?B?eTJZSW13bEFpdnlYdHQxeTJjWlRBL2FHS2NUY3k2V1R3bkdBYXExNjdIMCtv?= =?utf-8?B?SzdPaFNjc2hsT0o4cEVyVEk2cGxxZS9oV3VRR3BYVHMwQUdocDBoQVVOMXdx?= =?utf-8?B?K3k0TXgrcER6cnFEb216UFBvdVNoK0c3R29lYzF0dmEycGJYbmo3dWErS1Uy?= =?utf-8?B?QjZlSm1aL0czbzdTOGh5NzBGaFZPY2dtZjNFYTg4R2p6bnJBRDVrczhoOFhJ?= =?utf-8?B?SzBXdjFQR1VuVDhLZmUwVldhYjZ6bkQyRjFPQ1dYOGNjM3duS0Rra2Fiejht?= =?utf-8?B?dWs0bUMvWlZvQy9kR3ZDMVRMYytoVFFwYlBTQ001OSswWGhCRzZ5RDNucE4v?= =?utf-8?B?NE5lM25obFFJNjVUWGtmZ1h5K2ZrSmJSOWkxTjM3RjhJNEpHNzVQeFpKVjlW?= =?utf-8?B?K1d0LzZoNzNyRWpDNS9STm82U3pja1dVb3V6N0I2dnFaN3hOMFNmOTBvVUhi?= =?utf-8?B?Y01aUzlBdFVMUXhvM2xSLzkyVEJDTDR2YWZMOWRqL0lsUFl6VlJIOStaVWN0?= =?utf-8?B?WWcreTJCb2cya29LclFUamhVLzEvNWdWc1FLNVdwMkhTNlF0bys3WExpcHNp?= =?utf-8?B?MGFjd1NacXZpRU1BMGxrcStvOUt3TDM2OHhtMFI1VXJEQjZXbDN2WkN2ekRj?= =?utf-8?Q?71kUPElaM53sIe3nxRQvkYgXEMkbIMTEtaiPE66?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bb73bed-6c89-412a-2339-08d9834b1cb7 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 13:14:47.7835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UtEVlkbDpvc1RMt3KX76A2rb6wPkfkVDI1HcTqlp3HH0PG4XefMcWPEqLs8ZiiCT+BCvQn9r/lvHQivQSEfCmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1632921315683100001 Content-Type: text/plain; charset="utf-8" Wire up show_hvm_stack() also on this path. Move the show_guest_stack() invocation out of show_stack(), rendering dead the is-HVM check there. While separating guest and host paths, also move the show_code() invocation - the function bails immediately when guest_mode() returns "true". Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- v4: New. --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -303,10 +303,6 @@ static void show_guest_stack(struct vcpu unsigned long mask =3D STACK_SIZE; void *stack_page =3D NULL; =20 - /* Avoid HVM as we don't know what the stack looks like. */ - if ( is_hvm_vcpu(v) ) - return; - if ( is_pv_32bit_vcpu(v) ) { compat_show_guest_stack(v, regs, debug_stack_lines); @@ -611,14 +607,11 @@ static void show_trace(const struct cpu_ printk("\n"); } =20 -void show_stack(const struct cpu_user_regs *regs) +static void show_stack(const struct cpu_user_regs *regs) { unsigned long *stack =3D ESP_BEFORE_EXCEPTION(regs), *stack_bottom, ad= dr; int i; =20 - if ( guest_mode(regs) ) - return show_guest_stack(current, regs); - printk("Xen stack trace from "__OP"sp=3D%p:\n ", stack); =20 stack_bottom =3D _p(get_stack_dump_bottom(regs->rsp)); @@ -687,8 +680,30 @@ void show_execution_state(const struct c unsigned long flags =3D console_lock_recursive_irqsave(); =20 show_registers(regs); - show_code(regs); - show_stack(regs); + + if ( guest_mode(regs) ) + { + struct vcpu *curr =3D current; + + if ( is_hvm_vcpu(curr) ) + { + /* + * Stop interleaving prevention: The necessary P2M lookups + * involve locking, which has to occur with IRQs enabled. + */ + console_unlock_recursive_irqrestore(flags); + + show_hvm_stack(curr, regs); + return; + } + + show_guest_stack(curr, regs); + } + else + { + show_code(regs); + show_stack(regs); + } =20 console_unlock_recursive_irqrestore(flags); } --- a/xen/include/asm-x86/processor.h +++ b/xen/include/asm-x86/processor.h @@ -493,7 +493,6 @@ static always_inline void rep_nop(void) #define cpu_relax() rep_nop() =20 void show_code(const struct cpu_user_regs *regs); -void show_stack(const struct cpu_user_regs *regs); void show_stack_overflow(unsigned int cpu, const struct cpu_user_regs *reg= s); void show_registers(const struct cpu_user_regs *regs); void show_execution_state(const struct cpu_user_regs *regs); From nobody Fri May 17 13:26:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=quarantine dis=none) header.from=suse.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1632921352128721.1368778747363; Wed, 29 Sep 2021 06:15:52 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.199093.352938 (Exim 4.92) (envelope-from ) id 1mVZQp-0002ex-QK; Wed, 29 Sep 2021 13:15:31 +0000 Received: by outflank-mailman (output) from mailman id 199093.352938; Wed, 29 Sep 2021 13:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZQp-0002eq-Lw; Wed, 29 Sep 2021 13:15:31 +0000 Received: by outflank-mailman (input) for mailman id 199093; Wed, 29 Sep 2021 13:15:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZQo-0002eb-3s for xen-devel@lists.xenproject.org; Wed, 29 Sep 2021 13:15:30 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2a1860cd-3f21-4fe4-8e07-12f36a17a590; Wed, 29 Sep 2021 13:15:29 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-7-TzB_t_pHM_m-6GiNITrmCQ-1; Wed, 29 Sep 2021 15:15:27 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 29 Sep 2021 13:15:25 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Wed, 29 Sep 2021 13:15:25 +0000 Received: from [10.156.60.236] (37.24.206.209) by AS9PR06CA0103.eurprd06.prod.outlook.com (2603:10a6:20b:465::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15 via Frontend Transport; Wed, 29 Sep 2021 13:15:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a1860cd-3f21-4fe4-8e07-12f36a17a590 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1632921328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cLGJUBAqG8d0gm/NqmHESrd2ZgrMqEgXRIhq0Lc+mj8=; b=FDK/RSjbJRAJhbIuXuSllpUsmXOJUmPXP534atJyfu43EKE07FaUsAZIrndp70mrBJAXIZ CmTBsfHtZ4zCSN0s6W1Gp1mkmNnwuT2gmMYoGYumZl7u4AjByYRESc1csI4KyGzRmq4Jjg opEqQIS20cAJYkXUcEni76UM0qgd9ow= X-MC-Unique: TzB_t_pHM_m-6GiNITrmCQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MyPyY0X3CdbrApH4GlNlmy7go66YHNLd1U/FZwWghNZe8U+E5pHT85SoMBQwQwyKOkCyn4V0ErC1KmB++r6Chehn3GDorgYnT+gzfc3EGTqYpGiOqfTurwWXAF9qr0+hSh2Ed49iBGfQZ9uRWjebj7lg9Jw1yjW5kuBTirY1Xjy6H8G2N4alnIodBsNXcu2v9e7UNUag32KPnArIgfDsXivQVOx/dBm0BY4AXorhaoHKFLDjZkNlpVmTY18+S4G7+ku8Cx/vyruvjt8j+5HSfzjBHXgUHYknZfMXOiqJWGexggQD6vv9p8IrDV8/Xpp9TxAa1YYz/nrGgrAGGhb65A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/SsiSshy4JYyNEDKdw1hBdETYO6OhRZqVzfvWAITRUY=; b=Lhkk3xVRweitjsrTY7AFdUvT0e1wTNFpMEbBlr9Qs6v+O91JhfpWFFYN9gK5p4OdbEcjbzmKadK+T15GtVyIbcSfIPyWqe7LruY17HvXj7J2mzsnuICoqiCSfzX5/VPFUaj40Al6v7HaYwOcCRKmlTrOK9hx2ReDgvssQBSR98UVzxHBTt4m7PjPZjFy7KRGFm+3PQmJf7ruFT/knuso6c+6I+DXZOrUg14fSnKKCrNJ6sqH1wwcefs+Xje2LL3Uk84F8Dyxm4GmH7oQHFxDRKf2Zu2E98q85e7QEbCHowuA8SoNv9H0HAHP4FaqbfWkrMLOljBEheKgykYsspT5VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v4 5/6] x86/HVM: skip offline vCPU-s when dumping VMCBs/VMCSes From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima References: Message-ID: <4df38415-4154-e696-aca5-fa9498d1c318@suse.com> Date: Wed, 29 Sep 2021 15:15:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0103.eurprd06.prod.outlook.com (2603:10a6:20b:465::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af689673-9a1d-4cc4-3b4b-08d9834b3356 X-MS-TrafficTypeDiagnostic: VI1PR04MB7150: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cc28zFlhsXgLqQ0kwEthlvWtdnBbsNFE+ZFlpy8t0jvpWxt+vOTnaSRkpSIKO9kreyCijupeM9Bda+bdibXZ/3RbhyXfAN+LXh6S2JJy05Wp9AvHeQUiq63PWyY/l4nctMnbWPxnaTAFVz9Dzk3HsbW9pDdvhP5c2NbmXcV2UXXnHzKhAEForL6/sMa1Zp9kycvH/JtJrT1ox5kZuFmL6NQ8ErR5tCZ0eMFAeRbNUZ2DV8Oj2VFUalopZ7f2F0hBQAUxmhI6B3QRWhv2Us2uGE4m5SHZPMHclneKvDkXFZH/spJgcKn2C1x9ENi8rdE2FCjDh76hpF2BS2qB2pKLLJAMVLzfe3F51tsv1MhFjpknoL+6psGSaHqmem0XP2vGswhBXshvyNXrnW4bWD82/zbxZl+qCM0WqkiwIY1T4S4mtpfKuzCfMEDq3Es9CTmRuTS9BxOMU587fUsqVeiKTH/HgXA6o0aF3XVlWKIrRRH4kog8k1uygN0OmeIVAUsK6uK6x3YlfyfShrmJvWPzjrbGIxUYJod8unLqeimNkr2oggXQntAYM6IZqNZDo3p+uyrM1D7mNAl7j8c2UCzAcFneG9Ii/Dpak0vhZ3fHzhGfo+bf5I1yvL+r/KVInbirDADyxL7fJnVFebxqgVQLrOU9RpJsSJI5uWRYXSlfsqafalBYJJ4HmjhXNdDLxYfjR6tEPFPjZl0vbjh6CMGPKJTgKta2vnMwaRy2TeX5zoU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(66556008)(186003)(2906002)(16576012)(316002)(5660300002)(26005)(66946007)(8936002)(31686004)(8676002)(54906003)(66476007)(6486002)(86362001)(508600001)(36756003)(6916009)(956004)(4326008)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YA7aZMWKlUbXXCt2rRTnxx83JNH0m5vRdTrTvhQrchcaMQb9vrHKGP6cccTV?= =?us-ascii?Q?gLko0+LhaAhr6iJHsd4H+PlzUx893594MzBlKzqZcCTPRI+4M9qTynWiGA8q?= =?us-ascii?Q?opgn3aHFkD7pVlvRJZ5Dg/eMe1g6bFcnBv1lqbU6tTPB9hzkGXB3xpRUrNYY?= =?us-ascii?Q?sCOj5kAV/d9SarNAiJzqQMzXHMGA0VJg7HmDikEdEsm+7bSeOhrftb+heygG?= =?us-ascii?Q?9lnLiA265gDiFa0ZmUr2fCxi5QeHRUeMDrVnSjcQmLqr1Ju2flQnsFq5rfgP?= =?us-ascii?Q?3WFh0iwZfEskoPM+CV1tP/WibDK0rzDCYfeCJj+cJAH2UxvCTP9/T38MWF6r?= =?us-ascii?Q?FZNDRAicTzMrXxa5KYlClsKmLShrZW7XPAr+JV3h8aj3yeZDu7t4P/9jo22n?= =?us-ascii?Q?7yd9q4POW7XFPVqQnP/rSlQFTvmY4MFCXCPP7OnGJKU8Ih1aKqlF0r1Dih4b?= =?us-ascii?Q?DJ6pEWousoibz6Q+dhY14YvdcUV4t8XQjGAHBmhAesIKR6Gjzze0j/dQCP5g?= =?us-ascii?Q?RGh2rmej+P5Rq9OiORZ4gHJ6ajstYq4YbRyY+6V80zIdyKa957z4uQ4NmKB1?= =?us-ascii?Q?FE3GYtjryj1F4ipObklOJ+Nh8H2F1PElbZNgQ5cTZSI7+nYpMdUnKVYPqfO2?= =?us-ascii?Q?E2zcvlQ/DZvRp4LEjurXODgx4MTMMPUrYOhQ7LNG9mxTUhjVVPyjfy6YP0Fd?= =?us-ascii?Q?GAtY7eIPeudmi8YX09VQvU039H6XpJDU+5BCTSZfof3BWAZL9XBPLUQ4GvYR?= =?us-ascii?Q?WIOK6SKtlq9ZxcbbRbi9VAtbfTWkkBLHp6L5XnQZF+/5Vgps2BEamQdMg0cR?= =?us-ascii?Q?g1ewePpXuU0bLNGSqr/iEDvfEJRton6knK7mwsHohdtLUy8s56NF2Q7osgqS?= =?us-ascii?Q?jnbidlRLOSvHbKlHA6X+297H2Y+0iPhm9xYFTmgWogEWMnogi6MU3tQlemEc?= =?us-ascii?Q?rJOhGLXrX3ORIwkRGWNfUGWNikYXhIP7icdJ5rsmsFvc0RyOjnjb3togSS4w?= =?us-ascii?Q?iKCL6ZTZOMwyqjy6nm1RZKMXhK9R+KczrShIaRlxqSnoVELrvJA33ckGuCxE?= =?us-ascii?Q?/a3G9rhzwXZ12kMA/nNna0M2r+aNv5zJ3bkFp+wV7Q8aGugCNDMeGVKLgJle?= =?us-ascii?Q?GchdShc+rqVU7087YvTp/PYJ6X9xIGXThML3ULZ4CR49R3CBt4ftXXIN1Py9?= =?us-ascii?Q?+jqkjhiyXlndZzstZxf858Y4PWGtNslCLaCdZRhN4MwL3b6GB+mS90iWBrj8?= =?us-ascii?Q?hxXCEwHAr3YKvh8sez/VbThEEppML3LsVThBmXe5tp3kX0PFYDT/pu47sEkf?= =?us-ascii?Q?nZs7J2kI5Ze2wm+6J8rUi9OY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: af689673-9a1d-4cc4-3b4b-08d9834b3356 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 13:15:25.7280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YwfY+YHvq24ey5gN3wokohBnbVGPQG1mVzl+v5YMfmCLCOHipZZ07vuN7qR82XMMxxEhi+F34ZTv7goRtOi+Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1632921353023100001 Content-Type: text/plain; charset="utf-8" There's not really any register state associated with vCPU-s that haven't been initialized yet, so avoid spamming the log with largely useless information while still leaving an indication of the fact. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- v4: Key off of v->is_initialised. v2: New. --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -242,6 +242,11 @@ static void vmcb_dump(unsigned char ch) printk("\n>>> Domain %d <<<\n", d->domain_id); for_each_vcpu ( d, v ) { + if ( !v->is_initialised ) + { + printk("\tVCPU %u: not initialized\n", v->vcpu_id); + continue; + } printk("\tVCPU %d\n", v->vcpu_id); svm_vmcb_dump("key_handler", v->arch.hvm.svm.vmcb); } --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -2133,6 +2133,11 @@ static void vmcs_dump(unsigned char ch) printk("\n>>> Domain %d <<<\n", d->domain_id); for_each_vcpu ( d, v ) { + if ( !v->is_initialised ) + { + printk("\tVCPU %u: not initialized\n", v->vcpu_id); + continue; + } printk("\tVCPU %d\n", v->vcpu_id); vmcs_dump_vcpu(v); } From nobody Fri May 17 13:26:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1632921372; cv=pass; d=zohomail.com; s=zohoarc; b=g7aJeKZkwqTHnA1tQf08zja1I/IXw5Q67vY0IHjf+ydBp7vJbkDbvSztPTyNBeYORtbAxKqdI79u9uHk6GXawBWbCP0iGjARp7q2Mb2n61t1cxR5pI8/JquwcR8fyiFiNDgH7v7aLNyInWA8zO1IUdM0/xCNZ4K2+p5qaq1f2dA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632921372; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=289UvYu1z6hhybJctb/uHf8lFebZQ7uBwKVUfRIW7tA=; b=MfzSBYa6gTpiQ85byXcrdfVgTi05/G7KU2g8sAEJoTecq7nEBewzJJRAbsufEXJtgahR7Ss+0N8qxubNHyC1KXnLiJI+TdqoRa2bb3MX78Tlac16p2fRWo91eflRnwHZ9bYUBQIVSqZsDLmmdtbqpe9OWB6KxKBfibZkiE7zv6o= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1632921372875113.48068441255941; Wed, 29 Sep 2021 06:16:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.199098.352949 (Exim 4.92) (envelope-from ) id 1mVZRE-0003FW-38; Wed, 29 Sep 2021 13:15:56 +0000 Received: by outflank-mailman (output) from mailman id 199098.352949; Wed, 29 Sep 2021 13:15:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZRD-0003FP-VC; Wed, 29 Sep 2021 13:15:55 +0000 Received: by outflank-mailman (input) for mailman id 199098; Wed, 29 Sep 2021 13:15:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVZRC-0003F3-Np for xen-devel@lists.xenproject.org; Wed, 29 Sep 2021 13:15:54 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5f78e1a6-2127-11ec-bcfe-12813bfff9fa; Wed, 29 Sep 2021 13:15:53 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-3-uBEukRGdPEi98zdElX4-CQ-1; Wed, 29 Sep 2021 15:15:51 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 29 Sep 2021 13:15:51 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Wed, 29 Sep 2021 13:15:51 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM6P191CA0060.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Wed, 29 Sep 2021 13:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f78e1a6-2127-11ec-bcfe-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1632921352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=289UvYu1z6hhybJctb/uHf8lFebZQ7uBwKVUfRIW7tA=; b=Y2/9WnbZflcsVK3/RcugaVUFAe+t95Az81fMM+8rCvFDQ+GjNPWcLgJbT3QU7zJAb6W+nD ZjMZBVeepWoukFyfud8vxSDIJt/Vmjpwz2pCJXCugGonOLjL8uP2bJF4A1uF+qfYyAn5eP j6AUnAKyg9yBMfWv/0J3m1/UTkTkU/w= X-MC-Unique: uBEukRGdPEi98zdElX4-CQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZTQ2Qo/kf5nIVak7nvHSIiGkONhIf6lO7Vfr/kFAPJ3sZL3H+wRrupGfpfuXQCHpeEK96ULyFMbaCtxcmoSRd7Q4dBUacBprvqiegLaGY9GRhM9ivNk2Of5qcgJHMlktJKgan41WprcINwANoqJ0We2xCNu7g1D1+Io0sW8Zuc0Ej6vIpl/688A3/ynQBbiI1r3OxMPk+Ref3t0XXHgzSAmFNXSYhDEla/Gx1dmQrPYaavCTNJ1iGPFmEvr5inx/XHw444JDE6CDEYLw7CmS5fD5yX19xkTWqkJ8vPpgVUr/Y067YCrJjtLcyhP4YRDHDc9Y0Qa0Stlx2vuiZ4RNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=289UvYu1z6hhybJctb/uHf8lFebZQ7uBwKVUfRIW7tA=; b=UpuLwH+Px761mS2wamIljFLDTjk6ivaXUPQUcEyEOmv0gq7qc3pQf4EqofHho/yTQf5k/5guaQunxloNhPBe3Usl0C5W1jnlLRanMGpmRIBquPfWuxsnTgqBCFo3uZS8zFKcUEg57sGJUYcL5+1MVQLVaEv+KS3qfVDvUGszO44nrziYRLwTdLqIs51ICajnmEp83zQb/vLxzrwe3HVxZ6LpmUSflx7WXYqTPxMzLAzhIxxkWtuUaCFl/blWsSvS9GQAVxTCzhRcZzf4GgBRad2on2zHwwKNEc78Df9tj4iF01K62fWfY1v7ohHVIQODwvtEPJYGgnkfZo1eM7dMdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v4 6/6] x86/P2M: relax permissions of PVH Dom0's MMIO entries From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: Message-ID: <4b8c48ba-a563-d036-d4bf-f4f8bdf0efb1@suse.com> Date: Wed, 29 Sep 2021 15:15:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P191CA0060.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::37) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80f1b0d1-d613-4907-1926-08d9834b4264 X-MS-TrafficTypeDiagnostic: VI1PR04MB7150: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TPRDrz6BCE3Jc+Eeoa8oNpdKL8tqpPF6k/XQFGBrsFDBk4qC6hsk53E18kYRqP0aH8vDMvTl4ejbAXJ5JhBxU+ef+AVTzSIIXfgY+6ZnKbctC9tiWuzuCsDRGWL1abdXFqTOTtX7zMT8oxVnA1eEVZbmHlrBhBXzihx/zivFlS7IoxNpH6uMFEQNHCQ4XP1ukrytH6rZtiDZHomabruV2H8VqWazqg4og+qiCBkLb3voCI2HBdDr5Zyrl1dpZENwdw6RU0/rh55wFSqgKNSeRPXuUChhy5vYJSekpH6RrVUiyhXygLcvV8dfGGaDFj32R3Y5eQ4Rne08rQA24rUeFMRiP0HJLx5bSOZrQEyQUe7x6zaajDdbVzFTjqYfVoa67GWWRevFmtKMDhdINRMPjQQldtV7sO/04vZXXfCd7cUUWmFFrxnOub5NIy/OGEgFC4uryPCvx6KLt/gDnb95BTt28JGZP3x0gQm+qblXBU9fl52EDtpLI7R1KbIiZgTQoIG9wsrKouRj17FAev5G6g4XczCkCcGbIdVBE7Eqnxbggq6S0ss7qHvoo1FIb3IV4pzfhyIAAj17JgrqSptN4rIFWyRGWQPViYCAiPPxLMXEHFgXtqMXV60dlgkm5087bGwoiZ1zbYlT942QaSdF6MzR1BiNb1EFyBErTgFpgMpjVCnweJDK5LUzNeJA9bEt16w5e01Vit5oGZE15QFAL2163oFyafShI11RVi1iBbw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(66556008)(186003)(2906002)(16576012)(316002)(5660300002)(26005)(66946007)(8936002)(31686004)(83380400001)(8676002)(54906003)(66476007)(6486002)(86362001)(508600001)(36756003)(6916009)(956004)(4326008)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTArcWh5WWJvUktxalhWeFNwcVM3eTdpNlFDaXY5U3AwVXIwR24zWnVGME9O?= =?utf-8?B?dVF1NlkwM2RrVy8xM1p6N3FOOWZrZUJJZGptQmNZcXZxZEM1bkNuczVCWmkx?= =?utf-8?B?L3FCckdQeFhmbHBaL0RWNmNjQ0RyRUdObjl5ajBSTmREUFNncGl1Um0yNVRh?= =?utf-8?B?TmY4bmZmYklmYURxYjhPbmp4eFROTzNNbXkvY2FYOXhUSi9xMHNxQjVVcTdS?= =?utf-8?B?dWUyQ2FZZ2o2b2oybEIxSDdVYm5rRTFTcExyTXQySCtnaWxqTW9RckVaNGE0?= =?utf-8?B?WVJEL2JQSitXMTNMdzNwY2xMSm80eVJrV24wd3UrWTYvV2xPNW1qbTdiYm1j?= =?utf-8?B?WmVTcXhlRVdneHNvUHVLMm8rZlJ2NHNWTHg0VlRjRStxT0d0SGFTL2huZ1FP?= =?utf-8?B?VEhrbklJNTR4RU51YWFqT0EvNTIrZEZiclZhN2pFQlhaaE9yTEZVSStqbG9Q?= =?utf-8?B?ZFRzY1IxcTJtZ2FRM0NLSTRHYTRqNk5lQzFvYWVjdW9KMU54QmxhcElzdkRU?= =?utf-8?B?ZS96d2I5cGlPK1BDL29MOUNDWEJVaXBuaG9jbkNjS25VTEJhSEZLNDBTTlhq?= =?utf-8?B?U1lSMmN6M09TRG9hWjBNUXZsMW9OOUZJTVQyUkJyZjNkdmdxQTZYcUtiYmhk?= =?utf-8?B?QUJFTk5yVjJpUlZPNGxoOS9idVovZUJaLytYVjcvM0FlZWRQWTNxQ05TdkJB?= =?utf-8?B?R1Q1c0dRV050RnVYbWtrd1B1eVFEcEdzTE0wZS93aEk1MzI1NzRKQnlaN09a?= =?utf-8?B?TmJlVkJGMWlLdFVXRm0zR1ZJcng1cjNJVzBwOXNodXFzaGU2b0ZYZENuWXRM?= =?utf-8?B?OSs0WkpTZlpVNmJ3RVBmTXFYR1AvOTJKZVhrMzNRWkZ3R3IyNm5mMlQ3Rjkr?= =?utf-8?B?d1RJZXZONk9Pb3Bab3ZQTG1ySFBZLzZPRzZkSGF0Z3Q2YS9mMVY1T2NxZFVs?= =?utf-8?B?R0Y5azhiMjZjV2lxNlp1QU5pOUJiNzNwTU1kS2pCUEFOZGhmaXJwMUtmTEVo?= =?utf-8?B?YXhEaCtUY0hoZFErVEd6R3c3Tk50SXdNUXFmTW9wMFhUOW03VG1BTERBTTNC?= =?utf-8?B?cHZYek9JMDBPNEUrRWszTXluMjV3L3FZaUNJZFpmWmQzWkxoR29mREo2ZFdv?= =?utf-8?B?OEZMRXJ2MGo0YTdmWi9ZMlJ0OVVqYjlpTUJyRFgzRkNhZ1FsM3IrL2twY3p6?= =?utf-8?B?bmJGMy9IV0lKNHQ5THZJby96TnhQaEVXOGNpWU0yei9CbkNqaU1Pb1RBSUNj?= =?utf-8?B?NlBQRCtWTDZuNHVRYlBnYTMxdWYwZUIyNHRuT1ZUc3dhZ0FDUkxqTkRsdldZ?= =?utf-8?B?amlLWkdtUzVGSSttNHRicjM3bDFpTWRwL2pHaVUvbmlLbVJhblVVUFo0Q1ls?= =?utf-8?B?VzNkK1EyNTIrMWMzZGdVN0djM2lMUi9xdW8vNkdiK2pSZm9QbndFaTZ6N0FU?= =?utf-8?B?UStDVVk1cDVvU2VOQkVNem02NHR5MC94Nlk4KzdvYUZ5dmZtZDRWVHc1d3k0?= =?utf-8?B?dE1ZcTdHWXdkNlNaa0ZoRlBCbyszb2FiWEJkWXZOV1h3bGExallBcVRWeXVM?= =?utf-8?B?WjZ1emR3ck5YNFovejBtaVltMmFiRGhHM3lYclp0WmdEZnBXeU5YdXcza0ps?= =?utf-8?B?TVRIMkxwbnlNYWpLbjFsUXZWemxIUEljWFdoUDEwTWIxMStpTDdkZ0p1ZVNx?= =?utf-8?B?K04vVktBZ0J6QmwyZVJuYWc4bnlpTGhuVU5EaXhtODRIVTR3UCs4TW5wOWww?= =?utf-8?Q?fNq6leKW4YGiCCSuAPUgfYyOBPHbaotNynNAX75?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80f1b0d1-d613-4907-1926-08d9834b4264 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 13:15:50.9967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9HJ4sRWrMZc2S6To2MvFLOtPaXfT5CH6tecAqvOr/mZF7RBc4ieRZ9IE3Fwd7xY/gPkYcMnE8frKGws3GoLcEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1632921374797100001 Content-Type: text/plain; charset="utf-8" To become independent of the sequence of mapping operations, permit "access" to accumulate for Dom0, noting that there's not going to be an introspection agent for it which this might interfere with. While e.g. ideally only ROM regions would get mapped with X set, getting there is quite a bit of work. Plus the use of p2m_access_* here is abusive in the first place. Signed-off-by: Jan Beulich --- v3: Move last in series, for being controversial. v2: Split off from original patch. Accumulate all of R, W, and X. --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1319,6 +1319,18 @@ static int set_typed_p2m_entry(struct do return -EPERM; } =20 + /* + * Gross bodge, to go away again rather sooner than later: + * + * For MMIO allow access permissions to accumulate, but only for D= om0. + * Since set_identity_p2m_entry() and set_mmio_p2m_entry() differ = in + * the way they specify "access", this will allow the ultimate res= ult + * to be independent of the sequence of operations. + */ + if ( is_hardware_domain(d) && gfn_p2mt =3D=3D p2m_mmio_direct && + access <=3D p2m_access_rwx && a <=3D p2m_access_rwx ) + access |=3D a; + if ( access =3D=3D a ) { gfn_unlock(p2m, gfn, order);