From nobody Fri Jan 9 09:30:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766509371; cv=none; d=zohomail.com; s=zohoarc; b=jSj1W2OYJwgiY8kU8T/eyo3tSANCLzamdze1Gi6nbL6JmOD5pQPJoOfgklHg0eeRHc3WNLLfEJyW+/Qr1NqK2lc/6l2AouBL6c++ZFppQxyn8udxycYTTA4F4zLBTtxAu7TmkW1XoXkFIrk0fr56eWe2K266CgyyV0wGtJfBfKU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766509371; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=j+aOZqII5wc7BowuwzDWz84yJZJIh5yD9oqK8sJIWHU=; b=c89155QueiuFw8+dKc519F3931RZsrx0xwsyJui2gIrXRUkoWckpmoY3zcNq8wsNAZEhLdu5Dv8cRUhUDxHe3Y8XEPiOctNwu2TtoychbrBTQH9YixG02ZuXvGJW+VuTHz7TSWZD4DXiazVQ1i3glYY62N9Kw4/61HbFsddpfPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 176650937183287.72264667754177; Tue, 23 Dec 2025 09:02:51 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1192706.1511836 (Exim 4.92) (envelope-from ) id 1vY5m0-0000z0-MA; Tue, 23 Dec 2025 17:02:12 +0000 Received: by outflank-mailman (output) from mailman id 1192706.1511836; Tue, 23 Dec 2025 17:02:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vY5m0-0000wu-Fy; Tue, 23 Dec 2025 17:02:12 +0000 Received: by outflank-mailman (input) for mailman id 1192706; Tue, 23 Dec 2025 17:02:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vY5ly-0000rG-Uu for xen-devel@lists.xenproject.org; Tue, 23 Dec 2025 17:02:10 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1deb8b92-e021-11f0-9cce-f158ae23cfc8; Tue, 23 Dec 2025 18:02:09 +0100 (CET) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-b7a72874af1so895079966b.3 for ; Tue, 23 Dec 2025 09:02:09 -0800 (PST) Received: from fedora (user-109-243-71-38.play-internet.pl. [109.243.71.38]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b80464e01d9sm1306260566b.42.2025.12.23.09.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 09:02:07 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1deb8b92-e021-11f0-9cce-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766509328; x=1767114128; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j+aOZqII5wc7BowuwzDWz84yJZJIh5yD9oqK8sJIWHU=; b=U34azGk/kIgqoN9JkWzmgzoKsBiDc7dEhAqgDq3eLJ0XGidpV0OPA/KZw4EEFpY1c2 ZJh3OPdv7NDREITZiHsPwBEuv+7RfU9+lO8QPCavWAl99wIMZXDOzjHMrj7VwTIbw2rA aCP5ynArzqbMqVH0g7SmErqfRZU8aPGuNyWVL72hyypTaOqik1w5UX+B7ukjEsyJyZbv t7HfpPemI8ZWxTE3XWwZE6RdHpNMO1PHYODBniL+ABATBE9li63Dxo2rvfLpahftRVi4 V6B0PWpHuJphxFr3LJNMOCxJxkTyjfBFM7pPLJBjghfjICCHQZsi6wR5DmUI9UxSVxF4 8RMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766509328; x=1767114128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=j+aOZqII5wc7BowuwzDWz84yJZJIh5yD9oqK8sJIWHU=; b=wCiuPX3+9LK+g0v7dDHAhXfhS0ecS9bZm7kuSsVQiYhIPuulkc8DaYwFTUh9M71F25 ZTBuQ8cnad092Tc2mhojs99RR4SavZPs6OslqmJSAFtzTUIHEgTgXpEMZDL2Gz6HWtxN m+NCKdU+vXj1AQG8xdDeXTWRE71z7J91eWy46DLOpTf/0yK26+cd3l9yDNP6rN6UDLsB 29I1QCjU5suH0gzhDvLrP477HeOzCDyTaMFd5UapRTChGSJZk3ZfD5ba8B4DOcYuKV7L yylWHhM+CCX63QpT8brxPcnG15bKXZa0f4uVsncKvbHGqaAizk9OFqGEmXtK0ZeKIrvX Beog== X-Gm-Message-State: AOJu0YzymtpaxbfcRT9v2EKKAKUX5VP3NuCbzLUjXD9LODGMysyEfxG0 zsMslP+6YYhPd0VwCZH4QDGqEgojp4n4LMClolxpzsKc38oldM7UoiLcJDnGBA== X-Gm-Gg: AY/fxX6tu9i0Pw6KJ32Ayq7N+qOt+Rj/ZTmSEjxD73GspyFoLA8INtID9K9zzB0NF+B UWHfeg1OW/bTzn8gw3EilCIG8TM/2UguAVIer/SR4aK/rztLXmlrNpzV/P+M9H++H6wR2PB1hoU BDxJK8i2hi0bkEGQCWbOBQvkH5WpD+p3uVFpOTKZP8R8QdU28HzxOTBLNvihu6Dcta+TGt8ntcl do+G1w00wHFY505xGBoh5GaNx+XyxNsWSPIL0E++mjtkCkFbnG8ghS1GxPDxnA0A3ATqOhzlxLT eL1omuHrMJpzBDm5koElykmpWBiwoyF1QVF/JxxXvFHsk3s21bIn3AHI3ROmDEfs0LYcJBYdoJQ 1pj6NqnLLxIvqYQsuweU8L+TPMJnf6Ce/CcVZB8ChF8hdGjiPff2vaQkt9UJd21Rl2hhiSBRPKk xDIVrMS6rHxCGK7ZLKTj8rBBfjL+/XQJvAaqpcYlRZ/SLstDbMLdde1w5unfjawnNXbA== X-Google-Smtp-Source: AGHT+IFdBau6LYw66LiszAsIrMwHExSX3yPph04NnwJrpcy0HJbAmKM1EnTblHaCRBYBx5YCL/+Qzg== X-Received: by 2002:a17:907:1b0f:b0:b76:d4d0:68da with SMTP id a640c23a62f3a-b8036ebaaf1mr1435816066b.6.1766509328037; Tue, 23 Dec 2025 09:02:08 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper Subject: [PATCH v4 1/4] xen/arm: vcpu_vgic_free() updates Date: Tue, 23 Dec 2025 18:01:55 +0100 Message-ID: X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766509372222158500 Content-Type: text/plain; charset="utf-8" Use XFREE() instead of xfree() so that vcpu_vgic_free() can be idempotent. With XFREE(), vgic_vcpu->private_irqs is set to NULL, so calling vcpu_vgic_free() a second time is not an issue. Update the prototype of vcpu_vgic_free() to return void to satisfy MISRA Rule 17.7, since the return value of vcpu_vgic_free() is not used by any callers. Suggested-by: Andrew Cooper Signed-off-by: Oleksii Kurochko Reviewed-by: Andrew Cooper Acked-by: Michal Orzel --- Change in v4: - Add Reviewed-by: Andrew Cooper . --- Change in v3: - New patch. --- xen/arch/arm/include/asm/vgic.h | 2 +- xen/arch/arm/vgic.c | 5 ++--- xen/arch/arm/vgic/vgic-init.c | 4 +--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/include/asm/vgic.h b/xen/arch/arm/include/asm/vgi= c.h index 31b3d3e5ec5d..6f9ab1c98c1c 100644 --- a/xen/arch/arm/include/asm/vgic.h +++ b/xen/arch/arm/include/asm/vgic.h @@ -418,7 +418,7 @@ int domain_vgic_register(struct domain *d, unsigned int= *mmio_count); int domain_vgic_init(struct domain *d, unsigned int nr_spis); void domain_vgic_free(struct domain *d); int vcpu_vgic_init(struct vcpu *v); -int vcpu_vgic_free(struct vcpu *v); +void vcpu_vgic_free(struct vcpu *v); =20 void vgic_inject_irq(struct domain *d, struct vcpu *v, unsigned int virq, bool level); diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 3ebdf9953f07..6647071ad4d7 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -390,10 +390,9 @@ int vcpu_vgic_init(struct vcpu *v) return 0; } =20 -int vcpu_vgic_free(struct vcpu *v) +void vcpu_vgic_free(struct vcpu *v) { - xfree(v->arch.vgic.private_irqs); - return 0; + XFREE(v->arch.vgic.private_irqs); } =20 struct vcpu *vgic_get_target_vcpu(struct vcpu *v, unsigned int virq) diff --git a/xen/arch/arm/vgic/vgic-init.c b/xen/arch/arm/vgic/vgic-init.c index f8d7d3a226d0..aef526f2e717 100644 --- a/xen/arch/arm/vgic/vgic-init.c +++ b/xen/arch/arm/vgic/vgic-init.c @@ -239,13 +239,11 @@ void domain_vgic_free(struct domain *d) dist->nr_spis =3D 0; } =20 -int vcpu_vgic_free(struct vcpu *v) +void vcpu_vgic_free(struct vcpu *v) { struct vgic_cpu *vgic_cpu =3D &v->arch.vgic; =20 INIT_LIST_HEAD(&vgic_cpu->ap_list_head); - - return 0; } =20 /* --=20 2.52.0