From nobody Thu Sep 24 19:40:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788958777; cv=none; d=zohomail.com; s=zohoarc; b=lQt/JKYqYADSC/z6NvWcJc3+qu3UMCVrV6fub7M/SHokyD2awkF0bc9HhnTrHIfPV69CLOA8w86GIF+wrPXHnX9nYawmXzlTiytYnJpYLKp2ffCbyBeiGlDGEc965VBDIT1Zm4yFMPU5stMQTzjN8FLNU25d/WHzeN3KLNf8rqk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788958777; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=w7BwYGLPgsKXy885hcRpE5vhEVrFLgWJ5GO8dwiELeY=; b=GUcmtdUP8YllDnTPmQlwNw998q/ZBDRmQfD7a3zU6sfBX4nVEI1iVE3NAaL/oUwRq9jCcxwdiHqZgBvrJ3zSqOxCsv8X/xLGooIJa2ScYsD959I8+ir4HqHsUNBLy39iabZSfNA5VYIKcJ5Mw0V8PByOuyF6kWKAGRMV7rFfKcY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788958777729407.37588842848527; Wed, 9 Sep 2026 05:59:37 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1412990.1643267 (Exim 4.92) (envelope-from ) id 1x4HtX-0005BA-0Y; Wed, 09 Sep 2026 12:59:19 +0000 Received: by outflank-mailman (output) from mailman id 1412990.1643267; Wed, 09 Sep 2026 12:59:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4HtW-0005B3-Tz; Wed, 09 Sep 2026 12:59:18 +0000 Received: by outflank-mailman (input) for mailman id 1412990; Wed, 09 Sep 2026 12:59:17 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4HtV-0005At-Dx for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 12:59:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x4HtU-002MF2-Qc for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 14:59:16 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aa1581b-bab6-0a2a0a5309dd-0a2a4504854e-16 for ; Wed, 09 Sep 2026 14:59:16 +0200 Received: from [209.85.221.43] (helo=mail-wr1-f43.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aa15824-b57f-0a2a45040019-d155dd2bcd3d-3 for ; Wed, 09 Sep 2026 14:59:16 +0200 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-48441a2ba14so4887665f8f.1 for ; Wed, 09 Sep 2026 05:59:16 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485883c074asm42807935f8f.23.2026.09.09.05.59.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 05:59:15 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788958756; x=1789563556; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=w7BwYGLPgsKXy885hcRpE5vhEVrFLgWJ5GO8dwiELeY=; b=ZIFov2F7D+xg/PTLsYfAMzErJlypSh6sXh5wgI6N2CyXZyS+19lE+aCVL3vRyDTsIF OyTTAWJ8hO+L9gRKpmsRCDWpQphi7+N5ybApfIElfnI8JmZ6pZgCvNoKFxf6HHWRRBKo iYz+HDSv0DS91ruPxPpLNqBHUm81m6VBw53MLcDV4cxsbR6H+CvHspt7UeFFJHtixmtV 0HCH4O5GDv+KODTs3x/jWjfXH/DJvo1U82E4kMcMCXuEEmavWNjtlQJu0ztcnVgEVceM nAb5ORGMhcgyYKzGwMUgRFhi7S0zTnp4qY++TSo+e2x51KZNXtxbpTjOA7xOePHf1O2v LBmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788958756; x=1789563556; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=w7BwYGLPgsKXy885hcRpE5vhEVrFLgWJ5GO8dwiELeY=; b=aHd0lMUVH/IDPq8J1gY4u0XIjzNgqSHZ6VYGTiICkEKPvxbF4mxIWHlp/7UWZbGENy qL9p0jq5YDi4mi3O09O+7zkFOiSyMxbO7mNBWNsNRxKge2S1FZgaFeBqATjlb0bbd+AT GATXa3MAMcTUQj+UBUTIKGN9HjfaeDizHWXI0gm816QK4/ZJ40OE/RFuy3iszozqfvfR ZHGsVWY39PA/CRcJnqEX7OcFsOnStuc+iDDS9gncoPaKU8M1ujphZWUnl4eVd4k7Mgug KBz4U1CpyeV4yXg6gI11JXToHDrbWKTbCZSyZobK3ThsnUr6Odna7c8J9pccMGiONESp 5diQ== X-Gm-Message-State: AFuF++mXce3uup0C9WyJ/aQcAlnfNjbnWdhtBbHnQTPFMpRp6IQdeWZg j+HJMj+9CKrqnd1Cwm4E78PGJTN1pq7OzgQl05mp4avcbrIne8GS9J+OV3rZdJ/Ah1st3ZReVzr 0TrNtvQ== X-Gm-Gg: AYBFou2imAfbChjSQ2ZpN441X6kt8eT0IOlWnkuQUIOlXq2bt1BpMQuV7kU0xKT7XHJ /bCIwLPoeFtEC4qh5gCr/6ac1navtScLFcU4ZN06GBJwPttXVioxRp1GjWeNv+uGeoi+Rrkds9g +PmLIORj3oRmL/MDSsbD/U5nVrt+YRVHuKMLLjAJcKnmFXmixbhI0z8679Dc+tgwND+s8PBS3DA 82dESpjP8C2Vx7rS+s7j2GHcRtLsUxd3aDerkqVcdGuRbO7nJx4HbmxtKyTKSqzfoJp4RtYMnpP 438MelZkHCxLJ5XO/ZjI9kkqevcvBnAeyg/arn2f63LMnoKtsu85rnltlspCbi4uG7f5s24hpGY nHrkNwjqwpoe6x2VjU1HEC5brZl5iay0+trNQuNCBocyVTB0u/wITKDkK7cB+BGlMKMrI7oocDM pifF9cIUb/WfA4nOP8M6pbxLxduQ6MW7WpDnyiyPEtMSnhGUB1kZ88SAHJXPUhzS8iUQD/1Imsu qEz4smBjYtBo5t8qgJH7Fm+aDdhb82LsA1Zkmjmm19UU2IcvGXfD92hQWV6PGc= X-Received: by 2002:a5d:5e09:0:b0:485:956a:1607 with SMTP id ffacd0b85a97d-485956a162emr22560186f8f.40.1788958756180; Wed, 09 Sep 2026 05:59:16 -0700 (PDT) Message-ID: Date: Wed, 9 Sep 2026 14:59:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/6] x86/PV: adjust APPEND_CALL() to comply to Misra rule 18.2 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Nicola Vetrini References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ebf023/1788958756-583C0B50-2BB92F9C/0/0 X-purgate-type: clean X-purgate-size: 1268 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788958778506158500 Content-Type: text/plain; charset="utf-8" While casting to pointer types may be more natural there, the subtraction then ends up violating "Subtraction between pointers shall only be applied to pointers that address elements of the same array". Use long arithmetic instead. No functional change intended. Signed-off-by: Jan Beulich --- Depends on "Eclair: relax long <-> function-pointer conversion deviation" to not introduce other violations in turn. --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -92,7 +92,8 @@ static io_emul_stub_t *io_emul_stub_setu #define APPEND_BUFF(b) ({ memcpy(p, b, sizeof(b)); p +=3D sizeof(b); }) #define APPEND_CALL(f) \ ({ \ - long disp =3D (void *)(f) - (stub_va + (p - ctxt->io_emul_stub) + = 5); \ + long disp =3D (long)(f) - \ + ((long)stub_va + (p - ctxt->io_emul_stub) + 5); \ BUG_ON((int32_t)disp !=3D disp); \ *p++ =3D 0xe8; \ *(int32_t *)p =3D disp; p +=3D 4; = \ From nobody Thu Sep 24 19:40:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788958806; cv=none; d=zohomail.com; s=zohoarc; b=aMpdJ+53wvCnWXlL3Zu440wxzQH1dIzzdkDl7H/4elUe3rQrOn0jyP0LM3ulN2DIiUZYojBdW0G64oZlRaA3OqBVL7+/kqwMmYj89avi4gt/vHpBT72AxPuEC5SCmYuzG+sL9C4fKZnMcSdJ9WExOHO265eCgvGwRhi/n621Nyw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788958806; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uiDbqnQFDxQWBEQL3jORPSdEhXKfJVufeVtoG8lnjEg=; b=Rx/5Na7EbZpufLXz/KOIsFLgCf6/aFWdOkGDq21g1j3R+RCVPC0USeTxn+kXV72K27RGW4gns8TXxIp44p112jAAU+TAVu1cW0Y6/wFsEF+mmnDuwx3khzmUvcL8KaOSSyD3h8CzK7UQxSJG/UnSG0GbJwXS3O3FntcN0iHRfBA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 178895880679572.54789139538093; Wed, 9 Sep 2026 06:00:06 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1412996.1643275 (Exim 4.92) (envelope-from ) id 1x4Hu0-0005e8-CW; Wed, 09 Sep 2026 12:59:48 +0000 Received: by outflank-mailman (output) from mailman id 1412996.1643275; Wed, 09 Sep 2026 12:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4Hu0-0005e1-9l; Wed, 09 Sep 2026 12:59:48 +0000 Received: by outflank-mailman (input) for mailman id 1412996; Wed, 09 Sep 2026 12:59:47 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4Htz-0005cc-IQ for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 12:59:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x4Hty-00Gv9n-VD for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 14:59:46 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aa1583f-8faa-0a2a0a5109dd-0a2a4503c250-14 for ; Wed, 09 Sep 2026 14:59:46 +0200 Received: from [74.125.225.76] (helo=mail-wr2-f12.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aa15842-fae8-0a2a45030019-4a7de14caabc-3 for ; Wed, 09 Sep 2026 14:59:46 +0200 Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-48583cc7ab1so106229f8f.2 for ; Wed, 09 Sep 2026 05:59:46 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485883be709sm43699951f8f.21.2026.09.09.05.59.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 05:59:46 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788958786; x=1789563586; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=uiDbqnQFDxQWBEQL3jORPSdEhXKfJVufeVtoG8lnjEg=; b=Lw09bTqe/xiZX42hL+FofneeuaMNodhqY0csMH3ksA51qkGa+unXfcski+Se/MdECN 4RyMbIUouqQ5FZGpxR0Z+fTjCgq/8tJ4dYTN18+jWAecAM+LbZPbRgE/kJLqhQKtO4pD ZRc2qzhZpFYBuv5+C/aojnMalQzCG6qefdftbO+NFoGFaMlJ9cZn+EOUTV0T/W9aAbPo l9uwC+V2TyTzXceSfJ47ODpKQqssBFrIpl0+Be8orGA1qGfCbscnFo7nb4/9q7fjkXw+ xNuc5e8kIsrZk3x+bhBqZbYQcdWPRuqWR7TAFMxdNxzAkizizHiZbygS0Uc9zDyuKc2U lSeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788958786; x=1789563586; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=uiDbqnQFDxQWBEQL3jORPSdEhXKfJVufeVtoG8lnjEg=; b=SQOBMkCg+l0Nl+a71a99Jc8zBRLBp3eItrEaeUQf1wk9aup3ZGAr0SDlxfpbptSppR TKBcet4oQEt7g28OQgJcO8+Knx9ShimYmqdt7RPSSMOYEvEON0WBds/D5Q++vqLOIvSX 1qCSbCu3QMAN/a/0VCkstRE0NtFPq+4t9RQvcIDQBQK9vYRmIbIXWO6i18eiO9u/7Rou FxUip0WDgnk7uCrC3s2HYK+eVo+kA0/GlaHD/t4pWK5UOjXYXO4o2c1ydLaLOD/3DtrD bUJ0wTPm7mO/oqclV9y2Ex3HKLdg6+v7Fopblq2bxmDGHlWsJj6crSatjaZYp6P6X5/A GdmQ== X-Gm-Message-State: AFuF++myn5cpsYvXUGSAy2t+DFwPkg9YSzR3MJfgECEwv2KoW0AsReQB 6dj7PCHqa8TL3jEDN8gO2DUvswL1k1TkGzCYPj7PUv2An8MToa9viM0cp7lG0rpnzD95kCvIBGw +Rk9apg== X-Gm-Gg: AYBFou130pG8//s1bD7/ixiLYFBYt2tsbr/lKgLGio539Deabafz+ehK5MjG/4pZNcm YfXddFBD3jQZ46OlGSJ9c4gGEXPcA888jZ2CEWCZCu7nz4SupINag08y6xGvJh1OdX/129mreEg p6b1DeLw/fBON2lvHbMdKIEGa5if4VAqf6/8YZgyV/60Q+gIpKiurIQwAKWEDQl20CPjN67y3he DpQnANCXl5bOYW86l5+HDcgZU1yJcy/58JyohobP4+aBJ7pmM03GwKFZ6grLZbkfKiO+fwjdhOR d3gJKKLVeztz7f8O/FmHmiSLOYCc+lIQ9IdUaiwKg2UTtMoJ1o+dEySyiqPv9MZFOvXgyrAgSHt BCOWzILS/RV+r2gkxluRRqF8T8Swii/6FQDrhZGnGFgwfkitdfRD0/KK36Ia2gCbsvlXG2EUURF TeL9Xd7MP70JUhRmRDuOCCcORCUnMzfXfABpq3SQSnYGpIJmJKjuNfPs5ij8sxlgqJeD8qwWYEy g2J9MGA59GFkWwwkAxNryaZ+jm/cNGuyA0X7GRAQdrDdMI5L2bAgMHPA6dTxfo= X-Received: by 2002:a05:6000:400f:b0:485:8a47:5b91 with SMTP id ffacd0b85a97d-485c24042e3mr1415613f8f.46.1788958786307; Wed, 09 Sep 2026 05:59:46 -0700 (PDT) Message-ID: <6e503818-3446-4bdc-8b65-d61169667b7a@suse.com> Date: Wed, 9 Sep 2026 14:59:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/6] x86/alternatives: adjust _apply_alternatives() to comply to Misra rule 18.2 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Nicola Vetrini References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1788958786-756834E9-296AE92E/0/0 X-purgate-type: clean X-purgate-size: 1138 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788958809166158500 Content-Type: text/plain; charset="utf-8" While avoiding casts would be preferable here, the subtraction ends up violating "Subtraction between pointers shall only be applied to pointers that address elements of the same array". Use long arithmetic instead. No functional change intended. Signed-off-by: Jan Beulich --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -342,13 +342,13 @@ static int init_or_livepatch _apply_alte =20 /* 0xe8/0xe9 are relative branches; fix the offset. */ if ( a->repl_len >=3D 5 && (*buf & 0xfe) =3D=3D 0xe8 ) - *(int32_t *)(buf + 1) +=3D repl - orig; + *(int32_t *)(buf + 1) +=3D (long)repl - (long)orig; else if ( IS_ENABLED(CONFIG_RETURN_THUNK) && a->repl_len > 5 && buf[a->repl_len - 5] =3D=3D 0xe9 && ((long)repl + a->repl_len + *(int32_t *)(buf + a->repl_len - 4) =3D=3D (long)__x86_return_thunk) ) - *(int32_t *)(buf + a->repl_len - 4) +=3D repl - orig; + *(int32_t *)(buf + a->repl_len - 4) +=3D (long)repl - (long)or= ig; =20 a->priv =3D 1; From nobody Thu Sep 24 19:40:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788958839; cv=none; d=zohomail.com; s=zohoarc; b=fQ0Ww+PVHUZuzVG35KtEAVFQ3R5PtegH2kYJ2IePlqbICPGPMOT1TdPwy2lAtXhrbV65APXhJySLgLo6yjn9vJ9viGjpbezcttYKRgAb9UyNp/3YpI9h1h4XshOxaZZwdPg19dsFpUNdkhaRsXUJes002zuf2qENyl66o4tYw40= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788958839; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bWlSSzoVmVaek1Pzh48/jWlFrsNac/GAHMWoEX91Hj8=; b=inDxPsyfkGKIKu+p/BmaMyblfDLu1kz2xv6al0Shd/iGq6wKFMh4royNa1gcVpkbK1qSkMQU6VlhhiUDefMosvQgQsxx13Lsm8+CiXQtYZ1oiJwuVRyJpYWccaFoa8yEXz4xIQ7iegY32WjdXgJPA2ULiyN6DxgkH7Lbj3Hu9hk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 178895883983527.2219484723272; Wed, 9 Sep 2026 06:00:39 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1413005.1643284 (Exim 4.92) (envelope-from ) id 1x4Hub-00079R-Kg; Wed, 09 Sep 2026 13:00:25 +0000 Received: by outflank-mailman (output) from mailman id 1413005.1643284; Wed, 09 Sep 2026 13:00:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4Hub-00079K-Hy; Wed, 09 Sep 2026 13:00:25 +0000 Received: by outflank-mailman (input) for mailman id 1413005; Wed, 09 Sep 2026 13:00:24 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4HuZ-00077o-Uh for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 13:00:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x4HuZ-007Z4F-BH for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 15:00:23 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aa15865-e002-0a2a0a5209dd-0a2a45048c36-12 for ; Wed, 09 Sep 2026 15:00:23 +0200 Received: from [209.85.221.48] (helo=mail-wr1-f48.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aa15866-b57f-0a2a45040019-d155dd30ec60-3 for ; Wed, 09 Sep 2026 15:00:23 +0200 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-4858be8b509so2614034f8f.0 for ; Wed, 09 Sep 2026 06:00:23 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4858e239862sm38385950f8f.9.2026.09.09.06.00.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 06:00:22 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788958822; x=1789563622; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=bWlSSzoVmVaek1Pzh48/jWlFrsNac/GAHMWoEX91Hj8=; b=BAKaWvRFLX83BoeutOQIaqvh9Sy7KER39lULuFuDn+3jpfF+1OF9rOeNMCi0CmyO3O yVyUE81UtbmRVO0GGthdzvGuKjTgTl6tij0HU8y4KDVRq8bfBJEkHIo3EyOHIzwaxcTl 78aqslXjG/q7WBsGudUjFHLk+0kxK9w/02oJD3wX09GE0VEwjMQuKrtqR+VadOd+mwmO HRDtlTqNQlpecNP3pU3koPc7sBiEndxWmoSwsIFzPlMTR7HF/jfOFSvlVSs69RuEpJRk 5er3jTsmxDT2RNerURMkPMkeyPgsKEiRgKLTaTsRrEaGhmXYsAg0d9dSSm4QbYkTx/0O A1dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788958822; x=1789563622; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=bWlSSzoVmVaek1Pzh48/jWlFrsNac/GAHMWoEX91Hj8=; b=eTlT7sq4nAU77Q0RAUQSq+r52Upfvk91nmJinziVmvSscdPKiNCtyoqe7724ZW+mqj bNkqTo89ebJUZFJ7IDXcqZPpWR+A8uYtpAHQzqDN6m/pEN7tVBACALjlYEfbvxifXkrh Mo4cXE+6i08YKntXsrQmL1j2+wGJ04o+Q3cEsf0YdCAtby4k6X6l7KtYTC1vhoPQNG0e lLq89vL2cD8AH0YSOMLJDS9AtBNK7Xnmhp64rtAZY5+1O8CT9ctI5CdA5s1006ZW+x9E NiYxpBOmHAzNPXbuIbjWZ2W4FQGo/6r3oV6TcAp1Blqt9TmDwueuOGe/Wkp4UbZvh0vT Z2CA== X-Gm-Message-State: AFuF++k+GbxGDRXXpB9uXT8XAh17PjYDyZgSLa9sVRq0iSGwdH7Zxq4Q Oox7xwAOX26Dfqg1ScqwjdsGqrq3oeLVnW6f390llKtKyDrLIBRtSsx2zudmJH5ujF0kH9jbdiy 5muW0MA== X-Gm-Gg: AYBFou0bJCrJoNyTonBVBcvAdtbOlYToRry+tvVjJkGehCguTA5/DonXglhdgVVE2V9 QjfeKcSnhX5YwVP95yUBNDd5/1D1ozg+sbwuQdeG70ztTTfiHesb6xIal6JUIh7kQAG87GbTRTp dJSb5PnQlJ51+JLhXGlokuSbclNETqTH1x5yrjCGOsUe5AmbnQcCJQlkUMt3bzvgY57NpEKrodz tKWgPAvD8Z2++j2tclEcQ0nPVihFlsYCNKIAkBJNejRXYtlSRaCeoJqUmuAiud0jQ/4IsFEsCBD er10lyT5YqRHt3ECdxByVnf6b0yF3TCqWHk2p7Mk6nUewXLHYKpgJ5rEXpTbecY0vaTY20kPEbT S7hPlj1RvEqUH4h7rebwwgcSG4nTSw1zRaam3L8ccQGz0sA0xDgiGq4ZAAsjMmPRjvnMRzTTp6A /FQDwDCJAulZeL+ysQ65PDnCKxWCAInOoBhsH4AqfO6tqunX7qFxPOVhEaaUz7ZSO6tpA9Td0hX zSHKt+HeDa9GPANYQPuNsc6txIpYyaFU7FmfJpub1QnUvuO1af+bYn+tGPV2ycx X-Received: by 2002:a05:6000:985:b0:485:8b95:706f with SMTP id ffacd0b85a97d-4858b9570c4mr30979983f8f.13.1788958822351; Wed, 09 Sep 2026 06:00:22 -0700 (PDT) Message-ID: <25c71873-9043-40c7-a514-c7cd557f91d1@suse.com> Date: Wed, 9 Sep 2026 15:00:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/6] x86/EFI: adjust efi_multiboot2_prelude() to comply to Misra rule 18.2 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Nicola Vetrini , Marek Marczykowski , Daniel Smith References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ebf023/1788958823-C38C1B50-5EB107AA/0/0 X-purgate-type: clean X-purgate-size: 1446 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788958841668158500 Content-Type: text/plain; charset="utf-8" While casting to pointer types may be more natural there, the subtraction then ends up violating "Subtraction between pointers shall only be applied to pointers that address elements of the same array". Use unsigned long arithmetic instead. No functional change intended. Signed-off-by: Jan Beulich Acked-by: Marek Marczykowski-G=C3=B3recki --- a/xen/arch/x86/efi/mbi2.c +++ b/xen/arch/x86/efi/mbi2.c @@ -13,7 +13,7 @@ efi_multiboot2_prelude(uint32_t magic, c EFI_HANDLE ImageHandle =3D NULL; EFI_SYSTEM_TABLE *SystemTable =3D NULL; const char *cmdline =3D NULL; - const void *const mbi_raw =3D (const void *)mbi; + unsigned long mbi_raw =3D (unsigned long)mbi; bool have_bs =3D false; =20 if ( magic !=3D MULTIBOOT2_BOOTLOADER_MAGIC ) @@ -22,10 +22,10 @@ efi_multiboot2_prelude(uint32_t magic, c /* Skip Multiboot2 information fixed part. */ tag =3D _p(ROUNDUP((unsigned long)(mbi + 1), MULTIBOOT2_TAG_ALIGN)); =20 - for ( ; (const void *)(tag + 1) - mbi_raw <=3D mbi->total_size && + for ( ; (unsigned long)(tag + 1) - mbi_raw <=3D mbi->total_size && tag->type !=3D MULTIBOOT2_TAG_TYPE_END && tag->size >=3D sizeof(*tag) && - (const void *)tag + tag->size - mbi_raw <=3D mbi->total_size; + (unsigned long)tag + tag->size - mbi_raw <=3D mbi->total_size; tag =3D _p(ROUNDUP((unsigned long)tag + tag->size, MULTIBOOT2_TAG_ALIGN)) ) { From nobody Thu Sep 24 19:40:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788958868; cv=none; d=zohomail.com; s=zohoarc; b=TpVOEadPHrS8g7MWX36pSYxjTMK8LkSP3+uO47Uoik/mX3y8c+8hYKVDJ90QwLWH0d4hj/OxQw5y3cx6sJvxNAEVx9F4Jdb8bZJCoR39hARxcaKigSs3ICwe+FjKG4BzX94zpfbIAukD7AAlQqtHlhp1H2Gi8GzJ29l+MRGYMJ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788958868; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2hiugmH/DfrkMOq2Rrm79IM9Vi54MWLDW0uP3xzNUMw=; b=XtU9ZEk1YXLt5zK6O6CWdBVHnqt0WKzTkKcDvOfFPVuLUU22mn8Xnw1hJGU161MJviZJoLin5lkYe/uO5ta3Ptk9L2lg6PFklqHst4ZlZnwkxZc+lfWyS/7VGrCeu9kqWDitsX+jizeWTHq6RK1vCeIAe8xzx5u+P2Kd4W00F6I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788958868639637.395399205398; Wed, 9 Sep 2026 06:01:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1413009.1643294 (Exim 4.92) (envelope-from ) id 1x4Huw-0007Ug-RM; Wed, 09 Sep 2026 13:00:46 +0000 Received: by outflank-mailman (output) from mailman id 1413009.1643294; Wed, 09 Sep 2026 13:00:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4Huw-0007UZ-Oq; Wed, 09 Sep 2026 13:00:46 +0000 Received: by outflank-mailman (input) for mailman id 1413009; Wed, 09 Sep 2026 13:00:45 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4Huv-0007U9-Cl for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 13:00:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x4Huu-00GvQy-Ps for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 15:00:44 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aa15878-bab6-0a2a0a5309dd-0a2a4505ae82-14 for ; Wed, 09 Sep 2026 15:00:44 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aa1587c-4cb1-0a2a45050019-d155802ad0fb-3 for ; Wed, 09 Sep 2026 15:00:44 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49b392ccaacso84559025e9.2 for ; Wed, 09 Sep 2026 06:00:44 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cfbdacc45sm443341775e9.11.2026.09.09.06.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 06:00:43 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788958844; x=1789563644; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=2hiugmH/DfrkMOq2Rrm79IM9Vi54MWLDW0uP3xzNUMw=; b=O59Mh62IrcM7NczrKaQbC8ZS7fQ9R4IrhfEKLKb3olmsvJ6nmr8H+oBl2ZE3LCv88e VLNCssv1PXwEYm62mnQ6U9J/Bv8Z76EN+7YzErjFXiGTje4IgzDuNP7vYjNdieUgcABi y4PZ2RAqwtQCGqxDIJyFT9Hti+B9Y+bAaMF1knZNgoBkeTpbK6+xdo5amgRlcEjkh+eT 05jcrPMl+kzaud9iWd3JQNOHhG+rq+8ChZLRpzFmt1Nf9rO7UOPqpbDJdxYO5l1Z7pYc 71sJ0R0DHC7Bn1lK1g2grh1i+MPpgYybIXjiUTsEFheZ0io6RjuzANjkpHXp4rsl2Ca1 AxvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788958844; x=1789563644; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=2hiugmH/DfrkMOq2Rrm79IM9Vi54MWLDW0uP3xzNUMw=; b=Lt23S2cXQ/8sX3SiElPjLUw8tTKVixe5+3eo8TJ3U+MyJw6lpMG51C0+8sE8mq+CT+ l0F0gmadZCT+gUBuln8lz6Y4aSso8+HhyDWmgIRFMU/JUYetNGOGVsWZjHPAsgrk5MNR JzQg8gNVNa7gWl+OYnT1AJaBJ0gt4Gui7x5LicqY4dtpqIyUHHK66QuxyM9lgJWBW7u4 UON8DIIBBerInoH1H6NZQ+Q7OlI1KLe65iIB3fpGa1W2vPkbTa4f2dBthUaxK8Y16Nrg PAELfuuRQP4+UqqAf1v7bsS1Id02E+txBZuLG0faLZdnaFcOszqlfSQHeplPHbpXqW6q eJxw== X-Gm-Message-State: AFuF++le/TWNnGFCQqkxC6RIMqttCXvvbU1GczLgeJBpNA448J5P29J9 usoCPMol/0y+VXFf9PbW/iOUpxbQ8ovdWu5Cz9hbQ7hqkgQmDHXy1h9rLifpenQAJq64blLucfz 6tQLgPA== X-Gm-Gg: AYBFou1O9C4JAI+ngXmiIUnnMeBxYLeOrwPyRDIUc3hsUQbhyoEbBNUvcWD5W+yea8z rUbhZ8h+pnSut9zcBO1/Rhg6vZ1tf1opDW31AYaNo3i/9BhKP+zMCUYf0YIhIMJqvBw0DAPdayg GpRCa8C0zEn4Amx27ampa7uu0xX+zuH/5TaFVG1u6mCAAf7aUEZvVaBx5tcqcpQaH8b++AOHlgO O00GfI+GaRuLsGMnDtCGSYrxIXoemU55GAiYK7lL+ijhPyPSQdFIZufXB1J+IGQBbBiGaoXnlA0 8Jkl0GviSIYw+fVkRnGJO1NlKtgKgu7v/Z7LQRkmW4qkFURsddt5FqYSHs9oYu01TDK+Lx2Dxxq 3Lf0B9AFeyV1jZT3WJUrxfGgDmRyZgaYnA5/7CgHGlOP7fGEyxXDJJ7TZ0LN/PmdCfoAydAyWJ4 1HBnI0W9TQ5I0tEcJUl6mHHGZjuDQZnrBxEAo93jovMLp65CzBmBDp/5pZb4h3GdG08nTQnXyRo 7NLPY8Ct7nq+fKzTlNW9UGCZrST5X1WqWqYQ0v7kg3ixOvrSWb1me2oosE8FXY= X-Received: by 2002:a05:600c:3b18:b0:49c:fa21:1c8a with SMTP id 5b1f17b1804b1-49cfa211d97mr298047735e9.31.1788958843949; Wed, 09 Sep 2026 06:00:43 -0700 (PDT) Message-ID: <6fe2a230-4c36-48ce-93c0-ee8d75500d3a@suse.com> Date: Wed, 9 Sep 2026 15:00:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/6] x86/cpufreq: annotate Eclair false-positives for rule 18.2 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Nicola Vetrini References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c201ff/1788958844-724B42A1-9A133E62/0/0 X-purgate-type: clean X-purgate-size: 1941 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788958869697158500 Content-Type: text/plain; charset="utf-8" "Subtraction between pointers shall only be applied to pointers that address elements of the same array" is not violated here. Elsewhere, on simple "e - s" Eclair manages to notice this; apparently "(end ?: e)" is too complex ("end" being derived from "s" a few lines earlier). Suggested-by: Nicola Vetrini Signed-off-by: Jan Beulich --- As per Nicola Eclair 16.0.0 has this fixed. --- a/docs/misra/false-positive-eclair.json +++ b/docs/misra/false-positive-eclair.json @@ -3,6 +3,13 @@ "content": [ { "id": "SAF-0-false-positive-eclair", + "violation-id": "MC3A2.R18.2", + "tool-version": "3.14.0", + "name": "Rule 18.2: pointer subtraction", + "text": "Cmdline parsing start/end pointers point into the sam= e array" + }, + { + "id": "SAF-1-false-positive-eclair", "violation-id": "", "tool-version": "", "name": "Sentinel", --- a/xen/arch/x86/acpi/cpufreq/amd-cppc.c +++ b/xen/arch/x86/acpi/cpufreq/amd-cppc.c @@ -67,6 +67,7 @@ int __init amd_cppc_cmdline_parse(const { printk(XENLOG_WARNING "cpufreq/amd-cppc: option '%.*s' not recognized\n", + /* SAF-0-false-positive-eclair s, e, and end point into= the cmdline array */ (int)((end ?: e) - s), s); =20 return -EINVAL; --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -85,6 +85,7 @@ int __init hwp_cmdline_parse(const char if ( !hwp_handle_option(s, end) ) { printk(XENLOG_WARNING "cpufreq/hwp: option '%.*s' not recogniz= ed\n", + /* SAF-0-false-positive-eclair s, e, and end point into= the cmdline array */ (int)((end ?: e) - s), s); =20 return -EINVAL; From nobody Thu Sep 24 19:40:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788958880; cv=none; d=zohomail.com; s=zohoarc; b=F3+cqfNOhlYLmoJJEFvqTTcsIivwI6P0jZXcBoN0m2AAuUBFwINtUf3XFMtgY2t9tYJ4y+g+DN0S7iTaK5wbsx10OQKbMP/JX8wKuQNKHuhGpHvHfqTI3JEEM8Lfr2iijoHninu9/QEpYFdwelRYGhmxGKYpqTjpMlGdo6K56Aw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788958880; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RIlpRmcgmO+OHiE8JCj69D3pFRhEmMDX/T6up7aFl3o=; b=WZ16SsGpcvPAsqYDHq+NnJ+x38xiYzw/LigYE9dk4/Fnkos7MZCC5WFfZpheKcKZwyow8Cc0ZhM+1rJW52s/Aa+aBXmmWs3lPqqUBJeKp2Q7dqWJdCSxNlvhahaoMgvoPXLQ+b7aUtqu9vJUtIsN1xUX8LXgqIrX3qaMPez/DHw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788958880167946.8224725870983; Wed, 9 Sep 2026 06:01:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1413013.1643302 (Exim 4.92) (envelope-from ) id 1x4HvI-0007si-22; Wed, 09 Sep 2026 13:01:08 +0000 Received: by outflank-mailman (output) from mailman id 1413013.1643302; Wed, 09 Sep 2026 13:01:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4HvH-0007sZ-Vf; Wed, 09 Sep 2026 13:01:07 +0000 Received: by outflank-mailman (input) for mailman id 1413013; Wed, 09 Sep 2026 13:01:06 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4HvG-0007rs-6S for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 13:01:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x4HvF-005AXD-JE for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 15:01:05 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aa15887-2eae-0a2a0a5409dd-0a2a4505b5de-44 for ; Wed, 09 Sep 2026 15:01:05 +0200 Received: from [209.85.221.54] (helo=mail-wr1-f54.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aa15891-4cb1-0a2a45050019-d155dd36d5a1-3 for ; Wed, 09 Sep 2026 15:01:05 +0200 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-482f2ee53e7so4308877f8f.1 for ; Wed, 09 Sep 2026 06:01:05 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4859162f354sm36448884f8f.20.2026.09.09.06.01.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 06:01:04 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788958865; x=1789563665; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=RIlpRmcgmO+OHiE8JCj69D3pFRhEmMDX/T6up7aFl3o=; b=MJXRQgADLxW7XGDeadnxnsR+6jrttTbdcOkAPL/BfERs684KpfF1GDp4LaH6FptC+Z 9eyKo8rQv02Rev8qhsoAHyJKW+gJHKtWVoEBsB/oTfj6rGtSFd9ei2pf+wH5znz2RSIX DPqakSKhC9+MRFyQOtyg5HjmzpPfG7OIzUj5Q8bZLjLc04g4nBHl9ZCPMzbgkNi3soCh BIP1wrU6DkeUQ9+r7IB9wUbaAWCOr2UQVqkRt2qmVSX235zzqSlfDpnRvoOcX9q6CJZe MZ86O4lcpP8uVKQZWDqoeq2fm7VFoQBt8qfxcPxn3eJ5FekVp6lG7wIlDFWu12lRjuUE uVsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788958865; x=1789563665; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=RIlpRmcgmO+OHiE8JCj69D3pFRhEmMDX/T6up7aFl3o=; b=XzCLUgistFGxUWFA0ovMWbZDjw5FbTIaNutQtCLy5BCX6CTmdH4bLh8IBfNI/1AGBw oLDwwrAj5VR398VdbOtuxu/NieWNQmPlk5W6jOU8vhPHrfPcCZfxTxbQCm2rasCMdi3e 1zn004++PwjgC/m3It+plVvTGHfd7MXANizyjc7f3FT1ocm+OBf3bjdcTeS/kqR+jwuG U29LS1aIrF3eQQqEocRJFD4IbNqT6P9MQTZPUR2hoFC4JPZMeOXBVpMq0HQX/REbJrV5 DvEzB+TPsRUTQ+1uSNxZw6M1KxBc818XBbITVrK1/TSuV1K4RQo7r3OuPY+bJ1/g/63r AHww== X-Gm-Message-State: AFuF++mB13+RPpGEL1pSERPbnT42B0zAk+Uey4EjltVNCbVi/+kOAOY7 xYX0pcmWWKQoQHh5lwh1+J1cmoLDE13PedQIGHBioYytXpSb7Si3/HnYoCqz9nT2CNWplbZIoGU YWK/nHg== X-Gm-Gg: AYBFou2s0NlvcYpcNINXm/wNstmxm9tHuDwO/OMgKQmG+uUGbFWfkI+SPKzHFce8sBs /2prFGURtBcvJr8szR4B/zbB0MFWVcct2V24UryvFyEJyUXl+9z2wKcwTG+pmiliTFncLdEE2DE Gr5nOBh3sr/1RwUrOsRu8VT3v86ucgmqGZSsq+DWwl4aTvrK8mLpc9dk1+J9948vOefg4gXMogT 7PxwUe2RdWPwIuF60p0DYVipFrFOIPnxkXtTdG18oSFeYDBcHvobqAMhYi+oRB1UbJ/jTRF2Q66 MGtDEldddofudLIPT1g/zQo1mF+owz9LQLrxUxypoLvx9Y3bAHLS6HrI962CcCHz+kUiiK6oHrS x+HbPeRXWBPXtO0cPuH0pzg/9cUsNOaO95fFwGPoUlIDSUaL+vriaeDG5fDVz+zq9wElpy37pGy zhdrsZ2p1h86ctXbDVvYU8RJnwjLjhaPa0i/op+J/qOY5lZWH+X2RBAmdAiTPppFVgjrvy72cGo VLmGoy/PTTyiTchBtR5KlEeDu2MxGvd6J9M+S4RUKuHjLwkz1G7XljfcCn5zWA= X-Received: by 2002:a05:6000:2584:b0:482:b813:8315 with SMTP id ffacd0b85a97d-485872ac3b1mr39548042f8f.21.1788958864913; Wed, 09 Sep 2026 06:01:04 -0700 (PDT) Message-ID: <08038aa9-6902-4070-b49c-0a9ff113c786@suse.com> Date: Wed, 9 Sep 2026 15:01:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 5/6] x86/Viridian: annotate Eclair false-positives for rule 18.2 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Nicola Vetrini References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c201ff/1788958865-F4EA12A1-AA17D865/0/0 X-purgate-type: clean X-purgate-size: 1863 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788958882676158500 Content-Type: text/plain; charset="utf-8" "Subtraction between pointers shall only be applied to pointers that address elements of the same array" is not violated here: start_stimer() is only ever passed a sane argument, and stimer_expire() is either called from start_stimer() (using its parameter as argument) or as a callback, where a sane callback argument is also guaranteed to be set up. Suggested-by: Nicola Vetrini Signed-off-by: Jan Beulich --- As per Nicola Eclair 16.0.0 has this fixed. --- a/docs/misra/false-positive-eclair.json +++ b/docs/misra/false-positive-eclair.json @@ -10,6 +10,13 @@ }, { "id": "SAF-1-false-positive-eclair", + "violation-id": "MC3A2.R18.2", + "tool-version": "3.14.0", + "name": "Rule 18.2: pointer subtraction", + "text": "Viridian stimer index calculations use sane pointers" + }, + { + "id": "SAF-2-false-positive-eclair", "violation-id": "", "tool-version": "", "name": "Sentinel", --- a/xen/arch/x86/hvm/viridian/time.c +++ b/xen/arch/x86/hvm/viridian/time.c @@ -136,6 +136,7 @@ static void cf_check stimer_expire(void struct viridian_stimer *vs =3D data; struct vcpu *v =3D vs->v; struct viridian_vcpu *vv =3D v->arch.hvm.viridian; + /* SAF-1-false-positive-eclair vs is always sane */ unsigned int stimerx =3D vs - &vv->stimer[0]; =20 set_bit(stimerx, &vv->stimer_pending); @@ -146,6 +147,7 @@ static void start_stimer(struct viridian { const struct vcpu *v =3D vs->v; struct viridian_vcpu *vv =3D v->arch.hvm.viridian; + /* SAF-1-false-positive-eclair vs is always sane */ unsigned int stimerx =3D vs - &vv->stimer[0]; int64_t now =3D time_ref_count(v->domain); int64_t expiration; From nobody Thu Sep 24 19:40:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788959395; cv=none; d=zohomail.com; s=zohoarc; b=MM8jm/AotxT38zZsVlzrn9lhi6bK++n36anTgAGqiWdBynL+icoSAdk76wQQ9z1P+kl6jMOR3+CbK2yXUvP3/qWH367HR436L1NVBWYjBK8gS4CvkAA9/KC0BSig3B26B8TwL89njP9D/95BRIcAtIy3oaaX9LyDiiLhbR6iAkE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788959395; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GEucQ5HDVmg61mzKURTSDX41DOGEMC5gWDJ5N9xWUyc=; b=RlMi/ad7mScSdlTTDeQWan5AonKMLt5h1kXqTLweJLoRZoosjl+s7dFixSmXUwBkmcc/scjx+GNIO6m8HMOgBcntFIdKy7zcjv3zLW/9eDKWACITUWz4Y5lTVgbX+Pdxomu5aVkXJdVYN4pxXwRQSFT/tqo2mt6sxexJ32Mmyxk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788959395691509.97488029050885; Wed, 9 Sep 2026 06:09:55 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1413051.1643311 (Exim 4.92) (envelope-from ) id 1x4I3R-00013w-Tc; Wed, 09 Sep 2026 13:09:33 +0000 Received: by outflank-mailman (output) from mailman id 1413051.1643311; Wed, 09 Sep 2026 13:09:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4I3R-00013p-R5; Wed, 09 Sep 2026 13:09:33 +0000 Received: by outflank-mailman (input) for mailman id 1413051; Wed, 09 Sep 2026 13:09:32 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x4I3Q-00013e-LC for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 13:09:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x4I3P-002OaV-Jg for xen-devel@lists.xenproject.org; Wed, 09 Sep 2026 15:09:31 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aa15a8a-e002-0a2a0a5209dd-0a2a4504bb0c-4 for ; Wed, 09 Sep 2026 15:09:31 +0200 Received: from [74.125.228.140] (helo=mail-ej2-f12.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aa15a8b-b57f-0a2a45040019-4a7de48cb203-3 for ; Wed, 09 Sep 2026 15:09:31 +0200 Received: by mail-ej2-f12.google.com with SMTP id a640c23a62f3a-c254fa663c1so20678866b.0 for ; Wed, 09 Sep 2026 06:09:31 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d1fd532dcsm54775715e9.1.2026.09.09.06.01.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 06:01:55 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788959371; x=1789564171; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=GEucQ5HDVmg61mzKURTSDX41DOGEMC5gWDJ5N9xWUyc=; b=Q3zNq+bFV0bFs0awn5kL0X+utm8IRwPlSuWI5ZVGPA8fbZWjIRY2gfjlIRUNtg07oW 4/Rs4J67T8C4cuJ/AetJPwBgbMumMUD45xEXHvIkEW6WSzBTDptE4NaFeaqUYOyMhbVu HNw6/nbmD1Dp9BjnKPDbwotg6u77gh5bkgAgmRgGG4gjNFtcPX1FgpJjsBuwy02NFkwr MaTkpBkpaCz3GYcniB7LrYIUmU4hM5TgVp613tCZf6g1CDjhsiL/1HTPHTjnShpuZeFl 6tvvEtB6azxHn1ol5jOUy/+FuGZPIpYMaiBQkBae5CEr6U7sgw1XeML5t/JaBcH6N+9U Wr1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788959371; x=1789564171; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=GEucQ5HDVmg61mzKURTSDX41DOGEMC5gWDJ5N9xWUyc=; b=KViceom6U5XD94jy9yZDh1QpB0NhFMnNM2QHDX57ws1y9wnDvIlhO7p9CnqmxEDDJs qHZPfrN72MUlnHYqihtim3fMZUk8A3LvMafTh8BzSqs8TArFLCp/GO5pJ9iwRxLYwRbs uXs4bNCVnBcC/61fUDX7iTa9Lfb9OpUMI4c0kF6ejrr31eXHZmyuJlCeH6dna+fKi9e3 WWU++UsKmvGwHdaXq5LjxN8XuKa6EZ9R+pnd7iy8dD44IUPfLEmZvG5UQori2/Q2qwEx NaDS9ispObRDdr2qxkJus1rL1lqprBVQcSi3jiuu8iTToTPx2BqU+ja1T440irnpri2C aGrw== X-Gm-Message-State: AFuF++kkoLPx69DG49LfWQ5AIQWGqKcpodPVrctosDOdjuHpt6fRXhOc B4wyQmoRwMrVVpXRUzNhcbSRukM2HKKSoHaZhWCHTXUM6Cqb0zdDnJFyyoWtlzrTF/I4y/r2Eoz dFMFb1Q== X-Gm-Gg: AYBFou0OPxvpSPgT+9c9lw8gQfP/+De5tP6nH593/fh3sJ8LuLenjKuxWXvWW5wBiGH mQQS+UL+Cx861G9sA8X4huLUyvB24RzMVgvLV9yQ7L+w5Daab0DPK4gj9bDlEp9VwyelLPOmCzc 7ZA4ScsXgAjn8QojQivWT+Xh6PH9cdVv9/ZCM8kdw5/nK3VSMmOu+nAx1jj8fD4Q1oX72UqiyNc cm4HVlcRusnfd7D2t1L+R96zQAScB+g6McxeFdBb7NGbtFEJlCSnC8wN3NJNdmJDE+zoTAi4meN b4xSsnwOuFi4Jtc6SHZz94e8DLRojyJceLlXJOyowNRimceJOVHUi8rLhA7UQZGaolp/zKDlxn7 XQQmnHXBAzeFUQaMxaC9wKsNGz1KCDIUDftvKBtHPbQhIEKTBaUWU/K0ai313kQVL8snN/z8w41 MDwJc36HGdiFMyXHkqTHjdP4jdq2CV78a70ZZk3Kkx29Mk02q+odQ35bHryg/rOPGF633sXsZvW p6AtM+W2/9/kJSfa9wrf+8ILH4wpVmXBGGkk+9sgDSbqiuPqnMfVzz0N5Tta9o= X-Received: by 2002:a05:600c:45d5:b0:493:f140:c3fb with SMTP id 5b1f17b1804b1-49d258f1d5cmr17648745e9.7.1788958916303; Wed, 09 Sep 2026 06:01:56 -0700 (PDT) Message-ID: <486cf199-33fa-4373-965c-d59a782ae6d4@suse.com> Date: Wed, 9 Sep 2026 15:01:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 6/6] automation/Eclair: tag rules 18.1 and 18.2 as clean From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Nicola Vetrini References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ebf023/1788959371-C04DBB50-2D2A2FD0/0/0 X-purgate-type: clean X-purgate-size: 406 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788959397237158500 Content-Type: text/plain; charset="utf-8" Remaining (x86) 18.2 violations were addressed. 18.1 was already clean everywhere. Signed-off-by: Jan Beulich Acked-by: Stefano Stabellini --- a/automation/eclair_analysis/ECLAIR/tagging.ecl +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl @@ -80,6 +80,8 @@ MC3A2.R17.3|| MC3A2.R17.4|| MC3A2.R17.5|| MC3A2.R17.6|| +MC3A2.R18.1|| +MC3A2.R18.2|| MC3A2.R18.6|| MC3A2.R18.8|| MC3A2.R19.1||