From nobody Mon Feb 9 21:40:23 2026 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1570630890; cv=none; d=zoho.com; s=zohoarc; b=EMZOSz9Hgyo1BoKFIxbbEsyG2ymffy+W+suRQ/lpnTcM7/edu9BBgkUGv7Fj0bBx0pzCzs4QuVLAca20ODjKbLp7cO8JFnko/1x/bugme0FhqY3fAhWiathYY481FnI5z9CymykpDffOEKOyLRbBaC1QY5JP9YFMynud8dnvWZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570630890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h2RiSx2Iiw+wqcNrwZ6XRH3tFhPkOdfYRjrgtw35H18=; b=jrGzKKzvixxZ4wHpMWnHZop0BzsPdh2BnUCsD5Bc0QLke2xegHKLme62BYTQsX8/q5aCosK6vDURSpJ/LMg7OrxrTrsAMJZsUzuj23tswLgclZZK0Jaci3jNxUz0voTn1Wr4E0qyrwWmInilJuOTdgmVHmCWwx/OJ2+CHnObHl4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1570630890099585.0000716437316; Wed, 9 Oct 2019 07:21:30 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iICpP-0007V5-J3; Wed, 09 Oct 2019 14:20:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iICpN-0007US-Ml for xen-devel@lists.xenproject.org; Wed, 09 Oct 2019 14:20:33 +0000 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id efd55e20-ea9f-11e9-80e3-bc764e2007e4; Wed, 09 Oct 2019 14:20:26 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id f5so2680728ljg.8 for ; Wed, 09 Oct 2019 07:20:26 -0700 (PDT) Received: from EPUAKYIW0594.kyiv.epam.com (ll-74.141.223.85.sovam.net.ua. [85.223.141.74]) by smtp.gmail.com with ESMTPSA id i142sm526702lfi.5.2019.10.09.07.20.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 07:20:23 -0700 (PDT) X-Inumbo-ID: efd55e20-ea9f-11e9-80e3-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ymknUH33Rb304RHiPhugySmwwZfHcvQEz4Gc9cR3kzs=; b=TyEkZZc7KLZ7vLnhxPb7d3+md3FwkBDIr070bOPKHI2BKuBvsRzjX6JmcwiV2YjXvr pCFNz+SAtNm8ueOyMenJRz4FnKKbWTOvj3/10pdX0ZrycNIfSs2DJjNBAve7h+bdgvx5 kMdmOmB9N9DNBQg5gjEf65/qI0eDy0hDmChG61BhIbhvaKHfm/Qfn11WIhiJtoMkvt6F VC2tCTEaIwH+wQobhWasI54GfMxXApBu5hJbRJ9UsBoOB8X8h7SyNGbRk5thGJHgcAoG jKBPnpxlSlsQnfjVw+bo1Xo4I47wgtauNUbihXffnHK57b+UzkHv+jv1db+tvd8m7Esi aJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ymknUH33Rb304RHiPhugySmwwZfHcvQEz4Gc9cR3kzs=; b=YJncX4kEO2hwwPIMCef5yW6XqXiKXNdNE86hPYj2oG85wvShiyiYhiVoZEUZBe6G5w kAEAZtI6xvhcCGOEJeyHIW7fvGPjUEQDH5uHiaEchc7tUu1CE8Jm+7qxCwC8b+QxG0Db uBcQ285tygPLAO4waV3UUQwbMngEIQlaJF3de7sgtA794++zktKRz3TAY5xfXFgbd2zc HQI/v0Ej+h2jvg+SLPkpr5kAOFiX4BU4LiFn7iDB3Cgz7Q2LS/6e37wRWv7Ly6u3/G2w mdf3Q8I76NPXbG8Oehr3xV0O62jW8A/aNIcPkJjiR9kW6PlQph9d1Dm6vbDv3qj2Mx2s paOg== X-Gm-Message-State: APjAAAVGTS3i7SpYbHOuNO6sXDMocXfmjSZ82TsJs6BZ9gWXYd3FjXpn tztAs2wOFpLRRAwa8VhokEgdoXCVcca5VQ== X-Google-Smtp-Source: APXvYqx3EwmXWBXQ7J7TctRrteRPwO0+dyyFwa7GuYX/5e1+IdEI9Q+GyjO9T0rIfkBgXM9QrUkmyA== X-Received: by 2002:a2e:9759:: with SMTP id f25mr2560650ljj.173.1570630824242; Wed, 09 Oct 2019 07:20:24 -0700 (PDT) From: Artem Mygaiev To: xen-devel@lists.xenproject.org Date: Wed, 9 Oct 2019 17:20:16 +0300 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/3] Remove useless ASSERT condition X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Artem Mygaiev , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Artem Mygaiev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) cnt is unsigned, so always >=3D0 Coverity-ID: 1381848 Signed-off-by: Artem Mygaiev Acked-by: Julien Grall --- xen/drivers/char/scif-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c index fa0b8274ca..9d3f66b55b 100644 --- a/xen/drivers/char/scif-uart.c +++ b/xen/drivers/char/scif-uart.c @@ -205,7 +205,7 @@ static int scif_uart_tx_ready(struct serial_port *port) =20 /* Check number of data bytes stored in TX FIFO */ cnt =3D scif_readw(uart, SCIF_SCFDR) >> 8; - ASSERT( cnt >=3D 0 && cnt <=3D params->fifo_size ); + ASSERT( cnt <=3D params->fifo_size ); =20 return (params->fifo_size - cnt); } --=20 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel